[PATCH] drm/i915/gem: Add a check for object size for corner cases

2021-02-09 Thread Anand Moon
Add check for object size to return appropriate error -E2BIG or -EINVAL to avoid WARM_ON and sucessfull return for some testcase. Cc: Chris Wilson Cc: Matthew Auld Signed-off-by: Anand Moon --- VLK-17702: Since these object size is U64 these corner case will not come into real test senario. IG

Re: [RFC PATCH 8/9] drm/gem: Associate GEM objects with drm cgroup

2021-02-09 Thread Thomas Zimmermann
Hi Am 09.02.21 um 11:54 schrieb Daniel Vetter: *: vmwgfx is the only non-gem driver, but there's plans to move at least vmwgfx internals (maybe not the uapi, we'll see) over to gem. Once that's done it's truly all gpu memory. Do you have a URL to the discussion? While I recent worked on GEM,

[PATCH -next] drm/rockchip: cdn-dp: Mark cdn_dp_resume as __maybe_unused

2021-02-09 Thread Wei Yongjun
The function cdn_dp_resume() may have no callers depending on configuration, so it must be marked __maybe_unused to avoid harmless warning: drivers/gpu/drm/rockchip/cdn-dp-core.c:1124:12: warning: 'cdn_dp_resume' defined but not used [-Wunused-function] 1124 | static int cdn_dp_resume(struct dev

[nouveau] WARNING: possible circular locking dependency detected in linux-next

2021-02-09 Thread Alexander Kapshuk
-next-20210209 #142 Tainted: GW [ 57.207497] -- [ 57.207508] Xorg/459 is trying to acquire lock: [ 57.207521] 888016edc518 (&cli->mutex){+.+.}-{3:3}, at: nouveau_bo_move+0x4bf/0x2

Re: [PATCH 0/3] drm/ttm: constify static vm_operations_structs

2021-02-09 Thread Christian König
Reviewed-by: Christian König for the series. Am 10.02.21 um 00:48 schrieb Rikard Falkeborn: Constify a few static vm_operations_struct that are never modified. Their only usage is to assign their address to the vm_ops field in the vm_area_struct, which is a pointer to const vm_operations_struct

RE: [RFC v3 2/3] virtio: Introduce Vdmabuf driver

2021-02-09 Thread Kasireddy, Vivek
Hi Gerd, > -Original Message- > From: Gerd Hoffmann > Sent: Tuesday, February 09, 2021 12:45 AM > To: Kasireddy, Vivek > Cc: Daniel Vetter ; > virtualizat...@lists.linux-foundation.org; dri- > de...@lists.freedesktop.org; Vetter, Daniel ; > daniel.vet...@ffwll.ch; Kim, Dongwon ; > sumit

Re: [PATCH 1/9] mm/migrate.c: Always allow device private pages to migrate

2021-02-09 Thread Alistair Popple
On Wednesday, 10 February 2021 12:39:32 AM AEDT Jason Gunthorpe wrote: > On Tue, Feb 09, 2021 at 12:07:14PM +1100, Alistair Popple wrote: > > Device private pages are used to represent device memory that is not > > directly accessible from the CPU. Extra references to a device private > > page are

linux-next: build failure after merge of the drm-misc tree

2021-02-09 Thread Stephen Rothwell
error=incompatible-pointer-types] 390 | .timedout_job = v3d_generic_job_timedout, | ^~~~ drivers/gpu/drm/v3d/v3d_sched.c:390:18: note: (near initialization for 'v3d_cache_clean_sched_ops.timedout_job') Caused by commit c10983

Re: [PATCH] drm/msm: fix a6xx_gmu_clear_oob

2021-02-09 Thread Jordan Crouse
On Mon, Feb 08, 2021 at 01:55:54PM -0500, Jonathan Marek wrote: > The cleanup patch broke a6xx_gmu_clear_oob, fix it by adding the missing > bitshift operation. > > Fixes: 555c50a4a19b ("drm/msm: Clean up GMU OOB set/clear handling") > Signed-off-by: Jonathan Marek Thanks. I feel silly that I m

[PATCH v2] drm/msm: a6xx: Make sure the SQE microcode is safe

2021-02-09 Thread Jordan Crouse
Most a6xx targets have security issues that were fixed with new versions of the microcode(s). Make sure that we are booting with a safe version of the microcode for the target and print a message and error if not. v2: Add more informative error messages and fix typos Signed-off-by: Jordan Crouse

Re: [RFC][PATCH v6 1/7] drm: Add a sharable drm page-pool implementation

2021-02-09 Thread Suren Baghdasaryan
On Tue, Feb 9, 2021 at 12:03 PM Daniel Vetter wrote: > > On Tue, Feb 9, 2021 at 6:46 PM Christian König > wrote: > > > > > > > > Am 09.02.21 um 18:33 schrieb Suren Baghdasaryan: > > > On Tue, Feb 9, 2021 at 4:57 AM Christian König > > > wrote: > > >> Am 09.02.21 um 13:11 schrieb Christian Köni

[PATCH] Revert "drm/atomic: document and enforce rules around "spurious" EBUSY"

2021-02-09 Thread Manasi Navare
This reverts commit fb6473a48b635c55d04eb94e579eede52ef39550. These additional checks added to avoid EBUSY give unnecessary WARN_ON in case of big joiner used in i915 in which case even if the modeset is requested on a single pipe, internally another consecutive pipe is stolen and used to drive ha

[PATCH 1/3] drm/amdgpu/ttm: constify static vm_operations_struct

2021-02-09 Thread Rikard Falkeborn
The only usage of amdgpu_ttm_vm_ops is to assign its address to the vm_ops field in the vm_area_struct struct. Make it const to allow the compiler to put it in read-only memory. Signed-off-by: Rikard Falkeborn --- drivers/gpu/drm/amd/amdgpu/amdgpu_ttm.c | 2 +- 1 file changed, 1 insertion(+), 1

[PATCH 2/3] drm/radeon/ttm: constify static vm_operations_struct

2021-02-09 Thread Rikard Falkeborn
The only usage of radeon_ttm_vm_ops is to assign its address to the vm_ops field in the vm_area_struct struct. Make it const to allow the compiler to put it in read-only memory Signed-off-by: Rikard Falkeborn --- drivers/gpu/drm/radeon/radeon_ttm.c | 2 +- 1 file changed, 1 insertion(+), 1 delet

[PATCH 3/3] drm/nouveau/ttm: constify static vm_operations_struct

2021-02-09 Thread Rikard Falkeborn
The only usage of nouveau_ttm_vm_ops is to assign its address to the vm_ops field in the vm_area_struct struct. Make it const to allow the compiler to put it in read-only memory Signed-off-by: Rikard Falkeborn --- drivers/gpu/drm/nouveau/nouveau_ttm.c | 2 +- 1 file changed, 1 insertion(+), 1 de

Re: [PATCH v3 1/2] drm/aspeed: Look up syscon by phandle

2021-02-09 Thread Andrew Jeffery
On Tue, 9 Feb 2021, at 23:07, Joel Stanley wrote: > This scales better to multiple families of SoC. The lookup by compatible > can be removed in a future change. > > The fallback path is for the ast2500 platform only. Other platforms will > be added with the new style, so they won't need fallba

[PATCH 0/3] drm/ttm: constify static vm_operations_structs

2021-02-09 Thread Rikard Falkeborn
Constify a few static vm_operations_struct that are never modified. Their only usage is to assign their address to the vm_ops field in the vm_area_struct, which is a pointer to const vm_operations_struct. Make them const to allow the compiler to put them in read-only memory. With this series appli

[PATCH] drm/msm: a6xx: Make sure the SQE microcode is safe

2021-02-09 Thread Jordan Crouse
Most a6xx targets have security issues that were fixed with new versions of the microcode(s). Make sure that we are booting with a safe version of the microcode for the target and print a message and error if not. Signed-off-by: Jordan Crouse --- drivers/gpu/drm/msm/adreno/a6xx_gpu.c | 67 +

Re: [RFC][PATCH v6 1/7] drm: Add a sharable drm page-pool implementation

2021-02-09 Thread Suren Baghdasaryan
On Tue, Feb 9, 2021 at 9:46 AM Christian König wrote: > > > > Am 09.02.21 um 18:33 schrieb Suren Baghdasaryan: > > On Tue, Feb 9, 2021 at 4:57 AM Christian König > > wrote: > >> Am 09.02.21 um 13:11 schrieb Christian König: > >>> [SNIP] > >> +void drm_page_pool_add(struct drm_page_pool *pool

[PATCH] drm: use getter/setter functions

2021-02-09 Thread Julia Lawall
Use getter and setter functions, for platform_device structures and a mipi_dsi_device structure. Signed-off-by: Julia Lawall --- drivers/gpu/drm/aspeed/aspeed_gfx_drv.c |2 +- drivers/gpu/drm/bridge/cadence/cdns-mhdp8546-core.c |2 +- drivers/gpu/drm/panel/panel-lvds.c

[PATCH] video: use getter/setter functions

2021-02-09 Thread Julia Lawall
Use getter and setter functions, for platform_device structures and a spi_device structure. Signed-off-by: Julia Lawall --- drivers/video/backlight/qcom-wled.c |2 +- drivers/video/fbdev/amifb.c |4 ++-- drivers/

Re: [RESEND][PATCH] drm/tilcdc: send vblank event when disabling crtc

2021-02-09 Thread Jyri Sarha
On 2021-02-09 10:24, quanyang.w...@windriver.com wrote: From: Quanyang Wang When run xrandr to change resolution on Beaglebone Black board, it will print the error information: root@beaglebone:~# xrandr -display :0 --output HDMI-1 --mode 720x400 [drm:drm_crtc_commit_wait] *ERROR* flip_done tim

Re: [RFC][PATCH v6 1/7] drm: Add a sharable drm page-pool implementation

2021-02-09 Thread Suren Baghdasaryan
On Tue, Feb 9, 2021 at 4:57 AM Christian König wrote: > > Am 09.02.21 um 13:11 schrieb Christian König: > > [SNIP] > +void drm_page_pool_add(struct drm_page_pool *pool, struct page *page) > +{ > + spin_lock(&pool->lock); > + list_add_tail(&page->lru, &pool->items); > >>

[PATCH v5 4/4] drm/i915/gen9_bc: Add W/A for missing STRAP config on TGP PCH + CML combos

2021-02-09 Thread Lyude Paul
Apparently the new gen9_bc platforms that Intel has introduced don't provide us with a STRAP config register to read from for initializing DDI B, C, and D detection. So, workaround this by hard-coding our strap config in intel_setup_outputs(). Changes since v4: * Split this into it's own commit C

[PATCH v5 3/4] drm/i915/gen9_bc: Introduce HPD pin mappings for TGP PCH + CML combos

2021-02-09 Thread Lyude Paul
Next, let's start introducing the HPD pin mappings for Intel's new gen9_bc platform in order to make hotplugging display connectors work. Since gen9_bc is just a TGP PCH along with a CML CPU, except with the same HPD mappings as ICL, we simply add a skl_hpd_pin function that is shared between gen9

[PATCH v5 2/4] drm/i915/gen9_bc: Introduce TGP PCH DDC pin mappings

2021-02-09 Thread Lyude Paul
With the introduction of gen9_bc, where Intel combines Cometlake CPUs with a Tigerpoint PCH, we'll need to introduce new DDC pin mappings for this platform in order to make all of the display connectors work. So, let's do that. Changes since v4: * Split this into it's own patch - vsyrjala Cc: Mat

[PATCH v5 1/4] drm/i915/gen9_bc: Recognize TGP PCH + CML combos

2021-02-09 Thread Lyude Paul
Since Intel has introduced the gen9_bc platform, a combination of Tigerpoint PCHs and CML CPUs, let's recognize such platforms as valid and avoid WARNing on them. Changes since v4: * Split this into it's own patch - vsyrjala Cc: Matt Roper Cc: Jani Nikula Cc: Ville Syrjala [originally from Tej

Re: [PATCH 0/9] Add support for SVM atomics in Nouveau

2021-02-09 Thread Jerome Glisse
On Tue, Feb 09, 2021 at 09:35:20AM -0400, Jason Gunthorpe wrote: > On Tue, Feb 09, 2021 at 11:57:28PM +1100, Alistair Popple wrote: > > On Tuesday, 9 February 2021 9:27:05 PM AEDT Daniel Vetter wrote: > > > > > > > > Recent changes to pin_user_pages() prevent the creation of pinned pages > > > > i

[Bug 211425] [drm:atom_op_jump] *ERROR* atombios stuck in loop for more than 20secs aborting

2021-02-09 Thread bugzilla-daemon
https://bugzilla.kernel.org/show_bug.cgi?id=211425 --- Comment #6 from Andreas (icedragon...@web.de) --- (In reply to Alex Deucher from comment #5) > If this is a regression can you bisect? I can try to bisect at next weekend. -- You may reply to this email to add a comment. You are receiving t

Re: [PATCH 2/6] dt-bindings: display: rockchip-dsi: add optional #phy-cells property

2021-02-09 Thread Rob Herring
On Tue, 02 Feb 2021 15:56:28 +0100, Heiko Stuebner wrote: > From: Heiko Stuebner > > The Rockchip DSI controller on some SoCs also controls a bidrectional > dphy, which would be connected to an Image Signal Processor as a phy > in the rx configuration. > > So allow a #phy-cells property for the

Re: [PATCH v3 1/2] dt-bindings: panel: Add Samsung S6E3FA2 panel

2021-02-09 Thread Rob Herring
On Mon, 01 Feb 2021 18:53:05 +0200, Iskren Chernev wrote: > The Samsung S6E3FA2 AMOLED cmd LCD panel is used on the Samsung Galaxy > S5 (klte). > > Signed-off-by: Iskren Chernev > --- > Add a simple generated panel driver that supports on/off and the corresponding > binding documentation. > > Ch

Re: [PATCH 0/9] Add support for SVM atomics in Nouveau

2021-02-09 Thread John Hubbard
On 2/9/21 5:37 AM, Daniel Vetter wrote: On Tue, Feb 9, 2021 at 1:57 PM Alistair Popple wrote: On Tuesday, 9 February 2021 9:27:05 PM AEDT Daniel Vetter wrote: Recent changes to pin_user_pages() prevent the creation of pinned pages in ZONE_MOVABLE. This series allows pinned pages to be create

Re: [PATCH 2/3] dt-bindings: Add DT bindings for Displaytech DT050TFT-PTS

2021-02-09 Thread Rob Herring
On Sat, 30 Jan 2021 19:11:13 +0100, Marek Vasut wrote: > Add DT bindings for Displaytech DT050TFT-PTS 5.0" (800x480) > color TFT LCD panel, connected over DPI. > > Signed-off-by: Marek Vasut > To: dri-devel@lists.freedesktop.org > Cc: Rob Herring > Cc: Sam Ravnborg > Cc: devicet...@vger.kernel.

Re: [PATCH 1/3] dt-bindings: Add vendor prefix for Displaytech

2021-02-09 Thread Rob Herring
On Sat, 30 Jan 2021 19:11:12 +0100, Marek Vasut wrote: > The Displaytech Ltd. is an LCD panel manufacturer. > > Signed-off-by: Marek Vasut > To: dri-devel@lists.freedesktop.org > Cc: Eric Anholt > Cc: Rob Herring > Cc: Sam Ravnborg > Cc: devicet...@vger.kernel.org > --- > Documentation/device

Re: [PATCH 1/2] dt-bindings: drm/bridge: ti-sn65dsi83: Add TI SN65DSI83 bindings

2021-02-09 Thread Rob Herring
On Sat, Jan 30, 2021 at 07:10:13PM +0100, Marek Vasut wrote: > Add DT binding document for TI SN65DSI83 DSI to LVDS bridge. > > Signed-off-by: Marek Vasut > Cc: Douglas Anderson > Cc: Laurent Pinchart > Cc: Linus Walleij > Cc: Sam Ravnborg > Cc: Stephen Boyd > Cc: devicet...@vger.kernel.org

Re: [RFC][PATCH v6 1/7] drm: Add a sharable drm page-pool implementation

2021-02-09 Thread Daniel Vetter
On Tue, Feb 9, 2021 at 6:46 PM Christian König wrote: > > > > Am 09.02.21 um 18:33 schrieb Suren Baghdasaryan: > > On Tue, Feb 9, 2021 at 4:57 AM Christian König > > wrote: > >> Am 09.02.21 um 13:11 schrieb Christian König: > >>> [SNIP] > >> +void drm_page_pool_add(struct drm_page_pool *pool

[PATCH v2 2/2] dma-buf: heaps: Fix the name used when exporting dmabufs to be the actual heap name

2021-02-09 Thread John Stultz
By default dma_buf_export() sets the exporter name to be KBUILD_MODNAME. Unfortunately this may not be identical to the string used as the heap name (ie: "system" vs "system_heap"). This can cause some minor confusion with tooling, and there is the future potential where multiple heap types may be

[PATCH v2 1/2] dma-buf: dma-heap: Provide accessor to get heap name

2021-02-09 Thread John Stultz
It can be useful to access the name for the heap, so provide an accessor to do so. Cc: Daniel Vetter Cc: Sumit Semwal Cc: Liam Mark Cc: Chris Goldsworthy Cc: Laura Abbott Cc: Brian Starkey Cc: Hridya Valsaraju Cc: Suren Baghdasaryan Cc: Sandeep Patil Cc: Daniel Mentz Cc: Ørjan Eide Cc:

Re: [PATCH] drm/radeon: Simplify bool comparison

2021-02-09 Thread Alex Deucher
Applied. Thanks! Alex On Mon, Feb 8, 2021 at 5:17 AM Jiapeng Chong wrote: > > Fix the following coccicheck warning: > > ./drivers/gpu/drm/radeon/rs690.c:190:6-35: WARNING: Comparison to bool. > > Reported-by: Abaci Robot > Signed-off-by: Jiapeng Chong > --- > drivers/gpu/drm/radeon/rs690.c |

Re: [PATCH] drm/amd/display: Simplify bool comparison

2021-02-09 Thread Alex Deucher
Applied. Thanks! Alex On Mon, Feb 8, 2021 at 5:29 AM Jiapeng Chong wrote: > > Fix the following coccicheck warning: > > ./drivers/gpu/drm/amd/display/dc/inc/hw/clk_mgr_internal.h:319:11-23: > WARNING: Comparison to bool. > > Reported-by: Abaci Robot > Signed-off-by: Jiapeng Chong > --- > dri

Re: [PATCH] drm/amdgpu: fix unnecessary NULL check warnings

2021-02-09 Thread Alex Deucher
On Tue, Feb 9, 2021 at 3:44 AM Tian Tao wrote: > > Remove NULL checks before vfree() to fix these warnings: > drivers/gpu/drm/amd/amdgpu/amdgpu_cs.c:102:2-8: WARNING: NULL > check before some freeing functions is not needed. > > Signed-off-by: Tian Tao Applied. Thanks! Alex > --- > drivers/

Re: [PATCH v4 1/3] dt-bindings:drm/bridge:anx7625:add vendor define flags

2021-02-09 Thread Rob Herring
On Thu, Jan 28, 2021 at 11:08:26AM +0800, Xin Ji wrote: > Add 'bus-type' and 'data-lanes' define for port0, add HDCP support > flag and DP tx lane0 and lane1 swing register array define. > > Signed-off-by: Xin Ji > --- > .../bindings/display/bridge/analogix,anx7625.yaml | 54 >

Re: [PATCH] dt-bindings: mxsfb: Add interconnect bindings for LCDIF path

2021-02-09 Thread Rob Herring
On Wed, 27 Jan 2021 12:49:01 +0100, Martin Kepplinger wrote: > Add optional interconnect properties for the dram path requests. > > Signed-off-by: Martin Kepplinger > --- > Documentation/devicetree/bindings/display/fsl,lcdif.yaml | 8 > 1 file changed, 8 insertions(+) > Reviewed-by: R

Re: [PATCH v3 11/14] dt-bindings: display: bridge: Add i.MX8qm/qxp LVDS display bridge binding

2021-02-09 Thread Rob Herring
On Wed, 27 Jan 2021 16:51:25 +0800, Liu Ying wrote: > This patch adds bindings for i.MX8qm/qxp LVDS display bridge(LDB). > > Signed-off-by: Liu Ying > --- > v2->v3: > * Drop 'fsl,syscon' property. (Rob) > * Mention the CSR module controls LDB. > > v1->v2: > * Use graph schema. (Laurent) > * Side

Re: [PATCH v3 09/14] drm/bridge: imx: Add i.MX8qxp pixel link to DPI support

2021-02-09 Thread Rob Herring
On Wed, Jan 27, 2021 at 04:51:23PM +0800, Liu Ying wrote: > This patch adds a drm bridge driver for i.MX8qxp pixel link to display > pixel interface(PXL2DPI). The PXL2DPI interfaces the pixel link 36-bit > data output and the DSI controller’s MIPI-DPI 24-bit data input, and > inputs of LVDS Displa

[PATCH v3 5/5] drm/sun4i: dw-hdmi: Fix max. frequency for H6

2021-02-09 Thread Jernej Skrabec
It turns out that reasoning for lowering max. supported frequency is wrong. Scrambling works just fine. Several now fixed bugs prevented proper functioning, even with rates lower than 340 MHz. Issues were just more pronounced with higher frequencies. Fix that by allowing max. supported frequency i

[PATCH v3 4/5] drm/sun4i: Fix H6 HDMI PHY configuration

2021-02-09 Thread Jernej Skrabec
As it turns out, vendor HDMI PHY driver for H6 has a pretty big table of predefined values for various pixel clocks. However, most of them are not useful/tested because they come from reference driver code. Vendor PHY driver is concerned with only few of those, namely 27 MHz, 74.25 MHz, 148.5 MHz,

[PATCH v3 3/5] drm/sun4i: dw-hdmi: always set clock rate

2021-02-09 Thread Jernej Skrabec
As expected, HDMI controller clock should always match pixel clock. In the past, changing HDMI controller rate would seemingly worsen situation. However, that was the result of other bugs which are now fixed. Fix that by removing set_rate quirk and always set clock rate. Fixes: 40bb9d3147b2 ("drm

[PATCH v3 2/5] drm/sun4i: tcon: set sync polarity for tcon1 channel

2021-02-09 Thread Jernej Skrabec
Channel 1 has polarity bits for vsync and hsync signals but driver never sets them. It turns out that with pre-HDMI2 controllers seemingly there is no issue if polarity is not set. However, with HDMI2 controllers (H6) there often comes to de-synchronization due to phase shift. This causes flickerin

[PATCH v3 1/5] clk: sunxi-ng: mp: fix parent rate change flag check

2021-02-09 Thread Jernej Skrabec
CLK_SET_RATE_PARENT flag is checked on parent clock instead of current one. Fix that. Fixes: 3f790433c3cb ("clk: sunxi-ng: Adjust MP clock parent rate when allowed") Reviewed-by: Chen-Yu Tsai Tested-by: Andre Heider Signed-off-by: Jernej Skrabec --- drivers/clk/sunxi-ng/ccu_mp.c | 2 +- 1 file

[PATCH v3 0/5] sunxi: fix H6 HDMI related issues

2021-02-09 Thread Jernej Skrabec
Over the year I got plenty of reports of troubles with H6 HDMI signal. Sometimes monitor flickers, sometimes there was no image at all and sometimes it didn't play well with AVR. It turns out there are multiple issues. Patch 1 fixes clock issue, which didn't adjust parent rate, even if it is allow

Re: [RFC][PATCH v6 1/7] drm: Add a sharable drm page-pool implementation

2021-02-09 Thread John Stultz
On Tue, Feb 9, 2021 at 4:11 AM Christian König wrote: > > > > Am 05.02.21 um 21:46 schrieb John Stultz: > > On Fri, Feb 5, 2021 at 12:47 AM Christian König > > wrote: > >> Am 05.02.21 um 09:06 schrieb John Stultz: > >>> diff --git a/drivers/gpu/drm/page_pool.c b/drivers/gpu/drm/page_pool.c > >>>

Re: [PATCH v6 1/3] lib/vsprintf: Add support for printing V4L2 and DRM fourccs

2021-02-09 Thread Sakari Ailus
Hi Andy, On Tue, Feb 09, 2021 at 11:58:40AM +0200, Andy Shevchenko wrote: > On Tue, Feb 09, 2021 at 11:20:32AM +0200, Sakari Ailus wrote: > > On Mon, Feb 08, 2021 at 10:43:30PM +0200, Andy Shevchenko wrote: > > > On Mon, Feb 8, 2021 at 10:11 PM Sakari Ailus > > > wrote: > > ... > > > > > +

Re: [RFC][PATCH v6 1/7] drm: Add a sharable drm page-pool implementation

2021-02-09 Thread Christian König
Am 09.02.21 um 18:33 schrieb Suren Baghdasaryan: On Tue, Feb 9, 2021 at 4:57 AM Christian König wrote: Am 09.02.21 um 13:11 schrieb Christian König: [SNIP] +void drm_page_pool_add(struct drm_page_pool *pool, struct page *page) +{ + spin_lock(&pool->lock); + list_add_tail(&page->lru,

Re: [PATCH v2 0/3] drm/amdgpu: Remove in_interrupt() usage.

2021-02-09 Thread Christian König
Hi Sebastian, to be honest I'm thinking about that for quite some time now and I don't think that this is possible without a severe rewrite of the driver. The problem is simply that we have a lot of functions which deal with hardware handling independent of the context. But how registers are

Re: [RFC][PATCH v6 3/7] drm: ttm_pool: Rework ttm_pool_free_page to allow us to use it as a function pointer

2021-02-09 Thread John Stultz
On Tue, Feb 9, 2021 at 4:14 AM Christian König wrote: > Am 05.02.21 um 20:47 schrieb John Stultz: > > On Fri, Feb 5, 2021 at 12:28 AM Christian König > > wrote: > >> Adding this to all pages would increase the memory footprint drastically. > > Yea, that's a good point! Hrm... bummer. I'll have t

[Bug 211425] [drm:atom_op_jump] *ERROR* atombios stuck in loop for more than 20secs aborting

2021-02-09 Thread bugzilla-daemon
https://bugzilla.kernel.org/show_bug.cgi?id=211425 Alex Deucher (alexdeuc...@gmail.com) changed: What|Removed |Added CC||alexdeuc...@gmail.c

Re: [PATCH v2 0/3] drm/amdgpu: Remove in_interrupt() usage.

2021-02-09 Thread Sebastian Andrzej Siewior
On 2021-02-09 13:50:31 [+0100], Christian König wrote: > Reviewed-by: Christian König for the series. Thank you. Any chance you could give me a hand with the remaining three users within the amdgpu driver? I don't know if the in_interrupt() check can be limited to certain callers. What I noticed

Re: [PATCH] radeon: added support for 2560x1080 resolution

2021-02-09 Thread Alex Deucher
On Sun, Feb 7, 2021 at 1:13 PM Marcin Raszka wrote: > > I was wondering why I can't set the resolution to 2560x1080, > while in windows 7 I can without a problem. I looked at the radeon driver > code and found it doesn't support this resolution. So I made some changes. I > added the hdmi_mhz pa

Re: [PATCH] drm/vblank: Avoid storing a timestamp for the same frame twice

2021-02-09 Thread Daniel Vetter
On Tue, Feb 9, 2021 at 4:41 PM Ville Syrjälä wrote: > On Tue, Feb 09, 2021 at 11:07:53AM +0100, Daniel Vetter wrote: > > On Thu, Feb 04, 2021 at 04:04:00AM +0200, Ville Syrjala wrote: > > > From: Ville Syrjälä > > > > > > drm_vblank_restore() exists because certain power saving states > > > can c

Re: [PATCH 1/2] dt-bindings: display: bridge: Add documentation for LT8912

2021-02-09 Thread Rob Herring
On Sun, Jan 24, 2021 at 04:08:34PM +0100, Adrien Grassein wrote: > Lontium LT8912 is a DSI to HDMI bridge. > > Signed-off-by: Adrien Grassein > --- > .../display/bridge/lontium,lt8912.yaml| 92 +++ > MAINTAINERS | 5 + > 2 files changed,

Re: [PATCH v6 2/8] drm/mediatek: add component POSTMASK

2021-02-09 Thread Guenter Roeck
On Tue, Feb 02, 2021 at 04:12:31PM +0800, Hsin-Yi Wang wrote: > From: Yongqiang Niu > > This patch add component POSTMASK. > > Signed-off-by: Yongqiang Niu > Signed-off-by: Hsin-Yi Wang > Reviewed-by: CK Hu > --- [ ... ] > > +void mtk_postmask_config(struct device *dev, unsigned int w, sta

Re: [PATCH] drm/qxl: properly handle device init failures

2021-02-09 Thread Tong Zhang
Hi Gerd, I tested the patch on drm-misc-next and it fixed the issue. Thanks, - Tong > On Feb 9, 2021, at 7:16 AM, Gerd Hoffmann wrote: > > On Mon, Feb 08, 2021 at 12:07:01PM -0500, Tong Zhang wrote: >> Does this patch fix an issue raised previously? Or should they be used >> together? >> https:

[PATCH 2/2] drm/vmwgfx: Remove pointless code

2021-02-09 Thread Zack Rusin
There's no need to check for the presence of the hotplug property just to return because this is the end of the function so we're returning either way. Signed-off-by: Zack Rusin Reviewed-by: Martin Krastev Reviewed-by: Roland Scheidegger --- drivers/gpu/drm/vmwgfx/vmwgfx_kms.c | 4 1 file

[PATCH 1/2] drm/vmwgfx: Correctly set the name of the preferred mode

2021-02-09 Thread Zack Rusin
Our sysfs "modes" entries were broken because our preffered mode never had its name set correctly. This resulted in the first entry simply being called "preferred" followed by a list of other resolutions. Lets fix it by actually setting the name of mode (which is its resolution). This allows one to

Re: [PATCH] drm/vblank: Avoid storing a timestamp for the same frame twice

2021-02-09 Thread Ville Syrjälä
On Tue, Feb 09, 2021 at 11:07:53AM +0100, Daniel Vetter wrote: > On Thu, Feb 04, 2021 at 04:04:00AM +0200, Ville Syrjala wrote: > > From: Ville Syrjälä > > > > drm_vblank_restore() exists because certain power saving states > > can clobber the hardware frame counter. The way it does this is > > b

Re: [PATCH v4 11/14] drm/amdgpu: Guard against write accesses after device removal

2021-02-09 Thread Christian König
Am 09.02.21 um 15:30 schrieb Andrey Grodzovsky: [SNIP] Question - Why can't we just set those PTEs to point to system memory (another RO dummy page) filled with 1s ? Then writes are not discarded. E.g. the 1s would change to something else. Christian. I see but, what about marking the

Re: [PATCH v4, 01/10] soc: mediatek: mmsys: create mmsys folder

2021-02-09 Thread Enric Balletbo Serra
Hi Yongqiang Niu, Thank you for your patch. Missatge de Yongqiang Niu del dia dt., 5 de gen. 2021 a les 4:07: > > the mmsys will more and more complicated after support > more and more SoCs, add an independent folder will be > more clear > > Signed-off-by: Yongqiang Niu > --- > drivers/soc/med

Re: [PATCH] drm/vblank: Document drm_crtc_vblank_restore constraints

2021-02-09 Thread Ville Syrjälä
On Tue, Feb 09, 2021 at 11:15:23AM +0100, Daniel Vetter wrote: > I got real badly confused when trying to review a fix from Ville for > this. Let's try to document better what's required for this, and check > the minimal settings at runtime - we can't check ofc that there's > indeed no races in the

Re: [PATCH v4 00/14] RFC Support hot device unplug in amdgpu

2021-02-09 Thread Andrey Grodzovsky
On 2/9/21 4:50 AM, Daniel Vetter wrote: On Mon, Feb 08, 2021 at 11:01:14PM -0500, Andrey Grodzovsky wrote: On 2/8/21 2:27 AM, Daniel Vetter wrote: On Mon, Feb 8, 2021 at 6:59 AM Andrey Grodzovsky wrote: On 1/20/21 10:59 AM, Daniel Vetter wrote: On Wed, Jan 20, 2021 at 3:20 PM Andrey Grodzo

Re: [PATCH v2 3/3] drm/panfrost: Stay in the threaded MMU IRQ handler until we've handled all IRQs

2021-02-09 Thread Rob Herring
On Fri, Feb 5, 2021 at 5:18 AM Boris Brezillon wrote: > > Doing a hw-irq -> threaded-irq round-trip is counter-productive, stay > in the threaded irq handler as long as we can. > > v2: > * Rework the loop to avoid a goto > > Signed-off-by: Boris Brezillon > --- > drivers/gpu/drm/panfrost/panfros

[PATCH v6] dt-bindings: display: panel: one file of all simple LVDS panels with dual ports

2021-02-09 Thread Liu Ying
To complement panel-simple.yaml, create panel-simple-lvds-dual-ports.yaml. panel-simple-lvds-dual-ports.yaml is for all simple LVDS panels that have dual LVDS ports and require only a single power-supply. The first port receives odd pixels, and the second port receives even pixels. Optionally, a ba

Re: [PATCH v13 7/8] soc: mediatek: add mtk mutex support for MT8183

2021-02-09 Thread Enric Balletbo Serra
Hi Hsin-Yi, Thank you for your patch. Missatge de Hsin-Yi Wang del dia dv., 29 de gen. 2021 a les 10:23: > > From: Yongqiang Niu > > Add mtk mutex support for MT8183 SoC. > > Signed-off-by: Yongqiang Niu > Signed-off-by: Hsin-Yi Wang > Reviewed-by: CK Hu Reviewed-by: Enric Balletbo i Serra

Re: [PATCH v4 11/14] drm/amdgpu: Guard against write accesses after device removal

2021-02-09 Thread Andrey Grodzovsky
On 2/9/21 2:58 AM, Christian König wrote: Am 08.02.21 um 23:15 schrieb Andrey Grodzovsky: On 2/8/21 11:23 AM, Daniel Vetter wrote: On Mon, Feb 8, 2021 at 3:00 PM Christian König wrote: Am 08.02.21 um 11:11 schrieb Daniel Vetter: On Mon, Feb 08, 2021 at 11:03:15AM +0100, Christian König wr

Re: [Linaro-mm-sig] [PATCH] RFC: dma-fence: Document recoverable page fault implications

2021-02-09 Thread Felix Kuehling
Am 2021-02-09 um 9:08 a.m. schrieb Daniel Vetter: > On Tue, Feb 9, 2021 at 12:15 PM Felix Kuehling wrote: >> Am 2021-02-09 um 1:37 a.m. schrieb Daniel Vetter: >>> On Tue, Feb 9, 2021 at 4:13 AM Bas Nieuwenhuizen >>> wrote: On Thu, Jan 28, 2021 at 4:40 PM Felix Kuehling wrote: > Am

Re: [PATCH] backlight: ktd253: Bring up in a known state

2021-02-09 Thread Lee Jones
On Tue, 26 Jan 2021, Linus Walleij wrote: > The KTD253 backlight might already be on when the driver > is probed: then we don't really know what the current > ratio is and all light intensity settings will be off > relative to what it was at boot. > > To fix this, bring up the backlight OFF then

Re: [Linaro-mm-sig] [PATCH] RFC: dma-fence: Document recoverable page fault implications

2021-02-09 Thread Daniel Vetter
On Tue, Feb 9, 2021 at 12:15 PM Felix Kuehling wrote: > Am 2021-02-09 um 1:37 a.m. schrieb Daniel Vetter: > > On Tue, Feb 9, 2021 at 4:13 AM Bas Nieuwenhuizen > > wrote: > >> On Thu, Jan 28, 2021 at 4:40 PM Felix Kuehling > >> wrote: > >>> Am 2021-01-28 um 2:39 a.m. schrieb Christian König: > >

Re: [PATCH] drm/ttm: fix removal of bo_count sysfs file

2021-02-09 Thread Nirmoy
Reviewed-by: Nirmoy Das On 2/9/21 2:17 PM, Christian König wrote: Only a zombie leftover from rebasing. Signed-off-by: Christian König Fixes: 3763d635deaa ("drm/ttm: add debugfs directory v2") --- drivers/gpu/drm/ttm/ttm_device.c | 2 -- include/drm/ttm/ttm_device.h | 1 - 2 files chan

[Bug 211425] [drm:atom_op_jump] *ERROR* atombios stuck in loop for more than 20secs aborting

2021-02-09 Thread bugzilla-daemon
https://bugzilla.kernel.org/show_bug.cgi?id=211425 Andreas (icedragon...@web.de) changed: What|Removed |Added Kernel Version|5.10.13 |5.10.14 --- Comment #4 fr

Re: [PATCH] drm/ttm: fix removal of bo_count sysfs file

2021-02-09 Thread Daniel Vetter
On Tue, Feb 9, 2021 at 2:34 PM Christian König wrote: > > > > Am 09.02.21 um 14:32 schrieb Daniel Vetter: > > On Tue, Feb 9, 2021 at 2:18 PM Christian König > > wrote: > >> Only a zombie leftover from rebasing. > >> > >> Signed-off-by: Christian König > >> Fixes: 3763d635deaa ("drm/ttm: add debu

[PATCH v2 10/10] drm/ast: Move all of the cursor-update functionality to atomic_update

2021-02-09 Thread Thomas Zimmermann
We used to update the cursor image in prepare_fb. Move all this code to atomic_update (where it belongs). The generic helper for shadow-buffered planes now implement the cursor plane's prepare_fb. Signed-off-by: Thomas Zimmermann --- drivers/gpu/drm/ast/ast_mode.c | 66 --

[PATCH v2 03/10] drm/ast: Initialize planes in helper functions

2021-02-09 Thread Thomas Zimmermann
This change will help with inlining cursor functions into modesetting code. The primary plane's field used to be cleared with memset(). This has been dropped as the memory is always allocated with kzalloc(). Signed-off-by: Thomas Zimmermann --- drivers/gpu/drm/ast/ast_mode.c | 66 +++

[PATCH v2 07/10] drm/ast: Store cursor BOs in cursor plane

2021-02-09 Thread Thomas Zimmermann
The cursor uses two BOs in video RAM to implement double buffering. Store both in struct ast_cursor_plane. Signed-off-by: Thomas Zimmermann --- drivers/gpu/drm/ast/ast_drv.h | 11 ++- drivers/gpu/drm/ast/ast_mode.c | 27 +++ 2 files changed, 21 insertions(+), 17

[PATCH v2 06/10] drm/ast: Add cursor-plane data structure

2021-02-09 Thread Thomas Zimmermann
Cursor state is currently located throughout struct ast_private. Having struct ast_cursor_plane as dedicated data structure for cursors helps to organize the modesetting code. Signed-off-by: Thomas Zimmermann --- drivers/gpu/drm/ast/ast_drv.h | 23 ++- drivers/gpu/drm/ast/as

[PATCH v2 04/10] drm/ast: Allocate HW cursor BOs during cursor-plane initialization

2021-02-09 Thread Thomas Zimmermann
The BOs are eventually released by the cursor plane's destroy callback. Signed-off-by: Thomas Zimmermann --- drivers/gpu/drm/ast/ast_cursor.c | 58 -- drivers/gpu/drm/ast/ast_drv.h| 1 - drivers/gpu/drm/ast/ast_mode.c | 62 3 fi

[PATCH v2 08/10] drm/ast: Map HW cursor BOs permanently

2021-02-09 Thread Thomas Zimmermann
The BOs of the hardware cursor are now mapped permanently while the cursor plane is being used. This reduces the CPU overhead of the cursor plane's atomic_update function. The change also resolves a problem with the vmap call in the commit tail. The vmap implementation could acquire the DMA reserv

[PATCH v2 09/10] drm/ast: Store each HW cursor offset after pinning the rsp BO

2021-02-09 Thread Thomas Zimmermann
As HW cursor BOs never move, we can store the offset in VRAM in the cursor-plane's HWC state. This removes the last possible source of runtime errors from atomic_update. Signed-off-by: Thomas Zimmermann --- drivers/gpu/drm/ast/ast_drv.h | 1 + drivers/gpu/drm/ast/ast_mode.c | 21 +++---

[PATCH v2 05/10] drm/ast: Inline ast cursor-update functions into modesetting code

2021-02-09 Thread Thomas Zimmermann
The logic for cursor updates is now located in the cursor plane's modesetting code. A number of helper functions remain to modify the rsp registers and image. Signed-off-by: Thomas Zimmermann --- drivers/gpu/drm/ast/Makefile | 3 +- drivers/gpu/drm/ast/ast_cursor.c | 237 --

[PATCH v2 02/10] drm/ast: Fix invalid usage of AST_MAX_HWC_WIDTH in cursor atomic_check

2021-02-09 Thread Thomas Zimmermann
Use AST_MAX_HWC_HEIGHT for setting offset_y in the cursor plane's atomic_check. The code used AST_MAX_HWC_WIDTH instead. This worked because both constants has the same value. Signed-off-by: Thomas Zimmermann --- drivers/gpu/drm/ast/ast_mode.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-

[PATCH v2 01/10] drm/ast: Add constants for VGACRCB register bits

2021-02-09 Thread Thomas Zimmermann
Set the bits in VGACRCB with constants. Alo move the rsp code into a helper function. Signed-off-by: Thomas Zimmermann --- drivers/gpu/drm/ast/ast_cursor.c | 21 +++-- drivers/gpu/drm/ast/ast_drv.h| 3 +++ 2 files changed, 18 insertions(+), 6 deletions(-) diff --git a/drive

[PATCH v2 00/10] drm/ast: Clean-up cursor-plane updates

2021-02-09 Thread Thomas Zimmermann
(was: drm/ast: Move cursor vmap calls out of commit tail) Ast has vmap calls in its cursor's atomic_update function. This is not supported as vmap might aquire the dma reservation lock. While at it, cleanup the whole cursor code: the patchset removes all possible runtime errors from the atomic_upd

Re: [PATCH 0/9] Add support for SVM atomics in Nouveau

2021-02-09 Thread Jason Gunthorpe
On Tue, Feb 09, 2021 at 02:39:51PM +0100, Daniel Vetter wrote: > Either way ZONE_DEVICE for not vram/device memory sounds wrong. Is > that really going on here? My read was this was doing non-coherent atomics on CPU memory. Atomics on GPU memory is just called migration to GPU memory, it doesn't

Re: [PATCH 0/9] Add support for SVM atomics in Nouveau

2021-02-09 Thread Daniel Vetter
On Tue, Feb 9, 2021 at 2:35 PM Jason Gunthorpe wrote: > > On Tue, Feb 09, 2021 at 11:57:28PM +1100, Alistair Popple wrote: > > On Tuesday, 9 February 2021 9:27:05 PM AEDT Daniel Vetter wrote: > > > > > > > > Recent changes to pin_user_pages() prevent the creation of pinned pages > > > > in > > >

Re: [PATCH 1/9] mm/migrate.c: Always allow device private pages to migrate

2021-02-09 Thread Jason Gunthorpe
On Tue, Feb 09, 2021 at 12:07:14PM +1100, Alistair Popple wrote: > Device private pages are used to represent device memory that is not > directly accessible from the CPU. Extra references to a device private > page are only used to ensure the struct page itself remains valid whilst > waiting for m

Re: [PATCH 0/9] Add support for SVM atomics in Nouveau

2021-02-09 Thread Daniel Vetter
On Tue, Feb 9, 2021 at 1:57 PM Alistair Popple wrote: > > On Tuesday, 9 February 2021 9:27:05 PM AEDT Daniel Vetter wrote: > > > > > > Recent changes to pin_user_pages() prevent the creation of pinned pages in > > > ZONE_MOVABLE. This series allows pinned pages to be created in > ZONE_MOVABLE > >

Re: [PATCH 0/9] Add support for SVM atomics in Nouveau

2021-02-09 Thread Jason Gunthorpe
On Tue, Feb 09, 2021 at 11:57:28PM +1100, Alistair Popple wrote: > On Tuesday, 9 February 2021 9:27:05 PM AEDT Daniel Vetter wrote: > > > > > > Recent changes to pin_user_pages() prevent the creation of pinned pages in > > > ZONE_MOVABLE. This series allows pinned pages to be created in > ZONE_MOV

Re: [PATCH 0/9] Add support for SVM atomics in Nouveau

2021-02-09 Thread Alistair Popple
On Tuesday, 9 February 2021 9:27:05 PM AEDT Daniel Vetter wrote: > > > > Recent changes to pin_user_pages() prevent the creation of pinned pages in > > ZONE_MOVABLE. This series allows pinned pages to be created in ZONE_MOVABLE > > as attempts to migrate may fail which would be fatal to userspace.

[PATCH v3 5/6] ARM: dts: imx6dl-prtvt7: Remove backlight enable gpio

2021-02-09 Thread Oleksij Rempel
The backlight power is controlled through the reg_bl_12v0 regulator. Co-Developed-by: Robin van der Gracht Signed-off-by: Robin van der Gracht Signed-off-by: Oleksij Rempel --- arch/arm/boot/dts/imx6dl-prtvt7.dts | 9 - 1 file changed, 9 deletions(-) diff --git a/arch/arm/boot/dts/imx

[PATCH v3 4/6] ARM: dts: imx6dl-prtvt7: add TSC2046 touchscreen node

2021-02-09 Thread Oleksij Rempel
Add touchscreen support to the Protonic VT7 board. Co-Developed-by: Robin van der Gracht Signed-off-by: Robin van der Gracht Signed-off-by: Oleksij Rempel --- arch/arm/boot/dts/imx6dl-prtvt7.dts | 15 +++ 1 file changed, 15 insertions(+) diff --git a/arch/arm/boot/dts/imx6dl-prtvt

[PATCH v3 6/6] ARM: dts: imx6dl-plym2m: remove touchscreen-size-* properties

2021-02-09 Thread Oleksij Rempel
Remove touchscreen-size-* properties. This values are not correct, event if it works with ts_test tool, it fails to work properly with weston. And the real range of values reported by the driver (or measured by the controller) is close to max values and may change with time on resistive panels. So

  1   2   >