[PATCH v2] drm/ast: Disable fast reset after DRAM initial

2021-01-11 Thread KuoHsiang Chou
[Bug][AST2500] V1: When AST2500 acts as stand-alone VGA so that DRAM and DVO initialization have to be achieved by VGA driver with P2A (PCI to AHB) enabling. However, HW suggests disable Fast reset mode after DRAM initializaton, because fast reset mode is mainly designed for ARM ICE debugger. Once

[PATCH v4 1/2] dt-bindings: Add DT schema for Arm Mali Valhall GPU

2021-01-11 Thread Nick Fan
Add devicetree schema for Arm Mali Valhall GPU Define a compatible string for the Mali Valhall GPU for Mediatek's SoC platform. Signed-off-by: Nick Fan --- .../bindings/gpu/arm,mali-valhall.yaml| 252 ++ 1 file changed, 252 insertions(+) create mode 100644 Documentation

[PATCH v3] drm/sun4i: tcon: fix inverted DCLK polarity

2021-01-11 Thread Giulio Benetti
From: Giulio Benetti During commit 88bc4178568b ("drm: Use new DRM_BUS_FLAG_*_(DRIVE|SAMPLE)_(POS|NEG)EDGE flags") DRM_BUS_FLAG_* macros have been changed to avoid ambiguity but just because of this ambiguity previous DRM_BUS_FLAG_PIXDATA_(POS/NEG)EDGE were used meaning _SAMPLE_ not _DRIVE_. This

Re: [patch 02/30] genirq: Move status flag checks to core

2021-01-11 Thread Thomas Gleixner
On Sun, Dec 27 2020 at 11:20, Guenter Roeck wrote: > On Thu, Dec 10, 2020 at 08:25:38PM +0100, Thomas Gleixner wrote: > Yes, but that means that irq_check_status_bit() may be called from modules, > but it is not exported, resulting in build errors such as the following. > > arm64:allmodconfig: > >

[PATCH v2 12/15] drm/vc4: hdmi: Don't register the CEC adapter if there's no interrupts

2021-01-11 Thread Maxime Ripard
We introduced the BCM2711 support to the vc4 HDMI controller with 5.10, but this was lacking any of the interrupts of the CEC controller so we have to deal with the backward compatibility. Do so by simply ignoring the CEC setup if the DT doesn't have the interrupts property. Reviewed-by: Dave Ste

Re: [PATCH v2 2/2] drm/sun4i: tcon: improve DCLK polarity handling

2021-01-11 Thread Giulio Benetti
On 1/11/21 6:20 PM, Maxime Ripard wrote: On Fri, Jan 08, 2021 at 03:34:52PM +0100, Giulio Benetti wrote: Hi, On 1/8/21 10:23 AM, Maxime Ripard wrote: Hi, Thanks for those patches On Thu, Jan 07, 2021 at 03:30:32AM +0100, Giulio Benetti wrote: From: Giulio Benetti It turned out(Maxime sugg

[PATCH v2 02/15] drm/vc4: hdmi: Move hdmi reset to bind

2021-01-11 Thread Maxime Ripard
From: Dom Cobley The hdmi reset got moved to a later point in the commit 9045e91a476b ("drm/vc4: hdmi: Add reset callback"). However, the reset now occurs after vc4_hdmi_cec_init and so tramples the setup of registers like HDMI_CEC_CNTRL_1 This only affects pi0-3 as on pi4 the cec registers are

Re: [Freedreno] [PATCH] drm/msm: Only enable A6xx LLCC code on A6xx

2021-01-11 Thread Sai Prakash Ranjan
Hi Jordan, On 2021-01-11 21:41, Jordan Crouse wrote: On Mon, Jan 11, 2021 at 09:54:12AM +0530, Sai Prakash Ranjan wrote: Hi Rob, On 2021-01-08 22:16, Rob Clark wrote: >On Fri, Jan 8, 2021 at 6:05 AM Sai Prakash Ranjan > wrote: >> >>On 2021-01-08 19:09, Konrad Dybcio wrote: Konrad, can you

[PATCH v2 15/15] ARM: dts: bcm2711: Add the CEC interrupt controller

2021-01-11 Thread Maxime Ripard
The CEC and hotplug interrupts go through an interrupt controller shared between the two HDMI controllers. Let's add that interrupt controller and the interrupts for both HDMI controllers Reviewed-by: Florian Fainelli Signed-off-by: Maxime Ripard --- arch/arm/boot/dts/bcm2711.dtsi | 18 +++

[PATCH v2 04/15] drm/vc4: hdmi: Fix up CEC registers

2021-01-11 Thread Maxime Ripard
From: Dom Cobley The commit 311e305fdb4e ("drm/vc4: hdmi: Implement a register layout abstraction") forgot one CEC register, and made a copy and paste mistake for another one. Fix those mistakes. Fixes: 311e305fdb4e ("drm/vc4: hdmi: Implement a register layout abstraction") Reviewed-by: Dave Ste

[PATCH v2] drm: Introduce a drm_crtc_commit_wait helper

2021-01-11 Thread Maxime Ripard
There's currently four users of the same logic to wait for a commit to be flipped: three for the CRTCs, connectors and planes in drm_atomic_helper_wait_for_dependencies, and one in vc4. Let's consolidate this a bit to avoid any code duplication. Suggested-by: Daniel Vetter Reviewed-by: Daniel Ve

Re: [PATCH v2 2/2] drm/sun4i: tcon: improve DCLK polarity handling

2021-01-11 Thread Maxime Ripard
On Fri, Jan 08, 2021 at 03:34:52PM +0100, Giulio Benetti wrote: > Hi, > > On 1/8/21 10:23 AM, Maxime Ripard wrote: > > Hi, > > > > Thanks for those patches > > > > On Thu, Jan 07, 2021 at 03:30:32AM +0100, Giulio Benetti wrote: > > > From: Giulio Benetti > > > > > > It turned out(Maxime sugges

[PATCH] drm: Removes invalid function return value comment information

2021-01-11 Thread Zhaoge Zhang
Signed-off-by: Zhaoge Zhang --- drivers/gpu/drm/drm_file.c | 3 --- 1 file changed, 3 deletions(-) diff --git a/drivers/gpu/drm/drm_file.c b/drivers/gpu/drm/drm_file.c index b50380f..8548e8b 100644 --- a/drivers/gpu/drm/drm_file.c +++ b/drivers/gpu/drm/drm_file.c @@ -240,9 +240,6 @@ static void

[PATCH 3/3] drm/msm: Use IOMMU_LLC page protection flag to map gpu buffers

2021-01-11 Thread Sai Prakash Ranjan
Use the newly introduced IOMMU_LLC page protection flag to map GPU buffers. This will make sure that proper stage-1 PTE attributes are set for GPU buffers to use system cache. This also introduces MMU_FEATURE_USE_LLC features bit to check for GPUs supporting LLC and set them in the target specific

[PATCH 2/3] iommu/io-pgtable-arm: Add IOMMU_LLC page protection flag

2021-01-11 Thread Sai Prakash Ranjan
Add a new page protection flag IOMMU_LLC which can be used by non-coherent masters to set cacheable memory attributes for an outer level of cache called as last-level cache or system cache. Initial user of this page protection flag is the adreno gpu and then can later be used by other clients such

Re: [PATCH v16 0/4] RDMA: Add dma-buf support

2021-01-11 Thread Jason Gunthorpe
On Mon, Jan 11, 2021 at 03:24:18PM +, Xiong, Jianxin wrote: > Jason, will this series be able to get into 5.12? I was going to ask you where things are after the break? Did everyone agree the userspace stuff is OK now? Is Edward OK with the pyverbs changes, etc Jason ___

[PATCH v4 2/2] arm64: dts: mt8192: Add node for the Mali GPU

2021-01-11 Thread Nick Fan
Add a basic GPU node for mt8192. Signed-off-by: Nick Fan --- This patch depends on Mediatek power and regulator support. Listed as following. [1]https://lore.kernel.org/patchwork/patch/1336293/ [2]https://patchwork.kernel.org/project/linux-mediatek/list/?series=374013 [3]https://lore.kernel.org

Re: [PATCH 2/2] drm/msm/dp: unplug interrupt missed after irq_hpd handler

2021-01-11 Thread Stephen Boyd
Quoting Kuogee Hsieh (2021-01-07 12:30:25) > There is HPD unplug interrupts missed at scenario of an irq_hpd > followed by unplug interrupts with around 10 ms in between. > Since both AUX_SW_RESET and DP_SW_RESET clear pending HPD interrupts, > irq_hpd handler should not issues either aux or sw res

[PATCH v2 03/15] drm/vc4: hdmi: Fix register offset with longer CEC messages

2021-01-11 Thread Maxime Ripard
From: Dom Cobley The code prior to 311e305fdb4e ("drm/vc4: hdmi: Implement a register layout abstraction") was relying on the fact that the register offset was incremented by 4 for each readl call. That worked since the register width is 4 bytes. However, since that commit the HDMI_READ macro is

[PATCH v2 13/15] dt-binding: display: bcm2711-hdmi: Add CEC and hotplug interrupts

2021-01-11 Thread Maxime Ripard
The CEC and hotplug interrupts were missing when that binding was introduced, let's add them in now that we've figured out how it works. Signed-off-by: Maxime Ripard --- .../bindings/display/brcm,bcm2711-hdmi.yaml | 20 ++- 1 file changed, 19 insertions(+), 1 deletion(-) diff

[PATCH v2 05/15] drm/vc4: hdmi: Restore cec physical address on reconnect

2021-01-11 Thread Maxime Ripard
From: Dom Cobley Currently we call cec_phys_addr_invalidate on a hotplug deassert. That may be due to a TV power cycling, or an AVR being switched on (and switching edid). This makes CEC unusable since our controller wouldn't have a physical address anymore. Set it back up again on the hotplug

[PATCH v2 08/15] drm/vc4: hdmi: Introduce a CEC clock

2021-01-11 Thread Maxime Ripard
While the BCM2835 had the CEC clock derived from the HSM clock, the BCM2711 has a dedicated parent clock for it. Let's introduce a separate clock for it so that we can handle both cases. Reviewed-by: Dave Stevenson Signed-off-by: Maxime Ripard --- drivers/gpu/drm/vc4/vc4_hdmi.c | 9 -

[PATCH v2 09/15] drm/vc4: hdmi: Split the interrupt handlers

2021-01-11 Thread Maxime Ripard
The BCM2711 has two different interrupt sources to transmit and receive CEC messages, provided through an external interrupt chip shared between the two HDMI interrupt controllers. The rest of the CEC controller is identical though so we need to change a bit the code organisation to share the code

[PATCH 0/3] iommu/drm/msm: Allow non-coherent masters to use system cache

2021-01-11 Thread Sai Prakash Ranjan
commit ecd7274fb4cd ("iommu: Remove unused IOMMU_SYS_CACHE_ONLY flag") removed unused IOMMU_SYS_CACHE_ONLY prot flag and along with it went the memory type setting required for the non-coherent masters to use system cache. Now that system cache support for GPU is added, we will need to set the righ

[PATCH v2 06/15] drm/vc4: hdmi: Compute the CEC clock divider from the clock rate

2021-01-11 Thread Maxime Ripard
The CEC clock divider needs to output a frequency of 40kHz from the HSM rate on the BCM2835. The driver used to have a fixed frequency for it, but that changed for the BCM2711 and we now need to compute it dynamically to maintain the proper rate. Fixes: cd4cb49dc5bb ("drm/vc4: hdmi: Adjust HSM clo

[PATCH -next] drm/amd/display: tweak the kerneldoc for active_vblank_irq_count

2021-01-11 Thread Lukas Bulwahn
lank_irq_count. Signed-off-by: Lukas Bulwahn --- applies on amdgpu's -next and next-20210111 Bhawanpreet, Nick, please review and ack. Alex, Christian, please pick on top of the commit above. drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.h | 2 +- 1 file changed, 1 insertion(+), 1 deleti

[PATCH v2 00/15] drm/vc4: hdmi: Add CEC support for the BCM2711

2021-01-11 Thread Maxime Ripard
Hi, Here's a series introducing the CEC support for the BCM2711 found on the RaspberryPi4. The BCM2711 HDMI controller uses a similar layout for the CEC registers, the main difference being that the interrupt handling part is now shared between both HDMI controllers. This series is mainly about

[PATCH v2 11/15] drm/vc4: hdmi: Remove cec_available flag

2021-01-11 Thread Maxime Ripard
From: Dom Cobley Now that our HDMI controller supports CEC for the BCM2711, let's remove that flag. Reviewed-by: Dave Stevenson Signed-off-by: Dom Cobley Signed-off-by: Maxime Ripard --- drivers/gpu/drm/vc4/vc4_hdmi.c | 4 drivers/gpu/drm/vc4/vc4_hdmi.h | 3 --- 2 files changed, 7 delet

[PATCH v2 14/15] ARM: dts: bcm2711: Add the BSC interrupt controller

2021-01-11 Thread Maxime Ripard
The BSC controllers used for the HDMI DDC have an interrupt controller shared between both instances. Let's add it to avoid polling. Reviewed-by: Florian Fainelli Signed-off-by: Maxime Ripard --- arch/arm/boot/dts/bcm2711.dtsi | 12 1 file changed, 12 insertions(+) diff --git a/ar

Re: [patch V3 13/37] mips/mm/highmem: Switch to generic kmap atomic

2021-01-11 Thread Sebastian Andrzej Siewior
On 2021-01-09 01:33:52 [+0100], Thomas Bogendoerfer wrote: > On Sat, Jan 09, 2021 at 12:58:05AM +0100, Thomas Bogendoerfer wrote: > > On Fri, Jan 08, 2021 at 08:20:43PM +, Paul Cercueil wrote: > > > Hi Thomas, > > > > > > 5.11 does not boot anymore on Ingenic SoCs, I bisected it to this commit

[PATCH -next] phy: mediatek: Mark mtk_mipi_tx_driver with static keyword

2021-01-11 Thread Zou Wei
Fix the following sparse warning: drivers/phy/mediatek/phy-mtk-mipi-dsi.c:237:24: warning: symbol 'mtk_mipi_tx_driver' was not declared. Should it be static? Signed-off-by: Zou Wei --- drivers/phy/mediatek/phy-mtk-mipi-dsi.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/d

[PATCH 1/3] iommu/io-pgtable: Rename last-level cache quirk to IO_PGTABLE_QUIRK_PTW_LLC

2021-01-11 Thread Sai Prakash Ranjan
Rename last-level cache quirk IO_PGTABLE_QUIRK_ARM_OUTER_WBWA to IO_PGTABLE_QUIRK_PTW_LLC which is used to set the required TCR attributes for non-coherent page table walker to be more generic and in sync with the upcoming page protection flag IOMMU_LLC. Signed-off-by: Sai Prakash Ranjan --- dri

[PATCH] drm: Fix macro name DRM_MODE_PROP_OBJECT in code comment

2021-01-11 Thread Zhaoge Zhang
Signed-off-by: Zhaoge Zhang --- include/drm/drm_property.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/include/drm/drm_property.h b/include/drm/drm_property.h index 4a0a80d..bbf5c1fd 100644 --- a/include/drm/drm_property.h +++ b/include/drm/drm_property.h @@ -114,7 +114,7

[PATCH] drm: arc: Use simple encoder

2021-01-11 Thread Tian Tao
The arc driver uses empty implementations for its encoders. Replace the code with the generic simple encoder. Signed-off-by: Tian Tao --- drivers/gpu/drm/arc/arcpgu_hdmi.c | 8 ++-- 1 file changed, 2 insertions(+), 6 deletions(-) diff --git a/drivers/gpu/drm/arc/arcpgu_hdmi.c b/drivers/gpu

Re: [PATCH v2 01/15] ARM: bcm: Select BRCMSTB_L2_IRQ for bcm2835

2021-01-11 Thread Nicolas Saenz Julienne
@Maxime it seems you forgot to CC me on the series :) On Mon, 2021-01-11 at 08:54 -0800, Florian Fainelli wrote: > > On 1/11/2021 6:22 AM, Maxime Ripard wrote: > > The BCM2711 has a number of instances of interrupt controllers handled > > by the driver behind the BRCMSTB_L2_IRQ Kconfig option (ir

Re: [PATCH 1/2] drm/msm/dp: postpone irq_hpd event during connection pending state

2021-01-11 Thread Stephen Boyd
Quoting Kuogee Hsieh (2021-01-07 12:30:24) > irq_hpd event can only be executed at connected state. Therefore > irq_hpd event should be postponed if it happened at connection > pending state. This patch also make sure both link rate and lane Why does it happen at connection pending state? > are v

Re: [PATCH v2 01/15] ARM: bcm: Select BRCMSTB_L2_IRQ for bcm2835

2021-01-11 Thread Florian Fainelli
On 1/11/2021 6:22 AM, Maxime Ripard wrote: > The BCM2711 has a number of instances of interrupt controllers handled > by the driver behind the BRCMSTB_L2_IRQ Kconfig option (irq-brcmstb-l2). > > Let's select that driver as part of the ARCH_BCM2835 Kconfig option. > > Signed-off-by: Maxime Ripa

[PATCH v2 10/15] drm/vc4: hdmi: Support BCM2711 CEC interrupt setup

2021-01-11 Thread Maxime Ripard
The HDMI controller found in the BCM2711 has an external interrupt controller for the CEC and hotplug interrupt shared between the two instances. Let's add a variant flag to register a single interrupt handler and deals with the interrupt handler setup, or two interrupt handlers relying on an exte

[PATCH v2 01/15] ARM: bcm: Select BRCMSTB_L2_IRQ for bcm2835

2021-01-11 Thread Maxime Ripard
The BCM2711 has a number of instances of interrupt controllers handled by the driver behind the BRCMSTB_L2_IRQ Kconfig option (irq-brcmstb-l2). Let's select that driver as part of the ARCH_BCM2835 Kconfig option. Signed-off-by: Maxime Ripard --- arch/arm/mach-bcm/Kconfig| 1 + arch/arm64/Kc

[PATCH v2 07/15] drm/vc4: hdmi: Update the CEC clock divider on HSM rate change

2021-01-11 Thread Maxime Ripard
As part of the enable sequence we might change the HSM clock rate if the pixel rate is different than the one we were already dealing with. On the BCM2835 however, the CEC clock derives from the HSM clock so any rate change will need to be reflected in the CEC clock divider to output 40kHz. Fixes

Re: [PATCH 05/15] drm/vc4: hdmi: Restore cec physical address on reconnect

2021-01-11 Thread Maxime Ripard
Hi Dave, Thanks for your review On Fri, Dec 18, 2020 at 02:45:54PM +, Dave Stevenson wrote: > On Fri, 18 Dec 2020 at 14:21, Dave Stevenson > wrote: > > > > Hi Maxime & Dom > > > > On Thu, 10 Dec 2020 at 13:47, Maxime Ripard wrote: > > > > > > From: Dom Cobley > > > > > > Currently we call

Re: [PATCH v4 11/13] drm/vboxvideo: Use drm_gem_vram_vmap_local() in cursor update

2021-01-11 Thread Thomas Zimmermann
Hi Am 11.01.21 um 18:06 schrieb Daniel Vetter: On Fri, Jan 08, 2021 at 10:43:38AM +0100, Thomas Zimmermann wrote: Cursor updates in vboxvideo require a short-term mapping of the source BO. Use drm_gem_vram_vmap_local() and avoid the pinning operations. Signed-off-by: Thomas Zimmermann All t

Re: [PATCH 1/2] drm/radeon: stop re-init the TTM page pool

2021-01-11 Thread Christian König
Am 11.01.21 um 17:17 schrieb Daniel Vetter: On Mon, Jan 11, 2021 at 11:16:13AM +0100, Christian König wrote: Am 08.01.21 um 16:53 schrieb Daniel Vetter: On Fri, Jan 8, 2021 at 3:36 PM Christian König wrote: Am 08.01.21 um 15:31 schrieb Daniel Vetter: On Thu, Jan 07, 2021 at 09:08:29PM +0100,

Re: [PATCH v4 01/13] dma-buf: Add vmap_local and vnumap_local operations

2021-01-11 Thread Thomas Zimmermann
Hi Am 08.01.21 um 17:12 schrieb Ruhl, Michael J: -Original Message- From: dri-devel On Behalf Of Thomas Zimmermann Sent: Friday, January 8, 2021 4:43 AM To: sumit.sem...@linaro.org; christian.koe...@amd.com; airl...@redhat.com; dan...@ffwll.ch; maarten.lankho...@linux.intel.com; mrip...

RE: [PATCH 2/2] drm/amdgpu/display: buffer INTERRUPT_LOW_IRQ_CONTEXT interrupt work

2021-01-11 Thread Chen, Xiaogang
[AMD Official Use Only - Internal Distribution Only] Any comment? -Original Message- From: Xiaogang.Chen Sent: Monday, January 4, 2021 12:02 AM To: amd-...@lists.freedesktop.org; Wentland, Harry ; dri-devel@lists.freedesktop.org; airl...@linux.ie Cc: Chen, Xiaogang Subject: [PATCH 2/2

RE: [PATCH 1/2] drm: distinguish return value of drm_dp_check_and_send_link_address.

2021-01-11 Thread Chen, Xiaogang
[AMD Official Use Only - Internal Distribution Only] Any comment? -Original Message- From: Xiaogang.Chen Sent: Monday, January 4, 2021 12:02 AM To: amd-...@lists.freedesktop.org; Wentland, Harry ; dri-devel@lists.freedesktop.org; airl...@linux.ie Cc: Chen, Xiaogang Subject: [PATCH 1/2

Re: [PATCH v9 14/19] drm/i915/hdcp: MST streams support in hdcp port_data

2021-01-11 Thread Li, Juston
On Mon, 2021-01-11 at 13:41 +0530, Anshuman Gupta wrote: > Add support for multiple mst stream in hdcp port data > which will be used by RepeaterAuthStreamManage msg and > HDCP 2.2 security f/w for m' validation. > > Security f/w doesn't have any provision to mark the stream_type > for each stream

Re: [PATCH v3 4/6] dt-bindings: display: rockchip: dw-hdmi: Convert binding to YAML

2021-01-11 Thread Laurent Pinchart
Hi Rob, On Mon, Jan 11, 2021 at 05:12:58PM -0600, Rob Herring wrote: > On Tue, Jan 05, 2021 at 08:08:16AM +0200, Laurent Pinchart wrote: > > Convert the Rockchip HDMI TX text binding to YAML. > > > > Signed-off-by: Laurent Pinchart > > --- > > Changes since v2: > > > > - Use Mark's @gmail.com e

Re: [PATCH] drm/bridge: nwl-dsi: Avoid potential multiplication overflow on 32-bit

2021-01-11 Thread Laurent Pinchart
Hi Geert, Thank you for the patch. On Mon, Jan 11, 2021 at 01:57:02PM +0100, Geert Uytterhoeven wrote: > As nwl_dsi.lanes is u32, and NSEC_PER_SEC is 10L, the second > multiplication in > > dsi->lanes * 8 * NSEC_PER_SEC > > will overflow on a 32-bit platform. Fix this by making the

Re: [PATCH v3, 08/15] drm/mediatek: check if fb is null

2021-01-11 Thread Chun-Kuang Hu
Hi, Yongqiang: Yongqiang Niu 於 2021年1月11日 週一 下午3:48寫道: > > It's possible that state->base.fb is null. Add a check before access its > format. Applied to mediatek-drm-next [1], thanks. [1] https://git.kernel.org/pub/scm/linux/kernel/git/chunkuang.hu/linux.git/log/?h=mediatek-drm-next Regards,

Re: [PATCH v3, 07/15] drm/mediatek: enable OVL_LAYER_SMI_ID_EN for multi-layer usecase

2021-01-11 Thread Chun-Kuang Hu
Hi, Yongqiang: Yongqiang Niu 於 2021年1月11日 週一 下午3:44寫道: > > enable OVL_LAYER_SMI_ID_EN for multi-layer usecase Could you describe more information? Without this patch, what would happen? > > Signed-off-by: Yongqiang Niu > --- > drivers/gpu/drm/mediatek/mtk_disp_ovl.c | 12 > 1 fil

Re: [PATCH v3, 06/15] drm/mediatek: add component RDMA4

2021-01-11 Thread Chun-Kuang Hu
Hi, Yongqiang: Yongqiang Niu 於 2021年1月11日 週一 下午3:44寫道: > > This patch add component RDMA4 Reviewed-by: Chun-Kuang Hu > > Signed-off-by: Yongqiang Niu > --- > drivers/gpu/drm/mediatek/mtk_drm_ddp_comp.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/drivers/gpu/drm/mediatek/mtk_drm_

Re: [PATCH v3, 05/15] drm/mediatek: add component POSTMASK

2021-01-11 Thread Chun-Kuang Hu
Hi, Yongqiang: Yongqiang Niu 於 2021年1月11日 週一 下午3:44寫道: > > This patch add component POSTMASK, This patch has conflicts with the series "Decouple Mediatek DRM sub driver" [1] which has been applied to mediatek-drm-next, so please rebase this patch onto mediatek-drm-next. [1] https://patchwork.ke

Re: [PATCH v3, 04/15] drm/mediatek: add component OVL_2L2

2021-01-11 Thread Chun-Kuang Hu
Hi, Yongqiang: Yongqiang Niu 於 2021年1月11日 週一 下午3:44寫道: > > This patch add component OVL_2L2 Reviewed-by: Chun-Kuang Hu > > Signed-off-by: Yongqiang Niu > --- > drivers/gpu/drm/mediatek/mtk_drm_ddp_comp.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/drivers/gpu/drm/mediatek/mtk_dr

Re: [PATCH v3, 03/15] arm64: dts: mt8192: add display node

2021-01-11 Thread Chun-Kuang Hu
Hi, Yongqiang: Yongqiang Niu 於 2021年1月11日 週一 下午3:48寫道: > > add display node > > Signed-off-by: Yongqiang Niu > --- > arch/arm64/boot/dts/mediatek/mt8192.dtsi | 134 > +++ > 1 file changed, 134 insertions(+) > > diff --git a/arch/arm64/boot/dts/mediatek/mt8192.dtsi

Re: [PATCH v3, 02/15] dt-bindings: mediatek: add description for mt8192 display

2021-01-11 Thread Chun-Kuang Hu
Hi, Yongqiang: Yongqiang Niu 於 2021年1月11日 週一 下午3:48寫道: > > add description for mt8192 display Applied to mediatek-drm-next [1], thanks. [1] https://git.kernel.org/pub/scm/linux/kernel/git/chunkuang.hu/linux.git/log/?h=mediatek-drm-next Regards, Chun-Kuang. > > Signed-off-by: Yongqiang Niu >

Re: [PATCH v3, 01/15] dt-bindings: mediatek: add description for postmask

2021-01-11 Thread Chun-Kuang Hu
Yongqiang Niu 於 2021年1月11日 週一 下午3:44寫道: > > add description for postmask > postmask is used control round corner for display frame After changing to 'used to control', Reviewed-by: Chun-Kuang Hu > > Signed-off-by: Yongqiang Niu > --- > Documentation/devicetree/bindings/display/mediatek/media

Re: [PATCH v3 4/6] dt-bindings: display: rockchip: dw-hdmi: Convert binding to YAML

2021-01-11 Thread Rob Herring
On Tue, Jan 05, 2021 at 08:08:16AM +0200, Laurent Pinchart wrote: > Convert the Rockchip HDMI TX text binding to YAML. > > Signed-off-by: Laurent Pinchart > --- > Changes since v2: > > - Use Mark's @gmail.com e-mail address as the @rock-chips.com address > bounces > > Changes since v1: > > -

Re: [PATCH v3 4/6] dt-bindings: display: rockchip: dw-hdmi: Convert binding to YAML

2021-01-11 Thread Laurent Pinchart
Hi Rob, On Mon, Jan 11, 2021 at 05:01:36PM -0600, Rob Herring wrote: > On Wed, Jan 06, 2021 at 05:17:55PM +0200, Laurent Pinchart wrote: > > Hi Rob, > > > > Given that the maintainers property is mandatory in the schema, what's > > the procedure when no maintainer steps up for a converter YAML bi

Re: [PATCH v3 4/6] dt-bindings: display: rockchip: dw-hdmi: Convert binding to YAML

2021-01-11 Thread Rob Herring
On Wed, Jan 06, 2021 at 05:17:55PM +0200, Laurent Pinchart wrote: > Hi Rob, > > Given that the maintainers property is mandatory in the schema, what's > the procedure when no maintainer steps up for a converter YAML binding ? Delete it if no one cares... Typically we just put a subsystem or plat

Re: [PATCH v3 3/6] dt-bindings: display: imx: hdmi: Convert binding to YAML

2021-01-11 Thread Rob Herring
On Tue, Jan 05, 2021 at 08:08:15AM +0200, Laurent Pinchart wrote: > Convert the i.MX6 HDMI TX text binding to YAML. > > Signed-off-by: Laurent Pinchart > --- > Changes since v1: > > - Only specify maxItems for clocks > - Drop reg and interrupts as they're checked in the base schema > - Rebase on

Re: [PATCH v8] backlight: lms283gf05: Convert to GPIO descriptors

2021-01-11 Thread Mark Brown
On Mon, Jan 11, 2021 at 10:40:46PM +0100, Linus Walleij wrote: > Mark, can I have your ACK for deleting > include/linux/spi/lms283gf05.h > As part of this patch sets? Acked-by: Mark Brown signature.asc Description: PGP signature ___ dri-devel mailing

Re: [PATCH v3 2/6] dt-bindings: display: bridge: renesas,dw-hdmi: Convert binding to YAML

2021-01-11 Thread Rob Herring
On Tue, Jan 05, 2021 at 08:08:14AM +0200, Laurent Pinchart wrote: > Convert the Renesas R-Car DWC HDMI TX text binding to YAML. > > Signed-off-by: Laurent Pinchart > --- > Changes since v2: > > - Update MAINTAINERS > > Changes since v1: > > - Drop the part numbers in comments, only keep the So

Re: [PATCH v3 1/6] dt-bindings: display: bridge: Add YAML schema for Synopsys DW-HDMI

2021-01-11 Thread Rob Herring
On Tue, Jan 05, 2021 at 08:08:13AM +0200, Laurent Pinchart wrote: > Add a .yaml schema containing the common properties for the Synopsys > DesignWare HDMI TX controller. This isn't a full device tree binding > specification, but is meant to be referenced by platform-specific > bindings for the IP c

Re: [PATCH] drm/bridge: ti-sn65dsi86: rename GPIO register bits

2021-01-11 Thread Doug Anderson
Hi, On Mon, Jan 11, 2021 at 2:16 PM Doug Anderson wrote: > > Hi, > > On Thu, Dec 10, 2020 at 12:19 AM Shawn Guo wrote: > > > > From: Shawn Guo > > > > It renames GPIO register bits to drop 'SN_' prefix, so that they are > > consistent to other definitions - prefixing register name with 'SN_' bu

Re: [PATCH] dt-bindings: display: Augment s6e63m0 bindings

2021-01-11 Thread Rob Herring
On Fri, 01 Jan 2021 12:45:22 +0100, Linus Walleij wrote: > This fixes the following problems with the s6e63m0 display > bindings: > > - When used on the DSI bus, the panel is listed directly as > a subnode on the DSI host so the "port" node is not > compulsory. Remove "port" from required prop

Re: [PATCH] drm/bridge: ti-sn65dsi86: rename GPIO register bits

2021-01-11 Thread Doug Anderson
Hi, On Thu, Dec 10, 2020 at 12:19 AM Shawn Guo wrote: > > From: Shawn Guo > > It renames GPIO register bits to drop 'SN_' prefix, so that they are > consistent to other definitions - prefixing register name with 'SN_' but > not for bit fields. > > Signed-off-by: Shawn Guo > --- > drivers/gpu/d

Re: [PATCH v2 1/2] dt-bindings: drm/bridge: anx7625: add DPI flag and swing setting

2021-01-11 Thread Rob Herring
On Thu, Dec 31, 2020 at 10:21:12AM +0800, Xin Ji wrote: > Add DPI flag for distinguish MIPI input signal type, DSI or DPI. Add > swing setting for adjusting DP tx PHY swing > > Signed-off-by: Xin Ji > --- > .../bindings/display/bridge/analogix,anx7625.yaml | 25 > -- > 1 fi

Re: [drm:dm_plane_helper_prepare_fb [amdgpu]] *ERROR* Failed to pin framebuffer with error -12

2021-01-11 Thread Mikhail Gavrilov
Hi Christian, On Tue, 12 Jan 2021 at 01:45, Christian König wrote: > > Hi Mike, > > Unfortunately not, that's DC stuff. Easiest is to assign this as a bug > tracker to our DC team. Ok > At least some progress. Any objections that I add your e-mail address as > tested-by tag? Yes, feel free add m

Re: [PATCH v2] drm/amdkfd: Fix out-of-bounds read in kdf_create_vcrat_image_cpu()

2021-01-11 Thread Felix Kuehling
Am 2021-01-11 um 4:05 p.m. schrieb Jeremy Cline: > KASAN reported a slab-out-of-bounds read of size 1 in > kdf_create_vcrat_image_cpu(). > > This occurs when, for example, when on an x86_64 with a single NUMA node > because kfd_fill_iolink_info_for_cpu() is a no-op, but afterwards the > sub_type_hd

Re: [PATCH 1/2] dt-bindings: panel-simple: add samsung,s6e3fa2 panel

2021-01-11 Thread Rob Herring
On Wed, 30 Dec 2020 17:17:10 +0200, Iskren Chernev wrote: > Add samsung,s6e3fa2 in the allowed simple-panel compat strings. > > Signed-off-by: Iskren Chernev > --- > .../devicetree/bindings/display/panel/panel-simple.yaml | 2 ++ > 1 file changed, 2 insertions(+) > Acked-by: Rob Herrin

Re: [PATCH v8] backlight: lms283gf05: Convert to GPIO descriptors

2021-01-11 Thread Linus Walleij
On Mon, Jan 11, 2021 at 5:19 PM Lee Jones wrote: > > ChangeLog v7->v8: > > - Rebase onto v5.11-rc1 > > - I wonder why this never seems to get merged...? > > Because you need SPI & PXA Acks and a merge plan. Ah you're right I completely missed that the include is down in include/spi/... Mark, ca

Re: [PATCH v2] drm: Check actual format for legacy pageflip.

2021-01-11 Thread Alex Deucher
On Mon, Jan 11, 2021 at 11:39 AM Bas Nieuwenhuizen wrote: > > On Mon, Jan 11, 2021 at 4:02 PM Alex Deucher wrote: > > > > On Sat, Jan 9, 2021 at 9:11 PM Bas Nieuwenhuizen > > wrote: > > > > > > With modifiers one can actually have different format_info structs > > > for the same format, which no

[Bug 209713] amdgpu drivers/gpu/drm/amd/amdgpu/../display/dc/dcn10/dcn10_link_encoder.c:483 dcn10_get_dig_frontend+0x9e/0xc0 [amdgpu] when resuming from S3 state

2021-01-11 Thread bugzilla-daemon
https://bugzilla.kernel.org/show_bug.cgi?id=209713 --- Comment #5 from Klaus Mueller (kmuel...@justmail.de) --- Seems to be fixed for me since the last firmware update for the Picasso driver: - xf86-video-amdgpu-19.1.0-lp152.67.5.x86_64 - kernel-firmware-20201218-lp152.36.1.noarch -- You may rep

[PATCH v2] drm/amdkfd: Fix out-of-bounds read in kdf_create_vcrat_image_cpu()

2021-01-11 Thread Jeremy Cline
KASAN reported a slab-out-of-bounds read of size 1 in kdf_create_vcrat_image_cpu(). This occurs when, for example, when on an x86_64 with a single NUMA node because kfd_fill_iolink_info_for_cpu() is a no-op, but afterwards the sub_type_hdr->length, which is out-of-bounds, is read and multiplied by

Re: [drm:dm_plane_helper_prepare_fb [amdgpu]] *ERROR* Failed to pin framebuffer with error -12

2021-01-11 Thread Christian König
Hi Mike, Am 11.01.21 um 20:23 schrieb Mikhail Gavrilov: On Mon, 11 Jan 2021 at 19:01, Christian König wrote: Changing the page table attributes while releasing memory might sleep. So we can't use a spinlock here. Thanks for the report, a patch to fix this is on the mailing list now. Can you

Re: [PATCH v3 01/12] drm: Add dummy page per device or GEM object

2021-01-11 Thread Andrey Grodzovsky
On 1/11/21 11:15 AM, Daniel Vetter wrote: On Mon, Jan 11, 2021 at 05:13:56PM +0100, Daniel Vetter wrote: On Fri, Jan 08, 2021 at 04:49:55PM +, Grodzovsky, Andrey wrote: Ok then, I guess I will proceed with the dummy pages list implementation then. Andrey

Re: [PATCH] drm/ttm: Fix address passed to dma_mapping_error() in ttm_pool_map()

2021-01-11 Thread Jeremy Cline
On Mon, Jan 11, 2021 at 09:21:48PM +0100, Christian König wrote: > Am 11.01.21 um 17:40 schrieb Jeremy Cline: > > check_unmap() is producing a warning about a missing map error check. > > The return value from dma_map_page() should be checked for an error, not > > the caller-provided dma_addr. > >

Re: [PATCH] drm/ttm: Fix address passed to dma_mapping_error() in ttm_pool_map()

2021-01-11 Thread Christian König
Am 11.01.21 um 17:40 schrieb Jeremy Cline: check_unmap() is producing a warning about a missing map error check. The return value from dma_map_page() should be checked for an error, not the caller-provided dma_addr. Fixes: d099fc8f540a ("drm/ttm: new TT backend allocation pool v3") Signed-off-by

Re: [drm:dm_plane_helper_prepare_fb [amdgpu]] *ERROR* Failed to pin framebuffer with error -12

2021-01-11 Thread Mikhail Gavrilov
On Mon, 11 Jan 2021 at 19:01, Christian König wrote: > Changing the page table attributes while releasing memory might sleep. > So we can't use a spinlock here. > > Thanks for the report, a patch to fix this is on the mailing list now. Can you look also the first trace? Here a same error message

[PATCH 40/40] drm/amd/display/dc/core/dc_stream: Demote non-conformant kernel-doc headers

2021-01-11 Thread Lee Jones
Fixes the following W=1 kernel build warning(s): drivers/gpu/drm/amd/amdgpu/../display/dc/core/dc_stream.c:253: warning: Function parameter or member 'pStream' not described in 'dc_optimize_timing_for_fsft' drivers/gpu/drm/amd/amdgpu/../display/dc/core/dc_stream.c:253: warning: Function param

[PATCH 39/40] drm/amd/display/dc/core/dc_surface: Demote kernel-doc abuse

2021-01-11 Thread Lee Jones
Fixes the following W=1 kernel build warning(s): drivers/gpu/drm/amd/amdgpu/../display/dc/core/dc_surface.c:119: warning: Cannot understand * Cc: Harry Wentland Cc: Leo Li Cc: Alex Deucher Cc: "Christian König" Cc

[PATCH 34/40] drm/amd/display/dc/dce110/dce110_transform_v: Demote kernel-doc abuse

2021-01-11 Thread Lee Jones
Fixes the following W=1 kernel build warning(s): drivers/gpu/drm/amd/amdgpu/../display/dc/dce110/dce110_transform_v.c:228: warning: bad line:void drivers/gpu/drm/amd/amdgpu/../display/dc/dce110/dce110_transform_v.c:233: warning: Function parameter or member 'xfm_dce' not described in 'pro

[PATCH 36/40] drm/amd/display/dc/dce100/dce100_resource: Make local functions and ones called by reference static

2021-01-11 Thread Lee Jones
Fixes the following W=1 kernel build warning(s): In file included from drivers/gpu/drm/amd/amdgpu/../display/dc/dce100/dce100_resource.c:54: drivers/gpu/drm/amd/amdgpu/../display/dc/dce100/dce100_resource.c:614:22: warning: no previous prototype for ‘dce100_link_encoder_create’ [-Wmissing-pro

[PATCH 32/40] drm/amd/display/dc/dce110/Makefile: Ignore -Woverride-init warning

2021-01-11 Thread Lee Jones
Fixes the following W=1 kernel build warning(s): In file included from drivers/gpu/drm/amd/amdgpu/../display/dc/dce110/dce110_resource.c:66: drivers/gpu/drm/amd/amdgpu/../include/asic_reg/dce/dce_11_0_sh_mask.h:5936:51: warning: initialized field overwritten [-Woverride-init] drivers/gpu/drm/

[PATCH 33/40] drm/amd/display/dc/dce110/dce110_resource: Make local functions invoked by reference static

2021-01-11 Thread Lee Jones
Fixes the following W=1 kernel build warning(s): drivers/gpu/drm/amd/amdgpu/../display/dc/dce110/dce110_resource.c:262:15: warning: initialized field overwritten [-Woverride-init] drivers/gpu/drm/amd/amdgpu/../display/dc/dce110/dce110_resource.c:266:2: note: in expansion of macro ‘stream_enc_r

[PATCH 35/40] drm/amd/display/dc/dce60/dce60_timing_generator: Make 'dce60_configure_crc' invoked by reference static

2021-01-11 Thread Lee Jones
Fixes the following W=1 kernel build warning(s): drivers/gpu/drm/amd/amdgpu/../display/dc/dce60/dce60_timing_generator.c:192:6: warning: no previous prototype for ‘dce60_configure_crc’ [-Wmissing-prototypes] Cc: Harry Wentland Cc: Leo Li Cc: Alex Deucher Cc: "Christian König" Cc: David Airl

[PATCH 38/40] drm/amd/display/dc/dce80/dce80_resource: Make local functions static

2021-01-11 Thread Lee Jones
Fixes the following W=1 kernel build warning(s): drivers/gpu/drm/amd/amdgpu/../display/dc/dce80/dce80_resource.c:527:17: warning: no previous prototype for ‘dce80_aux_engine_create’ [-Wmissing-prototypes] drivers/gpu/drm/amd/amdgpu/../display/dc/dce80/dce80_resource.c:565:20: warning: no prev

[PATCH 37/40] drm/amd/display/dc/dce60/dce60_resource: Make local functions static

2021-01-11 Thread Lee Jones
Fixes the following W=1 kernel build warning(s): drivers/gpu/drm/amd/amdgpu/../display/dc/dce60/dce60_resource.c:522:17: warning: no previous prototype for ‘dce60_aux_engine_create’ [-Wmissing-prototypes] drivers/gpu/drm/amd/amdgpu/../display/dc/dce60/dce60_resource.c:560:20: warning: no prev

[PATCH 26/40] drm/amd/display/dc/dce110/dce110_timing_generator: Demote kernel-doc abuses to standard function headers

2021-01-11 Thread Lee Jones
Fixes the following W=1 kernel build warning(s): drivers/gpu/drm/amd/amdgpu/../display/dc/dce110/dce110_timing_generator.c:79: warning: Cannot understand * drivers/gpu/drm/amd/amdgpu/../display/dc/dce110/dce110_timing

[PATCH 31/40] drm/amd/display/dc/dce110/dce110_mem_input_v: Include our own header, containing prototypes

2021-01-11 Thread Lee Jones
Fixes the following W=1 kernel build warning(s): drivers/gpu/drm/amd/amdgpu/../display/dc/dce110/dce110_mem_input_v.c:1034:6: warning: no previous prototype for ‘dce110_mem_input_v_construct’ [-Wmissing-prototypes] Cc: Harry Wentland Cc: Leo Li Cc: Alex Deucher Cc: "Christian König" Cc: Da

[PATCH 29/40] drm/amd/display/dc/dce112/dce112_resource: Make local functions and ones called by reference static

2021-01-11 Thread Lee Jones
Fixes the following W=1 kernel build warning(s): drivers/gpu/drm/amd/amdgpu/../display/dc/dce112/dce112_resource.c:620:22: warning: no previous prototype for ‘dce112_link_encoder_create’ [-Wmissing-prototypes] drivers/gpu/drm/amd/amdgpu/../display/dc/dce112/dce112_resource.c:674:32: warning:

[PATCH 27/40] drm/amd/display/dc/dce110/dce110_compressor: Strip out unused function 'controller_id_to_index'

2021-01-11 Thread Lee Jones
Fixes the following W=1 kernel build warning(s): drivers/gpu/drm/amd/amdgpu/../display/dc/dce110/dce110_compressor.c:429:14: warning: no previous prototype for ‘controller_id_to_index’ [-Wmissing-prototypes] Cc: Harry Wentland Cc: Leo Li Cc: Alex Deucher Cc: "Christian König" Cc: David Air

[PATCH 30/40] drm/amd/display/dc/dce110/dce110_timing_generator_v: Demote kernel-doc abuse and line up comments

2021-01-11 Thread Lee Jones
Fixes the following W=1 kernel build warning(s): drivers/gpu/drm/amd/amdgpu/../display/dc/dce110/dce110_timing_generator_v.c:54: warning: Function parameter or member 'tg' not described in 'dce110_timing_generator_v_enable_crtc' drivers/gpu/drm/amd/amdgpu/../display/dc/dce110/dce110_timing_g

[PATCH 28/40] drm/amd/display/dc/calcs/dce_calcs: Demote non-conformant kernel-doc function headers

2021-01-11 Thread Lee Jones
Fixes the following W=1 kernel build warning(s): drivers/gpu/drm/amd/amdgpu/../display/dc/calcs/dce_calcs.c:2753: warning: Function parameter or member 'vbios' not described in 'is_display_configuration_supported' drivers/gpu/drm/amd/amdgpu/../display/dc/calcs/dce_calcs.c:2753: warning: Funct

[PATCH 25/40] drm/amd/display/dc/dce120/dce120_timing_generator: Remove unused function 'dce120_timing_generator_get_position'

2021-01-11 Thread Lee Jones
Fixes the following W=1 kernel build warning(s): drivers/gpu/drm/amd/amdgpu/../display/dc/dce120/dce120_timing_generator.c:602:13: warning: ‘dce120_timing_generator_get_position’ defined but not used [-Wunused-function] Cc: Harry Wentland Cc: Leo Li Cc: Alex Deucher Cc: "Christian König"

[PATCH 23/40] drm/amd/display/dc/dce110/dce110_mem_input_v: Make local functions static

2021-01-11 Thread Lee Jones
Fixes the following W=1 kernel build warning(s): drivers/gpu/drm/amd/amdgpu/../display/dc/dce110/dce110_mem_input_v.c:471:6: warning: no previous prototype for ‘dce_mem_input_v_is_surface_pending’ [-Wmissing-prototypes] drivers/gpu/drm/amd/amdgpu/../display/dc/dce110/dce110_mem_input_v.c:486:6

[PATCH 24/40] drm/amd/pm/swsmu/smu11/vangogh_ppt: Make local function 'vangogh_clk_dpm_is_enabled' static

2021-01-11 Thread Lee Jones
Fixes the following W=1 kernel build warning(s): drivers/gpu/drm/amd/amdgpu/../pm/swsmu/smu11/vangogh_ppt.c:613:6: warning: no previous prototype for ‘vangogh_clk_dpm_is_enabled’ [-Wmissing-prototypes] Cc: Alex Deucher Cc: "Christian König" Cc: David Airlie Cc: Daniel Vetter Cc: Xiaojian Du

[PATCH 21/40] drm/amd/display/dc/dce110/dce110_compressor: Remove unused function 'dce110_get_required_compressed_surfacesize

2021-01-11 Thread Lee Jones
Fixes the following W=1 kernel build warning(s): drivers/gpu/drm/amd/amdgpu/../display/dc/dce110/dce110_compressor.c:415:6: warning: no previous prototype for ‘dce110_get_required_compressed_surfacesize’ [-Wmissing-prototypes] Cc: Harry Wentland Cc: Leo Li Cc: Alex Deucher Cc: "Christian Kö

[PATCH 19/40] drm/amd/display/dc/dce/dce_opp: Remove duplicate entries causing 'field overwritten' issues

2021-01-11 Thread Lee Jones
Fixes the following W=1 kernel build warning(s): In file included from drivers/gpu/drm/amd/amdgpu/../display/dc/dce112/dce112_resource.c:59: drivers/gpu/drm/amd/amdgpu/../include/asic_reg/dce/dce_11_2_sh_mask.h:10480:62: warning: initialized field overwritten [-Woverride-init] drivers/gpu/dr

  1   2   3   >