[PATCH v6 18/18] drm/i915/hdcp: Enable HDCP 2.2 MST support

2020-11-25 Thread Anshuman Gupta
Enable HDCP 2.2 over DP MST. Authenticate and enable port encryption only once for an active HDCP 2.2 session, once port is authenticated and encrypted enable encryption for each stream that requires encryption on this port. Similarly disable the stream encryption for each encrypted stream, once a

[PATCH v6 17/18] drm/i915/hdcp: Support for HDCP 2.2 MST shim callbacks

2020-11-25 Thread Anshuman Gupta
Add support for HDCP 2.2 DP MST shim callback. This adds existing DP HDCP shim callback for Link Authentication and Encryption and HDCP 2.2 stream encryption callback. v2: - Added a WARN_ON() instead of drm_err. [Uma] - Cosmetic changes. [Uma] v3: - 's/port_data/hdcp_port_data' [Ram] - skip redund

[PATCH v6 14/18] drm/i915/hdcp: MST streams support in hdcp port_data

2020-11-25 Thread Anshuman Gupta
Add support for multiple mst stream in hdcp port data which will be used by RepeaterAuthStreamManage msg and HDCP 2.2 security f/w for m' validation. Security f/w doesn't have any provision to mark the stream_type for each stream separately, it just take single input of stream_type while authentic

[PATCH v6 15/18] drm/i915/hdcp: Pass connector to check_2_2_link

2020-11-25 Thread Anshuman Gupta
This requires for HDCP 2.2 MST check link. As for DP/HDMI shims check_2_2_link retrieves the connector from dig_port, this is not sufficient or DP MST connector, there can be multiple DP MST topology connector associated with same dig_port. Cc: Ramalingam C Reviewed-by: Uma Shankar Reviewed-by:

[PATCH v6 16/18] drm/i915/hdcp: Add HDCP 2.2 stream register

2020-11-25 Thread Anshuman Gupta
Add HDCP 2.2 DP MST HDCP2_STREAM_STATUS and HDCP2_AUTH_STREAM register in i915_reg header. Cc: Ramalingam C Reviewed-by: Uma Shankar Reviewed-by: Ramalingam C Tested-by: Karthik B S Signed-off-by: Anshuman Gupta --- drivers/gpu/drm/i915/i915_reg.h | 30 ++ 1 file

[PATCH v6 13/18] drm/hdcp: Max MST content streams

2020-11-25 Thread Anshuman Gupta
Let's define Maximum MST content streams up to four generically which can be supported by modern display controllers. Cc: Sean Paul Cc: Ramalingam C Acked-by: Maarten Lankhorst Reviewed-by: Uma Shankar Reviewed-by: Ramalingam C Tested-by: Karthik B S Signed-off-by: Anshuman Gupta --- inclu

[PATCH v6 08/18] drm/i915/hdcp: Enable HDCP 1.4 stream encryption

2020-11-25 Thread Anshuman Gupta
Enable HDCP 1.4 DP MST stream encryption. Enable stream encryption once encryption is enabled on the DP transport driving the link for each stream which has requested encryption. Disable stream encryption for each stream that no longer requires encryption before disabling HDCP encryption on the l

[PATCH v6 12/18] misc/mei/hdcp: Fix AUTH_STREAM_REQ cmd buffer len

2020-11-25 Thread Anshuman Gupta
Fix the size of WIRED_REPEATER_AUTH_STREAM_REQ cmd buffer size. It is based upon the actual number of MST streams and size of wired_cmd_repeater_auth_stream_req_in. Excluding the size of hdcp_cmd_header. v2: - hdcp_cmd_header size annotation nitpick. [Tomas] Cc: Tomas Winkler Cc: Ramalingam C A

[PATCH v6 11/18] drm/i915/hdcp: Encapsulate hdcp_port_data to dig_port

2020-11-25 Thread Anshuman Gupta
hdcp_port_data is specific to a port on which HDCP encryption is getting enabled, so encapsulate it to intel_digital_port. This will be required to enable HDCP 2.2 stream encryption. v2: - 's/port_data/hdcp_port_data'. [Ram] Cc: Ramalingam C Reviewed-by: Uma Shankar Reviewed-by: Ramalingam C T

[PATCH v6 10/18] drm/i915/hdcp: Pass dig_port to intel_hdcp_init

2020-11-25 Thread Anshuman Gupta
Pass dig_port as an argument to intel_hdcp_init() and intel_hdcp2_init(). This will be required for HDCP 2.2 stream encryption. Cc: Ramalingam C Reviewed-by: Uma Shankar Reviewed-by: Ramalingam C Tested-by: Karthik B S Signed-off-by: Anshuman Gupta --- drivers/gpu/drm/i915/display/intel_dp_h

[PATCH v6 09/18] drm/i915/hdcp: Enable Gen12 HDCP 1.4 DP MST support

2020-11-25 Thread Anshuman Gupta
Enable HDCP 1.4 over DP MST for Gen12. v2: - Enable HDCP for <= Gen12 platforms. [Ram] Cc: Ramalingam C Tested-by: Karthik B S Signed-off-by: Anshuman Gupta --- drivers/gpu/drm/i915/display/intel_dp_mst.c | 6 ++ 1 file changed, 2 insertions(+), 4 deletions(-) diff --git a/drivers/gpu/dr

[PATCH v6 07/18] drm/i915/hdcp: HDCP stream encryption support

2020-11-25 Thread Anshuman Gupta
Both HDCP_{1.x,2.x} requires to select/deselect Multistream HDCP bit in TRANS_DDI_FUNC_CTL in order to enable/disable stream HDCP encryption over DP MST Transport Link. HDCP 1.4 stream encryption requires to validate the stream encryption status in HDCP_STATUS_{TRANSCODER,PORT} register driving th

[PATCH v6 06/18] drm/i915/hdcp: Move HDCP enc status timeout to header

2020-11-25 Thread Anshuman Gupta
DP MST stream encryption status requires time of a link frame in order to change its status, but as there were some HDCP encryption timeout observed earlier, it is safer to use ENCRYPT_STATUS_CHANGE_TIMEOUT_MS timeout for stream status too, it requires to move the macro to a header. It will be used

[PATCH v6 05/18] drm/i915/hdcp: DP MST transcoder for link and stream

2020-11-25 Thread Anshuman Gupta
Gen12 has H/W delta with respect to HDCP{1.x,2.x} display engine instances lies in Transcoder instead of DDI as in Gen11. This requires hdcp driver to use mst_master_transcoder for link authentication and stream transcoder for stream encryption separately. This will be used for both HDCP 1.4 and

[PATCH v6 04/18] drm/i915/hdcp: No HDCP when encoder is't initialized

2020-11-25 Thread Anshuman Gupta
There can be situation when DP MST connector is created without mst modeset being done, in those cases connector->encoder will be NULL. MST connector->encoder initializes after modeset. Don't enable HDCP in such cases to prevent any crash. Cc: Ramalingam C Cc: Juston Li Signed-off-by: Anshuman G

[PATCH v6 03/18] drm/i915/hotplug: Handle CP_IRQ for DP-MST

2020-11-25 Thread Anshuman Gupta
Handle CP_IRQ in DEVICE_SERVICE_IRQ_VECTOR_ESI0 It requires to call intel_hdcp_handle_cp_irq() in case of CP_IRQ is triggered by a sink in DP-MST topology. Cc: "Ville Syrjälä" Cc: Ramalingam C Reviewed-by: Uma Shankar Reviewed-by: Ramalingam C Tested-by: Karthik B S Signed-off-by: Anshuman Gu

[PATCH v6 02/18] drm/i915/hdcp: Get conn while content_type changed

2020-11-25 Thread Anshuman Gupta
Get DRM connector reference count while scheduling a prop work to avoid any possible destroy of DRM connector when it is in DRM_CONNECTOR_REGISTERED state. Fixes: a6597faa2d59 ("drm/i915: Protect workers against disappearing connectors") Cc: Sean Paul Cc: Ramalingam C Reviewed-by: Uma Shankar

[PATCH v6 01/18] drm/i915/hdcp: Update CP property in update_pipe

2020-11-25 Thread Anshuman Gupta
When crtc state need_modeset is true it is not necessary it is going to be a real modeset, it can turns to be a fastset instead of modeset. This turns content protection property to be DESIRED and hdcp update_pipe left with property to be in DESIRED state but actual hdcp->value was ENABLED. This i

[PATCH v6 00/18] HDCP 2.2 and HDCP 1.4 Gen12 DP MST support

2020-11-25 Thread Anshuman Gupta
This is v6 version to test with IGT https://patchwork.freedesktop.org/series/82987/ This v6 has added a new patch to series to avoid a crash reported on Chrome-OS and has addressed the few cosmetics review comments from Ram. It has been also tested manually with above IGT series. [PATCH v6 12/18]

Re: [PATCH] drm/nouveau: fix relocations applying logic and a double-free

2020-11-25 Thread Daniel Vetter
On Mon, Nov 23, 2020 at 10:51:25AM +0100, Daniel Vetter wrote: > On Fri, Nov 20, 2020 at 4:23 PM Matti Hamalainen wrote: > > > > Commit 03e0d26fcf79 ("drm/nouveau: slowpath for pushbuf ioctl") included > > a logic-bug which results in the relocations not actually getting > > applied at all as the

[Bug 210369] amdgpu fails to resume from suspend

2020-11-25 Thread bugzilla-daemon
https://bugzilla.kernel.org/show_bug.cgi?id=210369 --- Comment #1 from sevenever (sevene...@gmail.com) --- lspci output: 00:00.0 Host bridge: Advanced Micro Devices, Inc. [AMD] Renoir Root Complex 00:00.2 IOMMU: Advanced Micro Devices, Inc. [AMD] Renoir IOMMU 00:01.0 Host bridge: Advanced Micro De

[Bug 210369] New: amdgpu fails to resume from suspend

2020-11-25 Thread bugzilla-daemon
https://bugzilla.kernel.org/show_bug.cgi?id=210369 Bug ID: 210369 Summary: amdgpu fails to resume from suspend Product: Drivers Version: 2.5 Kernel Version: 5.9.10-050910-generic #202011221708 Hardware: All OS: Linux

[PULL] drm-intel-fixes

2020-11-25 Thread Rodrigo Vivi
Hi Dave and Daniel, Please notice that commit eb0104ee498d ("drm/i915/gt: Track signaled breadcrumbs outside of the breadcrumb spinlock") is just a dependency of commit 2e6ce8313a53 ("drm/i915/gt: Don't cancel the interrupt shadow too early"). Here goes drm-intel-fixes-2020-11-25: - Fix Perf/OA

Re: [Intel-gfx] [RFC v2 3/8] drm/i915: Keep track of pwm-related backlight hooks separately

2020-11-25 Thread Dave Airlie
On Thu, 17 Sept 2020 at 03:19, Lyude Paul wrote: > > Currently, every different type of backlight hook that i915 supports is > pretty straight forward - you have a backlight, probably through PWM > (but maybe DPCD), with a single set of platform-specific hooks that are > used for controlling it. >

RE: [PATCH rdma-core 3/5] pyverbs: Add dma-buf based MR support

2020-11-25 Thread Xiong, Jianxin
> -Original Message- > From: Jason Gunthorpe > Sent: Wednesday, November 25, 2020 4:00 PM > To: Xiong, Jianxin > Cc: Daniel Vetter ; Leon Romanovsky ; > linux-r...@vger.kernel.org; dri-devel@lists.freedesktop.org; > Doug Ledford ; Vetter, Daniel ; > Christian Koenig > Subject: Re: [PAT

Re: [PATCH 6/6] drm/sched: Make use of a "done" thread

2020-11-25 Thread Luben Tuikov
On 2020-11-25 06:09, Steven Price wrote: > On 25/11/2020 03:17, Luben Tuikov wrote: >> Add a "done" list to which all completed jobs are added >> to be freed. The drm_sched_job_done() callback is the >> producer of jobs to this list. >> >> Add a "done" thread which consumes from the done list >> an

Re: [PATCH 6/6] drm/sched: Make use of a "done" thread

2020-11-25 Thread Luben Tuikov
On 2020-11-25 05:10, Christian König wrote: > Am 25.11.20 um 04:17 schrieb Luben Tuikov: >> Add a "done" list to which all completed jobs are added >> to be freed. The drm_sched_job_done() callback is the >> producer of jobs to this list. >> >> Add a "done" thread which consumes from the done list

[Bug 210123] drm:drm_atomic_helper_wait_for_dependencies [drm_kms_helper]] - flip_done time out with vmwgfx

2020-11-25 Thread bugzilla-daemon
https://bugzilla.kernel.org/show_bug.cgi?id=210123 --- Comment #6 from Stefan Mayr (stefan+ker...@mayr-stefan.de) --- Kernel 5.1.16 also showed the error message after 2 days. So this seems to be triggered by changes between 5.0.13 and 5.1.16. I'm out of SUSE Kernels to narrow it down even more.

Re: [PATCH] iommu/io-pgtable: Remove tlb_flush_leaf

2020-11-25 Thread Jordan Crouse
On Wed, Nov 25, 2020 at 06:24:13PM +, Robin Murphy wrote: > On 2020-11-25 17:29, Robin Murphy wrote: > >The only user of tlb_flush_leaf is a particularly hairy corner of the > >Arm short-descriptor code, which wants a synchronous invalidation to > >minimise the races inherent in trying to split

Re: [Intel-wired-lan] [PATCH 000/141] Fix fall-through warnings for Clang

2020-11-25 Thread Kees Cook
On Tue, Nov 24, 2020 at 11:05:35PM -0800, James Bottomley wrote: > Now, what we have seems to be about 6 cases (at least what's been shown > in this thread) where a missing break would cause potentially user > visible issues. That means the value of this isn't zero, but it's not > a no-brainer mas

Re: [PATCH][next] drm/mcde: fix masking and bitwise-or on variable val

2020-11-25 Thread Linus Walleij
On Tue, Nov 24, 2020 at 1:15 PM Colin King wrote: > From: Colin Ian King > > The masking of val with ~MCDE_CRX1_CLKSEL_MASK is currently being > ignored because there seems to be a missing bitwise-or of val in the > following statement. Fix this by replacing the assignment of val > with a bitwi

RE: [PATCH v2 13/13] drm/i915: Configure PCON for DSC1.1 to DSC1.2 encoding

2020-11-25 Thread Shankar, Uma
> -Original Message- > From: Nautiyal, Ankit K > Sent: Sunday, November 1, 2020 3:37 PM > To: intel-...@lists.freedesktop.org > Cc: dri-devel@lists.freedesktop.org; Shankar, Uma ; > Kulkarni, Vandita ; ville.syrj...@linux.intel.com; > Sharma, Swati2 > Subject: [PATCH v2 13/13] drm/i915

RE: [PATCH v2 12/13] drm/i915: Add helper functions for calculating DSC parameters for HDMI2.1

2020-11-25 Thread Shankar, Uma
> -Original Message- > From: Nautiyal, Ankit K > Sent: Sunday, November 1, 2020 3:37 PM > To: intel-...@lists.freedesktop.org > Cc: dri-devel@lists.freedesktop.org; Shankar, Uma ; > Kulkarni, Vandita ; ville.syrj...@linux.intel.com; > Sharma, Swati2 > Subject: [PATCH v2 12/13] drm/i915

[PATCH v2 3/3] drm/nouveau: clean up all clients on device removal

2020-11-25 Thread Jeremy Cline
The postclose handler can run after the device has been removed (or the driver has been unbound) since userspace clients are free to hold the file open as long as they want. Because the device removal callback frees the entire nouveau_drm structure, any reference to it in the postclose handler will

[PATCH v2 2/3] drm/nouveau: Add a dedicated mutex for the clients list

2020-11-25 Thread Jeremy Cline
Rather than protecting the nouveau_drm clients list with the lock within the "client" nouveau_cli, add a dedicated lock to serialize access to the list. This is both clearer and necessary to avoid lockdep being upset with us when we need to iterate through all the clients in the list and potentiall

[PATCH v2 1/3] drm/nouveau: use drm_dev_unplug() during device removal

2020-11-25 Thread Jeremy Cline
Nouveau does not currently support hot-unplugging, but it still makes sense to switch from drm_dev_unregister() to drm_dev_unplug(). drm_dev_unplug() calls drm_dev_unregister() after marking the device as unplugged, but only after any device critical sections are finished. Since nouveau isn't usin

[PATCH v2 0/3] drm/nouveau: fix a use-after-free in postclose()

2020-11-25 Thread Jeremy Cline
This series fixes a number of use-after-frees in nouveau's postclose() handler. It was discovered by pointing IGT's core_hotunplug tests at a nouveau device, but the steps to reproduce it are simple: 1. Open the device file 2. Unbind the driver or remove the device 3. Close the file opened in step

Re: [PATCH 2/3] drm/nouveau: Add a dedicated mutex for the clients list

2020-11-25 Thread Jeremy Cline
On Wed, Nov 25, 2020 at 01:37:06PM -0500, Lyude Paul wrote: > On Tue, 2020-11-03 at 14:49 -0500, Jeremy Cline wrote: > > Rather than protecting the nouveau_drm clients list with the lock within > > the "client" nouveau_cli, add a dedicated lock to serialize access to > > the list. This is both clea

Re: [PATCH] drm/modes: Switch to 64bit maths to avoid integer overflow

2020-11-25 Thread Chris Wilson
Quoting Ville Syrjälä (2020-10-30 14:43:46) > On Fri, Oct 30, 2020 at 02:19:45PM +, Chris Wilson wrote: > > Quoting Ville Syrjala (2020-10-22 20:42:56) > > > From: Ville Syrjälä > > > > > > The new >8k CEA modes have dotclocks reaching 5.94 GHz, which > > > means our clock*1000 will now overf

Re: [PATCH v3 05/12] drm/ttm: Expose ttm_tt_unpopulate for driver use

2020-11-25 Thread Andrey Grodzovsky
On 11/25/20 11:36 AM, Daniel Vetter wrote: On Wed, Nov 25, 2020 at 01:57:40PM +0100, Christian König wrote: Am 25.11.20 um 11:40 schrieb Daniel Vetter: On Tue, Nov 24, 2020 at 05:44:07PM +0100, Christian König wrote: Am 24.11.20 um 17:22 schrieb Andrey Grodzovsky: On 11/24/20 2:41 AM, Christ

RE: [PATCH rdma-core 3/5] pyverbs: Add dma-buf based MR support

2020-11-25 Thread Xiong, Jianxin
> -Original Message- > From: Jason Gunthorpe > Sent: Wednesday, November 25, 2020 4:15 AM > To: Daniel Vetter > Cc: Xiong, Jianxin ; Leon Romanovsky > ; linux-r...@vger.kernel.org; dri- > de...@lists.freedesktop.org; Doug Ledford ; Vetter, > Daniel ; Christian Koenig > > Subject: Re: [

Re: [PATCH 3/3] drm/nouveau: clean up all clients on device removal

2020-11-25 Thread Lyude Paul
On Tue, 2020-11-03 at 14:49 -0500, Jeremy Cline wrote: > The postclose handler can run after the device has been removed (or the > driver has been unbound) since userspace clients are free to hold the > file open the file as long as they want. Because the device removal ^ typo

Re: [PATCH 2/3] drm/nouveau: Add a dedicated mutex for the clients list

2020-11-25 Thread Lyude Paul
On Tue, 2020-11-03 at 14:49 -0500, Jeremy Cline wrote: > Rather than protecting the nouveau_drm clients list with the lock within > the "client" nouveau_cli, add a dedicated lock to serialize access to > the list. This is both clearer and necessary to avoid lockdep being > upset with us when we nee

Re: [PATCH] iommu/io-pgtable: Remove tlb_flush_leaf

2020-11-25 Thread Robin Murphy
On 2020-11-25 17:29, Robin Murphy wrote: The only user of tlb_flush_leaf is a particularly hairy corner of the Arm short-descriptor code, which wants a synchronous invalidation to minimise the races inherent in trying to split a large page mapping. This is already far enough into "here be dragons

Re: [PATCH] drm/ttm: don't set page->mapping

2020-11-25 Thread Daniel Stone
Hi, On Wed, 25 Nov 2020 at 18:06, Jason Gunthorpe wrote: > On Wed, Nov 25, 2020 at 05:28:32PM +0100, Daniel Vetter wrote: > > Apologies again, this shouldn't have been included. But at least I > > have an idea now why this patch somehow was included in the git > > send-email. Lovely interface :-/

Re: [PATCH v3 08/12] drm/amdgpu: Split amdgpu_device_fini into early and late

2020-11-25 Thread Andrey Grodzovsky
On 11/25/20 5:41 AM, Daniel Vetter wrote: On Tue, Nov 24, 2020 at 10:51:57AM -0500, Andrey Grodzovsky wrote: On 11/24/20 9:53 AM, Daniel Vetter wrote: On Sat, Nov 21, 2020 at 12:21:18AM -0500, Andrey Grodzovsky wrote: Some of the stuff in amdgpu_device_fini such as HW interrupts disable and

Re: [PATCH v3 10/12] drm/amdgpu: Avoid sysfs dirs removal post device unplug

2020-11-25 Thread Andrey Grodzovsky
On 11/25/20 4:04 AM, Daniel Vetter wrote: On Tue, Nov 24, 2020 at 11:27 PM Andrey Grodzovsky wrote: On 11/24/20 9:49 AM, Daniel Vetter wrote: On Sat, Nov 21, 2020 at 12:21:20AM -0500, Andrey Grodzovsky wrote: Avoids NULL ptr due to kobj->sd being unset on device removal. Signed-off-by: And

[Bug 205675] Display locks up. AMDGPU timeout

2020-11-25 Thread bugzilla-daemon
https://bugzilla.kernel.org/show_bug.cgi?id=205675 --- Comment #41 from serbsersntr (jesirok...@btsese.com) --- https://gitlab.com/gitlab-org/gitlab/-/issues/288077 https://gitlab.com/gitlab-org/gitlab/-/issues/288078 https://gitlab.com/gitlab-org/gitlab/-/issues/288079 https://gitlab.com/gitlab-o

[PATCH] iommu/io-pgtable: Remove tlb_flush_leaf

2020-11-25 Thread Robin Murphy
The only user of tlb_flush_leaf is a particularly hairy corner of the Arm short-descriptor code, which wants a synchronous invalidation to minimise the races inherent in trying to split a large page mapping. This is already far enough into "here be dragons" territory that no sensible caller should

Re: [PATCH v3 05/12] drm/ttm: Expose ttm_tt_unpopulate for driver use

2020-11-25 Thread Daniel Vetter
On Wed, Nov 25, 2020 at 5:56 PM Michel Dänzer wrote: > > On 2020-11-25 1:57 p.m., Christian König wrote: > > > > Well thinking more about this, it seems to be a another really good > > argument why mapping pages from DMA-bufs into application address space > > directly is a very bad idea :) > > Ap

Re: [PATCH 5/6] drm/amdgpu: Don't hardcode thread name length

2020-11-25 Thread Luben Tuikov
On 2020-11-25 04:55, Christian König wrote: > Am 25.11.20 um 04:17 schrieb Luben Tuikov: >> Introduce a macro DRM_THREAD_NAME_LEN >> and use that to define ring name size, >> instead of hardcoding it to 16. >> >> Signed-off-by: Luben Tuikov >> --- >> drivers/gpu/drm/amd/amdgpu/amdgpu_ring.h | 2

Re: [PATCH v3 05/12] drm/ttm: Expose ttm_tt_unpopulate for driver use

2020-11-25 Thread Michel Dänzer
On 2020-11-25 1:57 p.m., Christian König wrote: Well thinking more about this, it seems to be a another really good argument why mapping pages from DMA-bufs into application address space directly is a very bad idea :) Apologies for going off on a tangent here... Since allowing userspace mm

[Bug 210123] drm:drm_atomic_helper_wait_for_dependencies [drm_kms_helper]] - flip_done time out with vmwgfx

2020-11-25 Thread bugzilla-daemon
https://bugzilla.kernel.org/show_bug.cgi?id=210123 Zack Rusin (za...@vmware.com) changed: What|Removed |Added CC||za...@vmware.com --- Comm

Re: [PATCH v3 4/6] drm/tidss: Set bus_format correctly from bridge/connector

2020-11-25 Thread Tomi Valkeinen
Hi Nikhil, On 19/11/2020 18:01, Nikhil Devshatwar wrote: > Remove the old code to iterate over the bridge chain, as this is > already done by the framework. > The bridge state should have the negotiated bus format and flags. > Use these from the bridge's state. > If the bridge does not support for

Re: [PATCH 3/6] drm/scheduler: Job timeout handler returns status

2020-11-25 Thread Luben Tuikov
On 2020-11-25 04:50, Christian König wrote: > Am 25.11.20 um 04:17 schrieb Luben Tuikov: >> The job timeout handler now returns status >> indicating back to the DRM layer whether the job >> was successfully cancelled or whether more time >> should be given to the job to complete. >> >> Signed-off-b

[Bug 205675] Display locks up. AMDGPU timeout

2020-11-25 Thread bugzilla-daemon
https://bugzilla.kernel.org/show_bug.cgi?id=205675 serbsersntr (jesirok...@btsese.com) changed: What|Removed |Added CC||jesirok...@btsese.co

[pull] amdgpu, radeon drm-next-5.11

2020-11-25 Thread Alex Deucher
Hi Dave, Daniel, More updates for 5.11. The following changes since commit 178631700f9dc40df754acbe766b55753ddcbfec: drm/amd/pm: fix spelling mistakes in dev_warn messages (2020-11-17 14:07:26 -0500) are available in the Git repository at: git://people.freedesktop.org/~agd5f/linux tags/am

Re: [PATCH 2/6] gpu/drm: ring_mirror_list --> pending_list

2020-11-25 Thread Luben Tuikov
On 2020-11-25 04:47, Christian König wrote: > Am 25.11.20 um 04:17 schrieb Luben Tuikov: >> Rename "ring_mirror_list" to "pending_list", >> to describe what something is, not what it does, >> how it's used, or how the hardware implements it. >> >> This also abstracts the actual hardware >> implemen

Re: [PATCH v3 05/12] drm/ttm: Expose ttm_tt_unpopulate for driver use

2020-11-25 Thread Daniel Vetter
On Wed, Nov 25, 2020 at 01:57:40PM +0100, Christian König wrote: > Am 25.11.20 um 11:40 schrieb Daniel Vetter: > > On Tue, Nov 24, 2020 at 05:44:07PM +0100, Christian König wrote: > > > Am 24.11.20 um 17:22 schrieb Andrey Grodzovsky: > > > > On 11/24/20 2:41 AM, Christian König wrote: > > > > > Am

Re: [PATCH 4/7] drm/radeon: Pin buffers while they are vmap'ed

2020-11-25 Thread Daniel Vetter
On Wed, Nov 25, 2020 at 12:38:01PM +0100, Thomas Zimmermann wrote: > Hi > > Am 25.11.20 um 11:36 schrieb Daniel Vetter: > > On Wed, Nov 25, 2020 at 11:13:13AM +0100, Christian König wrote: > > > Am 25.11.20 um 09:37 schrieb Thomas Zimmermann: > > > > Hi > > > > > > > > Am 24.11.20 um 15:09 schrie

Re: [PATCH] drm/ttm: don't set page->mapping

2020-11-25 Thread Daniel Vetter
On Wed, Nov 25, 2020 at 5:25 PM Daniel Vetter wrote: > > Random observation while trying to review Christian's patch series to > stop looking at struct page for dma-buf imports. > > This was originally added in > > commit 58aa6622d32af7d2c08d45085f44c54554a16ed7 > Author: Thomas Hellstrom > Date:

[PATCH v4 3/3] locking/selftests: Add testcases for fs_reclaim

2020-11-25 Thread Daniel Vetter
Since I butchered this I figured better to make sure we have testcases for this now. Since we only have a locking context for __GFP_FS that's the only thing we're testing right now. Acked-by: Peter Zijlstra (Intel) Cc: linux-fsde...@vger.kernel.org Cc: Dave Chinner Cc: Qian Cai Cc: linux-...@vg

[PATCH] drm/ttm: don't set page->mapping

2020-11-25 Thread Daniel Vetter
Random observation while trying to review Christian's patch series to stop looking at struct page for dma-buf imports. This was originally added in commit 58aa6622d32af7d2c08d45085f44c54554a16ed7 Author: Thomas Hellstrom Date: Fri Jan 3 11:47:23 2014 +0100 drm/ttm: Correctly set page mapp

[PATCH v4 0/3] mmu_notifier vs fs_reclaim lockdep annotations

2020-11-25 Thread Daniel Vetter
Hi all, Just resending with the polish applied, no functional changes at all. Previous versions. v3: https://lore.kernel.org/dri-devel/20201120095445.1195585-1-daniel.vet...@ffwll.ch/ v2: https://lore.kernel.org/dri-devel/20200610194101.1668038-1-daniel.vet...@ffwll.ch/ Changes since v3: - mo

[PATCH v4 2/3] mm: Extract might_alloc() debug check

2020-11-25 Thread Daniel Vetter
Extracted from slab.h, which seems to have the most complete version including the correct might_sleep() check. Roll it out to slob.c. Motivated by a discussion with Paul about possibly changing call_rcu behaviour to allocate memory, but only roughly every 500th call. There are a lot fewer places

[PATCH v4 1/3] mm: Track mmu notifiers in fs_reclaim_acquire/release

2020-11-25 Thread Daniel Vetter
fs_reclaim_acquire/release nicely catch recursion issues when allocating GFP_KERNEL memory against shrinkers (which gpu drivers tend to use to keep the excessive caches in check). For mmu notifier recursions we do have lockdep annotations since 23b68395c7c7 ("mm/mmu_notifiers: add a lockdep map for

Re: [Intel-wired-lan] [PATCH 000/141] Fix fall-through warnings for Clang

2020-11-25 Thread Jakub Kicinski
On Wed, 25 Nov 2020 04:24:27 -0800 Nick Desaulniers wrote: > I even agree that most of the churn comes from > > case 0: > ++x; > default: > break; And just to spell it out, case ENUM_VALUE1: bla(); break; case ENUM_VALUE2: bla(); default: break; is a fairly i

[pull] amdgpu drm-fixes-5.10

2020-11-25 Thread Alex Deucher
Hi Dave, Daniel, Fixes for 5.10. The following changes since commit 6600f9d52213b5c3455481b5c9e61cf5e305c0e6: Merge tag 'drm-intel-fixes-2020-11-19' of git://anongit.freedesktop.org/drm/drm-intel into drm-fixes (2020-11-20 11:21:54 +1000) are available in the Git repository at: git://peo

RE: [PATCH][next] drm/amdgpu: Fix sizeof() mismatch in bps_bo kmalloc_array creation

2020-11-25 Thread Chen, Guchun
[AMD Public Use] Reviewed-by: Guchun Chen Regards, Guchun -Original Message- From: Colin King Sent: Wednesday, November 25, 2020 10:18 PM To: Deucher, Alexander ; Koenig, Christian ; David Airlie ; Daniel Vetter ; Zhou1, Tao ; Chen, Guchun ; amd-...@lists.freedesktop.org; dri-deve

[PATCH] drm/radeon: fix check order in radeon_bo_move

2020-11-25 Thread Christian König
Reorder the code to fix checking if blitting is available. Signed-off-by: Christian König --- drivers/gpu/drm/radeon/radeon_ttm.c | 54 + 1 file changed, 24 insertions(+), 30 deletions(-) diff --git a/drivers/gpu/drm/radeon/radeon_ttm.c b/drivers/gpu/drm/radeon/rade

Re: [PATCH][next] drm/amdgpu: Fix sizeof() mismatch in bps_bo kmalloc_array creation

2020-11-25 Thread Christian König
Am 25.11.20 um 15:18 schrieb Colin King: From: Colin Ian King An incorrect sizeof() is being used, sizeof((*data)->bps_bo) is not correct, it should be sizeof(*(*data)->bps_bo). It just so happens to work because the sizes are the same. Fix it. Addresses-Coverity: ("Sizeof not portable (SIZE

[PATCH][next] drm/amdgpu: Fix sizeof() mismatch in bps_bo kmalloc_array creation

2020-11-25 Thread Colin King
From: Colin Ian King An incorrect sizeof() is being used, sizeof((*data)->bps_bo) is not correct, it should be sizeof(*(*data)->bps_bo). It just so happens to work because the sizes are the same. Fix it. Addresses-Coverity: ("Sizeof not portable (SIZEOF_MISMATCH)") Fixes: 5278a159cf35 ("drm/am

Re: [PATCH 11/15] drm/radeon: Remove references to struct drm_device.pdev

2020-11-25 Thread Alex Deucher
On Tue, Nov 24, 2020 at 6:39 AM Thomas Zimmermann wrote: > > Using struct drm_device.pdev is deprecated. Convert radeon to struct > drm_device.dev. No functional changes. > > Signed-off-by: Thomas Zimmermann > Cc: Alex Deucher > Cc: Christian König There are a few unrelated whitespace changes.

Re: [PATCH 01/15] drm/amdgpu: Remove references to struct drm_device.pdev

2020-11-25 Thread Alex Deucher
On Tue, Nov 24, 2020 at 6:38 AM Thomas Zimmermann wrote: > > Using struct drm_device.pdev is deprecated. Convert amdgpu to struct > drm_device.dev. No functional changes. > > Signed-off-by: Thomas Zimmermann > Cc: Alex Deucher > Cc: Christian König There are a few unrelated whitespace changes.

Re: [PATCHv10 0/9] System Cache support for GPU and required SMMU support

2020-11-25 Thread Will Deacon
On Wed, 25 Nov 2020 12:30:09 +0530, Sai Prakash Ranjan wrote: > Some hardware variants contain a system cache or the last level > cache(llc). This cache is typically a large block which is shared > by multiple clients on the SOC. GPU uses the system cache to cache > both the GPU data buffers(like t

Re: [PATCHv10 0/9] System Cache support for GPU and required SMMU support

2020-11-25 Thread Will Deacon
On Wed, 25 Nov 2020 12:30:09 +0530, Sai Prakash Ranjan wrote: > Some hardware variants contain a system cache or the last level > cache(llc). This cache is typically a large block which is shared > by multiple clients on the SOC. GPU uses the system cache to cache > both the GPU data buffers(like t

[PATCH 7/7] drm/prime: split array import functions v4

2020-11-25 Thread Christian König
Mapping the imported pages of a DMA-buf into an userspace process doesn't work as expected. But we have reoccurring requests on this approach, so split the functions for this and document that dma_buf_mmap() needs to be used instead. v2: split it into two functions v3: rebased on latest changes

[PATCH 6/7] drm/ttm: nuke ttm_dma_tt_init

2020-11-25 Thread Christian König
Not used any more. Signed-off-by: Christian König --- drivers/gpu/drm/ttm/ttm_tt.c | 13 - include/drm/ttm/ttm_tt.h | 2 -- 2 files changed, 15 deletions(-) diff --git a/drivers/gpu/drm/ttm/ttm_tt.c b/drivers/gpu/drm/ttm/ttm_tt.c index da9eeffe0c6d..77ba784425dd 100644 --- a/dr

[PATCH 2/7] drm/amdgpu: stop using pages with drm_prime_sg_to_page_addr_arrays

2020-11-25 Thread Christian König
This is deprecated. Signed-off-by: Christian König --- drivers/gpu/drm/amd/amdgpu/amdgpu_ttm.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_ttm.c b/drivers/gpu/drm/amd/amdgpu/amdgpu_ttm.c index c438d290a6db..02748e030322 100644 ---

[PATCH 3/7] drm/nouveau: stop using pages with drm_prime_sg_to_page_addr_arrays v2

2020-11-25 Thread Christian König
This is deprecated, also drop the comment about faults. v2: also use ttm_sg_tt_init to avoid allocating the page array. Signed-off-by: Christian König --- drivers/gpu/drm/nouveau/nouveau_bo.c| 6 +++--- drivers/gpu/drm/nouveau/nouveau_sgdma.c | 2 +- 2 files changed, 4 insertions(+), 4 dele

[PATCH 4/7] drm/vmwgfx: switch to ttm_sg_tt_init

2020-11-25 Thread Christian König
According to Daniel VMWGFX doesn't support DMA-buf anyway. Signed-off-by: Christian König --- drivers/gpu/drm/vmwgfx/vmwgfx_ttm_buffer.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/gpu/drm/vmwgfx/vmwgfx_ttm_buffer.c b/drivers/gpu/drm/vmwgfx/vmwgfx_ttm_buffer.

[PATCH 5/7] drm/qxl: switch to ttm_sg_tt_init

2020-11-25 Thread Christian König
The function qxl_gem_prime_import_sg_table is not fully implemented. Signed-off-by: Christian König --- drivers/gpu/drm/qxl/qxl_ttm.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/gpu/drm/qxl/qxl_ttm.c b/drivers/gpu/drm/qxl/qxl_ttm.c index 128c38c8a837..d42e750cbdd3

[PATCH 1/7] drm/radeon: stop using pages with drm_prime_sg_to_page_addr_arrays v2

2020-11-25 Thread Christian König
This is deprecated. v2: also use ttm_sg_tt_init to avoid allocating the page array. Signed-off-by: Christian König --- drivers/gpu/drm/radeon/radeon_ttm.c | 11 ++- 1 file changed, 6 insertions(+), 5 deletions(-) diff --git a/drivers/gpu/drm/radeon/radeon_ttm.c b/drivers/gpu/drm/radeo

Re: [PATCH v3 05/12] drm/ttm: Expose ttm_tt_unpopulate for driver use

2020-11-25 Thread Christian König
Am 25.11.20 um 11:40 schrieb Daniel Vetter: On Tue, Nov 24, 2020 at 05:44:07PM +0100, Christian König wrote: Am 24.11.20 um 17:22 schrieb Andrey Grodzovsky: On 11/24/20 2:41 AM, Christian König wrote: Am 23.11.20 um 22:08 schrieb Andrey Grodzovsky: On 11/23/20 3:41 PM, Christian König wrote:

Re: [PATCH v4 55/80] drm/panel: panel-dsi-cm: use MIPI_DCS_GET_ERROR_COUNT_ON_DSI

2020-11-25 Thread Tomi Valkeinen
On 24/11/2020 18:38, Sam Ravnborg wrote: >>> IMO you should get all the patches at least up including this patch applied. >>> They are all reviewed/acked. And then you have a much smaller stack of >>> patches to spam us with. >> >> Yes, I think that makes sense. I did not want to merge them earlie

Re: [PATCH 3/6] drm/scheduler: Job timeout handler returns status

2020-11-25 Thread Christian König
Am 25.11.20 um 12:04 schrieb Steven Price: On 25/11/2020 03:17, Luben Tuikov wrote: The job timeout handler now returns status indicating back to the DRM layer whether the job was successfully cancelled or whether more time should be given to the job to complete. I'm not sure I understand in w

RE: [PATCH] video: hyperv_fb: Directly use the MMIO VRAM

2020-11-25 Thread Dexuan Cui
Hi Wei Liu, Please do not pick up this patch, because actually MMIO VRAM can not work with fb_deferred_io. Previously I didn't test Xorg -- sorry. As soon as I tested it, I got the below warning and the Xorg program ternimated immediately: [ 28.148432] WARNING: CPU: 19 PID: 1410 at mm/vmalloc.c

Re: [PATCH 3/6] drm/scheduler: Job timeout handler returns status

2020-11-25 Thread Lucas Stach
Am Mittwoch, den 25.11.2020, 11:22 + schrieb Steven Price: > On 25/11/2020 11:15, Lucas Stach wrote: > > Am Mittwoch, den 25.11.2020, 11:04 + schrieb Steven Price: > > > On 25/11/2020 03:17, Luben Tuikov wrote: > > > > The job timeout handler now returns status > > > > indicating back to th

Re: [PATCH 4/7] drm/radeon: Pin buffers while they are vmap'ed

2020-11-25 Thread Thomas Zimmermann
Hi Am 25.11.20 um 11:36 schrieb Daniel Vetter: On Wed, Nov 25, 2020 at 11:13:13AM +0100, Christian König wrote: Am 25.11.20 um 09:37 schrieb Thomas Zimmermann: Hi Am 24.11.20 um 15:09 schrieb Daniel Vetter: On Tue, Nov 24, 2020 at 02:56:51PM +0100, Thomas Zimmermann wrote: Hi Am 24.11.20 u

Re: [PATCH 3/6] drm/scheduler: Job timeout handler returns status

2020-11-25 Thread Steven Price
On 25/11/2020 11:15, Lucas Stach wrote: Am Mittwoch, den 25.11.2020, 11:04 + schrieb Steven Price: On 25/11/2020 03:17, Luben Tuikov wrote: The job timeout handler now returns status indicating back to the DRM layer whether the job was successfully cancelled or whether more time should be g

Re: [PATCH 3/6] drm/scheduler: Job timeout handler returns status

2020-11-25 Thread Lucas Stach
Am Mittwoch, den 25.11.2020, 11:04 + schrieb Steven Price: > On 25/11/2020 03:17, Luben Tuikov wrote: > > The job timeout handler now returns status > > indicating back to the DRM layer whether the job > > was successfully cancelled or whether more time > > should be given to the job to complet

Re: [PATCH 6/6] drm/sched: Make use of a "done" thread

2020-11-25 Thread Steven Price
On 25/11/2020 03:17, Luben Tuikov wrote: Add a "done" list to which all completed jobs are added to be freed. The drm_sched_job_done() callback is the producer of jobs to this list. Add a "done" thread which consumes from the done list and frees up jobs. Now, the main scheduler thread only pushe

Re: [PATCH 3/6] drm/scheduler: Job timeout handler returns status

2020-11-25 Thread Steven Price
On 25/11/2020 03:17, Luben Tuikov wrote: The job timeout handler now returns status indicating back to the DRM layer whether the job was successfully cancelled or whether more time should be given to the job to complete. I'm not sure I understand in what circumstances you would want to give th

Re: [PATCH 4/7] drm/radeon: Pin buffers while they are vmap'ed

2020-11-25 Thread Christian König
Am 25.11.20 um 11:36 schrieb Daniel Vetter: On Wed, Nov 25, 2020 at 11:13:13AM +0100, Christian König wrote: Am 25.11.20 um 09:37 schrieb Thomas Zimmermann: Hi Am 24.11.20 um 15:09 schrieb Daniel Vetter: On Tue, Nov 24, 2020 at 02:56:51PM +0100, Thomas Zimmermann wrote: Hi Am 24.11.20 um 14

Re: [PATCH rdma-core 3/5] pyverbs: Add dma-buf based MR support

2020-11-25 Thread Daniel Vetter
On Tue, Nov 24, 2020 at 06:45:06PM +, Xiong, Jianxin wrote: > > -Original Message- > > From: Daniel Vetter > > Sent: Tuesday, November 24, 2020 7:17 AM > > To: Jason Gunthorpe > > Cc: Xiong, Jianxin ; Leon Romanovsky > > ; linux-r...@vger.kernel.org; dri- > > de...@lists.freedesktop.

Re: [PATCH v3 08/12] drm/amdgpu: Split amdgpu_device_fini into early and late

2020-11-25 Thread Daniel Vetter
On Tue, Nov 24, 2020 at 10:51:57AM -0500, Andrey Grodzovsky wrote: > > On 11/24/20 9:53 AM, Daniel Vetter wrote: > > On Sat, Nov 21, 2020 at 12:21:18AM -0500, Andrey Grodzovsky wrote: > > > Some of the stuff in amdgpu_device_fini such as HW interrupts > > > disable and pending fences finilization

Re: [PATCH v3 05/12] drm/ttm: Expose ttm_tt_unpopulate for driver use

2020-11-25 Thread Daniel Vetter
On Tue, Nov 24, 2020 at 05:44:07PM +0100, Christian König wrote: > Am 24.11.20 um 17:22 schrieb Andrey Grodzovsky: > > > > On 11/24/20 2:41 AM, Christian König wrote: > > > Am 23.11.20 um 22:08 schrieb Andrey Grodzovsky: > > > > > > > > On 11/23/20 3:41 PM, Christian König wrote: > > > > > Am 23.

Re: [PATCH 000/141] Fix fall-through warnings for Clang

2020-11-25 Thread Andy Shevchenko
On Mon, Nov 23, 2020 at 10:39 PM James Bottomley wrote: > On Mon, 2020-11-23 at 19:56 +0100, Miguel Ojeda wrote: > > On Mon, Nov 23, 2020 at 4:58 PM James Bottomley > > wrote: ... > > But if we do the math, for an author, at even 1 minute per line > > change and assuming nothing can be automate

Re: [PATCH 4/7] drm/radeon: Pin buffers while they are vmap'ed

2020-11-25 Thread Daniel Vetter
On Wed, Nov 25, 2020 at 11:13:13AM +0100, Christian König wrote: > Am 25.11.20 um 09:37 schrieb Thomas Zimmermann: > > Hi > > > > Am 24.11.20 um 15:09 schrieb Daniel Vetter: > > > On Tue, Nov 24, 2020 at 02:56:51PM +0100, Thomas Zimmermann wrote: > > > > Hi > > > > > > > > Am 24.11.20 um 14:36 sc

Re: [PATCH 4/7] drm/radeon: Pin buffers while they are vmap'ed

2020-11-25 Thread Christian König
Am 25.11.20 um 09:37 schrieb Thomas Zimmermann: Hi Am 24.11.20 um 15:09 schrieb Daniel Vetter: On Tue, Nov 24, 2020 at 02:56:51PM +0100, Thomas Zimmermann wrote: Hi Am 24.11.20 um 14:36 schrieb Christian König: Am 24.11.20 um 13:15 schrieb Thomas Zimmermann: [SNIP] First I wanted to put th

  1   2   >