Re: Linux 5.10-rc4; graphics alignment

Hi Am 24.11.20 um 17:27 schrieb David Laight: From: David Laight Sent: 20 November 2020 15:39 From: Thomas Zimmermann Sent: 20 November 2020 13:42 ... I did a diff from v5.10-rc4 to drm-tip to look for suspicious changes. Some candidates are 8e3784dfef8a ("drm/ast: Reload gamma LUT aft

Re: [Intel-wired-lan] [PATCH 000/141] Fix fall-through warnings for Clang

On Tue, 2020-11-24 at 13:32 -0800, Kees Cook wrote: > On Mon, Nov 23, 2020 at 08:31:30AM -0800, James Bottomley wrote: > > Really, no ... something which produces no improvement has no value > > at all ... we really shouldn't be wasting maintainer time with it > > because it has a cost to merge. I

Re: [RFC] dcss: fix attaching to sn56dsi86 bridge

Hi Lukas, On Tue, Nov 24, 2020 at 06:19:57PM +0100, Lukas F. Hartmann wrote: > The sn56dsi86 DSI to eDP bridge driver does not support attaching > without a drm connector. I think the SN65DSI86 driver is exactly what you should focus on, so that it works when connector is optional. The ADV7511/AD

Re: [PATCH 3/6] drm/scheduler: Job timeout handler returns status

Hi Luben, Thank you for the patch! Yet something to improve: [auto build test ERROR on linus/master] [also build test ERROR on v5.10-rc5 next-20201124] [If your patch is applied to the wrong git tree, kindly drop us a note. And when submitting patch, we suggest to use '--base' as doc

[PATCH 3/6] drm/scheduler: Job timeout handler returns status

The job timeout handler now returns status indicating back to the DRM layer whether the job was successfully cancelled or whether more time should be given to the job to complete. Signed-off-by: Luben Tuikov --- drivers/gpu/drm/amd/amdgpu/amdgpu_job.c | 6 -- include/drm/gpu_scheduler.h

[PATCH 5/6] drm/amdgpu: Don't hardcode thread name length

Introduce a macro DRM_THREAD_NAME_LEN and use that to define ring name size, instead of hardcoding it to 16. Signed-off-by: Luben Tuikov --- drivers/gpu/drm/amd/amdgpu/amdgpu_ring.h | 2 +- include/drm/gpu_scheduler.h | 2 ++ 2 files changed, 3 insertions(+), 1 deletion(-) diff --g

[PATCH 6/6] drm/sched: Make use of a "done" thread

Add a "done" list to which all completed jobs are added to be freed. The drm_sched_job_done() callback is the producer of jobs to this list. Add a "done" thread which consumes from the done list and frees up jobs. Now, the main scheduler thread only pushes jobs to the GPU and the "done" thread fre

[PATCH 4/6] drm/scheduler: Essentialize the job done callback

The job done callback is called from various places, in two ways: in job done role, and as a fence callback role. Essentialize the callback to an atom function to just complete the job, and into a second function as a prototype of fence callback which calls to complete the job. This is used in la

[PATCH 2/6] gpu/drm: ring_mirror_list --> pending_list

Rename "ring_mirror_list" to "pending_list", to describe what something is, not what it does, how it's used, or how the hardware implements it. This also abstracts the actual hardware implementation, i.e. how the low-level driver communicates with the device it drives, ring, CAM, etc., shouldn't b

[PATCH 0/6] Allow to extend the timeout without jobs disappearing

Hi guys, This series of patches implements a pending list for jobs which are in the hardware, and a done list for tasks which are done and need to be freed. It implements a second thread, dedicated to freeing tasks from the done list. The main scheduler thread no longer frees (cleans up) done tas

[PATCH 1/6] drm/scheduler: "node" --> "list"

Rename "node" to "list" in struct drm_sched_job, in order to make it consistent with what we see being used throughout gpu_scheduler.h, for instance in struct drm_sched_entity, as well as the rest of DRM and the kernel. Signed-off-by: Luben Tuikov --- drivers/gpu/drm/amd/amdgpu/amdgpu_debugfs.c

Re: [PATCH v4 20/21] drm/tegra: Implement job submission part of new UAPI

Hi Mikko, Thank you for the patch! Perhaps something to improve: [auto build test WARNING on tegra/for-next] [also build test WARNING on linus/master v5.10-rc5] [cannot apply to tegra-drm/drm/tegra/for-next next-20201124] [If your patch is applied to the wrong git tree, kindly drop us a note

Re: [PATCH v3 10/12] drm/amdgpu: Avoid sysfs dirs removal post device unplug

On 11/24/20 9:49 AM, Daniel Vetter wrote: On Sat, Nov 21, 2020 at 12:21:20AM -0500, Andrey Grodzovsky wrote: Avoids NULL ptr due to kobj->sd being unset on device removal. Signed-off-by: Andrey Grodzovsky --- drivers/gpu/drm/amd/amdgpu/amdgpu_ras.c | 4 +++- drivers/gpu/drm/amd/amdgpu/a

Re: [PATCH v4 60/80] drm/panel: panel-dsi-cm: set column & page at setup

On 24/11/2020 19:30, Sam Ravnborg wrote: > On Tue, Nov 24, 2020 at 02:45:18PM +0200, Tomi Valkeinen wrote: >> Set the column & page address once during setup, instead of relying the >> DSI host driver to set those. >> >> Signed-off-by: Tomi Valkeinen > Reviewed-by: Sam Ravnborg > > But one comme

Re: [PATCHv8 0/8] System Cache support for GPU and required SMMU support

On Tue, Nov 24, 2020 at 1:43 PM Will Deacon wrote: > > On Tue, Nov 24, 2020 at 11:05:39AM -0800, Rob Clark wrote: > > On Tue, Nov 24, 2020 at 3:10 AM Will Deacon wrote: > > > On Tue, Nov 24, 2020 at 09:32:54AM +0530, Sai Prakash Ranjan wrote: > > > > On 2020-11-24 00:52, Rob Clark wrote: > > > >

Re: [PATCH 00/15] drm: Move struct drm_device.pdev to legacy

Hi Thomas. Nice clean-up series - quite an effort to move one member to deprecated! I have read through most of the patches. I left a few notes in my replies but nothing buggy. Just nitpicks. On Tue, Nov 24, 2020 at 12:38:09PM +0100, Thomas Zimmermann wrote: > The pdev field in struct drm_devic

Re: [PATCH 15/15] drm: Upcast struct drm_device.dev to struct pci_device; replace pdev

Hi Thomas, On Tue, Nov 24, 2020 at 12:38:24PM +0100, Thomas Zimmermann wrote: > We have DRM drivers based on USB, SPI and platform devices. All of them > are fine with storing their device reference in struct drm_device.dev. > PCI devices should be no exception. Therefore struct drm_device.pdev is

Re: [PATCHv8 0/8] System Cache support for GPU and required SMMU support

On Tue, Nov 24, 2020 at 11:05:39AM -0800, Rob Clark wrote: > On Tue, Nov 24, 2020 at 3:10 AM Will Deacon wrote: > > On Tue, Nov 24, 2020 at 09:32:54AM +0530, Sai Prakash Ranjan wrote: > > > On 2020-11-24 00:52, Rob Clark wrote: > > > > On Mon, Nov 23, 2020 at 9:01 AM Sai Prakash Ranjan > > > > wr

Re: [PATCH 09/15] drm/nouveau: Remove references to struct drm_device.pdev

Hi Thomas. On Tue, Nov 24, 2020 at 12:38:18PM +0100, Thomas Zimmermann wrote: > Using struct drm_device.pdev is deprecated. Convert nouveau to struct > drm_device.dev. No functional changes. > > Signed-off-by: Thomas Zimmermann > Cc: Ben Skeggs Suggestion to an alternative implmentation below.

Re: [PATCHv9 2/8] iommu/arm-smmu: Add domain attribute for pagetable configuration

On Mon, Nov 23, 2020 at 10:35:55PM +0530, Sai Prakash Ranjan wrote: > Add iommu domain attribute for pagetable configuration which > initially will be used to set quirks like for system cache aka > last level cache to be used by client drivers like GPU to set > right attributes for caching the hard

Re: [PATCHv9 3/8] iommu/arm-smmu: Move non-strict mode to use io_pgtable_domain_attr

On Mon, Nov 23, 2020 at 10:35:56PM +0530, Sai Prakash Ranjan wrote: > Now that we have a struct io_pgtable_domain_attr with quirks, > use that for non_strict mode as well thereby removing the need > for more members of arm_smmu_domain in the future. > > Signed-off-by: Sai Prakash Ranjan > --- >

Re: [Intel-wired-lan] [PATCH 000/141] Fix fall-through warnings for Clang

On Mon, Nov 23, 2020 at 08:31:30AM -0800, James Bottomley wrote: > Really, no ... something which produces no improvement has no value at > all ... we really shouldn't be wasting maintainer time with it because > it has a cost to merge. I'm not sure we understand where the balance > lies in value

Re: [PATCH 05/15] drm/gma500: Remove references to struct drm_device.pdev

Hi Thomas. On Tue, Nov 24, 2020 at 12:38:14PM +0100, Thomas Zimmermann wrote: > Using struct drm_device.pdev is deprecated. Convert gma500 to struct > drm_device.dev. No functional changes. > > Signed-off-by: Thomas Zimmermann > Cc: Patrik Jakobsson This patch includes several whitespace chang

Re: [PATCH 000/141] Fix fall-through warnings for Clang

On Mon, Nov 23, 2020 at 05:32:51PM -0800, Nick Desaulniers wrote: > On Sun, Nov 22, 2020 at 8:17 AM Kees Cook wrote: > > > > On Fri, Nov 20, 2020 at 11:51:42AM -0800, Jakub Kicinski wrote: > > > If none of the 140 patches here fix a real bug, and there is no change > > > to machine code then it so

[PATCH rdma-core v2 3/6] mlx5: Support dma-buf based memory region

Implement the new provider method for registering dma-buf based memory regions. Signed-off-by: Jianxin Xiong --- providers/mlx5/mlx5.c | 2 ++ providers/mlx5/mlx5.h | 3 +++ providers/mlx5/verbs.c | 22 ++ 3 files changed, 27 insertions(+) diff --git a/providers/mlx5/mlx

[PATCH rdma-core v2 4/6] pyverbs: Add dma-buf based MR support

Define a new sub-class of 'MR' that uses dma-buf object for the memory region. Define a new class 'DmaBuf' for dma-buf object allocation. Signed-off-by: Jianxin Xiong --- pyverbs/CMakeLists.txt | 2 ++ pyverbs/dmabuf.pxd | 13 pyverbs/dmabuf.pyx | 85 +++

[PATCH rdma-core v2 1/6] Update kernel headers

To commit 2eef437c4669 ("RDMA/uverbs: Add uverbs command for dma-buf based MR registration"). Signed-off-by: Jianxin Xiong --- kernel-headers/rdma/ib_user_ioctl_cmds.h | 14 ++ kernel-headers/rdma/ib_user_verbs.h | 14 -- 2 files changed, 14 insertions(+), 14 deletio

[PATCH rdma-core v2 0/6] Add user space dma-buf support

This is the user space counter-part of the kernel patch set to add dma-buf support to the RDMA subsystem. This is the second version of the patch series. Most of the issues found so far in v1 are addressed except for the use of /dev/dri/card* and dumb_buf for allocating dma-buf object. The current

[PATCH rdma-core v2 2/6] verbs: Support dma-buf based memory region

Add new API function and new provider method for registering dma-buf based memory region. Update the man page and bump the API version. Signed-off-by: Jianxin Xiong --- debian/libibverbs1.symbols | 2 ++ libibverbs/CMakeLists.txt| 2 +- libibverbs/cmd_mr.c | 38 +

[PATCH rdma-core v2 6/6] tests: Bug fix for get_access_flags()

The filter definition is wrong and causes get_access_flags() always returning empty list. As the result the MR tests using this function are effectively skipped (but report success). Signed-off-by: Jianxin Xiong --- tests/utils.py | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff -

[PATCH rdma-core v2 5/6] tests: Add tests for dma-buf based memory regions

Define a full set of tests similar to regular MR tests. Add a utility function to generate access flags for dma-buf based MRs because the set of supported flags is smaller. Signed-off-by: Jianxin Xiong --- tests/test_mr.py | 130 ++- tests/util

[PATCH v12 4/4] RDMA/mlx5: Support dma-buf based userspace memory region

Implement the new driver method 'reg_user_mr_dmabuf'. Utilize the core functions to import dma-buf based memory region and update the mappings. Add code to handle dma-buf related page fault. Signed-off-by: Jianxin Xiong Reviewed-by: Sean Hefty Acked-by: Michael J. Ruhl Acked-by: Christian Koe

[PATCH v12 1/4] RDMA/umem: Support importing dma-buf as user memory region

Dma-buf is a standard cross-driver buffer sharing mechanism that can be used to support peer-to-peer access from RDMA devices. Device memory exported via dma-buf is associated with a file descriptor. This is passed to the user space as a property associated with the buffer allocation. When the buf

[PATCH v12 3/4] RDMA/uverbs: Add uverbs command for dma-buf based MR registration

Implement a new uverbs ioctl method for memory registration with file descriptor as an extra parameter. Signed-off-by: Jianxin Xiong Reviewed-by: Sean Hefty Acked-by: Michael J. Ruhl Acked-by: Christian Koenig Acked-by: Daniel Vetter --- drivers/infiniband/core/uverbs_std_types_mr.c | 114 ++

[PATCH v12 0/4] RDMA: Add dma-buf support

This is the twelfth version of the patch set. Changelog: v12: * Move the prototype of function ib_umem_dmabuf_release() to ib_umem.h and remove umem_dmabuf.h * Break a line that is too long v11: https://www.spinics.net/lists/linux-rdma/msg97860.html * Rework the parameter checking code inside i

[PATCH v12 2/4] RDMA/core: Add device method for registering dma-buf based memory region

Dma-buf based memory region requires one extra parameter and is processed quite differently. Adding a separate method allows clean separation from regular memory regions. Signed-off-by: Jianxin Xiong Reviewed-by: Sean Hefty Acked-by: Michael J. Ruhl Acked-by: Christian Koenig Acked-by: Daniel

RE: [PATCH rdma-core 5/5] tests: Bug fix for get_access_flags()

> -Original Message- > From: John Hubbard > Sent: Tuesday, November 24, 2020 12:27 PM > To: Xiong, Jianxin ; linux-r...@vger.kernel.org; > dri-devel@lists.freedesktop.org > Cc: Doug Ledford ; Jason Gunthorpe ; Leon > Romanovsky ; Sumit Semwal > ; Christian Koenig ; > Vetter, Daniel > S

Re: [PATCH v4 55/80] drm/panel: panel-dsi-cm: use MIPI_DCS_GET_ERROR_COUNT_ON_DSI

Hi Sam, On 24/11/2020 18:18, Sam Ravnborg wrote: > Hi Tomi, > > On Tue, Nov 24, 2020 at 02:45:13PM +0200, Tomi Valkeinen wrote: >> Use the common MIPI_DCS_GET_ERROR_COUNT_ON_DSI define instead of >> driver's own. >> > They are both 5 - OK > >> Signed-off-by: Tomi Valkeinen > Reviewed-by: Sam Ra

Re: [PATCH rdma-core 5/5] tests: Bug fix for get_access_flags()

Just some silly nits I stumbled across while trying to understand the tests. On 11/23/20 9:53 AM, Jianxin Xiong wrote: The filter defintion is wrong and causes get_access_flags() always definition returning empty list. As the result the MR tests using this function are effective

[radeon-alex:drm-next 219/295] drivers/gpu/drm/amd/amdgpu/vcn_v3_0.c:1677:6: warning: no previous prototype for 'vcn_v3_0_dec_sw_ring_emit_fence'

tree: git://people.freedesktop.org/~agd5f/linux.git drm-next head: 7ff818f97c306f3e557d724bcebb1df31685f122 commit: 52f9535ca4f4268aa7c27975da330cb8dd6a9bf7 [219/295] drm/amdgpu/vcn3.0: add dec software ring vm functions to support config: riscv-randconfig-r006-20201124 (attached as .config

[PATCH 40/40] drm/amd/amdgpu/amdgpu_uvd: Add description for amdgpu_uvd_cs_msg_decode()'s 'buf_sizes' param

Fixes the following W=1 kernel build warning(s): drivers/gpu/drm/amd/amdgpu/amdgpu_uvd.c:555: warning: Function parameter or member 'buf_sizes' not described in 'amdgpu_uvd_cs_msg_decode' Cc: Alex Deucher Cc: "Christian König" Cc: David Airlie Cc: Daniel Vetter Cc: Sumit Semwal Cc: amd-...

[PATCH 29/40] drm/amd/amdgpu/vcn_v1_0: Fix a few kernel-doc misdemeanours

Fixes the following W=1 kernel build warning(s): drivers/gpu/drm/amd/amdgpu/vcn_v1_0.c:439: warning: Excess function parameter 'sw' description in 'vcn_v1_0_disable_clock_gating' drivers/gpu/drm/amd/amdgpu/vcn_v1_0.c:566: warning: Excess function parameter 'sw' description in 'vcn_v1_0_enable_

[PATCH 34/40] drm/amd/amdgpu/amdgpu_acp: Fix doc-rot issues pertaining to a couple of 'handle' params

Fixes the following W=1 kernel build warning(s): drivers/gpu/drm/amd/amdgpu/amdgpu_acp.c:183: warning: Function parameter or member 'handle' not described in 'acp_hw_init' drivers/gpu/drm/amd/amdgpu/amdgpu_acp.c:183: warning: Excess function parameter 'adev' description in 'acp_hw_init' drive

[PATCH 27/40] drm/amd/amdgpu/uvd_v7_0: Fix a bunch of kernel-doc function documentation issues

Fixes the following W=1 kernel build warning(s): drivers/gpu/drm/amd/amdgpu/uvd_v7_0.c:219: warning: Function parameter or member 'bo' not described in 'uvd_v7_0_enc_get_create_msg' drivers/gpu/drm/amd/amdgpu/uvd_v7_0.c:219: warning: Excess function parameter 'adev' description in 'uvd_v7_0_en

[PATCH 35/40] drm/amd/pm/swsmu/smu11/vangogh_ppt: Make local function 'vangogh_set_default_dpm_tables()' static

Fixes the following W=1 kernel build warning(s): drivers/gpu/drm/amd/amdgpu/../pm/swsmu/smu11/vangogh_ppt.c: At top level: drivers/gpu/drm/amd/amdgpu/../pm/swsmu/smu11/vangogh_ppt.c:764:5: warning: no previous prototype for ‘vangogh_set_default_dpm_tables’ [-Wmissing-prototypes] 764 | int vang

[PATCH 14/40] drm/amd/amdgpu/gfx_v9_0: Make called-by-reference only function static

Fixes the following W=1 kernel build warning(s): drivers/gpu/drm/amd/amdgpu/gfx_v9_0.c:2998:6: warning: no previous prototype for ‘gfx_v9_0_rlc_stop’ [-Wmissing-prototypes] Cc: Alex Deucher Cc: "Christian König" Cc: David Airlie Cc: Daniel Vetter Cc: Sumit Semwal Cc: amd-...@lists.freedesk

[PATCH 33/40] drm/amd/amdgpu/vcn_v3_0: Remove unused variable 'direct_poll' from 'vcn_v3_0_start_sriov()'

Fixes the following W=1 kernel build warning(s): drivers/gpu/drm/amd/amdgpu/vcn_v3_0.c: In function ‘vcn_v3_0_start_sriov’: drivers/gpu/drm/amd/amdgpu/vcn_v3_0.c:1242:3: warning: variable ‘direct_poll’ set but not used [-Wunused-but-set-variable] Cc: Alex Deucher Cc: "Christian König" Cc: Da

[PATCH 38/40] drm/amd/pm/swsmu/smu11/navi10_ppt: Remove unused 'struct i2c_algorithm navi10_i2c_algo'

Fixes the following W=1 kernel build warning(s): Cc: Alex Deucher Cc: "Christian König" Cc: David Airlie Cc: Daniel Vetter Cc: Evan Quan Cc: amd-...@lists.freedesktop.org Cc: dri-devel@lists.freedesktop.org Signed-off-by: Lee Jones --- .../gpu/drm/amd/pm/swsmu/smu11/navi10_ppt.c | 204 ---

[PATCH 39/40] drm/amd/pm/powerplay/smumgr/fiji_smumgr: Remove unused variable 'result'

Fixes the following W=1 kernel build warning(s): drivers/gpu/drm/amd/amdgpu/../pm/powerplay/smumgr/fiji_smumgr.c: In function ‘fiji_populate_smc_boot_level’: drivers/gpu/drm/amd/amdgpu/../pm/powerplay/smumgr/fiji_smumgr.c:1603:6: warning: variable ‘result’ set but not used [-Wunused-but-set-va

[PATCH 12/40] drm/amd/amdgpu/dce_v10_0: Supply description for function param 'async'

Fixes the following W=1 kernel build warning(s): drivers/gpu/drm/amd/amdgpu/dce_v10_0.c:237: warning: Function parameter or member 'async' not described in 'dce_v10_0_page_flip' Cc: Alex Deucher Cc: "Christian König" Cc: David Airlie Cc: Daniel Vetter Cc: Luben Tuikov Cc: amd-...@lists.fre

[PATCH 17/40] drm/amd/amdgpu/sdma_v2_4: Fix a bunch of kernel-doc function documentation issues

Fixes the following W=1 kernel build warning(s): drivers/gpu/drm/amd/amdgpu/sdma_v2_4.c:254: warning: Function parameter or member 'job' not described in 'sdma_v2_4_ring_emit_ib' drivers/gpu/drm/amd/amdgpu/sdma_v2_4.c:254: warning: Function parameter or member 'flags' not described in 'sdma_v2

[PATCH 19/40] drm/amd/amdgpu/sdma_v3_0: Fix incorrect param doc-rot issue

Fixes the following W=1 kernel build warning(s): drivers/gpu/drm/amd/amdgpu/sdma_v3_0.c:1651: warning: Function parameter or member 'ib' not described in 'sdma_v3_0_emit_copy_buffer' drivers/gpu/drm/amd/amdgpu/sdma_v3_0.c:1651: warning: Excess function parameter 'ring' description in 'sdma_v3_

[PATCH 36/40] drm/amd/pm/inc/smu_v11_0: Mark 'smu11_thermal_policy' as __maybe_unused

It's used in some, but not all source files which include 'smu_v11_0.h'. Fixes the following W=1 kernel build warning(s): In file included from drivers/gpu/drm/amd/amdgpu/../pm/swsmu/smu11/smu_v11_0.c:36: drivers/gpu/drm/amd/amdgpu/../pm/inc/smu_v11_0.h:61:43: warning: ‘smu11_thermal_policy’

[PATCH 23/40] drm/amd/amdgpu/sdma_v5_0: Provide some missing and repair other function params

Fixes the following W=1 kernel build warning(s): drivers/gpu/drm/amd/amdgpu/sdma_v5_0.c:403: warning: Function parameter or member 'job' not described in 'sdma_v5_0_ring_emit_ib' drivers/gpu/drm/amd/amdgpu/sdma_v5_0.c:403: warning: Function parameter or member 'flags' not described in 'sdma_v5

[PATCH 37/40] drm/amd/pm/swsmu/smu12/renoir_ppt: Demote kernel-doc formatting abuse

Fixes the following W=1 kernel build warning(s): Cc: Alex Deucher Cc: "Christian König" Cc: David Airlie Cc: Daniel Vetter Cc: amd-...@lists.freedesktop.org Cc: dri-devel@lists.freedesktop.org Signed-off-by: Lee Jones --- drivers/gpu/drm/amd/pm/swsmu/smu12/renoir_ppt.c | 4 ++-- 1 file chang

[PATCH 11/40] drm/amd/amdgpu/psp_v11_0: Make local function 'psp_v11_0_wait_for_bootloader()' static

Fixes the following W=1 kernel build warning(s): drivers/gpu/drm/amd/amdgpu/psp_v11_0.c:223:5: warning: no previous prototype for ‘psp_v11_0_wait_for_bootloader’ [-Wmissing-prototypes] Cc: Alex Deucher Cc: "Christian König" Cc: David Airlie Cc: Daniel Vetter Cc: Hawking Zhang Cc: amd-...@l

[PATCH 30/40] drm/amd/amdgpu/jpeg_v1_0: Add some missing function param descriptions

Fixes the following W=1 kernel build warning(s): drivers/gpu/drm/amd/amdgpu/jpeg_v1_0.c:219: warning: Function parameter or member 'addr' not described in 'jpeg_v1_0_decode_ring_emit_fence' drivers/gpu/drm/amd/amdgpu/jpeg_v1_0.c:219: warning: Function parameter or member 'seq' not described in

[PATCH 32/40] drm/amd/amdgpu/vcn_v2_0: Fix a few kernel-doc misdemeanours

Fixes the following W=1 kernel build warning(s): drivers/gpu/drm/amd/amdgpu/vcn_v2_0.c:483: warning: Excess function parameter 'sw' description in 'vcn_v2_0_disable_clock_gating' drivers/gpu/drm/amd/amdgpu/vcn_v2_0.c:644: warning: Excess function parameter 'sw' description in 'vcn_v2_0_enable_

[PATCH 28/40] drm/amd/amdgpu/gfx_v10_0: Make local function 'gfx_v10_0_rlc_stop()' static

Fixes the following W=1 kernel build warning(s): drivers/gpu/drm/amd/amdgpu/gfx_v10_0.c:5008:6: warning: no previous prototype for ‘gfx_v10_0_rlc_stop’ [-Wmissing-prototypes] Cc: Alex Deucher Cc: "Christian König" Cc: David Airlie Cc: Daniel Vetter Cc: Sumit Semwal Cc: amd-...@lists.freede

[PATCH 31/40] drm/amd/amdgpu/jpeg_v2_0: Add some missing kernel-doc descriptions

Fixes the following W=1 kernel build warning(s): drivers/gpu/drm/amd/amdgpu/jpeg_v2_0.c:498: warning: Function parameter or member 'addr' not described in 'jpeg_v2_0_dec_ring_emit_fence' drivers/gpu/drm/amd/amdgpu/jpeg_v2_0.c:498: warning: Function parameter or member 'seq' not described in 'j

[PATCH 21/40] drm/amd/amdgpu/sdma_v4_0: Repair a bunch of kernel-doc problems

Fixes the following W=1 kernel build warning(s): drivers/gpu/drm/amd/amdgpu/sdma_v4_0.c:848: warning: Function parameter or member 'job' not described in 'sdma_v4_0_ring_emit_ib' drivers/gpu/drm/amd/amdgpu/sdma_v4_0.c:848: warning: Function parameter or member 'flags' not described in 'sdma_v4

[PATCH 25/40] drm/amd/amdgpu/amdgpu_vce: Provide some missing and repair other function params

Fixes the following W=1 kernel build warning(s): drivers/gpu/drm/amd/amdgpu/amdgpu_vce.c:97: warning: Function parameter or member 'size' not described in 'amdgpu_vce_sw_init' drivers/gpu/drm/amd/amdgpu/amdgpu_vce.c:441: warning: Function parameter or member 'bo' not described in 'amdgpu_vce_g

[PATCH 26/40] drm/amd/amdgpu/uvd_v6_0: Fix a bunch of kernel-doc function documentation issues

Fixes the following W=1 kernel build warning(s): drivers/gpu/drm/amd/amdgpu/uvd_v6_0.c:211: warning: Function parameter or member 'bo' not described in 'uvd_v6_0_enc_get_create_msg' drivers/gpu/drm/amd/amdgpu/uvd_v6_0.c:211: warning: Excess function parameter 'adev' description in 'uvd_v6_0_en

[PATCH 24/40] drm/amd/amdgpu/sdma_v5_2: Provide some missing and repair other function params

Fixes the following W=1 kernel build warning(s): drivers/gpu/drm/amd/amdgpu/sdma_v5_2.c:367: warning: Function parameter or member 'job' not described in 'sdma_v5_2_ring_emit_ib' drivers/gpu/drm/amd/amdgpu/sdma_v5_2.c:367: warning: Function parameter or member 'flags' not described in 'sdma_v5

[PATCH 20/40] drm/amd/amdgpu/uvd_v5_0: Fix a bunch of kernel-doc function documentation issues

Fixes the following W=1 kernel build warning(s): drivers/gpu/drm/amd/amdgpu/uvd_v5_0.c:153: warning: Function parameter or member 'handle' not described in 'uvd_v5_0_hw_init' drivers/gpu/drm/amd/amdgpu/uvd_v5_0.c:153: warning: Excess function parameter 'adev' description in 'uvd_v5_0_hw_init'

[PATCH 22/40] drm/amd/amdgpu/amdgpu_uvd: Fix some function documentation headers

Fixes the following W=1 kernel build warning(s): drivers/gpu/drm/amd/amdgpu/amdgpu_uvd.c:95: warning: cannot understand function prototype: 'struct amdgpu_uvd_cs_ctx ' drivers/gpu/drm/amd/amdgpu/amdgpu_uvd.c:555: warning: Function parameter or member 'adev' not described in 'amdgpu_uvd_cs_msg_

[PATCH 06/40] drm/amd/amdgpu/cz_ih: Add missing function param descriptions for 'ih' and 'entry'

Fixes the following W=1 kernel build warning(s): drivers/gpu/drm/amd/amdgpu/cz_ih.c:191: warning: Function parameter or member 'ih' not described in 'cz_ih_get_wptr' drivers/gpu/drm/amd/amdgpu/cz_ih.c:223: warning: Function parameter or member 'ih' not described in 'cz_ih_decode_iv' drivers/g

[PATCH 09/40] drm/amd/amdgpu/vega10_ih: Add descriptions for 'ih' and 'entry'

Fixes the following W=1 kernel build warning(s): drivers/gpu/drm/amd/amdgpu/vega10_ih.c:377: warning: Function parameter or member 'ih' not described in 'vega10_ih_get_wptr' drivers/gpu/drm/amd/amdgpu/vega10_ih.c:440: warning: Function parameter or member 'ih' not described in 'vega10_ih_decod

[PATCH 15/40] drm/amd/amdgpu/gfx_v8_0: Functions must follow directly after their headers

Fixes the following W=1 kernel build warning(s): drivers/gpu/drm/amd/amdgpu/gfx_v8_0.c:3698: warning: Excess function parameter 'adev' description in 'DEFAULT_SH_MEM_BASES' Cc: Alex Deucher Cc: "Christian König" Cc: David Airlie Cc: Daniel Vetter Cc: Sumit Semwal Cc: amd-...@lists.freedesk

[PATCH 16/40] drm/amd/amdgpu/gfx_v10_0: Remove a bunch of set but unused variables

Fixes the following W=1 kernel build warning(s): drivers/gpu/drm/amd/amdgpu/gfx_v10_0.c: In function ‘gfx_v10_rlcg_wreg’: drivers/gpu/drm/amd/amdgpu/gfx_v10_0.c:1416:18: warning: variable ‘grbm_idx’ set but not used [-Wunused-but-set-variable] drivers/gpu/drm/amd/amdgpu/gfx_v10_0.c:1415:18: wa

[PATCH 05/40] drm/amd/amdgpu/tonga_ih: Provide some missing descriptions for 'ih' and 'entry'

Fixes the following W=1 kernel build warning(s): drivers/gpu/drm/amd/amdgpu/tonga_ih.c:193: warning: Function parameter or member 'ih' not described in 'tonga_ih_get_wptr' drivers/gpu/drm/amd/amdgpu/tonga_ih.c:225: warning: Function parameter or member 'ih' not described in 'tonga_ih_decode_iv

[PATCH 13/40] drm/amd/amdgpu/dce_v11_0: Supply description for function param 'async'

Fixes the following W=1 kernel build warning(s): drivers/gpu/drm/amd/amdgpu/dce_v11_0.c:255: warning: Function parameter or member 'async' not described in 'dce_v11_0_page_flip' Cc: Alex Deucher Cc: "Christian König" Cc: David Airlie Cc: Daniel Vetter Cc: Luben Tuikov Cc: amd-...@lists.fre

[PATCH 18/40] drm/amd/amdgpu/sdma_v3_0: Fix a bunch of kernel-doc function documentation issues

Fixes the following W=1 kernel build warning(s): drivers/gpu/drm/amd/amdgpu/sdma_v3_0.c:428: warning: Function parameter or member 'job' not described in 'sdma_v3_0_ring_emit_ib' drivers/gpu/drm/amd/amdgpu/sdma_v3_0.c:428: warning: Function parameter or member 'flags' not described in 'sdma_v3

[PATCH 08/40] drm/msm/dp/dp_ctrl: Move 'tu' from the stack to the heap

'struct tu_algo_data' is huge ~400 Bytes. Fixes the following W=1 kernel build warning(s): drivers/gpu/drm/msm/dp/dp_ctrl.c: In function ‘_dp_ctrl_calc_tu.constprop’: drivers/gpu/drm/msm/dp/dp_ctrl.c:938:1: warning: the frame size of 1184 bytes is larger than 1024 bytes [-Wframe-larger-than=]

[PATCH 10/40] drm/amd/amdgpu/navi10_ih: Add descriptions for 'ih' and 'entry'

Fixes the following W=1 kernel build warning(s): drivers/gpu/drm/amd/amdgpu/navi10_ih.c:453: warning: Function parameter or member 'ih' not described in 'navi10_ih_get_wptr' drivers/gpu/drm/amd/amdgpu/navi10_ih.c:512: warning: Function parameter or member 'ih' not described in 'navi10_ih_decod

[PATCH 07/40] drm/amd/amdgpu/amdgpu_psp: Make local function 'parse_ta_bin_descriptor' static

Fixes the following W=1 kernel build warning(s): drivers/gpu/drm/amd/amdgpu/amdgpu_psp.c:2576:5: warning: no previous prototype for ‘parse_ta_bin_descriptor’ [-Wmissing-prototypes] Cc: Alex Deucher Cc: "Christian König" Cc: David Airlie Cc: Daniel Vetter Cc: amd-...@lists.freedesktop.org Cc

[PATCH 03/40] drm/msm/adreno/a6xx_gpu_state: Make some local functions static

Fixes the following W=1 kernel build warning(s): drivers/gpu/drm/msm/adreno/a6xx_gpu_state.c:83:7: warning: no previous prototype for ‘state_kcalloc’ [-Wmissing-prototypes] drivers/gpu/drm/msm/adreno/a6xx_gpu_state.c:95:7: warning: no previous prototype for ‘state_kmemdup’ [-Wmissing-prototype

[PATCH 02/40] drm/amd/amdgpu/gmc_v10_0: Suppy some missing function doc descriptions

Fixes the following W=1 kernel build warning(s): drivers/gpu/drm/amd/amdgpu/gmc_v10_0.c:278: warning: Function parameter or member 'vmhub' not described in 'gmc_v10_0_flush_gpu_tlb' drivers/gpu/drm/amd/amdgpu/gmc_v10_0.c:278: warning: Function parameter or member 'flush_type' not described in

[PATCH 04/40] drm/amd/amdgpu/iceland_ih: Add missing function param descriptions for 'ih' and 'entry'

Fixes the following W=1 kernel build warning(s): drivers/gpu/drm/amd/amdgpu/iceland_ih.c:191: warning: Function parameter or member 'ih' not described in 'iceland_ih_get_wptr' drivers/gpu/drm/amd/amdgpu/iceland_ih.c:223: warning: Function parameter or member 'ih' not described in 'iceland_ih_d

[PATCH 01/40] drm/msm/msm_gem_shrinker: Fix descriptions for 'drm_device'

Fixes the following W=1 kernel build warning(s): drivers/gpu/drm/msm/msm_gem_shrinker.c:108: warning: Function parameter or member 'dev' not described in 'msm_gem_shrinker_init' drivers/gpu/drm/msm/msm_gem_shrinker.c:108: warning: Excess function parameter 'dev_priv' description in 'msm_gem_sh

[PATCH 00/40] [Set 9] Rid W=1 warnings from GPU

This set is part of a larger effort attempting to clean-up W=1 kernel builds, which are currently overwhelmingly riddled with niggly little warnings. 730 out of 5000 left. Lee Jones (40): drm/msm/msm_gem_shrinker: Fix descriptions for 'drm_device' drm/amd/amdgpu/gmc_v10_0: Suppy some missing

[PATCH v2 3/3] drm/msm: Improve the a6xx page fault handler

Use the new adreno-smmu-priv fault info function to get more SMMU debug registers and print the current TTBR0 to debug per-instance pagetables and figure out which GPU block generated the request. Signed-off-by: Jordan Crouse --- drivers/gpu/drm/msm/adreno/a5xx_gpu.c | 4 +- drivers/gpu/drm/ms

[PATCH v2 0/3] iommu/arm-smmu: adreno-smmu page fault handling

This is a stack to add an Adreno GPU specific handler for pagefaults. The first patch starts by wiring up report_iommu_fault for arm-smmu. The next patch adds a adreno-smmu-priv function hook to capture a handful of important debugging registers such as TTBR0, CONTEXTIDR, FSYNR0 and others. This is

Re: [PATCHv8 0/8] System Cache support for GPU and required SMMU support

On Tue, Nov 24, 2020 at 3:10 AM Will Deacon wrote: > > On Tue, Nov 24, 2020 at 09:32:54AM +0530, Sai Prakash Ranjan wrote: > > On 2020-11-24 00:52, Rob Clark wrote: > > > On Mon, Nov 23, 2020 at 9:01 AM Sai Prakash Ranjan > > > wrote: > > > > > > > > On 2020-11-23 20:51, Will Deacon wrote: > > >

Re: [PATCH 01/40] drm/radeon/radeon_device: Consume our own header where the prototypes are located

On Tue, 24 Nov 2020, Alex Deucher wrote: > On Mon, Nov 23, 2020 at 6:19 AM Lee Jones wrote: > > > > Fixes the following W=1 kernel build warning(s): > > > > drivers/gpu/drm/radeon/radeon_device.c:637:6: warning: no previous > > prototype for ‘radeon_device_is_virtual’ [-Wmissing-prototypes] > >

RE: [PATCH rdma-core 3/5] pyverbs: Add dma-buf based MR support

> -Original Message- > From: Daniel Vetter > Sent: Tuesday, November 24, 2020 7:17 AM > To: Jason Gunthorpe > Cc: Xiong, Jianxin ; Leon Romanovsky > ; linux-r...@vger.kernel.org; dri- > de...@lists.freedesktop.org; Doug Ledford ; Vetter, > Daniel ; Christian Koenig > > Subject: Re: [PA

RE: [PATCH v11 1/4] RDMA/umem: Support importing dma-buf as user memory region

> -Original Message- > From: Christoph Hellwig > Sent: Tuesday, November 24, 2020 1:34 AM > To: Xiong, Jianxin > Cc: linux-r...@vger.kernel.org; dri-devel@lists.freedesktop.org; Doug Ledford > ; Jason Gunthorpe ; > Leon Romanovsky ; Sumit Semwal ; > Christian Koenig ; Vetter, > Daniel

RE: [PATCH rdma-core 1/5] verbs: Support dma-buf based memory region

> -Original Message- > From: Yishai Hadas > Sent: Tuesday, November 24, 2020 2:32 AM > To: Xiong, Jianxin > Cc: linux-r...@vger.kernel.org; dri-devel@lists.freedesktop.org; Doug Ledford > ; Jason Gunthorpe ; > Leon Romanovsky ; Sumit Semwal ; > Christian Koenig ; Vetter, > Daniel ; Yish

Re: [PATCH 1/2] panel-simple: add Innolux N125HCE-GN1

Hi Lukas. On Tue, Nov 24, 2020 at 06:26:04PM +0100, Lukas F. Hartmann wrote: > The Innolux N125HCE-GN1 display is used in the MNT Reform 2.0 laptop, > attached via eDP to a SN65DSI86 MIPI-DSI to eDP bridge. > > Signed-off-by: Lukas F. Hartmann Danke, applied to drm-misc-next. Sam _

Re: [PATCH 2/2] dt-bindings: display/panel: add Innolux N125HCE-GN1

Hi Lukas On Tue, Nov 24, 2020 at 06:26:06PM +0100, Lukas F. Hartmann wrote: > The Innolux N125HCE-GN1 display is used in the MNT Reform 2.0 laptop, > attached via eDP to a SN65DSI86 MIPI-DSI to eDP bridge. This patch > contains the DT binding for "innolux,n125hce-gn1". > > Signed-off-by: Lukas F.

Re: [PATCH v3 07/12] drm/sched: Prevent any job recoveries after device is unplugged.

On 2020-11-24 12:40 p.m., Christian König wrote: > Am 24.11.20 um 18:11 schrieb Luben Tuikov: >> On 2020-11-24 2:50 a.m., Christian König wrote: >>> Am 24.11.20 um 02:12 schrieb Luben Tuikov: On 2020-11-23 3:06 a.m., Christian König wrote: > Am 23.11.20 um 06:37 schrieb Andrey Grodzovsky:

Re: [PATCH v3 07/12] drm/sched: Prevent any job recoveries after device is unplugged.

On 2020-11-24 12:17 p.m., Andrey Grodzovsky wrote: > > On 11/24/20 12:11 PM, Luben Tuikov wrote: >> On 2020-11-24 2:50 a.m., Christian König wrote: >>> Am 24.11.20 um 02:12 schrieb Luben Tuikov: On 2020-11-23 3:06 a.m., Christian König wrote: > Am 23.11.20 um 06:37 schrieb Andrey Grodzovs

[Bug 205675] Display locks up. AMDGPU timeout

https://bugzilla.kernel.org/show_bug.cgi?id=205675 swrbrsestryt (febola5...@opetron.com) changed: What|Removed |Added CC||febola5...@opetron

Re: [PATCH v3 07/12] drm/sched: Prevent any job recoveries after device is unplugged.

Am 24.11.20 um 18:11 schrieb Luben Tuikov: On 2020-11-24 2:50 a.m., Christian König wrote: Am 24.11.20 um 02:12 schrieb Luben Tuikov: On 2020-11-23 3:06 a.m., Christian König wrote: Am 23.11.20 um 06:37 schrieb Andrey Grodzovsky: On 11/22/20 6:57 AM, Christian König wrote: Am 21.11.20 um 06:

Re: [PATCH v4 70/80] drm/panel: panel-dsi-cm: drop unneeded includes

On Tue, Nov 24, 2020 at 02:45:28PM +0200, Tomi Valkeinen wrote: > Drop unneeded includes. > > Signed-off-by: Tomi Valkeinen I trust the compiler here. Reviewed-by: Sam Ravnborg > --- > drivers/gpu/drm/panel/panel-dsi-cm.c | 5 - > 1 file changed, 5 deletions(-) > > diff --git a/drivers/gp

Re: [PATCH v4 69/80] drm/panel: panel-dsi-cm: add panel database to driver

On Tue, Nov 24, 2020 at 02:45:27PM +0200, Tomi Valkeinen wrote: > Add a panel database to the driver instead of reading propertes from DT > data. This is similar to panel-simple, and I believe it's more future > safe way to handle the panels. > > Signed-off-by: Tomi Valkeinen Looks good, and you

Re: [PATCH v4 68/80] drm/panel: panel-dsi-cm: remove extra 'if'

Hi Tomi, On Tue, Nov 24, 2020 at 02:45:26PM +0200, Tomi Valkeinen wrote: > We have a useless 'if' in the dsicm_bl_update_status(), a left over from > the conversion to DRM model. Drop the if. > > Signed-off-by: Tomi Valkeinen Reviewed-by: Sam Ravnborg But with a few comments. > --- > drivers

Re: [PATCH v4 60/80] drm/panel: panel-dsi-cm: set column & page at setup

On Tue, Nov 24, 2020 at 02:45:18PM +0200, Tomi Valkeinen wrote: > Set the column & page address once during setup, instead of relying the > DSI host driver to set those. > > Signed-off-by: Tomi Valkeinen Reviewed-by: Sam Ravnborg But one comment below. > --- > drivers/gpu/drm/panel/panel-dsi-

Re: [PATCH v4 56/80] drm/panel: panel-dsi-cm: cleanup tear enable

On Tue, Nov 24, 2020 at 02:45:14PM +0200, Tomi Valkeinen wrote: > Simplify the code by moving code from _dsicm_enable_te() into > dsicm_power_on(). > > Signed-off-by: Tomi Valkeinen Reviewed-by: Sam Ravnborg ___ dri-devel mailing list dri-devel@lists.f

Re: [PATCH v3 07/12] drm/sched: Prevent any job recoveries after device is unplugged.

On 11/24/20 12:11 PM, Luben Tuikov wrote: On 2020-11-24 2:50 a.m., Christian König wrote: Am 24.11.20 um 02:12 schrieb Luben Tuikov: On 2020-11-23 3:06 a.m., Christian König wrote: Am 23.11.20 um 06:37 schrieb Andrey Grodzovsky: On 11/22/20 6:57 AM, Christian König wrote: Am 21.11.20 um 06:

  1   2   3   4   >