Re: [patch 00/13] preempt: Make preempt count unconditional

2020-09-14 Thread Linus Torvalds
On Mon, Sep 14, 2020 at 11:24 PM Herbert Xu wrote: > > On Tue, Sep 15, 2020 at 09:20:59AM +0300, Ard Biesheuvel wrote: > > > > The documentation of kmap_atomic() states the following: > > > > * The use of kmap_atomic/kunmap_atomic is discouraged - kmap/kunmap > > * gives a more generic (and cach

Re: [patch 00/13] preempt: Make preempt count unconditional

2020-09-14 Thread Ard Biesheuvel
On Tue, 15 Sep 2020 at 01:43, Linus Torvalds wrote: > > On Mon, Sep 14, 2020 at 3:24 PM Linus Torvalds > wrote: > > > > Ard and Herbert added to participants: see > > chacha20poly1305_crypt_sg_inplace(), which does > > > > flags = SG_MITER_TO_SG; > > if (!preemptible()) > >

some half-baked ttm ideas

2020-09-14 Thread Dave Airlie
Hi Christian, I've been trying to move towards the idea of not having TTM manage the global TT, I'm still not sure what the result would look like so I've been randomly trying out a direction or two, There are some patches in : https://github.com/airlied/linux/commits/ttm-half-baked-ideas a) it

[PATCH 5/7] drm/ttm: move ttm binding/unbinding out of ttm_tt paths.

2020-09-14 Thread Dave Airlie
From: Dave Airlie Move these up to the bo level, moving ttm_tt to just being backing store. Next step is to move the bound flag out. Signed-off-by: Dave Airlie --- drivers/gpu/drm/amd/amdgpu/amdgpu_ttm.c | 2 +- drivers/gpu/drm/nouveau/nouveau_bo.c| 2 +- drivers/gpu/drm/radeon/radeon_mn

[PATCH 1/7] drm/ttm/tt: add wrappers to set tt state.

2020-09-14 Thread Dave Airlie
From: Dave Airlie This adds 2 getters and 4 setters, however unbound and populated are currently the same thing, this will change, it also drops a BUG_ON that seems not that useful. Signed-off-by: Dave Airlie --- drivers/gpu/drm/amd/amdgpu/amdgpu_ttm.c| 4 +-- drivers/gpu/drm/nouveau/nouv

[no subject]

2020-09-14 Thread Dave Airlie
The goal here is to make the ttm_tt object just represent a memory backing store, and now whether the store is bound to a global translation table. It moves binding up to the bo level. There's a lot more work on removing the global TT from the core of TTM, but this seems like a good start. Dave.

[PATCH 4/7] drm/ttm: split populate out from binding.

2020-09-14 Thread Dave Airlie
From: Dave Airlie Drivers have to call populate themselves now before binding. Signed-off-by: Dave Airlie --- drivers/gpu/drm/amd/amdgpu/amdgpu_ttm.c | 7 ++- drivers/gpu/drm/nouveau/nouveau_bo.c| 6 +- drivers/gpu/drm/radeon/radeon_ttm.c | 7 ++- drivers/gpu/drm/ttm/ttm

[PATCH 2/7] drm/ttm: wrap tt destroy.

2020-09-14 Thread Dave Airlie
From: Dave Airlie All places this was called was using bo->ttm either direct or indirectly. Signed-off-by: Dave Airlie --- drivers/gpu/drm/ttm/ttm_bo.c | 9 +++-- drivers/gpu/drm/ttm/ttm_bo_util.c | 24 include/drm/ttm/ttm_bo_driver.h | 5 + 3 files ch

[PATCH 3/7] drm/ttm: tt destroy move null check to outer function.

2020-09-14 Thread Dave Airlie
From: Dave Airlie This just makes things easier later. Signed-off-by: Dave Airlie --- drivers/gpu/drm/ttm/ttm_bo_util.c | 2 ++ drivers/gpu/drm/ttm/ttm_tt.c | 3 --- 2 files changed, 2 insertions(+), 3 deletions(-) diff --git a/drivers/gpu/drm/ttm/ttm_bo_util.c b/drivers/gpu/drm/ttm/ttm

[PATCH 7/7] drm/ttm: move populated state into page flags

2020-09-14 Thread Dave Airlie
From: Dave Airlie Just use the top bit of page flags to store the populated state. Signed-off-by: Dave Airlie --- include/drm/ttm/ttm_tt.h | 9 + 1 file changed, 5 insertions(+), 4 deletions(-) diff --git a/include/drm/ttm/ttm_tt.h b/include/drm/ttm/ttm_tt.h index 94e16238c93d..c777b7

[PATCH 6/7] drm/ttm: split bound/populated flags.

2020-09-14 Thread Dave Airlie
From: Dave Airlie Move bound up into the bo object, and keep populated with the tt object. The ghost object handling needs to follow the flags at the bo level now instead of it being part of the ttm tt object. Signed-off-by: Dave Airlie --- drivers/gpu/drm/ttm/ttm_bo_util.c | 15 +++--

Re: [PATCH] drm/panel: samsung: make vint_table static

2020-09-14 Thread Laurent Pinchart
Hi Jason, Thank you for the patch. On Sat, Sep 12, 2020 at 11:38:17AM +0800, Jason Yan wrote: > This eliminates the following sparse warning: > > drivers/gpu/drm/panel/panel-samsung-s6e3ha2.c:217:15: warning: symbol > 'vint_table' was not declared. Should it be static? > > Reported-by: Hulk Rob

Re: [PATCH 2/2] drm/tilcdc: Remove tilcdc_crtc_max_width(), use private data

2020-09-14 Thread Laurent Pinchart
Hi Jyri, Thank you for the patch. On Mon, Sep 14, 2020 at 11:34:50AM +0300, Jyri Sarha wrote: > We already have a private data member for maximum display width so > let's use it and get rid of the redundant tilcdc_crtc_max_width(). You may want to add a sentence to explain why OF parsing is move

Re: [PATCH 1/2] drm/tilcdc: Do not keep vblank interrupts enabled all the time

2020-09-14 Thread Laurent Pinchart
Hi Jyri, Thank you for the patch. On Mon, Sep 14, 2020 at 11:34:49AM +0300, Jyri Sarha wrote: > END_OF_FRAME interrupts have been enabled all the time since the > beginning of this driver. It is about time to add this feature. > > Signed-off-by: Jyri Sarha Reviewed-by: Laurent Pinchart > ---

Re: [PATCH v2 04/23] virtio: Add get_shm_region method

2020-09-14 Thread Gurchetan Singh
On Thu, Sep 10, 2020 at 2:56 AM Miklos Szeredi wrote: > On Thu, Sep 10, 2020 at 2:28 AM Gurchetan Singh > wrote: > > > That sounds like an excellent plan ! > > > > I will send out blob v3 (incorporating kraxel@'s feedback) once the > topic pull request (it seems Miklos will do this?) for the shm

Re: [PATCH] drm/mediatek: add missing put_device() call in mtk_hdmi_dt_parse_pdata()

2020-09-14 Thread Chun-Kuang Hu
Hi, Yu Kuai: Yu Kuai 於 2020年9月11日 週五 下午7:22寫道: > > if of_find_device_by_node() succeed, mtk_drm_kms_init() doesn't have > a corresponding put_device(). Thus add jump target to fix the exception > handling for this function implementation. Reviewed-by: Chun-Kuang Hu > > Fixes: 8f83f26891e1 ("dr

Re: [PATCH] drm/mediatek: add missing put_device() call in mtk_drm_kms_init()

2020-09-14 Thread Chun-Kuang Hu
Hi, Yu Kuai: Yu Kuai 於 2020年9月11日 週五 下午7:22寫道: > > if of_find_device_by_node() succeed, mtk_drm_kms_init() doesn't have > a corresponding put_device(). Thus add jump target to fix the exception > handling for this function implementation. Reviewed-by: Chun-Kuang Hu > > Fixes: 119f5173628a ("dr

[git pull] virtio-shm region

2020-09-14 Thread Gurchetan Singh
Hi, This set of changes are required for zero-copy virtio-gpu. The following changes since commit 9123e3a74ec7b934a4a099e98af6a61c2f80bbf5: Linux 5.9-rc1 (2020-08-16 13:04:57 -0700) are available in the Git repository at: git://git.kernel.org/pub/scm/linux/kernel/git/mszeredi/fuse.git virt

Re: [PATCH] drm/mediatek: add exception handing in mtk_drm_probe() if component init fail

2020-09-14 Thread Chun-Kuang Hu
Hi, Yu Kuai: Yu Kuai 於 2020年9月9日 週三 下午4:50寫道: > > mtk_ddp_comp_init() is called in a loop in mtk_drm_probe(), if it > fail, previous successive init component is not proccessed. > > Thus uninitialize valid component and put their device if component > init failed. Reviewed-by: Chun-Kuang Hu >

Re: [PATCH] drm/mediatek: add missing put_device() call in mtk_ddp_comp_init()

2020-09-14 Thread Chun-Kuang Hu
Hi, Yu Kuai: Yu Kuai 於 2020年9月5日 週六 下午4:31寫道: > > if of_find_device_by_node() succeed, mtk_ddp_comp_init() doesn't have > a corresponding put_device(). Thus add put_device() to fix the exception > handling for this function implementation. > Reviewed-by: Chun-Kuang Hu > Fixes: d0afe37f5209 ("d

[GIT PULL] mediatek drm next for 5.10

2020-09-14 Thread Chun-Kuang Hu
Hi, Dave & Daniel: This includes: 1. Move Mediatek HDMI PHY driver from DRM folder to PHY folder 2. Convert mtk-dpi to drm_bridge API 3. Disable tmds on mt2701 Regards, Chun-Kuang. The following changes since commit 9123e3a74ec7b934a4a099e98af6a61c2f80bbf5: Linux 5.9-rc1 (2020-08-16 13:04:57

Re: [PATCH 1/3] dt-bindings: vendor-prefixes: Add Yes Optoelectronics

2020-09-14 Thread Rob Herring
On Fri, 04 Sep 2020 23:38:19 +0530, Jagan Teki wrote: > Add vendor dt-bindings for Yes Optoelectronics Co.,Ltd. > > Signed-off-by: Jagan Teki > --- > Documentation/devicetree/bindings/vendor-prefixes.yaml | 2 ++ > 1 file changed, 2 insertions(+) > Acked-by: Rob Herring __

Re: [PATCH 2/3] dt-bindings: display: simple: Add YTC700TLAG-05-201C

2020-09-14 Thread Rob Herring
On Fri, 04 Sep 2020 23:38:20 +0530, Jagan Teki wrote: > Add dt-bindings for YTC700TLAG-05-201C 7" TFT LCD panel from > Yes Optoelectronics Co.,Ltd. > > Signed-off-by: Jagan Teki > --- > .../devicetree/bindings/display/panel/panel-simple.yaml | 2 ++ > 1 file changed, 2 insertions(+) >

Re: [PATCH 07/13] dt-bindings: mfd: rohm,bd71847-pmic: Add common clock-names

2020-09-14 Thread Rob Herring
On Fri, Sep 04, 2020 at 04:53:06PM +0200, Krzysztof Kozlowski wrote: > Add common 'clock-names' property which might appear in DTSes. This > makes it consistent with rohm,bd71837-pmic dtschema. > > Signed-off-by: Krzysztof Kozlowski > --- > Documentation/devicetree/bindings/mfd/rohm,bd71847-pmi

Re: [PATCH 06/13] dt-bindings: mfd: rohm,bd71837-pmic: Add common properties

2020-09-14 Thread Rob Herring
On Fri, Sep 04, 2020 at 04:53:05PM +0200, Krzysztof Kozlowski wrote: > Add common properties appearing in DTSes (clock-names, > clock-output-names) to fix dtbs_check warnings like: > > arch/arm64/boot/dts/freescale/imx8mq-librem5-r2.dt.yaml: > pmic@4b: 'clock-names', 'clock-output-names', do

[PATCH 2/3] drm/msm: a6xx: Use WHERE_AM_I for eligible targets

2020-09-14 Thread Jordan Crouse
Support the WHERE_AM_I opcode for the A618, A630 and A640 GPUs if the microcode supports it. The WHERE_AM_I opcode allows the RPTR shadow to be updated in priviliged memory which protects the shadow from being read or written from user submissions. A650 already supports extended APRIV have built i

[PATCH 1/3] drm/msm: Allow a5xx to mark the RPTR shadow as privileged

2020-09-14 Thread Jordan Crouse
Newer microcode versions have support for the CP_WHERE_AM_I opcode which allows the RPTR shadow memory to be marked as privileged to protect it from corruption. Move the RPTR shadow into its own buffer and protect it it if the current microcode version supports the new feature. We can also re-enab

[PATCH 3/3] drm/msm: Get rid of the REG_ADRENO offsets

2020-09-14 Thread Jordan Crouse
As newer GPU families are added it makes less sense to maintain a "generic" version functions for older families. Move adreno_submit() and get_rptr() into the target specific code for a2xx, a3xx and a4xx. Add a parameter to adreno_flush to pass the target specific WPTR register instead of relying o

[PATCH 0/3] drm/msm: Add support for the WHERE_AM_I opcode

2020-09-14 Thread Jordan Crouse
The microcode in linux-firmware has been updated to 1.87.01 for a5xx 1.77.01 for a6xx [1]. These microcode versions support a new opcode called WHERE_AM_I that takes the place of the hardware RPTR shadow and enables the microcode to update the RPTR shadow in privileged memory so it is protected aga

Re: [patch 00/13] preempt: Make preempt count unconditional

2020-09-14 Thread Linus Torvalds
On Mon, Sep 14, 2020 at 3:24 PM Linus Torvalds wrote: > > Ard and Herbert added to participants: see > chacha20poly1305_crypt_sg_inplace(), which does > > flags = SG_MITER_TO_SG; > if (!preemptible()) > flags |= SG_MITER_ATOMIC; > > introduced in commit d95312a3ccc0

Re: [PATCH 03/13] dt-bindings: arm: fsl: Fix matching Purism Librem5 phones

2020-09-14 Thread Rob Herring
On Fri, 04 Sep 2020 16:53:02 +0200, Krzysztof Kozlowski wrote: > All Purism Librem5 phones have three compatibles so they need their own > entry to fix dbts_check warnings like: > > arch/arm64/boot/dts/freescale/imx8mq-librem5-r2.dt.yaml: /: > compatible: ['purism,librem5r2', 'purism,librem5

Re: [PATCH 05/13] dt-bindings: gpu: vivante, gc: Remove trailing whitespace

2020-09-14 Thread Rob Herring
On Fri, 04 Sep 2020 16:53:04 +0200, Krzysztof Kozlowski wrote: > Remove whitespace at the end of line. > > Signed-off-by: Krzysztof Kozlowski > --- > Documentation/devicetree/bindings/gpu/vivante,gc.yaml | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > Applied, thanks! ___

Re: [PATCH 04/13] dt-bindings: gpu: vivante, gc: Add common properties

2020-09-14 Thread Rob Herring
On Fri, 04 Sep 2020 16:53:03 +0200, Krzysztof Kozlowski wrote: > Add common properties appearing in DTSes (cooling-cells, assigned-clocks > and others) to fix dtbs_check warnings like: > > arch/arm64/boot/dts/freescale/imx8mq-evk.dt.yaml: gpu@3800: > '#cooling-cells', 'assigned-clock-par

Re: [PATCH 01/13] dt-bindings: power: fsl, imx-gpcv2: Document interrupt controller properties

2020-09-14 Thread Rob Herring
On Fri, 04 Sep 2020 16:53:00 +0200, Krzysztof Kozlowski wrote: > The i.MX General Power Controller v2 is also an interrupt controller so > document additional properties to fix dtbs_check warnings like: > > arch/arm64/boot/dts/freescale/imx8mq-evk.dt.yaml: gpc@303a: > '#interrupt-cells',

Re: [PATCH 02/13] dt-bindings: display: bridge: nwl-dsi: Add common properties

2020-09-14 Thread Rob Herring
On Fri, 04 Sep 2020 16:53:01 +0200, Krzysztof Kozlowski wrote: > Add common properties appearing in DTSes (assigned-clocks and others) to > fix dtbs_check warnings like: > > arch/arm64/boot/dts/freescale/imx8mq-evk.dt.yaml: mipi-dsi@30a0: > 'assigned-clock-parents', 'assigned-clock-rates

Re: [patch 00/13] preempt: Make preempt count unconditional

2020-09-14 Thread Linus Torvalds
On Mon, Sep 14, 2020 at 2:55 PM Thomas Gleixner wrote: > > Yes it does generate better code, but I tried hard to spot a difference > in various metrics exposed by perf. It's all in the noise and I only > can spot a difference when the actual preemption check after the > decrement I'm somewhat mor

Re: [PATCH v6 1/4] drm/mediatek: disable tmds on mt2701

2020-09-14 Thread Chun-Kuang Hu
Hi, Frank: Frank Wunderlich 於 2020年9月4日 週五 下午7:01寫道: > > From: chunhui dai > > Without that patch if you use specific resolutions like 1280x1024, > I can see distortion in the output. It seems as if the > frequency for updating the pixel of the image is out of sync. > > For initialization tmds n

Re: [PATCH 2/2] drm/ttm: remove available_caching

2020-09-14 Thread Dave Airlie
For both: Reviewed-by: Dave Airlie On Sat, 12 Sep 2020 at 01:24, Christian König wrote: > > Instead of letting TTM make an educated guess based on > some mask all drivers should just specify what caching > they want for their CPU mappings. > > Signed-off-by: Christian König > --- > drivers/gp

Re: [PATCH] drm/ttm: remove default caching

2020-09-14 Thread Dave Airlie
Reviewed-by: Dave Airlie On Fri, 11 Sep 2020 at 23:10, Christian König wrote: > > As far as I can tell this was never used either and we just > always fallback to the order cached > wc > uncached anyway. > > Signed-off-by: Christian König > --- > drivers/gpu/drm/amd/amdgpu/amdgpu_gtt_mgr.c |

Re: [PATCH 1/1] drm/amdgpu: Convert to using devm_drm_dev_alloc()

2020-09-14 Thread Alex Deucher
On Fri, Sep 11, 2020 at 4:50 PM Luben Tuikov wrote: > > On 2020-09-08 16:09, Luben Tuikov wrote: > > On 2020-09-07 04:07, Daniel Vetter wrote: > >> On Mon, Sep 07, 2020 at 10:06:08AM +0200, Daniel Vetter wrote: > >>> On Sat, Sep 05, 2020 at 11:50:05AM -0400, Alex Deucher wrote: > On Thu, Sep

Re: [PATCH v2 10/16] drm/exynos: implement a drm bridge

2020-09-14 Thread Andrzej Hajda
Hi Marek, Michael, On 14.09.2020 22:01, Michael Tretter wrote: > Hi, > > On Mon, 14 Sep 2020 14:31:19 +0200, Marek Szyprowski wrote: >> On 14.09.2020 10:29, Marek Szyprowski wrote: >>> On 11.09.2020 15:54, Michael Tretter wrote: Make the exynos_dsi driver a full drm bridge that can be found a

Re: [patch 00/13] preempt: Make preempt count unconditional

2020-09-14 Thread Linus Torvalds
On Mon, Sep 14, 2020 at 1:45 PM Thomas Gleixner wrote: > > Recently merged code does: > > gfp = preemptible() ? GFP_KERNEL : GFP_ATOMIC; > > Looks obviously correct, except for the fact that preemptible() is > unconditionally false for CONFIF_PREEMPT_COUNT=n, i.e. all allocations in > tha

Re: [patch 00/13] preempt: Make preempt count unconditional

2020-09-14 Thread Steven Rostedt
On Mon, 14 Sep 2020 22:42:09 +0200 Thomas Gleixner wrote: > 21 files changed, 23 insertions(+), 92 deletions(-) This alone makes it look promising, and hopefully acceptable by Linus :-) -- Steve ___ dri-devel mailing list dri-devel@lists.freedesktop.o

Re: [PATCH v2 3/6] dt-bindings: gpu: arm, mali-utgard: Correct Maxime's email

2020-09-14 Thread Rob Herring
On Thu, 03 Sep 2020 21:14:35 +0200, Krzysztof Kozlowski wrote: > Update the address of Maxime Ripard as one in @free-electrons.com does > not work. > > Cc: Maxime Ripard > Signed-off-by: Krzysztof Kozlowski > Acked-by: Maxime Ripard > > --- > > Changes since v1: > 1. Add Ack > --- > Document

Re: [PATCH v2 4/6] dt-bindings: gpu: samsung-rotator: Add missing properties

2020-09-14 Thread Rob Herring
On Thu, Sep 03, 2020 at 09:14:36PM +0200, Krzysztof Kozlowski wrote: > Add common properties appearing in DTSes (iommus, power-domains) to fix > dtbs_check warnings like: > > arch/arm/boot/dts/exynos4210-i9100.dt.yaml: rotator@1281: > 'iommus', 'power-domains' do not match any of the reg

Re: [PATCH v2 2/6] dt-bindings: gpu: arm, mali-utgard: Add missing properties

2020-09-14 Thread Rob Herring
On Thu, 03 Sep 2020 21:14:34 +0200, Krzysztof Kozlowski wrote: > Add common properties appearing in DTSes (opp-table) to fix dtbs_check > warnings like: > > arch/arm/boot/dts/exynos4210-i9100.dt.yaml: gpu@1300: > 'opp-table' does not match any of the regexes: 'pinctrl-[0-9]+' > > Signed

Re: [PATCH v2 1/6] dt-bindings: gpu: arm, mali-midgard: Add missing properties

2020-09-14 Thread Rob Herring
On Thu, 03 Sep 2020 21:14:33 +0200, Krzysztof Kozlowski wrote: > Add common properties appearing in DTSes (opp-table) to fix dtbs_check > warnings like: > > arch/arm64/boot/dts/exynos/exynos5433-tm2.dt.yaml: gpu@14ac: > 'opp-table' does not match any of the regexes: 'pinctrl-[0-9]+' > >

Re: [PATCH v2 10/16] drm/exynos: implement a drm bridge

2020-09-14 Thread Michael Tretter
Hi, On Mon, 14 Sep 2020 14:31:19 +0200, Marek Szyprowski wrote: > On 14.09.2020 10:29, Marek Szyprowski wrote: > > On 11.09.2020 15:54, Michael Tretter wrote: > >> Make the exynos_dsi driver a full drm bridge that can be found and used > >> from other drivers. > >> > >> Other drivers can only atta

Re: [Intel-gfx] [PATCH 2/3] drm/atomic-helper: Remove the timestamping constant update from drm_atomic_helper_update_legacy_modeset_state()

2020-09-14 Thread Ville Syrjälä
On Mon, Sep 07, 2020 at 08:12:56PM +0200, Daniel Vetter wrote: > On Mon, Sep 07, 2020 at 03:00:25PM +0300, Ville Syrjala wrote: > > From: Ville Syrjälä > > > > The timestamping constants have nothing to do with any legacy state > > so should not be updated from > > drm_atomic_helper_update_legacy

[Bug 208825] lspci triggers NULL pointer dereference on AMD Renoir 4800H/5600M laptop

2020-09-14 Thread bugzilla-daemon
https://bugzilla.kernel.org/show_bug.cgi?id=208825 --- Comment #3 from Jon Tourville (jontourvi...@me.com) --- I am now unable to reproduce even on versions <5.8.6, which I know still had the problem. So I am thinking it may have been a firmware update or something else that resolved the issue for

Re: [PATCH v10 2/3] drm: bridge: Add support for Cadence MHDP8546 DPI/DP bridge

2020-09-14 Thread kernel test robot
Hi Swapnil, Thank you for the patch! Perhaps something to improve: [auto build test WARNING on robh/for-next] [also build test WARNING on linus/master v5.9-rc5 next-20200914] [If your patch is applied to the wrong git tree, kindly drop us a note. And when submitting patch, we suggest to use

Re: Changing vma->vm_file in dma_buf_mmap()

2020-09-14 Thread Christian König
Am 14.09.20 um 16:06 schrieb Jason Gunthorpe: On Mon, Sep 14, 2020 at 03:30:47PM +0200, Christian König wrote: Am 14.09.20 um 15:29 schrieb Christian König: Hi Andrew, I'm the new DMA-buf maintainer and Daniel and others came up with patches extending the use of the dma_buf_mmap() function. N

Re: [PATCH 1/4] dt-bindings: display: samsung, amoled-mipi-dsi: Do not require enable-gpios on samsung, s6e63j0x03

2020-09-14 Thread Rob Herring
On Sat, 29 Aug 2020 19:25:29 +0200, Krzysztof Kozlowski wrote: > The samsung,s6e63j0x03 does not have enable GPIO, so do not require it. > This fixes dtbs_check warning: > > arch/arm/boot/dts/exynos3250-rinato.dt.yaml: panel@0: 'enable-gpios' is a > required property > > Signed-off-by: Krzyszt

Re: [PATCH 05/10] dt-bindings: connector: Convert Samsung 11-pin USB bindings to dtschema

2020-09-14 Thread Rob Herring
On Sat, 29 Aug 2020 16:24:56 +0200, Krzysztof Kozlowski wrote: > Add Samsung 11-pin USB-C connector into standard dtschema bindings file. > > Signed-off-by: Krzysztof Kozlowski > --- > .../connector/samsung,usb-connector-11pin.txt | 49 --- > .../bindings/connector/usb-connector.

Re: [PATCH 01/20] drm/amdgpu: Introduce GEM object functions

2020-09-14 Thread Christian König
Am 14.09.20 um 17:05 schrieb Thomas Zimmermann: Hi Am 13.08.20 um 12:22 schrieb Christian König: Am 13.08.20 um 10:36 schrieb Thomas Zimmermann: GEM object functions deprecate several similar callback interfaces in struct drm_driver. This patch replaces the per-driver callbacks with per-instan

Re: [PATCH v12 0/5] Add support for DisplayPort driver on SnapDragon

2020-09-14 Thread Tanmay Shah
On 2020-09-12 11:25, Rob Clark wrote: Fyi, I've pushed this series and the dp-compliance bits to msm-next-dp[1] I didn't include the dp audio series yet, which seems to need some minor rebasing. (And a small request, when resending, cc freedr...@lists.freedesktop.org, so it shows up in the pat

Re: [Intel-gfx] [PATCH] drm/i915: Fix the race between the GEM close and debugfs

2020-09-14 Thread Tvrtko Ursulin
On 14/09/2020 12:00, Nikunj A. Dadhania wrote: As we close GEM object and set file_priv to -EBADF which is protected by ctx->mutex, populating the GEM debugfs info is not protected and results in the crash shown below. Make sure to protect the access to file_priv using ctx->mutex to avoid race

Re: [Intel-gfx] [PATCH 3/3] drm/i915/gem: Serialise debugfs i915_gem_objects with ctx->mutex

2020-09-14 Thread Tvrtko Ursulin
On 23/07/2020 18:21, Chris Wilson wrote: Since the debugfs may peek into the GEM contexts as the corresponding client/fd is being closed, we may try and follow a dangling pointer. However, the context closure itself is serialised with the ctx->mutex, so if we hold that mutex as we inspect the s

Re: [PATCH] drm/msm/a6xx: fix a potential overflow issue

2020-09-14 Thread Jordan Crouse
On Sat, Sep 12, 2020 at 06:25:58PM +0800, Zhenzhong Duan wrote: > It's allocating an array of a6xx_gpu_state_obj structure rathor than > its pointers. > > This patch fix it. > > Signed-off-by: Zhenzhong Duan LGTM but should have a Fixes: tag for the stable trees Fixes: d6852b4b2d01 ("drm/msm/a

Re: [PATCH v2] drm/amdgpu/dc: Require primary plane to be enabled whenever the CRTC is

2020-09-14 Thread Michel Dänzer
On 2020-09-14 5:33 p.m., Kazlauskas, Nicholas wrote: On 2020-09-14 11:22 a.m., Michel Dänzer wrote: On 2020-09-14 4:37 p.m., Kazlauskas, Nicholas wrote: On 2020-09-14 3:52 a.m., Michel Dänzer wrote: P.S. Since DCN doesn't make a distinction between primary or overlay planes in hardware, coul

Re: [PATCH v10 2/3] drm: bridge: Add support for Cadence MHDP8546 DPI/DP bridge

2020-09-14 Thread kernel test robot
Hi Swapnil, Thank you for the patch! Perhaps something to improve: [auto build test WARNING on robh/for-next] [also build test WARNING on linus/master v5.9-rc5 next-20200914] [If your patch is applied to the wrong git tree, kindly drop us a note. And when submitting patch, we suggest to use

Re: [PATCH v2] drm/amdgpu/dc: Require primary plane to be enabled whenever the CRTC is

2020-09-14 Thread Kazlauskas, Nicholas
On 2020-09-14 11:22 a.m., Michel Dänzer wrote: On 2020-09-14 4:37 p.m., Kazlauskas, Nicholas wrote: On 2020-09-14 3:52 a.m., Michel Dänzer wrote: On 2020-09-07 9:57 a.m., Daniel Vetter wrote: On Fri, Sep 04, 2020 at 12:43:04PM +0200, Michel Dänzer wrote: From: Michel Dänzer Don't check drm_

Re: [PATCH v2] drm/amdgpu/dc: Require primary plane to be enabled whenever the CRTC is

2020-09-14 Thread Michel Dänzer
On 2020-09-14 4:37 p.m., Kazlauskas, Nicholas wrote: On 2020-09-14 3:52 a.m., Michel Dänzer wrote: On 2020-09-07 9:57 a.m., Daniel Vetter wrote: On Fri, Sep 04, 2020 at 12:43:04PM +0200, Michel Dänzer wrote: From: Michel Dänzer Don't check drm_crtc_state::active for this either, per its docu

Re: per-plane LUTs and CSCs?

2020-09-14 Thread Ville Syrjälä
On Mon, Sep 14, 2020 at 10:38:24AM -0400, Alex Deucher wrote: > On Mon, Sep 14, 2020 at 9:32 AM Ville Syrjälä > wrote: > > > > On Mon, Sep 14, 2020 at 02:13:09AM -0400, Alex Deucher wrote: > > > On Thu, Sep 10, 2020 at 4:29 AM Simon Ser wrote: > > > > > > > > On Thursday, September 10, 2020 10:18

Re: [PATCH 01/20] drm/amdgpu: Introduce GEM object functions

2020-09-14 Thread Thomas Zimmermann
Hi Am 13.08.20 um 12:22 schrieb Christian König: > Am 13.08.20 um 10:36 schrieb Thomas Zimmermann: >> GEM object functions deprecate several similar callback interfaces in >> struct drm_driver. This patch replaces the per-driver callbacks with >> per-instance callbacks in amdgpu. The only exceptio

Re: per-plane LUTs and CSCs?

2020-09-14 Thread Alex Deucher
On Mon, Sep 14, 2020 at 9:32 AM Ville Syrjälä wrote: > > On Mon, Sep 14, 2020 at 02:13:09AM -0400, Alex Deucher wrote: > > On Thu, Sep 10, 2020 at 4:29 AM Simon Ser wrote: > > > > > > On Thursday, September 10, 2020 10:18 AM, Daniel Vetter > > > wrote: > > > > > > > On Thu, Sep 10, 2020 at 07:5

Re: [PATCH v2] drm/amdgpu/dc: Require primary plane to be enabled whenever the CRTC is

2020-09-14 Thread Kazlauskas, Nicholas
On 2020-09-14 3:52 a.m., Michel Dänzer wrote: On 2020-09-07 9:57 a.m., Daniel Vetter wrote: On Fri, Sep 04, 2020 at 12:43:04PM +0200, Michel Dänzer wrote: From: Michel Dänzer Don't check drm_crtc_state::active for this either, per its documentation in include/drm/drm_crtc.h:   * Hence driver

Re: imx8m: Failed to attach bridge

2020-09-14 Thread Fabio Estevam
On Mon, Sep 14, 2020 at 10:52 AM Fabio Estevam wrote: > > Hi Martin and Guido, > > I am trying to get MIPI DSI panel to work on an imx8mq-evk board. > > Here are the changes I did against linux-next 20200914 following what > was done on imx8mq-librem5-devkit.dts: >

imx8m: Failed to attach bridge

2020-09-14 Thread Fabio Estevam
Hi Martin and Guido, I am trying to get MIPI DSI panel to work on an imx8mq-evk board. Here are the changes I did against linux-next 20200914 following what was done on imx8mq-librem5-devkit.dts: https://pastebin.com/raw/GXazRyNx The config I am using is this one: https://pastebin.com/raw

Re: per-plane LUTs and CSCs?

2020-09-14 Thread Ville Syrjälä
On Mon, Sep 14, 2020 at 02:13:09AM -0400, Alex Deucher wrote: > On Thu, Sep 10, 2020 at 4:29 AM Simon Ser wrote: > > > > On Thursday, September 10, 2020 10:18 AM, Daniel Vetter > > wrote: > > > > > On Thu, Sep 10, 2020 at 07:50:59AM +, Simon Ser wrote: > > > > > > > On Wednesday, September 9

Re: Changing vma->vm_file in dma_buf_mmap()

2020-09-14 Thread Christian König
Am 14.09.20 um 15:29 schrieb Christian König: Hi Andrew, Sorry forgot to add Daniel as well. I'm the new DMA-buf maintainer and Daniel and others came up with patches extending the use of the dma_buf_mmap() function. Now this function is doing something a bit odd by changing the vma->vm_fi

Changing vma->vm_file in dma_buf_mmap()

2020-09-14 Thread Christian König
Hi Andrew, I'm the new DMA-buf maintainer and Daniel and others came up with patches extending the use of the dma_buf_mmap() function. Now this function is doing something a bit odd by changing the vma->vm_file while installing a VMA in the mmap() system call The background here is that DMA-bu

[PATCH 1/2] drm/shmem-helpers: revert "Redirect mmap for imported dma-buf"

2020-09-14 Thread Christian König
This reverts commit 26d3ac3cb04d171a861952e89324e347598a347f. We need to figure out if dma_buf_mmap() is valid or not first. Signed-off-by: Christian König --- drivers/gpu/drm/drm_gem_shmem_helper.c | 3 --- 1 file changed, 3 deletions(-) diff --git a/drivers/gpu/drm/drm_gem_shmem_helper.c b/

[PATCH 2/2] mm: introduce vma_set_file function

2020-09-14 Thread Christian König
Add the new vma_set_file() function to allow changing vma->vm_file with the necessary refcount dance. Signed-off-by: Christian König --- drivers/dma-buf/dma-buf.c | 16 +--- include/linux/mm.h| 2 ++ mm/mmap.c | 16 3 files changed, 23 insert

Re: [PATCH 0/2] drm/tilcdc: Couple of minor feature improvements

2020-09-14 Thread Tomi Valkeinen
On 14/09/2020 11:34, Jyri Sarha wrote: > The vblank interrupts have been always on when the display is on for a > very long time, so I decided that it is about time to fix it. Then the > following patch is just a cleanup. > > BR, > Jyri > > Jyri Sarha (2): > drm/tilcdc: Do not keep vblank inter

[PATCH 0/2] drm/tilcdc: Couple of minor feature improvements

2020-09-14 Thread Jyri Sarha
The vblank interrupts have been always on when the display is on for a very long time, so I decided that it is about time to fix it. Then the following patch is just a cleanup. BR, Jyri Jyri Sarha (2): drm/tilcdc: Do not keep vblank interrupts enabled all the time drm/tilcdc: Remove tilcdc_cr

[PATCH 2/2] drm/tilcdc: Remove tilcdc_crtc_max_width(), use private data

2020-09-14 Thread Jyri Sarha
We already have a private data member for maximum display width so let's use it and get rid of the redundant tilcdc_crtc_max_width(). Signed-off-by: Jyri Sarha --- drivers/gpu/drm/tilcdc/tilcdc_crtc.c | 16 +--- drivers/gpu/drm/tilcdc/tilcdc_drv.c | 38 +++- driv

[PATCH 1/2] drm/tilcdc: Do not keep vblank interrupts enabled all the time

2020-09-14 Thread Jyri Sarha
END_OF_FRAME interrupts have been enabled all the time since the beginning of this driver. It is about time to add this feature. Signed-off-by: Jyri Sarha --- drivers/gpu/drm/tilcdc/tilcdc_crtc.c | 36 +--- 1 file changed, 33 insertions(+), 3 deletions(-) diff --git a/dr

Re: [PATCH v2 10/16] drm/exynos: implement a drm bridge

2020-09-14 Thread Marek Szyprowski
Hi, On 14.09.2020 10:29, Marek Szyprowski wrote: > On 11.09.2020 15:54, Michael Tretter wrote: >> Make the exynos_dsi driver a full drm bridge that can be found and used >> from other drivers. >> >> Other drivers can only attach to the bridge, if a mipi dsi device >> already attached to the bridge

Re: [PATCH] MAINTAINERS: make linux-aspeed list remarks consistent

2020-09-14 Thread Joel Stanley
On Sun, 13 Sep 2020 at 09:57, Lukas Bulwahn wrote: > > > > On Sat, 12 Sep 2020, Lukas Bulwahn wrote: > > > Commit f15a3ea80391 ("MAINTAINERS: Add ASPEED BMC GFX DRM driver entry") > > does not mention that linux-asp...@lists.ozlabs.org is moderated for > > non-subscribers, but the other three entr

[PATCH 0/3] dma-buf: Flag vmap'ed memory as system or I/O memory

2020-09-14 Thread Thomas Zimmermann
Dma-buf provides vmap() and vunmap() for retrieving and releasing mappings of dma-buf memory in kernel address space. The functions operate with plain addresses and the assumption is that the memory can be accessed with load and store operations. This is not the case on some architectures (e.g., sp

[PATCH 1/3] dma-buf: Add struct dma-buf-map for storing struct dma_buf.vaddr_ptr

2020-09-14 Thread Thomas Zimmermann
The new type struct dma_buf_map represents a mapping of dma-buf memory into kernel space. It contains a flag, is_iomem, that signals users to access the mapped memory with I/O operations instead of regular loads and stores. It was assumed that DMA buffer memory can be accessed with regular load an

[PATCH 2/3] dma-buf: Use struct dma_buf_map in dma_buf_vmap() interfaces

2020-09-14 Thread Thomas Zimmermann
This patch updates dma_buf_vmap() and dma-buf's vmap callback to use struct dma_buf_map. The interfaces used to return a buffer address. This address now gets stored in an instance of the structure that is given as an additional argument. The functions return an errno code on errors. Users of the

[PATCH 3/3] dma-buf: Use struct dma_buf_map in dma_buf_vunmap() interfaces

2020-09-14 Thread Thomas Zimmermann
This patch updates dma_buf_vunmap() and dma-buf's vunmap callback to use struct dma_buf_map. The interfaces used to receive a buffer address. This address is now given in an instance of the structure. Users of the functions are updated accordingly. This is only an interface change. It is currently

Re: [PATCH 0/4] Add support for video pattern DP CTS to MSM DP

2020-09-14 Thread Jani Nikula
On Thu, 03 Sep 2020, Abhinav Kumar wrote: > Add support for video pattern Display Port Compliance tests to > MSM DP driver. FWIW, I find it useful to prefix the cover letter subject line with the usual git log prefixes, e.g. "drm/msm/dp", so people can filter their mails better. BR, Jani. > A

Re: [PATCH v5 00/80] drm/vc4: Support BCM2711 Display Pipeline

2020-09-14 Thread Hoegeun Kwon
Hi Maxime, On 9/8/20 9:00 PM, Maxime Ripard wrote: > Hi Hoegeun, > > On Mon, Sep 07, 2020 at 08:49:12PM +0900, Hoegeun Kwon wrote: >> On 9/3/20 5:00 PM, Maxime Ripard wrote: >>> Hi everyone, >>> >>> Here's a (pretty long) series to introduce support in the VC4 DRM driver >>> for the display pipeli

Re: [PATCH v2 10/16] drm/exynos: implement a drm bridge

2020-09-14 Thread Marek Szyprowski
Hi Michael, On 11.09.2020 15:54, Michael Tretter wrote: > Make the exynos_dsi driver a full drm bridge that can be found and used > from other drivers. > > Other drivers can only attach to the bridge, if a mipi dsi device > already attached to the bridge. This allows to defer the probe of the > di

Re: [PATCH v2] drm/amdgpu/dc: Require primary plane to be enabled whenever the CRTC is

2020-09-14 Thread Michel Dänzer
On 2020-09-07 9:57 a.m., Daniel Vetter wrote: On Fri, Sep 04, 2020 at 12:43:04PM +0200, Michel Dänzer wrote: From: Michel Dänzer Don't check drm_crtc_state::active for this either, per its documentation in include/drm/drm_crtc.h: * Hence drivers must not consult @active in their various *

[PATCH v3 1/4] drm/ast: Set format registers in primary plane's update

2020-09-14 Thread Thomas Zimmermann
The atomic modesetting code tried to distinguish format changes from full modesetting operations. But the implementation was buggy and the format registers were often updated even for simple pageflips. Fix this problem by handling format changes in the primary plane's update function. v3:

[RESEND][PATCH v3 0/4] drm/ast: Disable HW cursor when switching modes

2020-09-14 Thread Thomas Zimmermann
Since converting the ast driver to atomic modesetting, modesetting occationally locks up the graphics hardware and turns the display permanently dark. This happens once or twice per 10 mode switches. Investigation shows that the ast hardware presumably requires the HW cursor to be disabled while th

[PATCH v3 2/4] drm/ast: Disable planes while switching display modes

2020-09-14 Thread Thomas Zimmermann
The ast HW cursor requires the primary plane and CRTC to display at a valid mode and format. This is not the case while switching display modes, which can lead to the screen turing permanently dark. As a workaround, the ast driver now disables active planes while the mode or format switch takes pl

[PATCH v3 3/4] drm/ast: Program display mode in CRTC's atomic_enable()

2020-09-14 Thread Thomas Zimmermann
This change simplifies ast's modesetting code. The display mode is now programmed from within the CRTC's atomic_enable(), which only runs if we actually want to program the mode. Corresponding code in atomic_flush() is being removed. Also removed is atomic_begin(), which serves no purpose at all.

[PATCH v3 4/4] drm/ast: Enable CRTC before planes

2020-09-14 Thread Thomas Zimmermann
An active cursor plane requires a valid display mode. Change the commit_tail callback, so that it sets up the CRTC's mode before updating planes. Signed-off-by: Thomas Zimmermann --- drivers/gpu/drm/ast/ast_mode.c | 7 +++ 1 file changed, 7 insertions(+) diff --git a/drivers/gpu/drm/ast/ast

Re: [PATCH] drm/vboxvideo: Use drm_gem_vram_vmap() interfaces

2020-09-14 Thread Thomas Zimmermann
Hi Am 11.09.20 um 16:07 schrieb Hans de Goede: > Hi, > > On 9/11/20 9:59 AM, Thomas Zimmermann wrote: >> VRAM helpers support ref counting for pin and vmap operations, no need >> to avoid these operations, by employing the internal kmap interface. Just >> use drm_gem_vram_vmap() and let it handle

Re: [PATCH] drm/vc4: Handing the return value of drm_universal_plane_init

2020-09-14 Thread Thomas Zimmermann
Hi Am 11.09.20 um 10:09 schrieb Tian Tao: > Handing the return value of drm_universal_plane_init to fix the following > W=1 kernel build warning(s): > vc4_plane.c: In function ‘vc4_plane_init’: > vc4_plane.c:1340:6: warning: variable ‘ret’ set but not > used [-Wunused-but-set-variable] > > Signed

[PATCH v2 0/3] Add support for SM8150 and SM8250 DSI.

2020-09-14 Thread Jonathan Marek
Note I haven't tested SM8150 recently, but DSI is almost identical to SM8250. v2: - added workaround for 5GHz max_rate overflowing in 32-bit builds (based on robclark's suggestion) - Updated Kconfig option to mention SM8250 and not just SM8150 Jonathan Marek (3): drm/msm/dsi: remove unused

[PATCH] drm/mediatek: add missing put_device() call in mtk_drm_kms_init()

2020-09-14 Thread Yu Kuai
if of_find_device_by_node() succeed, mtk_drm_kms_init() doesn't have a corresponding put_device(). Thus add jump target to fix the exception handling for this function implementation. Fixes: 119f5173628a ("drm/mediatek: Add DRM Driver for Mediatek SoC MT8173.") Signed-off-by: Yu Kuai --- drivers

Re: [RFC PATCH v2 10/17] WIP: gpu: host1x: Add no-recovery mode

2020-09-14 Thread Dmitry Osipenko
05.09.2020 13:34, Mikko Perttunen пишет: > + } else { > + struct host1x_job *failed_job = job; > + > + host1x_job_dump(dev, job); > + > + host1x_syncpt_set_locked(job->syncpt); > + failed_job->cancelled = true; > + > + list_for_each_en

Re: [PATCHv4 6/6] iommu: arm-smmu-impl: Remove unwanted extra blank lines

2020-09-14 Thread Sai Prakash Ranjan
On 2020-09-11 21:37, Will Deacon wrote: On Fri, Sep 11, 2020 at 05:03:06PM +0100, Robin Murphy wrote: BTW am I supposed to have received 3 copies of everything? Because I did... Yeah, this seems to be happening for all of Sai's emails :/ Sorry, I am not sure what went wrong as I only sent t

[PATCHv4 2/6] iommu/arm-smmu: Add domain attribute for system cache

2020-09-14 Thread Sai Prakash Ranjan
Add iommu domain attribute for using system cache aka last level cache by client drivers like GPU to set right attributes for caching the hardware pagetables into the system cache. Signed-off-by: Sai Prakash Ranjan --- drivers/iommu/arm/arm-smmu/arm-smmu.c | 17 + drivers/iommu/a

  1   2   >