Re: [PATCH] dma-buf: heap-helpers: Set dma-buf exporter name

2020-08-14 Thread Ezequiel Garcia
On Fri, 14 Aug 2020 at 23:20, John Stultz wrote: > > On Fri, Aug 14, 2020 at 7:25 AM Ezequiel Garcia > wrote: > > > > Currently the heap helper uses DEFINE_DMA_BUF_EXPORT_INFO, > > which uses KBUILD_MODNAME for the dma_buf_export_info.exp_name. > > > > This effectively makes all dma-bufs exporte

[PATCH 0/2] Fixes to drm_sched_priority (v2)

2020-08-14 Thread Luben Tuikov
Some fixes to enum drm_sched_priority which I'd wanted to do since last year. For instance, renaming MAX to COUNT, as usually a maximum value is a value which is part of the set of values, (e.g. a maxima of a function), and thus assignable, whereby a count is the size of a set (the enumeration in

[PATCH 1/2] drm/scheduler: Scheduler priority fixes (v2)

2020-08-14 Thread Luben Tuikov
Remove DRM_SCHED_PRIORITY_LOW, as it was used in only one place. Rename and separate by a line DRM_SCHED_PRIORITY_MAX to DRM_SCHED_PRIORITY_COUNT as it represents a (total) count of said priorities and it is used as such in loops throughout the code. (0-based indexing is the the count number.) Re

[PATCH 2/2] drm/scheduler: Remove priority macro INVALID (v2)

2020-08-14 Thread Luben Tuikov
Remove DRM_SCHED_PRIORITY_INVALID. We no longer carry around an invalid priority and cut it off at the source. Backwards compatibility behaviour of AMDGPU CTX IOCTL passing in garbage for context priority from user space and then mapping that to DRM_SCHED_PRIORITY_NORMAL is preserved. v2: Revert

Re: [PATCH] dma-buf: heap-helpers: Set dma-buf exporter name

2020-08-14 Thread John Stultz
On Fri, Aug 14, 2020 at 7:25 AM Ezequiel Garcia wrote: > > Currently the heap helper uses DEFINE_DMA_BUF_EXPORT_INFO, > which uses KBUILD_MODNAME for the dma_buf_export_info.exp_name. > > This effectively makes all dma-bufs exported by the heap > helper as coming from "heap-helpers", instead of th

Re: [PATCH v10 3/5] drm/msm/dp: add support for DP PLL driver

2020-08-14 Thread Tanmay Shah
On 2020-08-14 10:05, Dmitry Baryshkov wrote: On 12/08/2020 07:42, Tanmay Shah wrote: From: Chandan Uddaraju Add the needed DP PLL specific files to support display port interface on msm targets. [skipped] diff --git a/drivers/gpu/drm/msm/dp/dp_pll_private.h b/drivers/gpu/drm/msm/dp/dp_pll_

Re: [PATCH] drm/dp_mst: Don't return error code when crtc is null

2020-08-14 Thread Lakha, Bhawanpreet
[AMD Official Use Only - Internal Distribution Only] I took a closer look at this and there seems to be an issue in the function. Crtc being null is a valid case here. The sequence that leads to this is, unplug -> disable crtc/release vcpi slots then hotplug. The issue is that pos->port is not

Re: [PATCH 2/2] drm/scheduler: Remove priority macro INVALID

2020-08-14 Thread Luben Tuikov
On 2020-08-14 3:28 p.m., Alex Deucher wrote: > + dri-devel > > > On Fri, Aug 14, 2020 at 3:14 PM Luben Tuikov wrote: >> >> Remove DRM_SCHED_PRIORITY_INVALID. We no longer >> carry around an invalid priority and cut it off >> at the source. >> >> Backwards compatibility behaviour of AMDGPU CTX >>

Re: [Freedreno] [PATCH v10 2/5] drm/msm/dp: add displayPort driver support

2020-08-14 Thread Tanmay Shah
On 2020-08-14 10:56, Tanmay Shah wrote: On 2020-08-14 10:12, Dmitry Baryshkov wrote: Hello, On 12/08/2020 07:42, Tanmay Shah wrote: From: Chandan Uddaraju [skipped] + } else if ((dp_parser_check_prefix("ctrl", clk_name) || + dp_parser_check_prefix("s

Re: Role of DMA Heaps vs GEM in allocation

2020-08-14 Thread John Stultz
On Fri, Aug 14, 2020 at 3:59 AM Mikko Perttunen wrote: > > I'm currently working on a new UAPI for Host1x/TegraDRM (see first draft > in thread "[RFC] Host1x/TegraDRM UAPI"[1]). One question that has come > up is regarding the buffer allocation mechanism. Traditionally, DRM > drivers provide custo

Re: [RFC][PATCH v2 2/2] dma-heap: Add a system-uncached heap

2020-08-14 Thread John Stultz
On Fri, Aug 14, 2020 at 9:15 AM Ezequiel Garcia wrote: > Thanks for the patch. > > On Fri, 14 Aug 2020 at 03:25, John Stultz wrote: > > > > This adds a heap that allocates non-contiguous buffers that are > > marked as writecombined, so they are not cached by the CPU. > > > > What's the rationale

Re: [RFC][PATCH v2 2/2] dma-heap: Add a system-uncached heap

2020-08-14 Thread John Stultz
On Fri, Aug 14, 2020 at 2:17 AM Daniel Vetter wrote: > > On Fri, Aug 14, 2020 at 06:24:58AM +, John Stultz wrote: > > This adds a heap that allocates non-contiguous buffers that are > > marked as writecombined, so they are not cached by the CPU. > > > > This is useful, as most graphics buffers

Re: [PATCH] drm/modeset-lock: Take the modeset BKL for legacy drivers

2020-08-14 Thread Alex Deucher
On Fri, Aug 14, 2020 at 5:38 AM Daniel Vetter wrote: > > This fell off in the conversion in > > commit 9bcaa3fe58ab7559e71df798bcff6e0795158695 > Author: Michal Orzel > Date: Tue Apr 28 19:10:04 2020 +0200 > > drm: Replace drm_modeset_lock/unlock_all with DRM_MODESET_LOCK_ALL_* > helpers >

[PATCH v2] drm/mcde: Retry DSI read/write transactions

2020-08-14 Thread Linus Walleij
The vendor driver makes a few retries on read DSI transactions, something that is needed especially in case of read (such as reading the panel MTP ID) while the panel is running in video mode. This happens on the Samsung s6e63m0 panel on the Golden device. Retry reads and writes alike three times.

Re: [PATCH 2/2] drm/scheduler: Remove priority macro INVALID

2020-08-14 Thread Alex Deucher
+ dri-devel On Fri, Aug 14, 2020 at 3:14 PM Luben Tuikov wrote: > > Remove DRM_SCHED_PRIORITY_INVALID. We no longer > carry around an invalid priority and cut it off > at the source. > > Backwards compatibility behaviour of AMDGPU CTX > IOCTL passing in garbage for context priority > from user s

Re: [PATCH 0/2] Fixes to drm_sched_priority

2020-08-14 Thread Alex Deucher
+ dri-devel On Fri, Aug 14, 2020 at 3:14 PM Luben Tuikov wrote: > > Some fixes to enum drm_sched_priority which I'd wanted to do > since last year. > > For instance, renaming MAX to COUNT, as usually a maximum value > is a value which is part of the set of values, (e.g. a maxima of > a function),

Re: [PATCH] drm/dp_mst: Don't return error code when crtc is null

2020-08-14 Thread Lakha, Bhawanpreet
[AMD Official Use Only - Internal Distribution Only] pos->port->connector? This is checking the crtc not the connector. The crtc can be null if its disabled. Since it is happening after a unplug->hotplug, I guess we are missing something in the disable sequence and the old connector is still i

Re: [Freedreno] [PATCH v10 2/5] drm/msm/dp: add displayPort driver support

2020-08-14 Thread Tanmay Shah
On 2020-08-14 10:12, Dmitry Baryshkov wrote: Hello, On 12/08/2020 07:42, Tanmay Shah wrote: From: Chandan Uddaraju [skipped] + } else if ((dp_parser_check_prefix("ctrl", clk_name) || + dp_parser_check_prefix("stream", clk_name)) && +

RE: [PATCH] drm/dp_mst: Don't return error code when crtc is null

2020-08-14 Thread Ruhl, Michael J
>-Original Message- >From: dri-devel On Behalf Of >Bhawanpreet Lakha >Sent: Friday, August 14, 2020 1:02 PM >To: mikita.lip...@amd.com; nicholas.kazlaus...@amd.com; >alexander.deuc...@amd.com >Cc: Bhawanpreet Lakha ; dri- >de...@lists.freedesktop.org; amd-...@lists.freedesktop.org >Subject

Re: [git pull] drm for 5.8-rc1

2020-08-14 Thread Daniel Vetter
On Fri, Aug 14, 2020 at 7:17 PM Daniel Stone wrote: > > Hi, > > On Fri, 14 Aug 2020 at 17:22, Thierry Reding wrote: > > I suspect that the reason why this works in X but not in Wayland is > > because X passes the right usage flags, whereas Weston may not. But I'll > > have to investigate more in

Re: [git pull] drm for 5.8-rc1

2020-08-14 Thread Daniel Stone
Hi, On Fri, 14 Aug 2020 at 17:22, Thierry Reding wrote: > I suspect that the reason why this works in X but not in Wayland is > because X passes the right usage flags, whereas Weston may not. But I'll > have to investigate more in order to be sure. Weston allocates its own buffers for displaying

[PATCH] drm/dp_mst: Don't return error code when crtc is null

2020-08-14 Thread Bhawanpreet Lakha
[Why] In certain cases the crtc can be NULL and returning -EINVAL causes atomic check to fail when it shouln't. This leads to valid configurations failing because atomic check fails. [How] Don't early return if crtc is null Signed-off-by: Bhawanpreet Lakha --- drivers/gpu/drm/drm_dp_mst_topolog

Re: [PATCH] dt-bindings: Whitespace clean-ups in schema files

2020-08-14 Thread Luca Ceresoli
Hi, On 14/08/20 16:51, Rob Herring wrote: > On Thu, Aug 13, 2020 at 4:31 AM Luca Ceresoli wrote: >> >> Hi Rob, >> >> On 12/08/20 22:36, Rob Herring wrote: >>> Clean-up incorrect indentation, extra spaces, long lines, and missing >>> EOF newline in schema files. Most of the clean-ups are for list

Re: [git pull] drm for 5.8-rc1

2020-08-14 Thread Thierry Reding
On Fri, Aug 14, 2020 at 06:12:56PM +0200, Karol Herbst wrote: > On Fri, Aug 14, 2020 at 6:06 PM Thierry Reding > wrote: > > > > On Fri, Aug 14, 2020 at 05:40:34PM +0200, Karol Herbst wrote: > > > On Fri, Aug 14, 2020 at 5:35 PM Thierry Reding > > > wrote: > > > > > > > > On Fri, Aug 14, 2020 at

Re: [RFC][PATCH v2 2/2] dma-heap: Add a system-uncached heap

2020-08-14 Thread Ezequiel Garcia
Hi John, Thanks for the patch. On Fri, 14 Aug 2020 at 03:25, John Stultz wrote: > > This adds a heap that allocates non-contiguous buffers that are > marked as writecombined, so they are not cached by the CPU. > What's the rationale for exposing the memory attribute as a new heap, instead of ju

Re: [git pull] drm for 5.8-rc1

2020-08-14 Thread Karol Herbst
On Fri, Aug 14, 2020 at 6:06 PM Thierry Reding wrote: > > On Fri, Aug 14, 2020 at 05:40:34PM +0200, Karol Herbst wrote: > > On Fri, Aug 14, 2020 at 5:35 PM Thierry Reding > > wrote: > > > > > > On Fri, Aug 14, 2020 at 04:44:43PM +0200, Karol Herbst wrote: > > > > On Fri, Aug 14, 2020 at 4:05 PM

Re: [git pull] drm for 5.8-rc1

2020-08-14 Thread Thierry Reding
On Fri, Aug 14, 2020 at 05:40:34PM +0200, Karol Herbst wrote: > On Fri, Aug 14, 2020 at 5:35 PM Thierry Reding > wrote: > > > > On Fri, Aug 14, 2020 at 04:44:43PM +0200, Karol Herbst wrote: > > > On Fri, Aug 14, 2020 at 4:05 PM Thierry Reding > > > wrote: > > > > > > > > On Thu, Aug 13, 2020 at

Re: [git pull] drm for 5.8-rc1

2020-08-14 Thread Karol Herbst
On Fri, Aug 14, 2020 at 5:24 PM Thierry Reding wrote: > > On Fri, Aug 14, 2020 at 04:45:39PM +0200, Karol Herbst wrote: > > On Fri, Aug 14, 2020 at 4:08 PM Thierry Reding > > wrote: > > > > > > On Thu, Aug 13, 2020 at 05:39:39PM +0200, Karol Herbst wrote: > > > > btw, I just noticed that wayland

Re: [git pull] drm for 5.8-rc1

2020-08-14 Thread Karol Herbst
On Fri, Aug 14, 2020 at 5:35 PM Thierry Reding wrote: > > On Fri, Aug 14, 2020 at 04:44:43PM +0200, Karol Herbst wrote: > > On Fri, Aug 14, 2020 at 4:05 PM Thierry Reding > > wrote: > > > > > > On Thu, Aug 13, 2020 at 10:45:34AM -0700, James Jones wrote: > > > > I'll defer to Thierry, but I thin

Re: [git pull] drm for 5.8-rc1

2020-08-14 Thread Thierry Reding
On Fri, Aug 14, 2020 at 04:44:43PM +0200, Karol Herbst wrote: > On Fri, Aug 14, 2020 at 4:05 PM Thierry Reding > wrote: > > > > On Thu, Aug 13, 2020 at 10:45:34AM -0700, James Jones wrote: > > > I'll defer to Thierry, but I think that may be by design. Tegra format > > > modifiers were added to

Re: [PATCH 2/4] drm/panel: s6e63m0: Add DSI transport

2020-08-14 Thread Stephan Gerhold
On Sun, Aug 09, 2020 at 11:51:02PM +0200, Linus Walleij wrote: > This makes it possible to use the s6e63m0 panel with a > DSI host, such as in the Samsung GT-I8190 (Golden) mobile > phone. > > Cc: Stephan Gerhold > Cc: Paweł Chmiel > Signed-off-by: Linus Walleij > --- > drivers/gpu/drm/panel/K

Re: [git pull] drm for 5.8-rc1

2020-08-14 Thread Thierry Reding
On Fri, Aug 14, 2020 at 04:45:39PM +0200, Karol Herbst wrote: > On Fri, Aug 14, 2020 at 4:08 PM Thierry Reding > wrote: > > > > On Thu, Aug 13, 2020 at 05:39:39PM +0200, Karol Herbst wrote: > > > btw, I just noticed that wayland with gnome-shell is totally busted. > > > With this MR it at least d

Re: [PATCH] drm/dp_mst: Add ddc i2c device links for DP MST connectors

2020-08-14 Thread Imre Deak
On Wed, Jul 29, 2020 at 04:15:28PM +1000, Sam McNally wrote: > As of commit d8bd15b37d32 ("drm/dp_mst: Fix the DDC I2C device > registration of an MST port"), DP MST DDC I2C devices are consistently > parented to the underlying DRM device, making it challenging to > associate the ddc i2c device wit

Re: [PATCH] dt-bindings: Whitespace clean-ups in schema files

2020-08-14 Thread Rob Herring
On Thu, Aug 13, 2020 at 4:31 AM Luca Ceresoli wrote: > > Hi Rob, > > On 12/08/20 22:36, Rob Herring wrote: > > Clean-up incorrect indentation, extra spaces, long lines, and missing > > EOF newline in schema files. Most of the clean-ups are for list > > indentation which should always be 2 spaces m

Re: [git pull] drm for 5.8-rc1

2020-08-14 Thread Karol Herbst
On Fri, Aug 14, 2020 at 4:08 PM Thierry Reding wrote: > > On Thu, Aug 13, 2020 at 05:39:39PM +0200, Karol Herbst wrote: > > btw, I just noticed that wayland with gnome-shell is totally busted. > > With this MR it at least displays something, but without it doesn't > > work at all. > > Interesting,

Re: [git pull] drm for 5.8-rc1

2020-08-14 Thread Karol Herbst
On Fri, Aug 14, 2020 at 4:05 PM Thierry Reding wrote: > > On Thu, Aug 13, 2020 at 10:45:34AM -0700, James Jones wrote: > > I'll defer to Thierry, but I think that may be by design. Tegra format > > modifiers were added to get things like this working in the first place, > > right? It's not a reg

Re: [git pull] drm for 5.8-rc1

2020-08-14 Thread Thierry Reding
On Fri, Aug 14, 2020 at 03:59:16PM +0200, Karol Herbst wrote: > On Fri, Aug 14, 2020 at 3:57 PM Thierry Reding > wrote: > > > > On Thu, Aug 13, 2020 at 07:48:39PM +0200, Karol Herbst wrote: > > > On Thu, Aug 13, 2020 at 7:45 PM James Jones wrote: > > > > > > > > I'll defer to Thierry, but I thin

Re: [git pull] drm for 5.8-rc1

2020-08-14 Thread Thierry Reding
On Thu, Aug 13, 2020 at 05:39:39PM +0200, Karol Herbst wrote: > btw, I just noticed that wayland with gnome-shell is totally busted. > With this MR it at least displays something, but without it doesn't > work at all. Interesting, one of my typical test cases is to run Weston with a couple of test

Re: [git pull] drm for 5.8-rc1

2020-08-14 Thread Thierry Reding
On Thu, Aug 13, 2020 at 10:45:34AM -0700, James Jones wrote: > I'll defer to Thierry, but I think that may be by design. Tegra format > modifiers were added to get things like this working in the first place, > right? It's not a regression, is it? I recall that things used to work with or withou

Re: [PATCH v4 2/2] xen: add helpers to allocate unpopulated memory

2020-08-14 Thread Jürgen Groß
On 14.08.20 15:35, Roger Pau Monné wrote: On Fri, Aug 14, 2020 at 02:54:38PM +0200, Jürgen Groß wrote: On 14.08.20 14:47, Roger Pau Monné wrote: On Fri, Aug 14, 2020 at 12:27:32PM +0200, Jürgen Groß wrote: On 14.08.20 11:56, Roger Pau Monné wrote: On Fri, Aug 14, 2020 at 08:29:20AM +0100, Chr

Re: [git pull] drm for 5.8-rc1

2020-08-14 Thread Karol Herbst
On Fri, Aug 14, 2020 at 3:57 PM Thierry Reding wrote: > > On Thu, Aug 13, 2020 at 07:48:39PM +0200, Karol Herbst wrote: > > On Thu, Aug 13, 2020 at 7:45 PM James Jones wrote: > > > > > > I'll defer to Thierry, but I think that may be by design. Tegra format > > > modifiers were added to get thin

Re: [git pull] drm for 5.8-rc1

2020-08-14 Thread Thierry Reding
On Thu, Aug 13, 2020 at 07:48:39PM +0200, Karol Herbst wrote: > On Thu, Aug 13, 2020 at 7:45 PM James Jones wrote: > > > > I'll defer to Thierry, but I think that may be by design. Tegra format > > modifiers were added to get things like this working in the first place, > > right? It's not a reg

Re: [git pull] drm for 5.8-rc1

2020-08-14 Thread Karol Herbst
On Fri, Aug 14, 2020 at 3:40 PM Thierry Reding wrote: > > On Wed, Aug 12, 2020 at 10:03:46AM -0700, James Jones wrote: > > On 8/12/20 5:37 AM, Ilia Mirkin wrote: > > > On Wed, Aug 12, 2020 at 8:24 AM Karol Herbst wrote: > > > > > > > > On Wed, Aug 12, 2020 at 12:43 PM Karol Herbst > > > > wrote

Re: [git pull] drm for 5.8-rc1

2020-08-14 Thread Thierry Reding
On Thu, Aug 13, 2020 at 03:00:37PM +0200, Karol Herbst wrote: > At least for now I've created an MR to revert the change: > https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/6300 > > But it seems like there was probably a good reason why it got added? > Happy to have better fixes, but that

Re: [git pull] drm for 5.8-rc1

2020-08-14 Thread Thierry Reding
On Wed, Aug 12, 2020 at 10:03:46AM -0700, James Jones wrote: > On 8/12/20 5:37 AM, Ilia Mirkin wrote: > > On Wed, Aug 12, 2020 at 8:24 AM Karol Herbst wrote: > > > > > > On Wed, Aug 12, 2020 at 12:43 PM Karol Herbst wrote: > > > > > > > > On Wed, Aug 12, 2020 at 12:27 PM Karol Herbst > > > >

[PATCH 0/3] drm/panel: Add panel driver for the Mantix MLAF057WE51-X DSI panel

2020-08-14 Thread Guido Günther
The panel uses a Focaltech FT8006p, the touch part is handled by the already existing edt-ft5x06. It can be found in e.g. the Librem 5. This series is against next-20200814. Guido Günther (3): dt-bindings: vendor-prefixes: Add mantix vendor prefix dt-bindings: Add Mantix MLAF057WE51-X panel

[PATCH 3/3] drm/panel: Add panel driver for the Mantix MLAF057WE51-X DSI panel

2020-08-14 Thread Guido Günther
The panel uses a Focaltech FT8006p, the touch part is handled by the already existing edt-ft5x06. Signed-off-by: Guido Günther --- MAINTAINERS | 7 + drivers/gpu/drm/panel/Kconfig | 11 + drivers/gpu/drm/panel/Makefile| 1 +

[PATCH 1/3] dt-bindings: vendor-prefixes: Add mantix vendor prefix

2020-08-14 Thread Guido Günther
Add prefix for Mantix Display Technology Co.,Ltd. Signed-off-by: Guido Günther --- Documentation/devicetree/bindings/vendor-prefixes.yaml | 2 ++ 1 file changed, 2 insertions(+) diff --git a/Documentation/devicetree/bindings/vendor-prefixes.yaml b/Documentation/devicetree/bindings/vendor-prefi

[PATCH 2/3] dt-bindings: Add Mantix MLAF057WE51-X panel bindings

2020-08-14 Thread Guido Günther
The panel uses a Focaltech FT8006p, the touch part is handled by the already existing edt-ft5x06. Signed-off-by: Guido Günther --- .../display/panel/mantix,mlaf057we51-x.yaml | 73 +++ 1 file changed, 73 insertions(+) create mode 100644 Documentation/devicetree/bindings/displ

Re: [PATCH v8 2/3] drm: bridge: Add support for Cadence MHDP DPI/DP bridge

2020-08-14 Thread Tomi Valkeinen
On 11/08/2020 05:36, Laurent Pinchart wrote: >> +static int cdns_mhdp_mailbox_write(struct cdns_mhdp_device *mhdp, u8 val) >> +{ >> +int ret, full; >> + >> +WARN_ON(!mutex_is_locked(&mhdp->mbox_mutex)); >> + >> +ret = readx_poll_timeout(readl, mhdp->regs + CDNS_MAILBOX_FULL, >> +

Re: [PATCH v4 2/2] xen: add helpers to allocate unpopulated memory

2020-08-14 Thread Jürgen Groß
On 14.08.20 14:47, Roger Pau Monné wrote: On Fri, Aug 14, 2020 at 12:27:32PM +0200, Jürgen Groß wrote: On 14.08.20 11:56, Roger Pau Monné wrote: On Fri, Aug 14, 2020 at 08:29:20AM +0100, Christoph Hellwig wrote: On Thu, Aug 13, 2020 at 09:54:20AM +0200, Roger Pau Monn?? wrote: On Thu, Aug 13,

Re: [PATCH v8 2/3] drm: bridge: Add support for Cadence MHDP DPI/DP bridge

2020-08-14 Thread Tomi Valkeinen
On 11/08/2020 05:36, Laurent Pinchart wrote: >> +static int cdns_mhdp_connector_init(struct cdns_mhdp_device *mhdp) >> +{ >> +u32 bus_format = MEDIA_BUS_FMT_RGB121212_1X36; >> +struct drm_connector *conn = &mhdp->connector; >> +struct drm_bridge *bridge = &mhdp->bridge; >> +int ret

Re: Role of DMA Heaps vs GEM in allocation

2020-08-14 Thread Daniel Vetter
On Fri, Aug 14, 2020 at 1:34 PM Mikko Perttunen wrote: > > Hi, > > I'm currently working on a new UAPI for Host1x/TegraDRM (see first draft > in thread "[RFC] Host1x/TegraDRM UAPI"[1]). One question that has come > up is regarding the buffer allocation mechanism. Traditionally, DRM > drivers provi

Role of DMA Heaps vs GEM in allocation

2020-08-14 Thread Mikko Perttunen
Hi, I'm currently working on a new UAPI for Host1x/TegraDRM (see first draft in thread "[RFC] Host1x/TegraDRM UAPI"[1]). One question that has come up is regarding the buffer allocation mechanism. Traditionally, DRM drivers provide custom GEM allocation IOCTLs. However, we now have DMA Heaps,

Re: [PATCH v8 1/3] dt-bindings: drm/bridge: Document Cadence MHDP bridge bindings

2020-08-14 Thread Tomi Valkeinen
On 11/08/2020 03:36, Laurent Pinchart wrote: > I've got a chance to study the J721E datasheet, and it shows the DP > bridge has 4 inputs, to support MST. Shouldn't this already be reflected > in the DT bindings ? I think it should be as simple as having 4 input > ports (port@0 to port@3) and one o

Re: [PATCH v4 2/2] xen: add helpers to allocate unpopulated memory

2020-08-14 Thread Jürgen Groß
On 14.08.20 11:56, Roger Pau Monné wrote: On Fri, Aug 14, 2020 at 08:29:20AM +0100, Christoph Hellwig wrote: On Thu, Aug 13, 2020 at 09:54:20AM +0200, Roger Pau Monn?? wrote: On Thu, Aug 13, 2020 at 08:33:37AM +0100, Christoph Hellwig wrote: On Tue, Aug 11, 2020 at 11:44:47AM +0200, Roger Pau

[PATCH] drm/modeset-lock: Take the modeset BKL for legacy drivers

2020-08-14 Thread Daniel Vetter
This fell off in the conversion in commit 9bcaa3fe58ab7559e71df798bcff6e0795158695 Author: Michal Orzel Date: Tue Apr 28 19:10:04 2020 +0200 drm: Replace drm_modeset_lock/unlock_all with DRM_MODESET_LOCK_ALL_* helpers but it's caught by the drm_warn_on_modeset_not_all_locked() that the le

Re: [RFC][PATCH v2 2/2] dma-heap: Add a system-uncached heap

2020-08-14 Thread Daniel Vetter
On Fri, Aug 14, 2020 at 06:24:58AM +, John Stultz wrote: > This adds a heap that allocates non-contiguous buffers that are > marked as writecombined, so they are not cached by the CPU. > > This is useful, as most graphics buffers are usually not touched > by the CPU or only written into once b

Re: Warnings with drm: Replace drm_modeset_lock/unlock_all with DRM_MODESET_LOCK_ALL_* helpers

2020-08-14 Thread Daniel Vetter
On Thu, Aug 13, 2020 at 11:17:11PM -0400, Alex Deucher wrote: > The non-atomic modesetting code in amdgpu now spews warnings[1] with > this patch applied. I haven't really paged the legacy locking stuff > into my head in quite a while. Thoughts on how to proceed? Uh that mess. So the problem (a

[PATCH 2/4] drm/etnaviv: call perf_reg_read(..)

2020-08-14 Thread Christian Gmeiner
Replace the open coded access pattern with a function call. Signed-off-by: Christian Gmeiner --- drivers/gpu/drm/etnaviv/etnaviv_perfmon.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/drivers/gpu/drm/etnaviv/etnaviv_perfmon.c b/drivers/gpu/drm/etnaviv/etnaviv_perfmon.c

[PATCH 0/4] drm/etnaviv: add total hi bandwidth perf counters

2020-08-14 Thread Christian Gmeiner
This little patch set adds support for the total bandwidth used by HI. The basic hi bandwidth read-out is quite simple but I needed to add some little clean-ups to make it nice looking. Christian Gmeiner (4): drm/etnaviv: rename pipe_reg_read(..) drm/etnaviv: call perf_reg_read(..) drm/etnav

[PATCH 3/4] drm/etnaviv: add total hi bandwidth perfcounter

2020-08-14 Thread Christian Gmeiner
These two perf counters represent the total read and write GPU bandwidth in terms of 64bits. The used sequence was taken from Vivante kernel driver. Signed-off-by: Christian Gmeiner --- drivers/gpu/drm/etnaviv/etnaviv_perfmon.c | 35 ++- 1 file changed, 34 insertions(+), 1 d

[PATCH 1/4] drm/etnaviv: rename pipe_reg_read(..)

2020-08-14 Thread Christian Gmeiner
pipe_reg_read(..) iterates over all pixel pipes, selects a perf counter register and sums the actual perf counter value. Rename the function to reflect more what it is actual doing. Signed-off-by: Christian Gmeiner --- drivers/gpu/drm/etnaviv/etnaviv_perfmon.c | 30 +++ 1 fil

[PATCH 4/4] drm/etnaviv: add pipe_select(..) helper

2020-08-14 Thread Christian Gmeiner
Replace the open coded pixel pipe selection pattern with a function. Signed-off-by: Christian Gmeiner --- drivers/gpu/drm/etnaviv/etnaviv_perfmon.c | 24 +++ 1 file changed, 12 insertions(+), 12 deletions(-) diff --git a/drivers/gpu/drm/etnaviv/etnaviv_perfmon.c b/drivers/g

Re: [PATCH v4 2/2] drm: panel: Add tianma nt36672a panel driver

2020-08-14 Thread Sumit Semwal
Hello Sam, Thanks very much for the review. On Fri, 14 Aug 2020 at 01:16, Sam Ravnborg wrote: > > Hi Sumit. > > On Tue, Aug 11, 2020 at 11:51:07PM +0530, Sumit Semwal wrote: > > Some Poco F1 phones have an LCD panel from Tianma, model nt36672a, > > with a resolution of 1080x2246 that operates in

Re: [BUG] drm/ttm: Warning during suspend/freeze

2020-08-14 Thread Christian König
Hi Thomas, well I added a new assertion to catch cases when a driver tries to kmap a BO without grabbing the lock. Looks like QXL is doing exactly that here. Regards, Christian. Am 14.08.20 um 10:08 schrieb Thomas Gleixner: Suspending or freezing a KVM guest triggers the following warning r

Re: [PATCH 4/6] drm/rockchip: dw_hdmi: Add vendor hdmi properties

2020-08-14 Thread Pekka Paalanen
On Thu, 13 Aug 2020 13:45:22 +0300 Laurent Pinchart wrote: > On Thu, Aug 13, 2020 at 10:42:28AM +0300, Pekka Paalanen wrote: > > On Wed, 12 Aug 2020 16:30:17 +0300 Laurent Pinchart wrote: > > > On Wed, Aug 12, 2020 at 07:08:10PM +0800, crj wrote: > > > > 在 2020/8/12 17:33, Laurent Pinchart 写道

Re: [PATCH] MAINTAINERS: Change maintainer for hisilicon DRM driver

2020-08-14 Thread Thomas Zimmermann
Hi, as a driver maintainer, you should have commit access to drm-misc. Head over to https://drm.pages.freedesktop.org/maintainer-tools/commit-access.html for a description of what that means. The account is requested at https://www.freedesktop.org/wiki/AccountRequests/ as described under '