Re: [PATCH 1/6] drm/ttm: Add unampping of the entire device address space

2020-06-10 Thread Intel
On 6/10/20 11:19 PM, Andrey Grodzovsky wrote: On 6/10/20 4:30 PM, Thomas Hellström (Intel) wrote: On 6/10/20 5:30 PM, Daniel Vetter wrote: On Wed, Jun 10, 2020 at 04:05:04PM +0200, Christian König wrote: Am 10.06.20 um 15:54 schrieb Andrey Grodzovsky: On 6/10/20 6:15 AM, Thomas Hellström

Re: [PATCH 1/6] drm/ttm: Add unampping of the entire device address space

2020-06-10 Thread Intel
On 6/10/20 11:16 PM, Daniel Vetter wrote: On Wed, Jun 10, 2020 at 10:30 PM Thomas Hellström (Intel) wrote: On 6/10/20 5:30 PM, Daniel Vetter wrote: On Wed, Jun 10, 2020 at 04:05:04PM +0200, Christian König wrote: Am 10.06.20 um 15:54 schrieb Andrey Grodzovsky: On 6/10/20 6:15 AM, Thomas He

[git pull] drm i915 fixes for rc1

2020-06-10 Thread Dave Airlie
Hi Linus, dhowells reported an oops, and the i915 team tracked it down to a missing fix that didn't have correct tags, they've pulled it in along with two other fixes. I might have some more fixes for rc1, but I might not, taking the day off tomorrow, so probably won't be in a hurry to process an

[Bug 208135] AMDGPU sleep with preemption disabled

2020-06-10 Thread bugzilla-daemon
https://bugzilla.kernel.org/show_bug.cgi?id=208135 --- Comment #2 from yshu...@gmail.com --- And another one: [2.071364] BUG: sleeping function called from invalid context at mm/slab.h:567 [2.071379] in_atomic(): 1, irqs_disabled(): 0, non_block: 0, pid: 1, name: swapper/0 [2.071393]

[Bug 208135] AMDGPU sleep with preemption disabled

2020-06-10 Thread bugzilla-daemon
https://bugzilla.kernel.org/show_bug.cgi?id=208135 --- Comment #1 from yshu...@gmail.com --- And one more: [2.075377] BUG: sleeping function called from invalid context at mm/slab.h:567 [2.075391] in_atomic(): 1, irqs_disabled(): 0, non_block: 0, pid: 1, name: swapper/0 [2.075406] 1 l

[Bug 208135] New: AMDGPU sleep with preemption disabled

2020-06-10 Thread bugzilla-daemon
https://bugzilla.kernel.org/show_bug.cgi?id=208135 Bug ID: 208135 Summary: AMDGPU sleep with preemption disabled Product: Drivers Version: 2.5 Kernel Version: 5.7.2 Hardware: All OS: Linux Tree: Mainline

[Bug 207901] Nouveau: In a 4 monitor setup, 1-2 displays remains black after boot

2020-06-10 Thread bugzilla-daemon
https://bugzilla.kernel.org/show_bug.cgi?id=207901 --- Comment #15 from Maurice Gale (mauricega...@gmail.com) --- Hi! I have installed the closed source nvidia driver(nvidia-driver-440), and I am able to successfully get every display on every single boot. -- You are receiving this mail because:

[Bug 104791] ACPI errors on Lenovo C50-30 (AE_AML_INFINITE_LOOP, argument type mismatch)

2020-06-10 Thread bugzilla-daemon
https://bugzilla.kernel.org/show_bug.cgi?id=104791 James Ettle (ja...@ettle.org.uk) changed: What|Removed |Added Status|ASSIGNED|RESOLVED Resol

[Bug 207901] Nouveau: In a 4 monitor setup, 1-2 displays remains black after boot

2020-06-10 Thread bugzilla-daemon
https://bugzilla.kernel.org/show_bug.cgi?id=207901 Lyude Paul (thatsly...@gmail.com) changed: What|Removed |Added CC||thatsly...@gmail.com

Re: [PATCH 1/6] drm/ttm: Add unampping of the entire device address space

2020-06-10 Thread Andrey Grodzovsky
On 6/10/20 4:30 PM, Thomas Hellström (Intel) wrote: On 6/10/20 5:30 PM, Daniel Vetter wrote: On Wed, Jun 10, 2020 at 04:05:04PM +0200, Christian König wrote: Am 10.06.20 um 15:54 schrieb Andrey Grodzovsky: On 6/10/20 6:15 AM, Thomas Hellström (Intel) wrote: On 6/9/20 7:21 PM, Koenig, Chri

Re: [PATCH 1/6] drm/ttm: Add unampping of the entire device address space

2020-06-10 Thread Daniel Vetter
On Wed, Jun 10, 2020 at 10:30 PM Thomas Hellström (Intel) wrote: > > > On 6/10/20 5:30 PM, Daniel Vetter wrote: > > On Wed, Jun 10, 2020 at 04:05:04PM +0200, Christian König wrote: > >> Am 10.06.20 um 15:54 schrieb Andrey Grodzovsky: > >>> > >>> On 6/10/20 6:15 AM, Thomas Hellström (Intel) wrote:

Re: [PATCH 1/6] drm/ttm: Add unampping of the entire device address space

2020-06-10 Thread Intel
On 6/10/20 5:30 PM, Daniel Vetter wrote: On Wed, Jun 10, 2020 at 04:05:04PM +0200, Christian König wrote: Am 10.06.20 um 15:54 schrieb Andrey Grodzovsky: On 6/10/20 6:15 AM, Thomas Hellström (Intel) wrote: On 6/9/20 7:21 PM, Koenig, Christian wrote: Am 09.06.2020 18:37 schrieb "Grodzovsky

Re: [PATCH 1/1] AMDGPU: Replace invalid device ID with a valid device ID

2020-06-10 Thread Alex Deucher
Applied. Thanks! Alex On Wed, Jun 10, 2020 at 4:06 PM Sandeep Raghuraman wrote: > > Initializes Powertune data for a specific Hawaii card by fixing what looks > like a typo in the code. The device ID 66B1 is not a supported device ID for > this driver, and is not mentioned elsewhere. 67B1 is

[PATCH 1/1] AMDGPU: Replace invalid device ID with a valid device ID

2020-06-10 Thread Sandeep Raghuraman
Initializes Powertune data for a specific Hawaii card by fixing what looks like a typo in the code. The device ID 66B1 is not a supported device ID for this driver, and is not mentioned elsewhere. 67B1 is a valid device ID, and is a Hawaii Pro GPU. I have tested on my R9 390 which has device ID

[Bug 208129] amdgpu: polaris10 sudden crash, garbled graphics.

2020-06-10 Thread bugzilla-daemon
https://bugzilla.kernel.org/show_bug.cgi?id=208129 Alex Deucher (alexdeuc...@gmail.com) changed: What|Removed |Added CC||alexdeuc...@gmail.c

[Bug 208129] amdgpu: polaris10 sudden crash, garbled graphics.

2020-06-10 Thread bugzilla-daemon
https://bugzilla.kernel.org/show_bug.cgi?id=208129 --- Comment #5 from Martin Jørgensen (m...@gotu.dk) --- Created attachment 289609 --> https://bugzilla.kernel.org/attachment.cgi?id=289609&action=edit basic info -- You are receiving this mail because: You are watching the assignee of the bug.

[Bug 208129] amdgpu: polaris10 sudden crash, garbled graphics.

2020-06-10 Thread bugzilla-daemon
https://bugzilla.kernel.org/show_bug.cgi?id=208129 --- Comment #3 from Martin Jørgensen (m...@gotu.dk) --- Created attachment 289605 --> https://bugzilla.kernel.org/attachment.cgi?id=289605&action=edit xorg log -- You are receiving this mail because: You are watching the assignee of the bug. _

[Bug 208129] amdgpu: polaris10 sudden crash, garbled graphics.

2020-06-10 Thread bugzilla-daemon
https://bugzilla.kernel.org/show_bug.cgi?id=208129 --- Comment #4 from Martin Jørgensen (m...@gotu.dk) --- Created attachment 289607 --> https://bugzilla.kernel.org/attachment.cgi?id=289607&action=edit lsmod amdgpu -- You are receiving this mail because: You are watching the assignee of the bu

[PATCH] mm: Track mmu notifiers in fs_reclaim_acquire/release

2020-06-10 Thread Daniel Vetter
fs_reclaim_acquire/release nicely catch recursion issues when allocating GFP_KERNEL memory against shrinkers (which gpu drivers tend to use to keep the excessive caches in check). For mmu notifier recursions we do have lockdep annotations since 23b68395c7c7 ("mm/mmu_notifiers: add a lockdep map for

[Bug 208129] amdgpu: polaris10 sudden crash, garbled graphics.

2020-06-10 Thread bugzilla-daemon
https://bugzilla.kernel.org/show_bug.cgi?id=208129 --- Comment #1 from Martin Jørgensen (m...@gotu.dk) --- Created attachment 289601 --> https://bugzilla.kernel.org/attachment.cgi?id=289601&action=edit screen graphics after freeze -- You are receiving this mail because: You are watching the as

[Bug 208129] amdgpu: polaris10 sudden crash, garbled graphics.

2020-06-10 Thread bugzilla-daemon
https://bugzilla.kernel.org/show_bug.cgi?id=208129 --- Comment #2 from Martin Jørgensen (m...@gotu.dk) --- Created attachment 289603 --> https://bugzilla.kernel.org/attachment.cgi?id=289603&action=edit dmesg output -- You are receiving this mail because: You are watching the assignee of the bu

[Bug 208129] New: amdgpu: polaris10 sudden crash, garbled graphics.

2020-06-10 Thread bugzilla-daemon
https://bugzilla.kernel.org/show_bug.cgi?id=208129 Bug ID: 208129 Summary: amdgpu: polaris10 sudden crash, garbled graphics. Product: Drivers Version: 2.5 Kernel Version: 5.5.17 Hardware: x86-64 OS: Linux Tree

Re: [v3] drm/bridge: ti-sn65dsi86: ensure bridge suspend happens during PM sleep

2020-06-10 Thread Doug Anderson
Hi, On Tue, Jun 9, 2020 at 5:05 AM Harigovindan P wrote: > > ti-sn65dsi86 bridge is enumerated as a runtime device. When > suspend is triggered, PM core adds a refcount on all the > devices and calls device suspend, since usage count is > already incremented, runtime suspend will not be called >

Re: [PATCH] drm/ast: fix missing break in switch statement for format->cpp[0] case 4

2020-06-10 Thread Thomas Zimmermann
Hi Am 10.06.20 um 13:58 schrieb Colin King: > From: Colin Ian King > > Currently the switch statement for format->cpp[0] value 4 assigns > color_index which is never read again and then falls through to the > default case and returns. This looks like a missing break statement > bug. Fix this by

Re: (EXT) Re: [PATCH 3/4] drm/panel: simple: add CDTech S070PWS19HP-FC21 and S070SWV29HG-DC44

2020-06-10 Thread Sam Ravnborg
On Wed, Jun 10, 2020 at 05:26:23PM +0200, Matthias Schiffer wrote: > On Wed, 2020-06-10 at 16:59 +0200, Sam Ravnborg wrote: > > Hi Matthias. > > > > Thanks, a few details you need to fix. See below. > > > > Sam > > > > On Wed, Jun 10, 2020 at 02:01:30PM +0200, Matthias Schiffer wrote: > > >

Re: [PATCH v2 3/3] drm/dp_mst: Fix flushing the delayed port/mstb destroy work

2020-06-10 Thread Lyude Paul
my crunch time is over so I can review these on time now :) one small comment below, although it doesn't stop me from giving my R-B here: Reviewed-by: Lyude Paul On Wed, 2020-06-10 at 16:47 +0300, Imre Deak wrote: > Atm, a pending delayed destroy work during module removal will be > canceled,

Re: [PATCH 1/5] drm/omap: Fix suspend resume regression after platform data removal

2020-06-10 Thread Tomi Valkeinen
On 09/06/2020 20:10, Tony Lindgren wrote: On beagle-x15 I see these errors after modprobe: DSS: OMAP DSS rev 6.1 omapdss_dss 5800.dss: bound 58001000.dispc (ops dispc_component_ops [omapdss]) omapdss_dss 5800.dss: bound 5804.encoder (ops hdmi5_component_ops [omapdss]) [drm] Suppor

Re: [PATCH v3] drm/doc: device hot-unplug for userspace

2020-06-10 Thread Daniel Vetter
On Mon, Jun 01, 2020 at 05:32:03PM +0300, Pekka Paalanen wrote: > From: Pekka Paalanen > > Set up the expectations on how hot-unplugging a DRM device should look like to > userspace. > > Written by Daniel Vetter's request and largely based on his comments in IRC > and > from https://lists.freed

Re: [PATCH 08/17] drivers: gpu: drm: Fix trivial spelling

2020-06-10 Thread Daniel Vetter
On Tue, Jun 09, 2020 at 01:46:01PM +0100, Kieran Bingham wrote: > The word 'descriptor' is misspelled throughout the tree. > > Fix it up accordingly: > decriptors -> descriptors > > Signed-off-by: Kieran Bingham Queued for 5.9, thanks for your patch. -Daniel > --- > drivers/gpu/drm/drm_dp

Re: [PATCH v6 13/13] drm/print: Add tracefs support to the drm logging helpers

2020-06-10 Thread Sean Paul
On Wed, Jun 10, 2020 at 11:01 AM Steven Rostedt wrote: > > On Tue, 9 Jun 2020 11:49:19 -0400 > Sean Paul wrote: > > > +/** > > + * drm_trace_printf - adds an entry to the drm tracefs instance > > + * @format: printf format of the message to add to the trace > > + * > > + * This function adds a n

Re: [PATCH 1/6] drm/ttm: Add unampping of the entire device address space

2020-06-10 Thread Daniel Vetter
On Wed, Jun 10, 2020 at 04:05:04PM +0200, Christian König wrote: > Am 10.06.20 um 15:54 schrieb Andrey Grodzovsky: > > > > > > On 6/10/20 6:15 AM, Thomas Hellström (Intel) wrote: > > > > > > > > > On 6/9/20 7:21 PM, Koenig, Christian wrote: > > > > > > > > > > > > Am 09.06.2020 18:37 schrieb

Re: [Intel-gfx] [PATCH 03/18] dma-fence: basic lockdep annotations

2020-06-10 Thread Daniel Vetter
On Wed, Jun 10, 2020 at 4:22 PM Tvrtko Ursulin wrote: > > > On 04/06/2020 09:12, Daniel Vetter wrote: > > Design is similar to the lockdep annotations for workers, but with > > some twists: > > > > - We use a read-lock for the execution/worker/completion side, so that > >this explicit annotati

Re: [PATCH] dma-buf: Move dma_buf_release() from fops to dentry_ops

2020-06-10 Thread Sumit Semwal
On Wed, 10 Jun 2020 at 14:57, Arnd Bergmann wrote: > > On Wed, Jun 10, 2020 at 10:33 AM Sumit Semwal wrote: > > > > Charan Teja reported a 'use-after-free' in dmabuffs_dname [1], which > > happens if the dma_buf_release() is called while the userspace is > > accessing the dma_buf pseudo fs's dmab

Re: [PATCH v6 13/13] drm/print: Add tracefs support to the drm logging helpers

2020-06-10 Thread Steven Rostedt
On Tue, 9 Jun 2020 11:49:19 -0400 Sean Paul wrote: > +/** > + * drm_trace_printf - adds an entry to the drm tracefs instance > + * @format: printf format of the message to add to the trace > + * > + * This function adds a new entry in the drm tracefs instance > + */ > +void drm_trace_printf(cons

Re: [PATCH 4/4] drm/panel: simple: add Tianma TM070JVHG33

2020-06-10 Thread Sam Ravnborg
Hi Matthias. Thanks, also a few details here to fix. Sam On Wed, Jun 10, 2020 at 02:01:31PM +0200, Matthias Schiffer wrote: > From: Max Merchel > > Add support for the Tianma Micro-electronics TM070JVHG33 7.0" WXGA display > to panel-simple. > > Signed-off-by: Max Merchel > Signed-of

Re: [PATCH 3/4] drm/panel: simple: add CDTech S070PWS19HP-FC21 and S070SWV29HG-DC44

2020-06-10 Thread Sam Ravnborg
Hi Matthias. Thanks, a few details you need to fix. See below. Sam On Wed, Jun 10, 2020 at 02:01:30PM +0200, Matthias Schiffer wrote: > From: Michael Krummsdorf > > Add support for the CDTech Electronics displays S070PWS19HP-FC21 > (7.0" WSVGA) and S070SWV29HG-DC44 (7.0" WVGA) to panel

Re: [Intel-gfx] [PATCH 03/18] dma-fence: basic lockdep annotations

2020-06-10 Thread Tvrtko Ursulin
On 04/06/2020 09:12, Daniel Vetter wrote: Design is similar to the lockdep annotations for workers, but with some twists: - We use a read-lock for the execution/worker/completion side, so that this explicit annotation can be more liberally sprinkled around. With read locks lockdep isn't g

[PATCH] efi: avoid error message when booting under Xen

2020-06-10 Thread Juergen Gross
efifb_probe() will issue an error message in case the kernel is booted as Xen dom0 from UEFI as EFI_MEMMAP won't be set in this case. Avoid that message by calling efi_mem_desc_lookup() only if EFI_PARAVIRT isn't set. Fixes: 38ac0287b7f4 ("fbdev/efifb: Honour UEFI memory map attributes when mappi

Re: [PATCH v5 13/13] drm/print: Add tracefs support to the drm logging helpers

2020-06-10 Thread Pekka Paalanen
On Wed, 10 Jun 2020 09:29:37 -0400 Sean Paul wrote: > On Wed, Jun 10, 2020 at 3:57 AM Pekka Paalanen wrote: > > > > On Mon, 8 Jun 2020 17:05:03 -0400 > > Sean Paul wrote: > > > > > From: Sean Paul > > > > > > This patch adds a new module parameter called drm.trace which accepts > > > the sa

Re: [PATCH 1/6] drm/ttm: Add unampping of the entire device address space

2020-06-10 Thread Intel
On 6/10/20 3:54 PM, Andrey Grodzovsky wrote: On 6/10/20 6:15 AM, Thomas Hellström (Intel) wrote: On 6/9/20 7:21 PM, Koenig, Christian wrote: Am 09.06.2020 18:37 schrieb "Grodzovsky, Andrey" : On 6/5/20 2:40 PM, Christian König wrote: > Am 05.06.20 um 16:29 schrieb Andrey Grod

Re: [PATCH 1/6] drm/ttm: Add unampping of the entire device address space

2020-06-10 Thread Christian König
Am 10.06.20 um 15:54 schrieb Andrey Grodzovsky: On 6/10/20 6:15 AM, Thomas Hellström (Intel) wrote: On 6/9/20 7:21 PM, Koenig, Christian wrote: Am 09.06.2020 18:37 schrieb "Grodzovsky, Andrey" : On 6/5/20 2:40 PM, Christian König wrote: > Am 05.06.20 um 16:29 schrieb Andrey Gr

Re: [PATCH 5/6] drm/ttm: Add destroy flag in TTM BO eviction interface

2020-06-10 Thread Andrey Grodzovsky
On 6/10/20 6:25 AM, Thomas Hellström (Intel) wrote: On 5/9/20 8:51 PM, Andrey Grodzovsky wrote: This will allow to invalidate, destroy backing storage and notify users of BOs when device is unpluged. Signed-off-by: Andrey Grodzovsky Please add a motivation in the commit message and use impe

Re: [PATCH 1/6] drm/ttm: Add unampping of the entire device address space

2020-06-10 Thread Andrey Grodzovsky
On 6/10/20 6:15 AM, Thomas Hellström (Intel) wrote: On 6/9/20 7:21 PM, Koenig, Christian wrote: Am 09.06.2020 18:37 schrieb "Grodzovsky, Andrey" : On 6/5/20 2:40 PM, Christian König wrote: > Am 05.06.20 um 16:29 schrieb Andrey Grodzovsky: >> >> On 5/11/20 2:45 AM, Christ

[PATCH v2 3/3] drm/dp_mst: Fix flushing the delayed port/mstb destroy work

2020-06-10 Thread Imre Deak
Atm, a pending delayed destroy work during module removal will be canceled, leaving behind MST ports, mstbs. Fix this by using a dedicated workqueue which will be drained of requeued items as well when destroying it. v2: - Check if wq is NULL before calling destroy_workqueue(). Cc: Lyude Paul Cc

Re: [PATCH v5 13/13] drm/print: Add tracefs support to the drm logging helpers

2020-06-10 Thread Sean Paul
On Wed, Jun 10, 2020 at 3:57 AM Pekka Paalanen wrote: > > On Mon, 8 Jun 2020 17:05:03 -0400 > Sean Paul wrote: > > > From: Sean Paul > > > > This patch adds a new module parameter called drm.trace which accepts > > the same mask as drm.debug. When a debug category is enabled, log > > messages w

Re: [PATCH v9 03/11] drm: bridge: dw_mipi_dsi: add dsi v1.01 support

2020-06-10 Thread Yannick FERTRE
Hi Adrian, thanks for the pach: tested on stm32mp1. Tested-by: Yannick Fertré On 6/9/20 7:49 PM, Adrian Ratiu wrote: > The Synopsis MIPI DSI v1.01 host controller is quite widely used > on platforms like i.mx6 and is not very different from the other > versions like the 1.31/1.30 used on rockch

Re: [PATCH 02/18] dma-buf: minor doc touch-ups

2020-06-10 Thread Intel
On 6/4/20 10:12 AM, Daniel Vetter wrote: Just some tiny edits: - fix link to struct dma_fence - give slightly more meaningful title - the polling here is about implicit fences, explicit fences (in sync_file or drm_syncobj) also have their own polling Signed-off-by: Daniel Vetter Revie

Re: [PATCH v9 09/11] drm: bridge: dw-mipi-dsi: split low power cfg register into fields

2020-06-10 Thread Yannick FERTRE
Hi Adrian, thanks for the pach: tested on stm32mp1. Tested-by: Yannick Fertré On 6/9/20 7:49 PM, Adrian Ratiu wrote: > According to the Host Registers documentation for IMX, STM and RK > the LP cfg register should not be written entirely in one go because > some bits are reserved and should be

Re: [PATCH v9 10/11] drm: bridge: dw-mipi-dsi: fix bad register field offsets

2020-06-10 Thread Yannick FERTRE
Hi Adrian, thanks for the pach: tested on stm32mp1. Tested-by: Yannick Fertré On 6/9/20 7:49 PM, Adrian Ratiu wrote: > According to the DSI Host Registers sections available in the IMX, > STM and RK ref manuals for 1.01, 1.30 and 1.31, the register fields > are smaller or bigger than what's cod

Re: [Intel-gfx] [PATCH 01/18] mm: Track mmu notifiers in fs_reclaim_acquire/release

2020-06-10 Thread Daniel Vetter
On Wed, Jun 10, 2020 at 2:01 PM Thomas Hellström (Intel) wrote: > > Hi, Daniel, > > Please see below. > > On 6/4/20 10:12 AM, Daniel Vetter wrote: > > fs_reclaim_acquire/release nicely catch recursion issues when > > allocating GFP_KERNEL memory against shrinkers (which gpu drivers tend > > to use

Re: [PATCH v9 04/11] drm: bridge: dw_mipi_dsi: remove bind/unbind API

2020-06-10 Thread Yannick FERTRE
Hi Adrian, thanks for the pach: tested on stm32mp1. Tested-by: Yannick Fertré On 6/9/20 7:49 PM, Adrian Ratiu wrote: > The DW mipi-dsi bind/unbind API was only used to attach the bridge to > the encoder in the Rockchip driver, but with the addition of i.MX6 it > gets more complicated because th

Re: [PATCH] drm/tegra: Add zpos property for cursor planes

2020-06-10 Thread Ville Syrjälä
On Wed, Jun 10, 2020 at 01:30:59PM +0200, Thierry Reding wrote: > From: Thierry Reding > > As of commit 4dc55525b095 ("drm: plane: Verify that no or all planes > have a zpos property") a warning is emitted if there's a mix of planes > with and without a zpos property. > > On Tegra, cursor planes

Re: [PATCH 01/18] mm: Track mmu notifiers in fs_reclaim_acquire/release

2020-06-10 Thread Intel
Hi, Daniel, Please see below. On 6/4/20 10:12 AM, Daniel Vetter wrote: fs_reclaim_acquire/release nicely catch recursion issues when allocating GFP_KERNEL memory against shrinkers (which gpu drivers tend to use to keep the excessive caches in check). For mmu notifier recursions we do have lockd

[PATCH] drm/ast: fix missing break in switch statement for format->cpp[0] case 4

2020-06-10 Thread Colin King
From: Colin Ian King Currently the switch statement for format->cpp[0] value 4 assigns color_index which is never read again and then falls through to the default case and returns. This looks like a missing break statement bug. Fix this by adding a break statement. Addresses-Coverity: ("Unused v

Re: [Intel-gfx] A panic and a hang in the i915 drm driver

2020-06-10 Thread Jani Nikula
On Mon, 08 Jun 2020, David Howells wrote: > Jani Nikula wrote: > >> David, please try [1]. > > Assuming you mean this: > > https://patchwork.freedesktop.org/patch/366958/?series=77635&rev=1 > > yes, that works. > > Tested-by: David Howells Many thanks, Jani. -- Jani Nikula, Intel Open Sou

Re: [PATCH v4 08/12] device core: Introduce multiple dma pfn offsets

2020-06-10 Thread Jim Quinlan
Hi Andy, On Tue, Jun 9, 2020 at 7:18 AM Andy Shevchenko wrote: > > On Mon, Jun 08, 2020 at 11:48:51AM -0400, Jim Quinlan wrote: > > On Sun, Jun 7, 2020 at 12:500f9bfe0fb8840b268af1bbcc51f1cd440514e PM > > Andy Shevchenko wrote: > > > On Fri, Jun 05, 2020 at 05:26:48PM -0400, Jim Quinlan wrote: >

[PATCH] drm/tegra: Add zpos property for cursor planes

2020-06-10 Thread Thierry Reding
From: Thierry Reding As of commit 4dc55525b095 ("drm: plane: Verify that no or all planes have a zpos property") a warning is emitted if there's a mix of planes with and without a zpos property. On Tegra, cursor planes are always composited on top of all other planes, which is why they never had

Re: [PULL] drm-intel-next-fixes

2020-06-10 Thread Joonas Lahtinen
Quoting Joonas Lahtinen (2020-06-10 12:37:00) > Hi Dave & Daniel, > > Sending this one early for it to hopefully make it in before -rc1. > > Two important fixes: OOPS fix that was missing "Fixes:" tag and > not picked up earlier. Also fix for a use-after-free in cmdparser. > > Additional fixup t

Re: [PATCH 2/3] drm/dp_mst: Fix the DDC I2C device registration of an MST port

2020-06-10 Thread Lisovskiy, Stanislav
On Wed, Jun 10, 2020 at 01:09:36PM +0300, Imre Deak wrote: > On Wed, Jun 10, 2020 at 11:03:04AM +0300, Lisovskiy, Stanislav wrote: > > On Mon, Jun 08, 2020 at 12:25:21AM +0300, Imre Deak wrote: > > > During the initial MST probing an MST port's I2C device will be > > > registered using the kdev of

Re: [PATCH 5/6] drm/ttm: Add destroy flag in TTM BO eviction interface

2020-06-10 Thread Intel
On 5/9/20 8:51 PM, Andrey Grodzovsky wrote: This will allow to invalidate, destroy backing storage and notify users of BOs when device is unpluged. Signed-off-by: Andrey Grodzovsky Please add a motivation in the commit message and use imperative wording ("Allow to invalidate..." instead of

Re: [PATCH 1/6] drm/ttm: Add unampping of the entire device address space

2020-06-10 Thread Intel
On 6/9/20 7:21 PM, Koenig, Christian wrote: Am 09.06.2020 18:37 schrieb "Grodzovsky, Andrey" : On 6/5/20 2:40 PM, Christian König wrote: > Am 05.06.20 um 16:29 schrieb Andrey Grodzovsky: >> >> On 5/11/20 2:45 AM, Christian König wrote: >>> Am 09.05.20 um 20:51 schrieb A

Re: [PATCH 2/3] drm/dp_mst: Fix the DDC I2C device registration of an MST port

2020-06-10 Thread Imre Deak
On Wed, Jun 10, 2020 at 11:03:04AM +0300, Lisovskiy, Stanislav wrote: > On Mon, Jun 08, 2020 at 12:25:21AM +0300, Imre Deak wrote: > > During the initial MST probing an MST port's I2C device will be > > registered using the kdev of the DRM device as a parent. Later after MST > > Connection Status N

[PULL] drm-intel-next-fixes

2020-06-10 Thread Joonas Lahtinen
Hi Dave & Daniel, Sending this one early for it to hopefully make it in before -rc1. Two important fixes: OOPS fix that was missing "Fixes:" tag and not picked up earlier. Also fix for a use-after-free in cmdparser. Additional fixup to module param types. Regards, Joonas *** drm-intel-next-fi

Re: [PATCH] dma-buf: Move dma_buf_release() from fops to dentry_ops

2020-06-10 Thread Arnd Bergmann
On Wed, Jun 10, 2020 at 10:33 AM Sumit Semwal wrote: > > Charan Teja reported a 'use-after-free' in dmabuffs_dname [1], which > happens if the dma_buf_release() is called while the userspace is > accessing the dma_buf pseudo fs's dmabuffs_dname() in another process, > and dma_buf_release() release

Re: [PATCH v2] drm/rcar-du: DRM_RCAR_WRITEBACK depends on DRM

2020-06-10 Thread Kieran Bingham
Hi Qian, Laurent, On 08/06/2020 05:30, Qian Cai wrote: > > >> On Jun 7, 2020, at 11:16 PM, Laurent Pinchart >> wrote: >> >> I forgot to mention, I think the subject line should be >> >> drm/rcar-du: Make DRM_RCAR_WRITEBACK depend on DRM_RCAR_DU >> >> Could you please let me know if you're OK w

[PATCH] dma-buf: Move dma_buf_release() from fops to dentry_ops

2020-06-10 Thread Sumit Semwal
Charan Teja reported a 'use-after-free' in dmabuffs_dname [1], which happens if the dma_buf_release() is called while the userspace is accessing the dma_buf pseudo fs's dmabuffs_dname() in another process, and dma_buf_release() releases the dmabuf object when the last reference to the struct file g

Re: [PATCH 2/3] drm/dp_mst: Fix the DDC I2C device registration of an MST port

2020-06-10 Thread Lisovskiy, Stanislav
On Mon, Jun 08, 2020 at 12:25:21AM +0300, Imre Deak wrote: > During the initial MST probing an MST port's I2C device will be > registered using the kdev of the DRM device as a parent. Later after MST > Connection Status Notifications this I2C device will be re-registered > with the kdev of the port

Re: [PATCH v5 13/13] drm/print: Add tracefs support to the drm logging helpers

2020-06-10 Thread Pekka Paalanen
On Mon, 8 Jun 2020 17:05:03 -0400 Sean Paul wrote: > From: Sean Paul > > This patch adds a new module parameter called drm.trace which accepts > the same mask as drm.debug. When a debug category is enabled, log > messages will be put in a new tracefs instance called drm for > consumption. > >

Re: [PATCH 4/4] drm: pl111: Update documentation

2020-06-10 Thread kernel test robot
/drm-pl111-Credit-where-credit-is-due/20200610-041025 base: https://git.kernel.org/pub/scm/linux/kernel/git/daeinki/drm-exynos.git exynos-drm-next reproduce: make htmldocs If you fix the issue, kindly add following tag as appropriate Reported-by: kernel test robot All warnings (new ones prefixed

[PATCH v4 04/37] memory: tegra20-emc: Make driver modular

2020-06-10 Thread Dmitry Osipenko
This patch adds modularization support to the Tegra20 EMC driver. Driver now can be compiled as a loadable kernel module. Signed-off-by: Dmitry Osipenko --- drivers/memory/tegra/Kconfig | 2 +- drivers/memory/tegra/tegra20-emc.c | 17 - 2 files changed, 13 insertions(+), 6

Re: [PATCH 1/5] drm/omap: Fix suspend resume regression after platform data removal

2020-06-10 Thread Tony Lindgren
* Tony Lindgren [200609 17:11]: > I'm also seeing the rmmod omapdrm issue on am437x-sk-evm: Oops sorry this is a user error. I've forgotten I need to unbind the fb vtcon first :) thanks for hinting that Tomi! I can rmmod omapdrm just fine after doing: # echo 0 > /sys/class/vtconsole/vtcon1/bind

Re: [PATCH 1/5] drm/omap: Fix suspend resume regression after platform data removal

2020-06-10 Thread Tony Lindgren
* Tomi Valkeinen [200609 15:27]: > On 09/06/2020 18:19, Tony Lindgren wrote: > > Currently I'm only able to rmmod -f omapdrm, not sure if these issues might > > be related. > > Hmm, I always use modules, and can unload omapdrm and drm fine. But there's > a sequence that must be followed. However,

Re: [PATCH] drm/omap: force runtime PM suspend on system suspend

2020-06-10 Thread Tony Lindgren
* Tomi Valkeinen [200609 16:27]: > On 09/06/2020 19:10, Tony Lindgren wrote: > > Yeah so it seems. Can we just diconnect the display outputs > > in .prepare somewhere? Or is that the wrong place to do it? > > Hmm, yes, perhaps... If omapdrm uses .prepare to disable all the outputs. > Then DSS sub

[PATCH v6 1/6] of_graph: add of_graph_get_local_port()

2020-06-10 Thread Dmitry Osipenko
In some case, like a DRM display code for example, it's useful to silently check whether port node exists at all in a device-tree before proceeding with parsing the graph. This patch adds of_graph_get_local_port() which returns pointer to a local port node, or NULL if graph isn't specified in a de

[PATCH v4 33/37] memory: tegra30-emc: Continue probing if timings are missing in device-tree

2020-06-10 Thread Dmitry Osipenko
EMC driver will become mandatory after turning it into interconnect provider because interconnect users, like display controller driver, will fail to probe using newer device-trees that have interconnect properties. Thus make EMC driver to probe even if timings are missing in device-tree. Signed-o

[PATCH v4 00/37] Introduce memory interconnect for NVIDIA Tegra SoCs

2020-06-10 Thread Dmitry Osipenko
Hello, This series brings initial support for memory interconnect to Tegra20 and Tegra30 SoCs. For the starter only display controllers are getting interconnect API support, others could be supported later on. The display controllers have the biggest demand for interconnect API right now because

RE: [Bug Report] drivers/video/fbdev/kyro/fbdev.c: unsigned integer wrap-around might cause unexpected behavior

2020-06-10 Thread Changming Liu
> From: Bartlomiej Zolnierkiewicz > Sent: Tuesday, June 9, 2020 6:44 AM > To: Changming Liu > Cc: linux-fb...@vger.kernel.org; dri-devel@lists.freedesktop.org; Lu, Long > ; yaoh...@gmail.com > Subject: Re: [Bug Report] drivers/video/fbdev/kyro/fbdev.c: unsigned > integer wrap-around might cause u

[PATCH v4 12/37] PM / devfreq: tegra20: Use MC timings for building OPP table

2020-06-10 Thread Dmitry Osipenko
The clk_round_rate() won't be usable for building OPP table once interconnect support will be added to the EMC driver because that CLK API function limits the rounded rate based on the clk rate that is imposed by active clk-users, and thus, the rounding won't work as expected if interconnect will s

[PATCH v6 3/6] drm/tegra: output: Don't leak OF node on error

2020-06-10 Thread Dmitry Osipenko
The OF node should be put before returning error in tegra_output_probe(), otherwise node's refcount will be leaked. Reviewed-by: Laurent Pinchart Reviewed-by: Sam Ravnborg Signed-off-by: Dmitry Osipenko --- drivers/gpu/drm/tegra/output.c | 9 - 1 file changed, 4 insertions(+), 5 deleti

Re: [PATCH v2 11/15] pwm: crc: Implement get_state() method

2020-06-10 Thread Andy Shevchenko
On Sun, Jun 07, 2020 at 08:18:36PM +0200, Hans de Goede wrote: > Implement the pwm_ops.get_state() method to complete the support for the > new atomic PWM API. This one is good. Reviewed-by: Andy Shevchenko > Signed-off-by: Hans de Goede > --- > drivers/pwm/pwm-crc.c | 29

Re: [PATCH 1/5] drm/omap: Fix suspend resume regression after platform data removal

2020-06-10 Thread Tony Lindgren
* Tony Lindgren [200609 16:53]: > * Tomi Valkeinen [200609 15:27]: > > On 09/06/2020 18:19, Tony Lindgren wrote: > > > Currently I'm only able to rmmod -f omapdrm, not sure if these issues > > > might > > > be related. > > > > Hmm, I always use modules, and can unload omapdrm and drm fine. But

Re: [PATCH v4 08/12] device core: Introduce multiple dma pfn offsets

2020-06-10 Thread Andy Shevchenko
On Mon, Jun 08, 2020 at 11:48:51AM -0400, Jim Quinlan wrote: > On Sun, Jun 7, 2020 at 12:500f9bfe0fb8840b268af1bbcc51f1cd440514e PM > Andy Shevchenko wrote: > > On Fri, Jun 05, 2020 at 05:26:48PM -0400, Jim Quinlan wrote: ... > > > + *map_size = (num_ranges + 1) * sizeof(**map); > > > +

Re: [PATCH v2 10/15] pwm: crc: Implement apply() method to support the new atomic PWM API

2020-06-10 Thread Andy Shevchenko
On Tue, Jun 09, 2020 at 03:44:18PM +0200, Hans de Goede wrote: > On 6/9/20 1:32 PM, Andy Shevchenko wrote: > > On Sun, Jun 07, 2020 at 08:18:35PM +0200, Hans de Goede wrote: ... > > And again... :-( > > Well yes I cannot help it that the original code, as submitted by Intel, > was of very questi

[PATCH v4 37/37] drm/tegra: dc: Extend debug stats with total number of events

2020-06-10 Thread Dmitry Osipenko
It's useful to know the total number of underflow events and currently the debug stats are getting reset each time CRTC is being disabled. Let's account the overall number of events that doesn't get reset. Signed-off-by: Dmitry Osipenko --- drivers/gpu/drm/tegra/dc.c | 10 ++ drivers/gpu

[PATCH v4 31/37] memory: tegra20-emc: Register as interconnect provider

2020-06-10 Thread Dmitry Osipenko
Now memory controller is a memory interconnection provider. This allows us to use interconnect API in order to change memory configuration. Signed-off-by: Dmitry Osipenko --- drivers/memory/tegra/tegra20-emc.c | 110 + 1 file changed, 110 insertions(+) diff --git a/d

[PATCH v6 6/6] drm/tegra: output: rgb: Wrap directly-connected panel into DRM bridge

2020-06-10 Thread Dmitry Osipenko
Currently Tegra DRM driver manually manages display panel, but this management could be moved out into DRM core if we'll wrap panel into DRM bridge. This patch wraps RGB panel into a DRM bridge and removes manual handling of the panel from the RGB output code. Suggested-by: Laurent Pinchart Acked

Re: [PATCH] drm/omap: force runtime PM suspend on system suspend

2020-06-10 Thread Tony Lindgren
* Tomi Valkeinen [200609 15:38]: > On 09/06/2020 18:12, Tony Lindgren wrote: > > * Tomi Valkeinen [200609 10:33]: > > > Use suspend_late and resume_early callbacks in DSS submodules to force > > > runtime PM suspend and resume. > > > > > > We use suspend_late callback so that omapdrm's system su

[PATCH v6 4/6] drm/tegra: output: Support DRM bridges

2020-06-10 Thread Dmitry Osipenko
Newer Tegra device-trees will specify a video output graph which involves a bridge. This patch adds initial support for the DRM bridges to the Tegra DRM output. Acked-by: Sam Ravnborg Signed-off-by: Dmitry Osipenko --- drivers/gpu/drm/tegra/drm.h| 2 ++ drivers/gpu/drm/tegra/output.c | 12

[PATCH v4 13/37] PM / devfreq: tegra30: Use MC timings for building OPP table

2020-06-10 Thread Dmitry Osipenko
The clk_round_rate() won't be usable for building OPP table once interconnect support will be added to the EMC driver because that CLK API function limits the rounded rate based on the clk rate that is imposed by active clk-users, and thus, the rounding won't work as expected if interconnect will s

[PATCH v4 22/37] dt-bindings: host1x: Document new interconnect properties

2020-06-10 Thread Dmitry Osipenko
Most of Host1x devices have at least one memory client. These clients are directly connected to the memory controller. The new interconnect properties represent the memory client's connection to the memory controller. Signed-off-by: Dmitry Osipenko --- .../display/tegra/nvidia,tegra20-host1x.txt

[PATCH v4 18/37] dt-bindings: memory: tegra20: mc: Document new interconnect property

2020-06-10 Thread Dmitry Osipenko
Memory controller is interconnected with memory clients and with the external memory controller. Document new interconnect property which turns memory controller into interconnect provider. Acked-by: Rob Herring Signed-off-by: Dmitry Osipenko --- .../bindings/memory-controllers/nvidia,tegra20-m

Re: [PATCH v6 1/5] dt-bindings: msm/dp: add bindings of DP/DP-PLL driver for Snapdragon

2020-06-10 Thread Stephen Boyd
Quoting Tanmay Shah (2020-06-08 20:38:18) > diff --git a/Documentation/devicetree/bindings/display/msm/dp-sc7180.yaml > b/Documentation/devicetree/bindings/display/msm/dp-sc7180.yaml > new file mode 100644 > index 000..5fdb915 > --- /dev/null > +++ b/Documentation/devicetree/bindings/display/m

[PATCH v4 26/37] ARM: tegra: Add interconnect properties to Tegra30 device-tree

2020-06-10 Thread Dmitry Osipenko
Add interconnect properties to the memory controller, external memory controller and the display controller nodes in order to describe hardware interconnection. Signed-off-by: Dmitry Osipenko --- arch/arm/boot/dts/tegra30.dtsi | 23 ++- 1 file changed, 22 insertions(+), 1 del

[PATCH v4 07/37] memory: tegra124-emc: Use devm_platform_ioremap_resource

2020-06-10 Thread Dmitry Osipenko
Utilize that relatively new helper which makes code a bit cleaner. Signed-off-by: Dmitry Osipenko --- drivers/memory/tegra/tegra124-emc.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/drivers/memory/tegra/tegra124-emc.c b/drivers/memory/tegra/tegra124-emc.c index 98d98d

Re: [PATCH v2 10/15] pwm: crc: Implement apply() method to support the new atomic PWM API

2020-06-10 Thread Andy Shevchenko
On Sun, Jun 07, 2020 at 08:18:35PM +0200, Hans de Goede wrote: > Replace the enable, disable and config pwm_ops with an apply op, > to support the new atomic PWM API. ... > -static int crc_pwm_calc_clk_div(int period_ns) > +static int crc_pwm_apply(struct pwm_chip *chip, struct pwm_device *pwm, >

[PATCH v4 05/37] memory: tegra30-emc: Make driver modular

2020-06-10 Thread Dmitry Osipenko
This patch adds modularization support to the Tegra30 EMC driver. Driver now can be compiled as a loadable kernel module. Signed-off-by: Dmitry Osipenko --- drivers/memory/tegra/Kconfig | 2 +- drivers/memory/tegra/mc.c | 3 +++ drivers/memory/tegra/tegra30-emc.c | 17 ++

[PATCH v6 5/6] drm/tegra: output: rgb: Support LVDS encoder bridge

2020-06-10 Thread Dmitry Osipenko
Newer Tegra device-trees will specify a video output graph, which involves LVDS encoder bridge. This patch adds support for the LVDS encoder bridge to the RGB output, allowing us to model the display hardware properly. Reviewed-by: Laurent Pinchart Acked-by: Sam Ravnborg Signed-off-by: Dmitry Os

[PATCH v4 02/37] clk: tegra: Remove Memory Controller lock

2020-06-10 Thread Dmitry Osipenko
The shared Memory Controller lock isn't needed since the time when Memory Clock was made read-only. The lock could be removed safely now. Hence let's remove it, this will help a tad to make further patches cleaner. Signed-off-by: Dmitry Osipenko --- drivers/clk/tegra/clk-divider.c | 4 ++-- dri

[PATCH v4 29/37] memory: tegra20-emc: Use devm_platform_ioremap_resource

2020-06-10 Thread Dmitry Osipenko
Utilize that relatively new helper which makes code a bit cleaner. Signed-off-by: Dmitry Osipenko --- drivers/memory/tegra/tegra20-emc.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/drivers/memory/tegra/tegra20-emc.c b/drivers/memory/tegra/tegra20-emc.c index 2e310c51c

Re: [PATCH 1/2] drm/v3d: remove duplicated kfree in v3d_submit_cl_ioctl()

2020-06-10 Thread yukuai (C)
ping ? On 2020/6/1 20:32, yu kuai wrote: kfree() is called twice for the same variable 'bin', the first is introduced in commit 0d352a3a8a1f ("drm/v3d: don't leak bin job if v3d_job_init fails."), while the second is introduced in commit 29cd13cfd762 ("drm/v3d: Fix memory leak in v3d_submit_cl_i

  1   2   >