Re: [PATCH] drm/atomic-helper: reset vblank on crtc reset

2020-05-29 Thread Laurent Pinchart
Hi Daniel, Thank you for the patch. On Wed, May 27, 2020 at 11:53:32AM +0200, Daniel Vetter wrote: > Only when vblanks are supported ofc. > > Some drivers do this already, but most unfortunately missed it. This > opens up bugs after driver load, before the crtc is enabled for the > first time. s

[PATCH v2 09/22] drm: mxsfb: Remove unneeded includes

2020-05-29 Thread Laurent Pinchart
A fair number of includes are not needed. Drop them, and add a couple of required includes that were included indirectly. Signed-off-by: Laurent Pinchart Reviewed-by: Stefan Agner --- drivers/gpu/drm/mxsfb/mxsfb_crtc.c | 12 +++- drivers/gpu/drm/mxsfb/mxsfb_drv.c | 5 - 2 files ch

[PATCH v2 17/22] drm: mxsfb: Update internal IP version number for i.MX6SX

2020-05-29 Thread Laurent Pinchart
The LCDIF present in the i.MX6SX has extra features compared to the i.MX28. It has however lost its IP version register, so no official version number is known. Bump the version to MXSFB_V6 following the i.MX version, in preparation for support for the additional features. Signed-off-by: Laurent P

[PATCH v2 18/22] drm: mxsfb: Drop non-OF support

2020-05-29 Thread Laurent Pinchart
The mxsfb driver is only used by OF platforms. Drop non-OF support. Signed-off-by: Laurent Pinchart Reviewed-by: Stefan Agner --- drivers/gpu/drm/mxsfb/mxsfb_drv.c | 25 +++-- 1 file changed, 7 insertions(+), 18 deletions(-) diff --git a/drivers/gpu/drm/mxsfb/mxsfb_drv.c b

[PATCH v2 15/22] drm: mxsfb: Remove mxsfb_devdata unused fields

2020-05-29 Thread Laurent Pinchart
The debug0 and ipversion fields of the mxsfb_devdata structure are unused. Remove them. Signed-off-by: Laurent Pinchart Reviewed-by: Stefan Agner --- drivers/gpu/drm/mxsfb/mxsfb_drv.c | 4 drivers/gpu/drm/mxsfb/mxsfb_drv.h | 2 -- 2 files changed, 6 deletions(-) diff --git a/drivers/gpu/d

[PATCH v2 20/22] drm: mxsfb: Merge mxsfb_set_pixel_fmt() and mxsfb_set_bus_fmt()

2020-05-29 Thread Laurent Pinchart
The mxsfb_set_pixel_fmt() and mxsfb_set_bus_fmt() functions both deal with format configuration, are always called in a row from mxsfb_crtc_mode_set_nofb(), and set fields from the LCDC_CTRL register. This requires a read-modify-update cycle in mxsfb_set_bus_fmt(). Make this more efficient by mergi

[PATCH v2 19/22] drm: mxsfb: Turn mxsfb_set_pixel_fmt() into a void function

2020-05-29 Thread Laurent Pinchart
The mxsfb_set_pixel_fmt() function returns an error when the selected pixel format is unsupported. This can never happen, as such errors are caught by the DRM core. Remove the error check. Signed-off-by: Laurent Pinchart Reviewed-by: Stefan Agner --- drivers/gpu/drm/mxsfb/mxsfb_kms.c | 11 ++---

[PATCH v2 10/22] drm: mxsfb: Rename mxsfb_crtc.c to mxsfb_kms.c

2020-05-29 Thread Laurent Pinchart
The mxsfb_crtc.c file doesn't handle just the CRTC, but also the other KMS objects. Rename it accordingly. Signed-off-by: Laurent Pinchart Reviewed-by: Stefan Agner --- drivers/gpu/drm/mxsfb/Makefile | 2 +- drivers/gpu/drm/mxsfb/{mxsfb_crtc.c => mxsfb_kms.c} | 0 2 files c

[PATCH v2 02/22] drm: mxsfb: Use drm_panel_bridge

2020-05-29 Thread Laurent Pinchart
Replace the manual connector implementation based on drm_panel with the drm_panel_bridge helper. This simplifies the mxsfb driver by removing connector-related code, and standardizing all pipeline control operations on bridges. A hack is needed to get hold of the connector, as that's our only sour

[PATCH v2 22/22] drm: mxsfb: Support the alpha plane

2020-05-29 Thread Laurent Pinchart
The LCDIF in the i.MX6SX and i.MX7 have a second plane called the alpha plane. Support it. Signed-off-by: Laurent Pinchart --- Changes since v1: - Split whitespace cleanup to a separate patch --- drivers/gpu/drm/mxsfb/mxsfb_drv.c | 3 + drivers/gpu/drm/mxsfb/mxsfb_drv.h | 6 +- drivers/gp

[PATCH v2 21/22] drm: mxsfb: Remove unnecessary spaces after tab

2020-05-29 Thread Laurent Pinchart
This is a cosmetic change only, no code change is included. Signed-off-by: Laurent Pinchart --- drivers/gpu/drm/mxsfb/mxsfb_drv.h | 10 +- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/drivers/gpu/drm/mxsfb/mxsfb_drv.h b/drivers/gpu/drm/mxsfb/mxsfb_drv.h index 607a6a5e6b

[PATCH v2 03/22] drm: mxsfb: Use BIT() macro to define register bitfields

2020-05-29 Thread Laurent Pinchart
Using BIT() is preferred over manual shifts as it's more readable, handles the 1 << 31 case properly, and avoids other mistakes as shown by the DEBUG0_HSYNC and DEBUG0_VSYNC bits (that are currently unused). Use it. Signed-off-by: Laurent Pinchart Reviewed-by: Stefan Agner --- drivers/gpu/drm/m

[PATCH v2 07/22] drm: mxsfb: Use LCDC_CTRL register name explicitly

2020-05-29 Thread Laurent Pinchart
The LCDC_CTRL register is located at address 0x. Some of the accesses to the register simply use the mxsfb->base address. Reference the LCDC_CTRL register explicitly instead to clarify the code. Signed-off-by: Laurent Pinchart Reviewed-by: Stefan Agner --- drivers/gpu/drm/mxsfb/mxsfb_crtc.c

[PATCH v2 08/22] drm: mxsfb: Remove register definitions from mxsfb_crtc.c

2020-05-29 Thread Laurent Pinchart
mxsfb_crtc.c defines several macros related to register addresses and bit, which duplicates macros from mxsfb_regs.h. Use the macros from mxsfb_regs.h instead and remove them. Signed-off-by: Laurent Pinchart Reviewed-by: Stefan Agner --- drivers/gpu/drm/mxsfb/mxsfb_crtc.c | 14 +- 1

[PATCH v2 04/22] drm: mxsfb: Remove unused macros from mxsfb_regs.h

2020-05-29 Thread Laurent Pinchart
mxsfb_regs.h defines macros related to register bits. Some of them are not used and don't clearly map to any particular register, so their purpose isn't known. Remove them. Signed-off-by: Laurent Pinchart Reviewed-by: Stefan Agner --- drivers/gpu/drm/mxsfb/mxsfb_regs.h | 8 1 file chan

[PATCH v2 13/22] drm: mxsfb: Don't touch AXI clock in IRQ context

2020-05-29 Thread Laurent Pinchart
The driver attempts agressive power management by enabling and disabling the AXI clock around register accesses. This results in attempts to enable and disable the clock in the IRQ handler, which is a no-go as preparing or unpreparing the clock may sleep. On the other hand, the driver enables the

[PATCH v2 11/22] drm: mxsfb: Stop using DRM simple display pipeline helper

2020-05-29 Thread Laurent Pinchart
The DRM simple display pipeline helper only supports a single plane. In order to prepare for support of the alpha plane on i.MX6SX and i.MX7, move away from the helper. No new feature is added. Signed-off-by: Laurent Pinchart --- Changes since v1: - Move after mxsfb_crtc.c rename to mxsfb_kms.c

[PATCH v2 16/22] drm: mxsfb: Add i.MX7 and i.MX8M to the list of supported SoCs in Kconfig

2020-05-29 Thread Laurent Pinchart
Extend the Kconfig option description by listing the i.MX7 and i.MX8M SoCs, as they are supported by the same driver. Replace the list of SoCs in the short description with just "(e)LCDIF LCD controller" to avoid expanding it further in the future as support for more SoCs is added. Signed-off-by:

[PATCH v2 00/22] drm: mxsfb: Add i.MX7 support

2020-05-29 Thread Laurent Pinchart
Hello, This patch series adds i.MX7 support to the mxsfb driver. The eLCDIF instance found in the i.MX7 is backward-compatible with the already supported LCDC v4, but has extended features amongst which the most notable one is a second plane. The first 10 patches (01/22 to 10/22) contain miscella

[PATCH v2 01/22] drm: mxsfb: Remove fbdev leftovers

2020-05-29 Thread Laurent Pinchart
Commit 8e93f1028d74 ("drm/mxsfb: Use drm_fbdev_generic_setup()") replaced fbdev handling with drm_fbdev_generic_setup() but left inclusion of the drm/drm_fb_cma_helper.h header. Remove it. Fixes: 8e93f1028d74 ("drm/mxsfb: Use drm_fbdev_generic_setup()") Signed-off-by: Laurent Pinchart Reviewed-by

[PATCH v2 05/22] drm: mxsfb: Clarify format and bus width configuration

2020-05-29 Thread Laurent Pinchart
Replace the convoluted way to set the format and bus width through difficult to read macros with more explicit ones. Also remove the outdated comment related to the limitations on bus width setting as it doesn't apply anymore (the bus width can be specified through the display_info bus format). Si

[PATCH v2 14/22] drm: mxsfb: Enable vblank handling

2020-05-29 Thread Laurent Pinchart
Enable vblank handling when the CRTC is turned on and disable it when it is turned off. This requires moving vblank init after the KMS pipeline initialisation, otherwise drm_vblank_init() gets called with 0 CRTCs. Signed-off-by: Laurent Pinchart --- drivers/gpu/drm/mxsfb/mxsfb_drv.c | 15 +++

[PATCH v2 12/22] drm: mxsfb: Move vblank event arm to CRTC .atomic_flush()

2020-05-29 Thread Laurent Pinchart
The vblank event is armed in the plane .atomic_update(). This works fine as we have a single plane, and was the only option when the driver was using the drm_simple_kms_helper helper, but will break as soon as multiple planes are supported. Move it to CRTC .atomic_flush(). Signed-off-by: Laurent P

[PATCH v2 06/22] drm: mxsfb: Pass mxsfb_drm_private pointer to mxsfb_reset_block()

2020-05-29 Thread Laurent Pinchart
The mxsfb_reset_block() function isn't special, pass it the mxsfb_drm_private pointer instead of a pointer to the base address. Signed-off-by: Laurent Pinchart Reviewed-by: Stefan Agner --- drivers/gpu/drm/mxsfb/mxsfb_crtc.c | 12 ++-- 1 file changed, 6 insertions(+), 6 deletions(-) di

Re: [PATCH 21/21] drm: mxsfb: Support the alpha plane

2020-05-29 Thread Laurent Pinchart
Hi Stefan, On Tue, Mar 24, 2020 at 12:48:17AM +0100, Stefan Agner wrote: > On 2020-03-09 20:52, Laurent Pinchart wrote: > > The LCDIF in the i.MX6SX and i.MX7 have a second plane called the alpha > > plane. Support it. > > > > Signed-off-by: Laurent Pinchart > > --- > > drivers/gpu/drm/mxsfb/mx

Re: [PATCH 02/21] drm: mxsfb: Use drm_panel_bridge

2020-05-29 Thread Laurent Pinchart
Hi Stefan, On Mon, Mar 23, 2020 at 10:27:21PM +0100, Stefan Agner wrote: > On 2020-03-09 20:51, Laurent Pinchart wrote: > > Replace the manual connector implementation based on drm_panel with the > > drm_panel_bridge helper. This simplifies the mxsfb driver by removing > > connector-related code,

Re: [PATCH 09/21] drm: mxsfb: Remove unneeded includes

2020-05-29 Thread Laurent Pinchart
Hi Stefan, On Mon, Mar 23, 2020 at 10:53:50PM +0100, Stefan Agner wrote: > On 2020-03-09 20:52, Laurent Pinchart wrote: > > A fair number of includes are not needed. Drop them, and add a couple of > > required includes that were included indirectly. > > > > Signed-off-by: Laurent Pinchart > > O

Re: [PATCH 00/21] drm: mxsfb: Add i.MX7 support

2020-05-29 Thread Laurent Pinchart
Hi Stefan, On Tue, May 26, 2020 at 05:13:42PM +0200, Stefan Agner wrote: > On 2020-03-09 20:51, Laurent Pinchart wrote: > > Hello, > > > > This patch series adds i.MX7 support to the mxsfb driver. The eLCDIF > > instance found in the i.MX7 is backward-compatible with the already > > supported LCD

Re: [PATCH v3 4/6] drm: Add Generic USB Display driver

2020-05-29 Thread Peter Stuge
Hi Noralf, Noralf Trønnes wrote: > This adds a generic USB display driver with the intention that it can be > used with future USB interfaced low end displays/adapters. Fun! > The Linux gadget device driver will serve as the canonical device > implementation. That's a great goal, but as propos

Re: [RFC PATCH 2/2] drm: xlnx: driver for Xilinx DSI TX Subsystem

2020-05-29 Thread Hyun Kwon
Hi Laurent, On Wed, 2020-05-27 at 15:45:24 -0700, Laurent Pinchart wrote: > Hi Hyun, > > On Wed, May 27, 2020 at 10:54:35AM -0700, Hyun Kwon wrote: > > On Sat, 2020-05-23 at 20:08:13 -0700, Laurent Pinchart wrote: > > > On Mon, May 04, 2020 at 11:43:48AM -0700, Hyun Kwon wrote: > > >> On Mon, 202

[PATCH 2/2] drm/auth: drop unnessesary variable assignments

2020-05-29 Thread Emil Velikov
The variables are already the exact same value or will be overwritten shortly afterwords. In either case there's no functional difference. Cc: David Airlie Cc: Daniel Vetter Signed-off-by: Emil Velikov --- drivers/gpu/drm/drm_auth.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff

[PATCH 1/2] drm: vmwgfx: remove drm_driver::master_set() return typ

2020-05-29 Thread Emil Velikov
The function always returns zero (success). Ideally we'll remove it all together - although that's requires a little more work. For now, we can drop the return type and simplify the drm core code surrounding it. Cc: David Airlie Cc: Daniel Vetter Cc: VMware Graphics Cc: Roland Scheidegger Sig

Re: [PATCH] drm/selftests/mm: reduce per-function stack usage

2020-05-29 Thread Chris Wilson
Quoting Arnd Bergmann (2020-05-29 21:43:47) > On Fri, May 29, 2020 at 10:26 PM Chris Wilson > wrote: > > Quoting Arnd Bergmann (2020-05-29 21:15:26) > > > > > > > diff --git a/drivers/gpu/drm/selftests/test-drm_mm.c > > > b/drivers/gpu/drm/selftests/test-drm_mm.c > > > index 9aabe82dcd3a..30108

Re: [PATCH 0/8] Convert the intel iommu driver to the dma-iommu api

2020-05-29 Thread Marek Szyprowski
Hi Logan, On 29.05.2020 21:05, Logan Gunthorpe wrote: > On 2020-05-29 6:45 a.m., Christoph Hellwig wrote: >> On Thu, May 28, 2020 at 06:00:44PM -0600, Logan Gunthorpe wrote: This issue is most likely in the i915 driver and is most likely caused by the driver not respecting the return va

Re: [git pull] drm fixes for 5.7 final (apologies release)

2020-05-29 Thread pr-tracker-bot
The pull request you sent on Fri, 29 May 2020 12:37:51 +1000: > git://anongit.freedesktop.org/drm/drm tags/drm-fixes-2020-05-29-1 has been merged into torvalds/linux.git: https://git.kernel.org/torvalds/c/86e43b8bf0e6b3897e504cdb9230fd063ecd4452 Thank you! -- Deet-doot-dot, I am a bot. https:/

Re: [RFC PATCH 1/1] drm/mm: add ig_frag selftest

2020-05-29 Thread Nirmoy
On 5/29/20 5:52 PM, Chris Wilson wrote: Quoting Nirmoy (2020-05-29 16:40:53) This works correctly most of the times but sometimes I have to take my word back. In another machine,  20k insertions in best mode takes 6-9 times more than 10k insertions, all most all the time. evict, bottom-up

Re: [PATCH] drm/selftests/mm: reduce per-function stack usage

2020-05-29 Thread Arnd Bergmann
On Fri, May 29, 2020 at 10:26 PM Chris Wilson wrote: > Quoting Arnd Bergmann (2020-05-29 21:15:26) > > > > diff --git a/drivers/gpu/drm/selftests/test-drm_mm.c > > b/drivers/gpu/drm/selftests/test-drm_mm.c > > index 9aabe82dcd3a..30108c330db8 100644 > > --- a/drivers/gpu/drm/selftests/test-drm_m

Re: [PATCH] drm/selftests/mm: reduce per-function stack usage

2020-05-29 Thread Chris Wilson
Quoting Arnd Bergmann (2020-05-29 21:15:26) > The check_reserve_boundaries() function has a large array on the stack, > over 500 bytes. It gets inlined into __igt_reserve, which has multiple > other large structures as well but stayed just under the stack size > warning limit of 1024 bytes until on

[PATCH] drm/selftests/mm: reduce per-function stack usage

2020-05-29 Thread Arnd Bergmann
The check_reserve_boundaries() function has a large array on the stack, over 500 bytes. It gets inlined into __igt_reserve, which has multiple other large structures as well but stayed just under the stack size warning limit of 1024 bytes until one more member got added to struct drm_mm_node, causi

Re: [PATCH v3 104/105] dt-bindings: display: vc4: hdmi: Add BCM2711 HDMI controllers bindings

2020-05-29 Thread Rob Herring
On Wed, May 27, 2020 at 05:49:14PM +0200, Maxime Ripard wrote: > The HDMI controllers found in the BCM2711 SoC need some adjustments to the > bindings, especially since the registers have been shuffled around in more > register ranges. > > Cc: Rob Herring > Cc: devicet...@vger.kernel.org > Signed

[PATCH v3 1/6] drm/client: Add drm_client_init_from_id()

2020-05-29 Thread Noralf Trønnes
drm_client_init_from_id() provides a way for clients to add a client based on the minor. drm_client_register() is changed to return whether it was registered or not depending on the unplugged status of the DRM device. Its only caller drm_fbdev_generic_setup() runs inside probe() so it doesn't have

[PATCH v3 5/6] drm/gud: Add functionality for the USB gadget side

2020-05-29 Thread Noralf Trønnes
Since the USB gadget/device has to reach into the DRM internals, part of the code is placed in the DRM subsystem as a separate module. All calls into this module runs in process context and are serialized, except one function that runs in interrupt context. Since both the gadget side and the DRM s

[PATCH v3 4/6] drm: Add Generic USB Display driver

2020-05-29 Thread Noralf Trønnes
This adds a generic USB display driver with the intention that it can be used with future USB interfaced low end displays/adapters. The Linux gadget device driver will serve as the canonical device implementation. The following DRM properties are supported: - Plane rotation - Connector TV properti

[PATCH v3 6/6] usb: gadget: function: Add Generic USB Display support

2020-05-29 Thread Noralf Trønnes
This adds the gadget side support for the Generic USB Display. It presents a DRM display device as a USB Display configured through configfs. The display is implemented as a vendor type USB interface with one bulk out endpoint. The protocol is implemented using control requests. lz4 compressed fra

[PATCH v3 0/6] Generic USB Display driver

2020-05-29 Thread Noralf Trønnes
Hi, A while back I had the idea to turn a Raspberry Pi Zero into a $5 USB to HDMI/SDTV/DSI/DPI display adapter. This series adds a USB host driver and a device/gadget driver to achieve that. The reason for calling it 'Generic' is so anyone can make a USB display/adapter against this driver, all

[PATCH v3 3/6] drm/client: Add a way to set modeset, properties and rotation

2020-05-29 Thread Noralf Trønnes
This adds functions for clients that need more control over the configuration than what's setup by drm_client_modeset_probe(). Connector, fb and display mode can be set using drm_client_modeset_set(). Plane rotation can be set using drm_client_modeset_set_rotation() and other properties using drm_c

[PATCH v3 2/6] drm/client: Add drm_client_modeset_disable()

2020-05-29 Thread Noralf Trønnes
Add a way for clients to disable all outputs. Signed-off-by: Noralf Trønnes --- drivers/gpu/drm/drm_client_modeset.c | 20 include/drm/drm_client.h | 1 + 2 files changed, 21 insertions(+) diff --git a/drivers/gpu/drm/drm_client_modeset.c b/drivers/gpu/drm/drm

Re: [PATCH v6] drm/ioctl: Add a ioctl to set and get a label on GEM objects

2020-05-29 Thread Eric Anholt
On Fri, May 29, 2020 at 6:44 AM Rohan Garg wrote: > > Hey Eric! > > On jueves, 28 de mayo de 2020 20:45:24 (CEST) Eric Anholt wrote: > > On Thu, May 28, 2020 at 10:06 AM Rohan Garg > wrote: > > > DRM_IOCTL_HANDLE_SET_LABEL lets you label buffers associated > > > with a handle, making it easier to

[RFC PATCH v5 4/6] ARM: dts: exynos: Add interconnect properties to Exynos4412 bus nodes

2020-05-29 Thread Sylwester Nawrocki
This patch adds the following properties for Exynos4412 interconnect bus nodes: - samsung,interconnect-parent: to declare connections between nodes in order to guarantee PM QoS requirements between nodes; - #interconnect-cells: required by the interconnect framework. Note that #interconnect-c

[RFC PATCH v5 1/6] dt-bindings: exynos-bus: Add documentation for interconnect properties

2020-05-29 Thread Sylwester Nawrocki
Add documentation for new optional properties in the exynos bus nodes: samsung,interconnect-parent, #interconnect-cells. These properties allow to specify the SoC interconnect structure which then allows the interconnect consumer devices to request specific bandwidth requirements. Signed-off-by: A

[RFC PATCH v5 5/6] ARM: dts: exynos: Add interconnects to Exynos4412 mixer

2020-05-29 Thread Sylwester Nawrocki
From: Artur Świgoń This patch adds an 'interconnects' property to Exynos4412 DTS in order to declare the interconnect path used by the mixer. Please note that the 'interconnect-names' property is not needed when there is only one path in 'interconnects', in which case calling of_icc_get() with a

[RFC PATCH v5 2/6] interconnect: Add generic interconnect driver for Exynos SoCs

2020-05-29 Thread Sylwester Nawrocki
This patch adds a generic interconnect driver for Exynos SoCs in order to provide interconnect functionality for each "samsung,exynos-bus" compatible device. The SoC topology is a graph (or more specifically, a tree) and its edges are specified using the 'samsung,interconnect-parent' in the DT. Du

[RFC PATCH v5 3/6] PM / devfreq: exynos-bus: Add registration of interconnect child device

2020-05-29 Thread Sylwester Nawrocki
This patch adds registration of a child platform device for the exynos interconnect driver. It is assumed that the interconnect provider will only be needed when #interconnect-cells property is present in the bus DT node, hence the child device will be created only when such a property is present.

[RFC PATCH v5 0/6] Exynos: Simple QoS for exynos-bus using interconnect

2020-05-29 Thread Sylwester Nawrocki
This patchset adds interconnect API support for the Exynos SoC "samsung, exynos-bus" compatible devices, which already have their corresponding exynos-bus driver in the devfreq subsystem. Complementing the devfreq driver with an interconnect functionality allows to ensure the QoS requirements o

[RFC PATCH v5 6/6] drm: exynos: mixer: Add interconnect support

2020-05-29 Thread Sylwester Nawrocki
From: Marek Szyprowski This patch adds interconnect support to exynos-mixer. The mixer works the same as before when CONFIG_INTERCONNECT is 'n'. For proper operation of the video mixer block we need to ensure the interconnect busses like DMC or LEFTBUS provide enough bandwidth so as to avoid DMA

Re: [PATCH v3 4/5] arm64: dts: sun50i-a64-pinephone: Enable LCD support on PinePhone

2020-05-29 Thread Pavel Machek
Hi! > PinePhone uses PWM backlight and a XBD599 LCD panel over DSI for > display. > > Backlight levels curve was optimized by Martijn Braam using a > lux meter. If it was possible to preserve lux values for individual settings in the comment somewhere... that would be nice :-). One day, it woul

Re: [PATCH v8 0/8] Add support for devices in the Energy Model

2020-05-29 Thread Rafael J. Wysocki
On Fri, May 29, 2020 at 5:01 PM Lukasz Luba wrote: > > Hi Rafael, > > > On 5/27/20 10:58 AM, Lukasz Luba wrote: > > Hi all, > > > > Background of this version: > > This is the v8 of the patch set and is has smaller scope. I had to split > > the series into two: EM changes and thermal changes due t

Re: [PATCH v6 4/9] dt-bindings: display: panel: Add ilitek ili9341 panel bindings

2020-05-29 Thread Rob Herring
On Wed, 27 May 2020 15:27:28 +0800, dillon.min...@gmail.com wrote: > From: dillon min > > Add documentation for "ilitek,ili9341" panel. > > Signed-off-by: dillon min > --- > .../bindings/display/panel/ilitek,ili9341.yaml | 69 > ++ > 1 file changed, 69 insertions(+) >

Re: [RFC PATCH 1/1] drm/mm: add ig_frag selftest

2020-05-29 Thread Chris Wilson
Quoting Nirmoy (2020-05-29 16:40:53) > This works correctly most of the times but sometimes > > 20k insertions can take more than 8 times of 10k insertion time. The pressure is on to improve then :) > Regards, > > Nirmoy > > On 5/29/20 6:33 PM, Nirmoy Das wrote: > > This patch introduces fragm

Re: [Linux-stm32] [PATCH v8 08/10] drm: stm: dw-mipi-dsi: let the bridge handle the HW version check

2020-05-29 Thread Philippe CORNU
Hi Adrian, and thank you very much for the patchset. Thank you also for having tested it on STM32F769 and STM32MP1. Sorry for the late response, Yannick and I will review it as soon as possible and we will keep you posted. Note: Do not hesitate to put us in copy for the next version (philippe.co.

Re: [RFC PATCH 1/1] drm/mm: add ig_frag selftest

2020-05-29 Thread Nirmoy
This works correctly most of the times but sometimes 20k insertions can take more than 8 times of 10k insertion time. Regards, Nirmoy On 5/29/20 6:33 PM, Nirmoy Das wrote: This patch introduces fragmentation in the address range and measures time taken by 10k and 20k insertions. ig_frag() wi

Re: [PATCH v3] drm/fourcc: document modifier uniqueness requirements

2020-05-29 Thread Alex Deucher
On Fri, May 29, 2020 at 11:03 AM Daniel Stone wrote: > > On Fri, 29 May 2020 at 15:36, Alex Deucher wrote: > > On Fri, May 29, 2020 at 10:32 AM Daniel Stone wrote: > > > On Fri, 29 May 2020 at 15:29, Alex Deucher wrote: > > > > Maybe I'm over thinking this. I just don't want to get into a > >

[PATCH v7 6/6] drm/meson: crtc: handle commit of Amlogic FBC frames

2020-05-29 Thread Neil Armstrong
Since the VD1 Amlogic FBC decoder is now configured by the overlay driver, commit the right registers to decode the Amlogic FBC frame. Tested-by: Kevin Hilman Signed-off-by: Neil Armstrong --- drivers/gpu/drm/meson/meson_crtc.c | 118 + 1 file changed, 88 insertions(

[PATCH v7 1/6] drm/fourcc: Add modifier definitions for describing Amlogic Video Framebuffer Compression

2020-05-29 Thread Neil Armstrong
Amlogic uses a proprietary lossless image compression protocol and format for their hardware video codec accelerators, either video decoders or video input encoders. It considerably reduces memory bandwidth while writing and reading frames in memory. The underlying storage is considered to be 3 c

[PATCH v7 5/6] drm/meson: overlay: setup overlay for Amlogic FBC Scatter Memory layout

2020-05-29 Thread Neil Armstrong
Setup the Amlogic FBC decoder for the VD1 video overlay plane to use read the FBC header as Scatter Memory layout reference. Tested-by: Kevin Hilman Signed-off-by: Neil Armstrong --- drivers/gpu/drm/meson/meson_overlay.c | 53 ++- 1 file changed, 35 insertions(+), 18 del

[PATCH v7 4/6] drm/meson: overlay: setup overlay for Amlogic FBC Memory Saving mode

2020-05-29 Thread Neil Armstrong
Setup the Amlogic FBC decoder for the VD1 video overlay plane to use a different superblock size for the Memory Saving mode. Tested-by: Kevin Hilman Signed-off-by: Neil Armstrong --- drivers/gpu/drm/meson/meson_overlay.c | 25 +++-- 1 file changed, 23 insertions(+), 2 deleti

[PATCH v7 2/6] drm/meson: add Amlogic Video FBC registers

2020-05-29 Thread Neil Armstrong
Add the registers of the VPU VD1 Amlogic FBC decoder module, and routing register. Tested-by: Kevin Hilman Signed-off-by: Neil Armstrong --- drivers/gpu/drm/meson/meson_registers.h | 22 ++ 1 file changed, 22 insertions(+) diff --git a/drivers/gpu/drm/meson/meson_registers.

[PATCH v7 3/6] drm/meson: overlay: setup overlay for Amlogic FBC

2020-05-29 Thread Neil Armstrong
Setup the Amlogic FBC decoder for the VD1 video overlay plane. The VD1 Amlogic FBC decoder is integrated in the pipeline like the YUV pixel reading/formatter but used a direct memory address instead. This adds support for the basic layout, and needs to calculate the content body size since the he

[PATCH v7 0/6] drm/meson: add support for Amlogic Video FBC

2020-05-29 Thread Neil Armstrong
Amlogic uses a proprietary lossless image compression protocol and format for their hardware video codec accelerators, either video decoders or video input encoders. It considerably reduces memory bandwidth while writing and reading frames in memory. The underlying storage is considered to be 3 c

Re: [PATCH v3] drm/fourcc: document modifier uniqueness requirements

2020-05-29 Thread Daniel Stone
On Fri, 29 May 2020 at 15:36, Alex Deucher wrote: > On Fri, May 29, 2020 at 10:32 AM Daniel Stone wrote: > > On Fri, 29 May 2020 at 15:29, Alex Deucher wrote: > > > Maybe I'm over thinking this. I just don't want to get into a > > > situation where we go through a lot of effort to add modifier

Re: [Intel-gfx] [PATCH 06/13] ocfs2: use new sysctl subdir helper register_sysctl_subdir()

2020-05-29 Thread Kees Cook
On Fri, May 29, 2020 at 11:49:12AM +, Luis Chamberlain wrote: > Yikes, sense, you're right. Nope, I left the random config tests to > 0day. Will fix, thanks! Yeah, I do the same for randconfig, but I always do an "allmodconfig" build before sending stuff. It's a good smoke test. -- Kees Cook

Re: [PATCH] drm/shmem-helpers: Simplify dma-buf importing

2020-05-29 Thread Boris Brezillon
On Fri, 29 May 2020 16:05:42 +0200 Daniel Vetter wrote: > - Ditch the ->pages array > - Make it a private gem bo, which means no shmem object, which means > fireworks if anyone calls drm_gem_object_get_pages. But we've just > made sure that's all covered. > > v2: Rebase > > v3: I forgot to

Re: [PATCH v3] drm/fourcc: document modifier uniqueness requirements

2020-05-29 Thread Alex Deucher
On Fri, May 29, 2020 at 10:32 AM Daniel Stone wrote: > > On Fri, 29 May 2020 at 15:29, Alex Deucher wrote: > > Maybe I'm over thinking this. I just don't want to get into a > > situation where we go through a lot of effort to add modifier support > > and then performance ends up being worse than

Re: [PATCH v3] drm/fourcc: document modifier uniqueness requirements

2020-05-29 Thread Daniel Stone
On Fri, 29 May 2020 at 15:29, Alex Deucher wrote: > Maybe I'm over thinking this. I just don't want to get into a > situation where we go through a lot of effort to add modifier support > and then performance ends up being worse than it is today in a lot of > cases. I'm genuinely curious: what d

Re: [PATCH v3] drm/fourcc: document modifier uniqueness requirements

2020-05-29 Thread Alex Deucher
On Fri, May 29, 2020 at 9:58 AM Daniel Stone wrote: > > Hi Alex, > > On Fri, 29 May 2020 at 14:29, Alex Deucher wrote: > > On Fri, May 29, 2020 at 4:59 AM Simon Ser wrote: > > > OK. In this case I think it's fine to make the DMA-BUF import fail, as > > > we've suggested on IRC. The more-or-less

Re: [PATCH] xf86drm: add drmOpenByFB

2020-05-29 Thread Alex Deucher
On Fri, May 29, 2020 at 3:49 AM Pekka Paalanen wrote: > > On Thu, 28 May 2020 17:46:08 +0800 > Chih-Wei Huang wrote: > > > The main problem we're trying to solve is to > > find the DRM device of the primary framebuffer (fb0). > > Hi, > > I would say that is a completely wrong starting point. Plea

Re: [PATCH 1/1] drm/mm: fix hole size comparison

2020-05-29 Thread Christian König
Am 29.05.20 um 16:09 schrieb Chris Wilson: Quoting Nirmoy Das (2020-05-29 15:04:01) Fixes: 0cdea4455acd350a ("drm/mm: optimize rb_hole_addr rbtree search") Hmm. Indeed. Now, do you have a test case on your end that hits this? No, I just got time to double read through this and stumbled over i

Re: [PATCH 1/1] drm/mm: fix hole size comparison

2020-05-29 Thread Chris Wilson
Quoting Nirmoy Das (2020-05-29 15:04:01) > Fixes: 0cdea4455acd350a ("drm/mm: optimize rb_hole_addr rbtree search") Hmm. Indeed. Now, do you have a test case on your end that hits this? One of us should add one for drm-mm. -Chris ___ dri-devel mailing lis

[PATCH] drm/shmem-helpers: Simplify dma-buf importing

2020-05-29 Thread Daniel Vetter
- Ditch the ->pages array - Make it a private gem bo, which means no shmem object, which means fireworks if anyone calls drm_gem_object_get_pages. But we've just made sure that's all covered. v2: Rebase v3: I forgot to remove the page_count mangling from the free path too. Noticed by Boris wh

Re: [PATCH v3] drm/fourcc: document modifier uniqueness requirements

2020-05-29 Thread Daniel Stone
Hi Alex, On Fri, 29 May 2020 at 14:29, Alex Deucher wrote: > On Fri, May 29, 2020 at 4:59 AM Simon Ser wrote: > > OK. In this case I think it's fine to make the DMA-BUF import fail, as > > we've suggested on IRC. The more-or-less planned fix for these buffer > > sharing issues is to revive the b

Re: [PATCH 0/9] shmem helper untangling

2020-05-29 Thread Boris Brezillon
On Mon, 11 May 2020 11:35:45 +0200 Daniel Vetter wrote: > Hi all, > > I've started this a while ago, with the idea to move shmem helpers over > to dma_resv_lock. Big prep work for that was to untangle the layering > between functions called by drivers, and functions used to implement > drm_gem_o

Re: [PATCH] drm/shmem-helpers: Simplify dma-buf importing

2020-05-29 Thread Boris Brezillon
On Wed, 20 May 2020 20:02:32 +0200 Daniel Vetter wrote: > @@ -695,36 +702,16 @@ drm_gem_shmem_prime_import_sg_table(struct drm_device > *dev, > struct sg_table *sgt) > { > size_t size = PAGE_ALIGN(attach->dmabuf->size); > - size_t npages = size >> PA

Re: [PATCH v6] drm/ioctl: Add a ioctl to set and get a label on GEM objects

2020-05-29 Thread Rohan Garg
Hey Eric! On jueves, 28 de mayo de 2020 20:45:24 (CEST) Eric Anholt wrote: > On Thu, May 28, 2020 at 10:06 AM Rohan Garg wrote: > > DRM_IOCTL_HANDLE_SET_LABEL lets you label buffers associated > > with a handle, making it easier to debug issues in userspace > > applications. > > > > DRM_IOCTL_H

Re: [PATCH v3] drm/fourcc: document modifier uniqueness requirements

2020-05-29 Thread Daniel Vetter
On Fri, May 29, 2020 at 3:29 PM Alex Deucher wrote: > > On Fri, May 29, 2020 at 4:59 AM Simon Ser wrote: > > > > On Thursday, May 28, 2020 5:49 PM, Marek Olšák wrote: > > > > > On most hardware, there is a minimum pitch alignment for linear and > > > any greater multiple of the alignment is fine

Re: [PATCH] drm/shmem-helpers: Simplify dma-buf importing

2020-05-29 Thread Boris Brezillon
On Fri, 29 May 2020 15:34:28 +0200 Boris Brezillon wrote: > Hi Daniel, > > On Wed, 20 May 2020 20:02:32 +0200 > Daniel Vetter wrote: > > > - Ditch the ->pages array > > - Make it a private gem bo, which means no shmem object, which means > > fireworks if anyone calls drm_gem_object_get_pages

Re: [PATCH] drm/shmem-helpers: Simplify dma-buf importing

2020-05-29 Thread Boris Brezillon
Hi Daniel, On Wed, 20 May 2020 20:02:32 +0200 Daniel Vetter wrote: > - Ditch the ->pages array > - Make it a private gem bo, which means no shmem object, which means > fireworks if anyone calls drm_gem_object_get_pages. But we've just > made sure that's all covered. > > v2: Rebase > > Acke

Re: [git pull] drm fixes for 5.7-rc8/final

2020-05-29 Thread Rodrigo Vivi
On Fri, May 29, 2020 at 12:15:27PM +1000, Dave Airlie wrote: > On Fri, 29 May 2020 at 12:02, Dave Airlie wrote: > > > > On Fri, 29 May 2020 at 11:49, Linus Torvalds > > wrote: > > > > > > On Thu, May 28, 2020 at 5:21 PM Dave Airlie wrote: > > > > > > > > Seems to have wound down nicely, a couple

Re: [PATCH v3] drm/fourcc: document modifier uniqueness requirements

2020-05-29 Thread Alex Deucher
On Fri, May 29, 2020 at 4:59 AM Simon Ser wrote: > > On Thursday, May 28, 2020 5:49 PM, Marek Olšák wrote: > > > On most hardware, there is a minimum pitch alignment for linear and > > any greater multiple of the alignment is fine. > > > > On Navi, the pitch in bytes for linear must be > > align(

[Bug 207833] Brightness control not working on ASUS TUF FA506IU (AMD Ryzen 7 4800H / Nvidia GTX 1660 Ti)

2020-05-29 Thread bugzilla-daemon
https://bugzilla.kernel.org/show_bug.cgi?id=207833 Alex Deucher (alexdeuc...@gmail.com) changed: What|Removed |Added CC||alexdeuc...@gmail.c

Re: [PATCH 05/15] drm/panfrost: use spinlock instead of atomic

2020-05-29 Thread Steven Price
On 29/05/2020 13:35, Clément Péron wrote: Hi Robin, On Fri, 29 May 2020 at 14:20, Robin Murphy wrote: On 2020-05-10 17:55, Clément Péron wrote: Convert busy_count to a simple int protected by spinlock. A little more reasoning might be nice. I have follow the modification requested for li

Re: [PATCH 05/15] drm/panfrost: use spinlock instead of atomic

2020-05-29 Thread Robin Murphy
On 2020-05-10 17:55, Clément Péron wrote: Convert busy_count to a simple int protected by spinlock. A little more reasoning might be nice. Signed-off-by: Clément Péron --- [...] diff --git a/drivers/gpu/drm/panfrost/panfrost_devfreq.h b/drivers/gpu/drm/panfrost/panfrost_devfreq.h index 06

Re: [PATCH 01/13] sysctl: add new register_sysctl_subdir() helper

2020-05-29 Thread Luis Chamberlain
On Fri, May 29, 2020 at 11:13:21AM +0300, Jani Nikula wrote: > On Fri, 29 May 2020, Luis Chamberlain wrote: > > Often enough all we need to do is create a subdirectory so that > > we can stuff sysctls underneath it. However, *if* that directory > > was already created early on the boot sequence we

Re: [PATCH 09/13] firmware_loader: simplify sysctl declaration with register_sysctl_subdir()

2020-05-29 Thread Luis Chamberlain
On Fri, May 29, 2020 at 12:26:13PM +0200, Greg KH wrote: > On Fri, May 29, 2020 at 07:41:04AM +, Luis Chamberlain wrote: > > From: Xiaoming Ni > > > > Move the firmware config sysctl table to fallback_table.c and use the > > new register_sysctl_subdir() helper. This removes the clutter from >

Re: [PATCH 2/2] drm/atomic-helper: reset vblank on crtc reset

2020-05-29 Thread Boris Brezillon
On Wed, 27 May 2020 11:47:57 +0200 Daniel Vetter wrote: > Only when vblanks are supported ofc. > > Some drivers do this already, but most unfortunately missed it. This > opens up bugs after driver load, before the crtc is enabled for the > first time. syzbot spotted this when loading vkms as a s

Re: [PATCH 2/2] drm/atomic-helper: reset vblank on crtc reset

2020-05-29 Thread Daniel Vetter
On Wed, May 27, 2020 at 11:47:57AM +0200, Daniel Vetter wrote: > Only when vblanks are supported ofc. > > Some drivers do this already, but most unfortunately missed it. This > opens up bugs after driver load, before the crtc is enabled for the > first time. syzbot spotted this when loading vkms a

Re: [PATCH v2] drm: drm_fourcc: add NV15, Q410, Q401 YUV formats

2020-05-29 Thread Daniel Vetter
On Fri, May 29, 2020 at 12:47:26PM +0100, Ben Davis wrote: > DRM_FORMAT_NV15 is a 2 plane format suitable for linear and 16x16 Is there a specific modifier for this 16x16 block linear format? Feels a bit confusing, would be great to add that to the commit message so usage is clearer. We have DRM_F

Re: [Intel-gfx] [PATCH 06/13] ocfs2: use new sysctl subdir helper register_sysctl_subdir()

2020-05-29 Thread Luis Chamberlain
On Fri, May 29, 2020 at 01:23:19AM -0700, Kees Cook wrote: > On Fri, May 29, 2020 at 07:41:01AM +, Luis Chamberlain wrote: > > This simplifies the code considerably. The following coccinelle > > SmPL grammar rule was used to transform this code. > > > > // pycocci sysctl-subdir.cocci fs/ocfs2/

[PATCH v2] drm: drm_fourcc: add NV15, Q410, Q401 YUV formats

2020-05-29 Thread Ben Davis
DRM_FORMAT_NV15 is a 2 plane format suitable for linear and 16x16 block-linear memory layouts. The format is similar to P010 with 4:2:0 sub-sampling but has no padding between components. Instead, luminance and chrominance samples are grouped into 4s so that each group is packed into an integer num

Re: [PATCH] drm: use drm_dev_has_vblank more

2020-05-29 Thread Daniel Vetter
On Wed, May 27, 2020 at 02:02:12PM +0200, Thomas Zimmermann wrote: > > Am 27.05.20 um 13:11 schrieb Daniel Vetter: > > For historical reasons it's called dev->num_crtcs, which is rather > > confusing ever since kms was added. But now we have a nice helper, so > > let's use it for better readabilit

Re: [igt-dev] [PATCH i-g-t] panfrost: Test labeling functionality

2020-05-29 Thread Petri Latvala
On Thu, May 28, 2020 at 03:38:35PM +0200, Rohan Garg wrote: > Introduce tests to cover the new generic labeling ioctl's > being reviewed here [1]. > > Signed-off-by: Rohan Garg > > [1] https://patchwork.freedesktop.org/series/77267/ > > Signed-off-by: Rohan Garg > --- > include/drm-uapi/drm.h

  1   2   >