Re: [GIT PULL v2] mediatek drm next for 5.8

2020-05-27 Thread Dave Airlie
On Sat, 23 May 2020 at 01:58, Matthias Brugger wrote: > > > > On 20/05/2020 07:46, Dave Airlie wrote: > > On Wed, 20 May 2020 at 15:44, Dave Airlie wrote: > >> > >> On Mon, 18 May 2020 at 10:06, Chun-Kuang Hu > >> wrote: > >>> > >>> Hi, Dave & Daniel: > >>> > >>> This include dpi pin mode swap,

Re: [PATCH 1/2] drm/mxsfb: Call drm_crtc_vblank_on/off

2020-05-27 Thread Daniel Vetter
On Wed, May 27, 2020 at 11:47:56AM +0200, Daniel Vetter wrote: > mxsfb has vblank support, is atomic, but doesn't call > drm_crtc_vblank_on/off as it should. Not good. > > With my next patch to add the drm_crtc_vblank_reset to helpers this > means not even the very first crtc enabling will vblanks

Re: [Nouveau] [PATCH] nouveau: add fbdev dependency

2020-05-27 Thread Dave Airlie
On Thu, 28 May 2020 at 00:36, Arnd Bergmann wrote: > > On Wed, May 27, 2020 at 4:05 PM Ilia Mirkin wrote: > > > > Isn't this already fixed by > > > > https://cgit.freedesktop.org/drm/drm/commit/?id=7dbbdd37f2ae7dd4175ba3f86f4335c463b18403 > > Ok, I see that fixes the link error, but I when I crea

Re: [PATCH v1 4/4] gpu: host1x: debug: Dump push buffer state

2020-05-27 Thread kbuild test robot
Hi Dmitry, I love your patch! Perhaps something to improve: [auto build test WARNING on tegra-drm/drm/tegra/for-next] [also build test WARNING on v5.7-rc7 next-20200526] [if your patch is applied to the wrong git tree, please drop us a note to help improve the system. BTW, we also suggest to use

Re: [PATCH 5/4] dt-bindings: display: bridge: thc63lvd1024: Document dual-output mode

2020-05-27 Thread Rob Herring
On Thu, 14 May 2020 02:21:27 +0300, Laurent Pinchart wrote: > The DT binding support both dual-input and dual-output mode, but only > dual-input is documented. Document dual-output mode. > > Suggested-by: Jacopo Mondi > Signed-off-by: Laurent Pinchart > --- > .../display/bridge/thine,thc63lvd10

Re: [PATCH v3 1/5] dt-bindings: vendor-prefixes: Add Xingbangda

2020-05-27 Thread Rob Herring
On Wed, 13 May 2020 23:24:47 +0200, Ondrej Jirman wrote: > From: Icenowy Zheng > > Shenzhen Xingbangda Display Technology Co., Ltd is a company which > produces LCD modules. It supplies the LCD panels for the PinePhone. > > Add the vendor prefix of it. > > Signed-off-by: Icenowy Zheng > Signed

Re: [PATCH v3 2/5] dt-bindings: panel: Add binding for Xingbangda XBD599 panel

2020-05-27 Thread Rob Herring
On Wed, 13 May 2020 23:24:48 +0200, Ondrej Jirman wrote: > From: Icenowy Zheng > > Xingbangda XBD599 is a 5.99" 720x1440 MIPI-DSI LCD panel. It is based on > Sitronix ST7703 LCD controller. > > Add its device tree binding. > > Signed-off-by: Icenowy Zheng > Signed-off-by: Ondrej Jirman > ---

Re: [PATCH 3/3] drm/bridge: Introduce LT9611 DSI to HDMI bridge

2020-05-27 Thread Laurent Pinchart
Hi Vinod, Thank you for the patch. On Wed, May 13, 2020 at 03:35:33PM +0530, Vinod Koul wrote: > Lontium Lt9611 is a DSI to HDMI bridge which supports two DSI ports and > I2S port as an input and HDMI port as output > > Co-developed-by: Bjorn Andersson > Signed-off-by: Bjorn Andersson > Signed

Re: [PATCH 2/3] dt-bindings: display: bridge: Add documentation for LT9611

2020-05-27 Thread Laurent Pinchart
Hi Vinod, Thank you for the patch. On Wed, May 13, 2020 at 03:35:32PM +0530, Vinod Koul wrote: > Lontium LT9611 is a DSI to HDMI bridge which supports 2 DSI ports > and I2S port as input and one HDMI port as output > > Signed-off-by: Vinod Koul > --- > .../display/bridge/lontium,lt9611.yaml

Re: [PATCH 2/3] dt-bindings: display: bridge: Add documentation for LT9611

2020-05-27 Thread Rob Herring
On Wed, 13 May 2020 15:35:32 +0530, Vinod Koul wrote: > Lontium LT9611 is a DSI to HDMI bridge which supports 2 DSI ports > and I2S port as input and one HDMI port as output > > Signed-off-by: Vinod Koul > --- > .../display/bridge/lontium,lt9611.yaml| 178 ++ > 1 file cha

Re: [PATCH 1/3] dt-bindings: vendor-prefixes: Add Lontium vendor prefix

2020-05-27 Thread Rob Herring
On Wed, 13 May 2020 15:35:31 +0530, Vinod Koul wrote: > Add prefix for Lontium Semiconductor Corporation > > Signed-off-by: Vinod Koul > --- > Documentation/devicetree/bindings/vendor-prefixes.yaml | 2 ++ > 1 file changed, 2 insertions(+) > Acked-by: Rob Herring _

Re: [PATCH] drm/mediatek: dsi: fix scrolling of panel with small hfp or hbp

2020-05-27 Thread Chun-Kuang Hu
Hi, Jitao: Jitao Shi 於 2020年5月22日 週五 下午6:12寫道: > > If panel has too small hfp or hbp, horizontal_frontporch_byte or > horizontal_backporch_byte may become very small value or negative > value. This patch adjusts their values so that they are greater > than minimum value and keep total of them unc

[pull] amdgpu, amdkfd drm-next-5.8

2020-05-27 Thread Alex Deucher
Hi Dave, Daniel, Fixes for 5.8. The following changes since commit c41219fda6e04255c44d37fd2c0d898c1c46abf1: Merge tag 'drm-intel-next-fixes-2020-05-20' of git://anongit.freedesktop.org/drm/drm-intel into drm-next (2020-05-21 10:44:33 +1000) are available in the Git repository at: git://

Re: [RFC PATCH 2/2] drm: xlnx: driver for Xilinx DSI TX Subsystem

2020-05-27 Thread Laurent Pinchart
Hi Hyun, On Wed, May 27, 2020 at 10:54:35AM -0700, Hyun Kwon wrote: > On Sat, 2020-05-23 at 20:08:13 -0700, Laurent Pinchart wrote: > > On Mon, May 04, 2020 at 11:43:48AM -0700, Hyun Kwon wrote: > >> On Mon, 2020-04-20 at 14:20:56 -0700, Venkateshwar Rao Gannavarapu wrote: > >>> The Xilinx MIPI DS

[pull] amdgpu drm-fixes-5.7

2020-05-27 Thread Alex Deucher
Hi Dave, Daniel, A couple of small fixes for 5.7 The following changes since commit 7d9ff5eed4146bf026c69e766ff630bc0bd555bb: Merge tag 'amd-drm-fixes-5.7-2020-05-21' of git://people.freedesktop.org/~agd5f/linux into drm-fixes (2020-05-22 10:30:51 +1000) are available in the Git repository

Re: [Freedreno] [PATCH] drm/msm/dpu: ensure device suspend happens during PM sleep

2020-05-27 Thread Doug Anderson
Hi, On Fri, May 15, 2020 at 9:37 AM Doug Anderson wrote: > > Hi, > > On Fri, May 15, 2020 at 5:06 AM wrote: > > > > On 2020-05-14 21:47, Doug Anderson wrote: > > > Hi, > > > > > > On Fri, May 1, 2020 at 6:31 AM Kalyan Thota > > > wrote: > > >> > > >> "The PM core always increments the runtime u

Re: [Freedreno] [PATCH 5/6] drm: msm: a6xx: use dev_pm_opp_set_bw to set DDR bandwidth

2020-05-27 Thread Jordan Crouse
On Wed, May 27, 2020 at 08:38:47AM -0700, Rob Clark wrote: > On Wed, May 27, 2020 at 1:47 AM Sharat Masetty > wrote: > > > > + more folks > > > > On 5/18/2020 9:55 PM, Rob Clark wrote: > > > On Mon, May 18, 2020 at 7:23 AM Jordan Crouse > > > wrote: > > >> On Thu, May 14, 2020 at 04:24:18PM +05

Re: [Freedreno] [PATCH 5/6] drm: msm: a6xx: use dev_pm_opp_set_bw to set DDR bandwidth

2020-05-27 Thread Sibi Sankar
On 2020-05-27 23:01, Saravana Kannan wrote: On Wed, May 27, 2020 at 8:38 AM Rob Clark wrote: On Wed, May 27, 2020 at 1:47 AM Sharat Masetty wrote: > > + more folks > > On 5/18/2020 9:55 PM, Rob Clark wrote: > > On Mon, May 18, 2020 at 7:23 AM Jordan Crouse wrote: > >> On Thu, May 14, 2020

Re: [PATCH] drm/doc: device hot-unplug for userspace

2020-05-27 Thread Daniel Vetter
On Wed, May 27, 2020 at 9:44 PM Christian König wrote: > > Am 27.05.20 um 17:23 schrieb Andrey Grodzovsky: > > > > On 5/27/20 10:39 AM, Daniel Vetter wrote: > >> On Wed, May 27, 2020 at 3:51 PM Andrey Grodzovsky > >> wrote: > >>> > >>> On 5/27/20 2:44 AM, Pekka Paalanen wrote: > On Tue, 26 M

[PATCH v3] drm/panfrost: Reduce the amount of logs on deferred probe

2020-05-27 Thread Krzysztof Kozlowski
There is no point to print deferred probe (and its failures to get resources) as an error. Also there is no need to print regulator errors twice. In case of multiple probe tries this would pollute the dmesg. Signed-off-by: Krzysztof Kozlowski Reviewed-by: Steven Price --- Changes since v2: 1

Re: [PATCH] drm/doc: device hot-unplug for userspace

2020-05-27 Thread Christian König
Am 27.05.20 um 17:23 schrieb Andrey Grodzovsky: On 5/27/20 10:39 AM, Daniel Vetter wrote: On Wed, May 27, 2020 at 3:51 PM Andrey Grodzovsky wrote: On 5/27/20 2:44 AM, Pekka Paalanen wrote: On Tue, 26 May 2020 10:30:20 -0400 Andrey Grodzovsky wrote: On 5/19/20 6:06 AM, Pekka Paalanen wrot

Re: [PATCH v3 055/105] drm/vc4: hvs: Introduce a function to get the assigned FIFO

2020-05-27 Thread Eric Anholt
On Wed, May 27, 2020 at 8:50 AM Maxime Ripard wrote: > > At boot time, if we detect that a pixelvalve has been enabled, we need to > be able to retrieve the HVS channel it has been assigned to so that we can > disable that channel too. Let's create that function that returns the FIFO > or an error

[Bug 207901] Nouveau: In a 4 monitor setup, 1-2 displays remains black after boot

2020-05-27 Thread bugzilla-daemon
https://bugzilla.kernel.org/show_bug.cgi?id=207901 --- Comment #13 from Ilia Mirkin (imir...@alum.mit.edu) --- OK, that looks roughly identical to your v5.3 situation. -- You are receiving this mail because: You are watching the assignee of the bug. __

[Bug 207901] Nouveau: In a 4 monitor setup, 1-2 displays remains black after boot

2020-05-27 Thread bugzilla-daemon
https://bugzilla.kernel.org/show_bug.cgi?id=207901 --- Comment #12 from Maurice Gale (mauricega...@gmail.com) --- Created attachment 289357 --> https://bugzilla.kernel.org/attachment.cgi?id=289357&action=edit Log after firmware installation -- You are receiving this mail because: You are watch

[Bug 207901] Nouveau: In a 4 monitor setup, 1-2 displays remains black after boot

2020-05-27 Thread bugzilla-daemon
https://bugzilla.kernel.org/show_bug.cgi?id=207901 --- Comment #11 from Maurice Gale (mauricega...@gmail.com) --- Ok, I installed the firmware. Now I have 2/4 displays. -- You are receiving this mail because: You are watching the assignee of the bug. _

Re: [PATCH 7/9] drm/shmem-helpers: Redirect mmap for imported dma-buf

2020-05-27 Thread Daniel Vetter
On Wed, May 27, 2020 at 8:32 PM Thomas Zimmermann wrote: > > Hi Daniel, > > what's your plan for this patch set? I'd need this patch for the udl > shmem cleanup. I was pinging some people for a tested-by, I kinda don't want to push this entirely untested. I think at least one of the rendering dri

Re: [PATCH v3 059/105] drm/vc4: crtc: Add BCM2711 pixelvalves

2020-05-27 Thread Eric Anholt
On Wed, May 27, 2020 at 8:50 AM Maxime Ripard wrote: > > The BCM2711 has 5 pixelvalves, so now that our driver is ready, let's add > support for them. > > Signed-off-by: Maxime Ripard > --- > drivers/gpu/drm/vc4/vc4_crtc.c | 84 ++- > drivers/gpu/drm/vc4/vc4_regs.

Re: [PATCH v3 006/105] dt-bindings: display: Convert VC4 bindings to schemas

2020-05-27 Thread Rob Herring
On Wed, May 27, 2020 at 05:47:36PM +0200, Maxime Ripard wrote: > The BCM283x SoCs have a display pipeline composed of several controllers > with device tree bindings that are supported by Linux. > > Now that we have the DT validation in place, let's split into separate > files and convert the devi

Re: [PATCH] drm/radeon: Convert get_user_pages() --> pin_user_pages()

2020-05-27 Thread John Hubbard
On 2020-05-27 01:51, Daniel Vetter wrote: On Wed, May 27, 2020 at 10:48:52AM +0200, Daniel Vetter wrote: On Tue, May 26, 2020 at 03:57:45PM -0700, John Hubbard wrote: On 2020-05-26 14:00, Souptick Joarder wrote: This code was using get_user_pages(), in a "Case 2" scenario (DMA/RDMA), using the

Re: [PATCH] drm: pl111: add CONFIG_VEXPRESS_CONFIG dependency

2020-05-27 Thread Arnd Bergmann
On Wed, May 27, 2020 at 7:50 PM Sam Ravnborg wrote: > On Wed, May 27, 2020 at 05:47:21PM +0200, Arnd Bergmann wrote: > > On Wed, May 27, 2020 at 4:52 PM Sam Ravnborg wrote: > > > > > > Hi Arnd. > > > > > > On Wed, May 27, 2020 at 03:31:42PM +0200, Arnd Bergmann wrote: > > > > The vexpress_config

Re: [PATCH v3 070/105] drm/vc4: hdmi: rework connectors and encoders

2020-05-27 Thread Eric Anholt
On Wed, May 27, 2020 at 8:51 AM Maxime Ripard wrote: > > the vc4_hdmi driver has some custom structures to hold the data it needs to > associate with the drm_encoder and drm_connector structures. > > However, it allocates them separately from the vc4_hdmi structure which > makes it more complicate

Re: [PATCH 7/9] drm/shmem-helpers: Redirect mmap for imported dma-buf

2020-05-27 Thread Thomas Zimmermann
Hi Daniel, what's your plan for this patch set? I'd need this patch for the udl shmem cleanup. Best regards Thomas Am 11.05.20 um 11:35 schrieb Daniel Vetter: > Currently this seems to work by converting the sgt into a pages array, > and then treating it like a native object. Do the right thing

Re: [PATCH v3 041/105] drm/vc4: crtc: Move HVS mode config to HVS file

2020-05-27 Thread Eric Anholt
On Wed, May 27, 2020 at 8:50 AM Maxime Ripard wrote: > > Signed-off-by: Maxime Ripard > --- > drivers/gpu/drm/vc4/vc4_crtc.c | 272 +--- > drivers/gpu/drm/vc4/vc4_drv.h | 5 +- > drivers/gpu/drm/vc4/vc4_hvs.c | 298 ++- > 3 files ch

Re: [RFC PATCH 2/2] drm: xlnx: driver for Xilinx DSI TX Subsystem

2020-05-27 Thread Hyun Kwon
Hi Laurent, On Sat, 2020-05-23 at 20:08:13 -0700, Laurent Pinchart wrote: > Hi GVRao, > > Thank you for the patch. > > On Mon, May 04, 2020 at 11:43:48AM -0700, Hyun Kwon wrote: > > On Mon, 2020-04-20 at 14:20:56 -0700, Venkateshwar Rao Gannavarapu wrote: > > > The Xilinx MIPI DSI Tx Subsystem s

Re: [PATCH] drm: pl111: add CONFIG_VEXPRESS_CONFIG dependency

2020-05-27 Thread Sam Ravnborg
Hi Arnd. On Wed, May 27, 2020 at 05:47:21PM +0200, Arnd Bergmann wrote: > On Wed, May 27, 2020 at 4:52 PM Sam Ravnborg wrote: > > > > Hi Arnd. > > > > On Wed, May 27, 2020 at 03:31:42PM +0200, Arnd Bergmann wrote: > > > The vexpress_config code fails to link in some configurations: > > > > > > dr

Re: [PATCH] drm: use drm_dev_has_vblank more

2020-05-27 Thread Sam Ravnborg
On Wed, May 27, 2020 at 01:11:34PM +0200, Daniel Vetter wrote: > For historical reasons it's called dev->num_crtcs, which is rather > confusing ever since kms was added. But now we have a nice helper, so > let's use it for better readability! > > Only code change is in atomic helpers: vblank suppo

Re: [PATCH v3 040/105] drm/vc4: crtc: Turn pixelvalve reset into a function

2020-05-27 Thread Eric Anholt
On Wed, May 27, 2020 at 8:50 AM Maxime Ripard wrote: > > The driver resets the pixelvalve FIFO in a number of occurences without > always using the same sequence. > > Since this will be critical for BCM2711, let's move that sequence to a > function so that we are consistent. > > Signed-off-by: Max

Re: [PATCH v3 033/105] drm/vc4: crtc: Assign output to channel automatically

2020-05-27 Thread Eric Anholt
On Wed, May 27, 2020 at 8:50 AM Maxime Ripard wrote: > > The HVS found in the BCM2711 has 6 outputs and 3 FIFOs, with each output > being connected to a pixelvalve, and some muxing between the FIFOs and > outputs. > > Any output cannot feed from any FIFO though, and they all have a bunch of > cons

Re: [PATCH v3 032/105] drm/vc4: crtc: Enable and disable the PV in atomic_enable / disable

2020-05-27 Thread Eric Anholt
On Wed, May 27, 2020 at 8:50 AM Maxime Ripard wrote: > > The VIDEN bit in the pixelvalve currently being used to enable or disable > the pixelvalve seems to not be enough in some situations, which whill end > up with the pixelvalve stalling. > > In such a case, even re-enabling VIDEN doesn't bring

Re: [PATCH v3 020/105] drm/vc4: plane: Create overlays for any CRTC

2020-05-27 Thread Eric Anholt
On Wed, May 27, 2020 at 8:49 AM Maxime Ripard wrote: > > Now that we have everything in place, we can now register all the overlay > planes that can be assigned to all the CRTCs. > > This has two side effects: > > - The number of overlay planes is reduced from 24 to 8. This is temporary > an

Re: [PATCH v3 016/105] drm/vc4: plane: Improve LBM usage

2020-05-27 Thread Eric Anholt
On Wed, May 27, 2020 at 8:49 AM Maxime Ripard wrote: > > From: Dave Stevenson > > LBM allocations were always taking the worst case sizing of > max(src_width, dst_width) * 16. This is significantly over > the required sizing, and stops us rendering multiple 4k images > to the screen. > > Add some

[Bug 207901] Nouveau: In a 4 monitor setup, 1-2 displays remains black after boot

2020-05-27 Thread bugzilla-daemon
https://bugzilla.kernel.org/show_bug.cgi?id=207901 --- Comment #10 from Ilia Mirkin (imir...@alum.mit.edu) --- It looks like you don't have firmware present, which starting with v5.6 fails the whole module load. (I believe that's a separate bug.) Try installing linux-firmware, and making the firm

Re: [PATCH v3 015/105] drm/vc4: hvs: Boost the core clock during modeset

2020-05-27 Thread Eric Anholt
On Wed, May 27, 2020 at 8:49 AM Maxime Ripard wrote: > > In order to prevent timeouts and stalls in the pipeline, the core clock > needs to be maxed at 500MHz during a modeset on the BCM2711. Like, the whole system's core clock? How is it reasonable for some device driver to crank the system's c

Re: [PATCH v3 012/105] drm/vc4: drv: Support BCM2711

2020-05-27 Thread Eric Anholt
On Wed, May 27, 2020 at 8:49 AM Maxime Ripard wrote: > > The BCM2711 has a reworked display pipeline, and the load tracker needs > some adjustement to operate properly. Let's add a compatible for BCM2711 > and disable the load tracker until properly supported. > > Signed-off-by: Maxime Ripard > -

Re: [PATCH v3 002/105] reset: simple: Add reset callback

2020-05-27 Thread Philipp Zabel
Hi Maxime, On Wed, 2020-05-27 at 17:47 +0200, Maxime Ripard wrote: > The reset-simple code lacks a reset callback that is still pretty easy to > implement. The only real thing to consider is the delay needed for a device > to be reset, so let's expose that as part of the reset-simple driver data.

Re: [PATCH] [v2] drm/panfrost: Fix runtime PM imbalance on error

2020-05-27 Thread Steven Price
On 22/05/2020 14:41, Dinghao Liu wrote: The caller expects panfrost_job_hw_submit() to increase runtime PM usage counter. The refcount decrement on the error branch of WARN_ON() will break the counter balance and needs to be removed. Signed-off-by: Dinghao Liu Reviewed-by: Steven Price Than

Re: [PATCH 3/3] drm/i915/selftests: avoid bogus maybe-uninitialized warning

2020-05-27 Thread Chris Wilson
Quoting Arnd Bergmann (2020-05-27 15:05:10) > gcc has a problem following values through IS_ERR/PTR_ERR macros, > leading to a false-positive warning in allmodconfig, with any > compiler version: > > In file included from drivers/gpu/drm/i915/gt/intel_lrc.c:5892: > drivers/gpu/drm/i915/gt/selftest

Re: [PATCH] drm: pl111: add CONFIG_VEXPRESS_CONFIG dependency

2020-05-27 Thread Arnd Bergmann
On Wed, May 27, 2020 at 4:52 PM Sam Ravnborg wrote: > > Hi Arnd. > > On Wed, May 27, 2020 at 03:31:42PM +0200, Arnd Bergmann wrote: > > The vexpress_config code fails to link in some configurations: > > > > drivers/gpu/drm/pl111/pl111_versatile.o: in function `pl111_versatile_init': > > (.text+0x1

Re: [PATCH 2/3] drm/i915: work around false-positive maybe-uninitialized warning

2020-05-27 Thread Chris Wilson
Quoting Arnd Bergmann (2020-05-27 15:05:09) > gcc-9 gets confused by the code flow in check_dirty_whitelist: > > drivers/gpu/drm/i915/gt/selftest_workarounds.c: In function > 'check_dirty_whitelist': > drivers/gpu/drm/i915/gt/selftest_workarounds.c:492:17: error: 'rsvd' may be > used uninitializ

Re: [PATCH 2/2] drm/atomic-helper: reset vblank on crtc reset

2020-05-27 Thread Daniel Vetter
On Wed, May 27, 2020 at 11:48 AM Daniel Vetter wrote: > > Only when vblanks are supported ofc. > > Some drivers do this already, but most unfortunately missed it. This > opens up bugs after driver load, before the crtc is enabled for the > first time. syzbot spotted this when loading vkms as a sec

Re: [PATCH 1/3] drm/i915/pmu: avoid an maybe-uninitialized warning

2020-05-27 Thread Chris Wilson
Quoting Arnd Bergmann (2020-05-27 15:05:08) > Conditional spinlocks make it hard for gcc and for lockdep to > follow the code flow. This one causes a warning with at least > gcc-9 and higher: > > In file included from include/linux/irq.h:14, > from drivers/gpu/drm/i915/i915_pmu.c:

Re: [Freedreno] [PATCH 5/6] drm: msm: a6xx: use dev_pm_opp_set_bw to set DDR bandwidth

2020-05-27 Thread Rob Clark
On Wed, May 27, 2020 at 1:47 AM Sharat Masetty wrote: > > + more folks > > On 5/18/2020 9:55 PM, Rob Clark wrote: > > On Mon, May 18, 2020 at 7:23 AM Jordan Crouse > > wrote: > >> On Thu, May 14, 2020 at 04:24:18PM +0530, Sharat Masetty wrote: > >>> This patches replaces the previously used stat

[Bug 207901] Nouveau: In a 4 monitor setup, 1-2 displays remains black after boot

2020-05-27 Thread bugzilla-daemon
https://bugzilla.kernel.org/show_bug.cgi?id=207901 --- Comment #9 from Maurice Gale (mauricega...@gmail.com) --- Created attachment 289349 --> https://bugzilla.kernel.org/attachment.cgi?id=289349&action=edit Log for 5.7 -- You are receiving this mail because: You are watching the assignee of t

[Bug 207901] Nouveau: In a 4 monitor setup, 1-2 displays remains black after boot

2020-05-27 Thread bugzilla-daemon
https://bugzilla.kernel.org/show_bug.cgi?id=207901 --- Comment #8 from Maurice Gale (mauricega...@gmail.com) --- Created attachment 289347 --> https://bugzilla.kernel.org/attachment.cgi?id=289347&action=edit Log for 5.6 -- You are receiving this mail because: You are watching the assignee of t

[Bug 207901] Nouveau: In a 4 monitor setup, 1-2 displays remains black after boot

2020-05-27 Thread bugzilla-daemon
https://bugzilla.kernel.org/show_bug.cgi?id=207901 --- Comment #7 from Maurice Gale (mauricega...@gmail.com) --- Interestingly, after installing both 5.6 and 5.7-rc, I get no displays at all when connected to my Nvidia p2000. However, when I use integrated graphics, I get both of the displays. I

Re: [PATCH v4.19.x] make 'user_access_begin()' do 'access_ok()'

2020-05-27 Thread Greg KH
On Wed, May 13, 2020 at 05:08:19PM +, Ashwin H wrote: > > Ok, but what does that mean for us? > > > > You need to say why you are sending a patch, otherwise we will guess wrong. > > In drivers/gpu/drm/i915/i915_gem_execbuffer.c, ioctl functions does > user_access_begin() without doing access

Re: [PATCH] drm/doc: device hot-unplug for userspace

2020-05-27 Thread Andrey Grodzovsky
On 5/27/20 10:39 AM, Daniel Vetter wrote: On Wed, May 27, 2020 at 3:51 PM Andrey Grodzovsky wrote: On 5/27/20 2:44 AM, Pekka Paalanen wrote: On Tue, 26 May 2020 10:30:20 -0400 Andrey Grodzovsky wrote: On 5/19/20 6:06 AM, Pekka Paalanen wrote: From: Pekka Paalanen Set up the expectation

Re: [PATCH] drm: pl111: add CONFIG_VEXPRESS_CONFIG dependency

2020-05-27 Thread Sam Ravnborg
Hi Arnd. On Wed, May 27, 2020 at 03:31:42PM +0200, Arnd Bergmann wrote: > The vexpress_config code fails to link in some configurations: > > drivers/gpu/drm/pl111/pl111_versatile.o: in function `pl111_versatile_init': > (.text+0x1f0): undefined reference to `devm_regmap_init_vexpress_config' > >

Re: [PATCH] drm/doc: device hot-unplug for userspace

2020-05-27 Thread Daniel Vetter
On Wed, May 27, 2020 at 3:51 PM Andrey Grodzovsky wrote: > > > On 5/27/20 2:44 AM, Pekka Paalanen wrote: > > On Tue, 26 May 2020 10:30:20 -0400 > > Andrey Grodzovsky wrote: > > > >> On 5/19/20 6:06 AM, Pekka Paalanen wrote: > >>> From: Pekka Paalanen > >>> > >>> Set up the expectations on how ho

Re: [Nouveau] [PATCH] nouveau: add fbdev dependency

2020-05-27 Thread Arnd Bergmann
On Wed, May 27, 2020 at 4:05 PM Ilia Mirkin wrote: > > Isn't this already fixed by > > https://cgit.freedesktop.org/drm/drm/commit/?id=7dbbdd37f2ae7dd4175ba3f86f4335c463b18403 Ok, I see that fixes the link error, but I when I created my fix, that did not seem like the correct solution because it

Re: [PATCH] drm/atomic-helper: reset vblank on crtc reset

2020-05-27 Thread Daniel Vetter
On Wed, May 27, 2020 at 2:08 PM Liviu Dudau wrote: > > On Wed, May 27, 2020 at 01:07:05PM +0200, Daniel Vetter wrote: > > On Wed, May 27, 2020 at 12:57 PM Liviu Dudau wrote: > > > > > > Hi Daniel, > > > > > > On Wed, May 27, 2020 at 11:53:32AM +0200, Daniel Vetter wrote: > > > > Only when vblanks

[PATCH 2/3] drm/i915: work around false-positive maybe-uninitialized warning

2020-05-27 Thread Arnd Bergmann
gcc-9 gets confused by the code flow in check_dirty_whitelist: drivers/gpu/drm/i915/gt/selftest_workarounds.c: In function 'check_dirty_whitelist': drivers/gpu/drm/i915/gt/selftest_workarounds.c:492:17: error: 'rsvd' may be used uninitialized in this function [-Werror=maybe-uninitialized] I cou

[PATCH 3/3] drm/i915/selftests: avoid bogus maybe-uninitialized warning

2020-05-27 Thread Arnd Bergmann
gcc has a problem following values through IS_ERR/PTR_ERR macros, leading to a false-positive warning in allmodconfig, with any compiler version: In file included from drivers/gpu/drm/i915/gt/intel_lrc.c:5892: drivers/gpu/drm/i915/gt/selftest_lrc.c: In function 'create_gpr_client.isra.0': drivers/

[PATCH 1/3] drm/i915/pmu: avoid an maybe-uninitialized warning

2020-05-27 Thread Arnd Bergmann
Conditional spinlocks make it hard for gcc and for lockdep to follow the code flow. This one causes a warning with at least gcc-9 and higher: In file included from include/linux/irq.h:14, from drivers/gpu/drm/i915/i915_pmu.c:7: drivers/gpu/drm/i915/i915_pmu.c: In function 'i915_sa

Re: [Nouveau] [PATCH] nouveau: add fbdev dependency

2020-05-27 Thread Ilia Mirkin
Isn't this already fixed by https://cgit.freedesktop.org/drm/drm/commit/?id=7dbbdd37f2ae7dd4175ba3f86f4335c463b18403 On Wed, May 27, 2020 at 9:43 AM Arnd Bergmann wrote: > > Calling directly into the fbdev stack only works when the > fbdev layer is built into the kernel as well, or both are > lo

Re: [PATCH] drm/doc: device hot-unplug for userspace

2020-05-27 Thread Andrey Grodzovsky
On 5/27/20 2:44 AM, Pekka Paalanen wrote: On Tue, 26 May 2020 10:30:20 -0400 Andrey Grodzovsky wrote: On 5/19/20 6:06 AM, Pekka Paalanen wrote: From: Pekka Paalanen Set up the expectations on how hot-unplugging a DRM device should look like to userspace. Written by Daniel Vetter's reques

[PATCH] nouveau: add fbdev dependency

2020-05-27 Thread Arnd Bergmann
Calling directly into the fbdev stack only works when the fbdev layer is built into the kernel as well, or both are loadable modules: drivers/gpu/drm/nouveau/nouveau_drm.o: in function `nouveau_drm_probe': nouveau_drm.c:(.text+0x1f90): undefined reference to `remove_conflicting_pci_framebuffers'

Re: [PATCH] drm: pl111: add CONFIG_VEXPRESS_CONFIG dependency

2020-05-27 Thread Linus Walleij
On Wed, May 27, 2020 at 3:32 PM Arnd Bergmann wrote: > The vexpress_config code fails to link in some configurations: > > drivers/gpu/drm/pl111/pl111_versatile.o: in function `pl111_versatile_init': > (.text+0x1f0): undefined reference to `devm_regmap_init_vexpress_config' > > Add a dependency tha

[PATCH] drm: pl111: add CONFIG_VEXPRESS_CONFIG dependency

2020-05-27 Thread Arnd Bergmann
The vexpress_config code fails to link in some configurations: drivers/gpu/drm/pl111/pl111_versatile.o: in function `pl111_versatile_init': (.text+0x1f0): undefined reference to `devm_regmap_init_vexpress_config' Add a dependency that links to this only if the dependency is there, and prevent the

[PATCH 2/3] drm/edid: Iterate through all DispID ext blocks

2020-05-27 Thread Ville Syrjala
From: Ville Syrjälä Apparently there are EDIDs in the wild with multiple DispID extension blocks. Iterate through them all. In one particular case the tile information is specicied in the second DispID ext block, and since the current parser only looks at the first DispID ext block we don't noti

[PATCH 3/3] drm/edid: Clean up some curly braces

2020-05-27 Thread Ville Syrjala
From: Ville Syrjälä Drop some pointless curly braces, and add some across the else when the if has them too. Signed-off-by: Ville Syrjälä --- drivers/gpu/drm/drm_edid.c | 9 - 1 file changed, 4 insertions(+), 5 deletions(-) diff --git a/drivers/gpu/drm/drm_edid.c b/drivers/gpu/drm/drm

[PATCH 1/3] drm/edid: Allow looking for ext blocks starting from a specified index

2020-05-27 Thread Ville Syrjala
From: Ville Syrjälä Apparently EDIDs with multiple DispID ext blocks is a thing, so prepare for iterating through multiple ext blocks of the same type by passing the starting ext block index to drm_find_edid_extension(). Well also have drm_find_edid_extension() update the index to point to the ne

Re: [PATCH] drm/atomic-helper: reset vblank on crtc reset

2020-05-27 Thread Liviu Dudau
On Wed, May 27, 2020 at 01:07:05PM +0200, Daniel Vetter wrote: > On Wed, May 27, 2020 at 12:57 PM Liviu Dudau wrote: > > > > Hi Daniel, > > > > On Wed, May 27, 2020 at 11:53:32AM +0200, Daniel Vetter wrote: > > > Only when vblanks are supported ofc. > > > > > > Some drivers do this already, but mo

Re: [PATCH] drm: use drm_dev_has_vblank more

2020-05-27 Thread Thomas Zimmermann
Am 27.05.20 um 13:11 schrieb Daniel Vetter: > For historical reasons it's called dev->num_crtcs, which is rather > confusing ever since kms was added. But now we have a nice helper, so > let's use it for better readability! > > Only code change is in atomic helpers: vblank support means that > de

Re: [PATCH v6 8/9] spi: stm32: Add 'SPI_SIMPLEX_RX', 'SPI_3WIRE_RX' support for stm32f4

2020-05-27 Thread Mark Brown
On Wed, May 27, 2020 at 06:45:53PM +0800, dillon min wrote: > sorry, forget to remove these two patch from this submits, will not > include it in later submits > which ack other's review result. Ah, OK - no problem. signature.asc Description: PGP signature __

[PATCH] drm: use drm_dev_has_vblank more

2020-05-27 Thread Daniel Vetter
For historical reasons it's called dev->num_crtcs, which is rather confusing ever since kms was added. But now we have a nice helper, so let's use it for better readability! Only code change is in atomic helpers: vblank support means that dev->irq_enabled must be set too. Another one of these quir

Re: [PATCH] drm/atomic-helper: reset vblank on crtc reset

2020-05-27 Thread Daniel Vetter
On Wed, May 27, 2020 at 12:57 PM Liviu Dudau wrote: > > Hi Daniel, > > On Wed, May 27, 2020 at 11:53:32AM +0200, Daniel Vetter wrote: > > Only when vblanks are supported ofc. > > > > Some drivers do this already, but most unfortunately missed it. This > > opens up bugs after driver load, before th

Re: [PATCH] drm/atomic-helper: reset vblank on crtc reset

2020-05-27 Thread Liviu Dudau
Hi Daniel, On Wed, May 27, 2020 at 11:53:32AM +0200, Daniel Vetter wrote: > Only when vblanks are supported ofc. > > Some drivers do this already, but most unfortunately missed it. This > opens up bugs after driver load, before the crtc is enabled for the > first time. syzbot spotted this when lo

Re: [PATCH] drm/atomic-helper: reset vblank on crtc reset

2020-05-27 Thread Thierry Reding
On Wed, May 27, 2020 at 11:53:32AM +0200, Daniel Vetter wrote: > Only when vblanks are supported ofc. > > Some drivers do this already, but most unfortunately missed it. This > opens up bugs after driver load, before the crtc is enabled for the > first time. syzbot spotted this when loading vkms a

[PATCH] drm/atomic-helper: reset vblank on crtc reset

2020-05-27 Thread Daniel Vetter
Only when vblanks are supported ofc. Some drivers do this already, but most unfortunately missed it. This opens up bugs after driver load, before the crtc is enabled for the first time. syzbot spotted this when loading vkms as a secondary output. Given how many drivers are buggy it's best to solve

Re: [PATCH v6 8/9] spi: stm32: Add 'SPI_SIMPLEX_RX', 'SPI_3WIRE_RX' support for stm32f4

2020-05-27 Thread Mark Brown
On Wed, May 27, 2020 at 03:27:32PM +0800, dillon.min...@gmail.com wrote: > From: dillon min > > in l3gd20 driver startup, there is a setup failed error return from > stm32 spi driver Please do not submit new versions of already applied patches, please submit incremental updates to the existing c

[PATCH 1/2] drm/mxsfb: Call drm_crtc_vblank_on/off

2020-05-27 Thread Daniel Vetter
mxsfb has vblank support, is atomic, but doesn't call drm_crtc_vblank_on/off as it should. Not good. With my next patch to add the drm_crtc_vblank_reset to helpers this means not even the very first crtc enabling will vblanks work anymore, since they'll just stay off forever. Since mxsfb doesn't

[PATCH 2/2] drm/atomic-helper: reset vblank on crtc reset

2020-05-27 Thread Daniel Vetter
Only when vblanks are supported ofc. Some drivers do this already, but most unfortunately missed it. This opens up bugs after driver load, before the crtc is enabled for the first time. syzbot spotted this when loading vkms as a secondary output. Given how many drivers are buggy it's best to solve

Re: [PATCH v2 00/91] drm/vc4: Support BCM2711 Display Pipelin

2020-05-27 Thread Daniel Drake
On Wed, May 27, 2020 at 5:13 PM Maxime Ripard wrote: > I'm about to send a v3 today or tomorrow, I can Cc you (and Jian-Hong) if you > want. That would be great, although given the potentially inconsistent results we've been seeing so far it would be great if you could additionally push a git bra

Re: [PATCH] drm/fourcc: document modifier uniqueness requirements

2020-05-27 Thread Daniel Vetter
On Wed, May 27, 2020 at 08:52:00AM +, Simon Ser wrote: > There have suggestions to bake pitch alignment, address alignement, > contiguous memory or other placement (hidden VRAM, GTT/BAR, etc) > constraints into modifiers. Last time this was brought up it seemed > like the consensus was to not a

Re: [PATCH] drm/radeon: Convert get_user_pages() --> pin_user_pages()

2020-05-27 Thread Daniel Vetter
On Wed, May 27, 2020 at 10:48:52AM +0200, Daniel Vetter wrote: > On Tue, May 26, 2020 at 03:57:45PM -0700, John Hubbard wrote: > > On 2020-05-26 14:00, Souptick Joarder wrote: > > > This code was using get_user_pages(), in a "Case 2" scenario > > > (DMA/RDMA), using the categorization from [1]. Tha

[PATCH] drm/fourcc: document modifier uniqueness requirements

2020-05-27 Thread Simon Ser
There have suggestions to bake pitch alignment, address alignement, contiguous memory or other placement (hidden VRAM, GTT/BAR, etc) constraints into modifiers. Last time this was brought up it seemed like the consensus was to not allow this. Document this in drm_fourcc.h. There are several reason

Re: [PATCH] drm/radeon: Convert get_user_pages() --> pin_user_pages()

2020-05-27 Thread Daniel Vetter
On Tue, May 26, 2020 at 03:57:45PM -0700, John Hubbard wrote: > On 2020-05-26 14:00, Souptick Joarder wrote: > > This code was using get_user_pages(), in a "Case 2" scenario > > (DMA/RDMA), using the categorization from [1]. That means that it's > > time to convert the get_user_pages() + release_pa

Re: [Freedreno] [PATCH 5/6] drm: msm: a6xx: use dev_pm_opp_set_bw to set DDR bandwidth

2020-05-27 Thread Sharat Masetty
+ more folks On 5/18/2020 9:55 PM, Rob Clark wrote: On Mon, May 18, 2020 at 7:23 AM Jordan Crouse wrote: On Thu, May 14, 2020 at 04:24:18PM +0530, Sharat Masetty wrote: This patches replaces the previously used static DDR vote and uses dev_pm_opp_set_bw() to scale GPU->DDR bandwidth along wit

Re: [PATCH v6 5/9] clk: stm32: Fix stm32f429's ltdc driver hang in set clock rate

2020-05-27 Thread Stephen Boyd
Quoting dillon.min...@gmail.com (2020-05-27 00:27:29) > From: dillon min > > This is due to misuse \u2018PLL_VCO_SAI' and'PLL_SAI' in clk-stm32f4.c > 'PLL_SAI' is 2, 'PLL_VCO_SAI' is 7(defined in > include/dt-bindings/clock/stm32fx-clock.h). > > 'post_div' point to 'post_div_data[]', 'post_div->

Re: [PATCH v6 6/9] clk: stm32: Fix ltdc's clock turn off by clk_disable_unused() after kernel startup

2020-05-27 Thread Stephen Boyd
Quoting dillon.min...@gmail.com (2020-05-27 00:27:30) > From: dillon min > > stm32's clk driver register two ltdc gate clk to clk core by > clk_hw_register_gate() and clk_hw_register_composite() > > first: 'stm32f429_gates[]', clk name is 'ltdc', which no user to use. > second: 'stm32f429_aux_cl

Re: [PATCH] drm/vkms: Don't warn hrtimer_forward_now failure.

2020-05-27 Thread Daniel Vetter
On Tue, May 26, 2020 at 01:11:28PM +0200, Daniel Vetter wrote: > On Tue, May 26, 2020 at 6:39 AM Tetsuo Handa > wrote: > > > > On 2020/05/26 13:18, Tetsuo Handa wrote: > > > due to mode->crtc_clock <= 0. Thus, somehow initializing mode->crtc_clock > > > > 0 might be able > > > to solve this probl

[PULL] drm-misc-next-fixes

2020-05-27 Thread Thomas Zimmermann
Hi Dave and Daniel, here's the pull request for the current drm-misc-next-fixes. Best regards Thomas drm-misc-next-fixes-2020-05-27: Short summary of fixes pull (less than what git shortlog provides): There's a fix for panel brighness on Lenovo X13 Yoga devices and a fix for -Wformat warnings o

Re: [PATCH v5 0/8] drm: rcar-du: Add Color Management Module (CMM)

2020-05-27 Thread Geert Uytterhoeven
Hi Eugeniu, On Wed, May 27, 2020 at 9:16 AM Eugeniu Rosca wrote: > On Tue, Oct 15, 2019 at 12:46:13PM +0200, Jacopo Mondi wrote: > > CMM functionalities are retained between suspend/resume cycles (tested with > > suspend-to-idle) without requiring a re-programming of the LUT tables. > > Hmm. Is t

[PATCH v4 2/3] virtio-gpu: add VIRTIO_GPU_F_RESOURCE_UUID feature

2020-05-27 Thread David Stevens
This feature allows the guest to request a UUID from the host for a particular virtio_gpu resource. The UUID can then be shared with other virtio devices, to allow the other host devices to access the virtio_gpu's corresponding host resource. Signed-off-by: David Stevens --- include/uapi/linux/v

Re: [PATCH v2] tee: convert get_user_pages() --> pin_user_pages()

2020-05-27 Thread Jens Wiklander
Hi John, On Tue, May 26, 2020 at 1:32 AM John Hubbard wrote: > > This code was using get_user_pages*(), in a "Case 2" scenario > (DMA/RDMA), using the categorization from [1]. That means that it's > time to convert the get_user_pages*() + put_page() calls to > pin_user_pages*() + unpin_user_pages

[PATCH v4 1/3] virtio: add dma-buf support for exported objects

2020-05-27 Thread David Stevens
This change adds a new flavor of dma-bufs that can be used by virtio drivers to share exported objects. A virtio dma-buf can be queried by virtio drivers to obtain the UUID which identifies the underlying exported object. Signed-off-by: David Stevens --- drivers/virtio/Makefile | 2 +-

Re: [PATCH 09/21] drm/ingenic: Use GEM CMA object functions

2020-05-27 Thread Paul Cercueil
Hi Thomas, Le ven. 22 mai 2020 à 15:52, Thomas Zimmermann a écrit : The ingenic driver uses the default implementation for CMA functions. The DRM_GEM_CMA_DRIVER_OPS macro now sets these defaults in struct drm_driver. All remaining operations are provided by CMA GEM object functions. Signed-

Re: [PATCH v5 5/8] clk: stm32: Fix stm32f429's ltdc driver hang in set clock rate, fix duplicated ltdc clock register to 'clk_core' case ltdc's clock turn off by clk_disable_unused()

2020-05-27 Thread dillon min
Hi Stephen, Thanks for reviewing. On Wed, May 27, 2020 at 9:44 AM Stephen Boyd wrote: > > Quoting dillon.min...@gmail.com (2020-05-24 20:45:45) > > From: dillon min > > > > ltdc set clock rate crashed > >'post_div_data[]''s pll_num is PLL_I2S, PLL_SAI (number is 1,2). but, > > Please write

[PATCH v4 3/3] drm/virtio: Support virtgpu exported resources

2020-05-27 Thread David Stevens
Add support for UUID-based resource sharing mechanism to virtgpu. This implements the new virtgpu commands and hooks them up to dma-buf's get_uuid callback. Signed-off-by: David Stevens --- drivers/gpu/drm/virtio/virtgpu_drv.c | 3 + drivers/gpu/drm/virtio/virtgpu_drv.h | 20 ++ drivers

  1   2   >