Re: [PATCH v2] drm/i915/hdcp: Add additional R0' wait

On 2020-05-20 at 15:50:15 -0400, Sean Paul wrote: > On Wed, May 20, 2020 at 9:08 AM Sean Paul wrote: > > > > From: Sean Paul > > > > We're seeing some R0' mismatches in the field, particularly with > > repeaters. I'm guessing the (already lenient) 300ms wait time isn't > > enough for some setups.

Re: [PATCH] drm/i915/hdcp: Avoid duplicate HDCP enables

On 2020-05-20 at 15:47:44 -0400, Sean Paul wrote: > From: Sean Paul > > If userspace sets the CP property to DESIRED while it's already ENABLED, > the driver will try to re-enable HDCP. On some displays, this will > result in R0' mismatches. I'm guessing this is because the display is > still sen

[GIT PULL v3] mediatek drm next for 5.8

Hi, Dave & Daniel: This include dpi pin mode swap, config mipi_tx current and impedance, and some fixup. I drop backmerge patches and related fixup in this version. The following changes since commit 8f3d9f354286745c751374f5f1fcafee6b3f3136: Linux 5.7-rc1 (2020-04-12 12:35:55 -0700) are avail

Re: [PATCH v5 1/2] drm/ioctl: Add a ioctl to set and get a label on GEM objects

On Thu, 21 May 2020 at 01:07, Rohan Garg wrote: > > Hey Emil > I've applied all the suggestions except the ones I discuss below. > > > > > As a high-level question: how does this compare to VC4_LABEL_BO? > > Is it possible to implement to replace or partially implement the vc4 > > one with this in

Re: [PATCH v5 1/2] drm/ioctl: Add a ioctl to set and get a label on GEM objects

Hey Emil I've applied all the suggestions except the ones I discuss below. > > As a high-level question: how does this compare to VC4_LABEL_BO? > Is it possible to implement to replace or partially implement the vc4 > one with this infra? > > IMHO this is something to aim for. > Yep, the inten

Re: [PATCH] drm/exynos: Fix dma_parms allocation

Hi Marek, I love your patch! Perhaps something to improve: [auto build test WARNING on drm-exynos/exynos-drm-next] [also build test WARNING on drm-intel/for-linux-next tegra-drm/drm/tegra/for-next v5.7-rc6 next-20200519] [cannot apply to drm/drm-next] [if your patch is applied to the wrong git t

Re: [PATCH 2/2] drm/amd/display: Enable fp16 also on DCE-11.0 - DCE-12.

On Wed, May 20, 2020 at 9:07 PM Kazlauskas, Nicholas < nicholas.kazlaus...@amd.com> wrote: > On 2020-05-20 2:44 p.m., Mario Kleiner wrote: > > On Wed, May 20, 2020 at 8:25 PM Alex Deucher > > wrote: > > > > On Wed, May 20, 2020 at 12:39 PM Harry Wentland > <

Re: [PATCH v2] drm/i915/hdcp: Add additional R0' wait

On Wed, May 20, 2020 at 9:08 AM Sean Paul wrote: > > From: Sean Paul > > We're seeing some R0' mismatches in the field, particularly with > repeaters. I'm guessing the (already lenient) 300ms wait time isn't > enough for some setups. So add an additional wait when R0' is > mismatched. > I think

[PATCH] drm/i915/hdcp: Avoid duplicate HDCP enables

From: Sean Paul If userspace sets the CP property to DESIRED while it's already ENABLED, the driver will try to re-enable HDCP. On some displays, this will result in R0' mismatches. I'm guessing this is because the display is still sending back Ri instead of re-authenticating. At any rate, we ca

Re: [PATCH] drm/amd/amdkfd: Fix large framesize for kfd_smi_ev_read()

Am 2020-05-20 um 9:53 a.m. schrieb Aurabindo Pillai: > The buffer allocated is of 1024 bytes. Allocate this from > heap instead of stack. > > Also remove check for stack size since we're allocating from heap > > Signed-off-by: Aurabindo Pillai > Tested-by: Amber Lin See one comment inline. With

Re: [PATCH 2/2] drm/amd/display: Enable fp16 also on DCE-11.0 - DCE-12.

On 2020-05-20 2:44 p.m., Mario Kleiner wrote: On Wed, May 20, 2020 at 8:25 PM Alex Deucher > wrote: On Wed, May 20, 2020 at 12:39 PM Harry Wentland mailto:hwent...@amd.com>> wrote: > > On 2020-05-15 1:19 a.m., Mario Kleiner wrote: > > Testing on a

Re: [PATCH 2/2] drm/amd/display: Enable fp16 also on DCE-11.0 - DCE-12.

On Wed, May 20, 2020 at 8:25 PM Alex Deucher wrote: > On Wed, May 20, 2020 at 12:39 PM Harry Wentland wrote: > > > > On 2020-05-15 1:19 a.m., Mario Kleiner wrote: > > > Testing on a Polaris11 gpu with DCE-11.2 suggests that it > > > seems to work fine there, so optimistically enable it for > > >

Re: [PATCH v3] drm/amdgpu: off by one in amdgpu_device_attr_create_groups() error handling

Applied. Thanks! Alex On Wed, May 20, 2020 at 11:33 AM Christian König wrote: > Am 20.05.20 um 17:31 schrieb Ruhl, Michael J: > >> -Original Message- > >> From: Dan Carpenter > >> Sent: Wednesday, May 20, 2020 11:26 AM > >> To: Alex Deucher ; Kevin Wang > >> ; Ruhl, Michael J > >> Cc

Re: [PATCH 2/2] drm/amd/display: Enable fp16 also on DCE-11.0 - DCE-12.

On Wed, May 20, 2020 at 12:39 PM Harry Wentland wrote: > > On 2020-05-15 1:19 a.m., Mario Kleiner wrote: > > Testing on a Polaris11 gpu with DCE-11.2 suggests that it > > seems to work fine there, so optimistically enable it for > > DCE-11 and later. > > > > Signed-off-by: Mario Kleiner > > --- >

Re: [PATCH] drm/amd/amdkfd: Fix large framesize for kfd_smi_ev_read()

On Wed, May 20, 2020 at 9:53 AM Aurabindo Pillai wrote: > > The buffer allocated is of 1024 bytes. Allocate this from > heap instead of stack. > > Also remove check for stack size since we're allocating from heap > > Signed-off-by: Aurabindo Pillai > Tested-by: Amber Lin Reviewed-by: Alex Deuch

Re: [PATCH] drm/amdgpu/smu10: Replace one-element array and use struct_size() helper

Applied. thanks! Alex On Wed, May 20, 2020 at 3:42 AM Christian König wrote: > > Am 20.05.20 um 00:55 schrieb Gustavo A. R. Silva: > > The current codebase makes use of one-element arrays in the following > > form: > > > > struct something { > > int length; > > u8 data[1]; > > }; > >

Re: [Intel-gfx] [PATCH 3/3] misc/habalabs: don't set default fence_ops->wait

On Wed, May 20, 2020 at 9:05 PM Daniel Vetter wrote: > > On Thu, May 14, 2020 at 02:38:38PM +0300, Oded Gabbay wrote: > > On Tue, May 12, 2020 at 9:12 AM Daniel Vetter > > wrote: > > > > > > On Tue, May 12, 2020 at 4:14 AM Dave Airlie wrote: > > > > > > > > On Mon, 11 May 2020 at 19:37, Oded Ga

Re: [Intel-gfx] [PATCH 3/3] misc/habalabs: don't set default fence_ops->wait

On Thu, May 14, 2020 at 02:38:38PM +0300, Oded Gabbay wrote: > On Tue, May 12, 2020 at 9:12 AM Daniel Vetter wrote: > > > > On Tue, May 12, 2020 at 4:14 AM Dave Airlie wrote: > > > > > > On Mon, 11 May 2020 at 19:37, Oded Gabbay wrote: > > > > > > > > On Mon, May 11, 2020 at 12:11 PM Daniel Vett

Re: [PATCH 1/3] drm/writeback: don't set fence->ops to default

On Mon, May 11, 2020 at 06:12:32PM +, Ruhl, Michael J wrote: > >-Original Message- > >From: dri-devel On Behalf Of > >Daniel Vetter > >Sent: Monday, May 11, 2020 5:12 AM > >To: LKML > >Cc: David Airlie ; Daniel Vetter ; > >Intel Graphics Development ; DRI > >Development ; Thomas Zimme

[PATCH] drm/shmem-helpers: Simplify dma-buf importing

- Ditch the ->pages array - Make it a private gem bo, which means no shmem object, which means fireworks if anyone calls drm_gem_object_get_pages. But we've just made sure that's all covered. v2: Rebase Acked-by: Thomas Zimmermann Cc: Gerd Hoffmann Cc: Rob Herring Cc: Noralf Trønnes Signe

Re: [PATCH 2/2] drm/mm: improve rb_hole_addr rbtree search

On 5/20/20 6:35 PM, Chris Wilson wrote: Quoting Nirmoy (2020-05-20 17:28:04) Hi Chris, On 5/20/20 12:56 AM, Chris Wilson wrote: Quoting Nirmoy Das (2020-05-19 09:44:36) +#define DRM_MM_ALIGN_SHIFT 6 #define HOLE_SIZE(NODE) ((NODE)->hole_size) #define HOLE_ADDR(NODE) (__drm_mm_hole_nod

Re: [PATCH 2/2] drm/amd/display: Enable fp16 also on DCE-11.0 - DCE-12.

On 2020-05-15 1:19 a.m., Mario Kleiner wrote: > Testing on a Polaris11 gpu with DCE-11.2 suggests that it > seems to work fine there, so optimistically enable it for > DCE-11 and later. > > Signed-off-by: Mario Kleiner > --- > drivers/gpu/drm/amd/display/dc/dce110/dce110_resource.c | 2 +- > dri

Re: [PATCH] drm: Restore the NULL check for drm_gem_object_put()

Quoting Emil Velikov (2020-05-20 15:25:05) > Reviewed-by: Emil Velikov > > I'm half way through checking the callers and I've noticed a handful of bugs. > Will send the series in due time, although your patch is a perfect > intermediate solution. Pushed the compromise patch. That should keep us

Re: [PATCH 2/2] drm/mm: improve rb_hole_addr rbtree search

Quoting Nirmoy (2020-05-20 17:28:04) > Hi Chris, > > On 5/20/20 12:56 AM, Chris Wilson wrote: > > Quoting Nirmoy Das (2020-05-19 09:44:36) > >> +#define DRM_MM_ALIGN_SHIFT 6 > >> #define HOLE_SIZE(NODE) ((NODE)->hole_size) > >> #define HOLE_ADDR(NODE) (__drm_mm_hole_node_start(NODE)) > >> +#de

Re: [PATCH 2/2] drm/mm: improve rb_hole_addr rbtree search

Hi Chris, On 5/20/20 12:56 AM, Chris Wilson wrote: Quoting Nirmoy Das (2020-05-19 09:44:36) +#define DRM_MM_ALIGN_SHIFT 6 #define HOLE_SIZE(NODE) ((NODE)->hole_size) #define HOLE_ADDR(NODE) (__drm_mm_hole_node_start(NODE)) +#define HOLE_SIZE_ALIGN(NODE) ((NODE->hole_size << DRM_MM_ALIGN_SHI

Re: [RFC] Deprecate AGP GART support for Radeon/Nouveau/TTM

On 2020-05-20 4:43 p.m., Christian König wrote: > Am 13.05.20 um 13:03 schrieb Christian König: >> Unfortunately AGP is still to widely used as we could just drop >> support for using its GART. >> >> Not using the AGP GART also doesn't mean a loss in functionality since >> drivers will just fallbac

Re: [RFC] Deprecate AGP GART support for Radeon/Nouveau/TTM

On Wed, May 20, 2020 at 10:43 AM Christian König wrote: > > Am 13.05.20 um 13:03 schrieb Christian König: > > Unfortunately AGP is still to widely used as we could just drop support for > > using its GART. > > > > Not using the AGP GART also doesn't mean a loss in functionality since > > drivers

Re: [RFC PATCH 0/8] Qualcomm Cloud AI 100 driver

On Wed, May 20, 2020 at 08:48:13AM -0600, Jeffrey Hugo wrote: > On 5/20/2020 2:34 AM, Daniel Vetter wrote: > > On Wed, May 20, 2020 at 7:15 AM Greg Kroah-Hartman > > wrote: > > > > > > On Tue, May 19, 2020 at 10:41:15PM +0200, Daniel Vetter wrote: > > > > On Tue, May 19, 2020 at 07:41:20PM +0200,

Re: [RFC PATCH 0/8] Qualcomm Cloud AI 100 driver

On Wed, May 20, 2020 at 08:48:13AM -0600, Jeffrey Hugo wrote: > On 5/20/2020 2:34 AM, Daniel Vetter wrote: > > On Wed, May 20, 2020 at 7:15 AM Greg Kroah-Hartman > > wrote: > > > > > > On Tue, May 19, 2020 at 10:41:15PM +0200, Daniel Vetter wrote: > > > > On Tue, May 19, 2020 at 07:41:20PM +0200,

Re: [PATCH v3] drm/amdgpu: off by one in amdgpu_device_attr_create_groups() error handling

Am 20.05.20 um 17:31 schrieb Ruhl, Michael J: -Original Message- From: Dan Carpenter Sent: Wednesday, May 20, 2020 11:26 AM To: Alex Deucher ; Kevin Wang ; Ruhl, Michael J Cc: Christian König ; David Airlie ; Daniel Vetter ; Evan Quan ; Rui Huang ; Kenneth Feng ; Yintian Tao ; Hawking Z

RE: [PATCH v3] drm/amdgpu: off by one in amdgpu_device_attr_create_groups() error handling

>-Original Message- >From: Dan Carpenter >Sent: Wednesday, May 20, 2020 11:26 AM >To: Alex Deucher ; Kevin Wang >; Ruhl, Michael J >Cc: Christian König ; David Airlie >; Daniel Vetter ; Evan Quan >; Rui Huang ; Kenneth Feng >; Yintian Tao ; Hawking Zhang >; amd-...@lists.freedesktop.org;

[PATCH v3] drm/amdgpu: off by one in amdgpu_device_attr_create_groups() error handling

This loop in the error handling code should start a "i - 1" and end at "i == 0". Currently it starts a "i" and ends at "i == 1". The result is that it removes one attribute that wasn't created yet, and leaks the zeroeth attribute. Fixes: 4e01847c38f7 ("drm/amdgpu: optimize amdgpu device attribut

RE: [PATCH v2] drm/amdgpu: off by on in amdgpu_device_attr_create_groups() error handling

"off by on" or "off by one" ? M >-Original Message- >From: dri-devel On Behalf Of Dan >Carpenter >Sent: Wednesday, May 20, 2020 9:08 AM >To: Alex Deucher ; Kevin Wang > >Cc: David Airlie ; kernel-janit...@vger.kernel.org; linux- >ker...@vger.kernel.org; amd-...@lists.freedesktop.org;

Re: [PATCH 2/2] drm/amd/display: Enable fp16 also on DCE-11.0 - DCE-12.

On 2020-05-15 1:19 a.m., Mario Kleiner wrote: Testing on a Polaris11 gpu with DCE-11.2 suggests that it seems to work fine there, so optimistically enable it for DCE-11 and later. Signed-off-by: Mario Kleiner Series is: Reviewed-by: Nicholas Kazlauskas Thanks! --- drivers/gpu/drm/amd/d

Re: [PATCH v2 16/16] backlight: use backlight_is_blank() in all backlight drivers

On Wed, May 20, 2020 at 11:56:43AM +0100, Emil Velikov wrote: > Hi Sam, > > On Sun, 17 May 2020 at 20:02, Sam Ravnborg wrote: > > > --- a/drivers/video/backlight/88pm860x_bl.c > > +++ b/drivers/video/backlight/88pm860x_bl.c > > @@ -123,13 +123,7 @@ static int pm860x_backlight_update_status(struc

Re: [PATCH 2/3] drm/etnaviv: Don't ignore errors on getting clocks

On Wed, May 20, 2020 at 04:04:39PM +0200, Lucas Stach wrote: > Am Mittwoch, den 20.05.2020, 15:38 +0200 schrieb Lubomir Rintel: > > Yes. This means that in fact "core" is the only required clock for all > > implementations of vivante,gc and the common binding needs to be updated > > to reflect that

Re: [PATCH] drm/doc: device hot-unplug for userspace

On 5/20/20 8:46 AM, Daniel Vetter wrote: On Wed, May 20, 2020 at 02:19:08PM +0300, Pekka Paalanen wrote: On Tue, 19 May 2020 10:37:12 -0400 Andrey Grodzovsky wrote: Thanks for the summary, does put things in order and makes it easier to comprehend all the TODOs, some questions bellow On 5/1

Re: [RFC] Deprecate AGP GART support for Radeon/Nouveau/TTM

Am 13.05.20 um 13:03 schrieb Christian König: Unfortunately AGP is still to widely used as we could just drop support for using its GART. Not using the AGP GART also doesn't mean a loss in functionality since drivers will just fallback to the driver specific PCI GART. For now just deprecate t

Re: [PATCH] drm: Restore the NULL check for drm_gem_object_put()

On Wed, 20 May 2020 at 15:24, Chris Wilson wrote: > > Some users want to pass NULL to drm_gem_object_put(), but those using > __drm_gem_object_put() did not. Compromise, have both and let the > compiler sort it out. > > drm_gem_fb_destroy() calls drm_gem_object_put() with NULL obj causing: > [ 1

[PATCH] drm: Restore the NULL check for drm_gem_object_put()

Some users want to pass NULL to drm_gem_object_put(), but those using __drm_gem_object_put() did not. Compromise, have both and let the compiler sort it out. drm_gem_fb_destroy() calls drm_gem_object_put() with NULL obj causing: [ 11.584209] BUG: kernel NULL pointer dereference, address: 000

Re: [PATCH] drm/doc: device hot-unplug for userspace

On Wed, May 20, 2020 at 3:20 PM Simon Ser wrote: > > On Wednesday, May 20, 2020 2:55 PM, Daniel Vetter wrote: > > > Maybe we should add an explicit note that there's no guarantee about the > > new chardev minor this new device will get, it could both inherit the > > existing one (you can't open t

Re: [PATCH 2/3] drm/etnaviv: Don't ignore errors on getting clocks

Am Mittwoch, den 20.05.2020, 15:38 +0200 schrieb Lubomir Rintel: > On Thu, May 14, 2020 at 09:53:08AM +0100, Russell King - ARM Linux admin > wrote: > > On Thu, May 14, 2020 at 10:40:58AM +0200, Lucas Stach wrote: > > > Am Donnerstag, den 14.05.2020, 09:27 +0100 schrieb Russell King - ARM > > > L

Re: [PATCH] drm/panfrost: fix runtime pm imbalance on error

On 20/05/2020 12:05, Dinghao Liu wrote: pm_runtime_get_sync() increments the runtime PM usage counter even the call returns an error code. Thus a pairing decrement is needed on the error handling path to keep the counter balanced. Signed-off-by: Dinghao Liu Actually I think we have the opposi

[PATCH] drm/amd/amdkfd: Fix large framesize for kfd_smi_ev_read()

The buffer allocated is of 1024 bytes. Allocate this from heap instead of stack. Also remove check for stack size since we're allocating from heap Signed-off-by: Aurabindo Pillai Tested-by: Amber Lin --- drivers/gpu/drm/amd/amdkfd/kfd_smi_events.c | 26 +++-- 1 file changed, 19

Re: [PATCH v2] drm/amdgpu: off by on in amdgpu_device_attr_create_groups() error handling

[AMD Official Use Only - Internal Distribution Only] thanks. Reviewed-by: Kevin Wang Best Regads, Kevin From: Dan Carpenter Sent: Wednesday, May 20, 2020 9:08 PM To: Deucher, Alexander ; Wang, Kevin(Yang) Cc: Koenig, Christian ; David Airlie ; Daniel Vetter

Re: [PATCH 1/1] drm: check for NULL pointer in drm_gem_object_put

On Wed, 20 May 2020 at 14:30, Emil Velikov wrote: > > On Wed, 20 May 2020 at 14:17, Chris Wilson wrote: > > > > Quoting Christian König (2020-05-20 13:54:55) > > > Am 20.05.20 um 14:49 schrieb Chris Wilson: > > > > Quoting Christian König (2020-05-20 13:19:42) > > > >> Am 20.05.20 um 14:14 schrie

Re: [PATCH 1/1] drm: check for NULL pointer in drm_gem_object_put

On Wed, 20 May 2020 at 14:17, Chris Wilson wrote: > > Quoting Christian König (2020-05-20 13:54:55) > > Am 20.05.20 um 14:49 schrieb Chris Wilson: > > > Quoting Christian König (2020-05-20 13:19:42) > > >> Am 20.05.20 um 14:14 schrieb Nirmoy Das: > > >>> drm_gem_fb_destroy() calls drm_gem_object_p

Re: [PATCH] drm/doc: device hot-unplug for userspace

On Wednesday, May 20, 2020 2:55 PM, Daniel Vetter wrote: > Maybe we should add an explicit note that there's no guarantee about the > new chardev minor this new device will get, it could both inherit the > existing one (you can't open the old one anymore anyway) or get a new one? > > Or does user

Re: [PATCH 1/1] drm: check for NULL pointer in drm_gem_object_put

Quoting Christian König (2020-05-20 13:54:55) > Am 20.05.20 um 14:49 schrieb Chris Wilson: > > Quoting Christian König (2020-05-20 13:19:42) > >> Am 20.05.20 um 14:14 schrieb Nirmoy Das: > >>> drm_gem_fb_destroy() calls drm_gem_object_put() with NULL obj causing: > >>> [ 11.584209] BUG: kernel NU

Re: [PATCH v6 00/16] drm/i915: Add support for HDCP 1.4 over MST connectors

On Mon, May 18, 2020 at 12:41 PM Ramalingam C wrote: > > On 2020-05-18 at 10:32:09 -0400, Sean Paul wrote: > > On Fri, May 15, 2020 at 10:48 AM Ramalingam C > > wrote: > > > > > > On 2020-04-29 at 15:54:46 -0400, Sean Paul wrote: > > > > From: Sean Paul > > > > > > > > Changes in v6: > > > > -R

[PATCH v2] drm/amdgpu: off by on in amdgpu_device_attr_create_groups() error handling

This loop in the error handling code should start a "i - 1" and end at "i == 0". Currently it starts a "i" and ends at "i == 1". The result is that it removes one attribute that wasn't created yet, and leaks the zeroeth attribute. Fixes: 4e01847c38f7 ("drm/amdgpu: optimize amdgpu device attribut

[PATCH v2] drm/i915/hdcp: Add additional R0' wait

From: Sean Paul We're seeing some R0' mismatches in the field, particularly with repeaters. I'm guessing the (already lenient) 300ms wait time isn't enough for some setups. So add an additional wait when R0' is mismatched. Signed-off-by: Sean Paul Changes in v2: - Actually add the delay in R0`

Re: [PATCH 1/1] drm: check for NULL pointer in drm_gem_object_put

Am 20.05.20 um 15:00 schrieb Daniel Vetter: On Wed, May 20, 2020 at 02:54:55PM +0200, Christian König wrote: Am 20.05.20 um 14:49 schrieb Chris Wilson: Quoting Christian König (2020-05-20 13:19:42) Am 20.05.20 um 14:14 schrieb Nirmoy Das: drm_gem_fb_destroy() calls drm_gem_object_put() with N

Re: [PATCH 1/1] drm: check for NULL pointer in drm_gem_object_put

On Wed, May 20, 2020 at 02:54:55PM +0200, Christian König wrote: > Am 20.05.20 um 14:49 schrieb Chris Wilson: > > Quoting Christian König (2020-05-20 13:19:42) > > > Am 20.05.20 um 14:14 schrieb Nirmoy Das: > > > > drm_gem_fb_destroy() calls drm_gem_object_put() with NULL obj causing: > > > > [ 1

Re: [PATCH] drm/doc: device hot-unplug for userspace

On Tue, May 19, 2020 at 01:06:49PM +0300, Pekka Paalanen wrote: > From: Pekka Paalanen > > Set up the expectations on how hot-unplugging a DRM device should look like to > userspace. > > Written by Daniel Vetter's request and largely based on his comments in IRC > and > from https://lists.freed

Re: [PATCH] drm/amdgpu: off by on in amdgpu_device_attr_create_groups() error handling

On Wed, May 20, 2020 at 02:05:19PM +0200, Christian König wrote: > Am 20.05.20 um 14:00 schrieb Dan Carpenter: > > This loop in the error handling code should start a "i - 1" and end at > > "i == 0". Currently it starts a "i" and ends at "i == 1". The result > > is that it removes one attribute t

Re: [PATCH 1/1] drm: check for NULL pointer in drm_gem_object_put

Am 20.05.20 um 14:49 schrieb Chris Wilson: Quoting Christian König (2020-05-20 13:19:42) Am 20.05.20 um 14:14 schrieb Nirmoy Das: drm_gem_fb_destroy() calls drm_gem_object_put() with NULL obj causing: [ 11.584209] BUG: kernel NULL pointer dereference, address: [ 11.584213]

Re: [PATCH 1/1] drm: check for NULL pointer in drm_gem_object_put

Quoting Christian König (2020-05-20 13:19:42) > Am 20.05.20 um 14:14 schrieb Nirmoy Das: > > drm_gem_fb_destroy() calls drm_gem_object_put() with NULL obj causing: > > [ 11.584209] BUG: kernel NULL pointer dereference, address: > > > > [ 11.584213] #PF: supervisor write access

Re: [PATCH] drm/doc: device hot-unplug for userspace

On Wed, May 20, 2020 at 02:19:08PM +0300, Pekka Paalanen wrote: > On Tue, 19 May 2020 10:37:12 -0400 > Andrey Grodzovsky wrote: > > > Thanks for the summary, does put things in order and makes it easier to > > comprehend all the TODOs, some questions bellow > > > > On 5/19/20 6:06 AM, Pekka Paa

Re: [PATCH 2/2] drm: add docs for standard CRTC properties

On Mon, May 18, 2020 at 02:22:47PM +, Simon Ser wrote: > This patch adds docs for the ACTIVE and MODE_ID CRTC properties. > > Signed-off-by: Simon Ser > Cc: Daniel Vetter > Cc: Ville Syrjala > Cc: Pekka Paalanen > Cc: Michel Dänzer > --- > > Let me know if you think of other things to ad

Re: [PATCH] ASoC: fsl: imx-pcm-dma: Don't request dma channel in probe

On Wed, May 20, 2020 at 07:22:19PM +0800, Shengjiu Wang wrote: > I see some driver also request dma channel in open() or hw_params(). > how can they avoid the defer probe issue? > for example： > sound/arm/pxa2xx-pcm-lib.c > sound/soc/sprd/sprd-pcm-dma.c Other drivers having problems means those d

Re: [PATCH 1/2] drm: DPMS is no longer the only mutable connector prop

On Mon, May 18, 2020 at 02:22:28PM +, Simon Ser wrote: > There are a bunch of other writable connector properties now. > > Signed-off-by: Simon Ser > Cc: Daniel Vetter > Cc: Ville Syrjala > Cc: Pekka Paalanen > Cc: Michel Dänzer Reviewed-by: Daniel Vetter I think in general the list of

[PULL] drm-intel-next-fixes

Hi Dave & Daniel, On top of the drm-intel-next PR one fix for TypeC mode resets and two compile time warning fixes. CI results for your viewing: https://intel-gfx-ci.01.org/tree/drm-intel-next-fixes/combined-alt.html CI_DINF_189 = drm-intel-next pull CI_DINF_190 = this pull (3 patches) There i

Re: [PATCH] Lenovo X13 Yoga OLED panel brightness fix

On Mon, May 18, 2020 at 07:13:58PM -0400, Lyude Paul wrote: > ok-actually, I'm not sure dim will actually allow me to push this because this > never hit dri-devel as a properly formatted patch (because of the > -- > -- you put at the top of the branch confusing things) > > Can

Re: [PATCH 1/1] drm: check for NULL pointer in drm_gem_object_put

Am 20.05.20 um 14:14 schrieb Nirmoy Das: drm_gem_fb_destroy() calls drm_gem_object_put() with NULL obj causing: [ 11.584209] BUG: kernel NULL pointer dereference, address: [ 11.584213] #PF: supervisor write access in kernel mode [ 11.584215] #PF: error_code(0x0002) - not-pr

Re: [PATCH] drm/amdgpu: off by on in amdgpu_device_attr_create_groups() error handling

Am 20.05.20 um 14:00 schrieb Dan Carpenter: This loop in the error handling code should start a "i - 1" and end at "i == 0". Currently it starts a "i" and ends at "i == 1". The result is that it removes one attribute that wasn't created yet, and leaks the zeroeth attribute. Fixes: 4e01847c38f7

[PATCH] drm/amdgpu: off by on in amdgpu_device_attr_create_groups() error handling

This loop in the error handling code should start a "i - 1" and end at "i == 0". Currently it starts a "i" and ends at "i == 1". The result is that it removes one attribute that wasn't created yet, and leaks the zeroeth attribute. Fixes: 4e01847c38f7 ("drm/amdgpu: optimize amdgpu device attribut

[PATCH] drm: Replace deprecated function in drm_crtc_helper

Replace deprecated function drm_modeset_lock/unlock_all with helper function DRM_MODESET_LOCK_ALL_BEGIN/END. Signed-off-by: Sidong Yang --- drivers/gpu/drm/drm_crtc_helper.c | 19 --- 1 file changed, 12 insertions(+), 7 deletions(-) diff --git a/drivers/gpu/drm/drm_crtc_helper.c

RE: [EXTERNAL] Re: [RFC PATCH 0/4] DirectX on Linux

Hey guys, Thanks for the discussion. I may not be able to immediately answer all of your questions, but I'll do my best 😊. drivers/hyperv sounds like it could be a better location. We weren't too sure where to put this, we though /drivers/gpu would be appropriate given this deal with GPUs, but

Re: [PATCH] drm/doc: device hot-unplug for userspace

On Tue, 19 May 2020 10:37:12 -0400 Andrey Grodzovsky wrote: > Thanks for the summary, does put things in order and makes it easier to > comprehend all the TODOs, some questions bellow > > On 5/19/20 6:06 AM, Pekka Paalanen wrote: > > From: Pekka Paalanen > > > > Set up the expectations on how

[PATCH] drm/exynos: Fix dma_parms allocation

Since commit 9495b7e92f71 ("driver core: platform: Initialize dma_parms for platform devices") driver core handles allocation of the dma_parms structure for platform device, so there is no need to manually allocate nor free it. Reported-by: Tomi Valkeinen Signed-off-by: Marek Szyprowski --- dri

Re: [EXTERNAL] Re: [RFC PATCH 0/4] DirectX on Linux

Hi Steve, thank you for the fast reply. Am 20.05.20 um 09:42 schrieb Steve Pronovost: >> Echoing what others said, you're not making a DRM driver. The driver should >> live outside of the DRM code. > > Agreed, please see my earlier reply. We'll be moving the driver to > drivers/hyperv node or

Re: [PATCH v2 0/16] backlight updates

Hi Sam, It's a little weird to see this series, just after I mentioned that I had one in the works. Either way, patches 2 and 16 need some work. Although if you prefer that can be done as follow-up. For the rest: Reviewed-by: Emil Velikov -Emil ___ dr

Re: [PATCH] dma-fence: add might_sleep annotation to _wait()

On Wed, May 20, 2020 at 08:54:36AM +0200, Christian König wrote: > Am 19.05.20 um 15:27 schrieb Daniel Vetter: > > Do it uncontionally, there's a separate peek function with > > dma_fence_is_signalled() which can be called from atomic context. > > > > v2: Consensus calls for an unconditional might

Re: [PATCH v2 16/16] backlight: use backlight_is_blank() in all backlight drivers

Hi Sam, On Sun, 17 May 2020 at 20:02, Sam Ravnborg wrote: > --- a/drivers/video/backlight/88pm860x_bl.c > +++ b/drivers/video/backlight/88pm860x_bl.c > @@ -123,13 +123,7 @@ static int pm860x_backlight_update_status(struct > backlight_device *bl) > { > int brightness = bl->props.brightn

Re: [PATCH v1 13/25] dma-buf: Use sequence counter with associated wound/wait mutex

Am 19.05.20 um 23:45 schrieb Ahmed S. Darwish: A sequence counter write side critical section must be protected by some form of locking to serialize writers. If the serialization primitive is not disabling preemption implicitly, preemption has to be explicitly disabled before entering the sequenc

Re: [PATCH v2 03/16] backlight: add backlight_is_blank()

On Sun, 17 May 2020 at 20:02, Sam Ravnborg wrote: > > The backlight support has two properties that express the state: > - power > - state > > It is un-documented and easy to get wrong. > Add backlight_is_blank() helper to make it simpler for drivers > to get the check of the state correct. > > A

Re: [PATCH v2 02/16] backlight: refactor fb_notifier_callback()

Hi Sam, On Sun, 17 May 2020 at 20:02, Sam Ravnborg wrote: > > Increase readability of fb_notifier_callback() by removing > a few indent levels. > No functional change. > > Signed-off-by: Sam Ravnborg > Cc: Lee Jones > Cc: Daniel Thompson > Cc: Jingoo Han > --- > drivers/video/backlight/backl

Re: [PATCH libdrm] libdrm: enclose __FreeBSD__ behind a define

On Tue, 19 May 2020 12:04:58 -0700 Carlos Santa wrote: > Not doing the above can cause compilation errors on > platforms that don't define it. > > [1/25] Compiling C object 'drm@sha/xf86drm.c.o. > FAILED: drm@sha/xf86drm.c.o > ../xf86drm.c: In function 'drmGetMinorNameForFD': > ../xf86drm.c:2938

Re: [PATCH] ASoC: fsl: imx-pcm-dma: Don't request dma channel in probe

Am Mittwoch, den 20.05.2020, 16:20 +0800 schrieb Shengjiu Wang: > Hi > > On Tue, May 19, 2020 at 6:04 PM Lucas Stach wrote: > > Am Dienstag, den 19.05.2020, 17:41 +0800 schrieb Shengjiu Wang: > > > There are two requirements that we need to move the request > > > of dma channel from probe to open

[GIT PULL] etnaviv-fixes for 5.7

Hi Dave, hi Daniel, two fixes: - memory leak fix when userspace passes a invalid softpin address - off-by-one crashing the kernel in the perfmon domain iteration when the GPU core has both 2D and 3D capabilities Regards, Lucas The following changes since commit 8f3d9f354286745c751374f5f1fcafee6b

Re: [RFC PATCH 0/8] Qualcomm Cloud AI 100 driver

On Wed, May 20, 2020 at 7:15 AM Greg Kroah-Hartman wrote: > > On Tue, May 19, 2020 at 10:41:15PM +0200, Daniel Vetter wrote: > > On Tue, May 19, 2020 at 07:41:20PM +0200, Greg Kroah-Hartman wrote: > > > On Tue, May 19, 2020 at 08:57:38AM -0600, Jeffrey Hugo wrote: > > > > On 5/18/2020 11:08 PM, Da

Re: [PATCH] drm/amdgpu/smu10: Replace one-element array and use struct_size() helper

Am 20.05.20 um 00:55 schrieb Gustavo A. R. Silva: The current codebase makes use of one-element arrays in the following form: struct something { int length; u8 data[1]; }; struct something *instance; instance = kmalloc(sizeof(*instance) + size, GFP_KERNEL); instance->length = size; m

Re: [EXTERNAL] Re: [RFC PATCH 0/4] DirectX on Linux

Hi Steve, Sounds all good, some more comments and details below. On Wed, May 20, 2020 at 5:47 AM Steve Pronovost wrote: > Hey guys, > > Thanks for the discussion. I may not be able to immediately answer all of > your questions, but I'll do my best 😊. > > drivers/hyperv sounds like it could be a

[PATCH] ASoC: fsl: imx-pcm-dma: Don't request dma channel in probe

There are two requirements that we need to move the request of dma channel from probe to open. - When dma device binds with power-domains, the power will be enabled when we request dma channel. If the request of dma channel happen on probe, then the power-domains will be always enabled after kerne

[PATCH v2] drm/exynos: Remove dev_err() on platform_get_irq() failure

platform_get_irq() will call dev_err() itself on failure, so there is no need for the driver to also do this. This is detected by coccinelle. Also removing unnecessary curly braces around if () statement. Signed-off-by: Tamseel Shams --- Fixed review comment by j...@perches.com drivers/gpu/drm

[PATCH] drm/tegra: hub: Do not enable orphaned window group

Though the unconditional enable/disable code is not a final solution, we don't want to run into a NULL pointer situation when window group doesn't link to its DC parent if the DC is disabled in Device Tree. So this patch simply adds a check to make sure that window group has a valid parent before

Re: [PATCH] arch/{mips,sparc,microblaze,powerpc}: Don't enable pagefault/preempt twice

On Tue, May 19, 2020 at 11:40:32AM -0700, Ira Weiny wrote: > On Tue, May 19, 2020 at 09:54:22AM -0700, Guenter Roeck wrote: > > On Mon, May 18, 2020 at 11:48:43AM -0700, ira.we...@intel.com wrote: > > > From: Ira Weiny > > > > > > The kunmap_atomic clean up failed to remove one set of pagefault/p

[PATCH] dt-bindings: gpu: arm,mali-utgard: add additional properties

In the old txt situation we add/describe only properties that are used by the driver/hardware itself. With yaml it also filters things in a node that are used by other drivers like 'assigned-clocks' and 'assigned-clock-rates' for some older Rockchip SoCs in 'gpu' nodes, so add them to 'arm,mali-utg

Re: [RFC PATCH 0/8] Qualcomm Cloud AI 100 driver

On Tue 19 May 21:59 PDT 2020, Greg Kroah-Hartman wrote: > On Tue, May 19, 2020 at 10:41:15PM +0200, Daniel Vetter wrote: > > > Ok, that's a decision you are going to have to push upward on, as we > > > really can't take this without a working, open, userspace. > > > > Uh wut. > > > > So the merg

Re: [PATCH] arch/{mips,sparc,microblaze,powerpc}: Don't enable pagefault/preempt twice

On Mon, May 18, 2020 at 11:48:43AM -0700, ira.we...@intel.com wrote: > From: Ira Weiny > > The kunmap_atomic clean up failed to remove one set of pagefault/preempt > enables when vaddr is not in the fixmap. > > Fixes: bee2128a09e6 ("arch/kunmap_atomic: consolidate duplicate code") > Signed-off-b

Re: [PATCH v2] linux/bits.h: adjust GENMASK_INPUT_CHECK() check

+ Andrew et al who recieved mail from the build robot this morning about the same issue. On Tue, May 19, 2020 at 10:14:52PM +0100, Emil Velikov wrote: > Recently the GENMASK_INPUT_CHECK() was added, aiming to catch cases > where there GENMASK arguments are flipped. > > Although it seems to be tri

[PATCH 1/1] serial: stm32: add no_console_suspend support

In order to display console messages in low power mode, console pins must be kept active after suspend call. --- Initial patch "serial: stm32: add support for no_console_suspend" was part of "STM32 usart power improvement" series, but as dependancy to console_suspend pinctl state has been removed

Re: [RFC PATCH 0/8] Qualcomm Cloud AI 100 driver

On Tue, May 19, 2020 at 10:41:15PM +0200, Daniel Vetter wrote: > Get some consistency into your decision making as maintainer. And don't > tell me or anyone else that this is complicated, gpu and rdma driver folks > very much told you and Olof last year that this is what you're getting > yourself

[PATCH 2/2] drm/mm: improve rb_hole_addr rbtree search

Userspace can still abuse alignment while allocating buffer object to slow down rb_hole_addr rbtree search. This patch improves search in fragmented rb_hole_addr rbtree by storing maximum subtree hole alignment and use that to skip a complete subtree if that subtree can not fit a (size + alignment)

[PATCH 1/2] drm/mm: expand rb_hole_addr augmented callbacks

Expand RB_DECLARE_CALLBACKS_MAX so that it is possible to store extra value(max hole alignment) in the rb_hole_addr augmented rbtree. Signed-off-by: Nirmoy Das --- drivers/gpu/drm/drm_mm.c | 72 ++-- 1 file changed, 69 insertions(+), 3 deletions(-) diff --git

[PATCH v1 00/25] seqlock: Extend seqcount API with associated locks

Hi, A sequence counter write side critical section must be protected by some form of locking to serialize writers. If the serialization primitive is not disabling preemption implicitly, preemption has to be explicitly disabled before entering the write side critical section. There is no built-in

[PATCH] drm/mediatek: mtk_mt8173_hdmi_phy: Remove unnused const variables

There are some `static const u8` variables that are not used, this triggers a warning building with `make W=1`, it is safe to remove them, so do it and make the compiler more happy. Signed-off-by: Enric Balletbo i Serra --- .../gpu/drm/mediatek/mtk_mt8173_hdmi_phy.c| 48 ---

[PATCH v1 06/25] dma-buf: Remove custom seqcount lockdep class key

Commit 3c3b177a9369 ("reservation: add support for read-only access using rcu") introduced a sequence counter to manage updates to reservations. Back then, the reservation object initializer reservation_object_init() was always inlined. Having the sequence counter initialization inlined meant that

[PATCH] drm/mediatek: mtk_hdmi: Remove debug messages for function calls

Equivalent information can be nowadays obtained using function tracer Signed-off-by: Enric Balletbo i Serra --- drivers/gpu/drm/mediatek/mtk_hdmi.c| 12 +--- drivers/gpu/drm/mediatek/mtk_mt8173_hdmi_phy.c | 4 2 files changed, 1 insertion(+), 15 deletions(-) diff --gi

  1   2   >