Re: [PATCH] dma-fence: add might_sleep annotation to _wait()

2020-05-19 Thread Christian König
Am 19.05.20 um 15:27 schrieb Daniel Vetter: Do it uncontionally, there's a separate peek function with dma_fence_is_signalled() which can be called from atomic context. v2: Consensus calls for an unconditional might_sleep (Chris, Christian) Full audit: - dma-fence.h: Uses MAX_SCHEDULE_TIMOUT, g

Re: [PATCH] drm/i915/hdcp: Add additional R0' wait

2020-05-19 Thread Ramalingam C
On 2020-05-19 at 18:16:21 -0400, Sean Paul wrote: > From: Sean Paul > > We're seeing some R0' mismatches in the field, particularly with I think you want to say Vprime verification? delay is added in between the retry for vprime verfication. -Ram > repeaters. I'm guessing the (already lenient) 3

Re: [RFC PATCH 1/4] gpu: dxgkrnl: core code

2020-05-19 Thread Greg KH
On Tue, May 19, 2020 at 01:45:53PM -0400, Sasha Levin wrote: > On Tue, May 19, 2020 at 07:21:05PM +0200, Greg KH wrote: > > On Tue, May 19, 2020 at 12:32:31PM -0400, Sasha Levin wrote: > > > + > > > +#define DXGK_MAX_LOCK_DEPTH 64 > > > +#define W_MAX_PATH 260 > > > > We already

Re: [RFC PATCH 0/8] Qualcomm Cloud AI 100 driver

2020-05-19 Thread Greg Kroah-Hartman
On Tue, May 19, 2020 at 10:11:35PM -0700, Bjorn Andersson wrote: > On Tue 19 May 21:59 PDT 2020, Greg Kroah-Hartman wrote: > > > On Tue, May 19, 2020 at 10:41:15PM +0200, Daniel Vetter wrote: > > > > Ok, that's a decision you are going to have to push upward on, as we > > > > really can't take thi

Re: [GIT PULL v2] mediatek drm next for 5.8

2020-05-19 Thread Dave Airlie
On Wed, 20 May 2020 at 15:44, Dave Airlie wrote: > > On Mon, 18 May 2020 at 10:06, Chun-Kuang Hu wrote: > > > > Hi, Dave & Daniel: > > > > This include dpi pin mode swap, config mipi_tx current and impedance, > > and some fixup. I drop drm_bridge patches in this version. > > > > The following cha

Re: [GIT PULL v2] mediatek drm next for 5.8

2020-05-19 Thread Dave Airlie
On Mon, 18 May 2020 at 10:06, Chun-Kuang Hu wrote: > > Hi, Dave & Daniel: > > This include dpi pin mode swap, config mipi_tx current and impedance, > and some fixup. I drop drm_bridge patches in this version. > > The following changes since commit 8f3d9f354286745c751374f5f1fcafee6b3f3136: > Linu

Re: [PATCH v2] drm/exynos: Remove dev_err() on platform_get_irq() failure

2020-05-19 Thread Inki Dae
Hi Tamseel, Same patch[1] has been merged. So could you re-post this patch after rebasing it on top of exynos-drm-next branch? After rebase, only g2d part would be valid. Thanks, Inki Dae [1] https://git.kernel.org/pub/scm/linux/kernel/git/daeinki/drm-exynos.git/commit/?h=exynos-drm-next&id=fd

[GIT PULL] exynos-drm-next

2020-05-19 Thread Inki Dae
Hi Dave, Just several fixups and cleanups. Please kindly let me know if there is any problem. Thanks, Inki Dae The following changes since commit 1493bddcca4d601ca6f3dd27f2226f37a0f39732: Merge tag 'drm-misc-next-2020-05-14' of git://anongit.freedesktop.org/drm/drm-misc into drm-next

Re: [RFC PATCH 0/8] Qualcomm Cloud AI 100 driver

2020-05-19 Thread Greg Kroah-Hartman
On Tue, May 19, 2020 at 10:41:15PM +0200, Daniel Vetter wrote: > On Tue, May 19, 2020 at 07:41:20PM +0200, Greg Kroah-Hartman wrote: > > On Tue, May 19, 2020 at 08:57:38AM -0600, Jeffrey Hugo wrote: > > > On 5/18/2020 11:08 PM, Dave Airlie wrote: > > > > On Fri, 15 May 2020 at 00:12, Jeffrey Hugo

Re: [PATCH] arch/{mips,sparc,microblaze,powerpc}: Don't enable pagefault/preempt twice

2020-05-19 Thread Ira Weiny
On Tue, May 19, 2020 at 12:42:15PM -0700, Guenter Roeck wrote: > On Tue, May 19, 2020 at 11:40:32AM -0700, Ira Weiny wrote: > > On Tue, May 19, 2020 at 09:54:22AM -0700, Guenter Roeck wrote: > > > On Mon, May 18, 2020 at 11:48:43AM -0700, ira.we...@intel.com wrote: > > > > From: Ira Weiny > > > >

Re: [PATCH] arch/{mips,sparc,microblaze,powerpc}: Don't enable pagefault/preempt twice

2020-05-19 Thread Ira Weiny
On Tue, May 19, 2020 at 12:42:15PM -0700, Guenter Roeck wrote: > On Tue, May 19, 2020 at 11:40:32AM -0700, Ira Weiny wrote: > > On Tue, May 19, 2020 at 09:54:22AM -0700, Guenter Roeck wrote: > > > On Mon, May 18, 2020 at 11:48:43AM -0700, ira.we...@intel.com wrote: > > > > From: Ira Weiny > > > >

Re: [RFC PATCH 0/8] Qualcomm Cloud AI 100 driver

2020-05-19 Thread Greg Kroah-Hartman
On Tue, May 19, 2020 at 10:41:15PM +0200, Daniel Vetter wrote: > > Ok, that's a decision you are going to have to push upward on, as we > > really can't take this without a working, open, userspace. > > Uh wut. > > So the merge criteria for drivers/accel (atm still drivers/misc but I > thought th

Re: [PATCH v2 2/4] ARM: dts: ims53: Group port definitions for the dvi-converter

2020-05-19 Thread Shawn Guo
On Thu, May 14, 2020 at 04:36:10PM +0200, Ricardo Cañuelo wrote: > Group the port definitions of the dvi-converter in a 'ports' node to > make it compliant with the ti,tfp410 binding. > > Signed-off-by: Ricardo Cañuelo s/ims53/imx53-cx9020 in subject. I fixed it up and applied the patch. Shawn

Re: [git pull] vmwgfx-fixes-5.7

2020-05-19 Thread Dave Airlie
On Sat, 16 May 2020 at 15:05, Roland Scheidegger (VMware) wrote: > > Dave, Daniel > > Some minor fixes and a maintainer change. > > The following changes since commit 24085f70a6e1b0cb647ec92623284641d8270637: > > Merge tag 'trace-v5.7-rc4' of > git://git.kernel.org/pub/scm/linux/kernel/git/rost

Re: [PATCH] drm/zte: remove unneeded semicolon

2020-05-19 Thread Shawn Guo
On Mon, May 04, 2020 at 07:32:30PM +0800, Jason Yan wrote: > Fix the following coccicheck warning: > > drivers/gpu/drm/zte/zx_vga.c:158:2-3: Unneeded semicolon > drivers/gpu/drm/zte/zx_vga.c:171:2-3: Unneeded semicolon > drivers/gpu/drm/zte/zx_vga.c:179:2-3: Unneeded semicolon > > Signed-off-by:

Re: [PATCH 1/3] drm/arm: Kconfig annotate drivers as COMPILE_TEST

2020-05-19 Thread Emil Velikov
On Mon, 18 May 2020 at 12:10, Liviu Dudau wrote: > > On Sun, May 17, 2020 at 08:36:53PM +0100, Emil Velikov wrote: > > Add the COMPILE_TEST conditional, so that people can at least build test > > the drivers. > > > > Cc: Liviu Dudau > > Acked-by: Liviu Dudau > > > Cc: Brian Starkey > > Cc: Mali

Re: [PATCH v5 1/2] drm/ioctl: Add a ioctl to set and get a label on GEM objects

2020-05-19 Thread Emil Velikov
Hi Rohan, As a high-level question: how does this compare to VC4_LABEL_BO? Is it possible to implement to replace or partially implement the vc4 one with this infra? IMHO this is something to aim for. A handful of ideas and suggestions below: On Thu, 14 May 2020 at 16:05, Rohan Garg wrote: >

Re: [RFC PATCH 0/4] DirectX on Linux

2020-05-19 Thread Dave Airlie
On Wed, 20 May 2020 at 08:42, Dave Airlie wrote: > > On Wed, 20 May 2020 at 02:33, Sasha Levin wrote: > > > > There is a blog post that goes into more detail about the bigger > > picture, and walks through all the required pieces to make this work. It > > is available here: > > https://devblogs.m

Re: [RFC PATCH 0/4] DirectX on Linux

2020-05-19 Thread Daniel Vetter
On Wed, May 20, 2020 at 12:42 AM Dave Airlie wrote: > > On Wed, 20 May 2020 at 02:33, Sasha Levin wrote: > > > > There is a blog post that goes into more detail about the bigger > > picture, and walks through all the required pieces to make this work. It > > is available here: > > https://devblog

Re: [PATCH 2/2] drm/mm: improve rb_hole_addr rbtree search

2020-05-19 Thread Chris Wilson
Quoting Nirmoy Das (2020-05-19 09:44:36) > +#define DRM_MM_ALIGN_SHIFT 6 > #define HOLE_SIZE(NODE) ((NODE)->hole_size) > #define HOLE_ADDR(NODE) (__drm_mm_hole_node_start(NODE)) > +#define HOLE_SIZE_ALIGN(NODE) ((NODE->hole_size << DRM_MM_ALIGN_SHIFT) | \ > + ffs(HOLE

[PATCH] drm/amdgpu/smu10: Replace one-element array and use struct_size() helper

2020-05-19 Thread Gustavo A. R. Silva
The current codebase makes use of one-element arrays in the following form: struct something { int length; u8 data[1]; }; struct something *instance; instance = kmalloc(sizeof(*instance) + size, GFP_KERNEL); instance->length = size; memcpy(instance->data, source, size); but the preferre

Re: [RFC PATCH 0/4] DirectX on Linux

2020-05-19 Thread Dave Airlie
On Wed, 20 May 2020 at 02:33, Sasha Levin wrote: > > There is a blog post that goes into more detail about the bigger > picture, and walks through all the required pieces to make this work. It > is available here: > https://devblogs.microsoft.com/directx/directx-heart-linux . The rest of > this co

Re: [PATCH 1/2] drm/mm: expand rb_hole_addr augmented callbacks

2020-05-19 Thread Chris Wilson
Quoting Nirmoy Das (2020-05-19 09:44:35) > Expand RB_DECLARE_CALLBACKS_MAX so that it is possible to store > extra value(max hole alignment) in the rb_hole_addr augmented rbtree. > > Signed-off-by: Nirmoy Das > --- > drivers/gpu/drm/drm_mm.c | 72 ++-- > 1 fil

[PATCH] drm/i915/hdcp: Add additional R0' wait

2020-05-19 Thread Sean Paul
From: Sean Paul We're seeing some R0' mismatches in the field, particularly with repeaters. I'm guessing the (already lenient) 300ms wait time isn't enough for some setups. So add an additional wait when R0' is mismatched. Signed-off-by: Sean Paul --- drivers/gpu/drm/i915/display/intel_hdcp.c

Re: [PATCH 2/2] drm/mm: improve rb_hole_addr rbtree search

2020-05-19 Thread Chris Wilson
Quoting Nirmoy Das (2020-05-19 09:44:36) > Userspace can still abuse alignment while allocating buffer object > to slow down rb_hole_addr rbtree search. This patch improves search > in fragmented rb_hole_addr rbtree by storing maximum subtree hole > alignment and use that to skip a complete subtree

Re: [PATCH] dma-fence: add might_sleep annotation to _wait()

2020-05-19 Thread Chris Wilson
Quoting Daniel Vetter (2020-05-19 14:27:56) > Do it uncontionally, there's a separate peek function with > dma_fence_is_signalled() which can be called from atomic context. > > v2: Consensus calls for an unconditional might_sleep (Chris, > Christian) > > Full audit: > - dma-fence.h: Uses MAX_SCHE

[PATCH v2] linux/bits.h: adjust GENMASK_INPUT_CHECK() check

2020-05-19 Thread Emil Velikov
Recently the GENMASK_INPUT_CHECK() was added, aiming to catch cases where there GENMASK arguments are flipped. Although it seems to be triggering -Wtype-limits in the following cases: unsigned foo = (10 + x); unsigned bar = GENMASK(foo, 0); const unsigned foo = (10 + x); unsigned bar

Re: [RFC PATCH 0/8] Qualcomm Cloud AI 100 driver

2020-05-19 Thread Daniel Vetter
On Tue, May 19, 2020 at 07:41:20PM +0200, Greg Kroah-Hartman wrote: > On Tue, May 19, 2020 at 08:57:38AM -0600, Jeffrey Hugo wrote: > > On 5/18/2020 11:08 PM, Dave Airlie wrote: > > > On Fri, 15 May 2020 at 00:12, Jeffrey Hugo wrote: > > > > > > > > Introduction: > > > > Qualcomm Cloud AI 100 is a

Re: [RFC PATCH 0/4] DirectX on Linux

2020-05-19 Thread Sasha Levin
Hi Daniel, On Tue, May 19, 2020 at 09:21:15PM +0200, Daniel Vetter wrote: Hi Sasha So obviously great that Microsoft is trying to upstream all this, and very much welcome and all that. But I guess there's a bunch of rather fundamental issues before we look into any kind of code details. And th

Re: [PATCH v2 0/2] drm/udl: Map pages with SHMEM helpers

2020-05-19 Thread Emil Velikov
On Tue, 19 May 2020 at 09:04, Thomas Zimmermann wrote: > > (was: Default to cachable mappings for GEM SHMEM) > > Udl implments cached mappings. Convert it to SHMEM's default helpers. > > v2: > * keep writecombine mappings as the default > * add SHMEM helper for creating BOs with ca

Re: [PATCH] drm: rcar-du: Fix build error

2020-05-19 Thread Emil Velikov
On Tue, 19 May 2020 at 08:01, Daniel Gomez wrote: > > Select DRM_KMS_HELPER dependency. > > Build error when DRM_KMS_HELPER is not selected: > > drivers/gpu/drm/rcar-du/rcar_lvds.o:(.rodata+0xd48): undefined reference to > `drm_atomic_helper_bridge_duplicate_state' > drivers/gpu/drm/rcar-du/rcar_

[pull] amdgpu drm-next-5.8

2020-05-19 Thread Alex Deucher
Hi Dave, Daniel, Last few bits for 5.8. The following changes since commit 80c9b58e9503f33a707a23172b2dd8d015b8c036: Merge tag 'du-next-20200514' of git://linuxtv.org/pinchartl/media into drm-next (2020-05-14 13:41:51 +1000) are available in the Git repository at: git://people.freedesktop

Re: [PATCH] tee: convert convert get_user_pages() --> pin_user_pages()

2020-05-19 Thread John Hubbard
On 2020-05-18 22:18, John Hubbard wrote: This code was using get_user_pages*(), in a "Case 2" scenario (DMA/RDMA), using the categorization from [1]. That means that it's time to convert the get_user_pages*() + put_page() calls to pin_user_pages*() + unpin_user_pages() calls. Looks like I acci

Re: [RFC PATCH 0/4] DirectX on Linux

2020-05-19 Thread Daniel Vetter
Hi Sasha So obviously great that Microsoft is trying to upstream all this, and very much welcome and all that. But I guess there's a bunch of rather fundamental issues before we look into any kind of code details. And that might make this quite a hard sell for upstream to drivers/gpu subsystem:

[PATCH] libdrm: enclose __FreeBSD__ behind a define

2020-05-19 Thread Carlos Santa
Not doing the above can cause compilation errors on platforms that don't define it. [1/25] Compiling C object 'drm@sha/xf86drm.c.o. FAILED: drm@sha/xf86drm.c.o ../xf86drm.c: In function 'drmGetMinorNameForFD': ../xf86drm.c:2938:7: error: "__FreeBSD__" is not defined [-Werror=undef] #elif __FreeBS

[PATCH libdrm] libdrm: enclose __FreeBSD__ behind a define

2020-05-19 Thread Carlos Santa
Not doing the above can cause compilation errors on platforms that don't define it. [1/25] Compiling C object 'drm@sha/xf86drm.c.o. FAILED: drm@sha/xf86drm.c.o ../xf86drm.c: In function 'drmGetMinorNameForFD': ../xf86drm.c:2938:7: error: "__FreeBSD__" is not defined [-Werror=undef] #elif __FreeBS

Re: [PATCH] dt-bindings: gpu: arm, mali-utgard: add additional properties

2020-05-19 Thread Heiko Stübner
Hi, Am Dienstag, 19. Mai 2020, 18:44:25 CEST schrieb Johan Jonker: > In the old txt situation we add/describe only properties that are used > by the driver/hardware itself. With yaml it also filters things in a > node that are used by other drivers like 'assigned-clocks' and > 'assigned-clock-rate

Re: [PATCH] arch/{mips,sparc,microblaze,powerpc}: Don't enable pagefault/preempt twice

2020-05-19 Thread Ira Weiny
On Tue, May 19, 2020 at 09:54:22AM -0700, Guenter Roeck wrote: > On Mon, May 18, 2020 at 11:48:43AM -0700, ira.we...@intel.com wrote: > > From: Ira Weiny > > > > The kunmap_atomic clean up failed to remove one set of pagefault/preempt > > enables when vaddr is not in the fixmap. > > > > Fixes: b

Re: [RFC PATCH 1/4] gpu: dxgkrnl: core code

2020-05-19 Thread Sasha Levin
On Tue, May 19, 2020 at 07:21:05PM +0200, Greg KH wrote: On Tue, May 19, 2020 at 12:32:31PM -0400, Sasha Levin wrote: + +#define DXGK_MAX_LOCK_DEPTH64 +#define W_MAX_PATH 260 We already have a max path number, why use a different one? It's max path for Windows, not Linux (thu

Re: [RFC PATCH 1/4] gpu: dxgkrnl: core code

2020-05-19 Thread Greg KH
On Tue, May 19, 2020 at 12:32:31PM -0400, Sasha Levin wrote: > +static int dxgglobal_init_global_channel(struct hv_device *hdev) > +{ > + int ret = 0; > + > + TRACE_DEBUG(1, "%s %x %x", __func__, hdev->vendor_id, hdev->device_id); > + { > + TRACE_DEBUG(1, "device type : %

Re: [RFC PATCH 1/4] gpu: dxgkrnl: core code

2020-05-19 Thread Greg KH
On Tue, May 19, 2020 at 12:32:31PM -0400, Sasha Levin wrote: > + > +#define DXGK_MAX_LOCK_DEPTH 64 > +#define W_MAX_PATH 260 We already have a max path number, why use a different one? > +#define d3dkmt_handleu32 > +#define d3dgpu_virtual_address u64 > +#define wi

Re: [RFC PATCH 1/4] gpu: dxgkrnl: core code

2020-05-19 Thread Greg KH
On Tue, May 19, 2020 at 12:32:31PM -0400, Sasha Levin wrote: > +/* > + * Dxgkrnl Graphics Port Driver ioctl definitions > + * > + */ > + > +#define LX_IOCTL_DIR_WRITE 0x1 > +#define LX_IOCTL_DIR_READ 0x2 > + > +#define LX_IOCTL_DIR(_ioctl) (((_ioctl) >> 30) & 0x3) > +#define LX_IOCTL_SIZE(_ioctl)

Re: [PATCH 11/12] gpu/drm: Ingenic: Add support for the IPU

2020-05-19 Thread Paul Boddie
On Monday 18. May 2020 13.26.58 Paul Cercueil wrote: > >> > >> @@ -186,13 +186,16 @@ static void > >> > >> ingenic_drm_crtc_update_timings(struct ingenic_drm *priv, > >> > >> regmap_update_bits(priv->map, JZ_REG_LCD_CTRL, > >> JZ_LCD_CTRL_OFUP | JZ_LCD_CTRL

[RFC PATCH 4/4] gpu: dxgkrnl: create a MAINTAINERS entry

2020-05-19 Thread Sasha Levin
Signed-off-by: Sasha Levin --- MAINTAINERS | 7 +++ 1 file changed, 7 insertions(+) diff --git a/MAINTAINERS b/MAINTAINERS index e64e5db31497..dccdfadda5df 100644 --- a/MAINTAINERS +++ b/MAINTAINERS @@ -4997,6 +4997,13 @@ F: Documentation/filesystems/dnotify.txt F: fs/notify/dnoti

[RFC PATCH 2/4] gpu: dxgkrnl: hook up dxgkrnl

2020-05-19 Thread Sasha Levin
Connect the dxgkrnl module to the drivers/gpu/ makefile and Kconfig. Signed-off-by: Sasha Levin --- drivers/gpu/Makefile | 2 +- drivers/video/Kconfig | 2 ++ 2 files changed, 3 insertions(+), 1 deletion(-) diff --git a/drivers/gpu/Makefile b/drivers/gpu/Makefile index 835c88318cec..28c22c8144

[RFC PATCH 3/4] Drivers: hv: vmbus: hook up dxgkrnl

2020-05-19 Thread Sasha Levin
Register a new device type with vmbus. Signed-off-by: Sasha Levin --- include/linux/hyperv.h | 16 1 file changed, 16 insertions(+) diff --git a/include/linux/hyperv.h b/include/linux/hyperv.h index 692c89ccf5df..ad16e9bc676a 100644 --- a/include/linux/hyperv.h +++ b/include/li

[RFC PATCH 0/4] DirectX on Linux

2020-05-19 Thread Sasha Levin
There is a blog post that goes into more detail about the bigger picture, and walks through all the required pieces to make this work. It is available here: https://devblogs.microsoft.com/directx/directx-heart-linux . The rest of this cover letter will focus on the Linux Kernel bits. Overview

Re: [PATCH V3 07/15] arch/kunmap_atomic: Consolidate duplicate code

2020-05-19 Thread Ira Weiny
On Mon, May 18, 2020 at 07:50:36PM -0700, Guenter Roeck wrote: > Hi Ira, > > On 5/18/20 5:03 PM, Ira Weiny wrote: > > On Sun, May 17, 2020 at 09:29:32PM -0700, Guenter Roeck wrote: > >> On Sun, May 17, 2020 at 08:49:39PM -0700, Ira Weiny wrote: > >>> On Sat, May 16, 2020 at 03:33:06PM -0700, Guent

Re: [PATCH] drm/amdkfd: Fix boolreturn.cocci warnings

2020-05-19 Thread Alex Deucher
On Mon, May 18, 2020 at 12:37 PM Aishwarya Ramakrishnan wrote: > > Return statements in functions returning bool should use > true/false instead of 1/0. > > drivers/gpu/drm/amd/amdkfd/kfd_int_process_v9.c:40:9-10: > WARNING: return of 0/1 in function 'event_interrupt_isr_v9' with return type > bo

Re: [PATCH] drm/mediatek: mtk_hdmi: Remove debug messages for function calls

2020-05-19 Thread Chun-Kuang Hu
Hi, Enric: Enric Balletbo i Serra 於 2020年5月19日 週二 下午5:41寫道: > > Equivalent information can be nowadays obtained using function tracer > Reviewed-by: Chun-Kuang Hu > Signed-off-by: Enric Balletbo i Serra > --- > > drivers/gpu/drm/mediatek/mtk_hdmi.c| 12 +--- > drivers/gpu

Re: [PATCH] drm/mediatek: mtk_mt8173_hdmi_phy: Remove unnused const variables

2020-05-19 Thread Chun-Kuang Hu
Hi, Enric: Enric Balletbo i Serra 於 2020年5月19日 週二 下午5:40寫道: > > There are some `static const u8` variables that are not used, this > triggers a warning building with `make W=1`, it is safe to remove them, > so do it and make the compiler more happy. > Reviewed-by: Chun-Kuang Hu > Signed-off-by

Re: [PATCH] linux/bits.h: adjust GENMASK_INPUT_CHECK() check

2020-05-19 Thread kbuild test robot
improve the system. BTW, we also suggest to use '--base' option to specify the base tree in git format-patch, please see https://stackoverflow.com/a/37406982] url: https://github.com/0day-ci/linux/commits/Emil-Velikov/linux-bits-h-adjust-GENMASK_INPUT_CHECK-check/20200519-205452 b

Re: [PATCH] linux/bits.h: adjust GENMASK_INPUT_CHECK() check

2020-05-19 Thread kbuild test robot
improve the system. BTW, we also suggest to use '--base' option to specify the base tree in git format-patch, please see https://stackoverflow.com/a/37406982] url: https://github.com/0day-ci/linux/commits/Emil-Velikov/linux-bits-h-adjust-GENMASK_INPUT_CHECK-check/20200519-205452 b

Re: [PATCH] drm/doc: device hot-unplug for userspace

2020-05-19 Thread Andrey Grodzovsky
Thanks for the summary, does put things in order and makes it easier to comprehend all the TODOs, some questions bellow On 5/19/20 6:06 AM, Pekka Paalanen wrote: From: Pekka Paalanen Set up the expectations on how hot-unplugging a DRM device should look like to userspace. Written by Daniel V

RE: [PATCH v2 3/9] drm/i915/display/sdvo: Prefer drm_WARN* over WARN*

2020-05-19 Thread Laxminarayan Bharadiya, Pankaj
> -Original Message- > From: Jani Nikula > Sent: 19 May 2020 19:12 > To: Laxminarayan Bharadiya, Pankaj > ; dan...@ffwll.ch; intel- > g...@lists.freedesktop.org; dri-devel@lists.freedesktop.org; Joonas Lahtinen > ; Vivi, Rodrigo ; > David Airlie ; Ville Syrjälä > ; Chris > Wilson ; Deak

RE: [PATCH v2 3/9] drm/i915/display/sdvo: Prefer drm_WARN* over WARN*

2020-05-19 Thread Jani Nikula
On Fri, 08 May 2020, "Laxminarayan Bharadiya, Pankaj" wrote: >> -Original Message- >> From: Jani Nikula >> Sent: 08 May 2020 12:19 >> To: Laxminarayan Bharadiya, Pankaj >> ; dan...@ffwll.ch; intel- >> g...@lists.freedesktop.org; dri-devel@lists.freedesktop.org; Joonas Lahtinen >> ; Viv

[PATCH] dma-fence: add might_sleep annotation to _wait()

2020-05-19 Thread Daniel Vetter
Do it uncontionally, there's a separate peek function with dma_fence_is_signalled() which can be called from atomic context. v2: Consensus calls for an unconditional might_sleep (Chris, Christian) Full audit: - dma-fence.h: Uses MAX_SCHEDULE_TIMOUT, good chance this sleeps - dma-resv.c: Timeout a

Re: [PATCH AUTOSEL 5.6 33/50] drm/amdgpu: bump version for invalidate L2 before SDMA IBs

2020-05-19 Thread Deucher, Alexander
[AMD Public Use] Yes, please drop this patch for stable. Alex From: Marek Olšák Sent: Monday, May 18, 2020 6:35 PM To: Sasha Levin Cc: Linux Kernel Mailing List ; sta...@vger.kernel.org ; Pelloux-prayer, Pierre-eric ; Olsak, Marek ; amd-gfx mailing list ; dri

Re: [PATCH 06/12] gpu/drm: Ingenic: Fix incorrect assumption about plane->index

2020-05-19 Thread Sasha Levin
Hi [This is an automated email] This commit has been processed because it contains a "Fixes:" tag fixing commit: 90b86fcc47b4 ("DRM: Add KMS driver for the Ingenic JZ47xx SoCs"). The bot has tested the following trees: v5.6.13, v5.4.41. v5.6.13: Build OK! v5.4.41: Failed to apply! Possible depe

Re: [PATCH 1/3] drm/tilcdc: fix leak & null ref in panel_connector_get_modes

2020-05-19 Thread Tomi Valkeinen
On 06/05/2020 22:02, Sam Ravnborg wrote: On Wed, Apr 29, 2020 at 01:42:32PM +0300, Tomi Valkeinen wrote: If videomode_from_timings() returns true, the mode allocated with drm_mode_create will be leaked. Also, the return value of drm_mode_create() is never checked, and thus could cause NULL dere

[gabbayo:habanalabs-next 35/38] drivers/misc/habanalabs/gaudi/gaudi_coresight.c:833:6: warning: variable 'val' set but not used

2020-05-19 Thread kbuild test robot
tree: git://people.freedesktop.org/~gabbayo/linux habanalabs-next head: addd4be0a770e4cf5607310459cb7c8d11c8ae57 commit: af3bef8b2782bfe3eeb32c8f1f264b5064a27f81 [35/38] habanalabs: add gaudi profiler module config: m68k-randconfig-r012-20200519 (attached as .config) compiler: m68k-linux-gcc

Re: [PATCH] drm/etnaviv: Fix a leak in submit_pin_objects()

2020-05-19 Thread Lucas Stach
Am Montag, den 18.05.2020, 14:29 +0300 schrieb Dan Carpenter: > If the mapping address is wrong then we have to release the reference to > it before returning -EINVAL. > > Fixes: 00ddc0b2 ("drm/etnaviv: implement softpin") > Signed-off-by: Dan Carpenter Thanks, applied to etnaviv/fixes. Reg

Re: [PATCH v2] drm/etnaviv: fix perfmon domain interation

2020-05-19 Thread Lucas Stach
Am Dienstag, den 19.05.2020, 07:30 +0200 schrieb Christian Gmeiner: > The GC860 has one GPU device which has a 2d and 3d core. In this case > we want to expose perfmon information for both cores. > > The driver has one array which contains all possible perfmon domains > with some meta data - doms_

[PATCH] linux/bits.h: adjust GENMASK_INPUT_CHECK() check

2020-05-19 Thread Emil Velikov
Recently the GENMASK_INPUT_CHECK() was added, aiming to catch cases where there GENMASK arguments are flipped. Although it seems to be triggering -Wtype-limits in the following cases: unsigned foo = (10 + x); unsigned bar = GENMASK(foo, 0); const unsigned foo = (10 + x); unsigned bar

[gabbayo:habanalabs-next 33/38] drivers/misc/habanalabs/gaudi/gaudi_hwmgr.c:72:6: warning: variable 'rc' set but not used

2020-05-19 Thread kbuild test robot
tree: git://people.freedesktop.org/~gabbayo/linux habanalabs-next head: addd4be0a770e4cf5607310459cb7c8d11c8ae57 commit: f0fdc034c52b87d1c11bc28e2affd9d5a41a419b [33/38] habanalabs: add hwmgr module for gaudi config: m68k-randconfig-r012-20200519 (attached as .config) compiler: m68k-linux-gcc

Re: [PATCH 2/3] drm/tilcdc: remove unnecessary state->fb check

2020-05-19 Thread Jyri Sarha
On 29/04/2020 13:42, Tomi Valkeinen wrote: > tilcdc_plane_atomic_check() exits if state->fb == NULL, so no need to > check it again later. > > Signed-off-by: Tomi Valkeinen Reviewed-by: Jyri Sarha > --- > drivers/gpu/drm/tilcdc/tilcdc_plane.c | 3 +-- > 1 file changed, 1 insertion(+), 2 delet

[PATCH] drm/doc: device hot-unplug for userspace

2020-05-19 Thread Pekka Paalanen
From: Pekka Paalanen Set up the expectations on how hot-unplugging a DRM device should look like to userspace. Written by Daniel Vetter's request and largely based on his comments in IRC and from https://lists.freedesktop.org/archives/dri-devel/2020-May/265484.html . Signed-off-by: Pekka Paalan

Re: [PATCH 3/3] drm/tilcdc: add missing static for panel_driver

2020-05-19 Thread Jyri Sarha
On 29/04/2020 13:42, Tomi Valkeinen wrote: > struct platform_driver panel_driver is only used from tilcdc_panel.c, so > it can be static. > > Signed-off-by: Tomi Valkeinen Reviewed-by: Jyri Sarha > --- > drivers/gpu/drm/tilcdc/tilcdc_panel.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletio

Re: [PATCH 1/3] drm/tilcdc: fix leak & null ref in panel_connector_get_modes

2020-05-19 Thread Jyri Sarha
On 29/04/2020 13:42, Tomi Valkeinen wrote: > If videomode_from_timings() returns true, the mode allocated with > drm_mode_create will be leaked. > > Also, the return value of drm_mode_create() is never checked, and thus > could cause NULL deref. > > Fix these two issues. > > Signed-off-by: Tomi

Re: [PATCH] ASoC: fsl: imx-pcm-dma: Don't request dma channel in probe

2020-05-19 Thread Lucas Stach
Am Dienstag, den 19.05.2020, 17:41 +0800 schrieb Shengjiu Wang: > There are two requirements that we need to move the request > of dma channel from probe to open. How do you handle -EPROBE_DEFER return code from the channel request if you don't do it in probe? > - When dma device binds with power

Re: [PATCH] drm/i915/gvt: Use ARRAY_SIZE for vgpu_types

2020-05-19 Thread Zhenyu Wang
On 2020.05.18 22:00:52 +0100, Chris Wilson wrote: > Quoting Aishwarya Ramakrishnan (2020-05-18 16:03:36) > > Prefer ARRAY_SIZE instead of using sizeof > > > > Fixes coccicheck warning: Use ARRAY_SIZE > > > > Signed-off-by: Aishwarya Ramakrishnan > Reviewed-by: Chris Wilson Applied, thanks! --

Re: Graphic card that needs boot parameter

2020-05-19 Thread Ville Syrjälä
On Tue, May 19, 2020 at 07:22:56AM +0200, p...@hiereth.de wrote: > Hello, > > in > https://www.kernel.org/doc/html/latest/admin-guide/kernel-parameters.html > You ask > to inform about hardware that requires the setting > i915.invert-brightness=1. > > I needed this for an quite old notebook with

[PATCH v2 0/2] drm/udl: Map pages with SHMEM helpers

2020-05-19 Thread Thomas Zimmermann
(was: Default to cachable mappings for GEM SHMEM) Udl implments cached mappings. Convert it to SHMEM's default helpers. v2: * keep writecombine mappings as the default * add SHMEM helper for creating BOs with cached mappings * update udl on the new helper Thomas Zimmerman

[PATCH v2 2/2] drm/udl: Use GEM vmap/mmap function from SHMEM helpers

2020-05-19 Thread Thomas Zimmermann
The udl driver contains an implementation of GEM vmap and mmap operations that is identical to the common SHMEM helper; except that udl's code uses cached pages by default. Convert udl to regular SHMEM helper functions. There's no reason to have udl behave differently from all other SHMEM drivers.

[PATCH v2 1/2] drm/shmem-helper: Add .gem_create_object helper that sets map_cached flag

2020-05-19 Thread Thomas Zimmermann
The helper drm_gem_shmem_create_object_cached() allocates an GEM SHMEM object and sets the map_cached flag. Useful for drivers that want cached mappings. Signed-off-by: Thomas Zimmermann --- drivers/gpu/drm/drm_gem_shmem_helper.c | 27 ++ include/drm/drm_gem_shmem_helper.

[PATCH] drm/exynos: Remove dev_err() on platform_get_irq() failure

2020-05-19 Thread Tamseel Shams
platform_get_irq() will call dev_err() itself on failure, so there is no need for the driver to also do this. This is detected by coccinelle. Signed-off-by: Tamseel Shams --- drivers/gpu/drm/exynos/exynos_drm_dsi.c | 1 - drivers/gpu/drm/exynos/exynos_drm_g2d.c | 1 - drivers/gpu/drm/exy

Re: [PATCH V3 07/15] arch/kunmap_atomic: Consolidate duplicate code

2020-05-19 Thread Guenter Roeck
On Sun, May 17, 2020 at 08:49:39PM -0700, Ira Weiny wrote: [ ... ] > > > > --- > > # bad: [bdecf38f228bcca73b31ada98b5b7ba1215eb9c9] Add linux-next specific > > files for 20200515 > > # good: [2ef96a5bb12be62ef75b5828c0aab838ebb29cb8] Linux 5.7-rc5 > > git bisect start 'HEAD' 'v5.7-rc5' > > # g

[v4] dt-bindings: msm: disp: add yaml schemas for DPU and DSI bindings

2020-05-19 Thread Krishna Manikandan
MSM Mobile Display Subsytem (MDSS) encapsulates sub-blocks like DPU display controller, DSI etc. Add YAML schema for the device tree bindings for the same. Signed-off-by: Krishna Manikandan Changes in v2: - Changed dpu to DPU (Sam Ravnborg) - Fixed indentation issues (Sam Ravnbor

[RESEND PATCH 2/3] drm/mediatek: mtk_dpi: Convert to bridge driver

2020-05-19 Thread Enric Balletbo i Serra
Convert mtk_dpi to a bridge driver with built-in encoder support for compatibility with existing component drivers. Signed-off-by: Enric Balletbo i Serra Reviewed-by: Chun-Kuang Hu --- drivers/gpu/drm/mediatek/mtk_dpi.c | 66 +++--- 1 file changed, 34 insertions(+), 32

[PATCH v4 6/8] ARM: dts: stm32: enable ltdc binding with ili9341 on stm32429-disco board

2020-05-19 Thread dillon . minfei
From: dillon min Enable the ltdc & ili9341 on stm32429-disco board. Signed-off-by: dillon min --- arch/arm/boot/dts/stm32f429-disco.dts | 48 +++ 1 file changed, 48 insertions(+) diff --git a/arch/arm/boot/dts/stm32f429-disco.dts b/arch/arm/boot/dts/stm32f429-

[RESEND PATCH 3/3] drm/mediatek: mtk_dpi: Use simple encoder

2020-05-19 Thread Enric Balletbo i Serra
The mtk_dpi driver uses an empty implementation for its encoder. Replace the code with the generic simple encoder. Signed-off-by: Enric Balletbo i Serra Reviewed-by: Chun-Kuang Hu --- drivers/gpu/drm/mediatek/mtk_dpi.c | 14 +++--- 1 file changed, 3 insertions(+), 11 deletions(-) diff

Re: [PATCH V3 07/15] arch/kunmap_atomic: Consolidate duplicate code

2020-05-19 Thread Guenter Roeck
Hi Ira, On 5/18/20 5:03 PM, Ira Weiny wrote: > On Sun, May 17, 2020 at 09:29:32PM -0700, Guenter Roeck wrote: >> On Sun, May 17, 2020 at 08:49:39PM -0700, Ira Weiny wrote: >>> On Sat, May 16, 2020 at 03:33:06PM -0700, Guenter Roeck wrote: On Thu, May 07, 2020 at 07:59:55AM -0700, ira.we...@in

[PATCH v4 5/8] dt-bindings: display: panel: Add ilitek ili9341 panel bindings

2020-05-19 Thread dillon . minfei
From: dillon min Add documentation for "ilitek,ili9341" panel. Signed-off-by: dillon min --- .../bindings/display/panel/ilitek,ili9341.yaml | 69 ++ 1 file changed, 69 insertions(+) create mode 100644 Documentation/devicetree/bindings/display/panel/ilitek,ili9341.yaml

[PATCH v4 0/8] Enable ili9341 and l3gd20 on stm32f429-disco

2020-05-19 Thread dillon . minfei
From: dillon min According to alexandre torgue's suggestion, combine ili9341 and l3gd20's modification on stm32f429-disco board to one patchset. Changes: ili9341: V4: 1 update ili9341 panel driver according to Linus's suggestion 2 drop V1's No.5 patch, sumbit new changes for clk-stm32f4 3 merg

[PATCH] drm/msm/a6xx: don't try to set GPU frequency when GMU is suspended

2020-05-19 Thread Jonathan Marek
This fixes changing the frequency in sysfs while suspended, for example when doing something like this: cat devfreq/3d0.gpu/max_freq > devfreq/3d0.gpu/min_freq Signed-off-by: Jonathan Marek --- drivers/gpu/drm/msm/adreno/a6xx_gmu.c | 11 +-- 1 file changed, 9 insertions(+), 2 de

[RESEND PATCH 1/3] drm/mediatek: mtk_dpi: Rename bridge to next_bridge

2020-05-19 Thread Enric Balletbo i Serra
This is really a cosmetic change just to make a bit more readable the code after convert the driver to drm_bridge. The bridge variable name will be used by the encoder drm_bridge, and the chained bridge will be named next_bridge. Signed-off-by: Enric Balletbo i Serra Reviewed-by: Chun-Kuang Hu -

[PATCH v4 7/8] clk: stm32: Fix stm32f429's ltdc driver hang in set clock rate.

2020-05-19 Thread dillon . minfei
From: dillon min fix duplicated ltdc clock register to 'clk_core' case ltdc's clock turn off by clk_disable_unused() ltdc set clock rate crashed: 'post_div_data[]''s pll_num is PLL_I2S, PLL_SAI (number is 1,2). but, as pll_num is offset of 'clks[]' input to clk_register_pll_div(), which

[PATCH v4 2/8] ARM: dts: stm32: enable l3gd20 on stm32429-disco board

2020-05-19 Thread dillon . minfei
From: dillon min L3gd20, st mems motion sensor, 3-axis digital output gyroscope, connect to stm32f429 via spi5 Signed-off-by: dillon min --- arch/arm/boot/dts/stm32f4-pinctrl.dtsi | 17 + 1 file changed, 17 insertions(+) diff --git a/arch/arm/boot/dts/stm32f4-pinctrl.dtsi b/a

[PATCH] drm: rcar-du: Fix build error

2020-05-19 Thread Daniel Gomez
Select DRM_KMS_HELPER dependency. Build error when DRM_KMS_HELPER is not selected: drivers/gpu/drm/rcar-du/rcar_lvds.o:(.rodata+0xd48): undefined reference to `drm_atomic_helper_bridge_duplicate_state' drivers/gpu/drm/rcar-du/rcar_lvds.o:(.rodata+0xd50): undefined reference to `drm_atomic_helpe

[PATCH] Lenovo X13 Yoga OLED panel brightness fix. Add another panel that needs the edid quirk to the list so that brightness control works correctly. Fixes issue seen on Lenovo X13 Yoga with OLED pan

2020-05-19 Thread Mark Pearson
Co-developed-by: jendr...@lenovo.com Signed-off-by: Mark Pearson --- drivers/gpu/drm/drm_dp_helper.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/gpu/drm/drm_dp_helper.c b/drivers/gpu/drm/drm_dp_helper.c index c6fbe6e6bc9d..41f0e797ce8c 100644 --- a/drivers/gpu/drm/drm_dp_helper.c

[RESEND PATCH 0/3] Convert mtk-dpi to drm_bridge API

2020-05-19 Thread Enric Balletbo i Serra
The reason for this resend is because I forget to add some bridge maintainers. So adding them and collect the actual tags. The mtk-dpi driver still uses the drm_encoder API which is now somewhat deprecated. We started to move all the Mediatek drivers to the drm_bridge API, like we did for the mtk-

Graphic card that needs boot parameter

2020-05-19 Thread post
Hello, in https://www.kernel.org/doc/html/latest/admin-guide/kernel-parameters.html You ask to inform about hardware that requires the setting i915.invert-brightness=1. I needed this for an quite old notebook with the following specifications lspci -s 00:02 -nn 00:02.0 VGA compatible control

[PATCH v4 4/8] ARM: dts: stm32: Add pin map for ltdc on stm32f429-disco board

2020-05-19 Thread dillon . minfei
From: dillon min This patch adds the pin configuration for ltdc controller on stm32f429-disco board. Signed-off-by: dillon min --- arch/arm/boot/dts/stm32f4-pinctrl.dtsi | 50 ++ 1 file changed, 50 insertions(+) diff --git a/arch/arm/boot/dts/stm32f4-pinctrl.dt

[PATCH] drm/i915/gvt: Use ARRAY_SIZE for vgpu_types

2020-05-19 Thread Aishwarya Ramakrishnan
Prefer ARRAY_SIZE instead of using sizeof Fixes coccicheck warning: Use ARRAY_SIZE Signed-off-by: Aishwarya Ramakrishnan --- drivers/gpu/drm/i915/gvt/vgpu.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/gpu/drm/i915/gvt/vgpu.c b/drivers/gpu/drm/i915/gvt/vgpu.c inde

[PATCH] drm/amdkfd: Fix boolreturn.cocci warnings

2020-05-19 Thread Aishwarya Ramakrishnan
Return statements in functions returning bool should use true/false instead of 1/0. drivers/gpu/drm/amd/amdkfd/kfd_int_process_v9.c:40:9-10: WARNING: return of 0/1 in function 'event_interrupt_isr_v9' with return type bool Generated by: scripts/coccinelle/misc/boolreturn.cocci Signed-off-by: Ai

[PATCH v4 1/8] ARM: dts: stm32: Add dma config for spi5

2020-05-19 Thread dillon . minfei
From: dillon min Enable spi5's dma configuration. for graphics data output to ilitek ili9341 panel via mipi dbi interface Signed-off-by: dillon min --- arch/arm/boot/dts/stm32f429.dtsi | 3 +++ 1 file changed, 3 insertions(+) diff --git a/arch/arm/boot/dts/stm32f429.dtsi b/arch/arm/boot/dts/s

[PATCH v4 8/8] drm/panel: Add ilitek ili9341 panel driver

2020-05-19 Thread dillon . minfei
From: dillon min This driver combine tiny/ili9341.c mipi_dbi_interface driver with mipi_dpi_interface driver, can support ili9341 with serial mode or parallel rgb interface mode by register configuration. Signed-off-by: dillon min --- Changes since V3: accoding to Linus Walleij's suggestion.

Re: [PATCH 11/12] gpu/drm: Ingenic: Add support for the IPU

2020-05-19 Thread Paul Cercueil
Hi Emil, Le lun. 18 mai 2020 à 11:48, Emil Velikov a écrit : Hi Paul, Disclaimer: I don't know much about the hardware :-P On Sun, 17 May 2020 at 00:31, Paul Cercueil wrote: Add support for the Image Processing Unit (IPU) found in all Ingenic SoCs. Since the IPU is present on all dev

Re: [PATCH] drm/mediatek: Delete not used of_device_get_match_data

2020-05-19 Thread Enric Balletbo i Serra
Hi Matthias, On 18/5/20 13:22, matthias@kernel.org wrote: > From: Matthias Brugger > > The driver will be loaded by via a platform device. So we > will need to get the device_node from the parent device. > Depending on this we will set the driver data. > As all this is done later already, ju

[PATCH v4 3/8] spi: stm32: Add 'SPI_SIMPLEX_RX', 'SPI_3WIRE_RX' support for stm32f4

2020-05-19 Thread dillon . minfei
From: dillon min in l3gd20 driver startup, there is a setup failed error return from stm32 spi driver " [2.687630] st-gyro-spi spi0.0: supply vdd not found, using dummy regulator [2.696869] st-gyro-spi spi0.0: supply vddio not found, using dummy regulator [2.7

  1   2   >