[Bug 204559] amdgpu: kernel oops with constant gpu resets while using mpv

2019-09-06 Thread bugzilla-daemon
https://bugzilla.kernel.org/show_bug.cgi?id=204559 --- Comment #11 from Christopher Snowhill (kod...@gmail.com) --- Oops, I neglected to mention: The system is non-responsive to input devices, as the USB input appears to all be completely powered off after the GPU crashes, but the network interfac

[Bug 204559] amdgpu: kernel oops with constant gpu resets while using mpv

2019-09-06 Thread bugzilla-daemon
https://bugzilla.kernel.org/show_bug.cgi?id=204559 Christopher Snowhill (kod...@gmail.com) changed: What|Removed |Added CC||kod...@gmail.com

[Bug 102322] System crashes after "[drm] IP block:gmc_v8_0 is hung!" / [drm] IP block:sdma_v3_0 is hung!

2019-09-06 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=102322 --- Comment #86 from Paul Ezvan --- I was also impacted by this bug (amdgpu hangs on random conditions with similar messages as the one exposed) with any kernel/mesa version combination other than the ones on Debian Stretch (any other distro or

[Bug 111236] VA-API radeonsi SIGSEGV __memmove_avx_unaligned

2019-09-06 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=111236 --- Comment #11 from Julien Isorce --- Hi Michel, I confirm the attached patch fixes the issues for me too. -- You are receiving this mail because: You are the assignee for the bug.___ dri-devel mail

[Bug 109955] amdgpu [RX Vega 64] system freeze while gaming

2019-09-06 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=109955 --- Comment #97 from Rodney A Morris --- Created attachment 145290 --> https://bugs.freedesktop.org/attachment.cgi?id=145290&action=edit dmesg for crash dmesg from crash while playing Hearts of Iron IV using Steam. Related to comment #96. -

[Bug 109955] amdgpu [RX Vega 64] system freeze while gaming

2019-09-06 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=109955 --- Comment #96 from Rodney A Morris --- (In reply to Mauro Gaspari from comment #90) I am experiencing periodic lockups with various games, including Hearts of Iron IV, BATTLETECH, and Stellaris all being played through Steam. Below is the mo

Re: Adreno crash on i.MX53 running 5.3-rc6

2019-09-06 Thread Rob Clark
On Thu, Sep 5, 2019 at 3:30 PM Rob Clark wrote: > > On Thu, Sep 5, 2019 at 12:05 PM Rob Clark wrote: > > > > On Thu, Sep 5, 2019 at 10:03 AM Rob Clark wrote: > > > > > > On Wed, Sep 4, 2019 at 11:06 AM Robin Murphy wrote: > > > > > > > > On 04/09/2019 01:12, Rob Clark wrote: > > > > > On Tue, S

Re: [PATCH] drm: add drm device name

2019-09-06 Thread Rob Clark
On Fri, Sep 6, 2019 at 3:16 PM Marek Olšák wrote: > > + dri-devel > > On Tue, Sep 3, 2019 at 5:41 PM Jiang, Sonny wrote: >> >> Add DRM device name and use DRM_IOCTL_VERSION ioctl drmVersion::desc passing >> it to user space >> instead of unused DRM driver name descriptor. >> >> Change-Id: I809f6

Re: [PATCH] mm, notifier: Fix early return case for new lockdep annotations

2019-09-06 Thread John Hubbard
On 9/6/19 10:47 AM, Daniel Vetter wrote: > I missed that when extending the lockdep annotations to the > nonblocking case. > > I missed this while testing since in the i915 mmu notifiers is hitting > a nice lockdep splat already before the point of going into oom killer > mode :-/ > > Reported-by

Re: [PATCH] drm: add drm device name

2019-09-06 Thread Marek Olšák
+ dri-devel On Tue, Sep 3, 2019 at 5:41 PM Jiang, Sonny wrote: > Add DRM device name and use DRM_IOCTL_VERSION ioctl drmVersion::desc > passing it to user space > instead of unused DRM driver name descriptor. > > Change-Id: I809f6d3e057111417efbe8fa7cab8f0113ba4b21 > Signed-off-by: Sonny Jiang

[PATCH v2 2/2] drm/msm: mark devices where iommu is managed by driver

2019-09-06 Thread Rob Clark
From: Rob Clark Signed-off-by: Rob Clark --- drivers/gpu/drm/msm/adreno/adreno_device.c | 1 + drivers/gpu/drm/msm/disp/dpu1/dpu_kms.c| 1 + drivers/gpu/drm/msm/disp/mdp5/mdp5_kms.c | 1 + drivers/gpu/drm/msm/msm_drv.c | 1 + 4 files changed, 4 insertions(+) diff --git a/dri

[PATCH v2 1/2] iommu: add support for drivers that manage iommu explicitly

2019-09-06 Thread Rob Clark
From: Rob Clark Avoid attaching any non-driver managed domain if the driver indicates that it manages the iommu directly. Signed-off-by: Rob Clark --- drivers/iommu/iommu.c| 2 +- drivers/iommu/of_iommu.c | 3 +++ include/linux/device.h | 3 ++- 3 files changed, 6 insertions(+), 2 deleti

[PATCH v3 0/2] iommu: handle drivers that manage iommu directly

2019-09-06 Thread Rob Clark
From: Rob Clark One of the challenges we have to enable the aarch64 laptops upstream is dealing with the fact that the bootloader enables the display and takes the corresponding SMMU context-bank out of BYPASS. Unfortunately, currently, the IOMMU framework attaches a DMA (or potentially an IDENT

[Bug 109389] memory leak in `amdgpu_bo_create()`

2019-09-06 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=109389 --- Comment #8 from Czcibor Bohusz-Dobosz --- Created attachment 145289 --> https://bugs.freedesktop.org/attachment.cgi?id=145289&action=edit DRM/AMDgpu glxgears memleak log For comparison, I attach the bcc memleak log of glxgears taken with

[Bug 109389] memory leak in `amdgpu_bo_create()`

2019-09-06 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=109389 --- Comment #7 from Czcibor Bohusz-Dobosz --- Created attachment 145288 --> https://bugs.freedesktop.org/attachment.cgi?id=145288&action=edit DRM/Radeon glxgears memleak log Took a while to perform some more tests, and it turns out that runni

Re: [Spice-devel] Xorg indefinitely hangs in kernelspace

2019-09-06 Thread Frediano Ziglio
> > On Tue, 6 Aug 2019 21:00:10 +0300 From: Jaak Ristioja > > Hello! > > > > I'm writing to report a crash in the QXL / DRM code in the Linux kernel. > > I originally filed the issue on LaunchPad and more details can be found > > there, although I doubt whether these details are useful. > > >

[Bug 204683] amdgpu: ring sdma0 timeout

2019-09-06 Thread bugzilla-daemon
https://bugzilla.kernel.org/show_bug.cgi?id=204683 --- Comment #7 from Soeren Grunewald (soeren.grunew...@gmx.net) --- Created attachment 284869 --> https://bugzilla.kernel.org/attachment.cgi?id=284869&action=edit Kernel trace It seems I have the same issue. I run on fedora 30 with testing-upda

[PATCH 6/6] drm/msm/dpu: Remove unnecessary NULL checks

2019-09-06 Thread Drew Davenport
dpu_kms.dev will never be NULL, so don't bother checking. Signed-off-by: Drew Davenport --- drivers/gpu/drm/msm/disp/dpu1/dpu_core_irq.c | 8 - .../drm/msm/disp/dpu1/dpu_encoder_phys_cmd.c | 4 --- drivers/gpu/drm/msm/disp/dpu1/dpu_kms.c | 30 +-- 3 files changed,

[PATCH 2/6] drm/msm/dpu: Remove unused macro

2019-09-06 Thread Drew Davenport
Signed-off-by: Drew Davenport --- drivers/gpu/drm/msm/disp/dpu1/dpu_kms.h | 4 1 file changed, 4 deletions(-) diff --git a/drivers/gpu/drm/msm/disp/dpu1/dpu_kms.h b/drivers/gpu/drm/msm/disp/dpu1/dpu_kms.h index 4c889aabdaf9..6ceba33a179e 100644 --- a/drivers/gpu/drm/msm/disp/dpu1/dpu_kms.

[PATCH 5/6] drm/msm/dpu: Remove unnecessary NULL checks

2019-09-06 Thread Drew Davenport
msm_drm_private.kms will only be NULL in the dummy headless case, so there is no need to check it in the dpu display driver. Signed-off-by: Drew Davenport --- drivers/gpu/drm/msm/disp/dpu1/dpu_core_irq.c | 23 --- drivers/gpu/drm/msm/disp/dpu1/dpu_core_perf.c | 12 +++--- d

[PATCH 4/6] drm/msm/dpu: Remove unnecessary NULL checks

2019-09-06 Thread Drew Davenport
drm_crtc.dev will never be NULL, so no need to check it. Signed-off-by: Drew Davenport --- drivers/gpu/drm/msm/disp/dpu1/dpu_core_perf.c | 5 - drivers/gpu/drm/msm/disp/dpu1/dpu_crtc.c | 6 +++--- 2 files changed, 3 insertions(+), 8 deletions(-) diff --git a/drivers/gpu/drm/msm/disp/d

[PATCH 3/6] drm/msm/dpu: Remove unnecessary NULL checks

2019-09-06 Thread Drew Davenport
drm_device.dev_private is set to a non-NULL msm_drm_private struct in msm_drm_init. Successful initialization of msm means that dev_private is non-NULL so there is no need to check it everywhere. Signed-off-by: Drew Davenport --- drivers/gpu/drm/msm/disp/dpu1/dpu_core_irq.c | 6 -- dri

[PATCH 1/6] drm/msm/dpu: Remove unused variables

2019-09-06 Thread Drew Davenport
Signed-off-by: Drew Davenport --- drivers/gpu/drm/msm/disp/dpu1/dpu_crtc.c| 5 - drivers/gpu/drm/msm/disp/dpu1/dpu_encoder.c | 7 --- 2 files changed, 12 deletions(-) diff --git a/drivers/gpu/drm/msm/disp/dpu1/dpu_crtc.c b/drivers/gpu/drm/msm/disp/dpu1/dpu_crtc.c index ce59adff06aa

[RESEND][PATCH v8 5/5] kselftests: Add dma-heap test

2019-09-06 Thread John Stultz
Add very trivial allocation and import test for dma-heaps, utilizing the vgem driver as a test importer. A good chunk of this code taken from: tools/testing/selftests/android/ion/ionmap_test.c Originally by Laura Abbott Cc: Benjamin Gaignard Cc: Sumit Semwal Cc: Liam Mark Cc: Pratik Patel

[RESEND][PATCH v8 4/5] dma-buf: heaps: Add CMA heap to dmabuf heaps

2019-09-06 Thread John Stultz
This adds a CMA heap, which allows userspace to allocate a dma-buf of contiguous memory out of a CMA region. This code is an evolution of the Android ION implementation, so thanks to its original author and maintainters: Benjamin Gaignard, Laura Abbott, and others! Cc: Laura Abbott Cc: Benjami

[RESEND][PATCH v8 3/5] dma-buf: heaps: Add system heap to dmabuf heaps

2019-09-06 Thread John Stultz
This patch adds system heap to the dma-buf heaps framework. This allows applications to get a page-allocator backed dma-buf for non-contiguous memory. This code is an evolution of the Android ION implementation, so thanks to its original authors and maintainters: Rebecca Schultz Zavin, Colin Cr

[RESEND][PATCH v8 2/5] dma-buf: heaps: Add heap helpers

2019-09-06 Thread John Stultz
Add generic helper dmabuf ops for dma heaps, so we can reduce the amount of duplicative code for the exported dmabufs. This code is an evolution of the Android ION implementation, so thanks to its original authors and maintainters: Rebecca Schultz Zavin, Colin Cross, Laura Abbott, and others! C

[RESEND][PATCH v8 1/5] dma-buf: Add dma-buf heaps framework

2019-09-06 Thread John Stultz
From: "Andrew F. Davis" This framework allows a unified userspace interface for dma-buf exporters, allowing userland to allocate specific types of memory for use in dma-buf sharing. Each heap is given its own device node, which a user can allocate a dma-buf fd from using the DMA_HEAP_IOC_ALLOC.

[RESEND][PATCH v8 0/5] DMA-BUF Heaps (destaging ION)

2019-09-06 Thread John Stultz
Here is yet another pass at the dma-buf heaps patchset Andrew and I have been working on which tries to destage a fair chunk of ION functionality. The patchset implements per-heap devices which can be opened directly and then an ioctl is used to allocate a dmabuf from the heap. The interface is s

Re: [PATCH] fbdev/sa1100fb: Remove even more dead code

2019-09-06 Thread Daniel Vetter
On Fri, Sep 06, 2019 at 05:13:00PM +0200, Arnd Bergmann wrote: > This function lost its only call site as part of > earlier dead code removal, so remove it as well: > > drivers/video/fbdev/sa1100fb.c:975:21: error: unused function > 'sa1100fb_min_dma_period' [-Werror,-Wunused-function] > > Fixes

Re: [PATCH v4 0/4] Implement lazy unmapping for GEM VRAM buffers

2019-09-06 Thread Daniel Vetter
On Fri, Sep 06, 2019 at 02:20:52PM +0200, Thomas Zimmermann wrote: > Generic fbdev emulation maps and unmaps the console BO for updating it's > content from the shadow buffer. If this involves an actual mapping > operation (instead of reusing an existing mapping), lots of debug messages > may be pr

Re: [PATCH] drm/blend: Define the direction of Z position values

2019-09-06 Thread Daniel Vetter
On Fri, Sep 06, 2019 at 04:26:15PM +0100, Daniel Stone wrote: > On Fri, 6 Sep 2019 at 16:19, Daniel Vetter wrote: > > On Fri, Sep 6, 2019 at 4:45 PM Daniel Vetter wrote: > > > We forgot that. > > > > > > Proof is the one igt testcase we have: > > > > > > https://gitlab.freedesktop.org/drm/igt-gpu

Re: [PATCH] fbdev: matrox: make array wtst_xlat static const, makes object smaller

2019-09-06 Thread Ville Syrjälä
On Fri, Sep 06, 2019 at 07:11:14PM +0100, Colin King wrote: > From: Colin Ian King > > Don't populate the array wtst_xlat on the stack but instead make it > static const. Makes the object code smaller by 89 bytes. > > Before: >text data bss dec hex filename > 14347

[PATCH] fbdev: matrox: make array wtst_xlat static const, makes object smaller

2019-09-06 Thread Colin King
From: Colin Ian King Don't populate the array wtst_xlat on the stack but instead make it static const. Makes the object code smaller by 89 bytes. Before: textdata bss dec hex filename 14347 840 0 151873b53 fbdev/matrox/matroxfb_misc.o After: textdata

[PATCH] mm, notifier: Fix early return case for new lockdep annotations

2019-09-06 Thread Daniel Vetter
I missed that when extending the lockdep annotations to the nonblocking case. I missed this while testing since in the i915 mmu notifiers is hitting a nice lockdep splat already before the point of going into oom killer mode :-/ Reported-by: syzbot+aaedc50d99a03250f...@syzkaller.appspotmail.com F

[Bug 110659] pageflipping seems to cause jittering on mouse input when running Hitman 2 in Wine/DXVK with amdgpu.dc=1

2019-09-06 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=110659 --- Comment #75 from tempel.jul...@gmail.com --- Is it possible that Wine or the affected programs in Wine are the clients that are at fault for this? As it happens with my Arch Plasma setup and also a fresh Fedora Gnome installation, it seems im

Re: [PATCH v2] drm/connector: Allow max possible encoders to attach to a connector

2019-09-06 Thread Souza, Jose
On Fri, 2019-09-06 at 14:27 +0300, Ville Syrjälä wrote: > On Thu, Sep 05, 2019 at 02:09:27PM -0700, José Roberto de Souza > wrote: > > From: Dhinakaran Pandiyan > > > > Currently we restrict the number of encoders that can be linked to > > a connector to 3, increase it to match the maximum number

possible deadlock in __mmu_notifier_invalidate_range_end

2019-09-06 Thread syzbot
Hello, syzbot found the following crash on: HEAD commit:6d028043 Add linux-next specific files for 20190830 git tree: linux-next console output: https://syzkaller.appspot.com/x/log.txt?x=16cbf22a60 kernel config: https://syzkaller.appspot.com/x/.config?x=82a6bec43ab0cb69 dashboard

[Bug 111236] VA-API radeonsi SIGSEGV __memmove_avx_unaligned

2019-09-06 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=111236 --- Comment #10 from Michel Dänzer --- (In reply to Julien Isorce from comment #9) > gst-launch-1.0 filesrc location=test.mp4 ! qtdemux ! h264parse ! > vaapih264dec ! vaapipostproc ! videoconvert ! ximagesink > > (with and without vaapipostpro

[Bug 111021] [kernel >=5.2.x][amdgpu][CIK] BUG: KASAN: null-ptr-deref in amdgpu_ib_schedule+0x82/0x790 [amdgpu]

2019-09-06 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=111021 erhar...@mailbox.org changed: What|Removed |Added Attachment #144933|0 |1 is obsolete|

[Bug 111021] [kernel >=5.2.x][amdgpu][CIK] BUG: KASAN: null-ptr-deref in amdgpu_ib_schedule+0x82/0x790 [amdgpu]

2019-09-06 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=111021 erhar...@mailbox.org changed: What|Removed |Added Attachment #144932|0 |1 is obsolete|

[PATCH] omapdrm/dss: Use PTR_ERR_OR_ZERO() in four functions

2019-09-06 Thread Markus Elfring
From: Markus Elfring Date: Fri, 6 Sep 2019 18:40:48 +0200 Simplify these function implementations by using a known function. This issue was detected by using the Coccinelle software. Signed-off-by: Markus Elfring --- drivers/gpu/drm/omapdrm/dss/hdmi4.c | 6 +- drivers/gpu/drm/omapdrm

[Bug 111021] [kernel >=5.2.x][amdgpu][CIK] BUG: KASAN: null-ptr-deref in amdgpu_ib_schedule+0x82/0x790 [amdgpu]

2019-09-06 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=111021 erhar...@mailbox.org changed: What|Removed |Added Summary|[kernel 5.2.1][amdgpu][CIK] |[kernel |BUG: K

[Bug 110659] pageflipping seems to cause jittering on mouse input when running Hitman 2 in Wine/DXVK with amdgpu.dc=1

2019-09-06 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=110659 --- Comment #74 from Nicholas Kazlauskas --- (In reply to Michel Dänzer from comment #73) > Looks like some client repeatedly calls XForceScreenSaver (probably to > prevent the monitors from blanking), which results in the DPMS property > gettin

[Bug 110659] pageflipping seems to cause jittering on mouse input when running Hitman 2 in Wine/DXVK with amdgpu.dc=1

2019-09-06 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=110659 --- Comment #73 from Michel Dänzer --- Looks like some client repeatedly calls XForceScreenSaver (probably to prevent the monitors from blanking), which results in the DPMS property getting re-set over and over. Nicholas, maybe the kernel could

[Bug 111236] VA-API radeonsi SIGSEGV __memmove_avx_unaligned

2019-09-06 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=111236 --- Comment #9 from Julien Isorce --- Hi Michel, nice catch! Instead of using totem which has other issues can you try: gst-launch-1.0 filesrc location=test.mp4 ! qtdemux ! h264parse ! vaapih264dec ! vaapipostproc ! videoconvert ! ximagesink

Re: [PATCH] drm/modes: Make the whitelist more const

2019-09-06 Thread Maxime Ripard
On Fri, Sep 06, 2019 at 10:56:10AM +0300, Jani Nikula wrote: > On Fri, 06 Sep 2019, Maxime Ripard wrote: > > The commit 3764137906a5 ("drm/modes: Introduce a whitelist for the named > > modes") introduced a whitelist in the named modes lookup code in order to > > be a bit more robust. > > > > Howe

[pull] drm/msm: msm-next for 5.4

2019-09-06 Thread Rob Clark
Hi Dave, This time around: + move msm8998 (snapdragon 835) display support + dpu fixes/cleanup + better async commit support for cursor updates (for dpu for now, I'll add mdp5 and possibly mdp4 once the movers deliver boxes full of my older hardware, so for v5.5) The following change

Re: [git pull] drm fixes for 5.3-rc8 (or final)

2019-09-06 Thread pr-tracker-bot
The pull request you sent on Fri, 6 Sep 2019 17:18:34 +1000: > git://anongit.freedesktop.org/drm/drm tags/drm-fixes-2019-09-06 has been merged into torvalds/linux.git: https://git.kernel.org/torvalds/c/08d433d8121598f7c2a45f3461c534746b1ed05b Thank you! -- Deet-doot-dot, I am a bot. https://ko

Re: [PATCH RFC v4 00/16] new cgroup controller for gpu/drm subsystem

2019-09-06 Thread Tejun Heo
Hello, Daniel. On Fri, Sep 06, 2019 at 05:34:16PM +0200, Daniel Vetter wrote: > > Hmm... what'd be the fundamental difference from slab or socket memory > > which are handled through memcg? Is system memory used by GPUs have > > further global restrictions in addition to the amount of physical >

Re: [PATCH RFC v4 01/16] drm: Add drm_minor_for_each

2019-09-06 Thread Tejun Heo
Hello, Daniel. On Fri, Sep 06, 2019 at 05:36:02PM +0200, Daniel Vetter wrote: > Block devices are a great example I think. How do you handle the > partitions on that? For drm we also have a main minor interface, and cgroup IO controllers only distribute hardware IO capacity and are blind to parti

Re: [PATCH RFC v4 01/16] drm: Add drm_minor_for_each

2019-09-06 Thread Daniel Vetter
On Fri, Sep 6, 2019 at 5:29 PM Tejun Heo wrote: > > Hello, > > On Wed, Sep 04, 2019 at 10:54:34AM +0200, Daniel Vetter wrote: > > Anyway, I don't think reusing the drm_minor registration makes sense, > > since we want to be on the drm_device, not on the minor. Which is a bit > > awkward for cgroup

Re: [PATCH RFC v4 00/16] new cgroup controller for gpu/drm subsystem

2019-09-06 Thread Daniel Vetter
On Fri, Sep 6, 2019 at 5:23 PM Tejun Heo wrote: > > Hello, Daniel. > > On Tue, Sep 03, 2019 at 09:48:22PM +0200, Daniel Vetter wrote: > > I think system memory separate from vram makes sense. For one, vram is > > like 10x+ faster than system memory, so we definitely want to have > > good control o

[PATCH] staging: fbtft: make several arrays static const, makes object smaller

2019-09-06 Thread Colin King
From: Colin Ian King Don't populate the arrays on the stack but instead make them static const. Makes the object code smaller by 1329 bytes. Before: textdata bss dec hex filename 55811488 6471331bdd drivers/staging/fbtft/fb_hx8340bn.o 54441264

Re: [PATCH RFC v4 01/16] drm: Add drm_minor_for_each

2019-09-06 Thread Tejun Heo
Hello, On Wed, Sep 04, 2019 at 10:54:34AM +0200, Daniel Vetter wrote: > Anyway, I don't think reusing the drm_minor registration makes sense, > since we want to be on the drm_device, not on the minor. Which is a bit > awkward for cgroups, which wants to identify devices using major.minor > pairs.

Re: [PATCH] drm/blend: Define the direction of Z position values

2019-09-06 Thread Daniel Stone
On Fri, 6 Sep 2019 at 16:19, Daniel Vetter wrote: > On Fri, Sep 6, 2019 at 4:45 PM Daniel Vetter wrote: > > We forgot that. > > > > Proof is the one igt testcase we have: > > > > https://gitlab.freedesktop.org/drm/igt-gpu-tools/blob/master/tests/kms_atomic.c#L280 > > > > While at it also document

Re: [PATCH] drm/panfrost: Fix regulator_get_optional() misuse

2019-09-06 Thread Steven Price
On 04/09/2019 13:30, Mark Brown wrote: > The panfrost driver requests a supply using regulator_get_optional() > but both the name of the supply and the usage pattern suggest that it is > being used for the main power for the device and is not at all optional > for the device for function, there is

Re: [PATCH RFC v4 00/16] new cgroup controller for gpu/drm subsystem

2019-09-06 Thread Tejun Heo
Hello, Daniel. On Tue, Sep 03, 2019 at 09:48:22PM +0200, Daniel Vetter wrote: > I think system memory separate from vram makes sense. For one, vram is > like 10x+ faster than system memory, so we definitely want to have > good control on that. But maybe we only want one vram bucket overall > for t

Re: [PATCH] drm/blend: Define the direction of Z position values

2019-09-06 Thread Daniel Vetter
On Fri, Sep 6, 2019 at 4:45 PM Daniel Vetter wrote: > > We forgot that. > > Proof is the one igt testcase we have: > > https://gitlab.freedesktop.org/drm/igt-gpu-tools/blob/master/tests/kms_atomic.c#L280 > > While at it also document that we have immutable zpos properties in > some cases. > > Repo

[PATCH] fbdev/sa1100fb: Remove even more dead code

2019-09-06 Thread Arnd Bergmann
This function lost its only call site as part of earlier dead code removal, so remove it as well: drivers/video/fbdev/sa1100fb.c:975:21: error: unused function 'sa1100fb_min_dma_period' [-Werror,-Wunused-function] Fixes: 390e5de11284 ("fbdev/sa1100fb: Remove dead code") Signed-off-by: Arnd Bergm

[Bug 110659] pageflipping seems to cause jittering on mouse input when running Hitman 2 in Wine/DXVK with amdgpu.dc=1

2019-09-06 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=110659 --- Comment #72 from tempel.jul...@gmail.com --- Created attachment 145280 --> https://bugs.freedesktop.org/attachment.cgi?id=145280&action=edit 2nd gdb backtrace log, now with debug symbols -- You are receiving this mail because: You are the

[Bug 110659] pageflipping seems to cause jittering on mouse input when running Hitman 2 in Wine/DXVK with amdgpu.dc=1

2019-09-06 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=110659 --- Comment #71 from tempel.jul...@gmail.com --- Hope this helps: -- You are receiving this mail because: You are the assignee for the bug.___ dri-devel mailing list dri-devel@lists.freedesktop.org ht

Re: [PATCH] drm/panfrost: Fix regulator_get_optional() misuse

2019-09-06 Thread Steven Price
On 06/09/2019 11:55, Mark Brown wrote: [...] >>> However you're probably better off hiding all this stuff with the >>> generic OPP code rather than open coding it - this already has much >>> better handling for this, it supports voltage ranges rather than single >>> voltages and optional regulators

[PATCH] drm/blend: Define the direction of Z position values

2019-09-06 Thread Daniel Vetter
We forgot that. Proof is the one igt testcase we have: https://gitlab.freedesktop.org/drm/igt-gpu-tools/blob/master/tests/kms_atomic.c#L280 While at it also document that we have immutable zpos properties in some cases. Reported-by: Pekka Paalanen Cc: Pekka Paalanen Reviewed-by: Pekka Paalane

Re: [PATCH v3] drm: rcar-du: kms: Expand comment in vsps parsing routine

2019-09-06 Thread Laurent Pinchart
Hi Jacopo, On Fri, Sep 06, 2019 at 03:50:12PM +0200, Jacopo Mondi wrote: > Expand comment in the 'vsps' parsing routine to specify the LIF > channel index defaults to 0 in case the second cell of the property > is not specified to remain compatible with older DT bindings. > > Reviewed-by: Laurent

Re: [PATCH] drm: Use EOPNOTSUPP, not ENOTSUPP

2019-09-06 Thread Daniel Vetter
On Wed, Sep 04, 2019 at 10:05:09PM +0200, Daniel Vetter wrote: > On Wed, Sep 4, 2019 at 9:58 PM Souza, Jose wrote: > > > > On Wed, 2019-09-04 at 16:39 +0200, Daniel Vetter wrote: > > > - it's what we recommend in our docs: > > > > > > https://dri.freedesktop.org/docs/drm/gpu/drm-uapi.html#recommen

Re: [v4 2/2] drm/arm/mali-dp: Add display QoS interface configuration for Mali DP500

2019-09-06 Thread Liviu Dudau
Hi Wen, On Thu, Aug 22, 2019 at 10:11:35AM +0800, Wen He wrote: > Configure the display Quality of service (QoS) levels priority if the > optional property node "arm,malidp-aqros-value" is defined in DTS file. > > QoS signaling using AQROS and AWQOS AXI interface signals, the AQROS is > driven fr

Re: [PATCH v3 2/3] drm/vram: Add infrastructure for move_notify()

2019-09-06 Thread Thomas Zimmermann
Hi Am 06.09.19 um 15:05 schrieb Daniel Vetter: > On Fri, Sep 6, 2019 at 12:24 PM Thomas Zimmermann wrote: >> >> Hi >> >> Am 06.09.19 um 11:28 schrieb Daniel Vetter: >>> On Fri, Sep 06, 2019 at 10:52:13AM +0200, Thomas Zimmermann wrote: This patch prepares VRAM helpers for lazy unmapping of b

Re: [PATCH 2/2] drm/etnaviv: print MMU exception cause

2019-09-06 Thread Christian Gmeiner
Am Fr., 6. Sept. 2019 um 12:55 Uhr schrieb Lucas Stach : > > On Fr, 2019-09-06 at 12:03 +0200, Christian Gmeiner wrote: > > Might be useful when debugging MMU exceptions. > > > > Signed-off-by: Christian Gmeiner > > --- > > drivers/gpu/drm/etnaviv/etnaviv_gpu.c | 26 > > ++

[PATCH v4 1/9] dt-bindings: display: renesas,cmm: Add R-Car CMM documentation

2019-09-06 Thread Jacopo Mondi
Add device tree bindings documentation for the Renesas R-Car Display Unit Color Management Module. CMM is the image enhancement module available on each R-Car DU video channel on R-Car Gen2 and Gen3 SoCs (V3H and V3M excluded). Signed-off-by: Jacopo Mondi --- .../bindings/display/renesas,cmm.ya

[PATCH v4 2/9] dt-bindings: display, renesas,du: Document cmms property

2019-09-06 Thread Jacopo Mondi
Document the newly added 'cmms' property which accepts a list of phandle and channel index pairs that point to the CMM units available for each Display Unit output video channel. Signed-off-by: Jacopo Mondi Reviewed-by: Laurent Pinchart --- Documentation/devicetree/bindings/display/renesas,du.t

[Bug 110659] pageflipping seems to cause jittering on mouse input when running Hitman 2 in Wine/DXVK with amdgpu.dc=1

2019-09-06 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=110659 --- Comment #70 from Michel Dänzer --- (In reply to tempel.julian from comment #68) > I did it, but it stopped after hitting the two breakpoints the first time > without me having moved the mouse at all. I suppose this isn't enough? Would > it b

[PATCH v4 3/9] drm: rcar-du: Add support for CMM

2019-09-06 Thread Jacopo Mondi
Add a driver for the R-Car Display Unit Color Correction Module. In most of Gen3 SoCs, each DU output channel is provided with a CMM unit to perform image enhancement and color correction. Add support for CMM through a driver that supports configuration of the 1-dimensional LUT table. More advanc

[PATCH v4 5/9] drm: rcar-du: kms: Initialize CMM instances

2019-09-06 Thread Jacopo Mondi
Implement device tree parsing to collect the available CMM instances described by the 'renesas,cmms' property. Associate CMMs with CRTCs and store a mask of active CMMs in the DU group for later enablement. Enforce the probe and suspend/resume ordering of DU and CMM by creating a stateless device

[PATCH v4 4/9] drm: rcar-du: Claim CMM support for Gen3 SoCs

2019-09-06 Thread Jacopo Mondi
Add CMM to the list of supported features for Gen3 SoCs that provide it: - R8A7795 - R8A7796 - R8A77965 - R8A7799x Leave R8A77970 out as V3M and V3H are the only Gen3 SoCs that do not support CMM. Reviewed-by: Ulrich Hecht Reviewed-by: Laurent Pinchart Signed-off-by: Jacopo Mondi --- drivers/

[PATCH v4 7/9] drm: rcar-du: crtc: Register GAMMA_LUT properties

2019-09-06 Thread Jacopo Mondi
Enable the GAMMA_LUT KMS property using the framework helpers to register the property and set the associated gamma table maximum size. Reviewed-by: Ulrich Hecht Reviewed-by: Laurent Pinchart Signed-off-by: Jacopo Mondi --- drivers/gpu/drm/rcar-du/rcar_du_crtc.c | 4 1 file changed, 4 ins

[PATCH v4 0/9 drm: rcar-du: Add Color Management Module (CMM)

2019-09-06 Thread Jacopo Mondi
[ Ugh, sorry for the double sending, but I forgot --cc-cover to git-send email and the series has not been delivered to the mailing lists. Sorry about that. ] Hello, new iteration of CMM support, with quite a few changes compared to v3: References: A reference to the v1 cover letter, with som

[PATCH v4 9/9] arm64: dts: renesas: Add CMM units to Gen3 SoCs

2019-09-06 Thread Jacopo Mondi
Add CMM units to Renesas R-Car Gen3 SoC that support it, and reference them from the Display Unit they are connected to. Sort the 'vsps' and 'renesas,cmm' entries in the DU unit consistently in all the involved DTS. Signed-off-by: Jacopo Mondi --- arch/arm64/boot/dts/renesas/r8a7795.dtsi | 40

[PATCH v4 6/9] drm: rcar-du: crtc: Enable and disable CMMs

2019-09-06 Thread Jacopo Mondi
Enable/disable the CMM associated with a CRTC at CRTC start and stop time and enable the CMM unit through the Display Extensional Functions register at group setup time. Reviewed-by: Ulrich Hecht Reviewed-by: Laurent Pinchart Signed-off-by: Jacopo Mondi --- drivers/gpu/drm/rcar-du/rcar_du_crtc

[PATCH v4 8/9] drm: rcar-du: kms: Update CMM in atomic commit tail

2019-09-06 Thread Jacopo Mondi
Update CMM settings at in the atomic commit tail helper method. The CMM is updated with new gamma values provided to the driver in the GAMMA_LUT blob property. When resuming from system suspend, the DU driver is responsible for reprogramming and enabling the CMM unit if it was in use at the time t

[PATCH v3] drm: rcar-du: kms: Expand comment in vsps parsing routine

2019-09-06 Thread Jacopo Mondi
Expand comment in the 'vsps' parsing routine to specify the LIF channel index defaults to 0 in case the second cell of the property is not specified to remain compatible with older DT bindings. Reviewed-by: Laurent Pinchart Signed-off-by: Jacopo Mondi --- This trivial change is a leftover from a

[PATCH v4 0/9 drm: rcar-du: Add Color Management Module (CMM)

2019-09-06 Thread Jacopo Mondi
Hello, new iteration of CMM support, with quite a few changes compared to v3: References: A reference to the v1 cover letter, with some background on the CMM is available here: https://lkml.org/lkml/2019/6/6/583 v2: https://lore.kernel.org/linux-renesas-soc/20190706140746.29132-10-jacopo+rene...@j

Re: [PATCH v4 3/7] drm: Add DisplayPort colorspace property

2019-09-06 Thread Ilia Mirkin
On Fri, Sep 6, 2019 at 7:43 AM Ville Syrjälä wrote: > > On Fri, Sep 06, 2019 at 11:31:55AM +, Shankar, Uma wrote: > > > > > > >-Original Message- > > >From: Ilia Mirkin > > >Sent: Tuesday, September 3, 2019 6:12 PM > > >To: Mun, Gwan-gyeong > > >Cc: Intel Graphics Development ; Shank

Re: [PATCH v4 05/17] drm: add mmap() to drm_gem_object_funcs

2019-09-06 Thread Daniel Vetter
On Fri, Sep 6, 2019 at 2:13 PM Gerd Hoffmann wrote: > > Hi, > > > I think if we do an mmap callback, it should replace all the mmap handling > > (except the drm_gem_object_get) that drm_gem_mmap_obj does. So maybe > > something like the below: > > [ snip ] > > > Since I remember quite a few disc

Re: [PATCH v3 2/3] drm/vram: Add infrastructure for move_notify()

2019-09-06 Thread Daniel Vetter
On Fri, Sep 6, 2019 at 12:24 PM Thomas Zimmermann wrote: > > Hi > > Am 06.09.19 um 11:28 schrieb Daniel Vetter: > > On Fri, Sep 06, 2019 at 10:52:13AM +0200, Thomas Zimmermann wrote: > >> This patch prepares VRAM helpers for lazy unmapping of buffer objects. > >> > >> Signed-off-by: Thomas Zimmerm

Re: [PATCH] drm/panfrost: Prevent race when handling page fault

2019-09-06 Thread Steven Price
On 06/09/2019 12:10, Rob Herring wrote: > On Thu, Sep 5, 2019 at 1:11 PM Steven Price wrote: >> >> When handling a GPU page fault addr_to_drm_mm_node() is used to >> translate the GPU address to a buffer object. However it is possible for >> the buffer object to be freed after the function has ret

[PATCH v4 3/4] drm/vram: Add infrastructure for move_notify()

2019-09-06 Thread Thomas Zimmermann
This patch prepares VRAM helpers for lazy unmapping of buffer objects. Signed-off-by: Thomas Zimmermann --- drivers/gpu/drm/drm_vram_mm_helper.c | 12 include/drm/drm_vram_mm_helper.h | 4 2 files changed, 16 insertions(+) diff --git a/drivers/gpu/drm/drm_vram_mm_helper.c

[PATCH v4 0/4] Implement lazy unmapping for GEM VRAM buffers

2019-09-06 Thread Thomas Zimmermann
Generic fbdev emulation maps and unmaps the console BO for updating it's content from the shadow buffer. If this involves an actual mapping operation (instead of reusing an existing mapping), lots of debug messages may be printed, such as x86/PAT: Overlap at 0xd000-0xd100 x86/PAT: rese

[PATCH v4 2/4] drm/vram: Acquire lock only once per call to vmap()/vunmap()

2019-09-06 Thread Thomas Zimmermann
The implementation of vmap() is a combined pin() and kmap(). As both functions share the same lock, we can make vmap() slightly faster by acquiring the lock only once for both operations. Same for the inverse, vunmap(). Signed-off-by: Thomas Zimmermann --- drivers/gpu/drm/drm_gem_vram_helper.c |

[PATCH v4 1/4] drm/vram: Add kmap ref-counting to GEM VRAM objects

2019-09-06 Thread Thomas Zimmermann
The kmap and kunmap operations of GEM VRAM buffers can now be called in interleaving pairs. The first call to drm_gem_vram_kmap() maps the buffer's memory to kernel address space and the final call to drm_gem_vram_kunmap() unmaps the memory. Intermediate calls to these functions increment or decrem

[PATCH v4 4/4] drm/vram: Implement lazy unmapping for GEM VRAM buffers

2019-09-06 Thread Thomas Zimmermann
Frequent mapping and unmapping a buffer object adds overhead for modifying the page table and creates debug output. Unmapping a buffer is only required when the memory manager evicts the buffer from its current location. v4: * WARN_ON if buffer is still mapped during BO cleanup Signed-off

Re: [PATCH v4 05/17] drm: add mmap() to drm_gem_object_funcs

2019-09-06 Thread Gerd Hoffmann
Hi, > I think if we do an mmap callback, it should replace all the mmap handling > (except the drm_gem_object_get) that drm_gem_mmap_obj does. So maybe > something like the below: [ snip ] > Since I remember quite a few discussions where the default vma flag > wrangling we're doing is seriousl

[Bug 110659] pageflipping seems to cause jittering on mouse input when running Hitman 2 in Wine/DXVK with amdgpu.dc=1

2019-09-06 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=110659 --- Comment #69 from tempel.jul...@gmail.com --- Created attachment 145278 --> https://bugs.freedesktop.org/attachment.cgi?id=145278&action=edit 1st gdb log -- You are receiving this mail because: You are the assignee for the bug.

[Bug 110659] pageflipping seems to cause jittering on mouse input when running Hitman 2 in Wine/DXVK with amdgpu.dc=1

2019-09-06 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=110659 --- Comment #68 from tempel.jul...@gmail.com --- I did it, but it stopped after hitting the two breakpoints the first time without me having moved the mouse at all. I suppose this isn't enough? Would it be possible to provide me with a short hint

Re: [PATCH v4 3/7] drm: Add DisplayPort colorspace property

2019-09-06 Thread Ville Syrjälä
On Fri, Sep 06, 2019 at 11:31:55AM +, Shankar, Uma wrote: > > > >-Original Message- > >From: Ilia Mirkin > >Sent: Tuesday, September 3, 2019 6:12 PM > >To: Mun, Gwan-gyeong > >Cc: Intel Graphics Development ; Shankar, > >Uma > >; dri-devel > >Subject: Re: [PATCH v4 3/7] drm: Add D

RE: [PATCH v4 3/7] drm: Add DisplayPort colorspace property

2019-09-06 Thread Shankar, Uma
>-Original Message- >From: Ilia Mirkin >Sent: Tuesday, September 3, 2019 6:12 PM >To: Mun, Gwan-gyeong >Cc: Intel Graphics Development ; Shankar, Uma >; dri-devel >Subject: Re: [PATCH v4 3/7] drm: Add DisplayPort colorspace property > >So how would this work with a DP++ connector? Shou

Re: [PATCH v2] drm/connector: Allow max possible encoders to attach to a connector

2019-09-06 Thread Ville Syrjälä
On Thu, Sep 05, 2019 at 02:09:27PM -0700, José Roberto de Souza wrote: > From: Dhinakaran Pandiyan > > Currently we restrict the number of encoders that can be linked to > a connector to 3, increase it to match the maximum number of encoders > that can be initialized(32). > > To more effiently d

Re: [PATCH v3 3/3] drm/vram: Implement lazy unmapping for GEM VRAM buffers

2019-09-06 Thread Gerd Hoffmann
On Fri, Sep 06, 2019 at 12:37:47PM +0200, Thomas Zimmermann wrote: > Hi > > Am 06.09.19 um 11:39 schrieb Gerd Hoffmann: > >> +void drm_gem_vram_bo_driver_move_notify(struct ttm_buffer_object *bo, > >> + bool evict, > >> + struct ttm

Re: [PATCH] drm/panfrost: Prevent race when handling page fault

2019-09-06 Thread Rob Herring
On Thu, Sep 5, 2019 at 1:11 PM Steven Price wrote: > > When handling a GPU page fault addr_to_drm_mm_node() is used to > translate the GPU address to a buffer object. However it is possible for > the buffer object to be freed after the function has returned resulting > in a use-after-free of the B

Re: [PATCH V4] drm: Add LTTPR defines for DP 1.4a

2019-09-06 Thread Ville Syrjälä
On Thu, Sep 05, 2019 at 07:51:59PM +, Siqueira, Rodrigo wrote: > Hi Ville, > > First of all, thank you very much for the review. > > I added some comments below. > > On 09/05, Wentland, Harry wrote: > > On 2019-09-05 1:29 p.m., Ville Syrjälä wrote: > > > On Wed, Sep 04, 2019 at 07:02:18PM +0

  1   2   >