https://bugzilla.kernel.org/show_bug.cgi?id=204181
--- Comment #45 from Tom Seewald (tseew...@gmail.com) ---
> Unfortunately, it didn't fix the page flip-triggered dereference for me. Do
> you have page flip related errors in Xorg log on "modesetting" X driver ?
> With and without it ?
I don't be
On 26/08/2019 00:01, Daniel Vetter wrote:
On Fri, Aug 23, 2019 at 8:53 PM Jason Ekstrand wrote:
On Thu, Aug 22, 2019 at 5:28 PM Lionel Landwerlin
wrote:
On 22/08/2019 21:24, Jason Ekstrand wrote:
On Thu, Aug 22, 2019 at 9:55 AM Lionel Landwerlin
wrote:
We've added a set of new APIs to m
https://bugs.freedesktop.org/show_bug.cgi?id=110674
--- Comment #121 from ReddestDream ---
Some observations:
1. Nothing at all seems to be up with cur_speed and cur_width. They get set
several times in a row in both runs, but the values are all the same in both.
2. I can't really see anything
https://bugs.freedesktop.org/show_bug.cgi?id=110674
--- Comment #120 from ReddestDream ---
Created attachment 145159
--> https://bugs.freedesktop.org/attachment.cgi?id=145159&action=edit
DebugAMDiGPU
Also here is the AMD + iGPU one.
--
You are receiving this mail because:
You are the assigne
https://bugs.freedesktop.org/show_bug.cgi?id=110674
--- Comment #119 from ReddestDream ---
Created attachment 145158
--> https://bugs.freedesktop.org/attachment.cgi?id=145158&action=edit
DebugAMD2Monitors
>I don't think I have time to try it today but if anyone is recompiling the
>code adding
https://bugzilla.kernel.org/show_bug.cgi?id=204611
Alex Deucher (alexdeuc...@gmail.com) changed:
What|Removed |Added
CC||alexdeuc...@gmail.c
Hi all,
Today's linux-next merge of the drm tree got a conflict in:
drivers/gpu/drm/mediatek/mtk_drm_drv.c
between commit:
7837951a12fd ("drm/mediatek: include dma-mapping header")
from Linus' tree and commit:
9aef5867c86c ("drm/mediatek: drop use of drmP.h")
from the drm tree.
I fixe
Hi all,
Today's linux-next merge of the drm tree got a conflict in:
drivers/gpu/drm/arm/display/komeda/komeda_dev.c
between commit:
51a44a28eefd ("drm/komeda: Add missing of_node_get() call")
from the drm-misc-fixes tree and commit:
8965ad8433ea ("drm/komeda: Enable dual-link support")
https://bugs.freedesktop.org/show_bug.cgi?id=110865
Alex Deucher changed:
What|Removed |Added
Attachment #145136|0 |1
is obsolete|
Hi Guido,
On Jo, 2019-08-22 at 19:03 +0200, Guido Günther wrote:
> Hi Robert,
> thanks for your comments! Most of this make sense, i have some
> comments
> inline below (mostly since I only have access to the imx8mq reference
> manual but not to the any NWL IP docs):
>
> On Thu, Aug 22, 2019 at 0
From: Dariusz Marcinkiewicz
Until now the connector info API was a kernel-internal API only.
This moves it to the public API and adds the new ioctl to retrieve
this information.
Signed-off-by: Dariusz Marcinkiewicz
Signed-off-by: Hans Verkuil
---
drivers/media/cec/cec-adap.c | 2 ++
drivers/
From: Dariusz Marcinkiewicz
Fill in the connector info, allowing userspace to associate
the CEC device with the drm connector.
Tested on a Raspberry Pi 3B.
Signed-off-by: Dariusz Marcinkiewicz
Signed-off-by: Hans Verkuil
Tested-by: Hans Verkuil
---
drivers/gpu/drm/vc4/vc4_hdmi.c | 13 ++
When building mtk_drm_drv.o the following build error is seen:
../drivers/gpu/drm/mediatek/mtk_drm_drv.c: In function ‘mtk_drm_kms_init’:
../drivers/gpu/drm/mediatek/mtk_drm_drv.c:291:8: error: implicit declaration of
function ‘dma_set_max_seg_size’; did you mean ‘drm_rect_adjust_size’?
[-Werror
On Sun, 25 Aug 2019 04:28:01 -0700 Mikhail Gavrilov wrote:
> Hi folks,
> I left unblocked gnome-shell at noon, and when I returned at the
> evening I discovered than monitor not sleeping and show open gnome
> activity. At first, I thought that some application did not let fall
> asleep the system.
Set the connector info to help userspace associate the CEC adapter
with the HDMI connector.
This required that the cec initialization and unregistering the
CEC adapter takes place in the bridge attach and detach ops.
Tested on an R-Car Koelsch board.
Signed-off-by: Hans Verkuil
Tested-by: Hans
From: Rob Clark
Add support to restore the secure configuration for qcm_scm-32.c. This
is needed by the On Chip MEMory (OCMEM) that is present on some
Snapdragon devices.
Signed-off-by: Rob Clark
[masn...@onstation.org: ported to latest kernel; set ctx_bank_num to
spare parameter.]
Signed-off-
If cec_notifier_cec_adap_unregister() is called before
cec_unregister_adapter() then everything is OK (and this is the
case today). But if it is the other way around, then
cec_notifier_unregister() is called first, and that doesn't
set n->cec_adap to NULL.
So if e.g. cec_notifier_set_phys_addr() i
Add ocmem driver that's needed for some a3xx and a4xx based systems.
Signed-off-by: Brian Masney
---
Changes since v6:
- None
Changes since v5:
- None
This patch was introduced in v5.
arch/arm/configs/qcom_defconfig | 1 +
1 file changed, 1 insertion(+)
diff --git a/arch/arm/configs/qcom_def
hi maxim,
On Tue, Aug 20, 2019 at 5:00 PM Maxime Ripard wrote:
>
> Hi,
>
> On Mon, Aug 19, 2019 at 09:20:00PM +0200, Thomas Graichen wrote:
> > On Mon, Aug 19, 2019 at 8:54 PM Jernej Škrabec
> > wrote:
> > >
> > > +CC: Thomas Graichen
> > >
> > > Dne ponedeljek, 17. junij 2019 ob 16:51:32 CEST
In file included from ./include/linux/bitmap.h:9,
from ./include/linux/cpumask.h:12,
from ./arch/x86/include/asm/cpumask.h:5,
from ./arch/x86/include/asm/msr.h:11,
from ./arch/x86/include/asm/processor.h:21,
from .
Three drivers were not updated in Dariusz' series:
https://patchwork.linuxtv.org/project/linux-media/list/?series=573
This series adds connector info support for those three.
Note that the sun4i patch has this patch as a prerequisite:
https://patchwork.linuxtv.org/project/linux-media/list/?seri
Set the connector info for the CEC adapter. This helps
userspace to associate the CEC device with the HDMI connector.
Tested on a Cubieboard.
Signed-off-by: Hans Verkuil
Tested-by: Hans Verkuil
---
drivers/gpu/drm/sun4i/sun4i_hdmi_enc.c | 6 --
1 file changed, 4 insertions(+), 2 deletions(
Hi!
The first patch fixes the fact that there are two items numbered "4" in
the list of fbcon options. This bug is a teenager...
The second patch extends that list with a new option that allows the
user to display any number of logos (that fits on the screen). I need it
to limit the display to on
From: Rob Clark
Add support for the OCMEM lock/unlock interface that is needed by the
On Chip MEMory (OCMEM) that is present on some Snapdragon devices.
Signed-off-by: Rob Clark
[masn...@onstation.org: ported to latest kernel; minor reformatting.]
Signed-off-by: Brian Masney
Reviewed-by: Bjorn
These two patches add the CEC connector info API.
Note that connector info is currently for drm connectors only.
In the future support for v4l2 connectors will be added as well,
once we actually know how to uniquely identify a HDMI receiver
connector.
Regards,
Hans
Dariusz Marcinkiewicz
On Thu, Aug 15, 2019 at 08:52:56PM +, Yang, Philip wrote:
> hmm_range_fault may return NULL pages because some of pfns are equal to
> HMM_PFN_NONE. This happens randomly under memory pressure. The reason is
> for swapped out page pte path, hmm_vma_handle_pte doesn't update fault
> variable from
When resuming from ACPI S3, memory leak happens in nvkm_ram_get().
This is because *pmemory points to newly allocated memory without
checking and freeing the old memory.
Here is the log showing this issue.
unreferenced object 0xa3b608c6d5c0 (size 64):
comm "kworker/u32:30", pid 934, jiffies
Document the new CEC_ADAP_G_CONNECTOR_INFO ioctl and the new
CEC_CAP_CONNECTOR_INFO capability.
Signed-off-by: Dariusz Marcinkiewicz
Co-developed-by: Hans Verkuil
[hverkuil-ci...@xs4all.nl: added CEC_CAP_CONNECTOR_INFO]
[hverkuil-ci...@xs4all.nl: added DQEVENT have_conn_info]
Signed-off-by: Hans
Probably most useful if you only want one logo regardless of how many
CPU cores you have.
Signed-off-by: Peter Rosin
---
Documentation/fb/fbcon.rst | 5 +
drivers/video/fbdev/core/fbcon.c | 7 +++
drivers/video/fbdev/core/fbmem.c | 5 -
include/linux/fb.h | 1 +
4
Hi Laurent,
Le ven. 23 août 2019 à 23:23, Laurent Pinchart
a écrit :
The ingenic driver supports DPI panels only at the moment, so hardcode
their type to DPI instead of Unknown.
Signed-off-by: Laurent Pinchart
---
Paul, as the driver has been merged in v5.3-rc1, this is a candidate
for
a
The files a3xx_gpu.c and a4xx_gpu.c have ifdefs for the OCMEM support
that was missing upstream. Add two new functions (adreno_gpu_ocmem_init
and adreno_gpu_ocmem_cleanup) that removes some duplicated code.
Signed-off-by: Brian Masney
---
Changes since v6:
- None
Changes since v5:
- None
Change
Three shall be the number thou shalt count, and the number of the
counting shall be three. Four shalt thou not count...
One! Two! Five!
Fixes: efb985f6b265 ("[PATCH] fbcon: Console Rotation - Add framebuffer console
documentation")
Signed-off-by: Peter Rosin
---
Documentation/fb/fbcon.rst | 8
This patch series adds support for Qualcomm's On Chip MEMory (OCMEM)
that is needed in order to support some a3xx and a4xx-based GPUs
upstream. This is based on Rob Clark's patch series that he submitted
in October 2015 and I am resubmitting updated patches with his
permission. See the individual p
Add device tree bindings for the On Chip Memory (OCMEM) that is present
on some Qualcomm Snapdragon SoCs.
Signed-off-by: Brian Masney
Reviewed-by: Rob Herring
---
Changes since v6:
- None
Changes since v5:
- None
Changes since v4:
- remove qcom from path in $id
Changes since v3:
- add ranges
Check if cec_s_conn_info is called with a valid cec adapter,
do nothing if it is invalid.
This makes it possible to call this function even if CEC support is
disabled in the kernel config.
Signed-off-by: Hans Verkuil
---
drivers/media/cec/cec-adap.c | 3 +++
1 file changed, 3 insertions(+)
dif
Some A3xx and A4xx Adreno GPUs do not have GMEM inside the GPU core and
must use the On Chip MEMory (OCMEM) in order to be functional. Add the
optional ocmem property to the Adreno Graphics Management Unit bindings.
Signed-off-by: Brian Masney
---
Changes since v6:
- link to gmu-sram in example
-
Hi Laurent,
On 23/08/2019 at 03:40, Laurent Pinchart wrote:
> Add a type field to the drm_panel structure to report the panel type,
> using DRM_MODE_CONNECTOR_* macros (the values that make sense are LVDS,
> eDP, DSI and DPI). This will be used to initialise the corresponding
> connector type.
Wi
The OCMEM driver handles allocation and configuration of the On Chip
MEMory that is present on some Snapdragon SoCs. Devices which have
OCMEM do not have GMEM inside the GPU core, so the GPU must instead
use OCMEM to be functional. Since the GPU is currently the only OCMEM
user with an upstream dri
While newer kbase include only the numbers of errata, older kbase
releases included one-line descriptions for each errata, which is useful
for those working on the driver. Import these descriptions. Most are
from kbase verbatim; a few I edited for clarity.
v2: Wrote a description for the workaroun
Pardon the pun, but
Reviewed-by: Alyssa Rosenzweig
(or a-b if you prefer, of course!)
On Thu, Aug 22, 2019 at 08:33:57PM -0500, Rob Herring wrote:
> Add Steven Price and Alyssa Rosenzweig as reviewers as they have been the
> primary reviewers already.
>
> Cc: Steven Price
> Cc: Alyssa Rosenzw
https://bugs.freedesktop.org/show_bug.cgi?id=110674
--- Comment #118 from ReddestDream ---
So, this is a crazy idea, but ironically I think it might be getting closer to
the truth.
Tom B. attempted reverting ad51c46eec739c18be24178a30b47801b10e0357, which was
known to cause some issue with an RX
https://bugs.freedesktop.org/show_bug.cgi?id=111481
Andre Klapper changed:
What|Removed |Added
Priority|highest |not set
--
You are receiving this mail
On Fri, Aug 23, 2019 at 8:53 PM Jason Ekstrand wrote:
>
>
> On Thu, Aug 22, 2019 at 5:28 PM Lionel Landwerlin
> wrote:
>>
>> On 22/08/2019 21:24, Jason Ekstrand wrote:
>>
>> On Thu, Aug 22, 2019 at 9:55 AM Lionel Landwerlin
>> wrote:
>>>
>>> We've added a set of new APIs to manipulate syncobjs
https://bugs.freedesktop.org/show_bug.cgi?id=110865
--- Comment #19 from Martin ---
with 70W i mean total system power-consumption of course.
This is roughly the same / a little more as with Windows. So we are on a good
path I think.
If i do
"echo low > /sys/class/drm/card0/device/power_dpm_fo
https://bugs.freedesktop.org/show_bug.cgi?id=110865
--- Comment #18 from Martin ---
Hello,
sorry that it took me that long. I was on a historic cycling event in Germany.
Your patch indeed did something.
The power consumption drops sometimes to 70W, but now both screen flicker and
produce errors
https://bugs.freedesktop.org/show_bug.cgi?id=110674
--- Comment #117 from ReddestDream ---
Created attachment 145154
--> https://bugs.freedesktop.org/attachment.cgi?id=145154&action=edit
AMDInteliGPUBoot
Also find my stable Intel iGPU + AMD Graphics config dmesg here.
--
You are receiving th
https://bugs.freedesktop.org/show_bug.cgi?id=110674
--- Comment #116 from ReddestDream ---
Created attachment 145153
--> https://bugs.freedesktop.org/attachment.cgi?id=145153&action=edit
dmesgAMD2Monitors
I've been doing a few tests. I looked into and compiled 5.3-rc5 along with
these patches,
You'll probably get a more detailed reply during the week, but for now
have a look at the "link-status" property, which was made for
precisely this situation. I think basically the idea is to ignore link
training as part of the modeset, and just return the link status
depending on the success. (And
https://bugs.freedesktop.org/show_bug.cgi?id=109534
--- Comment #7 from vanyasm...@gmail.com ---
No, sorry. Still happening with Oracle JRE, but more rarely.
--
You are receiving this mail because:
You are the assignee for the bug.___
dri-devel mailing
https://bugs.freedesktop.org/show_bug.cgi?id=109534
--- Comment #6 from vanyasm...@gmail.com ---
I've again faced with this issue on Ubuntu 18.04 with Mesa 19.1.4 from
x-swat-ppa.
After some digging I've found that current problem may not be related to Mesa,
but may be related to JVM (like in #33
https://bugs.freedesktop.org/show_bug.cgi?id=111077
--- Comment #19 from rol...@rptd.ch ---
Need to shift this back to GenToo since compiling (aka bisecting) is not the
problem right now but GenToo (which actually is the "only" distro I've seen
this problem on so far).
--
You are receiving this
https://bugs.freedesktop.org/show_bug.cgi?id=111448
Sylvain BERTRAND changed:
What|Removed |Added
Resolution|--- |FIXED
Status|NEW
Am 24.08.19 um 21:12 schrieb Chris Wilson:
> Quoting Koenig, Christian (2019-08-24 20:04:43)
>> Am 24.08.19 um 15:58 schrieb Chris Wilson:
>>> In order to allow dma-fence-array as a generic container for fences, we
>>> need to allow for it to contain other dma-fence-arrays. By giving each
>>> dma-f
https://bugs.freedesktop.org/show_bug.cgi?id=111481
--- Comment #1 from Marko Popovic ---
Adding error log from Manjaro:
avg 23 16:05:37 Marko-PC kernel: [drm:amdgpu_job_timedout [amdgpu]] *ERROR*
ring sdma0 timeout, signaled seq=1742, emitted seq=1743
avg 23 16:05:37 Marko-PC kernel: [drm:amdgpu
https://bugs.freedesktop.org/show_bug.cgi?id=108493
Łukasz Posadowski changed:
What|Removed |Added
Resolution|FIXED |---
Status|RESOLVED
https://bugs.freedesktop.org/show_bug.cgi?id=111483
Bug ID: 111483
Summary: FreeSync LFC breaks under certain circumstances,
causing either tearing or stutter
Product: DRI
Version: DRI git
Hardware: x86-64 (AMD64)
https://bugs.freedesktop.org/show_bug.cgi?id=110659
--- Comment #47 from tempel.jul...@gmail.com ---
I got a new 1440p 144 Hz FreeSync display, and as expected, the issue is
unchanged with it.
With it, I've created a new debug dmesg log for render stutter in Oblivion,
this time with your patch ap
https://bugs.freedesktop.org/show_bug.cgi?id=110659
--- Comment #46 from tempel.jul...@gmail.com ---
Created attachment 145152
--> https://bugs.freedesktop.org/attachment.cgi?id=145152&action=edit
new debug dmesg log saved after running Oblivion with drm-next kernel
--
You are receiving this m
Add CMM units to Renesas R-Car M3-N device tree and reference them from
the Display Unit they are connected to.
Signed-off-by: Jacopo Mondi
---
arch/arm64/boot/dts/renesas/r8a77965.dtsi | 25 +++
1 file changed, 25 insertions(+)
diff --git a/arch/arm64/boot/dts/renesas/r8a77
https://bugs.freedesktop.org/show_bug.cgi?id=111481
Marko Popovic changed:
What|Removed |Added
Priority|not set |highest
--
You are receiving this mail
When resuming from system suspend, the DU driver is responsible for
reprogramming and enabling the CMM unit if it was in use at the time
the system entered the suspend state.
Force the color_mgmt_changed flag to true if any of the DRM color
transformation properties was set in the CRTC state dupli
Update CMM settings at in the atomic commit tail helper method.
The CMM is updated with new gamma values provided to the driver
in the GAMMA_LUT blob property.
Reviewed-by: Ulrich Hecht
Reviewed-by: Laurent Pinchart
Signed-off-by: Jacopo Mondi
---
drivers/gpu/drm/rcar-du/rcar_du_kms.c | 35 ++
Enable the GAMMA_LUT KMS property using the framework helpers to
register the property and set the associated gamma table maximum size.
Reviewed-by: Ulrich Hecht
Reviewed-by: Laurent Pinchart
Signed-off-by: Jacopo Mondi
---
drivers/gpu/drm/rcar-du/rcar_du_crtc.c | 4
1 file changed, 4 ins
Add a driver for the R-Car Display Unit Color Correction Module.
In most of Gen3 SoCs, each DU output channel is provided with a CMM unit
to perform image enhancement and color correction.
Add support for CMM through a driver that supports configuration of
the 1-dimensional LUT table. More advanc
Implement device tree parsing to collect the available CMM instances
described by the 'cmms' property. Associate CMMs with CRTCs and store a
mask of active CMMs in the DU group for later enablement.
Enforce the suspend/resume ordering of DU and CMM by creating a
stateless device link between the t
Add CMM to the list of supported features for Gen3 SoCs that provide it:
- R8A7795
- R8A7796
- R8A77965
- R8A7799x
Leave R8A77970 out as V3M and V3H are the only Gen3 SoCs that do not
support CMM.
Reviewed-by: Ulrich Hecht
Reviewed-by: Laurent Pinchart
Signed-off-by: Jacopo Mondi
---
drivers/
Enable/disable the CMM associated with a CRTC at CRTC start and stop
time and enable the CMM unit through the Display Extensional Functions
register at group setup time.
Reviewed-by: Ulrich Hecht
Reviewed-by: Laurent Pinchart
Signed-off-by: Jacopo Mondi
---
drivers/gpu/drm/rcar-du/rcar_du_crtc
Add CMM units to Renesas R-Car D3 device tree and reference them from
the Display Unit they are connected to.
While at it, re-sort the du device node properties to match the ordering
found in other SoCs.
Signed-off-by: Jacopo Mondi
---
arch/arm64/boot/dts/renesas/r8a77995.dtsi | 20
Add CMM units to Renesas R-Car M3-W device tree and reference them from
the Display Unit they are connected to.
Signed-off-by: Jacopo Mondi
---
arch/arm64/boot/dts/renesas/r8a7796.dtsi | 25
1 file changed, 25 insertions(+)
diff --git a/arch/arm64/boot/dts/renesas/r8a77
Add CMM units to Renesas R-Car E3 device tree and reference them from
the Display Unit they are connected to.
While at it, re-sort the du device node properties to match the ordering
found in other SoCs.
Signed-off-by: Jacopo Mondi
---
arch/arm64/boot/dts/renesas/r8a77990.dtsi | 20
Hello,
this is the third iteration of CMM support series.
A reference to the v1 cover letter, with some background on the CMM is
available here:
https://lkml.org/lkml/2019/6/6/583
The series is now based on the v5.3-rc4-based renesas-devel-2019-08-21 branch
of Geert's tree, which already contai
Document the newly added 'cmms' property which accepts a list of phandle
and channel index pairs that point to the CMM units available for each
Display Unit output video channel.
Signed-off-by: Jacopo Mondi
Reviewed-by: Laurent Pinchart
---
Documentation/devicetree/bindings/display/renesas,du.t
Add device tree bindings documentation for the Renesas R-Car Display
Unit Color Management Module.
CMM is the image enhancement module available on each R-Car DU video
channel on R-Car Gen2 and Gen3 SoCs (V3H and V3M excluded).
Signed-off-by: Jacopo Mondi
---
.../bindings/display/renesas,cmm.tx
Add CMM units to Renesas R-Car H3 device tree and reference them from
the Display Unit they are connected to.
While at it, re-sort the du device node properties to match the ordering
found in other SoCs.
Signed-off-by: Jacopo Mondi
---
arch/arm64/boot/dts/renesas/r8a7795.dtsi | 36 +
On 8/14/19 12:45 PM, Dariusz Marcinkiewicz wrote:
> Use the new cec_notifier_conn_(un)register() functions to
> (un)register the notifier for the HDMI connector, and fill
> in the cec_connector_info.
>
> Changes since v6:
> - move cec_notifier_conn_unregister to tda998x_bridge_detach,
>
Hi folks,
I left unblocked gnome-shell at noon, and when I returned at the
evening I discovered than monitor not sleeping and show open gnome
activity. At first, I thought that some application did not let fall
asleep the system. But when I try to move the mouse, I realized that
the system hanged.
I'd like to learn DRM subsystem and GPU driver development and I was
thinking about about writing XGI DRM driver as a practice project
since:
- there's (or was until recently) staging fbdev driver that should
hopefully be working
- it's still possible to buy thin client HW with XGI Z11 running Linu
Hi,
I am working on a new DisplayPort bridge-driver and there is a couple of
things that I do not know how to handle.
1. When should the link training happen?
a) In connector detect()?
- This would enable us to do mode filtering (in mode_valid())
based on the established link ban
On 2019-08-24 17:34, Matthew Wilcox wrote:
> On Fri, Aug 23, 2019 at 08:47:47AM +, Peter Rosin wrote:
>> +++ b/drivers/video/fbdev/core/fbcon.c
>> +++ b/drivers/video/fbdev/core/fbmem.c
>> @@ -56,6 +56,9 @@ EXPORT_SYMBOL(num_registered_fb);
>> bool fb_center_logo __read_mostly;
>> EXPORT_SYMB
https://bugzilla.kernel.org/show_bug.cgi?id=204683
--- Comment #1 from Matthias Heinz (m...@familie-heinz.name) ---
So I tried the oldest installed kernel (a 4.19) I could find and didn't have
any problems with it. This seems to be a regression.
--
You are receiving this mail because:
You are wa
https://bugs.freedesktop.org/show_bug.cgi?id=111482
Bug ID: 111482
Summary: Sapphire Pulse RX 5700 XT power consumption
Product: DRI
Version: DRI git
Hardware: x86-64 (AMD64)
OS: Linux (All)
Status: NEW
Se
81 matches
Mail list logo
