On Mon, Jun 10, 2019 at 02:18:10PM -0700, davidri...@chromium.org wrote:
> From: David Riley
>
> After data is copied to the cache entry, atomic_set is used indicate
> that the data is the entry is valid without appropriate memory barriers.
> Similarly the read side was missing the corresponding
Acked-by: Thomas Zimmermann
Am 12.06.19 um 11:12 schrieb Daniel Vetter:
> ast doesn't implement the mode_set_base_atomic hook this would need,
> so this is dead code.
>
> Signed-off-by: Daniel Vetter
> Cc: Dave Airlie
> Cc: Daniel Vetter
> Cc: Gerd Hoffmann
> Cc: Thomas Zimmermann
> Cc: Ale
Hi, Daniel:
On Wed, 2019-06-12 at 18:25 +0200, Daniel Vetter wrote:
> On Wed, Jun 12, 2019 at 03:51:08PM +0800, CK Hu wrote:
> > Hi Dave, Daniel:
> >
> > This include unbind error fix, clock control flow refinement, and PRIME
> > mmap with page offset.
> >
> > Regards,
> > CK
> >
> > The follow
Hi Rodrigo.
On Wed, Jun 12, 2019 at 11:10:54PM -0300, Rodrigo Siqueira wrote:
> For historical reason, the function drm_wait_vblank_ioctl always return
> -EINVAL if something gets wrong. This scenario limits the flexibility
> for the userspace make detailed verification of the problem and take
> s
On Wed, Jun 12, 2019 at 10:34 PM Hariprasad Kelam
wrote:
>
> this patch fixes below compilation error
>
> drivers/gpu/drm/amd/amdgpu/../display/dc/dcn10/dcn10_hw_sequencer.c: In
> function ‘dcn10_apply_ctx_for_surface’:
> drivers/gpu/drm/amd/amdgpu/../display/dc/dcn10/dcn10_hw_sequencer.c:2378:3:
https://bugs.freedesktop.org/show_bug.cgi?id=110783
--- Comment #11 from Ilia Mirkin ---
(In reply to Christian König from comment #10)
> (In reply to Gert Wollny from comment #9)
> > Indeed, currently the code only tests whether compute shaders are supported,
> > and DIV and TEX_LZ don't have an
Hi Dave, Daniel,
Fixes for 5.2:
- Extend previous vce fix for resume to uvd and vcn
- Fix bounds checking in ras debugfs interface
- Fix a regression on SI using amdgpu
The following changes since commit 671e2ee5ee2127179ca884b439ab6001a623edd6:
Merge branch 'linux-5.2' of git://github.com/ske
For historical reason, the function drm_wait_vblank_ioctl always return
-EINVAL if something gets wrong. This scenario limits the flexibility
for the userspace make detailed verification of the problem and take
some action. In particular, the validation of “if (!dev->irq_enabled)”
in the drm_wait_v
https://bugs.freedesktop.org/show_bug.cgi?id=110907
Bug ID: 110907
Summary: Xorg 1.19.6 segfaults at address 0x6d with mesa 19.1
Product: Mesa
Version: 19.1
Hardware: x86-64 (AMD64)
OS: Linux (All)
Status: NEW
https://bugs.freedesktop.org/show_bug.cgi?id=110795
--- Comment #16 from Rolf ---
Btw, it would be very nice to list these PPAs on the driver page. Where are
they documented? It's not like I can build the driver for myself without
source.
--
You are receiving this mail because:
You are the assi
https://bugs.freedesktop.org/show_bug.cgi?id=110795
Rolf changed:
What|Removed |Added
Resolution|INVALID |WONTFIX
--- Comment #15 from Rolf ---
I have a
https://bugzilla.kernel.org/show_bug.cgi?id=203879
--- Comment #1 from Claude Heiland-Allen (cla...@mathr.co.uk) ---
My conjecture that inactive Xorg prevents freeze is false: got a system freeze
with virtual terminal active, Xorg running on inactive VT. No kernel messages
were printed :( Now ru
Rebase to https://github.com/jgunthorpe/linux.git hmm branch, need some
changes because of interface hmm_range_register change. Then run a quick
amdgpu_test. Test is finished, result is ok. But there is below kernel
BUG message, seems hmm_free_rcu calls down_write.
[ 1171.919921] BUG: sleep
Hi Derek.
On Mon, Jun 10, 2019 at 09:03:46PM -0700, Derek Basehore wrote:
> This adds a helper function for reading the rotation (panel
> orientation) from the device tree.
>
> Signed-off-by: Derek Basehore
> ---
> drivers/gpu/drm/drm_panel.c | 41 +
> includ
Hi Derek.
On Mon, Jun 10, 2019 at 09:03:46PM -0700, Derek Basehore wrote:
> This adds a helper function for reading the rotation (panel
> orientation) from the device tree.
>
> Signed-off-by: Derek Basehore
> ---
> drivers/gpu/drm/drm_panel.c | 41 +
> includ
https://bugs.freedesktop.org/show_bug.cgi?id=110897
--- Comment #14 from cosiek...@o2.pl ---
Created attachment 144524
--> https://bugs.freedesktop.org/attachment.cgi?id=144524&action=edit
bigger glxgears window
>Is HyperZ just good without any changes to stock mesa?
yes, mesa is from manjaro r
https://bugs.freedesktop.org/show_bug.cgi?id=110897
--- Comment #13 from cosiek...@o2.pl ---
01:05.0 VGA compatible controller: Advanced Micro Devices, Inc. [AMD/ATI]
RC410M [Mobility Radeon Xpress 200M] (prog-if 00 [VGA controller])
Subsystem: Packard Bell B.V. RC410M [Mobility Radeon Xpr
On 6/12/19 12:00 AM, Stephen Rothwell wrote:
> Hi all,
>
> Changes since 20190611:
>
on x86_64:
../drivers/gpu/drm/amd/amdgpu/../display/dc/dcn10/dcn10_hw_sequencer.c: In
function ‘dcn10_apply_ctx_for_surface’:
../drivers/gpu/drm/amd/amdgpu/../display/dc/dcn10/dcn10_hw_sequencer.c:2378:3:
err
https://bugs.freedesktop.org/show_bug.cgi?id=110897
--- Comment #12 from Richard Thier ---
Hi Cosiek!
What card is that (lspci output maybe)? Is HyperZ just good without any changes
to stock mesa? Your card seems to be also reported as RC410 like mine, but you
have much-much more FPS for some re
DisplayID blocks allow embedding of CEA blocks. The payloads are
identical to traditional top level CEA extension blocks, but the header
is slightly different.
This change allows the CEA parser to find a CEA block inside a DisplayID
block. Additionally, it adds support for parsing the embedded CTA
https://bugzilla.kernel.org/show_bug.cgi?id=203879
Bug ID: 203879
Summary: hard freeze on high single threaded load when Xorg is
active (AMD Ryzen 7 2700X CPU, AMD Radeon RX 580 GPU)
Product: Drivers
Version: 2.5
Kernel Version:
On Wed, Jun 12, 2019 at 7:40 PM Mauro Carvalho Chehab
wrote:
>
> Em Tue, 11 Jun 2019 09:37:01 -0600
> Jonathan Corbet escreveu:
>
> > On Tue, 11 Jun 2019 06:02:15 -0300
> > Mauro Carvalho Chehab wrote:
> >
> > > Jon, please correct me if I' wrong, bu I guess the plan is to place them
> > > somew
https://bugs.freedesktop.org/show_bug.cgi?id=110783
--- Comment #10 from Christian König ---
(In reply to Gert Wollny from comment #9)
> Indeed, currently the code only tests whether compute shaders are supported,
> and DIV and TEX_LZ don't have any caps yet. I guess I'll take in on me to
> add t
https://bugs.freedesktop.org/show_bug.cgi?id=110783
--- Comment #9 from Gert Wollny ---
Indeed, currently the code only tests whether compute shaders are supported,
and DIV and TEX_LZ don't have any caps yet. I guess I'll take in on me to add
these caps.
--
You are receiving this mail because:
Convert this small file to ReST in preparation for adding it to
the driver-api book.
While this is not part of the driver-api book, mark it as
:orphan:, in order to avoid build warnings.
Signed-off-by: Mauro Carvalho Chehab
---
.../console/{console.txt => console.rst} | 63 ++--
On Wed, Jun 12, 2019 at 11:22:36AM +0800, Zhenyu Wang wrote:
> On 2019.05.26 13:26:33 +0530, Hariprasad Kelam wrote:
> > Remove duplicate include of trace.h
> >
> > Issue identified by includecheck
> >
> > Signed-off-by: Hariprasad Kelam
> > ---
> > drivers/gpu/drm/i915/gvt/trace_points.c | 1 -
https://bugs.freedesktop.org/show_bug.cgi?id=110822
--- Comment #19 from Alex Deucher ---
(In reply to Gobinda Joy from comment #18)
>
> What I don't get is why they are using 2 calls to get the bandwidth reading.
> Since both function walking the PCIe tree what's the point. Also it seems
> like
With commit 88ba95bedb79 ("backlight: pwm_bl: Compute brightness of
LED linearly to human eye") the number of set bits (aka hweight())
in the PWM period is used in the heuristic to determine the number
of brightness levels, when the brightness table isn't specified in
the DT. The number of set bits
[+Philip]
Hi Jason,
I'm out of the office this week.
Hi Philip, can you give this a go? Not sure how much you've been
following this patch series review. Message or call me on Skype to
discuss any questions.
Thanks,
Felix
On 2019-06-11 12:48, Jason Gunthorpe wrote:
> On Thu, Jun 06, 2019
Convert the locking documents to ReST and add them to the
kernel development book where it belongs.
Most of the stuff here is just to make Sphinx to properly
parse the text file, as they're already in good shape,
not requiring massive changes in order to be parsed.
The conversion is actually:
-
Sphinx need to know when a paragraph ends. So, do some adjustments
at the file for it to be properly parsed.
At its new index.rst, let's add a :orphan: while this is not linked to
the main index.rst file, in order to avoid build warnings.
that's said, I believe that this file should be moved to t
https://bugs.freedesktop.org/show_bug.cgi?id=110897
--- Comment #11 from cosiek...@o2.pl ---
Created attachment 144523
--> https://bugs.freedesktop.org/attachment.cgi?id=144523&action=edit
good HyperZ glxgears
Extended renderer info (GLX_MESA_query_renderer):
Vendor: X.Org R300 Project (0x1
https://bugs.freedesktop.org/show_bug.cgi?id=99970
--- Comment #7 from cosiek...@o2.pl ---
>You can try glamor, but I'm not sure it can work with your GPU.
Yea I think it can't /var/log/Xorg.0.log
>glamor requires at least 128 instructions (64 reported)
Is is worth to try to fix DRI3 and EXA for
Em Tue, 11 Jun 2019 09:37:01 -0600
Jonathan Corbet escreveu:
> On Tue, 11 Jun 2019 06:02:15 -0300
> Mauro Carvalho Chehab wrote:
>
> > Jon, please correct me if I' wrong, bu I guess the plan is to place them
> > somewhere under Documentation/admin-guide/.
>
> That makes sense to me.
>
> >
https://bugs.freedesktop.org/show_bug.cgi?id=110897
--- Comment #10 from cosiek...@o2.pl ---
>Was it looking similar? Was it solved for your case?
I didn't report that bug. Someone just wrote in that thread that HyperZ was not
enabled due to lack of testing, so I ran some piglid tests. :)
I just
https://bugs.freedesktop.org/show_bug.cgi?id=110783
--- Comment #8 from Ilia Mirkin ---
(In reply to Gert Wollny from comment #7)
> This is a very deep rabbit hole: Not only does r600 not support DIV, it also
> doesn't support TEX_LZ that is used by these compute shaders and Evergreen
> class har
https://bugs.freedesktop.org/show_bug.cgi?id=110783
--- Comment #7 from Gert Wollny ---
This is a very deep rabbit hole: Not only does r600 not support DIV, it also
doesn't support TEX_LZ that is used by these compute shaders and Evergreen
class hardware doesn't support more then one target swizz
https://bugs.freedesktop.org/show_bug.cgi?id=110883
--- Comment #7 from Sibren Vasse ---
> Does https://patchwork.freedesktop.org/patch/309712/ work?
Yes, it does.
--
You are receiving this mail because:
You are the assignee for the bug.___
dri-devel
On Wed, Jun 12, 2019 at 12:37:57PM -0400, Sven Van Asbroeck wrote:
> On Wed, Jun 12, 2019 at 12:28 PM Russell King - ARM Linux admin
> wrote:
> >
> > The platform data path has never supported the HDMI codec way of doing
> > things, so that really isn't a concern here. The platform data way
> > w
On Wed, Jun 12, 2019 at 11:36:59AM -0400, Sven Van Asbroeck wrote:
> On Tue, Jun 11, 2019 at 7:02 AM Russell King
> wrote:
> >
> > Move the mux and clocking selection out of tda998x_configure_audio()
> > into the parent functions, so we can validate this when parameters
> > are set outside of the
On Wed, Jun 12, 2019 at 11:27:16AM -0400, Sven Van Asbroeck wrote:
> On Tue, Jun 11, 2019 at 7:02 AM Russell King
> wrote:
> >
> > The TDA998x derives the CTS value using the supplied I2S bit clock
> > (ACLK, in TDA998x parlence) rather than 128·fs. TDA998x uses two
> > constants named m and k i
https://bugs.freedesktop.org/show_bug.cgi?id=108514
Paul Dufresne changed:
What|Removed |Added
Status|NEW |RESOLVED
Resolution|---
On Wed, Jun 12, 2019 at 03:51:08PM +0800, CK Hu wrote:
> Hi Dave, Daniel:
>
> This include unbind error fix, clock control flow refinement, and PRIME
> mmap with page offset.
>
> Regards,
> CK
>
> The following changes since commit
> a188339ca5a396acc588e5851ed7e19f66b0ebd9:
>
> Linux 5.2-rc1
On Wed, Jun 12, 2019 at 11:25:59AM -0400, Sven Van Asbroeck wrote:
> On Tue, Jun 11, 2019 at 7:02 AM Russell King
> wrote:
> >
> > Improve the selection of the audio clock divisor so that more modes
> > and sample rates work.
> >
> > Signed-off-by: Russell King
> > ---
>
> +static u8 tda998x_ge
https://bugs.freedesktop.org/show_bug.cgi?id=110906
--- Comment #1 from Michel Dänzer ---
Looks like bug 110883.
--
You are receiving this mail because:
You are the assignee for the bug.___
dri-devel mailing list
dri-devel@lists.freedesktop.org
https:
https://bugs.freedesktop.org/show_bug.cgi?id=110883
--- Comment #6 from Michel Dänzer ---
Does https://patchwork.freedesktop.org/patch/309712/ work?
--
You are receiving this mail because:
You are the assignee for the bug.___
dri-devel mailing list
dr
On Wed, Jun 12, 2019 at 5:48 AM Tomi Valkeinen wrote:
>
> Hi,
>
> On 12/06/2019 11:32, Andrey Smirnov wrote:
> > Transfer size of zero means a request to do an address-only
> > transfer. Since the HW support this, we probably shouldn't be just
> > ignoring such requests. While at it allow DP_AUX_I
Hi Andrey,
On 6/12/19 1:43 PM, Andrey Konovalov wrote:
> This patch is a part of a series that extends arm64 kernel ABI to allow to
> pass tagged user pointers (with the top byte set to something else other
> than 0x00) as syscall arguments.
>
> vaddr_get_pfn() uses provided user pointers for vma
Hi,
On a imx6qp-wandboard I get the warning below about a possible
circular locking dependency running 5.1.9 built from
imx_v6_v7_defconfig.
Such warning does not happen on the imx6q or imx6solo variants of
wandboard though.
Any ideas?
Thanks,
Fabio Estevam
** (matchbox-panel:708): WARNING **
On Wed, Jun 12, 2019 at 05:09:27PM +0200, Sam Ravnborg wrote:
> On Wed, Jun 12, 2019 at 11:00:34AM -0400, Sean Paul wrote:
> > From: Sean Paul
> >
> > I copied the kerneldoc for encoder_funcs.atomic_enable from
> > encoder_funcs.enable
> > in a recent patch [1]. Sam rightly pointed out in the re
https://bugs.freedesktop.org/show_bug.cgi?id=110381
--- Comment #8 from Paul Menzel ---
Why can’t it be said for certain, if the issue is fixed? The commit message
should reference this report, but `git log --grep 110381` does not show
anything.
--
You are receiving this mail because:
You are t
https://bugs.freedesktop.org/show_bug.cgi?id=110906
Bug ID: 110906
Summary: [Regression 5.2-rc4] Frozen screen with `Memory
manager not clean during takedown.`
Product: DRI
Version: XOrg git
Hardware: Other
Hi, Christian,
This looks OK, although there are a couple of minor alterations needed
in the vmwgfx driver:
- We should operate on vmw_buffer_objects rather than on
user_buffer_objects.
- vmw_user_bo_verify_synccpu should move to the validate code.
I can take care of that if it's ok with you.
T
On Wed, Jun 12, 2019 at 11:26:15AM +0100, Daniel Thompson wrote:
> Hi Shobhit
>
> Thanks for the patch. Feedback below...
Hi Daneil,
You provided some valuable feedback. Thank you for your time and
effort.
>
>
> On Tue, Jun 11, 2019 at 09:32:32PM -0700, Shobhit Kukreti wrote:
From: Thomas Hellstrom
Driver fault callbacks are allowed to drop the mmap_sem when expecting
long hardware waits to avoid blocking other mm users. Allow the mkwrite
callbacks to do the same by returning early on VM_FAULT_RETRY.
In particular we want to be able to drop the mmap_sem when waiting
From: Thomas Hellstrom
Add two utilities to a) write-protect and b) clean all ptes pointing into
a range of an address space.
The utilities are intended to aid in tracking dirty pages (either
driver-allocated system memory or pci device memory).
The write-protect utility should be used in conjunc
From: Thomas Hellstrom
This is basically apply_to_page_range with added functionality:
Allocating missing parts of the page table becomes optional, which
means that the function can be guaranteed not to error if allocation
is disabled. Also passing of the closure struct and callback function
beco
From: Thomas Hellstrom
Add the callbacks necessary to implement emulated coherent memory for
surfaces. Add a flag to the gb_surface_create ioctl to indicate that
surface memory should be coherent.
Also bump the drm minor version to signal the availability of coherent
surfaces.
Signed-off-by: Tho
Planning to merge this through the drm/vmwgfx tree soon, so if there
are any objections, please speak up.
Graphics APIs like OpenGL 4.4 and Vulkan require the graphics driver
to provide coherent graphics memory, meaning that the GPU sees any
content written to the coherent memory on the next GPU o
From: Thomas Hellstrom
Add a pointer to the struct vm_operations_struct in the bo_device, and
assign that pointer to the default value currently used.
The driver can then optionally modify that pointer and the new value
can be used for each new vma created.
Cc: "Christian König"
Signed-off-by
From: Thomas Hellstrom
With emulated coherent memory we need to be able to quickly look up
a resource from the MOB offset. Instead of traversing a linked list with
O(n) worst case, use an RBtree with O(log n) worst case complexity.
Signed-off-by: Thomas Hellstrom
Reviewed-by: Deepak Rawat
---
From: Thomas Hellstrom
This infrastructure will, for coherent resources, make sure that
from the user-space point of view, data written by the CPU is immediately
automatically available to the GPU at resource validation time.
Signed-off-by: Thomas Hellstrom
Reviewed-by: Deepak Rawat
---
drive
From: Thomas Hellstrom
Similar to write-coherent resources, make sure that from the user-space
point of view, GPU rendered contents is automatically available for
reading by the CPU.
Signed-off-by: Thomas Hellstrom
Reviewed-by: Deepak Rawat
---
drivers/gpu/drm/vmwgfx/vmwgfx_drv.h |
From: Thomas Hellstrom
With the vmwgfx dirty tracking, the default TTM fault handler is not
completely sufficient (vmwgfx need to modify the vma->vm_flags member,
and also needs to restrict the number of prefaults).
We also want to replicate the new ttm_bo_vm_reserve() functionality
So start tu
https://bugs.freedesktop.org/show_bug.cgi?id=110783
--- Comment #6 from Gert Wollny ---
The commit that added TGSI shaders with DIV were introduced with
f6ac0b5d7187
gallium/auxiliary/vl: Add compute shader to support video compositor render
and the use of the shaders was enabled with
9
Hi Shobhit
> - if (gpio_is_valid(pdata->gpio_enable)) {
> - ret = devm_gpio_request_one(dev, pdata->gpio_enable,
> - GPIOF_OUT_INIT_HIGH, "sky81452-en");
> + pdata->gpiod_enable = devm_gpiod_get(dev, "sk81452-en", GPIOD_OUT_HIGH);
> + i
On Wed, Jun 12, 2019 at 11:00:34AM -0400, Sean Paul wrote:
> From: Sean Paul
>
> I copied the kerneldoc for encoder_funcs.atomic_enable from
> encoder_funcs.enable
> in a recent patch [1]. Sam rightly pointed out in the review that "for
> symmetry
> with" text is awkward [2]. So here's a patch
Quoting Rob Herring (2019-06-10 18:04:40)
> The midgard/bifrost GPUs need to allocate GPU memory which is allocated
> on GPU page faults and not pinned in memory. The vendor driver calls
> this functionality GROW_ON_GPF.
>
> This implementation assumes that BOs allocated with the
> PANFROST_BO_NOM
https://bugs.freedesktop.org/show_bug.cgi?id=110783
--- Comment #5 from Gert Wollny ---
No this doesn't fix the bug, there are other instances where a DIV is
introduced.
--
You are receiving this mail because:
You are the assignee for the bug.___
dri-
From: Sean Paul
I copied the kerneldoc for encoder_funcs.atomic_enable from encoder_funcs.enable
in a recent patch [1]. Sam rightly pointed out in the review that "for symmetry
with" text is awkward [2]. So here's a patch to fix up the source of the awkward
language.
[1]
https://patchwork.freed
On Wed, Jun 12, 2019 at 02:54:56PM +0200, Tomeu Vizoso wrote:
> On Mon, 10 Jun 2019 at 19:06, Rob Herring wrote:
> >
> > The midgard/bifrost GPUs need to allocate GPU memory which is allocated
> > on GPU page faults and not pinned in memory. The vendor driver calls
> > this functionality GROW_ON_G
On Wed, Jun 12, 2019 at 10:16:37AM +0200, Andrzej Hajda wrote:
> > +The ANX6345 is an ultra-low power Full-HD eDP transmitter designed for
> > +portable devices.
> > +
> > +Required properties:
> > +
> > + - compatible : "analogix,anx6345"
> > + - reg : I2C address
On Wed, Jun 12, 2019 at 10:34:55AM -0300, Rodrigo Siqueira wrote:
> On Thu, Jun 6, 2019 at 7:28 PM Daniel Vetter wrote:
> >
> > The worker is always in process context, no need for the _irqsafe
> > version. Same for the set_source callback, that's only called from the
> > debugfs handler in a sysc
From: Sean Paul
This patch adds a new drm helper library to help drivers implement
self refresh. Drivers choosing to use it will register crtcs and
will receive callbacks when it's time to enter or exit self refresh
mode.
In its current form, it has a timer which will trigger after a
driver-spec
On Wed, Jun 12, 2019 at 10:33:11AM -0300, Rodrigo Siqueira wrote:
> On Thu, Jun 6, 2019 at 7:28 PM Daniel Vetter wrote:
> >
> > The issue we have is that the crc worker might fall behind. We've
> > tried to handle this by tracking both the earliest frame for which it
> > still needs to compute a c
Hi Kieran,
Thank you for the patch.
On Fri, May 17, 2019 at 11:31:43PM +0100, Kieran Bingham wrote:
> The vsp1_du_setup_lif() function is deprecated, and the users have been
> removed. Remove the implementation and the associated configuration
> structure.
>
> Signed-off-by: Kieran Bingham
Rev
Hi Kieran,
Thank you for the patch.
On Fri, May 17, 2019 at 11:31:42PM +0100, Kieran Bingham wrote:
> The configuration API between the VSP and the DU has been updated to
> provide finer grain control over modesetting, and enablement.
>
> Split rcar_du_vsp_enable() into rcar_du_vsp_modeset() and
Hello Chenbo,
Thanks very much for your patches. Other than a couple tiny nits
below, I think these look good, and I will merge them before the end
of this week.
On Tue, 11 Jun 2019 at 05:32, Chenbo Feng wrote:
>
> From: Greg Hackmann
>
> This patch adds complimentary DMA_BUF_SET_NAME and DMA_BU
Hi Kieran,
Thank you for the patch.
On Fri, May 17, 2019 at 11:31:41PM +0100, Kieran Bingham wrote:
> Break vsp1_du_setup_lif() into components more suited to the DRM Atomic
> API. The existing vsp1_du_setup_lif() API call is maintained as it is
> still used from the DU.
>
> Signed-off-by: Kiera
On Wed, Jun 12, 2019 at 10:28:41AM -0300, Rodrigo Siqueira wrote:
> Hi Daniel,
>
> First of all, thank you very much for your patchset.
>
> I tried to make a detailed review of your series, and you can see my
> comments in each patch. You’ll notice that I asked many things related
> to the DRM su
On Wed, Jun 12, 2019 at 09:27:21AM +0200, Thomas Zimmermann wrote:
> Hi
>
> Am 11.06.19 um 17:33 schrieb Daniel Vetter:
> > On Tue, Jun 11, 2019 at 2:32 PM Thomas Zimmermann
> > wrote:
> >>
> >> Hi
> >>
> >> Am 05.06.19 um 11:58 schrieb Gerd Hoffmann:
> >>> On Tue, Jun 04, 2019 at 05:41:59PM +02
Quoting Patchwork (2019-06-12 15:07:50)
> == Series Details ==
>
> Series: dma-fence/reservation: Markup rcu protected access for DEBUG_MUTEXES
> URL : https://patchwork.freedesktop.org/series/61963/
> State : warning
>
> == Summary ==
>
> $ dim sparse origin/drm-tip
> Sparse version: v0.5.2
>
https://bugs.freedesktop.org/show_bug.cgi?id=110783
--- Comment #4 from Gert Wollny ---
@AngryPenguin A closer look shows that the bicubic filter in
gallium/auxiliar/vl issues TGSI code that contains a DIV operation.
Could you try this tree:
https://gitlab.freedesktop.org/gerddie/mesa/tree/vl
On Tue, Jun 11, 2019 at 10:56:45PM +0200, Sam Ravnborg wrote:
> Hi Sean.
>
> Small things here and there. Did not stare at this long enough to
> understand the code, but added some feedback anyway.
Thanks for the comments, Sam, I'll send a revision shortly
>
> Sam
> >
/snip
> > +stati
On Wed, Jun 12, 2019 at 09:55:30AM +0200, Nicolas Ferre - M43238 wrote:
> On 11/06/2019 at 19:09, Colin King wrote:
> > External E-Mail
> >
> >
> > From: Colin Ian King
> >
> > Currently variable ret is being initialized with -ENOENT however that
> > value is never read and ret is being re-assi
On 08.06.2019 13:40, Laurent Pinchart wrote:
> Hi Wolfram,
>
> Thank you for the patch.
>
> On Sat, Jun 08, 2019 at 12:55:41PM +0200, Wolfram Sang wrote:
>> We have a dedicated pointer for that, so use it. Much easier to read and
>> less computation involved.
>>
>> Signed-off-by: Wolfram Sang
> Re
On Mon, Jun 10, 2019 at 12:39 PM Liviu Dudau wrote:
>
> On Fri, Jun 07, 2019 at 11:58:04AM -0300, Rodrigo Siqueira wrote:
> > On Fri, Jun 7, 2019 at 4:48 AM Daniel Vetter wrote:
> > >
> > > On Thu, Jun 06, 2019 at 07:41:01PM -0300, Rodrigo Siqueira wrote:
> > > > This patch implements the necessa
Document the optional properties for describing module resets, to
support resetting display channels on R-Car Gen2 and Gen3.
Signed-off-by: Geert Uytterhoeven
Acked-by: Laurent Pinchart
Acked-by: Rob Herring
---
v3:
- Add Acked-by,
- Drop LVDS resets, as LVDS is now covered by a separate bi
On Thu, Jun 6, 2019 at 7:28 PM Daniel Vetter wrote:
>
> We're now guaranteed to no longer race against prepare_fb/cleanup_fb,
> which means we can access ->vaddr without having to hold a lock.
>
> Before the previous patches it was fairly easy to observe the cursor
> ->vaddr being invalid, but tha
On Thu, Jun 6, 2019 at 7:28 PM Daniel Vetter wrote:
>
> The crc computation worker needs to be able to get at some data
> structures and framebuffer mappings, while potentially more atomic
> updates are going on. The solution thus far is to copy relevant bits
> around, but that's very tedious.
>
>
On Thu, Jun 6, 2019 at 7:28 PM Daniel Vetter wrote:
>
> irqs are already off.
>
> Signed-off-by: Daniel Vetter
> ---
> drivers/gpu/drm/vkms/vkms_crtc.c | 5 ++---
> 1 file changed, 2 insertions(+), 3 deletions(-)
>
> diff --git a/drivers/gpu/drm/vkms/vkms_crtc.c
> b/drivers/gpu/drm/vkms/vkms_cr
On Wed, Jun 12, 2019 at 03:30:38PM +0200, Linus Walleij wrote:
> We need to handle the case when of_drm_find_bridge() returns
> NULL.
>
> Reported-by: Dan Carpenter
> Cc: Dan Carpenter
> Signed-off-by: Linus Walleij
> ---
> drivers/gpu/drm/mcde/mcde_drv.c | 4 ++--
> 1 file changed, 2 insertio
On Thu, Jun 6, 2019 at 7:28 PM Daniel Vetter wrote:
>
> Currently we flush pending crc workers very late in the commit flow,
> when we destry all the old crtc states. Unfortunately at that point
destry -> destroy
> the framebuffers are already unpinned (and our vaddr possible gone),
> so this is
On Thu, Jun 6, 2019 at 7:28 PM Daniel Vetter wrote:
>
> No need to have them multiple times.
>
> Signed-off-by: Daniel Vetter
> Cc: Rodrigo Siqueira
> Cc: Haneen Mohammed
> Cc: Daniel Vetter
> ---
> drivers/gpu/drm/vkms/vkms_drv.h | 8
> drivers/gpu/drm/vkms/vkms_plane.c | 8 ++
On Thu, Jun 6, 2019 at 7:28 PM Daniel Vetter wrote:
>
> Plus add a comment about what it actually protects. It's very little.
>
> Signed-off-by: Daniel Vetter
> Cc: Rodrigo Siqueira
> Cc: Haneen Mohammed
> Cc: Daniel Vetter
> ---
> drivers/gpu/drm/vkms/vkms_crc.c | 4 ++--
> drivers/gpu/drm/
On Thu, Jun 6, 2019 at 7:28 PM Daniel Vetter wrote:
>
> The worker is always in process context, no need for the _irqsafe
> version. Same for the set_source callback, that's only called from the
> debugfs handler in a syscall.
>
> Cc: Shayenne Moura
> Cc: Rodrigo Siqueira
> Signed-off-by: Daniel
On Thu, Jun 6, 2019 at 7:28 PM Daniel Vetter wrote:
>
> The issue we have is that the crc worker might fall behind. We've
> tried to handle this by tracking both the earliest frame for which it
> still needs to compute a crc, and the last one. Plus when the
> crtc_state changes, we have a new work
We need to handle the case when of_drm_find_bridge() returns
NULL.
Reported-by: Dan Carpenter
Cc: Dan Carpenter
Signed-off-by: Linus Walleij
---
drivers/gpu/drm/mcde/mcde_drv.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/gpu/drm/mcde/mcde_drv.c b/drivers/gpu
Am 12.06.19 um 15:28 schrieb Chris Wilson:
Mark the access to reservation_object.fence as being protected to
silence sparse.
Signed-off-by: Chris Wilson
Reviewed-by: Christian König
---
include/linux/reservation.h | 8 ++--
1 file changed, 6 insertions(+), 2 deletions(-)
diff --git
Hi Daniel,
First of all, thank you very much for your patchset.
I tried to make a detailed review of your series, and you can see my
comments in each patch. You’ll notice that I asked many things related
to the DRM subsystem with the hope that I could learn a little bit
more about DRM from your c
1 - 100 of 190 matches
Mail list logo
