[Bug 108916] polaris11 d3d9 rendering issue

2019-01-25 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=108916 --- Comment #3 from Roman Elshin --- I saw some reports with distortions which looks similar to this and it was fixed in llvm-8. Installing llvm-8 from http://apt.llvm.org/ and recompiling libdrm + mesa from git does't solve this issue. $ glxinf

[PATCH] drm/i915: Don't send MST hotplugs until after resume

2019-01-25 Thread Lyude Paul
Turns out we are sending a lot more hotplug events then we need, and this is causing some pretty serious issues. Currently, we call intel_dp_mst_resume() in i915_drm_resume() well before we have any sort of hotplugging setup. This is a pretty big problem, because in practice it will generally resul

[PATCH] drm/rockchip: check yuv2yuv existence before assigning window data

2019-01-25 Thread Heiko Stuebner
Before assigning window data, we should check if the yuv2yuv vop-data is set at all, because it looks like it can otherwise reference something wrong, as I saw on my rk3188 today which ended up in a null pointer dereference in vop_plane_atomic_update when accessing the yuv2yuv data. Fixes: 1c21aa8

[Bug 201497] [amdgpu]: '*ERROR* No EDID read' is back in 4.19

2019-01-25 Thread bugzilla-daemon
https://bugzilla.kernel.org/show_bug.cgi?id=201497 --- Comment #8 from Elliot Thomas (e.singularity...@gmail.com) --- Created attachment 280777 --> https://bugzilla.kernel.org/attachment.cgi?id=280777&action=edit dmesg, amd-staging-drm-next-git (d0333a48e54fdcfdae5e378acd898a680967e939) -- You

[pull] amdgpu, amdkfd, ttm, sched drm-next-5.1

2019-01-25 Thread Alex Deucher
Hi Dave, Daniel, New stuff for 5.1. amdgpu: - DC bandwidth formula updates - Support for DCC on scanout surfaces - Support for multiple IH rings on soc15 asics - Fix xgmi locking - Add sysfs interface to get pcie usage stats - Simplify DC i2c/aux code - Initial support for BACO on vega10/20 - New

Re: [PATCH v6 11/22] clk: sunxi-ng: a64: Add minimum rate for PLL_MIPI

2019-01-25 Thread Maxime Ripard
On Fri, Jan 25, 2019 at 01:28:49AM +0530, Jagan Teki wrote: > Minimum PLL used for MIPI is 500MHz, as per manual, but > lowering the min rate by 300MHz can result proper working > nkms divider with the help of desired dclock rate from > panel driver. > > Signed-off-by: Jagan Teki > Acked-by: Step

Re: [PATCH v5 07/17] drm/sun4i: sun6i_mipi_dsi: Refactor vertical video start delay

2019-01-25 Thread Maxime Ripard
On Tue, Jan 22, 2019 at 05:21:08PM +0530, Jagan Teki wrote: > On Tue, Jan 22, 2019 at 4:41 PM Maxime Ripard > wrote: > > > > On Fri, Jan 18, 2019 at 09:14:19PM +0530, Jagan Teki wrote: > > > On Thu, Jan 17, 2019 at 10:02 AM Jagan Teki > > > wrote: > > > > > > > > On Thu, Jan 17, 2019 at 12:48 A

Re: [PATCH 4/4] drm/i915/dsi: Call drm_connector_cleanup on vlv_dsi_init error exit path

2019-01-25 Thread Ville Syrjälä
On Sat, Dec 01, 2018 at 12:31:48PM +0100, Hans de Goede wrote: > If we exit vlv_dsi_init() because we failed to find a fixed_mode, then > we've already called drm_connector_init() and we should call > drm_connector_cleanup() to unregister the connector object. > > Signed-off-by: Hans de Goede Re

Re: [Intel-gfx] [PATCH 2/3] drm: Sync errno values for property lookup errors

2019-01-25 Thread Ville Syrjälä
On Tue, Jan 22, 2019 at 10:39:38AM +0100, Daniel Vetter wrote: > On Mon, Jan 21, 2019 at 10:24:29PM +0200, Ville Syrjala wrote: > > From: Ville Syrjälä > > > > Use ENOENT consistently for the case where the requested property > > isn't found, and EINVAL for the case where the object has no > > pr

Re: [Intel-gfx] [PATCH 1/3] drm: Add debug prints for the various object lookup errors

2019-01-25 Thread Ville Syrjälä
On Tue, Jan 22, 2019 at 10:38:30AM +0100, Daniel Vetter wrote: > On Mon, Jan 21, 2019 at 10:24:28PM +0200, Ville Syrjala wrote: > > From: Ville Syrjälä > > > > Only some of the drm mode object lookups have a corresponding debug > > print for the lookup failure. That makes logs a bit hard to parse

Re: [PATCH v5 2/2] drm/panel: Add Feiyang FY07024DI26A30-D MIPI-DSI LCD panel

2019-01-25 Thread Sam Ravnborg
Hi Jagan. Looks good, only very few nits left. On Sat, Jan 26, 2019 at 12:52:33AM +0530, Jagan Teki wrote: > Feiyang FY07024DI26A30-D is 1024x600, 4-lane MIPI-DSI LCD panel. > > Add panel driver for it. > > Tested-by: Bhushan Shah > Signed-off-by: Jagan Teki If you consider my inputs (I know

[PATCH v5 2/2] drm/panel: Add Feiyang FY07024DI26A30-D MIPI-DSI LCD panel

2019-01-25 Thread Jagan Teki
Feiyang FY07024DI26A30-D is 1024x600, 4-lane MIPI-DSI LCD panel. Add panel driver for it. Tested-by: Bhushan Shah Signed-off-by: Jagan Teki --- Changes for v5: - drop drmP.h header - order include files - add empty line after kzalloc() - drop gpio set for reset - drop backlight put_device from

[PATCH v5 1/2] dt-bindings: panel: Add Feiyang FY07024DI26A30-D MIPI-DSI LCD panel

2019-01-25 Thread Jagan Teki
Feiyang FY07024DI26A30-D is 1024x600, 4-lane MIPI-DSI LCD panel. Add dt-bingings for it. Signed-off-by: Jagan Teki Reviewed-by: Rob Herring --- Changes for v5, v4, v3: - none Changes for v2: - new patch, derived from another dsi series .../display/panel/feiyang,fy07024di26a30d.txt | 20 +

Re: [PATCH v6 16/22] arm64: dts: allwinner: a64: Add DSI pipeline

2019-01-25 Thread Maxime Ripard
On Fri, Jan 25, 2019 at 01:28:54AM +0530, Jagan Teki wrote: > The A64 has a MIPI-DSI block which is similar to A31. > > Add dsi, dphy nodes with A31 fallback compatible and finally > connect the dsi node to tcon0 node to make proper DSI pipeline. > > Signed-off-by: Jagan Teki > --- > arch/arm64

[Bug 109246] HDMI connected monitors fail to sleep and instead turn back on when amdgpu.dc=1

2019-01-25 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=109246 --- Comment #15 from tme --- I've been attempting to perform a bisect on an off for a while now with no success. The main problem I'm running into is this error when trying to compile. RELOCS arch/x86/boot/compressed/vmlinux.relocs Unsupport

Re: [PATCH v3 18/23] drm/qxl: remove dead qxl fbdev emulation code

2019-01-25 Thread Noralf Trønnes
Den 25.01.2019 19.10, skrev Sam Ravnborg: > Hi Noralf. > >>> Lovely diffstat, thanks to the new generic fbdev emulation. >>> >>> drm/qxl/Makefile |2 >>> drm/qxl/qxl_draw.c | 232 >>> drm/qxl/qxl_drv.h | 21 --- >>> drm/qxl/qxl_fb.c | 300 >

Re: [PATCH 06/26] drm/fb_helper: set info->par in fill_info()

2019-01-25 Thread Sam Ravnborg
On Fri, Jan 25, 2019 at 09:44:06AM +0100, Daniel Vetter wrote: > On Thu, Jan 24, 2019 at 06:45:52PM +0100, Sam Ravnborg wrote: > > Hi Daniel. > > > > On Thu, Jan 24, 2019 at 05:58:11PM +0100, Daniel Vetter wrote: > > > The fbdev emulation helpers pretty much assume that this is set. > > > Let's do

Re: [PATCH 2/2] drm/vmwgfx: Use ttm_dma_page_alloc_enabled

2019-01-25 Thread Sam Ravnborg
Hi Thomas. One little nit, and an improvment proposal (for another patch/day). On Fri, Jan 25, 2019 at 02:05:48PM +0100, Thomas Hellstrom wrote: > Instead of guessing whether TTM has the dma page allocator enabled, > ask TTM. > > Signed-off-by: Thomas Hellstrom > --- > drivers/gpu/drm/vmwgfx/v

Re: [Intel-gfx] [PATCH 14/15] drm/i915/tv: Fix >1024 modes on gen3

2019-01-25 Thread Ville Syrjälä
On Wed, Jan 23, 2019 at 03:49:02PM +0200, Imre Deak wrote: > On Mon, Nov 12, 2018 at 06:59:59PM +0200, Ville Syrjala wrote: > > From: Ville Syrjälä > > > > On gen3 we must disable the TV encoder vertical filter for >1024 > > pixel wide sources. Once that's done all we can is try to center > > the

Re: [PATCH v3 18/23] drm/qxl: remove dead qxl fbdev emulation code

2019-01-25 Thread Sam Ravnborg
Hi Noralf. > > Lovely diffstat, thanks to the new generic fbdev emulation. > > > > drm/qxl/Makefile |2 > > drm/qxl/qxl_draw.c | 232 > > drm/qxl/qxl_drv.h | 21 --- > > drm/qxl/qxl_fb.c | 300 > >

Re: [PATCH v3 1/4] drm/vc4: Wait for display list synchronization when completing commit

2019-01-25 Thread Eric Anholt
Paul Kocialkowski writes: > Hi, > > On Wed, 2019-01-23 at 10:34 -0800, Eric Anholt wrote: >> Paul Kocialkowski writes: >> >> > During an atomic commit, the HVS is configured with a display list >> > for the channel matching the associated CRTC. The Pixel Valve (CRTC) >> > and encoder are also c

Re: [PATCH v3 2/4] drm/vc4: Report underrun errors

2019-01-25 Thread Eric Anholt
Paul Kocialkowski writes: > Hi Eric, > > On Wed, 2019-01-23 at 10:47 -0800, Eric Anholt wrote: >> Paul Kocialkowski writes: >> > +void vc4_hvs_mask_underrun(struct drm_device *dev) >> > +{ >> > + struct vc4_dev *vc4 = to_vc4_dev(dev); >> > + u32 dispctrl = HVS_READ(SCALER_DISPCTRL); >> > + >>

Re: [PATCH v3 22/23] drm/qxl: use kernel mode db

2019-01-25 Thread Noralf Trønnes
Den 18.01.2019 13.20, skrev Gerd Hoffmann: > Add all standard modes from the kernel's video mode data base. > Keep a few non-standard modes in the qxl mode list. > > Signed-off-by: Gerd Hoffmann > --- Acked-by: Noralf Trønnes ___ dri-devel mailing l

Re: [PATCH v3 21/23] drm/qxl: add qxl_add_mode helper function

2019-01-25 Thread Noralf Trønnes
Den 18.01.2019 13.20, skrev Gerd Hoffmann: > Add a helper function to add custom video modes to a connector. > > Signed-off-by: Gerd Hoffmann > --- Acked-by: Noralf Trønnes ___ dri-devel mailing list dri-devel@lists.freedesktop.org https://lists.fre

Re: [PATCH v3 20/23] drm/qxl: add mode/framebuffer check functions

2019-01-25 Thread Noralf Trønnes
Den 18.01.2019 13.20, skrev Gerd Hoffmann: > Add a helper functions to check video modes. Also add a helper to check > framebuffer buffer objects, using the former for consistency. That way > we should not fail in qxl_primary_atomic_check() because video modes > which are too big will not be ad

Re: [PATCH v3 19/23] drm/qxl: implement qxl_gem_prime_(un)pin

2019-01-25 Thread Noralf Trønnes
Den 18.01.2019 13.20, skrev Gerd Hoffmann: > Signed-off-by: Gerd Hoffmann > --- Acked-by: Noralf Trønnes ___ dri-devel mailing list dri-devel@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/dri-devel

Re: [PATCH v3 18/23] drm/qxl: remove dead qxl fbdev emulation code

2019-01-25 Thread Noralf Trønnes
Den 18.01.2019 13.20, skrev Gerd Hoffmann: > Lovely diffstat, thanks to the new generic fbdev emulation. > > drm/qxl/Makefile |2 > drm/qxl/qxl_draw.c | 232 > drm/qxl/qxl_drv.h | 21 --- > drm/qxl/qxl_fb.c | 300 > -

[Bug 108854] [polaris11] - GPU Hang - ring gfx timeout

2019-01-25 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=108854 Alex Deucher changed: What|Removed |Added Component|DRM/AMDgpu |Drivers/Gallium/radeonsi Prod

Re: [PATCH v3 17/23] drm/qxl: use generic fbdev emulation

2019-01-25 Thread Noralf Trønnes
Den 18.01.2019 13.20, skrev Gerd Hoffmann: > Switch qxl over to the new generic fbdev emulation. > > Signed-off-by: Gerd Hoffmann > --- > drivers/gpu/drm/qxl/qxl_display.c | 7 --- > drivers/gpu/drm/qxl/qxl_drv.c | 2 ++ > 2 files changed, 2 insertions(+), 7 deletions(-) > > diff --gi

[Bug 108854] [polaris11] - GPU Hang - ring gfx timeout

2019-01-25 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=108854 --- Comment #11 from Alex Deucher --- The reset was actually successful. The problem is, userspace components need to be aware of the reset and recreate their contexts. As a workaround, you can kill the problematic app or restart X. -- You a

[Bug 190971] amdgpu (on Kabini) fails to resume, atombios stuck executing BA98

2019-01-25 Thread bugzilla-daemon
https://bugzilla.kernel.org/show_bug.cgi?id=190971 Johannes Hirte (johannes.hi...@datenkhaos.de) changed: What|Removed |Added CC||johannes.h

Re: [PATCH v3 16/23] drm/qxl: implement prime kmap/kunmap

2019-01-25 Thread Noralf Trønnes
Den 18.01.2019 13.20, skrev Gerd Hoffmann: > Generic fbdev emulation needs this. Also: We must keep track of the > number of mappings now, so we don't unmap early in case two users want a > kmap of the same bo. Add a sanity check to destroy callback to make > sure kmap/kunmap is balanced. > >

Re: [PATCH v3 15/23] drm/qxl: use qxl_num_crtc directly

2019-01-25 Thread Noralf Trønnes
Den 18.01.2019 13.20, skrev Gerd Hoffmann: > qdev->monitors_config->max_allowed is effectively set by the > qxl.num_heads module parameter, stored in the qxl_num_crtc variable. > Lets get rid of the indirection and use the variable qxl_num_crtc > directly. The kernel doesn't need to dereference

Re: [PATCH v3 14/23] drm/qxl: cover all crtcs in shadow bo.

2019-01-25 Thread Noralf Trønnes
Den 18.01.2019 13.20, skrev Gerd Hoffmann: > The qxl device supports only a single active framebuffer ("primary > surface" in spice terminology). In multihead configurations are handled > by defining rectangles within the primary surface for each head/crtc. > > Userspace which uses the qxl ioct

Re: [PATCH v3 13/23] drm/qxl: use shadow bo directly

2019-01-25 Thread Noralf Trønnes
Den 18.01.2019 13.20, skrev Gerd Hoffmann: > Pass the shadow bo to qxl_io_create_primary() instead of expecting > qxl_io_create_primary to check bo->shadow. Set is_primary flag on the > shadow bo. Move the is_primary tracking into qxl_io_create_primary() > and qxl_io_destroy_primary() functions

Re: [PATCH 2/2] phy: Add driver for mixel dphy

2019-01-25 Thread Sam Ravnborg
Hi Guido. Patch looks good but a few comments below. Sam On Fri, Jan 25, 2019 at 11:14:46AM +0100, Guido Günther wrote: > This adds support for the Mixel DPHY as found on i.MX8 CPUs but since > this is an IP core it will likely be found on others in the future. So > instead of adding thi

[Bug 107978] [amdgpu] Switching to tty fails with DisplayPort 1.2 monitor going to sleep (REG_WAIT timeout / dce110_stream_encoder_dp_blank)

2019-01-25 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=107978 --- Comment #50 from Shmerl --- I think I know what happened. When I was rebooting, I still had the older kernel running (without the fix), to actually test the new one, so probably the bug still kicked in after reboot. I now rebooted a few mor

[Bug 109389] memory leak in `amdgpu_bo_create()`

2019-01-25 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=109389 --- Comment #3 from Michel Dänzer --- Does this also happen with 4.20.y? If not, can you bisect? -- You are receiving this mail because: You are the assignee for the bug.___ dri-devel mailing list dr

[Bug 107978] [amdgpu] Switching to tty fails with DisplayPort 1.2 monitor going to sleep (REG_WAIT timeout / dce110_stream_encoder_dp_blank)

2019-01-25 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=107978 --- Comment #49 from Shmerl --- Though my tests mostly focused on reboots. Let me double check what happens after actual cold off and boot. -- You are receiving this mail because: You are the assignee for the bug.__

[Bug 107978] [amdgpu] Switching to tty fails with DisplayPort 1.2 monitor going to sleep (REG_WAIT timeout / dce110_stream_encoder_dp_blank)

2019-01-25 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=107978 --- Comment #48 from Shmerl --- (In reply to Jerry Zuo from comment #47) > You observed the monitor goes to sleep right after reboot, did you? Hotplug > will have the display back on. Is that what you observed? After any boot, not necessarily r

Re: [Intel-gfx] [PATCH 03/26] drm/irq: Ditch DRIVER_IRQ_SHARED

2019-01-25 Thread Daniel Vetter
On Fri, Jan 25, 2019 at 02:46:55PM +, Emil Velikov wrote: > On Thu, 24 Jan 2019 at 16:58, Daniel Vetter wrote: > > > > This is only used by drm_irq_install(), which is an optional helper. > > And the right choice is to set it for all pci devices, and not for > > everything else. > > > Can you

[Bug 107978] [amdgpu] Switching to tty fails with DisplayPort 1.2 monitor going to sleep (REG_WAIT timeout / dce110_stream_encoder_dp_blank)

2019-01-25 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=107978 --- Comment #47 from Jerry Zuo --- You observed the monitor goes to sleep right after reboot, did you? Hotplug will have the display back on. Is that what you observed? -- You are receiving this mail because: You are the assignee for the bug._

Re: [PATCH v3 12/23] drm/qxl: track primary bo

2019-01-25 Thread Noralf Trønnes
Den 18.01.2019 13.20, skrev Gerd Hoffmann: > Track which bo is used as primary surface. With that in place we don't > need the primary_created flag any more, we can just check the primary bo > pointer instead. > > Also verify we don't already have a primary surface in > qxl_io_create_primary().

Re: [PATCH v3 11/23] drm/qxl: drop unused offset parameter from qxl_io_create_primary()

2019-01-25 Thread Noralf Trønnes
Den 18.01.2019 13.20, skrev Gerd Hoffmann: > Signed-off-by: Gerd Hoffmann > --- Acked-by: Noralf Trønnes ___ dri-devel mailing list dri-devel@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/dri-devel

Re: [PATCH v3 10/23] drm/qxl: move qxl_primary_apply_cursor to correct place

2019-01-25 Thread Noralf Trønnes
Den 18.01.2019 13.20, skrev Gerd Hoffmann: > The cursor must be set again after creating the primary surface. > Also drop the error message. > > Signed-off-by: Gerd Hoffmann > --- > drivers/gpu/drm/qxl/qxl_display.c | 10 +++--- > 1 file changed, 3 insertions(+), 7 deletions(-) > > diff -

Re: [PATCH] drm/vkms: Fix flush_work() without INIT_WORK().

2019-01-25 Thread Daniel Vetter
On Fri, Jan 25, 2019 at 09:46:15AM -0500, Sean Paul wrote: > On Sat, Jan 19, 2019 at 01:43:43AM +0900, Tetsuo Handa wrote: > > syzbot is hitting a lockdep warning [1] because flush_work() is called > > without INIT_WORK() after kzalloc() at vkms_atomic_crtc_reset(). > > > > Commit 6c234fe37c57627a

Re: [PATCH v3 09/23] drm/qxl: use QXL_GEM_DOMAIN_SURFACE for dumb gem objects

2019-01-25 Thread Noralf Trønnes
Den 18.01.2019 13.20, skrev Gerd Hoffmann: > dumb buffers are used as qxl surfaces, so allocate them as > QXL_GEM_DOMAIN_SURFACE. Should usually be allocated in > PRIV ttm domain then, so this reduces VRAM memory pressure. > > Signed-off-by: Gerd Hoffmann > --- Acked-by: Noralf Trønnes _

Re: [PATCH v3 08/23] drm/qxl: use QXL_GEM_DOMAIN_SURFACE for shadow bo.

2019-01-25 Thread Noralf Trønnes
Den 18.01.2019 13.20, skrev Gerd Hoffmann: > The shadow bo is used as qxl surface, so allocate it as > QXL_GEM_DOMAIN_SURFACE. Should usually be allocated in > PRIV ttm domain then, so this reduces VRAM memory pressure. > > Signed-off-by: Gerd Hoffmann > --- Acked-by: Noralf Trønnes

Re: [PATCH v3 07/23] drm/qxl: allow both PRIV and VRAM placement for QXL_GEM_DOMAIN_SURFACE

2019-01-25 Thread Noralf Trønnes
Den 18.01.2019 13.20, skrev Gerd Hoffmann: > qxl surfaces (used for framebuffers and gem objects) can live in both > VRAM and PRIV ttm domains. Update placement setup to include both. > Put PRIV first in the list so it is preferred, so VRAM will have more > room for objects which must be allocat

Re: [PATCH v3 06/23] drm/qxl: use separate offset spaces for the two slots / ttm memory types.

2019-01-25 Thread Noralf Trønnes
Den 18.01.2019 13.20, skrev Gerd Hoffmann: > Without that ttm offsets are not unique, they can refer to objects > in both VRAM and PRIV memory (aka main and surfaces slot). > > One of those "why things didn't blow up without this" moments. > Probably offset conflicts are rare enough by pure luck

Re: [PATCH v3 05/23] drm/qxl: drop unused fields from struct qxl_device

2019-01-25 Thread Noralf Trønnes
Den 18.01.2019 13.20, skrev Gerd Hoffmann: > slot_id_bits and slot_gen_bits can be read directly from qxlrom instead. > va_slot_mask is never used anywhere. > > Signed-off-by: Gerd Hoffmann > --- Acked-by: Noralf Trønnes ___ dri-devel mailing list d

Re: [PATCH v6 15/22] dt-bindings: sun6i-dsi: Add A64 DPHY compatible (w/ A31 fallback)

2019-01-25 Thread Maxime Ripard
On Fri, Jan 25, 2019 at 01:28:53AM +0530, Jagan Teki wrote: > The MIPI DSI PHY controller on Allwinner A64 is similar > on the one on A31. > > Add A64 compatible and append A31 compatible as fallback. > > Signed-off-by: Jagan Teki > Reviewed-by: Rob Herring > --- > Documentation/devicetree/bin

Re: [PATCH v6 14/22] dt-bindings: sun6i-dsi: Add A64 DSI compatible (w/ A31 fallback)

2019-01-25 Thread Maxime Ripard
On Fri, Jan 25, 2019 at 01:28:52AM +0530, Jagan Teki wrote: > The MIPI DSI controller in Allwinner A64 is similar to A33. > > But unlike A33, A64 doesn't have DSI_SCLK gating which eventually > set the mod clock rate for the controller. > > So, use the DSI_DPHY gating for the similar purpose of m

Re: [PATCH v3 04/23] drm/qxl: change the way slot is detected

2019-01-25 Thread Noralf Trønnes
Den 18.01.2019 13.20, skrev Gerd Hoffmann: > From: Frediano Ziglio > > Instead of relaying on surface type use the actual placement. > This allow to have different placement for a single type of > surface. > > Signed-off-by: Frediano Ziglio > > [ kraxel: rebased, adapted to upstream changes

Re: [PATCH v3 03/23] drm/qxl: simplify slot management

2019-01-25 Thread Noralf Trønnes
Den 18.01.2019 13.20, skrev Gerd Hoffmann: > Drop pointless indirection, remove the mem_slots array and index > variables, drop dynamic allocation. Store memslots in qxl_device > instead. > > Signed-off-by: Gerd Hoffmann > --- Looks sane: Acked-by: Noralf Trønnes ___

Re: [PATCH v6 12/22] dt-bindings: sun6i-dsi: Add VCC-DSI supply property

2019-01-25 Thread Maxime Ripard
On Fri, Jan 25, 2019 at 01:28:50AM +0530, Jagan Teki wrote: > Most of the Allwinner MIPI DSI controllers are supply with > VCC-DSI pin. which need to supply for some of the boards to > trigger the power. > > So, document the supply property so-that the required board > can eable it via device tree

Re: [PATCH v3 02/23] drm/qxl: drop unused qxl_fb_virtual_address

2019-01-25 Thread Noralf Trønnes
Den 18.01.2019 13.19, skrev Gerd Hoffmann: > Signed-off-by: Gerd Hoffmann > --- Acked-by: Noralf Trønnes ___ dri-devel mailing list dri-devel@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/dri-devel

Re: [PATCH v3 01/23] drm/qxl: drop ttm_mem_reg arg from qxl_hw_surface_alloc()

2019-01-25 Thread Noralf Trønnes
Den 18.01.2019 13.19, skrev Gerd Hoffmann: > Not used, is always NULL. > > Signed-off-by: Gerd Hoffmann > --- Acked-by: Noralf Trønnes ___ dri-devel mailing list dri-devel@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/dri-deve

[Bug 109456] KVM VFIO guest X hang with guest kernel > 4.15

2019-01-25 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=109456 --- Comment #1 from Alex Deucher --- Can you bisect? Please attach your dmesg output and xorg log. -- You are receiving this mail because: You are the assignee for the bug.___ dri-devel mailing list

Re: [PATCH] drm/amd/display: add -msse2 to prevent Clang from emitting libcalls to undefined SW FP routines

2019-01-25 Thread Wentland, Harry
On 2019-01-24 7:52 p.m., ndesaulni...@google.com wrote: > arch/x86/Makefile disables SSE and SSE2 for the whole kernel. The > AMDGPU drivers modified in this patch re-enable SSE but not SSE2. Turn > on SSE2 to support emitting double precision floating point instructions > rather than calls to no

Re: [PATCH 26/26] drm/: Don't set FBINFO_(FLAG_)DEFAULT

2019-01-25 Thread Thierry Reding
On Thu, Jan 24, 2019 at 05:58:31PM +0100, Daniel Vetter wrote: > It's 0. > > Signed-off-by: Daniel Vetter > Cc: Inki Dae > Cc: Joonyoung Shim > Cc: Seung-Woo Kim > Cc: Kyungmin Park > Cc: Kukjin Kim > Cc: Krzysztof Kozlowski > Cc: Patrik Jakobsson > Cc: Ben Skeggs > Cc: Sandy Huang > Cc:

Re: [PATCH 22/26] drm/qxl: Use drm_fb_helper_fill_info

2019-01-25 Thread Thierry Reding
On Thu, Jan 24, 2019 at 05:58:27PM +0100, Daniel Vetter wrote: > Another driver that didn't set fbinfo->fix.id before. > > Signed-off-by: Daniel Vetter > Cc: Thierry Reding > Cc: Jonathan Hunter > Cc: linux-te...@vger.kernel.org > --- > drivers/gpu/drm/tegra/fb.c | 4 +--- > 1 file changed, 1

Re: [PATCH 01/26] drm/irq: Don't check for DRIVER_HAVE_IRQ in drm_irq_(un)install

2019-01-25 Thread Emil Velikov
On Thu, 24 Jan 2019 at 16:58, Daniel Vetter wrote: > > If a non-legacy driver calls these it's valid to assume there is > interrupt support. The flag is really only needed for legacy drivers. ... legacy drivers which issue the IRQ via the DRM_IOCTL_CONTROL legacy IOCTL. At a later stage, we migh

Re: [Intel-gfx] [PATCH 26/26] drm/: Don't set FBINFO_(FLAG_)DEFAULT

2019-01-25 Thread Emil Velikov
On Thu, 24 Jan 2019 at 17:00, Daniel Vetter wrote: > > It's 0. > I'd add a bit more information here. Feel free to reuse as much/little of the following: Both macros evaluate to 0. At the same time flag is already set to zero since the struct is kzalloc'd in framebuffer_alloc(). As called by drm_

[PATCH] drm/fb-helper: generic: Fix drm_fbdev_client_restore()

2019-01-25 Thread Noralf Trønnes
If fbdev setup has failed, lastclose will give a NULL pointer deref: [ 77.794295] [drm:drm_lastclose] [ 77.794414] [drm:drm_lastclose] driver lastclose completed [ 77.794660] Unable to handle kernel NULL pointer dereference at virtual address 0014 [ 77.809460] pgd = b376b71b [ 77.81

Re: [Intel-gfx] [PATCH 03/26] drm/irq: Ditch DRIVER_IRQ_SHARED

2019-01-25 Thread Emil Velikov
On Thu, 24 Jan 2019 at 16:58, Daniel Vetter wrote: > > This is only used by drm_irq_install(), which is an optional helper. > And the right choice is to set it for all pci devices, and not for > everything else. > Can you please add some information (or reference) why it's the right choice? Thank

Re: [PATCH v3 1/4] drm/vc4: Wait for display list synchronization when completing commit

2019-01-25 Thread Paul Kocialkowski
Hi, On Wed, 2019-01-23 at 10:34 -0800, Eric Anholt wrote: > Paul Kocialkowski writes: > > > During an atomic commit, the HVS is configured with a display list > > for the channel matching the associated CRTC. The Pixel Valve (CRTC) > > and encoder are also configured for the new setup at that ti

Re: [PATCH] drm/vkms: Fix flush_work() without INIT_WORK().

2019-01-25 Thread Sean Paul
On Sat, Jan 19, 2019 at 01:43:43AM +0900, Tetsuo Handa wrote: > syzbot is hitting a lockdep warning [1] because flush_work() is called > without INIT_WORK() after kzalloc() at vkms_atomic_crtc_reset(). > > Commit 6c234fe37c57627a ("drm/vkms: Implement CRC debugfs API") added > INIT_WORK() to only

Re: [PATCH v3 2/4] drm/vc4: Report underrun errors

2019-01-25 Thread Paul Kocialkowski
Hi Eric, On Wed, 2019-01-23 at 10:47 -0800, Eric Anholt wrote: > Paul Kocialkowski writes: > > > From: Boris Brezillon > > > > The DRM framework provides a generic way to report underrun errors. > > Let's implement the necessary hooks to support it in the VC4 driver. > > > > Signed-off-by: Bo

Re: [PATCH] drm/rockchip: rgb: update SPDX license identifier

2019-01-25 Thread Heiko Stuebner
Am Mittwoch, 23. Januar 2019, 11:14:39 CET schrieb Sandy Huang: > update SPDX License Identifier from GPL-2.0+ to GPL-2.0 > and drop some GPL text. > > Signed-off-by: Sandy Huang I've added Fixes, Cc-stable and Reported-by (for Thomas) tags and applied it to drm-misc-fixes Thanks Heiko _

Re: [PATCH libdrm 2/2] xf85drm: de-duplicate drmParse{Platform.Host1x}{Bus, Device}Info

2019-01-25 Thread Eric Engestrom
On Wednesday, 2019-01-23 10:45:18 +, Emil Velikov wrote: > From: Emil Velikov > > The functions are virtually identical, fold them up. > > Signed-off-by: Emil Velikov Assuming patch 1 is OK, and `foo` gets renamed to something better: Reviewed-by: Eric Engestrom I don't know enough to re

[PATCH v2] i2c: of: Try to find an I2C adapter matching the parent

2019-01-25 Thread Thierry Reding
From: Thierry Reding If an I2C adapter doesn't match the provided device tree node, also try matching the parent's device tree node. This allows finding an adapter based on the device node of the parent device that was used to register it. This fixes a regression on Tegra124-based Chromebooks (N

[PATCH 2/2] drm/vmwgfx: Use ttm_dma_page_alloc_enabled

2019-01-25 Thread Thomas Hellstrom
Instead of guessing whether TTM has the dma page allocator enabled, ask TTM. Signed-off-by: Thomas Hellstrom --- drivers/gpu/drm/vmwgfx/vmwgfx_drv.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/gpu/drm/vmwgfx/vmwgfx_drv.c b/drivers/gpu/drm/vmwgfx/vmwgfx_drv.c

[PATCH 1/2] drm/ttm: Implement and export ttm_dma_page_alloc_enabled

2019-01-25 Thread Thomas Hellstrom
The vmwgfx driver needs to know whether the dma page pool is enabled to determine whether to refuse loading if the dma mode logic requests coherent memory from the dma page pool. Cc: "Koenig, Christian" Signed-off-by: Thomas Hellstrom --- drivers/gpu/drm/ttm/ttm_page_alloc_dma.c | 11 ++

Re: [PATCH 03/11] drm/simple-kms-helper: Add drm_simple_connector_create()

2019-01-25 Thread Noralf Trønnes
Den 24.01.2019 15.53, skrev Hans de Goede: > Hi, > > On 24-01-19 15:38, Noralf Trønnes wrote: >> [cc:Hans] >> >> Den 21.01.2019 10.22, skrev Daniel Vetter: >>> On Sun, Jan 20, 2019 at 12:43:10PM +0100, Noralf Trønnes wrote: This adds a function that creates a simple connector that has only

Re: [PATCH 0/5] tda998x updates

2019-01-25 Thread Brian Starkey
Hi, On Fri, Jan 25, 2019 at 11:56:09AM +, Russell King - ARM Linux admin wrote: > (Removed what I assume is a typo on the Cc line - n...@arm.com) Sadly not. I have to Cc (not Bcc!) n...@arm.com to remove the confidentiality disclaimer which would otherwise be added. Ugly, but my only option.

Re: [PATCH 0/5] tda998x updates

2019-01-25 Thread Russell King - ARM Linux admin
(Removed what I assume is a typo on the Cc line - n...@arm.com) On Fri, Jan 25, 2019 at 11:45:10AM +, Brian Starkey wrote: > Hi Russell, > > On Fri, Jan 25, 2019 at 09:40:38AM +, Russell King - ARM Linux admin > wrote: > > Hi, > > > > This series adds support for programming the SPD and

Re: [PATCH 0/5] tda998x updates

2019-01-25 Thread Brian Starkey
Hi Russell, On Fri, Jan 25, 2019 at 09:40:38AM +, Russell King - ARM Linux admin wrote: > Hi, > > This series adds support for programming the SPD and vendor infoframes. > > It also adds support for pixel repeated modes - we were not rejecting > these modes, but we also didn't have the imple

Re: [PATCH] drm: enable uncached DMA optimization for ARM and arm64

2019-01-25 Thread Christian König
Am 25.01.19 um 09:43 schrieb Ard Biesheuvel: On Thu, 24 Jan 2019 at 15:01, Alex Deucher wrote: On Thu, Jan 24, 2019 at 9:00 AM Ard Biesheuvel wrote: On Thu, 24 Jan 2019 at 13:31, Koenig, Christian wrote: Am 24.01.19 um 13:06 schrieb Ard Biesheuvel: The DRM driver stack is designed to work

Re: [PATCH v2 0/7] Replace ttm_bo_{unref,reference} with ttm_bo_{get|put}

2019-01-25 Thread Koenig, Christian
Reviewed-by: Christian König If there are no objections over the weekend I'm going to push that into upstream direction on monday. Thanks for the work, Christian. Am 25.01.19 um 12:02 schrieb Thomas Zimmermann: > This patchset cleans up the last remaining callers of ttm_bo_reference > and ttm_

Re: [PATCH] drm/panel: simple: fix AUO g185han01 horizontal blanking

2019-01-25 Thread Philipp Zabel
On Mon, 2018-11-12 at 18:41 +0100, Lucas Stach wrote: > The horizontal blanking periods are too short, as the values are > specified for a single LVDS channel. Since this panel is dual LVDS > they need to be doubled. With this change the panel reaches its > nominal vrefresh rate of 60Fps, instead o

[Bug 109456] KVM VFIO guest X hang with guest kernel > 4.15

2019-01-25 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=109456 Bug ID: 109456 Summary: KVM VFIO guest X hang with guest kernel > 4.15 Product: DRI Version: XOrg git Hardware: x86-64 (AMD64) OS: Linux (All) Status: NEW

[PATCH v2 4/7] drm/vmwgfx: Replace ttm_bo_reference with ttm_bo_get

2019-01-25 Thread Thomas Zimmermann
The function ttm_bo_get acquires a reference on a TTM buffer object. The function's name is more aligned to the Linux kernel convention of naming ref-counting function _get and _put. Signed-off-by: Thomas Zimmermann --- drivers/gpu/drm/vmwgfx/vmwgfx_bo.c | 5 +++-- drivers/gpu/drm/vmwgfx/v

[PATCH v2 2/7] drm/nouveau: Replace ttm_bo_reference with ttm_bo_get

2019-01-25 Thread Thomas Zimmermann
The function ttm_bo_get acquires a reference on a TTM buffer object. The function's name is more aligned to the Linux kernel convention of naming ref-counting function _get and _put. Signed-off-by: Thomas Zimmermann --- drivers/gpu/drm/nouveau/nouveau_bo.h | 7 ++- 1 file changed, 6 insertio

[PATCH v2 3/7] drm/nouveau: Replace ttm_bo_unref with ttm_bo_put

2019-01-25 Thread Thomas Zimmermann
The function ttm_bo_put releases a reference to a TTM buffer object. The function's name is more aligned to the Linux kernel convention of naming ref-counting function _get and _put. A call to ttm_bo_unref takes the address of the TTM BO object's pointer and clears the pointer's value to NULL. Thi

[PATCH v2 5/7] drm/vmwgfx: Replace ttm_bo_unref with ttm_bo_put

2019-01-25 Thread Thomas Zimmermann
The function ttm_bo_put releases a reference to a TTM buffer object. The function's name is more aligned to the Linux kernel convention of naming ref-counting function _get and _put. A call to ttm_bo_unref takes the address of the TTM BO object's pointer and clears the pointer's value to NULL. Thi

[PATCH v2 6/7] drm/mgag200: Replace ttm_bo_unref with ttm_bo_put

2019-01-25 Thread Thomas Zimmermann
The function ttm_bo_put releases a reference to a TTM buffer object. The function's name is more aligned to the Linux kernel convention of naming ref-counting function _get and _put. A call to ttm_bo_unref takes the address of the TTM BO object's pointer and clears the pointer's value to NULL. Thi

[PATCH v2 0/7] Replace ttm_bo_{unref, reference} with ttm_bo_{get|put}

2019-01-25 Thread Thomas Zimmermann
This patchset cleans up the last remaining callers of ttm_bo_reference and ttm_bo_unref. Calls are replaced with ttm_bo_get and ttm_bo_put, which follow Linux' get/put semantics more closely. The most notable difference is that ttm_bo_get does not clear the supplied pointer's value. This behaviou

[PATCH v2 1/7] drm/ast: Replace ttm_bo_unref with ttm_bo_put

2019-01-25 Thread Thomas Zimmermann
The function ttm_bo_put releases a reference to a TTM buffer object. The function's name is more aligned to the Linux kernel convention of naming ref-counting function _get and _put. A call to ttm_bo_unref takes the address of the TTM BO object's pointer and clears the pointer's value to NULL. Thi

[PATCH v2 7/7] drm/ttm: Remove ttm_bo_reference and ttm_bo_unref

2019-01-25 Thread Thomas Zimmermann
Both functions are obsolete and all calls have been replaced by ttm_bo_get and ttm_bo_put. Signed-off-by: Thomas Zimmermann --- drivers/gpu/drm/ttm/ttm_bo.c | 9 - include/drm/ttm/ttm_bo_api.h | 28 2 files changed, 37 deletions(-) diff --git a/drivers/gpu/

Re: [PATCH 01/26] drm/irq: Don't check for DRIVER_HAVE_IRQ in drm_irq_(un)install

2019-01-25 Thread Sam Ravnborg
Hi Daniel. On Thu, Jan 24, 2019 at 05:58:06PM +0100, Daniel Vetter wrote: > If a non-legacy driver calls these it's valid to assume there is > interrupt support. The flag is really only needed for legacy drivers. > > Also remove all the flag usage from non-legacy drivers. > > Signed-off-by: Dani

Re: [PATCH 4/5] drm/tegra: Restrict IOVA space to DMA mask

2019-01-25 Thread Dmitry Osipenko
24.01.2019 13:24, Mikko Perttunen пишет: > On 23.1.2019 21.42, Dmitry Osipenko wrote: >> 23.01.2019 18:55, Dmitry Osipenko пишет: >>> 23.01.2019 17:04, Thierry Reding пишет: On Wed, Jan 23, 2019 at 04:41:44PM +0300, Dmitry Osipenko wrote: > 23.01.2019 12:39, Thierry Reding пишет: >> Fr

Re: [PATCH 4/5] drm/tegra: Restrict IOVA space to DMA mask

2019-01-25 Thread Dmitry Osipenko
24.01.2019 16:27, Mikko Perttunen пишет: > On 24.1.2019 15.15, Dmitry Osipenko wrote: >> 24.01.2019 13:24, Mikko Perttunen пишет: >>> On 23.1.2019 21.42, Dmitry Osipenko wrote: 23.01.2019 18:55, Dmitry Osipenko пишет: > 23.01.2019 17:04, Thierry Reding пишет: >> On Wed, Jan 23, 2019 at

Re: [PATCH] drm/amd/display: add -msse2 to prevent Clang from emitting libcalls to undefined SW FP routines

2019-01-25 Thread Nathan Chancellor
On Thu, Jan 24, 2019 at 04:52:59PM -0800, ndesaulni...@google.com wrote: > arch/x86/Makefile disables SSE and SSE2 for the whole kernel. The > AMDGPU drivers modified in this patch re-enable SSE but not SSE2. Turn > on SSE2 to support emitting double precision floating point instructions > rather

[PATCH 2/2] phy: Add driver for mixel dphy

2019-01-25 Thread Guido Günther
This adds support for the Mixel DPHY as found on i.MX8 CPUs but since this is an IP core it will likely be found on others in the future. So instead of adding this to the nwl host driver make it a generic PHY driver. The driver supports the i.MX8MQ. Support for i.MX8QM and i.MX8QXP can be added on

Re: [v4,2/2] drm/panel: Add Feiyang FY07024DI26A30-D MIPI-DSI LCD panel

2019-01-25 Thread Bhushan Shah
On Fri, Jan 25, 2019 at 12:13:13AM +0530, Jagan Teki wrote: > Feiyang FY07024DI26A30-D is 1024x600, 4-lane MIPI-DSI LCD panel. > > Add panel driver for it. > > Signed-off-by: Jagan Teki Tested-by: Bhushan Shah -- Bhushan Shah http://blog.bshah.in IRC Nick : bshah on Freenode GPG key fingerpr

Re: [RFC PATCH] drm: disable WC optimization for cache coherent devices on non-x86

2019-01-25 Thread Ard Biesheuvel
On Thu, 24 Jan 2019 at 12:23, Koenig, Christian wrote: > > Am 24.01.19 um 10:59 schrieb Ard Biesheuvel: > > [SNIP] > > This is *exactly* my point the whole time. > > > > The current code has > > > > static inline bool drm_arch_can_wc_memory(void) > > { > > #if defined(CONFIG_PPC) && !defined(CONFI

[PATCH] drm/amd/display: add -msse2 to prevent Clang from emitting libcalls to undefined SW FP routines

2019-01-25 Thread ndesaulniers
arch/x86/Makefile disables SSE and SSE2 for the whole kernel. The AMDGPU drivers modified in this patch re-enable SSE but not SSE2. Turn on SSE2 to support emitting double precision floating point instructions rather than calls to non-existent (usually available from gcc_s or compiler_rt) floatin

Re: [RFC PATCH] drm: disable WC optimization for cache coherent devices on non-x86

2019-01-25 Thread Ard Biesheuvel
On Thu, 24 Jan 2019 at 10:25, Koenig, Christian wrote: > > Am 24.01.19 um 10:13 schrieb Christoph Hellwig: > > On Wed, Jan 23, 2019 at 05:52:50PM +0100, Ard Biesheuvel wrote: > >> But my concern is that it seems likely that non-cache coherent > >> implementations are relying on this hack as well.

Re: [PATCH 04/26] drm/fb-helper: Add fill_info() functions

2019-01-25 Thread Daniel Vetter
On Fri, Jan 25, 2019 at 10:46 AM Noralf Trønnes wrote: > > > > Den 25.01.2019 09.48, skrev Daniel Vetter: > > On Thu, Jan 24, 2019 at 06:40:52PM +0100, Noralf Trønnes wrote: > >> > >> > >> Den 24.01.2019 17.58, skrev Daniel Vetter: > >>> The fbdev split between fix and var information is kinda > >

  1   2   >