Re: [[DPU PATCH]] drm/msm/dpu: Correct dpu destroy and disable order

2018-11-01 Thread Jeykumar Sankaran
On 2018-11-01 23:17, Jayant Shekhar wrote: In case of msm drm bind failure, dpu_mdss_destroy is triggered. In this function, resources are freed and pm runtime disable is called, which triggers dpu_mdss_disable. Now in dpu_mdss_disable, driver tries to access a memory which is already freed. This

[PATCH v7 17/19] drm/i915/dp: Disable DSC in source by disabling DSS CTL bits

2018-11-01 Thread Manasi Navare
1. Disable Left/right VDSC branch in DSS Ctrl reg depending on the number of VDSC engines being used 2. Disable joiner in DSS Ctrl reg v4: * Remove encoder, make crtc_state const (Ville) v3 (From Manasi): * Add Disable PG2 for VDSC on eDP v2 (From Manasi): * Use old_crtc_state to find dsc para

[PATCH v7 09/19] drm/i915/dsc: Define & Compute VESA DSC params

2018-11-01 Thread Manasi Navare
From: Gaurav K Singh This patches does the following: 1. This patch defines all the DSC parameters as per the VESA DSC specification. These are stored in the encoder and used to compute the PPS parameters to be sent to the Sink. 2. Compute all the DSC parameters which are derived from DSC state

[PATCH v7 14/19] drm/i915/dp: Use the existing write_infoframe() for DSC PPS SDPs

2018-11-01 Thread Manasi Navare
Infoframes are used to send secondary data packets. This patch adds support for DSC Picture parameter set secondary data packets in the existing write_infoframe helpers. v3: * Unused variables cleanup (Ville) v2: * Rebase on drm-tip (Manasi) Cc: Jani Nikula Cc: Ville Syrjala Cc: Anusha Srivatsa

[PATCH v7 07/19] drm/i915/dp: Do not enable PSR2 if DSC is enabled

2018-11-01 Thread Manasi Navare
If a eDP panel supports both PSR2 and VDSC, our HW cannot support both at a time. Give priority to PSR2 if a requested resolution can be supported without compression else enable VDSC and keep PSR2 disabled. v3: * Rebase v2: * Add warning for DSC and PSR2 enabled together (DK) Cc: Rodrigo Vivi C

[PATCH v7 10/19] drm/i915/dsc: Compute Rate Control parameters for DSC

2018-11-01 Thread Manasi Navare
From: Gaurav K Singh This computation of RC params happens in the atomic commit phase during compute_config() to validate if display stream compression can be enabled for the requested mode. v6 (From Manasi): * Use 9 instead of 0x9 for consistency (Anusha) v5 (From Manasi): * Fix dim checkpatch

[PATCH v7 15/19] drm/i915/dp: Populate DSC PPS SDP and send PPS infoframes

2018-11-01 Thread Manasi Navare
DSC PPS secondary data packet infoframes are filled with DSC picure parameter set metadata according to the DSC standard. These infoframes are sent to the sink device and used during DSC decoding. v3: * Rename to intel_dp_write_pps_sdp (Ville) * Use const intel_crtc_state (Ville) v2: * Rebase ond

[PATCH v7 12/19] drm/i915/dsc: Add a power domain for VDSC on eDP/MIPI DSI

2018-11-01 Thread Manasi Navare
On Icelake, a separate power well PG2 is created for VDSC engine used for eDP/MIPI DSI. This patch adds a new display power domain for Power well 2. v3: * Call it POWER_DOMAIN_TRANSCODER_EDP_VDSC (Ville) * Move it around TRANSCODER power domain defs (Ville) v2: * Fix the power well mismatch CI er

[PATCH v7 19/19] drm/i915/dsc: Add Per connector debugfs node for DSC support/enable

2018-11-01 Thread Manasi Navare
DSC can be supported per DP connector. This patch adds a per connector debugfs node to expose DSC support capability by the kernel. The same node can be used from userspace to force DSC enable. force_dsc_en written through this debugfs node is used to force DSC even for lower resolutions. v3: * C

[PATCH v7 08/19] drm/dsc: Define the DSC 1.1 and 1.2 Line Buffer depth constants

2018-11-01 Thread Manasi Navare
DSC specification defines linebuf_depth which contains the line buffer bit depth used to generate the bitstream. These values are defined as per Table 4.1 in DSC 1.2 spec v2 (From Manasi): * Rename as MAX_LINEBUF_DEPTH for DSC 1.1 and DSC 1.2 Cc: dri-devel@lists.freedesktop.org Cc: Jani Nikula C

[PATCH v7 16/19] drm/i915/dp: Configure Display stream splitter registers during DSC enable

2018-11-01 Thread Manasi Navare
Display Stream Splitter registers need to be programmed to enable the joiner if two DSC engines are used and also to enable the left and the right DSC engines. This happens as part of the DSC enabling routine in the source in atomic commit. v4: * Remove redundant comment (Ville) v3: * Use cpu_tran

[PATCH v7 01/19] drm/dsc: Define Display Stream Compression PPS infoframe

2018-11-01 Thread Manasi Navare
This patch defines a new header file for all the DSC 1.2 structures and creates a structure for PPS infoframe which will be used to send picture parameter set secondary data packet for display stream compression. All the PPS infoframe syntax elements are taken from DSC 1.2 specification from VESA.

[PATCH v7 03/19] drm/dsc: Define Rate Control values that do not change over configurations

2018-11-01 Thread Manasi Navare
From: "Srivatsa, Anusha" DSC has some Rate Control values that remain constant across all configurations. These are as per the DSC standard. v3: * Define them in drm_dsc.h as they are DSC constants (Manasi) v2: * Add DP_DSC_ prefix (Jani Nikula) Cc: dri-devel@lists.freedesktop.org Cc: Manasi Na

[PATCH v7 02/19] drm/dsc: Define VESA Display Stream Compression Capabilities

2018-11-01 Thread Manasi Navare
This defines all the DSC parameters as per the VESA DSC spec that will be required for DSC encoder/decoder v6: (From Manasi) * Add a bit mask for RANGE_BPG_OFFSET for 6 bits(Manasi) v5 (From Manasi) * Add the RC constants as per the spec v4 (From Manasi) * Add the DSC_MUX_WORD_SIZE constants (Mana

[PATCH v7 06/19] drm/i915/dp: Compute DSC pipe config in atomic check

2018-11-01 Thread Manasi Navare
DSC params like the enable, compressed bpp, slice count and dsc_split are added to the intel_crtc_state. These parameters are set based on the requested mode and available link parameters during the pipe configuration in atomic check phase. These values are then later used to populate the remaining

[PATCH v7 04/19] drm/dsc: Add helpers for DSC picture parameter set infoframes

2018-11-01 Thread Manasi Navare
According to Display Stream compression spec 1.2, the picture parameter set metadata is sent from source to sink device using the DP Secondary data packet. An infoframe is formed for the PPS SDP header and PPS SDP payload bytes. This patch adds helpers to fill the PPS SDP header and PPS SDP payload

[PATCH v7 00/19] DSC enabling remaining patches

2018-11-01 Thread Manasi Navare
This patch series addresses review comments on previous DSC series: https://patchwork.freedesktop.org/series/47514/ Gaurav K Singh (3): drm/i915/dsc: Define & Compute VESA DSC params drm/i915/dsc: Compute Rate Control parameters for DSC drm/i915/dp: Enable/Disable DSC in DP Sink Manasi Nav

[PATCH v7 05/19] drm/i915/dp: Add DSC params and DSC config to intel_crtc_state

2018-11-01 Thread Manasi Navare
Basic DSC parameters and DSC configuration data needs to be computed for each of the requested mode during atomic check. This is required since for certain modes, valid DSC parameters and config data might not be computed in which case compression cannot be enabled for that mode. For that reason we

[PATCH v7 11/19] drm/i915/dp: Enable/Disable DSC in DP Sink

2018-11-01 Thread Manasi Navare
From: Gaurav K Singh This patch enables decompression support in sink device before link training and disables the same during the DDI disabling. v3 (From manasi): * Pass bool state to enable/disable (Ville) v2:(From Manasi) * Change the enable/disable function to take crtc_state instead of inte

[PATCH v7 18/19] drm/i915/dsc: Enable and disable appropriate power wells for VDSC

2018-11-01 Thread Manasi Navare
A separate power well 2 (PG2) is required for VDSC on eDP transcoder whereas all other transcoders use the power wells associated with the transcoders for VDSC. This patch adds a helper to obtain correct power domain depending on transcoder being used and enables/disables the power wells during VDS

[PATCH v7 13/19] drm/i915/dp: Configure i915 Picture parameter Set registers during DSC enabling

2018-11-01 Thread Manasi Navare
After encoder->pre_enable() hook, after link training sequence is completed, PPS registers for DSC encoder are configured using the DSC state parameters in intel_crtc_state as part of DSC enabling routine in the source. DSC enabling routine is called after encoder->pre_enable() before enbaling the

[v5 1/6] i915/dp/fec: Cache the FEC_CAPABLE DPCD register

2018-11-01 Thread Anusha Srivatsa
Similar to DSC DPCD registers, let us cache FEC_CAPABLE register to avoid using stale values. With this we can avoid aux reads everytime and instead read the cached values. v2: Avoid using memset and array for a single field. (Manasi,Jani) v3: Print FEC CAPABILITY value. (Manasi) Suggested-by: J

[v5 3/6] i915/dp/fec: Add fec_enable to the crtc state.

2018-11-01 Thread Anusha Srivatsa
For DP 1.4 and above, Display Stream compression can be enabled only if Forward Error Correctin can be performed. Add a crtc state for FEC. Currently, the state is determined by platform, DP and DSC being enabled. Moving forward we can use the state to have error correction on other scenarios too

[v5 6/6] drm/i915/fec: Disable FEC state.

2018-11-01 Thread Anusha Srivatsa
Set the suitable bits in DP_TP_CTL to stop bit correction when DSC is disabled. v2: - rebased. - Add additional check for compression state. (Gaurav) v3: rebased. v4: - Move the code to the proper spot according to spec (Ville) - Use proper checks (manasi) v5: Remove unnecessary checks (Ville)

[v5 5/6] i915/dp/fec: Configure the Forward Error Correction bits.

2018-11-01 Thread Anusha Srivatsa
If FEC is supported, the corresponding DP_TP_CTL register bits have to be configured. The driver has to program the FEC_ENABLE in DP_TP_CTL[30] register and wait till FEC_STATUS in DP_TP_CTL[28] is 1. Also add the warn message to make sure that the control register is already active while enabling

[v5 4/6] drm/i915/fec: Set FEC_READY in FEC_CONFIGURATION

2018-11-01 Thread Anusha Srivatsa
If the panel supports FEC, the driver has to set the FEC_READY bit in the dpcd register: FEC_CONFIGURATION. This has to happen before link training. v2: s/intel_dp_set_fec_ready/intel_dp_sink_set_fec_ready - change commit message. (Gaurav) v3: rebased. (r-b Manasi) v4: Use fec crtc state, be

[v5 2/6] drm/dp/fec: DRM helper for Forward Error Correction

2018-11-01 Thread Anusha Srivatsa
DP 1.4 has Forward Error Correction Support(FEC). Add helper function to check if the sink device supports FEC. v2: Separate the helper and the code that uses the helper into two separate patches. (Manasi) v3: - Move the code to drm_dp_helper.c (Manasi) - change the return type, code style change

[git pull] drm next fixes for 4.20-rc1

2018-11-01 Thread Dave Airlie
Hi Linus, Pretty much a normal fixes pull pre-rc1, mostly amdgpu fixes, one i915 link training regression fix, and a couple of minor panel/bridge fixes and a panel quirk. Thanks, Dave. drm-next-2018-11-02: drm, i915, amdgpu, bridge + core quirk The following changes since commit f2bfc71aee75feff

[Bug 201599] New: [drm:atom_op_jump [amdgpu]] *ERROR* atombios stuck in loop for more than 5secs aborting

2018-11-01 Thread bugzilla-daemon
https://bugzilla.kernel.org/show_bug.cgi?id=201599 Bug ID: 201599 Summary: [drm:atom_op_jump [amdgpu]] *ERROR* atombios stuck in loop for more than 5secs aborting Product: Drivers Version: 2.5 Kernel Version: 4.18.14-300.fc29.x86

[Bug 108533] [Polaris 20] 4.19.0 final unusable with RX580 - SDDM screen corruption, regression

2018-11-01 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=108533 Dieter Nützel changed: What|Removed |Added Status|RESOLVED|CLOSED -- You are receiving this mail

[Bug 108577] Black X laptop screen with cursor if HDMI not plugged in, bisected

2018-11-01 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=108577 --- Comment #18 from Duncan Roe --- Created attachment 142334 --> https://bugs.freedesktop.org/attachment.cgi?id=142334&action=edit Patch for Linux-19.0 to revert 5099114 & reinstate DRM_AMD_DC_FBC kconfig option -- You are receiving this ma

[PATCH v3] Add display nodes to SDM845 dtsi

2018-11-01 Thread Jeykumar Sankaran
Reviving the patch posted by Sean initially. This patch set adds MDSS and DSI nodes to SDM845 dtsi to enable display. The patches are tested on SDM845 MTP platform using the kernel based on [1]. Part of the dependent drivers are already posted on list. Rest of the dependencies are met using usin

[PATCH v3] arm64: dts: qcom: sdm845: Add dpu to sdm845 dts file

2018-11-01 Thread Jeykumar Sankaran
DPU is short for the Display Processing Unit. It is the display controller on Qualcomm SDM845 chips. This change adds MDSS and DSI nodes to enable display on the target device. Changes in v2: - Beefed up commit message - Use SoC specific compatibles for mdss and dpu (Rob H)

[PATCH] drm/amd/amdgpu/dm: Fix dm_dp_create_fake_mst_encoder()

2018-11-01 Thread Lyude Paul
[why] Removing connector reusage from DM to match the rest of the tree ended up revealing an issue that was surprisingly subtle. The original amdgpu code for DC that was submitted appears to have left a chunk in dm_dp_create_fake_mst_encoder() that tries to find a "master encoder", the likes of whi

[Bug 106175] amdgpu.dc=1 shows performance issues with Xorg compositors when moving windows

2018-11-01 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=106175 --- Comment #39 from gr...@sub.red --- (In reply to Michel Dänzer from comment #34) > > Right, you'd have to disable TearFree as well. Then I think the logs should represent that, even when the manpage tells me that tearfree is using page flipp

Re: [PATCH v6 11/28] drm/dsc: Add helpers for DSC picture parameter set infoframes

2018-11-01 Thread Manasi Navare
On Thu, Nov 01, 2018 at 04:54:14PM -0700, Manasi Navare wrote: > Thanks for reviewing this patch. Find some comments inline > > On Thu, Nov 01, 2018 at 06:46:28PM +0200, Ville Syrjälä wrote: > > On Wed, Oct 24, 2018 at 03:28:23PM -0700, Manasi Navare wrote: > > > According to Display Stream compre

[Bug 93829] [Wine] Lockup with MotoGP 2

2018-11-01 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=93829 Timothy Arceri changed: What|Removed |Added Resolution|--- |FIXED Status|NEEDINFO

Re: [PATCH v6 11/28] drm/dsc: Add helpers for DSC picture parameter set infoframes

2018-11-01 Thread Manasi Navare
Thanks for reviewing this patch. Find some comments inline On Thu, Nov 01, 2018 at 06:46:28PM +0200, Ville Syrjälä wrote: > On Wed, Oct 24, 2018 at 03:28:23PM -0700, Manasi Navare wrote: > > According to Display Stream compression spec 1.2, the picture > > parameter set metadata is sent from sourc

Re: [RFC] Generic cgroup controller for the gpu/drm subsystem

2018-11-01 Thread Matt Roper
+dri-devel list since a lot of the relevant audience is on that list. On Mon, Oct 29, 2018 at 07:49:13PM -0400, Kenny Ho wrote: > (Resending in plain text) > > Hi, > > We are thinking of using cgroup to manage resources in GPUs. I > believe Matt Roper from Intel has been trying to do something

[Bug 108613] amdgpu.dc=1 + xf86-video-amdgpu: changing to a GPU upscaling resolution resets pp_dpm_mclk

2018-11-01 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=108613 --- Comment #5 from tempel.jul...@gmail.com --- Yeah, looks like that. It also happens when changing ttys. -- You are receiving this mail because: You are the assignee for the bug.___ dri-devel mailin

Re: [PATCH v6 08/28] drm/dsc: Define Display Stream Compression PPS infoframe

2018-11-01 Thread Manasi Navare
On Thu, Nov 01, 2018 at 06:42:17PM +0200, Ville Syrjälä wrote: > On Wed, Oct 24, 2018 at 03:28:20PM -0700, Manasi Navare wrote: > > This patch defines a new header file for all the DSC 1.2 structures > > and creates a structure for PPS infoframe which will be used to send > > picture parameter set

[PATCH 2/2 v4] drm/panel: Add a driver for the TPO TPG110

2018-11-01 Thread Linus Walleij
The TPO (Toppoly) TPG110 is a pretty generic display driver similar in vein to the Ilitek 93xx devices. It is not a panel per se but a driver used with several low-cost noname panels. This is used on the Nomadik NHK15 combined with a OSD OSD057VA01CT display for WVGA 800x480. The driver is pretty

Re: [Freedreno] [DPU PATCH 3/3] drm/msm/dp: add support for DP PLL driver

2018-11-01 Thread Jordan Crouse
On Thu, Nov 01, 2018 at 05:03:15PM -0400, Sean Paul wrote: > On Wed, Oct 10, 2018 at 10:15:59AM -0700, Chandan Uddaraju wrote: > > Add the needed DP PLL specific files to support > > display port interface on msm targets. > > > > The DP driver calls the DP PLL driver registration. > > The DP drive

[PATCH 1/2 v4] drm/panel: Augment the TPO TPG110 bindings

2018-11-01 Thread Linus Walleij
The TPO TPG110 bindings were using the DPI bindings (popular in the fbdev subsystem) but this misses the finer points learned in the DRM subsystem. We need to augment the bindings for proper DRM integration: the timings are expressed by the hardware, not put into the device tree. I.e. this hardwar

[Bug 108613] amdgpu.dc=1 + xf86-video-amdgpu: changing to a GPU upscaling resolution resets pp_dpm_mclk

2018-11-01 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=108613 --- Comment #4 from dwagner --- This is most certainly a duplicate of bug https://bugs.freedesktop.org/show_bug.cgi?id=107141 (which I would really really like to be fixed one day...) -- You are receiving this mail because: You are the assigne

Re: [DPU PATCH 3/3] drm/msm/dp: add support for DP PLL driver

2018-11-01 Thread Sean Paul
On Wed, Oct 10, 2018 at 10:15:59AM -0700, Chandan Uddaraju wrote: > Add the needed DP PLL specific files to support > display port interface on msm targets. > > The DP driver calls the DP PLL driver registration. > The DP driver sets the link and pixel clock sources. > > Signed-off-by: Chandan Ud

Re: [PATCH v2 0/7] BL035-RGB-002 3.5" LCD sunxi DRM support

2018-11-01 Thread Paul Kocialkowski
Hi, Le jeudi 01 novembre 2018 à 21:00 +0100, Paul Kocialkowski a écrit : > The series adds support for the BL035-RGB-002 LCD panel and the required > device-tree bindings for using it on the BananaPi M1. > > Only the changes related to the DRM driver and the panel are submitted > for merge, which

Re: [PATCH] Add RGBA64 texture cpp for vc4 driver.

2018-11-01 Thread Eric Anholt
Nick Kreeger writes: > This patch is needed to help implement half-float texturing and > rendering for the vc4 driver in mesa. This small patch introduces the > cpp value for the RGBA64 texture. A future patch will include updates to > vc4_render_cl.c to handle HDR color stores. We'll need a GET

[PATCH v2 5/7] drm/panel: simple: Add support for the LeMaker BL035-RGB-002 3.5" LCD

2018-11-01 Thread Paul Kocialkowski
This adds support for the 3.5" LCD panel from LeMaker, sold for use with BananaPi boards. It comes with a 24-bit RGB888 parallel interface and requires an active-low DE signal Signed-off-by: Paul Kocialkowski --- drivers/gpu/drm/panel/panel-simple.c | 27 +++ 1 file chang

[PATCH NOT FOR MERGE v2 7/7] ARM: dts: sun7i-a20-bananapi: Add bindings for the LeMaker 3.5" LCD

2018-11-01 Thread Paul Kocialkowski
This adds the backlight panel, power, pwm and tcon0 device-tree bindings required for supporting the 3.5" LCD from LeMaker on the BananaPi M1. Signed-off-by: Paul Kocialkowski --- arch/arm/boot/dts/sun7i-a20-bananapi.dts | 89 1 file changed, 89 insertions(+) diff --git

[PATCH NOT FOR MERGE v2 6/7] ARM: dts: sun7i: Add pinmux configuration for LCD0 RGB888 pins

2018-11-01 Thread Paul Kocialkowski
This adds the pin muxing definition for configuring the PD pins in LCD0 mode for a RGB888 format to the sun7i device-tree. Signed-off-by: Paul Kocialkowski --- arch/arm/boot/dts/sun7i-a20.dtsi | 11 +++ 1 file changed, 11 insertions(+) diff --git a/arch/arm/boot/dts/sun7i-a20.dtsi b/arc

[PATCH v2 4/7] dt-bindings: Add bindings for the LeMaker BL035-RGB-002 LCD panel

2018-11-01 Thread Paul Kocialkowski
This adds the device-tree bindings for the LeMaker BL035-RGB-002 3.5" QVGA TFT LCD panel, compatible with simple-panel. Signed-off-by: Paul Kocialkowski --- .../bindings/display/panel/lemaker,bl035-rgb-002.txt | 7 +++ 1 file changed, 7 insertions(+) create mode 100644 Documentation/

[PATCH v2 3/7] dt-bindings: Add vendor prefix for LeMaker

2018-11-01 Thread Paul Kocialkowski
This introduces a new device-tree binding vendor prefix for Shenzhen LeMaker Technology Co., Ltd. Signed-off-by: Paul Kocialkowski --- Documentation/devicetree/bindings/vendor-prefixes.txt | 1 + 1 file changed, 1 insertion(+) diff --git a/Documentation/devicetree/bindings/vendor-prefixes.txt

[PATCH v2 2/7] drm/sun4i: tcon: Support an active-low DE signal with RGB interface

2018-11-01 Thread Paul Kocialkowski
Some panels need an active-low data enable (DE) signal for the RGB interface. This requires flipping a bit in the TCON0 polarity register when setting up the mode for the RGB interface. Match the associated bus flag and use it to set the polarity inversion bit for the DE signal when required. Sig

[PATCH v2 0/7] BL035-RGB-002 3.5" LCD sunxi DRM support

2018-11-01 Thread Paul Kocialkowski
The series adds support for the BL035-RGB-002 LCD panel and the required device-tree bindings for using it on the BananaPi M1. Only the changes related to the DRM driver and the panel are submitted for merge, which does not include the two final commits. Changes since v1: * Used the full name of

[PATCH v2 1/7] drm/sun4i: tcon: Pass encoder instead of using panel for RGB setup

2018-11-01 Thread Paul Kocialkowski
Features such as dithering and pixel data edge configuration currently rely on the panel registered with the TCON driver. However, bridges are also supported in addition panels. Instead of retrieving the connector from the panel, pass the encoder from the calling function, as is done for other int

[Bug 108628] Middle-Earth: Shadow of Mordor: artifacts in benchmark mode

2018-11-01 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=108628 Bug ID: 108628 Summary: Middle-Earth: Shadow of Mordor: artifacts in benchmark mode Product: Mesa Version: 18.2 Hardware: Other OS: Linux (All)

Re: [Freedreno] [PATCH 1/2] drm/msm: use common display thread for dispatching vblank events

2018-11-01 Thread Jordan Crouse
On Wed, Oct 31, 2018 at 05:19:04PM -0700, Jeykumar Sankaran wrote: > DPU was using one thread per display to dispatch async > commits and vblank requests. Since clean up already happened > in msm to use the common thread for all the display commits, > display threads are only used to cater vblank r

[Bug 108627] [CI][BAT] igt@pm_rpm@module-reload - timeout - pm_rpm: executing$

2018-11-01 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=108627 Martin Peres changed: What|Removed |Added Status|RESOLVED|CLOSED -- You are receiving this mail b

Re: [Freedreno] [PATCH 2/2] drm/msm: subclass work object for vblank events

2018-11-01 Thread Sean Paul
On Wed, Oct 31, 2018 at 05:19:05PM -0700, Jeykumar Sankaran wrote: > msm maintains a separate structure to define vblank > work definitions and a list to track events submitted > to the display worker thread. We can avoid these > redundant list and its protection mechanism, if we > subclass the wor

Re: [Freedreno] [PATCH 1/2] drm/msm: use common display thread for dispatching vblank events

2018-11-01 Thread Sean Paul
On Wed, Oct 31, 2018 at 05:19:04PM -0700, Jeykumar Sankaran wrote: > DPU was using one thread per display to dispatch async > commits and vblank requests. Since clean up already happened > in msm to use the common thread for all the display commits, > display threads are only used to cater vblank r

[PATCH 3/3] drm/atomic: Use explicit old/new state in drm_atomic_plane_check()

2018-11-01 Thread Ville Syrjala
From: Ville Syrjälä Convert drm_atomic_plane_check() over to using explicit old vs. new plane states. Avoids the confusion of "what does plane->state mean again?". Signed-off-by: Ville Syrjälä --- drivers/gpu/drm/drm_atomic.c | 90 ++-- 1 file changed, 46 insert

[PATCH 2/3] drm/atomic: Use explicit old/new state in drm_atomic_crtc_check()

2018-11-01 Thread Ville Syrjala
From: Ville Syrjälä Convert drm_atomic_crtc_check() over to using explicit old vs. new crtc states. Avoids the confusion of "what does crtc->state mean again?". Signed-off-by: Ville Syrjälä --- drivers/gpu/drm/drm_atomic.c | 26 +++--- 1 file changed, 15 insertions(+), 11 d

[PATCH 1/3] drm/atomic: Use explicit old crtc state in drm_atomic_add_affected_planes()

2018-11-01 Thread Ville Syrjala
From: Ville Syrjälä Replace 'crtc->state' with the explicit old crtc state. Actually it shouldn't matter whether we use the old or the new crtc state here since any plane that has been removed from the crtc since the crtc state was duplicated will have been added to the atomic state already. Tha

[Bug 106175] amdgpu.dc=1 shows performance issues with Xorg compositors when moving windows

2018-11-01 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=106175 --- Comment #38 from bmil...@gmail.com --- (In reply to tempel.julian from comment #37) > I think software cursor would also be unusable even if it left pageflipping > on. It causes nasty issues like flickering cursor or other visual corruption.

[Bug 108627] [CI][BAT] igt@pm_rpm@module-reload - timeout - pm_rpm: executing$

2018-11-01 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=108627 Martin Peres changed: What|Removed |Added Status|NEW |RESOLVED Resolution|---

[Bug 108075] [CI][BAT] igt@amdgpu/amd_prime@(amd-to-i915|i915-to-amd) - timeout - last line in dmesg "[IGT] amd_prime: executing"

2018-11-01 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=108075 --- Comment #2 from Martin Peres --- *** Bug 108627 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are the assignee for the bug.___ dri-devel mailing list

[Bug 108075] [CI][BAT] igt@amdgpu/amd_prime@(amd-to-i915|i915-to-amd) - timeout - last line in dmesg "[IGT] amd_prime: executing"

2018-11-01 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=108075 Martin Peres changed: What|Removed |Added Component|DRM/Intel |IGT QA Contact|intel-gfx-bugs@li

[Bug 108627] [CI][BAT] igt@pm_rpm@module-reload - timeout - pm_rpm: executing$

2018-11-01 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=108627 Martin Peres changed: What|Removed |Added Component|DRM/Intel |IGT QA Contact|intel-gfx-bugs@li

[Bug 106175] amdgpu.dc=1 shows performance issues with Xorg compositors when moving windows

2018-11-01 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=106175 --- Comment #37 from tempel.jul...@gmail.com --- I think software cursor would also be unusable even if it left pageflipping on. It causes nasty issues like flickering cursor or other visual corruption. -- You are receiving this mail because: Y

[Bug 106175] amdgpu.dc=1 shows performance issues with Xorg compositors when moving windows

2018-11-01 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=106175 --- Comment #36 from bmil...@gmail.com --- So, to help find the origin of the issue, there are a few options that get rid of stutter when compositing: 1 - amdgpu.dc=0 - The old DC seems unaffected by the bug. 2 - SWcursor on - Unaffected by bug

[Bug 108625] AMDGPU - Can't even get Xorg to start - Kernel driver hangs with ring buffer timeout on ARM64

2018-11-01 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=108625 --- Comment #1 from Alex Deucher --- Please attach your full dmesg output and xorg log if using X. -- You are receiving this mail because: You are the assignee for the bug.___ dri-devel mailing list

[Bug 106175] amdgpu.dc=1 shows performance issues with Xorg compositors when moving windows

2018-11-01 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=106175 --- Comment #35 from bmil...@gmail.com --- (In reply to Michel Dänzer from comment #31) > Note that SWcursor completely disables page flipping, at least with > xf86-video-amdgpu, because the two things are fundamentally incompatible > with each o

[Bug 108606] Raven Ridge: constant lockups since latest pull from Linus

2018-11-01 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=108606 --- Comment #16 from Samantha McVey --- Created attachment 142330 --> https://bugs.freedesktop.org/attachment.cgi?id=142330&action=edit amdgpu.ppfeaturemask=0xfffdbfff lockup during normal usage I did more testing on amdgpu.ppfeaturemask=0xff

[Bug 201585] 144Hz 2560x1440 no longer works (caps at 120Hz)

2018-11-01 Thread bugzilla-daemon
https://bugzilla.kernel.org/show_bug.cgi?id=201585 --- Comment #8 from Dan Acristinii (d...@acristinii.com) --- Created attachment 279289 --> https://bugzilla.kernel.org/attachment.cgi?id=279289&action=edit 4.18 with drm.debug=4 I think I added it in the right way -- You are receiving this ma

Re: [PATCH v4 3/4] drm: Document variable refresh properties

2018-11-01 Thread Kazlauskas, Nicholas
On 11/1/18 1:05 PM, Michel Dänzer wrote: > On 2018-11-01 3:58 p.m., Kazlauskas, Nicholas wrote: >> On 11/1/18 6:58 AM, Michel Dänzer wrote: >>> On 2018-10-31 6:54 p.m., Kazlauskas, Nicholas wrote: On 10/31/18 12:20 PM, Michel Dänzer wrote: > On 2018-10-31 3:41 p.m., Kazlauskas, Nicholas wr

Re: [PATCH v1] drm/msm: Move fence put to where failure occurs

2018-11-01 Thread Robert Foss
Hey Chris, On 2018-11-01 17:26, Chris Wilson wrote: Quoting Robert Foss (2018-11-01 16:12:28) If dma_fence_wait fails to wait for a supplied in-fence in msm_ioctl_gem_submit, make sure we release that in-fence. Also remove this dma_fence_put() from the 'out' label. Signed-off-by: Robert Foss

Re: [PATCH v4 3/4] drm: Document variable refresh properties

2018-11-01 Thread Michel Dänzer
On 2018-11-01 3:58 p.m., Kazlauskas, Nicholas wrote: > On 11/1/18 6:58 AM, Michel Dänzer wrote: >> On 2018-10-31 6:54 p.m., Kazlauskas, Nicholas wrote: >>> On 10/31/18 12:20 PM, Michel Dänzer wrote: On 2018-10-31 3:41 p.m., Kazlauskas, Nicholas wrote: > On 10/31/18 10:12 AM, Michel Dänzer

[PATCH v8] drm/fourcc: Add char_per_block, block_w and block_h in drm_format_info

2018-11-01 Thread Alexandru-Cosmin Gheorghe
For some pixel formats .cpp structure in drm_format info it's not enough to describe the peculiarities of the pixel layout, for example tiled formats or packed formats at bit level. What's implemented here is to add three new members to drm_format_info that could describe such formats: - char_per

[Bug 107402] [Intel GFX CI][BAT] igt@amdgpu_amd_basic@userptr - incomplete - general protection fault: 0000 [#1] PREEMPT SMP PTI, __mmu_notifier_release

2018-11-01 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=107402 Martin Peres changed: What|Removed |Added Status|RESOLVED|CLOSED -- You are receiving this mail b

[Bug 107402] [Intel GFX CI][BAT] igt@amdgpu_amd_basic@userptr - incomplete - general protection fault: 0000 [#1] PREEMPT SMP PTI, __mmu_notifier_release

2018-11-01 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=107402 Martin Peres changed: What|Removed |Added Resolution|--- |WORKSFORME Status|NEW

Re: [Intel-gfx] [PATCH v6 08/28] drm/dsc: Define Display Stream Compression PPS infoframe

2018-11-01 Thread Ville Syrjälä
On Thu, Nov 01, 2018 at 06:42:17PM +0200, Ville Syrjälä wrote: > On Wed, Oct 24, 2018 at 03:28:20PM -0700, Manasi Navare wrote: > > This patch defines a new header file for all the DSC 1.2 structures > > and creates a structure for PPS infoframe which will be used to send > > picture parameter set

[Bug 108606] Raven Ridge: constant lockups since latest pull from Linus

2018-11-01 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=108606 --- Comment #15 from Samantha McVey --- Alex, The conditions in your patch never get triggered. I added some print statements in there, and gfx_v9_0_init_rlc_ext_microcode(adev) runs, but `adev->powerplay.pp_feature &= ~PP_GFXOFF_MASK` never run

[Bug 102646] Screen flickering under amdgpu-experimental [buggy auto power profile]

2018-11-01 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=102646 --- Comment #39 from bmil...@gmail.com --- Another interesting info, even with amdgpu.dc=0 I get flickering @75hz. Difference is the flickering immediatly stops when I switch back to 60hz (no need to reboot or switch monitor off/on) -- You are

Re: [PATCH v6 11/28] drm/dsc: Add helpers for DSC picture parameter set infoframes

2018-11-01 Thread Ville Syrjälä
On Wed, Oct 24, 2018 at 03:28:23PM -0700, Manasi Navare wrote: > According to Display Stream compression spec 1.2, the picture > parameter set metadata is sent from source to sink device > using the DP Secondary data packet. An infoframe is formed > for the PPS SDP header and PPS SDP payload bytes.

Re: [PATCH v6 08/28] drm/dsc: Define Display Stream Compression PPS infoframe

2018-11-01 Thread Ville Syrjälä
On Wed, Oct 24, 2018 at 03:28:20PM -0700, Manasi Navare wrote: > This patch defines a new header file for all the DSC 1.2 structures > and creates a structure for PPS infoframe which will be used to send > picture parameter set secondary data packet for display stream compression. > All the PPS inf

[Bug 107222] [Intel GFX CI] Many "*ERROR* amdgpu: IB test timed out." messages in dmesg

2018-11-01 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=107222 Martin Peres changed: What|Removed |Added Resolution|--- |WORKSFORME Status|NEW

[Bug 107222] [Intel GFX CI] Many "*ERROR* amdgpu: IB test timed out." messages in dmesg

2018-11-01 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=107222 Martin Peres changed: What|Removed |Added Status|RESOLVED|CLOSED -- You are receiving this mail b

[Bug 107221] [Intel GFX CI] Plenty of "*ERROR* VCE not responding, trying to reset the ECPU!!!" in dmesg

2018-11-01 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=107221 Martin Peres changed: What|Removed |Added Status|RESOLVED|CLOSED -- You are receiving this mail b

[Bug 107221] [Intel GFX CI] Plenty of "*ERROR* VCE not responding, trying to reset the ECPU!!!" in dmesg

2018-11-01 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=107221 Martin Peres changed: What|Removed |Added Status|NEW |RESOLVED Resolution|---

Re: [PATCH v1] drm/msm: Move fence put to where failure occurs

2018-11-01 Thread Chris Wilson
Quoting Robert Foss (2018-11-01 16:12:28) > If dma_fence_wait fails to wait for a supplied in-fence in > msm_ioctl_gem_submit, make sure we release that in-fence. > > Also remove this dma_fence_put() from the 'out' label. > > Signed-off-by: Robert Foss > --- > drivers/gpu/drm/msm/msm_gem_submit

Re: [PATCH 0/3] omapdrm: Fix runtime PM issues at module load and unload time

2018-11-01 Thread Laurent Pinchart
Hi Tony, On Thursday, 1 November 2018 17:58:56 EET Tony Lindgren wrote: > * Laurent Pinchart [181101 12:13]: > > On Thursday, 1 November 2018 13:47:40 EET Tomi Valkeinen wrote: > > > We do dispc_runtime_get/put in the HDMI driver's suspend/resume too, so > > > don't we need similar hack (as you a

[PATCH v1] drm/msm: Move fence put to where failure occurs

2018-11-01 Thread Robert Foss
If dma_fence_wait fails to wait for a supplied in-fence in msm_ioctl_gem_submit, make sure we release that in-fence. Also remove this dma_fence_put() from the 'out' label. Signed-off-by: Robert Foss --- drivers/gpu/drm/msm/msm_gem_submit.c | 10 +- 1 file changed, 5 insertions(+), 5 del

[Bug 108625] AMDGPU - Can't even get Xorg to start - Kernel driver hangs with ring buffer timeout on ARM64

2018-11-01 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=108625 Bug ID: 108625 Summary: AMDGPU - Can't even get Xorg to start - Kernel driver hangs with ring buffer timeout on ARM64 Product: DRI Version: unspecified Hardware: ARM

[Bug 108613] amdgpu.dc=1 + xf86-video-amdgpu: changing to a GPU upscaling resolution resets pp_dpm_mclk

2018-11-01 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=108613 Michel Dänzer changed: What|Removed |Added Attachment #142328|text/x-log |text/plain mime type|

[Bug 108613] amdgpu.dc=1 + xf86-video-amdgpu: changing to a GPU upscaling resolution resets pp_dpm_mclk

2018-11-01 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=108613 Michel Dänzer changed: What|Removed |Added Attachment #142327|text/x-log |text/plain mime type|

[Bug 106175] amdgpu.dc=1 shows performance issues with Xorg compositors when moving windows

2018-11-01 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=106175 --- Comment #34 from Michel Dänzer --- (In reply to tempel.julian from comment #33) > I suppose TearFree forces pageflipping regardless, as we don't see any > tearing with that configuration. Right, you'd have to disable TearFree as well. Can b

[Bug 108098] Ryzen 7 2700U, amdgpu, graphics freezes on 4.19.0-041900-generic

2018-11-01 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=108098 --- Comment #7 from Michel Dänzer --- FWIW, I advise against paying too much attention to fin4478. They are not involved in driver development and known for making rather questionable suggestions which are definitely not suitable for everyone.

Re: [PATCH v6 3/9] drm: mali-dp: Enable Mali-DP tiled buffer formats

2018-11-01 Thread Liviu Dudau
On Thu, Nov 01, 2018 at 01:31:06PM +, Alexandru-Cosmin Gheorghe wrote: > Hi, > > Liviu, can I merge this through drm-misc-next. Yeah, that is fine with me. Best regards, Liviu > > On Mon, Oct 29, 2018 at 05:14:38PM +, Alexandru-Cosmin Gheorghe wrote: > > Enable the following formats >

[pull] amdgpu drm-next-4.20

2018-11-01 Thread Alex Deucher
Hi Dave, Fixes for 4.20. Highlights: - Fix flickering at low backlight levels on some systems - Fix some overclocking regressions - Vega20 updates for - GPU recovery fixes - Disable gfxoff on RV as some sbios/fw combinations are not stable yet The following changes since commit 0af5c656fdb797f74

  1   2   >