Re: [PATCH 2/2] drm/scheduler: stop setting rq to NULL

2018-07-30 Thread Christian König
Am 30.07.2018 um 22:51 schrieb Andrey Grodzovsky: On 07/30/2018 09:30 AM, Nayan Deshmukh wrote: On Mon, Jul 30, 2018 at 4:33 PM Christian König > wrote: We removed the redundancy of having an extra scheduler field, so we can't set the rq t

Re: [PATCH] drm/amdgpu/pm: Fix potential Spectre v1

2018-07-30 Thread Christian König
Am 30.07.2018 um 22:14 schrieb Alex Deucher: On Mon, Jul 30, 2018 at 5:55 AM, Michel Dänzer wrote: On 2018-07-24 10:53 PM, Alex Deucher wrote: On Mon, Jul 23, 2018 at 12:32 PM, Gustavo A. R. Silva wrote: idx can be indirectly controlled by user-space, hence leading to a potential exploitatio

Re: [PATCH 1/2] drm/amd: Replace ttm_bo_reference with ttm_bo_get

2018-07-30 Thread Christian König
Am 31.07.2018 um 08:11 schrieb Thomas Zimmermann: The function ttm_bo_get acquires a reference on a TTM buffer object. The function's name is more aligned to the Linux kernel convention of naming ref-counting function _get and _put. Signed-off-by: Thomas Zimmermann amdgpu patches should actua

[PATCH] staging/vboxvideo: Replace ttm_bo_unref with ttm_bo_put

2018-07-30 Thread Thomas Zimmermann
The function ttm_bo_put releases a reference to a TTM buffer object. The function's name is more aligned to the Linux kernel convention of naming ref-counting function _get and _put. A call to ttm_bo_unref takes the address of the TTM BO object's pointer and clears the pointer's value to NULL. Thi

[PATCH] drm/qxl: Replace ttm_bo_unref with ttm_bo_put

2018-07-30 Thread Thomas Zimmermann
The function ttm_bo_put releases a reference to a TTM buffer object. The function's name is more aligned to the Linux kernel convention of naming ref-counting function _get and _put. A call to ttm_bo_unref takes the address of the TTM BO object's pointer and clears the pointer's value to NULL. Thi

[PATCH] drm/mgag200: Replace ttm_bo_unref with ttm_bo_put

2018-07-30 Thread Thomas Zimmermann
The function ttm_bo_put releases a reference to a TTM buffer object. The function's name is more aligned to the Linux kernel convention of naming ref-counting function _get and _put. A call to ttm_bo_unref takes the address of the TTM BO object's pointer and clears the pointer's value to NULL. Thi

[PATCH] drm/hisilicon: Replace ttm_bo_unref with ttm_bo_put

2018-07-30 Thread Thomas Zimmermann
The function ttm_bo_put releases a reference to a TTM buffer object. The function's name is more aligned to the Linux kernel convention of naming ref-counting function _get and _put. A call to ttm_bo_unref takes the address of the TTM BO object's pointer and clears the pointer's value to NULL. Thi

[PATCH] drm/cirrus: Replace ttm_bo_unref with ttm_bo_put

2018-07-30 Thread Thomas Zimmermann
The function ttm_bo_put releases a reference to a TTM buffer object. The function's name is more aligned to the Linux kernel convention of naming ref-counting function _get and _put. A call to ttm_bo_unref takes the address of the TTM BO object's pointer and clears the pointer's value to NULL. Thi

[PATCH] drm/bochs: Replace ttm_bo_unref with ttm_bo_put

2018-07-30 Thread Thomas Zimmermann
The function ttm_bo_put releases a reference to a TTM buffer object. The function's name is more aligned to the Linux kernel convention of naming ref-counting function _get and _put. A call to ttm_bo_unref takes the address of the TTM BO object's pointer and clears the pointer's value to NULL. Thi

[PATCH 0/2] Clean-up TTM BO ref-counting interface

2018-07-30 Thread Thomas Zimmermann
This patchset replaces ttm_bo_{reference/unref} with ttm_bo_{get,put}, which follow Linux' conventions for ref-counting functions. Thomas Zimmermann (2): Replace ttm_bo_reference with ttm_bo_get drm/vmwgfx: Replace ttm_bo_unref with ttm_bo_put drivers/gpu/drm/vmwgfx/vmwgfx_bo.c | 11 ++

[PATCH 2/2] drm/vmwgfx: Replace ttm_bo_unref with ttm_bo_put

2018-07-30 Thread Thomas Zimmermann
The function ttm_bo_put releases a reference to a TTM buffer object. The function's name is more aligned to the Linux kernel convention of naming ref-counting function _get and _put. A call to ttm_bo_unref takes the address of the TTM BO object's pointer and clears the pointer's value to NULL. Thi

[PATCH 1/2] Replace ttm_bo_reference with ttm_bo_get

2018-07-30 Thread Thomas Zimmermann
The function ttm_bo_get acquires a reference on a TTM buffer object. The function's name is more aligned to the Linux kernel convention of naming ref-counting function _get and _put. Signed-off-by: Thomas Zimmermann --- drivers/gpu/drm/vmwgfx/vmwgfx_bo.c | 5 +++-- drivers/gpu/drm/vmwgfx/v

[PATCH 0/2] Clean-up TTM BOref-counting interface

2018-07-30 Thread Thomas Zimmermann
This patchset replaces ttm_bo_{reference/unref} with ttm_bo_{get,put}, which follow Linux' conventions for ref-counting functions. Thomas Zimmermann (2): drm/virtio: Replace ttm_bo_reference with ttm_bo_get drm/virtio: Replace ttm_bo_unref with ttm_bo_put drivers/gpu/drm/virtio/virtgpu_drv.h

[PATCH 1/2] drm/virtio: Replace ttm_bo_reference with ttm_bo_get

2018-07-30 Thread Thomas Zimmermann
The function ttm_bo_get acquires a reference on a TTM buffer object. The function's name is more aligned to the Linux kernel convention of naming ref-counting function _get and _put. Signed-off-by: Thomas Zimmermann --- drivers/gpu/drm/virtio/virtgpu_drv.h | 2 +- 1 file changed, 1 insertion(+),

RE: [PATCH v6 01/35] drm: hdcp2.2 authentication msg definitions

2018-07-30 Thread Shankar, Uma
>-Original Message- >From: dri-devel [mailto:dri-devel-boun...@lists.freedesktop.org] On Behalf Of >Ramalingam C >Sent: Saturday, July 14, 2018 8:45 AM >To: intel-...@lists.freedesktop.org; dri-devel@lists.freedesktop.org; >dan...@ffwll.ch; seanp...@chromium.org; Winkler, Tomas >; Usyskin

[PATCH 2/2] drm/virtio: Replace ttm_bo_unref with ttm_bo_put

2018-07-30 Thread Thomas Zimmermann
The function ttm_bo_put releases a reference to a TTM buffer object. The function's name is more aligned to the Linux kernel convention of naming ref-counting function _get and _put. A call to ttm_bo_unref takes the address of the TTM BO object's pointer and clears the pointer's value to NULL. Thi

[PATCH 2/2] drm/radeon: Replace ttm_bo_unref with ttm_bo_put

2018-07-30 Thread Thomas Zimmermann
The function ttm_bo_put releases a reference to a TTM buffer object. The function's name is more aligned to the Linux kernel convention of naming ref-counting function _get and _put. A call to ttm_bo_unref takes the address of the TTM BO object's pointer and clears the pointer's value to NULL. Thi

[PATCH 1/2] drm/radeon: Replace ttm_bo_reference with ttm_bo_get

2018-07-30 Thread Thomas Zimmermann
The function ttm_bo_get acquires a reference on a TTM buffer object. The function's name is more aligned to the Linux kernel convention of naming ref-counting function _get and _put. Signed-off-by: Thomas Zimmermann --- drivers/gpu/drm/radeon/radeon_object.c | 2 +- 1 file changed, 1 insertion(+

[PATCH 2/2] drm/nouveau: Replace ttm_bo_unref with ttm_bo_put

2018-07-30 Thread Thomas Zimmermann
The function ttm_bo_put releases a reference to a TTM buffer object. The function's name is more aligned to the Linux kernel convention of naming ref-counting function _get and _put. A call to ttm_bo_unref takes the address of the TTM BO object's pointer and clears the pointer's value to NULL. Thi

[PATCH 1/2] drm/nouveau: Replace ttm_bo_reference with ttm_bo_get

2018-07-30 Thread Thomas Zimmermann
The function ttm_bo_get acquires a reference on a TTM buffer object. The function's name is more aligned to the Linux kernel convention of naming ref-counting function _get and _put. Signed-off-by: Thomas Zimmermann --- drivers/gpu/drm/nouveau/nouveau_bo.h | 7 ++- 1 file changed, 6 insertio

[PATCH] drm/ast: Replace ttm_bo_unref with ttm_bo_put

2018-07-30 Thread Thomas Zimmermann
The function ttm_bo_put releases a reference to a TTM buffer object. The function's name is more aligned to the Linux kernel convention of naming ref-counting function _get and _put. A call to ttm_bo_unref takes the address of the TTM BO object's pointer and clears the pointer's value to NULL. Thi

[PATCH 1/2] drm/amd: Replace ttm_bo_reference with ttm_bo_get

2018-07-30 Thread Thomas Zimmermann
The function ttm_bo_get acquires a reference on a TTM buffer object. The function's name is more aligned to the Linux kernel convention of naming ref-counting function _get and _put. Signed-off-by: Thomas Zimmermann --- drivers/gpu/drm/amd/amdgpu/amdgpu_object.c | 2 +- 1 file changed, 1 inserti

[PATCH 2/2] Replace ttm_bo_unref with ttm_bo_put

2018-07-30 Thread Thomas Zimmermann
The function ttm_bo_put releases a reference to a TTM buffer object. The function's name is more aligned to the Linux kernel convention of naming ref-counting function _get and _put. A call to ttm_bo_unref takes the address of the TTM BO object's pointer and clears the pointer's value to NULL. Thi

[PATCH 14/23] drm/dsc: Define the DSC 1.1 and 1.2 Line Buffer depth constants

2018-07-30 Thread Manasi Navare
From: Gaurav K Singh DSC specification defines linebuf_depth which contains the line buffer bit depth used to generate the bitstream. These values are defined as per Table 4.1 in DSC 1.2 spec v2 (From Manasi): * Rename as MAX_LINEBUF_DEPTH for DSC 1.1 and DSC 1.2 Cc: dri-devel@lists.freedesktop

[PATCH 08/23] drm/dsc: Define VESA Display Stream Compression Capabilities

2018-07-30 Thread Manasi Navare
From: Gaurav K Singh This defines all the DSC parameters as per the VESA DSC spec that will be required for DSC encoder/decoder v4 (From Manasi) * Add the DSC_MUX_WORD_SIZE constants (Manasi) v3 (From Manasi) * Remove the duplicate define (Suggested By:Harry Wentland) v2: Define this struct in

[PATCH 06/23] drm/dp: Define payload size for DP SDP PPS packet

2018-07-30 Thread Manasi Navare
DP 1.4 spec defines DP secondary data packet for DSC picture parameter set. This patch defines its payload size according to the DP 1.4 specification. Signed-off-by: Manasi Navare Cc: dri-devel@lists.freedesktop.org Cc: Gaurav K Singh Cc: Jani Nikula Cc: Ville Syrjala Cc: Anusha Srivatsa Revi

[PATCH 10/23] drm/dsc: Add helpers for DSC picture parameter set infoframes

2018-07-30 Thread Manasi Navare
According to Display Stream compression spec 1.2, the picture parameter set metadata is sent from source to sink device using the DP Secondary data packet. An infoframe is formed for the PPS SDP header and PPS SDP payload bytes. This patch adds helpers to fill the PPS SDP header and PPS SDP payload

[PATCH 03/23] drm/dp: DRM DP helper/macros to get DP sink DSC parameters

2018-07-30 Thread Manasi Navare
This patch adds inline functions and helpers for obtaining DP sink's supported DSC parameters like DSC sink support, eDP compressed BPP supported, maximum slice count supported by the sink devices, DSC line buffer bit depth supported on DP sink, DSC sink maximum color depth by parsing corresponding

[PATCH 07/23] drm/dsc: Define Display Stream Compression PPS infoframe

2018-07-30 Thread Manasi Navare
This patch defines a new header file for all the DSC 1.2 structures and creates a structure for PPS infoframe which will be used to send picture parameter set secondary data packet for display stream compression. All the PPS infoframe syntax elements are taken from DSC 1.2 specification from VESA.

[PATCH 09/23] drm/dsc: Define Rate Control values that do not change over configurations

2018-07-30 Thread Manasi Navare
From: "Srivatsa, Anusha" DSC has some Rate Control values that remain constant across all configurations. These are as per the DSC standard. v3: * Define them in drm_dsc.h as they are DSC constants (Manasi) v2: * Add DP_DSC_ prefix (Jani Nikula) Cc: dri-devel@lists.freedesktop.org Cc: Manasi Na

[PATCH 01/23] drm/dp: Add DP DSC DPCD receiver capability size define and missing SHIFT

2018-07-30 Thread Manasi Navare
This patch defines the DP DSC receiver capability size that gives total number of DP DSC DPCD registers. This also adds a missing #defines for DP DSC support missed in the commit id (ab6a46ea6842ce "Add DPCD definitions for DP 1.4 DSC feature") v3: * MIN_SLICE_WIDTH = 2560 (Anusha) * Define DP_DSC

[PATCH 00/23] Enable Display Stream Compression on eDP/DP

2018-07-30 Thread Manasi Navare
Cc: dri-devel@lists.freedesktop.org VESA has developed an industry standard Display Stream Compression(DSC) for interoperable, visually lossless compression over display links to address the needs for higher resolution displays. This patch series enables DSC on Gen 10 eDP and Gen 11 eDP/DP panels

[Bug 107432] Periodic complete system lockup with Vega M and Kernel 4.18-rc6+

2018-07-30 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=107432 Robert Strube changed: What|Removed |Added Attachment #140902|0 |1 is obsolete|

[Bug 107432] Periodic complete system lockup with Vega M and Kernel 4.18-rc6+

2018-07-30 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=107432 Bug ID: 107432 Summary: Periodic complete system lockup with Vega M and Kernel 4.18-rc6+ Product: DRI Version: unspecified Hardware: x86-64 (AMD64) OS: Lin

[PATCH v2] drm/nouveau: Fix potential memory access error in nouveau_debugfs_pstate_get()

2018-07-30 Thread Lyude Paul
nouveau_debugfs(drm) will never be NULL, because we're taking the value of the potentially null device pointer and adding to it so it isn't 0x0. So, check if drm is NULL instead. Signed-off-by: Lyude Paul Cc: Karol Herbst --- Forgot to hit :w before committing, whoops! drivers/gpu/drm/nouveau/

[PATCH] drm/nouveau: Fix potential memory access error in nouveau_debugfs_pstate_get()

2018-07-30 Thread Lyude Paul
nouveau_debugfs(drm) will never be NULL, because we're taking the value of the potentially null device pointer and adding to it so it isn't 0x0. So, check if drm is NULL instead. Signed-off-by: Lyude Paul Cc: Karol Herbst --- drivers/gpu/drm/nouveau/nouveau_debugfs.c | 5 +++-- 1 file changed,

[PATCH 1/2] drm/nouveau: Print debug message on ACPI probe event

2018-07-30 Thread Lyude Paul
Signed-off-by: Lyude Paul --- drivers/gpu/drm/nouveau/nouveau_display.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/gpu/drm/nouveau/nouveau_display.c b/drivers/gpu/drm/nouveau/nouveau_display.c index ec7861457b84..b2a93e3fa67b 100644 --- a/drivers/gpu/drm/nouveau/nouveau_display.

[PATCH 2/2] drm/nouveau: Prevent redundant connector probes from ACPI

2018-07-30 Thread Lyude Paul
On the Lenovo P50 I've been working on, ACPI notifications for hotplugs always seem happen even while the GPU has it's hotplugs enabled. This means that we're uselessly scheduling two connector probes every time we get a hotplug. Since we can't unregister the acpi handler without causing userspace

[PATCH v3 8/8] drm/nouveau: Call pm_runtime_get_noresume() from hpd handlers

2018-07-30 Thread Lyude Paul
We can't and don't need to try resuming the device from our hotplug handlers, but hotplug events are generally something we'd like to keep the device awake for whenever possible. So, grab a PM ref safely in our hotplug handlers using pm_runtime_get_noresume() and mark the device as busy once we're

[PATCH v3 1/8] drm/nouveau: Fix bogus drm_kms_helper_poll_enable() placement

2018-07-30 Thread Lyude Paul
Turns out this part is my fault for not noticing when reviewing 9a2eba337cace ("drm/nouveau: Fix drm poll_helper handling"). Currently we call drm_kms_helper_poll_enable() from nouveau_display_hpd_work(). This makes basically no sense however, because that means we're calling drm_kms_helper_poll_en

[PATCH v3 5/8] drm/nouveau: Use pm_runtime_get_noresume() in connector_detect()

2018-07-30 Thread Lyude Paul
It's true we can't resume the device from poll workers in nouveau_connector_detect(). We can however, prevent the autosuspend timer from elapsing immediately if it hasn't already without risking any sort of deadlock with the runtime suspend/resume operations. So do that instead of entirely avoiding

[PATCH v3 4/8] drm/nouveau: Fix deadlock with fb_helper using new helpers

2018-07-30 Thread Lyude Paul
This removes the potential of deadlocking with fb_helper entirely by preventing it from handling hotplugs during the runtime suspend process as early as possible in the suspend process. If it turns out this is not possible, due to some fb_helper action having been queued up before we got a time to

[PATCH v3 3/8] drm/fb_helper: Introduce hotplug_suspend/resume()

2018-07-30 Thread Lyude Paul
I'm sure I don't need to tell you that fb_helper's locking is a mess. That being said; fb_helper's locking mess can seriously complicate the runtime suspend/resume operations of drivers because it can invoke atomic commits and connector probing from anywhere that calls drm_fb_helper_hotplug_event()

[PATCH v3 7/8] drm/nouveau: Fix deadlocks in nouveau_connector_detect()

2018-07-30 Thread Lyude Paul
When we disable hotplugging on the GPU, we need to be able to synchronize with each connector's hotplug interrupt handler before the interrupt is finally disabled. This can be a problem however, since nouveau_connector_detect() currently grabs a runtime power reference when handling connector probi

[PATCH v3 6/8] drm/nouveau: Respond to HPDs by probing one conn at a time

2018-07-30 Thread Lyude Paul
There isn't actually any reason we need to call drm_hpd_irq_event() from our hotplug handler, as we already know which connector the hotplug event was fired for. We're also going to need to avoid probing all connectors needlessly from hotplug handlers anyway so that we can track when nouveau_connec

[PATCH v3 0/8] Fix connector probing deadlocks from RPM bugs

2018-07-30 Thread Lyude Paul
This is the next version of https://patchwork.freedesktop.org/series/46815/ With a lot more thought put into it so as to avoid the potential deadlock scenarios I missed. This also required fixing some bogus DRM helper usage. Try and deadlock me now, nouveau. I dare you!!! Lyude Paul (8): drm/n

[PATCH v3 2/8] drm/nouveau: Enable polling even if we have runtime PM

2018-07-30 Thread Lyude Paul
Having runtime PM makes no difference on whether or not we want polling, and it's now safe to just enable polling unconditionally in drm_load() thanks to d61a5c106351 ("drm/nouveau: Fix deadlock on runtime suspend") Signed-off-by: Lyude Paul Cc: Lukas Wunner Cc: Peter Ujfalusi Cc: sta...@vger.k

Re: [PATCH v3.1 08/10] dt-bindings: sun4i-drm: add HDMI VCC supply property for sun8i-dw-hdmi

2018-07-30 Thread Rob Herring
On Fri, Jul 27, 2018 at 01:12:55AM +0800, Icenowy Zheng wrote: > Allwiner SoCs with DesignWare HDMI controller all come with a "HVCC" > pin, which is the VCC of HDMI part. > > Add a supply property to specify HVCC's regulator in the device tree. > > Signed-off-by: Icenowy Zheng > --- > Changes i

[git pull] drm udl fixes

2018-07-30 Thread Dave Airlie
Pull request to myself just so it's logged and linked in right place, but this is a set of Mikulas's udl kms patches I've looked over and am happy with. Dave. The following changes since commit acb1872577b346bd15ab3a3f8dff780d6cca4b70: Linux 4.18-rc7 (2018-07-29 14:44:52 -0700) are available

Re: [PATCH] drm: Convert drm_atomic_helper_suspend/resume()

2018-07-30 Thread Laurent Pinchart
Hi Souptick, Thank you for the patch. On Monday, 30 July 2018 22:01:37 EEST Souptick Joarder wrote: > convert drm_atomic_helper_suspend/resume() to use > drm_mode_config_helper_suspend/resume(). > > With this conversion, drm_fbdev_cma_set_suspend_unlocked() > will left with no consumer. So this

[Bug 107152] GPU fault detected: 146 / VM_CONTEXT1_PROTECTION_FAULT / ring gfx timeout

2018-07-30 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=107152 --- Comment #3 from krzys...@cybulski.info --- Hi, I get this GPU hung, 1-2 a day, mostly when using PHPStorm (Java based PHP Editor) System is KDE Neon (Ubuntu 18.04 + latest KDE), I use padoka PPA (currently 1:18.2~git180730133900.0ea243d~b~p

Re: [PATCH 2/2] drm/scheduler: stop setting rq to NULL

2018-07-30 Thread Andrey Grodzovsky
On 07/30/2018 09:30 AM, Nayan Deshmukh wrote: On Mon, Jul 30, 2018 at 4:33 PM Christian König > wrote: We removed the redundancy of having an extra scheduler field, so we can't set the rq to NULL any more or otherwise won't know which sc

Re: [PATCH 1/2] drm/scheduler: only kill entity if last user is killed v2

2018-07-30 Thread Andrey Grodzovsky
I believe that in this case if (!entity->rq) {     DRM_ERROR...     return; } clause will take place. P.S I remember we planned to actually propagate the error back to the caller so i guess we should take care of this sooner or later. The change is Reviewed-by: Andrey Grodzovsky Andrey

Re: [PATCH] drm/amdgpu/pm: Fix potential Spectre v1

2018-07-30 Thread Alex Deucher
On Mon, Jul 30, 2018 at 5:55 AM, Michel Dänzer wrote: > On 2018-07-24 10:53 PM, Alex Deucher wrote: >> On Mon, Jul 23, 2018 at 12:32 PM, Gustavo A. R. Silva >> wrote: >>> idx can be indirectly controlled by user-space, hence leading to a >>> potential exploitation of the Spectre variant 1 vulnera

Re: [PATCH v2] drm/vkms: Use new return type vm_fault_t

2018-07-30 Thread Gustavo Padovan
Hi Souptick, On Thu, Jul 26, 2018 at 08:15:49PM +0530, Souptick Joarder wrote: > Use new return type vm_fault_t for fault handler. > > Signed-off-by: Souptick Joarder > --- > v2: Updated patch title > > drivers/gpu/drm/vkms/vkms_drv.h | 2 +- > drivers/gpu/drm/vkms/vkms_gem.c | 5 ++--- > 2 fi

[PATCH 3/3] drm: rcar-du: Improve non-DPLL clock selection

2018-07-30 Thread Jacopo Mondi
DU channels not equipped with a DPLL use an internal (aka SoC provided) or external clock source combined with an internal divider to generate the desired output dot clock frequency. The current clock selection procedure does not fully exploit the ability of external clock sources to generate the

[PATCH 0/3] drm: rcar-du: Rework clock configuration

2018-07-30 Thread Jacopo Mondi
Hello this series improves the DU peripheral input clock selection procedure, fixing high-resolution modes for non-DPLL channels, as DPAD and LVDS ones. The first patch in the series is a rework from Laurent of the clock selection procedure, clearly separating DPLL equipped channels from channe

[PATCH 2/3] drm: rcar-du: Rename var to a more precise name

2018-07-30 Thread Jacopo Mondi
Rename the 'value' variable, only used to for writing to DMSR register to a more precise 'dmsr' name. Signed-off-by: Laurent Pinchart Signed-off-by: Jacopo Mondi --- drivers/gpu/drm/rcar-du/rcar_du_crtc.c | 12 ++-- 1 file changed, 6 insertions(+), 6 deletions(-) diff --git a/drivers/g

[PATCH 1/3] drm: rcar-du: Rework clock configuration based on hardware limits

2018-07-30 Thread Jacopo Mondi
From: Laurent Pinchart The DU channels that have a display PLL (DPLL) can only use external clock sources, and don't have an internal clock divider (with the exception of H3 ES1.x where the post-divider is present and needs to be used as a workaround for a DPLL silicon issue). Rework the clock c

Re: [PATCH v4 0/4] Add infrastructure needed for CRC support

2018-07-30 Thread Sean Paul
On Tue, Jul 24, 2018 at 07:25:38PM +0300, Haneen Mohammed wrote: > This patchset add the necessary infrastructure needed later for CRC > support. > > 1. add functions to map buffers to kernel address space. > 2. map/unmap buffers in the prepare/cleanup_fb hooks. > 3. clip plane coordinates. > 4. s

Re: [PATCH] drm/bridge/tc358764: fix drm helper name

2018-07-30 Thread Sean Paul
On Fri, Jul 27, 2018 at 11:48:59AM +0200, Andrzej Hajda wrote: > Recently drm_mode_connector_attach_encoder changed it's name. The change > was not noticed by bridge author, as a result gcc reports compile error > on next branch. > > Fixes: f38b7cca6d0e ("drm/bridge: tc358764: Add DSI to LVDS brid

[PATCH] drm/bridge/ti-sn65dsi86: Fix implicit declaration to drm_mode_connector_attach_encoder

2018-07-30 Thread Sean Paul
This function name was changed to drm_connector_attach_encoder(). Unfortunately this driver was posted on the list before that change, and applied after Fixes: a095f15c00e2 ("drm/bridge: add support for sn65dsi86 bridge driver") Cc: Sandeep Panda Cc: Andrzej Hajda Cc: Archit Taneja Cc: Laurent

[Bug 107428] Flickering artifacts in OpenRA with Vega 56

2018-07-30 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=107428 --- Comment #3 from Isaac Curtis --- Created attachment 140900 --> https://bugs.freedesktop.org/attachment.cgi?id=140900&action=edit video of artifacts I captured a small video to show the nature of the artifacts. -- You are receiving this

[Bug 107428] Flickering artifacts in OpenRA with Vega 56

2018-07-30 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=107428 --- Comment #2 from Isaac Curtis --- A second machine works just fine without the artifacts. Same kernel, same Mesa version. Glinfo: GL_VERSION: 3.0 Mesa 18.1.4 GL_RENDERER: Mesa DRI Intel(R) Haswell Mobile GL_VENDOR: Intel Open Source Technol

[Bug 107428] Flickering artifacts in OpenRA with Vega 56

2018-07-30 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=107428 Michel Dänzer changed: What|Removed |Added Version|unspecified |git Product|DRI

[Bug 107428] Flickering artifacts in OpenRA with Vega 56

2018-07-30 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=107428 Bug ID: 107428 Summary: Flickering artifacts in OpenRA with Vega 56 Product: DRI Version: unspecified Hardware: x86-64 (AMD64) OS: Linux (All) Status: NEW

Re: [PATCH] drm/rcar-du: Convert drm_atomic_helper_suspend/resume()

2018-07-30 Thread Laurent Pinchart
Hi Souptick, On Monday, 30 July 2018 18:13:13 EEST Souptick Joarder wrote: > On Mon, Jul 30, 2018 at 7:54 PM, Laurent Pinchart wrote: > > On Monday, 30 July 2018 16:58:09 EEST Souptick Joarder wrote: > >> On Sun, Jul 29, 2018 at 1:50 AM, Laurent Pinchart wrote: > >>> On Saturday, 28 July 2018 21:5

[Bug 105725] WARNING: CPU: 0 PID: 487 at drivers/gpu/drm/amd/amdgpu/../display /dc/gpio/gpio_base.c:64 dal_gpio_open_ex+0xc/0x30 [amdgpu]

2018-07-30 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=105725 Marc Thomas changed: What|Removed |Added CC||m...@dragonfly.plus.com --- Comment #7 fr

[Bug 107367] [regression, bisected] Games freeze the PC with newest AMD Staging DRM Next Kernel

2018-07-30 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=107367 --- Comment #9 from Gregor Münch --- Created attachment 140895 --> https://bugs.freedesktop.org/attachment.cgi?id=140895&action=edit Freeze with Shadow of Mordor I applied both patches and the crash with Dota2 is fixed. However I tried with

Re: [PATCH] drm/rcar-du: Convert drm_atomic_helper_suspend/resume()

2018-07-30 Thread Laurent Pinchart
Hi Souptick, On Monday, 30 July 2018 16:58:09 EEST Souptick Joarder wrote: > On Sun, Jul 29, 2018 at 1:50 AM, Laurent Pinchart wrote: > > On Saturday, 28 July 2018 21:50:58 EEST Souptick Joarder wrote: > >> On Sat, Jul 28, 2018 at 11:20 PM, Vaishali Thakkar wrote: > >>> On Sat, Jul 28, 2018 at 9:1

Re: [RFC PATCHv2 4/9] drm/tidss: add new driver for TI Keystone platforms

2018-07-30 Thread Laurent Pinchart
Hi Tomi, (CC'ing Jacopo Mondi for a comment about bus_formats in bridge drivers) Thank you for the patch. On Monday, 18 June 2018 16:22:37 EEST Tomi Valkeinen wrote: > This patch adds a new DRM driver for Texas Instruments DSS6 IP used on > Texas Instruments Keystone K2G SoC. The DSS6 IP is a ma

RE: Fix broken Raven system before Linux 4.18 release

2018-07-30 Thread Huang, Ray
Yes, that patch won't change any code logic, and just a cleanup. Thanks, Ray -Original Message- From: Koenig, Christian Sent: Monday, July 30, 2018 9:31 PM To: Paul Menzel ; Huang, Ray ; Alex Deucher Cc: amd-...@lists.freedesktop.org; dri-devel@lists.freedesktop.org Subject: Re: Fix br

Re: [PATCH][drm-next] drm/msm/disp/dpu: fix two spelling mistakes

2018-07-30 Thread Sean Paul
On Mon, Jul 30, 2018 at 02:44:46PM +0100, Colin King wrote: > From: Colin Ian King > > Trivial fix to spelling mistake in error messages > "diable" -> "disable" > "cliend" -> "client" > > Signed-off-by: Colin Ian King Reviewed-by: Sean Paul > --- > drivers/gpu/drm/msm/disp/dpu1/dpu_encoder.

[PATCH][drm-next] drm/msm/disp/dpu: fix two spelling mistakes

2018-07-30 Thread Colin King
From: Colin Ian King Trivial fix to spelling mistake in error messages "diable" -> "disable" "cliend" -> "client" Signed-off-by: Colin Ian King --- drivers/gpu/drm/msm/disp/dpu1/dpu_encoder.c | 2 +- drivers/gpu/drm/msm/disp/dpu1/dpu_power_handle.c | 2 +- 2 files changed, 2 insertions(+)

Re: [PATCH 1/2] drm/scheduler: only kill entity if last user is killed v2

2018-07-30 Thread Nayan Deshmukh
Hi Christian, The code looks good to me. But I was just wondering what will happen when the last user is killed and some other user tries to push to the entity. Regards, Nayan Deshmukh On Mon, Jul 30, 2018 at 4:33 PM Christian König < ckoenig.leichtzumer...@gmail.com> wrote: > Note which task i

Re: [PATCH] drm/kms/crtc: Saving crtc->primary into a drm_plane pointer instead of dereferencing it every time.

2018-07-30 Thread Sean Paul
On Mon, Jul 30, 2018 at 11:35:58AM +0530, Satendra Singh Thakur wrote: > In the func __drm_mode_set_config_internal, > objects (fb, old_fb, crtc) of crtc->primary are used at many places. > To access the objects of primary, it is dereferenced from crtc every > time. It's better to save it into drm_

Re: Fix broken Raven system before Linux 4.18 release

2018-07-30 Thread Christian König
Hi Paul, well that is rather odd, cause the patch you pointed out is just a code cleanup without functional change. Can you double check your bisect result again? Thanks, Christian. Am 30.07.2018 um 14:35 schrieb Paul Menzel: Dear Linux folks, On 07/04/18 12:43, Christian König wrote: Am

Re: [PATCH 2/2] drm/scheduler: stop setting rq to NULL

2018-07-30 Thread Nayan Deshmukh
On Mon, Jul 30, 2018 at 4:33 PM Christian König < ckoenig.leichtzumer...@gmail.com> wrote: > We removed the redundancy of having an extra scheduler field, so we > can't set the rq to NULL any more or otherwise won't know which > scheduler to use for the cleanup. > > Just remove the entity from the

[resend][pull] drm/msm: msm-next for 4.19

2018-07-30 Thread Rob Clark
re-send to fix s-o-b vs committer problem that I overlooked. Sorry, Stephen Rothwell's email about it was lost in the noise. original pull msg: Hi Dave, A bit larger this time around, due to introduction of "dpu1" support for the display controller in sdm845 and beyond. This has been on list a

Re: [PATCH] drm/sched: remove unneeded -Iinclude/drm compiler flag

2018-07-30 Thread Christian König
Am 30.07.2018 um 14:49 schrieb Nayan Deshmukh: On Sat, Jul 28, 2018 at 6:54 PM Masahiro Yamada mailto:yamada.masah...@socionext.com>> wrote: Hi. 2018-07-06 14:12 GMT+09:00 Masahiro Yamada mailto:yamada.masah...@socionext.com>>: > I refactored the include directives under in

Re: [PATCH] drm/sched: remove unneeded -Iinclude/drm compiler flag

2018-07-30 Thread Nayan Deshmukh
On Sat, Jul 28, 2018 at 6:54 PM Masahiro Yamada < yamada.masah...@socionext.com> wrote: > Hi. > > 2018-07-06 14:12 GMT+09:00 Masahiro Yamada >: > > I refactored the include directives under include/drm/ some time ago. > > This flag is unneeded. > > > A minor nit-pick in the commit message, someth

Re: [PATCH] v4l: vsp1: Fix deadlock in VSPDL DRM pipelines

2018-07-30 Thread Mauro Carvalho Chehab
Em Sat, 28 Jul 2018 20:13:05 +0100 Kieran Bingham escreveu: > Hi Laurent, Mauro, > > I've cast my eyes through this, and the driver code it affects > > On 27/07/18 18:19, Laurent Pinchart wrote: > > The VSP uses a lock to protect the BRU and BRS assignment when > > configuring pipelines. The lo

Re: [RFC PATCHv2 2/9] dt-bindings: display/ti: add k2g-dss bindings

2018-07-30 Thread Tomi Valkeinen
On 24/07/18 17:29, Laurent Pinchart wrote: > Hi Tomi, > > Thank you for the patch. > > On Monday, 18 June 2018 16:22:35 EEST Tomi Valkeinen wrote: >> Add DT bindings for Texas Instruments K2G SoC Display Subsystem. The DSS >> is quite simple, with a single plane and a single output. >> >> Signed-

Re: [RFC PATCHv2 3/9] dt-bindings: display/ti: add am65x-dss bindings

2018-07-30 Thread Tomi Valkeinen
On 30/07/18 02:04, Laurent Pinchart wrote: > Hi Tomi, > > Thank you for the patch. > > On Monday, 18 June 2018 16:22:36 EEST Tomi Valkeinen wrote: >> Add DT bindings for Texas Instruments AM65x SoC Display Subsystem. The >> DSS7 on AM65x SoC has two video ports (DPI and OLDI) and two video >> pi

Re: [PATCH v2] backlight: pwm_bl: switch to using "atomic" PWM API

2018-07-30 Thread Daniel Thompson
On Fri, Jul 27, 2018 at 05:11:21PM +0200, Enric Balletbo i Serra wrote: > The "atomic" API allows us to configure PWM period and duty_cycle and > enable it in one call. > > The patch also moves the pwm_init_state just before any use of the > pwm_state struct, this fixes a potential bug where pwm_g

[Bug 107367] [regression, bisected] Games freeze the PC with newest AMD Staging DRM Next Kernel

2018-07-30 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=107367 --- Comment #8 from Christian König --- Created attachment 140889 --> https://bugs.freedesktop.org/attachment.cgi?id=140889&action=edit Possible fix Yeah, I see. Please test the new fix for this. -- You are receiving this mail because: You

[PATCH 1/2] drm/scheduler: only kill entity if last user is killed v2

2018-07-30 Thread Christian König
Note which task is using the entity and only kill it if the last user of the entity is killed. This should prevent problems when entities are leaked to child processes. v2: add missing kernel doc Signed-off-by: Christian König --- drivers/gpu/drm/scheduler/gpu_scheduler.c | 6 +- include/dr

[PATCH 2/2] drm/scheduler: stop setting rq to NULL

2018-07-30 Thread Christian König
We removed the redundancy of having an extra scheduler field, so we can't set the rq to NULL any more or otherwise won't know which scheduler to use for the cleanup. Just remove the entity from the scheduling list instead. Signed-off-by: Christian König --- drivers/gpu/drm/scheduler/gpu_schedul

[PATCH] udlfb: handle unplug properly

2018-07-30 Thread Mikulas Patocka
The udlfb driver maintained an open count and cleaned up itself when the count reached zero. But the console is also counted in the reference count - so, if the user unplugged the device, the open count would not drop to zero and the driver stayed loaded with console attached. If the user re-plugge

Re: [PATCH] fb: fix lost console when the user unplugs a USB adapter

2018-07-30 Thread Mikulas Patocka
On Wed, 25 Jul 2018, Bartlomiej Zolnierkiewicz wrote: > > Can unregister_framebuffer() be called when /dev/fb0 is open as a file > > handle and/or mapped to some process? > > It should be OK. > > > > Moreover the dlfb <-> fb_info locking scheme seems to be reversed > > > (+racy) as it is dlfb

[Bug 107384] random tab crashes in firefox nightly

2018-07-30 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=107384 Michel Dänzer changed: What|Removed |Added Status|NEW |RESOLVED Resolution|---

Re: [PATCH] drm/amdgpu/pm: Fix potential Spectre v1

2018-07-30 Thread Michel Dänzer
On 2018-07-24 10:53 PM, Alex Deucher wrote: > On Mon, Jul 23, 2018 at 12:32 PM, Gustavo A. R. Silva > wrote: >> idx can be indirectly controlled by user-space, hence leading to a >> potential exploitation of the Spectre variant 1 vulnerability. >> >> This issue was detected with the help of Smatch

Re: Decrease boot time by not probing unconnected ports to improve desktop user experience

2018-07-30 Thread Michel Dänzer
On 2018-07-28 09:10 PM, Paul Menzel wrote: > Dear Linux folks, > > > It looks like, that loading a graphics driver, the DRM methods probe > each connector. > > For example, the Asus F2A85-M PRO has four monitor ports, but only one > monitor is connected over DVI. Here is the log excerpt with Lin

[Bug 200645] 4.18-rc regression bisected to e03fd3f30: amdgpu polaris11/rx460 only activates on one output/monitor of two

2018-07-30 Thread bugzilla-daemon
https://bugzilla.kernel.org/show_bug.cgi?id=200645 --- Comment #5 from Duncan (1i5t5.dun...@cox.net) --- (In reply to Alex Deucher from comment #4) > Fixed. See: > https://bugs.freedesktop.org/show_bug.cgi?id=106959 Not fixed as of 4.18-rc7 and thus not a dup. The merge including the patch for

RE: [PATCH v6 00/35] drm/i915: Implement HDCP2.2

2018-07-30 Thread Shankar, Uma
>-Original Message- >From: dri-devel [mailto:dri-devel-boun...@lists.freedesktop.org] On Behalf Of >Ramalingam C >Sent: Saturday, July 14, 2018 8:45 AM >To: intel-...@lists.freedesktop.org; dri-devel@lists.freedesktop.org; >dan...@ffwll.ch; seanp...@chromium.org; Winkler, Tomas >; Usyskin

Re: [PATCH] drm/scheduler: only kill entity if last user is killed

2018-07-30 Thread Nayan Deshmukh
On Thu, Jul 26, 2018 at 5:16 PM Christian König < ckoenig.leichtzumer...@gmail.com> wrote: > Note which task is using the entity and only kill it if the last user of > the entity is killed. This should prevent problems when entities are > leaked to > child processes. > > Signed-off-by: Christian K

[Bug 107384] random tab crashes in firefox nightly

2018-07-30 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=107384 --- Comment #8 from Michel Dänzer --- Still smells like a libdrm bug to me, surely drmGetDevice2 can't rely on its caller initializing the device pointer. -- You are receiving this mail because: You are the assignee for the bug.___

[Bug 105308] X log ballooning in size with "drmmode_wait_vblank failed for scanout update" and "get vblank counter failed"

2018-07-30 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=105308 Michel Dänzer changed: What|Removed |Added Resolution|--- |FIXED Status|NEW

Re: [PATCH] drm/mediatek: Replace drm_dev_unref with drm_dev_put

2018-07-30 Thread CK Hu
Hi, Thomas: On Tue, 2018-07-17 at 12:21 +0200, Philipp Zabel wrote: > On Tue, 2018-07-17 at 10:35 +0200, Thomas Zimmermann wrote: > > This patch unifies the naming of DRM functions for reference counting > > of struct drm_device. The resulting code is more aligned with the rest > > of the Linux ke

Re: [PATCH] drm/kms/atomic: Improved the func drm_atomic_set_crtc_for_connector

2018-07-30 Thread Maarten Lankhorst
Op 30-07-18 om 08:14 schreef Satendra Singh Thakur: > a. Used drm_atomic_get_crtc_state instead of drm_atomic_get_new_crtc_state. >Anyway new_state and state are same, this should make no difference. >This change will make the code of this func and the func >drm_atomic_set_crtc_for_plan

  1   2   >