Re: [PATCH V3 2/4] drm/vkms: Add framebuffer and plane helpers

2018-07-11 Thread Daniel Vetter
On Wed, Jul 11, 2018 at 11:02:01PM -0300, Rodrigo Siqueira wrote: > This patch appends the minimum helpers related to framebuffer and plane > to make vkms minimally usable. > > Changes since V1: > - None > Changes since V2: > - Squash "Add plane helper struct" and "Add helper for framebuffer > c

Re: [PATCH 02/12] blk: use for_each_if

2018-07-11 Thread Joe Perches
On Wed, 2018-07-11 at 20:50 +0200, Daniel Vetter wrote: > On Wed, Jul 11, 2018 at 8:30 PM, Jens Axboe wrote: > > On 7/11/18 10:45 AM, Tejun Heo wrote: > > > On Wed, Jul 11, 2018 at 09:40:58AM -0700, Tejun Heo wrote: > > > > On Mon, Jul 09, 2018 at 10:36:40AM +0200, Daniel Vetter wrote: > > > > > M

Re: [PATCH 3/3] drm/scheduler: modify args of drm_sched_entity_init

2018-07-11 Thread Nayan Deshmukh
On Thu, Jul 12, 2018 at 12:07 PM Nayan Deshmukh wrote: > > replace run queue by a list of run queues and remove the > sched arg as that is part of run queue itself > > Signed-off-by: Nayan Deshmukh > --- > drivers/gpu/drm/amd/amdgpu/amdgpu_ctx.c | 4 ++-- > drivers/gpu/drm/amd/amdgpu/amdgpu_t

Re: [PATCH 02/12] blk: use for_each_if

2018-07-11 Thread Daniel Vetter
On Wed, Jul 11, 2018 at 03:13:00PM -0600, Jens Axboe wrote: > On 7/11/18 3:08 PM, Daniel Vetter wrote: > > On Wed, Jul 11, 2018 at 10:06 PM, Tejun Heo wrote: > >> On Wed, Jul 11, 2018 at 01:31:51PM -0600, Jens Axboe wrote: > >>> I don't think there's a git easy way of sending it out outside of > >

Re: [PATCH] kernel.h: Add for_each_if()

2018-07-11 Thread Daniel Vetter
On Thu, Jul 12, 2018 at 1:05 AM, Andrew Morton wrote: > On Wed, 11 Jul 2018 13:51:08 +0200 Daniel Vetter wrote: >> But I still have the situation that a bunch of maintainers acked this >> and Andrew Morton defacto nacked it, which I guess means I'll keep the >> macro in drm? The common way to go

[PATCH 3/3] drm/scheduler: modify args of drm_sched_entity_init

2018-07-11 Thread Nayan Deshmukh
replace run queue by a list of run queues and remove the sched arg as that is part of run queue itself Signed-off-by: Nayan Deshmukh --- drivers/gpu/drm/amd/amdgpu/amdgpu_ctx.c | 4 ++-- drivers/gpu/drm/amd/amdgpu/amdgpu_ttm.c | 4 ++-- drivers/gpu/drm/amd/amdgpu/amdgpu_uvd.c | 4 ++--

[PATCH 2/3] drm/scheduler: add counter for total jobs in scheduler

2018-07-11 Thread Nayan Deshmukh
Signed-off-by: Nayan Deshmukh --- drivers/gpu/drm/scheduler/gpu_scheduler.c | 3 +++ include/drm/gpu_scheduler.h | 2 ++ 2 files changed, 5 insertions(+) diff --git a/drivers/gpu/drm/scheduler/gpu_scheduler.c b/drivers/gpu/drm/scheduler/gpu_scheduler.c index 429b1328653a..3dc1a4f0

[PATCH 1/3] drm/scheduler: add a pointer to scheduler in the rq

2018-07-11 Thread Nayan Deshmukh
Signed-off-by: Nayan Deshmukh --- drivers/gpu/drm/scheduler/gpu_scheduler.c | 6 -- include/drm/gpu_scheduler.h | 2 ++ 2 files changed, 6 insertions(+), 2 deletions(-) diff --git a/drivers/gpu/drm/scheduler/gpu_scheduler.c b/drivers/gpu/drm/scheduler/gpu_scheduler.c index 7d2

[PATCH 0/3] drm/scheduler: preparation for load balancing

2018-07-11 Thread Nayan Deshmukh
This patch series is prepration for implementing better load balancing in the GPU scheduler. Patch #3 is the major change which modifies the drm_sched_entity_init, the driver is now expected to provide a list of potential run queue on which the jobs from this entity can be scheduled. In future pa

[Bug 105760] [4.17-rc1] RIP: smu7_populate_single_firmware_entry.isra.6+0x57/0xc0 [amdgpu] RSP: ffffa17901efb930

2018-07-11 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=105760 --- Comment #33 from Alex Deucher --- (In reply to Thomas Martitz from comment #21) > > I assume this is some mapped memory and some HW component in the GPU writes > to it while the CPU is using it, isn't it? If so, the proper fix would be to >

[Bug 105760] [4.17-rc1] RIP: smu7_populate_single_firmware_entry.isra.6+0x57/0xc0 [amdgpu] RSP: ffffa17901efb930

2018-07-11 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=105760 Alex Deucher changed: What|Removed |Added Attachment #140577|0 |1 is obsolete|

[Bug 105760] [4.17-rc1] RIP: smu7_populate_single_firmware_entry.isra.6+0x57/0xc0 [amdgpu] RSP: ffffa17901efb930

2018-07-11 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=105760 --- Comment #31 from Thomas Martitz --- I can't say for sure for your latest patch because I removed the printks, but it has been the first one before (but only after resume, the ones at boot are OK). Should I check again for your latest patch?

[Bug 105760] [4.17-rc1] RIP: smu7_populate_single_firmware_entry.isra.6+0x57/0xc0 [amdgpu] RSP: ffffa17901efb930

2018-07-11 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=105760 --- Comment #30 from Alex Deucher --- Is it the first call to smu7_populate_single_firmware_entry() which fails or one of the later ones? -- You are receiving this mail because: You are the assignee for the bug.

[Bug 105760] [4.17-rc1] RIP: smu7_populate_single_firmware_entry.isra.6+0x57/0xc0 [amdgpu] RSP: ffffa17901efb930

2018-07-11 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=105760 --- Comment #29 from Thomas Martitz --- Unfortunately, the last patch doesn't help either. This time I removed all my printk's and applied your patch on top of ~agd5f/linux/drm-next-4.19 [ 32.537266] BUG: unable to handle kernel paging reque

[pull] amdgpu drm-fixes-4.18

2018-07-11 Thread Alex Deucher
Hi Dave, A few display and GPUVM fixes for 4.18. The following changes since commit dc81aab1be9fac2e11f31fe7538a50705eba08cf: MAINTAINERS: update drm tree (2018-07-10 10:59:58 +1000) are available in the git repository at: git://people.freedesktop.org/~agd5f/linux drm-fixes-4.18 for you t

RE: [PATCH v5 20/40] drm/i915: Check HDCP 1.4 and 2.2 link on CP_IRQ

2018-07-11 Thread C, Ramalingam
> -Original Message- > From: Sean Paul [mailto:seanp...@chromium.org] > Sent: Tuesday, July 10, 2018 2:21 AM > To: C, Ramalingam > Cc: intel-...@lists.freedesktop.org; dri-devel@lists.freedesktop.org; > dan...@ffwll.ch; Winkler, Tomas ; Usyskin, > Alexander ; Shankar, Uma > ; ch...@chris-

RE: [Intel-gfx] [PATCH v5 01/40] drm: hdcp2.2 authentication msg definitions

2018-07-11 Thread C, Ramalingam
> -Original Message- > From: Sean Paul [mailto:seanp...@chromium.org] > Sent: Thursday, July 12, 2018 12:38 AM > To: C, Ramalingam > Cc: Sean Paul ; intel-...@lists.freedesktop.org; dri- > de...@lists.freedesktop.org; dan...@ffwll.ch; Winkler, Tomas > ; Usyskin, Alexander > ; Shankar, Uma

RE: [PATCH v5 09/40] drm/i915: Schedule hdcp_check_link in _intel_hdcp_enable

2018-07-11 Thread C, Ramalingam
> -Original Message- > From: Sean Paul [mailto:seanp...@chromium.org] > Sent: Thursday, July 12, 2018 2:36 AM > To: C, Ramalingam > Cc: Sean Paul ; intel-...@lists.freedesktop.org; dri- > de...@lists.freedesktop.org; dan...@ffwll.ch; Winkler, Tomas > ; Usyskin, Alexander > ; Shankar, Uma

[PATCH V3 3/4] drm/vkms: Add connectors helpers

2018-07-11 Thread Rodrigo Siqueira
This patch adds the struct drm_connector_helper_funcs with some necessary hooks. Additionally, it also adds some missing hooks at drm_connector_funcs. Changes since V1: - None Change since V2: Daniel Vetter: - Remove vkms_conn_mode_valid Signed-off-by: Rodrigo Siqueira --- drivers/gpu/drm/vkm

[PATCH V3 4/4] drm/vkms: Add vblank events simulated by hrtimers

2018-07-11 Thread Rodrigo Siqueira
This commit adds regular vblank events simulated through hrtimers, which is a feature required by VKMS to mimic real hardware. Additionally, all the vblank event send after pageflip is kept in the atomic_flush function. Changes since V1: - Compute the vblank timer interval per interruption Ville

[PATCH V3 2/4] drm/vkms: Add framebuffer and plane helpers

2018-07-11 Thread Rodrigo Siqueira
This patch appends the minimum helpers related to framebuffer and plane to make vkms minimally usable. Changes since V1: - None Changes since V2: - Squash "Add plane helper struct" and "Add helper for framebuffer create" Signed-off-by: Rodrigo Siqueira --- drivers/gpu/drm/vkms/vkms_drv.c |

[PATCH V3 0/4] Add infrastructure for vblank and page flip events in vkms

2018-07-11 Thread Rodrigo Siqueira
Currently, we are working to make VKMS pass in the kms_flip test (IGT). As a result, we made a series of changes in the module with the goal to meet some of the necessary steps required by kms_flip. This patchset comprises all the modifications needed to make kms_flip partially pass. Note that the

[PATCH V3 1/4] drm/vkms: Add dumb operations

2018-07-11 Thread Rodrigo Siqueira
VKMS currently does not handle dumb data, and as a consequence, it does not provide mechanisms for handling gem. This commit adds the necessary support for gem object/handler and the dumb functions. Changes since V1: Daniel Vetter: - Add dumb buffer support to the same patchset Changes since V2:

linux-next: build warning after merge of the drm-misc tree

2018-07-11 Thread Stephen Rothwell
Hi all, After merging the drm-misc tree, today's linux-next build (arm multi_v7_defconfig) produced this warning: drivers/gpu/drm/sun4i/sun8i_tcon_top.c: In function 'sun8i_tcon_top_register_gate': drivers/gpu/drm/sun4i/sun8i_tcon_top.c:102:10: warning: return makes pointer from integer without

[PULL] drm-misc-next

2018-07-11 Thread Gustavo Padovan
Hi Dave, Big update this week for 4.19. One can never have enough panels, many added. We also have the initial support for vkms from our GSoC and Outreachy students \o/ plus a bunch of improvements and fixes all over core and drivers. An API for in-kernel clients is also in the works. Please pull

Re: [PATCH] kernel.h: Add for_each_if()

2018-07-11 Thread Andrew Morton
On Wed, 11 Jul 2018 13:51:08 +0200 Daniel Vetter wrote: > But I still have the situation that a bunch of maintainers acked this > and Andrew Morton defacto nacked it, which I guess means I'll keep the > macro in drm? The common way to go about this seems to be to just push > the patch series with

[Bug 102322] System crashes after "[drm] IP block:gmc_v8_0 is hung!" / [drm] IP block:sdma_v3_0 is hung!

2018-07-11 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=102322 --- Comment #30 from dwagner --- (In reply to Andrey Grodzovsky from comment #29) > > (If that is a Mesa issue, no more than user processes / X11 should have > > crashed - but not the kernel amdgpu driver... right?) > > Not exactly, MESA could

[Bug 107065] "BUG: unable to handle kernel paging request at 0000000000002000" in amdgpu_vm_cpu_set_ptes at amdgpu_vm.c:921

2018-07-11 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=107065 --- Comment #20 from dwagner --- (In reply to Andrey Grodzovsky from comment #19) > I was able to reproduce this instantly without even using page tables CPU > update mode. Looks like a regression since S3 was working fine for long > time. Were

[Bug 107065] "BUG: unable to handle kernel paging request at 0000000000002000" in amdgpu_vm_cpu_set_ptes at amdgpu_vm.c:921

2018-07-11 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=107065 --- Comment #19 from Andrey Grodzovsky --- (In reply to Andrey Grodzovsky from comment #18) > (In reply to dwagner from comment #17) > > Interesting observation: If I first switch from the X11 display to the > > console display (with Alt-F2), an

[Bug 105760] [4.17-rc1] RIP: smu7_populate_single_firmware_entry.isra.6+0x57/0xc0 [amdgpu] RSP: ffffa17901efb930

2018-07-11 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=105760 Alex Deucher changed: What|Removed |Added Attachment #140573|0 |1 is obsolete|

Re: [PATCH 02/12] blk: use for_each_if

2018-07-11 Thread Daniel Vetter
On Wed, Jul 11, 2018 at 10:06 PM, Tejun Heo wrote: > On Wed, Jul 11, 2018 at 01:31:51PM -0600, Jens Axboe wrote: >> I don't think there's a git easy way of sending it out outside of >> just ensuring that everybody is CC'ed on everything. I don't mind >> that at all. I don't subscribe to lkml, and

Re: [PATCH v5 09/40] drm/i915: Schedule hdcp_check_link in _intel_hdcp_enable

2018-07-11 Thread Sean Paul
On Wed, Jul 11, 2018 at 07:07:10PM +, C, Ramalingam wrote: > > > -Original Message- > > From: Sean Paul [mailto:seanp...@chromium.org] > > Sent: Tuesday, July 10, 2018 2:04 AM > > To: C, Ramalingam > > Cc: intel-...@lists.freedesktop.org; dri-devel@lists.freedesktop.org; > > dan...@ff

[Bug 107150] GPU restarts when some games are launched

2018-07-11 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=107150 --- Comment #9 from Vitalii --- (In reply to Roland Scheidegger from comment #2) > Forgot to mention, gpu resets should be logged so easily visible in the > system log file (although the log may not help much to identify the root > cause). I ra

Re: [PATCH] drm/tinydrm: Fix doc build warnings

2018-07-11 Thread Noralf Trønnes
Den 10.07.2018 17.05, skrev Noralf Trønnes: include/drm/tinydrm/tinydrm.h:34: warning: Function parameter or member 'fb_dirty' not described in 'tinydrm_device' drivers/gpu/drm/tinydrm/mipi-dbi.c:272: warning: Function parameter or member 'crtc_state' not described in 'mipi_dbi_enable_flush' d

Re: [PATCH] drm/client: Fix: drm_client_new: Don't require DRM to be registered

2018-07-11 Thread Noralf Trønnes
Den 11.07.2018 20.53, skrev Daniel Vetter: On Wed, Jul 11, 2018 at 8:21 PM, Noralf Trønnes wrote: Den 11.07.2018 20.00, skrev Daniel Vetter: On Wed, Jul 11, 2018 at 05:56:32PM +0200, Noralf Trønnes wrote: Commit 894a677f4b3e ("drm/cma-helper: Use the generic fbdev emulation") broke almost al

[Bug 105760] [4.17-rc1] RIP: smu7_populate_single_firmware_entry.isra.6+0x57/0xc0 [amdgpu] RSP: ffffa17901efb930

2018-07-11 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=105760 --- Comment #27 from Thomas Martitz --- I wonder if any of the following warnings I see at boot has anyting to do with it: [0.905752] amdgpu: [powerplay] Voltage value looks like a Leakage ID but it's not patched [0.905796] amdgpu: [po

[Bug 105760] [4.17-rc1] RIP: smu7_populate_single_firmware_entry.isra.6+0x57/0xc0 [amdgpu] RSP: ffffa17901efb930

2018-07-11 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=105760 --- Comment #26 from Thomas Martitz --- No, unfortunately it doesn't seem to have an effect. I still run into the same oops, and the printk's I added indicate the same problem (the entry pointer passed to smu7_populate_single_firmware_entry() is

[Bug 107084] WebGL shader freezes X server

2018-07-11 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=107084 Danylo changed: What|Removed |Added CC||danylo.pilia...@gmail.com --- Comment #4 from

Re: [PATCH 02/12] blk: use for_each_if

2018-07-11 Thread Tejun Heo
On Wed, Jul 11, 2018 at 01:31:51PM -0600, Jens Axboe wrote: > I don't think there's a git easy way of sending it out outside of > just ensuring that everybody is CC'ed on everything. I don't mind > that at all. I don't subscribe to lkml, and the patches weren't > sent to linux-block. Hence all I se

Re: [PATCH v5 2/3] fbcon: Call WARN_CONSOLE_UNLOCKED() where applicable

2018-07-11 Thread Hans de Goede
Hi, On 11-07-18 21:19, Steven Rostedt wrote: On Wed, 11 Jul 2018 19:56:02 +0200 Daniel Vetter wrote: Have you seen Steven's suggestion which he send about the same time as your mail I'm replying to here ? I personally think that doing something like that makes sense (for as long as we have th

[Bug 107082] With 4.18 rc kernel stop working video output on AMD GPU Vega 56

2018-07-11 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=107082 --- Comment #1 from Nicholas Kazlauskas --- This should be fixed with: https://patchwork.freedesktop.org/patch/233283/ The fix is also availble if you use amd-staging-drm-next. -- You are receiving this mail because: You are the assignee for t

[Bug 105760] [4.17-rc1] RIP: smu7_populate_single_firmware_entry.isra.6+0x57/0xc0 [amdgpu] RSP: ffffa17901efb930

2018-07-11 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=105760 --- Comment #24 from Alex Deucher --- Created attachment 140575 --> https://bugs.freedesktop.org/attachment.cgi?id=140575&action=edit possible fix 3/4 -- You are receiving this mail because: You are the assignee for the bug._

[Bug 105760] [4.17-rc1] RIP: smu7_populate_single_firmware_entry.isra.6+0x57/0xc0 [amdgpu] RSP: ffffa17901efb930

2018-07-11 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=105760 --- Comment #25 from Alex Deucher --- Created attachment 140576 --> https://bugs.freedesktop.org/attachment.cgi?id=140576&action=edit possible fix 4/4 -- You are receiving this mail because: You are the assignee for the bug._

[Bug 105760] [4.17-rc1] RIP: smu7_populate_single_firmware_entry.isra.6+0x57/0xc0 [amdgpu] RSP: ffffa17901efb930

2018-07-11 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=105760 --- Comment #23 from Alex Deucher --- Created attachment 140574 --> https://bugs.freedesktop.org/attachment.cgi?id=140574&action=edit possible fix 2/4 -- You are receiving this mail because: You are the assignee for the bug._

[Bug 105760] [4.17-rc1] RIP: smu7_populate_single_firmware_entry.isra.6+0x57/0xc0 [amdgpu] RSP: ffffa17901efb930

2018-07-11 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=105760 --- Comment #22 from Alex Deucher --- Created attachment 140573 --> https://bugs.freedesktop.org/attachment.cgi?id=140573&action=edit possible fix 1/4 Does this patch set help? -- You are receiving this mail because: You are the assignee fo

Re: [PATCH v5 2/3] fbcon: Call WARN_CONSOLE_UNLOCKED() where applicable

2018-07-11 Thread Steven Rostedt
On Wed, 11 Jul 2018 19:56:02 +0200 Daniel Vetter wrote: > > Have you seen Steven's suggestion which he send about the same time > > as your mail I'm replying to here ? I personally think that doing > > something like that makes sense (for as long as we have the need > > for the lockless_fb_regist

Re: [Intel-gfx] [PATCH v5 01/40] drm: hdcp2.2 authentication msg definitions

2018-07-11 Thread Sean Paul
On Wed, Jul 11, 2018 at 05:57:08PM +, C, Ramalingam wrote: > Thanks seanpaul for the reviews. > > > -Original Message- > > From: Sean Paul [mailto:seanp...@chromium.org] > > Sent: Tuesday, July 10, 2018 1:51 AM > > To: C, Ramalingam > > Cc: intel-...@lists.freedesktop.org; dri-devel@l

RE: [PATCH v5 09/40] drm/i915: Schedule hdcp_check_link in _intel_hdcp_enable

2018-07-11 Thread C, Ramalingam
> -Original Message- > From: Sean Paul [mailto:seanp...@chromium.org] > Sent: Tuesday, July 10, 2018 2:04 AM > To: C, Ramalingam > Cc: intel-...@lists.freedesktop.org; dri-devel@lists.freedesktop.org; > dan...@ffwll.ch; Winkler, Tomas ; Usyskin, > Alexander ; Shankar, Uma > > Subject: Re

Re: [PATCH] drm/client: Fix: drm_client_new: Don't require DRM to be registered

2018-07-11 Thread Daniel Vetter
On Wed, Jul 11, 2018 at 8:21 PM, Noralf Trønnes wrote: > > Den 11.07.2018 20.00, skrev Daniel Vetter: >> >> On Wed, Jul 11, 2018 at 05:56:32PM +0200, Noralf Trønnes wrote: >>> >>> Commit 894a677f4b3e ("drm/cma-helper: Use the generic fbdev emulation") >>> broke almost all drivers that use the CMA

Re: [PATCH 02/12] blk: use for_each_if

2018-07-11 Thread Daniel Vetter
On Wed, Jul 11, 2018 at 8:30 PM, Jens Axboe wrote: > On 7/11/18 10:45 AM, Tejun Heo wrote: >> On Wed, Jul 11, 2018 at 09:40:58AM -0700, Tejun Heo wrote: >>> On Mon, Jul 09, 2018 at 10:36:40AM +0200, Daniel Vetter wrote: Makes the macros resilient against if {} else {} blocks right afterw

[bug report] drm: Begin an API for in-kernel clients

2018-07-11 Thread Dan Carpenter
Hello Noralf Trønnes, The patch c76f0f7cb546: "drm: Begin an API for in-kernel clients" from Jul 3, 2018, leads to the following static checker warning: drivers/gpu/drm/drm_client.c:289 drm_client_buffer_create() error: double free of 'buffer' drivers/gpu/drm/drm_client.c 268

Re: [PATCH] drm/client: Fix: drm_client_new: Don't require DRM to be registered

2018-07-11 Thread Noralf Trønnes
Den 11.07.2018 20.00, skrev Daniel Vetter: On Wed, Jul 11, 2018 at 05:56:32PM +0200, Noralf Trønnes wrote: Commit 894a677f4b3e ("drm/cma-helper: Use the generic fbdev emulation") broke almost all drivers that use the CMA helper. The reason is that drm_client_new() requires that the DRM device

More drm-panel help volunteers?

2018-07-11 Thread Daniel Vetter
Hi all, I chatted a bit with Thierry about drm-panel, and state of things still seems to be that when Thierry's on vacations/leave/busy patches don't move. So I looked at people with a few patches who could be volunteered to sometimes help out with review&merging: 31 Thierry Reding 16 P

[drm-tip:drm-tip 8/9] debug.c:undefined reference to `save_stack_trace'

2018-07-11 Thread kbuild test robot
Hi Rodrigo, It's probably a bug fix that unveils the link errors. tree: git://anongit.freedesktop.org/drm/drm-tip drm-tip head: 02e578b7aace48d33fa617dddb40621bd664c92c commit: dde6f6606700e68d82f0452d9a9a3b78dff1068f [8/9] Merge remote-tracking branch 'drm-intel/topic/core-for-CI' into drm-

RE: [PATCH v5 05/40] drm/i915: wrapping all hdcp var into intel_hdcp

2018-07-11 Thread C, Ramalingam
> -Original Message- > From: Sean Paul [mailto:seanp...@chromium.org] > Sent: Tuesday, July 10, 2018 2:00 AM > To: C, Ramalingam > Cc: intel-...@lists.freedesktop.org; dri-devel@lists.freedesktop.org; > dan...@ffwll.ch; Winkler, Tomas ; Usyskin, > Alexander ; Shankar, Uma > > Subject: Re

Re: [PATCH] drm/client: Fix: drm_client_new: Don't require DRM to be registered

2018-07-11 Thread Daniel Vetter
On Wed, Jul 11, 2018 at 05:56:32PM +0200, Noralf Trønnes wrote: > Commit 894a677f4b3e ("drm/cma-helper: Use the generic fbdev emulation") > broke almost all drivers that use the CMA helper. > > The reason is that drm_client_new() requires that the DRM device has > been registered, but the drivers

RE: [Intel-gfx] [PATCH v5 02/40] drm: HDMI and DP specific HDCP2.2 defines

2018-07-11 Thread C, Ramalingam
> -Original Message- > From: Sean Paul [mailto:seanp...@chromium.org] > Sent: Tuesday, July 10, 2018 1:53 AM > To: C, Ramalingam > Cc: intel-...@lists.freedesktop.org; dri-devel@lists.freedesktop.org; > dan...@ffwll.ch; Winkler, Tomas ; Usyskin, > Alexander ; Shankar, Uma > > Subject: Re

RE: [Intel-gfx] [PATCH v5 01/40] drm: hdcp2.2 authentication msg definitions

2018-07-11 Thread C, Ramalingam
Thanks seanpaul for the reviews. > -Original Message- > From: Sean Paul [mailto:seanp...@chromium.org] > Sent: Tuesday, July 10, 2018 1:51 AM > To: C, Ramalingam > Cc: intel-...@lists.freedesktop.org; dri-devel@lists.freedesktop.org; > dan...@ffwll.ch; Winkler, Tomas ; Usyskin, > Alexande

Re: [PATCH v5 2/3] fbcon: Call WARN_CONSOLE_UNLOCKED() where applicable

2018-07-11 Thread Daniel Vetter
On Wed, Jul 11, 2018 at 7:35 PM, Hans de Goede wrote: > Hi, > > > On 11-07-18 17:42, Daniel Vetter wrote: >> >> On Wed, Jul 11, 2018 at 5:35 PM, Hans de Goede >> wrote: >>> >>> Hi, >>> >>> On 11-07-18 17:28, Daniel Vetter wrote: On Wed, Jul 11, 2018 at 5:14 PM, Hans de Goede

Re: [PATCH v5 2/3] fbcon: Call WARN_CONSOLE_UNLOCKED() where applicable

2018-07-11 Thread Hans de Goede
Hi, On 11-07-18 17:42, Daniel Vetter wrote: On Wed, Jul 11, 2018 at 5:35 PM, Hans de Goede wrote: Hi, On 11-07-18 17:28, Daniel Vetter wrote: On Wed, Jul 11, 2018 at 5:14 PM, Hans de Goede wrote: Hi, On 11-07-18 17:07, Thomas Zimmermann wrote: Hi Am 11.07.2018 um 16:52 schrieb Steve

Re: [PATCH 03/12] cgroup: use for_each_if

2018-07-11 Thread Tejun Heo
On Mon, Jul 09, 2018 at 10:36:41AM +0200, Daniel Vetter wrote: > Avoids the need to invert the condition instead of the open-coded > version. > > Signed-off-by: Daniel Vetter > Cc: Tejun Heo > Cc: Li Zefan > Cc: Johannes Weiner > Cc: cgro...@vger.kernel.org Acked-by: Tejun Heo Please feel f

Re: [PATCH 02/12] blk: use for_each_if

2018-07-11 Thread Tejun Heo
On Wed, Jul 11, 2018 at 09:40:58AM -0700, Tejun Heo wrote: > On Mon, Jul 09, 2018 at 10:36:40AM +0200, Daniel Vetter wrote: > > Makes the macros resilient against if {} else {} blocks right > > afterwards. > > > > Signed-off-by: Daniel Vetter > > Cc: Tejun Heo > > Cc: Jens Axboe > > Cc: Shaohua

Re: [PATCH v2] drm/panel: simple: Add Sharp LQ035Q7DB03 panel support

2018-07-11 Thread Thierry Reding
On Fri, Jul 06, 2018 at 09:51:01PM +0300, Vladimir Zapolskiy wrote: > The change adds support for Sharp LQ035Q7DB03 3.5" QVGA TFT panel. > > Note that this aged panel is already found in the kernel sources, > for instance in board mach files mach-mx21ads.c, mach-mx27ads.c, > mach-pcm043.c, lpd270.

Re: [PATCH 02/12] blk: use for_each_if

2018-07-11 Thread Tejun Heo
On Mon, Jul 09, 2018 at 10:36:40AM +0200, Daniel Vetter wrote: > Makes the macros resilient against if {} else {} blocks right > afterwards. > > Signed-off-by: Daniel Vetter > Cc: Tejun Heo > Cc: Jens Axboe > Cc: Shaohua Li > Cc: Kate Stewart > Cc: Greg Kroah-Hartman > Cc: Joseph Qi > Cc: D

Re: [PATCH v3 0/4] drm/panel: Handle the "panel is missing" case properly

2018-07-11 Thread Eric Anholt
Thierry Reding writes: > [ Unknown signature status ] > On Wed, May 09, 2018 at 03:00:38PM +0200, Boris Brezillon wrote: >> Hello, >> >> This is a new attempt at fixing the "panel is missing" issue (described >> in this thread [1]). I lost track of Eric's proposal, but I recently >> proposed to

Re: [PATCH v2] drm/panel: simple: Add Sharp LQ035Q7DB03 panel support

2018-07-11 Thread Rob Herring
On Fri, Jul 06, 2018 at 09:51:01PM +0300, Vladimir Zapolskiy wrote: > The change adds support for Sharp LQ035Q7DB03 3.5" QVGA TFT panel. > > Note that this aged panel is already found in the kernel sources, > for instance in board mach files mach-mx21ads.c, mach-mx27ads.c, > mach-pcm043.c, lpd270.

Re: Regression on the sun4i-drm driver by cma helper change

2018-07-11 Thread Noralf Trønnes
Den 11.07.2018 17.04, skrev Daniel Vetter: On Wed, Jul 11, 2018 at 4:52 PM, Noralf Trønnes wrote: Den 11.07.2018 16.06, skrev Maxime Ripard: CC'ing Noralf and Daniel, On Wed, Jul 11, 2018 at 09:47:53PM +0800, Icenowy Zheng wrote: Today, during testing the Banana Pi M2 Zero HDMI patch, I fou

[PATCH] drm/client: Fix: drm_client_new: Don't require DRM to be registered

2018-07-11 Thread Noralf Trønnes
Commit 894a677f4b3e ("drm/cma-helper: Use the generic fbdev emulation") broke almost all drivers that use the CMA helper. The reason is that drm_client_new() requires that the DRM device has been registered, but the drivers register fbdev before registering DRM. Remove the requirement that DRM sh

Re: [PATCH 1/3] vulkan: Define new VK_MESA_query_timestamp extension [v2]

2018-07-11 Thread Keith Packard
Pekka Paalanen writes: > I did not mean you would be solving that problem. I meant that it would > be good to figure out what people actually want from the API to be able > to solve the problem themselves. Thanks for the clarification. I'd suggest that we not try and solve that problem until we

Re: [PATCH v3 2/2] dt-bindings: mipi-dsi: Add dual-channel DSI related info

2018-07-11 Thread Rob Herring
On Mon, Jul 09, 2018 at 02:37:51PM +0530, Archit Taneja wrote: > Add binding info for peripherals that support dual-channel DSI. Add > corresponding optional bindings for DSI host controllers that may > be configured in this mode. Add an example of an I2C controlled > device operating in dual-chann

Re: [PATCH v5 2/3] fbcon: Call WARN_CONSOLE_UNLOCKED() where applicable

2018-07-11 Thread Daniel Vetter
On Wed, Jul 11, 2018 at 5:35 PM, Hans de Goede wrote: > Hi, > > On 11-07-18 17:28, Daniel Vetter wrote: >> >> On Wed, Jul 11, 2018 at 5:14 PM, Hans de Goede >> wrote: >>> >>> Hi, >>> >>> On 11-07-18 17:07, Thomas Zimmermann wrote: Hi Am 11.07.2018 um 16:52 schrieb Steven

Re: [PATCH v5 2/3] fbcon: Call WARN_CONSOLE_UNLOCKED() where applicable

2018-07-11 Thread Steven Rostedt
On Wed, 11 Jul 2018 17:35:10 +0200 Hans de Goede wrote: > OK, so if we don't remove it, we should probably make it so that it > can be used without triggering any WARN_ONs, which would require changing > the existing WARN_CONSOLE_UNLOCKED() so that the calls from > drivers/tty/vt/vt.c > also do

Re: [PATCH v5 2/3] fbcon: Call WARN_CONSOLE_UNLOCKED() where applicable

2018-07-11 Thread Hans de Goede
Hi, On 11-07-18 17:28, Daniel Vetter wrote: On Wed, Jul 11, 2018 at 5:14 PM, Hans de Goede wrote: Hi, On 11-07-18 17:07, Thomas Zimmermann wrote: Hi Am 11.07.2018 um 16:52 schrieb Steven Rostedt: What if you make lockless_register_fb visible to fbcon, and then we can have a macro: Th

Re: [PATCH v5 2/3] fbcon: Call WARN_CONSOLE_UNLOCKED() where applicable

2018-07-11 Thread Daniel Vetter
On Wed, Jul 11, 2018 at 5:14 PM, Hans de Goede wrote: > Hi, > > On 11-07-18 17:07, Thomas Zimmermann wrote: >> >> Hi >> >> Am 11.07.2018 um 16:52 schrieb Steven Rostedt: >>> >>> >>> What if you make lockless_register_fb visible to fbcon, and then we can >>> have a macro: >> >> >> There are more of

Re: [PATCH v5 2/3] fbcon: Call WARN_CONSOLE_UNLOCKED() where applicable

2018-07-11 Thread Hans de Goede
Hi, On 11-07-18 17:07, Thomas Zimmermann wrote: Hi Am 11.07.2018 um 16:52 schrieb Steven Rostedt: What if you make lockless_register_fb visible to fbcon, and then we can have a macro: There are more of these macro invocations under drivers/tty/vt, which also mess up the log during debugging

Re: [PATCH V4 3/8] backlight: qcom-wled: Add new properties for PMI8998

2018-07-11 Thread Rob Herring
On Mon, Jul 09, 2018 at 03:52:16PM +0530, Kiran Gunda wrote: > Update the bindings with the new properties used for > PMI8998. > > Signed-off-by: Kiran Gunda > --- > Changes from V3: > - Removed the default values. > - Removed pmi8998 example. > > .../bindings/leds/backlight/qcom-wl

[PATCH 09/10] Revert "drm: crc: Wait for a frame before returning from open()"

2018-07-11 Thread Mahesh Kumar
This reverts commit e8fa5671183c80342d520ad81d14fa79a9d4a680. Don't wait for first CRC during crtc_crc_open. It avoids one frame wait during open. If application want to wait after read call, it can use poll/read blocking read() call. Suggested-by: Ville Syrjälä Signed-off-by: Mahesh Kumar Cc:

[PATCH 08/10] drm/crc: Cleanup crtc_crc_open function

2018-07-11 Thread Mahesh Kumar
This patch make changes to allocate crc-entries buffer before enabling CRC generation. It moves all the failure check early in the function before setting the source or memory allocation. Now set_crc_source takes only two variable inputs, values_cnt we already gets as part of verify_crc_source. Ch

[PATCH 05/10] drm/rcar-du/crc: Implement verify_crc_source callback

2018-07-11 Thread Mahesh Kumar
This patch implements "verify_crc_source" callback function for rcar drm driver. Changes Since V1: - avoid duplication of code Signed-off-by: Mahesh Kumar Cc: dri-devel@lists.freedesktop.org Cc: Laurent Pinchart Reviewed-by: Maarten Lankhorst --- drivers/gpu/drm/rcar-du/rcar_du_crtc.c | 66 +

[PATCH 04/10] drm/amdgpu_dm/crc: Implement verify_crc_source callback

2018-07-11 Thread Mahesh Kumar
This patch implements "verify_crc_source" callback function for AMD drm driver. Signed-off-by: Mahesh Kumar Cc: dri-devel@lists.freedesktop.org Reviewed-by: Maarten Lankhorst Acked-by: Leo Li --- drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c | 1 + drivers/gpu/drm/amd/display/amdgpu_d

[PATCH 06/10] drm/i915/crc: implement verify_crc_source callback

2018-07-11 Thread Mahesh Kumar
This patch implements verify_crc_source callback function introduced earlier in this series. Signed-off-by: Mahesh Kumar Cc: dri-devel@lists.freedesktop.org Reviewed-by: Maarten Lankhorst --- drivers/gpu/drm/i915/intel_display.c | 1 + drivers/gpu/drm/i915/intel_drv.h | 3 + drivers/g

[PATCH 07/10] drm/i915/crc: implement get_crc_sources callback

2018-07-11 Thread Mahesh Kumar
This patch implements get_crc_sources callback, which returns list of all the valid crc sources supported by driver in current platform. Changes since V1: - Return array of crc sources Signed-off-by: Mahesh Kumar Cc: dri-devel@lists.freedesktop.org Reviewed-by: Maarten Lankhorst --- drivers/g

[PATCH 02/10] drm: crc: Introduce get_crc_sources callback

2018-07-11 Thread Mahesh Kumar
This patch introduce a callback function "get_crc_sources" which will be called during read of control node. It is an optional callback function and if driver implements this callback, driver should return a constant pointer to an array of crc sources list and update count according to the number o

[PATCH 03/10] drm/rockchip/crc: Implement verify_crc_source callback

2018-07-11 Thread Mahesh Kumar
This patch implements "verify_crc_source" callback function for rockchip drm driver. Changes since V1: - simplify the verification (Jani N) Signed-off-by: Mahesh Kumar Cc: dri-devel@lists.freedesktop.org Reviewed-by: Maarten Lankhorst Acked-by: Heiko Stuebner --- drivers/gpu/drm/rockchip/roc

[PATCH 01/10] drm: crc: Introduce verify_crc_source callback

2018-07-11 Thread Mahesh Kumar
This patch adds a new callback function "verify_crc_source" which will be used during setting the crc source in control node. This will help in avoiding setting of wrong string for source. Changes since V1: - do not yet verify_crc_source during open. Signed-off-by: Mahesh Kumar Cc: dri-devel@li

Re: [PATCH v5 2/3] fbcon: Call WARN_CONSOLE_UNLOCKED() where applicable

2018-07-11 Thread Daniel Vetter
On Wed, Jul 11, 2018 at 5:01 PM, Hans de Goede wrote: > Hi, > > On 11-07-18 16:52, Steven Rostedt wrote: >> >> On Wed, 11 Jul 2018 16:46:11 +0200 >> Thomas Zimmermann wrote: >> >>> Hi >>> >>> Am 28.06.2018 um 11:03 schrieb Hans de Goede: Replace comments about places where the console l

Re: [PATCH v5 2/3] fbcon: Call WARN_CONSOLE_UNLOCKED() where applicable

2018-07-11 Thread Thomas Zimmermann
Hi Am 11.07.2018 um 16:52 schrieb Steven Rostedt: > > What if you make lockless_register_fb visible to fbcon, and then we can > have a macro: There are more of these macro invocations under drivers/tty/vt, which also mess up the log during debugging. WARN_CONSOLE_UNLOCKED is already protected b

Re: [PATCH V2 1/5] drm/vkms: Add dumb operations

2018-07-11 Thread Daniel Vetter
On Wed, Jul 11, 2018 at 4:21 PM, Rodrigo Siqueira wrote: > On 07/11, Daniel Vetter wrote: >> On Thu, Jul 05, 2018 at 11:21:19PM +0300, Haneen Mohammed wrote: >> > On Thu, Jun 21, 2018 at 09:16:13AM -0300, Rodrigo Siqueira wrote: >> > > VKMS currently does not handle dumb data, and as a consequence

Re: Regression on the sun4i-drm driver by cma helper change

2018-07-11 Thread Daniel Vetter
On Wed, Jul 11, 2018 at 4:52 PM, Noralf Trønnes wrote: > > Den 11.07.2018 16.06, skrev Maxime Ripard: >> >> CC'ing Noralf and Daniel, >> >> On Wed, Jul 11, 2018 at 09:47:53PM +0800, Icenowy Zheng wrote: >>> >>> Today, during testing the Banana Pi M2 Zero HDMI patch, I found a >>> regression on the

Re: [PATCH v5 2/3] fbcon: Call WARN_CONSOLE_UNLOCKED() where applicable

2018-07-11 Thread Hans de Goede
Hi, On 11-07-18 16:52, Steven Rostedt wrote: On Wed, 11 Jul 2018 16:46:11 +0200 Thomas Zimmermann wrote: Hi Am 28.06.2018 um 11:03 schrieb Hans de Goede: Replace comments about places where the console lock should be held with calls to WARN_CONSOLE_UNLOCKED() to assert that it is actually h

Re: [PATCH v5 2/3] fbcon: Call WARN_CONSOLE_UNLOCKED() where applicable

2018-07-11 Thread Steven Rostedt
On Wed, 11 Jul 2018 16:46:11 +0200 Thomas Zimmermann wrote: > Hi > > Am 28.06.2018 um 11:03 schrieb Hans de Goede: > > Replace comments about places where the console lock should be held with > > calls to WARN_CONSOLE_UNLOCKED() to assert that it is actually held. > > Debugging fbcon sometime

Re: Regression on the sun4i-drm driver by cma helper change

2018-07-11 Thread Noralf Trønnes
Den 11.07.2018 16.06, skrev Maxime Ripard: CC'ing Noralf and Daniel, On Wed, Jul 11, 2018 at 09:47:53PM +0800, Icenowy Zheng wrote: Today, during testing the Banana Pi M2 Zero HDMI patch, I found a regression on the sun4i-drm driver, which happenes because of the cma helper change. The bad co

Re: [PATCH] i915/intel_tv_get_modes: fix strncpy truncation warning

2018-07-11 Thread Chris Wilson
Quoting Dominique Martinet (2018-07-11 08:46:15) > This is effectively no-op as the next line writes a nul at the final > byte of the buffer, so copying one letter less does not change the > behaviour. > > Signed-off-by: Dominique Martinet > --- > > gcc 8 gives the following warning, which I am

Re: [PATCH v5 2/3] fbcon: Call WARN_CONSOLE_UNLOCKED() where applicable

2018-07-11 Thread Thomas Zimmermann
Hi Am 28.06.2018 um 11:03 schrieb Hans de Goede: > Replace comments about places where the console lock should be held with > calls to WARN_CONSOLE_UNLOCKED() to assert that it is actually held. Debugging fbcon sometimes requires to not take the console lock. This patch breaks the debugging worka

[PATCH] [v3] drm/sun4i: fix build failure with CONFIG_DRM_SUN8I_MIXER=m

2018-07-11 Thread Arnd Bergmann
Having DRM_SUN4I built-in but DRM_SUN8I_MIXER as a loadable module results in a link error, as we try to access a symbol from the sun8i_tcon_top.ko module: ERROR: "sun8i_tcon_top_of_table" [drivers/gpu/drm/sun4i/sun8i-drm-hdmi.ko] undefined! ERROR: "sun8i_tcon_top_of_table" [drivers/gpu/drm/sun4i

[Bug 105760] [4.17-rc1] RIP: smu7_populate_single_firmware_entry.isra.6+0x57/0xc0 [amdgpu] RSP: ffffa17901efb930

2018-07-11 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=105760 --- Comment #21 from Thomas Martitz --- Created attachment 140560 --> https://bugs.freedesktop.org/attachment.cgi?id=140560&action=edit workaround The attached workaround makes resuming generally work on my system. The problem seems to be tha

Re: [PATCH V2 1/5] drm/vkms: Add dumb operations

2018-07-11 Thread Rodrigo Siqueira
On 07/11, Daniel Vetter wrote: > On Thu, Jul 05, 2018 at 11:21:19PM +0300, Haneen Mohammed wrote: > > On Thu, Jun 21, 2018 at 09:16:13AM -0300, Rodrigo Siqueira wrote: > > > VKMS currently does not handle dumb data, and as a consequence, it does > > > not provide mechanisms for handling gem. This c

Re: Regression on the sun4i-drm driver by cma helper change

2018-07-11 Thread Maxime Ripard
CC'ing Noralf and Daniel, On Wed, Jul 11, 2018 at 09:47:53PM +0800, Icenowy Zheng wrote: > Today, during testing the Banana Pi M2 Zero HDMI patch, I found a > regression on the sun4i-drm driver, which happenes because of the cma > helper change. > > The bad commit is 894a677f4b3e6d2ab8d01bb46c1fb

Re: [PATCH] drm/msm: avoid using 'timespec'

2018-07-11 Thread Sean Paul
On Tue, Jul 10, 2018 at 11:27:00PM +0200, Arnd Bergmann wrote: > On Tue, Jul 10, 2018 at 10:47 PM, Sean Paul wrote: > > On Mon, Jun 18, 2018 at 05:39:42PM +0200, Arnd Bergmann wrote: > >> The timespec structure and associated interfaces are deprecated and will > >> be removed in the future because

Re: [linux-sunxi] [PATCH v3] drm/sun4i: mixer: Read id from DT

2018-07-11 Thread Chen-Yu Tsai
On Wed, Jul 11, 2018 at 7:27 PM, Jernej Skrabec wrote: > Currently, TCON supports 2 ways to match TCON with engine (mixer in this > case). Old way is to just traverse of graph backwards and compare node > pointer. New way is to match TCON and engine by their respective ids. > All SoCs with DE2 ena

  1   2   3   >