Re: [RESEND][PATCH] video: fbdev: atmel_lcdfb: convert to use GPIO descriptors

2018-02-05 Thread Ludovic Desroches
On Mon, Feb 05, 2018 at 12:56:04PM +0100, Linus Walleij wrote: > On Mon, Feb 5, 2018 at 9:47 AM, Ludovic Desroches > wrote: > > > Use GPIO descriptors instead of relying on the old method. > > > > Signed-off-by: Ludovic Desroches > > Ah there it is :D > Reviewed-by: Linus Walleij > > PS: why

[PATCH V2] video: fbdev: atmel_lcdfb: convert to use GPIO descriptors

2018-02-05 Thread Ludovic Desroches
Use GPIO descriptors instead of relying on the old method. Signed-off-by: Ludovic Desroches Acked-by: Nicolas Ferre Reviewed-by: Linus Walleij Reviewed-by: Andy Shevchenko --- Changes - V2: - remove of_gpio.h. - move gpiod declaration to preserve reversed tree style. - use devm_gpiod_get

[Bug 104963] MSI MoBo A88XM-E35 GPU Trinity A8-5600K (Aruba HD7560D) Boot loop without radeon.dpm=0

2018-02-05 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=104963 Bug ID: 104963 Summary: MSI MoBo A88XM-E35 GPU Trinity A8-5600K (Aruba HD7560D) Boot loop without radeon.dpm=0 Product: DRI Version: DRI git Hardware: x86-64 (AMD64)

Re: [PATCH] drm/bridge/synopsys: dsi: Add read feature

2018-02-05 Thread Brian Norris
Hi, On Sun, Feb 04, 2018 at 10:31:04PM +0100, Philippe Cornu wrote: > This patch adds the DCS/GENERIC DSI read feature. > > Signed-off-by: Philippe Cornu > --- > Extra notes: > DSI read tests have been performed with DCS & GENERIC, short & long > commands, on two different panels. > The maximum

Re: [PATCH] drm/bridge/synopsys: dsi: Add 1.31 version support

2018-02-05 Thread Brian Norris
On Fri, Feb 02, 2018 at 10:19:15PM +, Philippe CORNU wrote: > Hi Archit, Andrzej, Laurent & Brian, > > What is your opinion regarding this patch? Do you have any advice for > handling hw versions? > > Do not hesitate to comment. I'll admit, I don't really have the bandwidth to handle this.

Re: [Intel-gfx] Enabling i915 Panel Self Refresh by default on some devices ?

2018-02-05 Thread Pandiyan, Dhinakaran
On Thu, 2018-02-01 at 13:31 +0100, Hans de Goede wrote: > Hi All, > > As you may have heard I've recently been working on improving > Linux laptop battery life, specifically the OOTB experience > without tweaking any options such as e.g. powertop --auto-tune > would do, see: > > https://fedorap

Re: [Intel-gfx] i915 PSR test results and cursor lag

2018-02-05 Thread Rodrigo Vivi
On Mon, Feb 05, 2018 at 11:54:04PM +, Andy Lutomirski wrote: > > > > On Feb 5, 2018, at 2:50 PM, Rodrigo Vivi wrote: > > > >> On Sat, Feb 03, 2018 at 05:33:08PM +, Andy Lutomirski wrote: > >>> On Fri, Feb 2, 2018 at 7:18 PM, Andy Lutomirski wrote: > On Fri, Feb 2, 2018 at 1:24 AM,

Re: [PATCH 2/4] drm/exynos: fix comparison to bitshift when dealing with a mask

2018-02-05 Thread Inki Dae
2018년 02월 06일 05:09에 Wolfram Sang 이(가) 쓴 글: > Due to a typo, the mask was destroyed by a comparison instead of a bit > shift. > > Signed-off-by: Wolfram Sang > --- > Only build tested. To be applied individually per subsystem. > > drivers/gpu/drm/exynos/regs-fimc.h | 2 +- > 1 file changed, 1

Re: [PATCH] [v2] drm/exynos: g2d: use monotonic timestamps

2018-02-05 Thread Inki Dae
2018년 01월 18일 02:01에 Arnd Bergmann 이(가) 쓴 글: > The exynos DRM driver uses real-time 'struct timeval' values > for exporting its timestamps to user space. This has multiple > problems: > > 1. signed seconds overflow in y2038 > 2. the 'struct timeval' definition is deprecated in the kernel > 3. ti

Re: [Intel-gfx] i915 PSR test results and cursor lag

2018-02-05 Thread Andy Lutomirski
> On Feb 5, 2018, at 2:50 PM, Rodrigo Vivi wrote: > >> On Sat, Feb 03, 2018 at 05:33:08PM +, Andy Lutomirski wrote: >>> On Fri, Feb 2, 2018 at 7:18 PM, Andy Lutomirski wrote: On Fri, Feb 2, 2018 at 1:24 AM, Andy Lutomirski wrote: > On Thu, Feb 1, 2018 at 9:20 PM, Chris Wilson >

Re: [PATCH 0/1] drm/nouveau/disp: prefer identity-mapped route of SOR <-> macro link

2018-02-05 Thread Ben Skeggs
On Tue, Feb 6, 2018 at 9:35 AM, Danilo Krummrich wrote: > Hi Ben, > > still _assuming_ it's an issue of the card I thought about why it > works with the NVIDIA binary driver. > > And I can image they're just trying to do an identity-mapping first > and if that doesn't work (e.g. the particular SOR

Re: [PATCH 01/10] drm/vblank: Data type fixes for 64-bit vblank sequences.

2018-02-05 Thread Keith Packard
Rodrigo Vivi writes: > I didn't checked the drm one close enough yet to decide for that. > DK or Keith? do you guys see anyone suitable for fixes? Yeah, we should probably get 1, 3 and 7 into fixes. 2, 4, 5 and 6 add explicit casts where the compiler would already introduce equivalent implicit c

[PATCH 0/1] drm/nouveau/disp: prefer identity-mapped route of SOR <-> macro link

2018-02-05 Thread Danilo Krummrich
Hi Ben, still _assuming_ it's an issue of the card I thought about why it works with the NVIDIA binary driver. And I can image they're just trying to do an identity-mapping first and if that doesn't work (e.g. the particular SOR is already in use by another macro link) they just pick the next sui

[PATCH 1/1] drm/nouveau/disp: prefer identity-mapped route of SOR <-> macro link

2018-02-05 Thread Danilo Krummrich
With DCB 4.1 implemented by VBIOS since GM20x GPUs, SOR crossbar routing should be possible, such that any SOR sublink can drive any macro link. Therefore, if crossbar routing is available, the first suitable SOR was picked. Unfortunately, there's at least one card where some SORs being being conn

Re: Enabling i915 Panel Self Refresh by default on some devices ?

2018-02-05 Thread Rodrigo Vivi
Hi Hans, On Fri, Feb 02, 2018 at 09:55:32AM +, Hans de Goede wrote: > Hi, > > On 01-02-18 13:31, Hans de Goede wrote: > > Hi All, > > > > As you may have heard I've recently been working on improving > > Linux laptop battery life, specifically the OOTB experience > > without tweaking any op

Re: i915 PSR test results and cursor lag

2018-02-05 Thread Rodrigo Vivi
On Thu, Feb 01, 2018 at 05:43:56PM +, Andy Lutomirski wrote: > On Thu, Feb 1, 2018 at 9:40 AM, Andy Lutomirski wrote: > > Hi- > > > > As requested in your blog post, I tested PSR. I see something like > > 2.69W with PSR off and 2.17W with PSR on. Screen blanking, > > suspend/resume, and the

Re: [Intel-gfx] i915 PSR test results and cursor lag

2018-02-05 Thread Rodrigo Vivi
On Sat, Feb 03, 2018 at 05:33:08PM +, Andy Lutomirski wrote: > On Fri, Feb 2, 2018 at 7:18 PM, Andy Lutomirski wrote: > > On Fri, Feb 2, 2018 at 1:24 AM, Andy Lutomirski wrote: > >> On Thu, Feb 1, 2018 at 9:20 PM, Chris Wilson > >> wrote: > >>> Quoting Andy Lutomirski (2018-02-01 21:04:30)

Re: [Intel-gfx] i915 PSR test results and cursor lag

2018-02-05 Thread Rodrigo Vivi
On Mon, Feb 05, 2018 at 08:35:25PM +, Andy Lutomirski wrote: Andy, first of all thank you very much for those findings. > On Mon, Feb 5, 2018 at 6:53 PM, Pandiyan, Dhinakaran > wrote: > > > > > > > > On Sun, 2018-02-04 at 21:50 +, Andy Lutomirski wrote: > >> On Sat, Feb 3, 2018 at 5:08 P

Re: [Intel-gfx] i915 PSR test results and cursor lag

2018-02-05 Thread Rodrigo Vivi
On Thu, Feb 01, 2018 at 08:33:29PM +, Chris Wilson wrote: > Quoting Kristian Høgsberg (2018-02-01 20:22:40) > > On Thu, Feb 1, 2018 at 9:53 AM Chris Wilson > > wrote: > > > > > Quoting Andy Lutomirski (2018-02-01 17:40:22) > > > > *However*, I do see one unfortunate side effect of turning on

[PATCH] drm/i915: Improve PSR activation timing

2018-02-05 Thread Andy Lutomirski
The current PSR code has a two call sites that each schedule delayed work to activate PSR. As far as I can tell, each call site intends to keep PSR inactive for the given amount of time and then allow it to be activated. The call sites are: - intel_psr_enable(), which explicitly states in a com

[Bug 198669] Driver crash at radeon_ring_backup+0xd3/0x140 [radeon]

2018-02-05 Thread bugzilla-daemon
https://bugzilla.kernel.org/show_bug.cgi?id=198669 --- Comment #4 from ro...@beardandsandals.co.uk (ro...@beardandsandals.co.uk) --- Well it moved the problem. It crashed somewhere else in the driver with some message about scratch. Sorry I cannot tell you what is was because I screwed up the sav

Re: [Intel-gfx] i915 PSR test results and cursor lag

2018-02-05 Thread Andy Lutomirski
On Mon, Feb 5, 2018 at 9:17 PM, Pandiyan, Dhinakaran wrote: > > On Mon, 2018-02-05 at 20:35 +, Andy Lutomirski wrote: >> On Mon, Feb 5, 2018 at 6:53 PM, Pandiyan, Dhinakaran >> wrote: >> > >> > >> > >> > On Sun, 2018-02-04 at 21:50 +, Andy Lutomirski wrote: >> >> On Sat, Feb 3, 2018 at 5:

Re: [Intel-gfx] i915 PSR test results and cursor lag

2018-02-05 Thread Pandiyan, Dhinakaran
On Mon, 2018-02-05 at 20:35 +, Andy Lutomirski wrote: > On Mon, Feb 5, 2018 at 6:53 PM, Pandiyan, Dhinakaran > wrote: > > > > > > > > On Sun, 2018-02-04 at 21:50 +, Andy Lutomirski wrote: > >> On Sat, Feb 3, 2018 at 5:08 PM, Andy Lutomirski wrote: > >> > On Sat, Feb 3, 2018 at 5:20 AM, P

Re: [Intel-gfx] [PATCH 01/10] drm/vblank: Data type fixes for 64-bit vblank sequences.

2018-02-05 Thread Pandiyan, Dhinakaran
On Mon, 2018-02-05 at 12:49 -0800, Rodrigo Vivi wrote: > On Mon, Feb 05, 2018 at 08:37:13PM +, Dave Airlie wrote: > > On 6 February 2018 at 06:32, Rodrigo Vivi wrote: > > > On Sat, Feb 03, 2018 at 08:14:48AM +, Keith Packard wrote: > > >> Dhinakaran Pandiyan writes: > > >> > > >> > From:

Re: [PATCH 01/10] drm/vblank: Data type fixes for 64-bit vblank sequences.

2018-02-05 Thread Rodrigo Vivi
On Mon, Feb 05, 2018 at 08:37:13PM +, Dave Airlie wrote: > On 6 February 2018 at 06:32, Rodrigo Vivi wrote: > > On Sat, Feb 03, 2018 at 08:14:48AM +, Keith Packard wrote: > >> Dhinakaran Pandiyan writes: > >> > >> > From: "Pandiyan, Dhinakaran" > >> > > >> > drm_vblank_count() has an u32

Re: [PATCH v2 2/2] drm/i915/cmdparser: Do not check past the cmd length.

2018-02-05 Thread Chris Wilson
Quoting Chris Wilson (2018-02-05 16:04:25) > Quoting Michal Srb (2018-02-05 15:17:45) > > The command MEDIA_VFE_STATE checks bits at offset +2 dwords. However, it is > > possible to have MEDIA_VFE_STATE command with length = 0 + LENGTH_BIAS = 2. > > In that case check_cmd will read bits from the fo

Re: [PATCH 01/10] drm/vblank: Data type fixes for 64-bit vblank sequences.

2018-02-05 Thread Dave Airlie
On 6 February 2018 at 06:32, Rodrigo Vivi wrote: > On Sat, Feb 03, 2018 at 08:14:48AM +, Keith Packard wrote: >> Dhinakaran Pandiyan writes: >> >> > From: "Pandiyan, Dhinakaran" >> > >> > drm_vblank_count() has an u32 type returning what is a 64-bit vblank count. >> > The effect of this is w

Re: [Intel-gfx] i915 PSR test results and cursor lag

2018-02-05 Thread Andy Lutomirski
On Mon, Feb 5, 2018 at 6:53 PM, Pandiyan, Dhinakaran wrote: > > > > On Sun, 2018-02-04 at 21:50 +, Andy Lutomirski wrote: >> On Sat, Feb 3, 2018 at 5:08 PM, Andy Lutomirski wrote: >> > On Sat, Feb 3, 2018 at 5:20 AM, Pandiyan, Dhinakaran >> > wrote: >> >> >> >> On Fri, 2018-02-02 at 19:18 +0

Re: [PATCH 01/10] drm/vblank: Data type fixes for 64-bit vblank sequences.

2018-02-05 Thread Rodrigo Vivi
On Sat, Feb 03, 2018 at 08:14:48AM +, Keith Packard wrote: > Dhinakaran Pandiyan writes: > > > From: "Pandiyan, Dhinakaran" > > > > drm_vblank_count() has an u32 type returning what is a 64-bit vblank count. > > The effect of this is when drm_wait_vblank_ioctl() tries to widen the user > > s

[PATCH 15/17] drm/dp: Set channel coding on link configuration

2018-02-05 Thread Thierry Reding
From: Thierry Reding Make use of ANSI 8B/10B channel coding if the DisplayPort sink supports it. Signed-off-by: Thierry Reding --- drivers/gpu/drm/drm_dp_helper.c | 9 - 1 file changed, 8 insertions(+), 1 deletion(-) diff --git a/drivers/gpu/drm/drm_dp_helper.c b/drivers/gpu/drm/drm_d

[PATCH 17/17] drm/dp: Add drm_dp_link_choose() helper

2018-02-05 Thread Thierry Reding
From: Thierry Reding This helper chooses an appropriate configuration, according to the bitrate requirements of the video mode and the capabilities of the DisplayPort sink. Signed-off-by: Thierry Reding --- drivers/gpu/drm/drm_dp_helper.c | 55 + include

[PATCH 16/17] drm/dp: Enable alternate scrambler reset when supported

2018-02-05 Thread Thierry Reding
From: Thierry Reding If the sink is eDP and supports the alternate scrambler reset, enable it. Signed-off-by: Thierry Reding --- drivers/gpu/drm/drm_dp_helper.c | 7 +++ 1 file changed, 7 insertions(+) diff --git a/drivers/gpu/drm/drm_dp_helper.c b/drivers/gpu/drm/drm_dp_helper.c index 82

[PATCH 10/17] drm/dp: Read eDP version from DPCD

2018-02-05 Thread Thierry Reding
From: Thierry Reding If the sink supports eDP, read the eDP revision from it's DPCD. Signed-off-by: Thierry Reding --- drivers/gpu/drm/drm_dp_helper.c | 16 +++- include/drm/drm_dp_helper.h | 2 ++ 2 files changed, 17 insertions(+), 1 deletion(-) diff --git a/drivers/gpu/drm/

[PATCH 12/17] drm/dp: Do not busy-loop during link training

2018-02-05 Thread Thierry Reding
From: Thierry Reding Use microsecond sleeps for the clock recovery and channel equalization delays during link training. The duration of these delays can be from 100 us up to 16 ms. It is rude to busy-loop for that amount of time. While at it, also convert to standard coding style by putting the

[PATCH 14/17] drm/dp: Add helper to get post-cursor adjustments

2018-02-05 Thread Thierry Reding
From: Thierry Reding If the transmitter supports pre-emphasis post cursor2 the sink will request adjustments in a similar way to how it requests adjustments to the voltage swing and pre-emphasis settings. Add a helper to extract these adjustments on a per-lane basis from the DPCD link status. S

[PATCH 09/17] drm/dp: Read alternate scrambler reset capability from sink

2018-02-05 Thread Thierry Reding
From: Thierry Reding Parse from the sink capabilities whether or not the eDP alternate scrambler reset value of 0xfffe is supported. Signed-off-by: Thierry Reding --- drivers/gpu/drm/drm_dp_helper.c | 5 + include/drm/drm_dp_helper.h | 9 + 2 files changed, 14 insertions(+) di

[PATCH 11/17] drm/dp: Read AUX read interval from DPCD

2018-02-05 Thread Thierry Reding
From: Thierry Reding Store the AUX read interval from DPCD, so that it can be used to wait for the durations given in the specification during link training. Signed-off-by: Thierry Reding --- drivers/gpu/drm/drm_dp_helper.c | 3 +++ include/drm/drm_dp_helper.h | 18 ++ 2 f

[PATCH 13/17] drm/dp: Use drm_dp_aux_rd_interval()

2018-02-05 Thread Thierry Reding
From: Thierry Reding Make use of the newly added drm_dp_aux_rd_interval() helper in existing DP link training helpers and add comments about minimum required delays mandated by the DP specification. Signed-off-by: Thierry Reding --- drivers/gpu/drm/drm_dp_helper.c | 20 1

[PATCH 08/17] drm/dp: Read channel coding capability from sink

2018-02-05 Thread Thierry Reding
From: Thierry Reding Parse from the sink capabilities whether or not it supports ANSI 8B/10B channel coding as specified in ANSI X3.230-1994, clause 11. Signed-off-by: Thierry Reding --- drivers/gpu/drm/drm_dp_helper.c | 3 +++ include/drm/drm_dp_helper.h | 9 + 2 files changed, 12

[PATCH 07/17] drm/dp: Read TPS3 capability from sink

2018-02-05 Thread Thierry Reding
From: Thierry Reding The TPS3 capability can be exposed by DP 1.2 and later sinks if they support the alternative training pattern for channel equalization. Signed-off-by: Thierry Reding --- drivers/gpu/drm/drm_dp_helper.c | 3 +++ include/drm/drm_dp_helper.h | 2 ++ 2 files changed, 5 ins

[PATCH 06/17] drm/dp: Read fast training capability from link

2018-02-05 Thread Thierry Reding
From: Thierry Reding While probing the DisplayPort link, query the fast training capability. If supported, drivers can use the fast link training sequence instead of the more involved full link training sequence. Signed-off-by: Thierry Reding --- drivers/gpu/drm/drm_dp_helper.c | 3 +++ includ

[PATCH 00/17] drm/dp: Miscellaneous improvements

2018-02-05 Thread Thierry Reding
From: Thierry Reding Hi, this set of patches is based on work that I had done some 2-3 years ago to enable DP support on Pixel C. I never really got that to work, but I recently got my hands on newer hardware with DP connectivity, so I went to revive these patches. I think this takes into accou

[PATCH 05/17] drm/dp: Probe link using existing parsing helpers

2018-02-05 Thread Thierry Reding
From: Thierry Reding Use existing parsing helpers to probe a DisplayPort link. Signed-off-by: Thierry Reding --- drivers/gpu/drm/drm_dp_helper.c | 29 ++--- include/drm/drm_dp_helper.h | 2 ++ 2 files changed, 24 insertions(+), 7 deletions(-) diff --git a/drivers/

[PATCH 03/17] drm/dp: Track link capabilities alongside settings

2018-02-05 Thread Thierry Reding
From: Thierry Reding Store capabilities in max_* fields and add separate fields for the currently selected settings. Signed-off-by: Thierry Reding --- drivers/gpu/drm/bridge/tc358767.c | 14 +++--- drivers/gpu/drm/drm_dp_helper.c| 16 +++- drivers/gpu/drm/msm/e

[PATCH 04/17] drm/dp: Turn link capabilities into booleans

2018-02-05 Thread Thierry Reding
From: Thierry Reding Rather than storing capabilities as flags in an integer, use a separate boolean per capability. This simplifies the code that checks for these capabilities. Signed-off-by: Thierry Reding --- drivers/gpu/drm/bridge/tc358767.c | 6 +++--- drivers/gpu/drm/drm_dp_helper.c

[PATCH 02/17] drm/dp: Add drm_dp_link_reset() implementation

2018-02-05 Thread Thierry Reding
From: Thierry Reding Subsequent patches will add non-volatile fields to struct drm_dp_link, so introduce a function to zero out only the volatile fields. Signed-off-by: Thierry Reding --- drivers/gpu/drm/drm_dp_helper.c | 13 - 1 file changed, 12 insertions(+), 1 deletion(-) diff

[PATCH 01/17] drm/dp: Add missing kerneldoc for struct drm_dp_link

2018-02-05 Thread Thierry Reding
From: Thierry Reding The drm_dp_link structure tracks capabilities on the DP link. Add some kerneldoc to explain what each of its fields means. Signed-off-by: Thierry Reding --- include/drm/drm_dp_helper.h | 7 +++ 1 file changed, 7 insertions(+) diff --git a/include/drm/drm_dp_helper.h b

[PATCH 2/2 v2] drm/panel: Add support for ARM Versatile panels

2018-02-05 Thread Linus Walleij
The ARM reference designs "Versatile AB" and "Versatile PB" contain panel connectors with autodetection of the connected panel type. This adds a small driver utilizing the MFD syscon look-up to read the autodetection register and set up the corresponding panel appropriately. In the source file the

Re: [PATCH v1 1/2] drm/stm: ltdc: add non-alpha color formats

2018-02-05 Thread kbuild test robot
Hi Philippe, I love your patch! Yet something to improve: [auto build test ERROR on drm/drm-next] [also build test ERROR on v4.15 next-20180205] [if your patch is applied to the wrong git tree, please drop us a note to help improve the system] url: https://github.com/0day-ci/linux/commits

[PATCH 1/2 v2] drm/panel: Device tree bindings for ARM Versatile panels

2018-02-05 Thread Linus Walleij
This adds a pretty simple set of device tree bindings for ARM Versatile panels appearing as child nodes of a system controller. Cc: devicet...@vger.kernel.org Reviewed-by: Rob Herring Signed-off-by: Linus Walleij --- ChangeLog v1->v2: - Collect Rob's ACK. --- .../display/panel/arm,versatile-tft

Re: [Intel-gfx] i915 PSR test results and cursor lag

2018-02-05 Thread Pandiyan, Dhinakaran
On Sun, 2018-02-04 at 21:50 +, Andy Lutomirski wrote: > On Sat, Feb 3, 2018 at 5:08 PM, Andy Lutomirski wrote: > > On Sat, Feb 3, 2018 at 5:20 AM, Pandiyan, Dhinakaran > > wrote: > >> > >> On Fri, 2018-02-02 at 19:18 +, Andy Lutomirski wrote: > >>> I updated to 4.15, and the situation

[radeon-alex:drm-next-4.17-wip 59/249] drivers/gpu/drm/amd/amdgpu/../display/amdgpu_dm/amdgpu_dm.h:280: multiple definition of `amdgpu_dm_crtc_handle_crc_irq'

2018-02-05 Thread kbuild test robot
tree: git://people.freedesktop.org/~agd5f/linux.git drm-next-4.17-wip head: a5592a6df4f45a018b48f252ad1c498e683e9b9d commit: 30de3c24e044a36ad8738faddb8986fe4e3a2319 [59/249] drm/amd/display: Implement interface for CRC on CRTC config: x86_64-randconfig-a0-02052326 (attached as .config) compil

Re: [PATCH 04/10] drm/amdgpu: Handle 64-bit return from drm_crtc_vblank_count()

2018-02-05 Thread Alex Deucher
On Sat, Feb 3, 2018 at 12:12 AM, Dhinakaran Pandiyan wrote: > 570e86963a51 ("drm: Widen vblank count to 64-bits [v3]") changed the > return type for drm_crtc_vblank_count() to u64. This could cause > potential problems if the return value is used in arithmetic operations > with a 32-bit reference

[Bug 104216] Firefox quirks (black and/or white squares)

2018-02-05 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=104216 --- Comment #14 from Germano Massullo --- (In reply to Emil Velikov from comment #13) > (In reply to Germano Massullo from comment #12) > > Is there anything else I can do to retrieve useful informations? > > Thank you > > > You can track (git

Re: [PATCH] drm: don't link DP aux i2c adapter to the hardware device node

2018-02-05 Thread Thierry Reding
On Mon, Feb 05, 2018 at 06:39:05PM +0100, Lucas Stach wrote: > Am Montag, den 05.02.2018, 18:33 +0100 schrieb Thierry Reding: > > On Mon, Feb 05, 2018 at 05:11:30PM +0100, Thierry Reding wrote: > > > On Wed, Apr 05, 2017 at 02:04:31PM +0200, Thierry Reding wrote: > > > > On Wed, Apr 05, 2017 at 10:

[PATCH] drm: exynos: Use proper macro definition for HDMI_I2S_PIN_SEL_1

2018-02-05 Thread Sylwester Nawrocki
Bit field [2:0] of HDMI_I2S_PIN_SEL_1 corresponds to SDATA_0, not SDATA_2. This patch removes redefinition of HDMI_I2S_SEL_DATA2 constant and adds missing HDMI_I2S_SEL_DATA0. There is no functional change. Signed-off-by: Sylwester Nawrocki --- drivers/gpu/drm/exynos/exynos_hdmi.c | 7 +-- dr

Re: [PATCH] drm: don't link DP aux i2c adapter to the hardware device node

2018-02-05 Thread Lucas Stach
Am Montag, den 05.02.2018, 18:33 +0100 schrieb Thierry Reding: > On Mon, Feb 05, 2018 at 05:11:30PM +0100, Thierry Reding wrote: > > On Wed, Apr 05, 2017 at 02:04:31PM +0200, Thierry Reding wrote: > > > On Wed, Apr 05, 2017 at 10:52:32AM +0200, Lucas Stach wrote: > > > > Hi Rob, > > > > > > > > Am

Re: [PATCH] drm: don't link DP aux i2c adapter to the hardware device node

2018-02-05 Thread Thierry Reding
On Mon, Feb 05, 2018 at 05:11:30PM +0100, Thierry Reding wrote: > On Wed, Apr 05, 2017 at 02:04:31PM +0200, Thierry Reding wrote: > > On Wed, Apr 05, 2017 at 10:52:32AM +0200, Lucas Stach wrote: > > > Hi Rob, > > > > > > Am Mittwoch, den 29.03.2017, 08:56 -0500 schrieb Rob Herring: > > > > On Mon,

Re: [PATCH] drm: don't link DP aux i2c adapter to the hardware device node

2018-02-05 Thread Thierry Reding
On Mon, Feb 05, 2018 at 05:29:09PM +0100, Lucas Stach wrote: > Am Montag, den 05.02.2018, 17:11 +0100 schrieb Thierry Reding: > > On Wed, Apr 05, 2017 at 02:04:31PM +0200, Thierry Reding wrote: > > > On Wed, Apr 05, 2017 at 10:52:32AM +0200, Lucas Stach wrote: > > > > Hi Rob, > > > > > > > > Am Mi

Re: Questions on page flips and atomic modeset

2018-02-05 Thread Ville Syrjälä
On Mon, Feb 05, 2018 at 06:03:25PM +0200, Oleksandr Andrushchenko wrote: > Hello, > > > I have a DRM driver which implements display protocol for Xen [1] > and this protocol has a dedicated XENDISPL_OP_PG_FLIP request which > tells the other end that some display buffer needs to be displayed, > e

Re: [PATCH] drm: don't link DP aux i2c adapter to the hardware device node

2018-02-05 Thread Lucas Stach
Am Montag, den 05.02.2018, 17:11 +0100 schrieb Thierry Reding: > On Wed, Apr 05, 2017 at 02:04:31PM +0200, Thierry Reding wrote: > > On Wed, Apr 05, 2017 at 10:52:32AM +0200, Lucas Stach wrote: > > > Hi Rob, > > > > > > Am Mittwoch, den 29.03.2017, 08:56 -0500 schrieb Rob Herring: > > > > On Mon,

[Bug 104216] Firefox quirks (black and/or white squares)

2018-02-05 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=104216 --- Comment #13 from Emil Velikov --- (In reply to Germano Massullo from comment #12) > Is there anything else I can do to retrieve useful informations? > Thank you You can track (git bisect) which version of Mesa, ideally which commit, caused

Re: [PATCH] drm: don't link DP aux i2c adapter to the hardware device node

2018-02-05 Thread Thierry Reding
On Wed, Apr 05, 2017 at 02:04:31PM +0200, Thierry Reding wrote: > On Wed, Apr 05, 2017 at 10:52:32AM +0200, Lucas Stach wrote: > > Hi Rob, > > > > Am Mittwoch, den 29.03.2017, 08:56 -0500 schrieb Rob Herring: > > > On Mon, Jan 23, 2017 at 10:33 AM, Thierry Reding > > > wrote: > > > > On Fri, Jan

Re: [PATCH v2 2/2] drm/i915/cmdparser: Do not check past the cmd length.

2018-02-05 Thread Chris Wilson
Quoting Michal Srb (2018-02-05 15:17:45) > The command MEDIA_VFE_STATE checks bits at offset +2 dwords. However, it is > possible to have MEDIA_VFE_STATE command with length = 0 + LENGTH_BIAS = 2. > In that case check_cmd will read bits from the following command, or even past > the end of the buff

Re: [PATCH v3 1/2] drm/virtio: Add window server support

2018-02-05 Thread Gerd Hoffmann
On Mon, Feb 05, 2018 at 03:46:17PM +0100, Tomeu Vizoso wrote: > On 02/05/2018 01:20 PM, Gerd Hoffmann wrote: > >Hi, > > > > > > Why not use virtio-vsock to run the wayland protocol? I don't like > > > > the idea to duplicate something with very simliar functionality in > > > > virtio-gpu. > >

Questions on page flips and atomic modeset

2018-02-05 Thread Oleksandr Andrushchenko
Hello, I have a DRM driver which implements display protocol for Xen [1] and this protocol has a dedicated XENDISPL_OP_PG_FLIP request which tells the other end that some display buffer needs to be displayed, e.g. it is issued by the frontend DRM driver to the corresponding backend when the form

Re: [RESEND][PATCH] video: fbdev: atmel_lcdfb: convert to use GPIO descriptors

2018-02-05 Thread Ludovic Desroches
On Mon, Feb 05, 2018 at 03:06:33PM +0200, Andy Shevchenko wrote: > On Mon, Feb 5, 2018 at 10:47 AM, Ludovic Desroches > wrote: > > Use GPIO descriptors instead of relying on the old method. > > Reviewed-by: Andy Shevchenko > > Though few nitpicks below. > > > > --- a/drivers/video/fbdev/atmel

Re: [PATCH 04/10] drm/amdgpu: Handle 64-bit return from drm_crtc_vblank_count()

2018-02-05 Thread Harry Wentland
On 2018-02-03 12:12 AM, Dhinakaran Pandiyan wrote: > 570e86963a51 ("drm: Widen vblank count to 64-bits [v3]") changed the > return type for drm_crtc_vblank_count() to u64. This could cause > potential problems if the return value is used in arithmetic operations > with a 32-bit reference HW vblank

[PATCH v2 2/2] drm/i915/cmdparser: Do not check past the cmd length.

2018-02-05 Thread Michal Srb
The command MEDIA_VFE_STATE checks bits at offset +2 dwords. However, it is possible to have MEDIA_VFE_STATE command with length = 0 + LENGTH_BIAS = 2. In that case check_cmd will read bits from the following command, or even past the end of the buffer. If the offset ends up outside of the command

[PATCH v2 3/3] drm/nouveau/pci: SOR crossbar quirk for 10b0:1b81

2018-02-05 Thread Danilo Krummrich
On Gainward GTX 1070 routing any other SOR than SOR-1 to macro link 'D' (pad macro 1, link 2) causes failures: [6.712111] nouveau :01:00.0: bus: MMIO read of FAULT at 61c880 [ IBUS ] [6.724888] nouveau :01:00.0: disp: intr24 8000 [8.716668] nouveau :01:00.0: D

[PATCH v2 2/3] drm/nouveau/disp: quirk for SOR crossbar routing

2018-02-05 Thread Danilo Krummrich
With DCB 4.1 implemented by VBIOS since GM20x GPUs, SOR crossbar routing should be possible, such that any SOR sublink can drive any macro link. Unfortunately, there's at least one card where some SOR sublinks being connected to a particular macro link are causing failures. To work around this is

[PATCH v2 1/3] drm/nouveau/pci: PCI IDs for pascal architecture

2018-02-05 Thread Danilo Krummrich
Taken from NVIDIA binary driver (Linux 64-bit, revision 390.25) from README.txt. Signed-off-by: Danilo Krummrich --- drivers/gpu/drm/nouveau/nvkm/engine/device/pci.c | 41 1 file changed, 41 insertions(+) diff --git a/drivers/gpu/drm/nouveau/nvkm/engine/device/pci.c b/

Re: [PATCH] libdrm: intel/Android.mk: Filter libdrm_intel library requirements on x86

2018-02-05 Thread Emil Velikov
On 1 February 2018 at 14:59, Rob Herring wrote: > On Wed, Jan 31, 2018 at 12:46 PM, John Stultz wrote: >> On Wed, Jan 31, 2018 at 8:01 AM, Emil Velikov >> wrote: >>> On 30 January 2018 at 05:42, John Stultz wrote: On Fri, Jan 26, 2018 at 10:33 AM, Emil Velikov wrote: > Hi all,

Re: [PATCH] drm/bridge/synopsys: dsi: Add 1.31 version support

2018-02-05 Thread Philippe CORNU
Hi Andrzej, And many thanks for your good comments On 02/05/2018 02:03 PM, Andrzej Hajda wrote: > On 22.01.2018 16:08, Philippe Cornu wrote: >> From: Philippe CORNU >> >> Add support for the Synopsys DesignWare MIPI DSI version 1.31 >> Two registers need to be updated/added for supporting 1.31:

Re: [Intel-gfx] [PATCH] drm/crc: Add support for polling on the data fd.

2018-02-05 Thread Maarten Lankhorst
Op 05-02-18 om 15:16 schreef Ville Syrjälä: > On Mon, Feb 05, 2018 at 01:59:05PM +0100, Maarten Lankhorst wrote: >> Op 02-02-18 om 15:46 schreef Ville Syrjälä: >>> On Fri, Feb 02, 2018 at 03:27:43PM +0100, Maarten Lankhorst wrote: This will make it possible for userspace to know whether readin

Re: [PATCH 2/2] drm/i915/cmdparser: Do not check past the cmd length.

2018-02-05 Thread Chris Wilson
Quoting Michal Srb (2018-02-05 14:29:16) > The command MEDIA_VFE_STATE checks bits at offset +2 dwords. However, it is > possible to have MEDIA_VFE_STATE command with length = 0 + LENGTH_BIAS = 2. > In that case check_cmd will read bits from the following command, or even past > the end of the buff

Re: [PATCH v3 1/2] drm/virtio: Add window server support

2018-02-05 Thread Tomeu Vizoso
On 02/05/2018 01:20 PM, Gerd Hoffmann wrote: Hi, Why not use virtio-vsock to run the wayland protocol? I don't like the idea to duplicate something with very simliar functionality in virtio-gpu. The reason for abandoning that approach was the type of objects that could be shared via virtio

Re: [PATCH 1/5] backlight: lp8788: document sysfs attributes

2018-02-05 Thread Daniel Thompson
On Mon, Feb 05, 2018 at 12:55:50PM +0530, Aishwarya Pant wrote: > On Thu, Feb 01, 2018 at 11:36:04AM +, Daniel Thompson wrote: > > On Wed, Jan 31, 2018 at 01:51:21PM +0200, Jani Nikula wrote: > > > On Wed, 31 Jan 2018, Daniel Thompson wrote: > > > > On Fri, Jan 26, 2018 at 08:20:08PM +0530, Ai

[PATCH 8/9] drm/rockchip: dw_hdmi: store rockchip_hdmi reference in phy_data object

2018-02-05 Thread Heiko Stuebner
When using special phy handling operations we'll often need access to the rockchip_hdmi struct. As the chip-data that occupies the phy_data pointer initially gets assigned to the rockchip_hdmi struct we can not re-use this phy_data pointer to hold the reference to the rockchip_hdmi struct, similar

[PATCH 1/9] dt-bindings: add binding for Rockchip hdmi phy using an Innosilicon IP

2018-02-05 Thread Heiko Stuebner
From: Zheng Yang The phy is used so far in two Rockchip socs the rk3228 and the rk3328. Signed-off-by: Zheng Yang Signed-off-by: Heiko Stuebner --- .../bindings/phy/phy-rockchip-inno-hdmi.txt| 42 ++ 1 file changed, 42 insertions(+) create mode 100644 Documentati

[PATCH 6/9] dt-bindings: allow optional phys in Rockchip dw_hdmi binding

2018-02-05 Thread Heiko Stuebner
Some newer Rockchip SoCs use an Innosilicon hdmiphy accessed via general mmio, so allow these to be referenced via the regular phy interfaces and therefore add optional phy-related properties to the binding. Signed-off-by: Heiko Stuebner --- Documentation/devicetree/bindings/display/rockchip/dw_

[PATCH 5/9] drm/rockchip: dw_hdmi: Allow outputs that don't need output switching

2018-02-05 Thread Heiko Stuebner
So far we always encountered socs with 2 output crtcs needing the driver to tell the hdmi block which output to connect to. But there also exist socs with only one crtc like the rk3228, rk3328 and rk3368. So adapt the register field to simply carry a negative value to signal that now output-switch

[PATCH 2/9] phy: add Rockchip Innosilicon hdmi phy

2018-02-05 Thread Heiko Stuebner
From: Zheng Yang Add a driver for the Innosilicon hdmi phy used on rk3228/rk3229 and rk3328 socs from Rockchip. Signed-off-by: Zheng Yang Signed-off-by: Heiko Stuebner --- drivers/phy/rockchip/Kconfig |7 + drivers/phy/rockchip/Makefile |1 + drivers/p

[PATCH 3/9] drm/bridge: dw-hdmi: allow overriding of phy-type reading

2018-02-05 Thread Heiko Stuebner
In some IP implementations the reading of the phy-type may be broken. One example are the Rockchip rk3228 and rk3328 socs that use a separate phy from Innosilicon but still report the HDMI20_TX type. So allow the glue driver to force a specific type, like the vendor-phy for these cases. Signed-of

[PATCH 7/9] drm/rockchip: dw_hdmi: allow including external phys

2018-02-05 Thread Heiko Stuebner
Some variants of the dw-hdmi on Rockchip socs use a separate phy block accessed via the generic phy framework, so allow them to be included if such a phy reference is found. Signed-off-by: Heiko Stuebner --- drivers/gpu/drm/rockchip/dw_hdmi-rockchip.c | 10 ++ 1 file changed, 10 insertio

[PATCH 4/9] drm/bridge: dw-hdmi: export hotplug functions

2018-02-05 Thread Heiko Stuebner
From: Algea Cao External phys may not provide their own hotplug-related routines but instead rely on the dw-hdmi ones. Export these functions so that external hdmi-phys can use them if necessary. Signed-off-by: Algea Cao [export all 3 hotplug-related functions] Signed-off-by: Heiko Stuebner --

[PATCH 0/9] drm/rockchip: hdmi support for rk3328

2018-02-05 Thread Heiko Stuebner
The rk3228/rk3229 and rk3328 socs started using a new type of hdmi-phy from Innosilicon that resides completely separate from the dw-hdmi block and gets accessed via mmio. Additionally the rk3328 dw-hdmi does not report the vendor-phy type but a different one instead, so add the possibility to ove

[PATCH 9/9] drm/rockchip: dw_hdmi: add dw-hdmi support for the rk3328

2018-02-05 Thread Heiko Stuebner
The rk3328 uses an external hdmi phy from Innosilicon which uses the generic phy framework for access. Add the necessary data and the compatible for it. Signed-off-by: Heiko Stuebner --- .../bindings/display/rockchip/dw_hdmi-rockchip.txt | 1 + drivers/gpu/drm/rockchip/dw_hdmi-rockchip.c

[PATCH 1/2] drm/i915/cmdparser: Check reg_table_count before derefencing.

2018-02-05 Thread Michal Srb
The find_reg function was assuming that there is always at least one table in reg_tables. It is not always true. In case of VCS or VECS, the reg_tables is NULL and reg_table_count is 0, implying that no register-accessing commands are allowed. However, the command tables include commands such as M

[PATCH 2/2] drm/i915/cmdparser: Do not check past the cmd length.

2018-02-05 Thread Michal Srb
The command MEDIA_VFE_STATE checks bits at offset +2 dwords. However, it is possible to have MEDIA_VFE_STATE command with length = 0 + LENGTH_BIAS = 2. In that case check_cmd will read bits from the following command, or even past the end of the buffer. Similarly to how registers are checked - if

[PATCH 0/2] Fixes in drm/i915/cmdparser.

2018-02-05 Thread Michal Srb
Hi, I have tried to extract the intel_engine_cmd_parser into a user-space binary and run libFuzzer on it. It found two ways to cause undefined behavior. I am not completely sure if the same issues can be triggered in the driver, or if something would prevent them from happening. Still I thought i

Re: [PATCH 2/2] drm/sun4i: Handle DRM_MODE_FLAG_**SYNC_POSITIVE correctly

2018-02-05 Thread Maxime Ripard
On Thu, Feb 01, 2018 at 05:09:33PM +0100, Giulio Benetti wrote: > Il 01/02/2018 11:14, Maxime Ripard ha scritto: > > On Sat, Jan 27, 2018 at 11:07:09PM +0100, Giulio Benetti wrote: > > > > > > > I don't really know what the polarity of D0 would be just by > > > > > > > judging at that capture, but

Re: [Intel-gfx] [PATCH] drm/crc: Add support for polling on the data fd.

2018-02-05 Thread Ville Syrjälä
On Mon, Feb 05, 2018 at 01:59:05PM +0100, Maarten Lankhorst wrote: > Op 02-02-18 om 15:46 schreef Ville Syrjälä: > > On Fri, Feb 02, 2018 at 03:27:43PM +0100, Maarten Lankhorst wrote: > >> This will make it possible for userspace to know whether reading > >> will block, without blocking on the fd.

Re: [PATCH] drm/nouveau: prefer XBGR2101010 for addfb ioctl

2018-02-05 Thread Ilia Mirkin
On Mon, Feb 5, 2018 at 8:58 AM, Ville Syrjälä wrote: > On Sat, Feb 03, 2018 at 02:11:23PM -0500, Ilia Mirkin wrote: >> Nouveau only exposes support for XBGR2101010. Prior to the atomic >> conversion, drm would pass in the wrong format in the framebuffer, but >> it was always ignored -- both usersp

Re: [PATCH] drm/nouveau: prefer XBGR2101010 for addfb ioctl

2018-02-05 Thread Ville Syrjälä
On Sat, Feb 03, 2018 at 02:11:23PM -0500, Ilia Mirkin wrote: > Nouveau only exposes support for XBGR2101010. Prior to the atomic > conversion, drm would pass in the wrong format in the framebuffer, but > it was always ignored -- both userspace (xf86-video-nouveau) and the > kernel driver agreed on

Re: [PATCH 5/5] drm/amdgpu: replace iova debugfs file with iomem

2018-02-05 Thread Tom St Denis
Attached is a patch for umr{master} which should in theory support both iova and iomem. I can add the write method if you want since ya it should be fairly simple to copy/pasta that up. Cheers, Tom On 05/02/18 07:07 AM, Christian König wrote: Well adding write support is trivial. What I'm

Re: [RESEND][PATCH] video: fbdev: atmel_lcdfb: convert to use GPIO descriptors

2018-02-05 Thread Andy Shevchenko
On Mon, Feb 5, 2018 at 10:47 AM, Ludovic Desroches wrote: > Use GPIO descriptors instead of relying on the old method. Reviewed-by: Andy Shevchenko Though few nitpicks below. > --- a/drivers/video/fbdev/atmel_lcdfb.c > +++ b/drivers/video/fbdev/atmel_lcdfb.c > @@ -18,6 +18,7 @@ > #include >

Re: [PATCH] drm/bridge/synopsys: dsi: Add 1.31 version support

2018-02-05 Thread Andrzej Hajda
On 22.01.2018 16:08, Philippe Cornu wrote: > From: Philippe CORNU > > Add support for the Synopsys DesignWare MIPI DSI version 1.31 > Two registers need to be updated/added for supporting 1.31: > * PHY_TMR_CFG 0x9c (updated) > 1.30 [31:24] phy_hs2lp_time >[23:16] phy_lp2hs_time >

Re: [Intel-gfx] [PATCH] drm/crc: Add support for polling on the data fd.

2018-02-05 Thread Maarten Lankhorst
Op 02-02-18 om 15:46 schreef Ville Syrjälä: > On Fri, Feb 02, 2018 at 03:27:43PM +0100, Maarten Lankhorst wrote: >> This will make it possible for userspace to know whether reading >> will block, without blocking on the fd. This makes it possible to >> drain all queued CRC's in blocking mode, witho

Re: [PATCH] drm/bridge/synopsys: dsi: Add read feature

2018-02-05 Thread Philippe CORNU
Hi Andrzej, And many thanks Philippe :-) On 02/05/2018 11:07 AM, Andrzej Hajda wrote: > On 04.02.2018 22:31, Philippe Cornu wrote: >> This patch adds the DCS/GENERIC DSI read feature. >> >> Signed-off-by: Philippe Cornu > > Reviewed-by: Andrzej Hajda > > If there will be no objections I will

  1   2   >