Re: [PATCH 2/2] drm: clean up internally created framebuffer on CRTC disable

2017-12-08 Thread Gurchetan Singh
The problem I'm trying to solve is that the internal cursor fb is leaky and even present after closing the drm driver fd. This can be seen by running modetest after this test case: https://chromium.googlesource.com/chromiumos/platform/drm-tests/+/master/drm_cursor_test.c However, as you mentione

Re: [PATCH v1 1/2] dt-bindings: Add binding for Sitronix ST7735R display panels

2017-12-08 Thread Noralf Trønnes
Den 29.11.2017 04.01, skrev David Lechner: This adds a new device tree binding for Sitronix ST7735R display panels, such as the Adafruit 1.8" TFT. Signed-off-by: David Lechner --- .../bindings/display/sitronix,st7735r.txt | 35 ++ 1 file changed, 35 insertions(+

Re: [PATCH v3 10/11] drm/tinydrm: Use drm_fb_cma_fbdev_init_with_funcs/fini()

2017-12-08 Thread David Lechner
On 12/08/2017 01:37 PM, Noralf Trønnes wrote: Use drm_fb_cma_fbdev_init_with_funcs() and drm_fb_cma_fbdev_fini() which relies on the fact that drm_device holds a pointer to the drm_fb_helper structure. This means that the driver doesn't have to keep track of that. Also use the drm_fb_helper funct

Re: [PATCH v1 2/2] drm/tinydrm: add driver for ST7735R panels

2017-12-08 Thread David Lechner
On 12/06/2017 12:27 PM, Noralf Trønnes wrote: Den 29.11.2017 04.01, skrev David Lechner: This adds a new driver for Sitronix ST7735R display panels. This has been tested using an Adafruit 1.8" TFT. Signed-off-by: David Lechner ---   MAINTAINERS   |   6 +   drivers/gpu/drm

Re: [git pull] drm fixes for v4.15-rc3

2017-12-08 Thread Linus Torvalds
On Thu, Dec 7, 2017 at 5:20 PM, Dave Airlie wrote: > > This pull is a bit larger than I'd like but a large bunch of it is > license fixes, AMD wanted to fix the licenses for a bunch of files > that were missing them, Oh Christ, couldn't they have just added the one-liner SPDX tags rather than doi

Re: [PATCH] drm/vc4: Release fence after signalling

2017-12-08 Thread Eric Anholt
Stefan Schake writes: > We were never releasing the initial fence reference that is obtained > through dma_fence_init. > > Link: https://github.com/anholt/linux/issues/122 > Fixes: cdec4d361323 ("drm/vc4: Expose dma-buf fences for V3D rendering.") > Signed-off-by: Stefan Schake Your commit mess

[PATCH v3 11/11] drm/cma-helper: Remove drm_fbdev_cma* functions

2017-12-08 Thread Noralf Trønnes
Remove the unused struct drm_fbdev_cma functions. Cc: Laurent Pinchart Signed-off-by: Noralf Trønnes Acked-by: Daniel Vetter --- drivers/gpu/drm/drm_fb_cma_helper.c | 158 include/drm/drm_fb_cma_helper.h | 28 +-- 2 files changed, 3 insertions(+),

[PATCH v3 10/11] drm/tinydrm: Use drm_fb_cma_fbdev_init_with_funcs/fini()

2017-12-08 Thread Noralf Trønnes
Use drm_fb_cma_fbdev_init_with_funcs() and drm_fb_cma_fbdev_fini() which relies on the fact that drm_device holds a pointer to the drm_fb_helper structure. This means that the driver doesn't have to keep track of that. Also use the drm_fb_helper functions directly. Remove todo entry. Cc: David Lec

[PATCH v3 08/11] drm/rcar-du: Use drm_fb_cma_fbdev_init/fini()

2017-12-08 Thread Noralf Trønnes
Use drm_fb_cma_fbdev_init() and drm_fb_cma_fbdev_fini() which relies on the fact that drm_device holds a pointer to the drm_fb_helper structure. This means that the driver doesn't have to keep track of that. Also use the drm_fb_helper functions directly. Cc: Laurent Pinchart Signed-off-by: Noralf

[PATCH v3 09/11] drm/fsl-dcu: Use drm_fb_cma_fbdev_init/fini()

2017-12-08 Thread Noralf Trønnes
Use drm_fb_cma_fbdev_init() and drm_fb_cma_fbdev_fini() which relies on the fact that drm_device holds a pointer to the drm_fb_helper structure. This means that the driver doesn't have to keep track of that. Also use the drm_fb_helper functions directly. Remove console.h inclusion which was forgott

[PATCH v3 05/11] drm/meson: Use drm_fb_cma_fbdev_init/fini()

2017-12-08 Thread Noralf Trønnes
Use drm_fb_cma_fbdev_init() and drm_fb_cma_fbdev_fini() which relies on the fact that drm_device holds a pointer to the drm_fb_helper structure. This means that the driver doesn't have to keep track of that. Also use the drm_fb_helper functions directly. Cc: Neil Armstrong Signed-off-by: Noralf T

[PATCH v3 00/11] drm/cma-helper: Remove drm_fbdev_cma* functions

2017-12-08 Thread Noralf Trønnes
These are the remaining patches not applied due to missing review and: - arm/hdlcd and rcar-du have started to use drm_fbdev_cma_set_suspend_unlocked() since last, so I have added patches converting them to drm_mode_config_helper_suspend/resume(). - tinydrm has gained a new driver ili9225 Nora

[PATCH v3 01/11] drm/arc: Use drm_fb_cma_fbdev_init/fini()

2017-12-08 Thread Noralf Trønnes
Use drm_fb_cma_fbdev_init() and drm_fb_cma_fbdev_fini() which relies on the fact that drm_device holds a pointer to the drm_fb_helper structure. This means that the driver doesn't have to keep track of that. Also use the drm_fb_helper functions directly. Remove unused function prototype arcpgu_fbde

[PATCH v3 03/11] drm/arm/hdlcd: Use drm_fb_cma_fbdev_init/fini()

2017-12-08 Thread Noralf Trønnes
Use drm_fb_cma_fbdev_init() and drm_fb_cma_fbdev_fini() which relies on the fact that drm_device holds a pointer to the drm_fb_helper structure. This means that the driver doesn't have to keep track of that. Also use the drm_fb_helper functions directly. Cc: Liviu Dudau Cc: Brian Starkey Signed-

[PATCH v3 04/11] drm/hisilicon/kirin: Use drm_fb_cma_fbdev_init/fini()

2017-12-08 Thread Noralf Trønnes
Use drm_fb_cma_fbdev_init() and drm_fb_cma_fbdev_fini() which relies on the fact that drm_device holds a pointer to the drm_fb_helper structure. This means that the driver doesn't have to keep track of that. Also use the drm_fb_helper functions directly. Cc: Xinliang Liu Cc: Rongrong Zou Cc: Xin

[PATCH v3 06/11] drm/mxsfb: Use drm_fb_cma_fbdev_init/fini()

2017-12-08 Thread Noralf Trønnes
Use drm_fb_cma_fbdev_init() and drm_fb_cma_fbdev_fini() which relies on the fact that drm_device holds a pointer to the drm_fb_helper structure. This means that the driver doesn't have to keep track of that. Also use the drm_fb_helper functions directly. Cc: Marek Vasut Signed-off-by: Noralf Trøn

[PATCH v3 02/11] drm/arm/hdlcd: Use drm_mode_config_helper_suspend/resume()

2017-12-08 Thread Noralf Trønnes
Replace driver's code with the generic helpers that do the same thing including the NULL check. Cc: Liviu Dudau Cc: Brian Starkey Signed-off-by: Noralf Trønnes --- drivers/gpu/drm/arm/hdlcd_drv.c | 25 +++-- drivers/gpu/drm/arm/hdlcd_drv.h | 1 - 2 files changed, 3 inserti

[PATCH v3 07/11] drm/rcar-du: Use drm_mode_config_helper_suspend/resume()

2017-12-08 Thread Noralf Trønnes
Replace driver's code with the generic helpers that do the same thing. Cc: Laurent Pinchart Signed-off-by: Noralf Trønnes --- drivers/gpu/drm/rcar-du/rcar_du_drv.c | 21 +++-- drivers/gpu/drm/rcar-du/rcar_du_drv.h | 1 - 2 files changed, 3 insertions(+), 19 deletions(-) diff -

[Bug 104003] [IGT] pm_sseu@full-enable fails with assertion: gem.spinfunc

2017-12-08 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=104003 Chris Wilson changed: What|Removed |Added Resolution|--- |FIXED Status|NEW

Re: [Intel-gfx] [PATCH] kthread: finer-grained lockdep/cross-release completion

2017-12-08 Thread Peter Zijlstra
On Fri, Dec 08, 2017 at 05:36:28PM +0100, Daniel Vetter wrote: > Aside: Could/should we take some fake lockdep locks around these > callbacks, since not all drivers call them from a hardirq context? Just to > validate that everyone follows the contract. What I typically do is use local_irq_save/r

Re: [Intel-gfx] [PATCH] kthread: finer-grained lockdep/cross-release completion

2017-12-08 Thread Daniel Vetter
On Fri, Dec 08, 2017 at 11:14:16AM +0100, Peter Zijlstra wrote: > On Thu, Dec 07, 2017 at 09:56:57PM +0100, Daniel Vetter wrote: > > On Thu, Dec 07, 2017 at 08:57:09PM +0100, Peter Zijlstra wrote: > > > > Is what it says I suppose. Now I don't know enough about that i915 code > > > to say if that

[PATCHv2] drm/sun4i: validate modes for HDMI

2017-12-08 Thread Hans Verkuil
When I connected my cubieboard running 4.15-rc1 to my 4k display I got no picture. Some digging found that there is no check against the upper pixelclock limit of the HDMI output, so X selects a 4kp60 format at 594 MHz, which obviously won't work. The patch below adds a check for the upper bound

Re: [PATCH] drm/sun4i: validate modes for HDMI

2017-12-08 Thread Hans Verkuil
Please ignore, this patch was on top of my old hack instead of being a proper patch. I'll resend. Hans On 12/08/2017 04:45 PM, Hans Verkuil wrote: > When I connected my cubieboard running 4.15-rc1 to my 4k display I got no > picture. Some > digging found that there is no check against t

[PATCH] drm/sun4i: validate modes for HDMI

2017-12-08 Thread Hans Verkuil
When I connected my cubieboard running 4.15-rc1 to my 4k display I got no picture. Some digging found that there is no check against the upper pixelclock limit of the HDMI output, so X selects a 4kp60 format at 594 MHz, which obviously won't work. The patch below adds a check for the upper bound

Re: [PATCH v1 2/2] drm/tinydrm: add driver for ST7735R panels

2017-12-08 Thread Noralf Trønnes
Den 06.12.2017 19.27, skrev Noralf Trønnes: Den 29.11.2017 04.01, skrev David Lechner: This adds a new driver for Sitronix ST7735R display panels. This has been tested using an Adafruit 1.8" TFT. Signed-off-by: David Lechner --- diff --git a/drivers/gpu/drm/tinydrm/st7735r.c b/drivers/

Re: [PATCH v2 00/22] drm/cma-helper: Remove drm_fbdev_cma* functions

2017-12-08 Thread Noralf Trønnes
Den 15.11.2017 15.19, skrev Noralf Trønnes: This patchset adds drm_fb_cma_fbdev_init/fini() functions that replaces drm_fbdev_cma_init/fini(). The reason for doing so is to get rid of struct drm_fbdev_cma and it's wrapper functions. The final piece will happen when tinydrm moves away from the cm

[Bug 103102] Cannot wake-up with an AMD RX 480 on Linux 4.13 and Linux 4.14

2017-12-08 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=103102 Alex Deucher changed: What|Removed |Added Resolution|--- |FIXED Status|NEW

[PATCH 06/25] drm/armada: allow the primary plane to be disabled

2017-12-08 Thread Russell King
Add our own hook to allow the primary plane to be disabled. Signed-off-by: Russell King --- drivers/gpu/drm/armada/armada_crtc.c | 99 1 file changed, 55 insertions(+), 44 deletions(-) diff --git a/drivers/gpu/drm/armada/armada_crtc.c b/drivers/gpu/drm/arma

Re: [PATCH v3 00/11] drm/fb-helper: Add .last_close and .output_poll_changed helpers

2017-12-08 Thread Noralf Trønnes
Den 06.12.2017 10.14, skrev Daniel Vetter: On Tue, Dec 05, 2017 at 04:11:26PM -0500, Alex Deucher wrote: On Tue, Dec 5, 2017 at 1:24 PM, Noralf Trønnes wrote: The helpers are applied and have reached airlied/drm-next. amd has gained another .poll_changed user since last. Patches 1, 2, 9 app

Re: [PATCH v2 6/7] drm/i2c: tda998x: add CEC support

2017-12-08 Thread Hans Verkuil
On 12/08/2017 12:57 PM, Russell King - ARM Linux wrote: > On Wed, Dec 06, 2017 at 02:50:44PM +0100, Hans Verkuil wrote: >> Hi Russell, >> >> Thanks for this patch series! >> >> On 12/06/17 13:35, Russell King wrote: >>> The TDA998x is a HDMI transmitter with a TDA9950 CEC engine integrated >>> onto

Re: [PATCH] kthread: finer-grained lockdep/cross-release completion

2017-12-08 Thread Peter Zijlstra
On Thu, Dec 07, 2017 at 11:08:49AM +0100, Daniel Vetter wrote: > Since -rc1 we're hitting a bunch of lockdep splats using the new > cross-release stuff around the 2 kthread completions. In all cases > they are because totally independent uses of kthread are mixed up by > lockdep into the same locki

Re: [Intel-gfx] [PATCH] kthread: finer-grained lockdep/cross-release completion

2017-12-08 Thread Peter Zijlstra
On Thu, Dec 07, 2017 at 09:56:57PM +0100, Daniel Vetter wrote: > On Thu, Dec 07, 2017 at 08:57:09PM +0100, Peter Zijlstra wrote: > > Is what it says I suppose. Now I don't know enough about that i915 code > > to say if that breadcrumbs_signal thread can ever trigger a fault or > > not. I got prope

Re: [Intel-gfx] [PATCH] drm/plane: Make framebuffer refcounting the responsibility of setplane_internal callers

2017-12-08 Thread Daniel Vetter
On Fri, Dec 08, 2017 at 10:54:36AM +0100, Maarten Lankhorst wrote: > lock_all_ctx in setplane_internal may return -EINTR, and > __setplane_internal could return -EDEADLK. Making more > special cases for fb would make the code even harder to > read, so the easiest solution is not taking over the fb

[PATCH] drm/plane: Make framebuffer refcounting the responsibility of setplane_internal callers

2017-12-08 Thread Maarten Lankhorst
lock_all_ctx in setplane_internal may return -EINTR, and __setplane_internal could return -EDEADLK. Making more special cases for fb would make the code even harder to read, so the easiest solution is not taking over the fb refcount, and making callers responsible for dropping the ref. Bugzilla: h

Re: [RESEND PATCH 0/4] drm/meson: power domain init related fixes

2017-12-08 Thread Neil Armstrong
On 08/12/2017 10:04, Jerome Brunet wrote: > On Wed, 2017-12-06 at 12:54 +0100, Neil Armstrong wrote: >> On the Amlogic Gx SoCs (GXBB, GXL & GXM), the VPU power domain is initialized >> by the vendor U-Boot code, but running mainline U-boot has been possible >> on these SoCs. But lacking such init m

Re: [RFC PATCH 1/6] drm: Add Content Protection property

2017-12-08 Thread Daniel Vetter
On Thu, Dec 07, 2017 at 02:30:52PM +, Alan Cox wrote: > > If you want to actually lock down a machine to implement content > > protection, then you need secure boot without unlockable boot-loader and a > > pile more bits in userspace. > > So let me take my Intel hat off for a moment. > > The

Re: [Outreachy kernel] [PATCH v14 2/3] drm/tinydrm: Move tinydrm_of_find_backlight to backlight.c

2017-12-08 Thread Daniel Vetter
On Thu, Dec 07, 2017 at 05:01:21PM +0100, Noralf Trønnes wrote: > > Den 07.12.2017 16.44, skrev Daniel Thompson: > > On 06/12/17 10:43, Meghana Madhyastha wrote: > > > On Tue, Oct 24, 2017 at 06:45:34PM +0200, Noralf Trønnes wrote: > > > > > > > > Den 24.10.2017 17.42, skrev Sean Paul: > > > > >

Re: [PATCH v3 08/15] drm/sun4i: Add LVDS support

2017-12-08 Thread Philippe Ombredanne
On Tue, Dec 5, 2017 at 4:10 PM, Maxime Ripard wrote: > The TCON supports the LVDS interface to output to a panel or a bridge. > Let's add support for it. > > Signed-off-by: Maxime Ripard [] > --- /dev/null > +++ b/drivers/gpu/drm/sun4i/sun4i_lvds.c > @@ -0,0 +1,183 @@ > +/* > + * Copyright (C) 20

[PATCH] drm/i915: Increase max texture to 16k for gen9+

2017-12-08 Thread Alex Tu
Rrefer to another patch [1] on mesa to extend width/height to 16384. For issue : - https://bugs.freedesktop.org/show_bug.cgi?id=102508 - LP: #1714178 Triple monitor display failed with Dell Dock (HiDPI) [1] https://patchwork.freedesktop.org/patch/124918/ Signed-off-by: Alex Tu --- drivers/gpu

Re: [Intel-gfx] [PATCH] drm/i915: Increase max texture to 16k for gen9+

2017-12-08 Thread Alex Tu
looks it's not that easy as I thought. This change is for https://bugs.freedesktop.org/show_bug.cgi?id=102508 , and the hardware configuration is * 00:02.0 VGA compatible controller [0300]: Intel Corporation Device [8086:591d] (rev 04) * Dell Thunderbolt BME dock : http://www.dell.com/support/arti

Re: [PATCH] video: hd44780: Add hd44780 lcd display driver

2017-12-08 Thread Lars Poeschel
On Wed, Dec 6, 2017 at 16:04:10 CET Geert Uytterhoeven wrote: > Hi Lars, > > On Wed, Dec 6, 2017 at 2:52 PM, Lars Poeschel wrote: > > This adds a console driver for hd44780 based character lcd displays and > > clones. The driver currently supports 20x4 character displays with > > character ROMs A

Re: [PATCH] drm/vc4: Fix false positive WARN() backtrace on refcount_inc() usage

2017-12-08 Thread Stefan Wahren
Hi Daniel, Am 24.11.2017 um 15:52 schrieb Daniel Vetter: On Thu, Nov 23, 2017 at 09:24:11AM +0100, Boris Brezillon wrote: On Wed, 22 Nov 2017 16:13:31 -0800 Eric Anholt wrote: Boris Brezillon writes: On Wed, 22 Nov 2017 13:16:08 -0800 Eric Anholt wrote: Boris Brezillon writes:

Re: [Intel-gfx] [PATCH] drm/i915: Increase max texture to 16k for gen9+

2017-12-08 Thread Alex Tu
Thanks for comment. I'm not familiar with that, so just followed the patch in mes https://patchwork.freedesktop.org/patch/124918/a. How about change subtitle to "drm/i915: Increase max CRTC bounds to 16k for gen9+"? On Thu, Dec 7, 2017 at 5:32 PM, Chris Wilson wrote: > Quoting Alex Tu (2017-12-

Re: [Ask for help] ATI HD 7470 card on arm64 platform

2017-12-08 Thread liuxinliang
Hi Christian, On 2017/12/7 17:57, Xinliang Liu wrote: cc z.liuxinli...@hisilicon.com On 7 December 2017 at 17:54, Xinliang Liu wrote: Thanks Christian, add tangyongqian in the loop. On 7 December 2017 at 17:40, Christian König wrote: Hi Xinliang, please provide the output of lspci and t