Some HW vblank counters reset due to power management events, which messes
up the vblank counting logic. This leads to screen freezes with user space
waiting on vblank events that may not occur if the counter keeps resetting.
For e.g., After the HW vblank counter resets
[9.007359] [drm:drm_upd
Hi Noralf,
I love your patch! Yet something to improve:
[auto build test ERROR on drm/drm-next]
[also build test ERROR on v4.14-rc8 next-20171106]
[if your patch is applied to the wrong git tree, please drop us a note to help
improve the system]
url:
https://github.com/0day-ci/linux
On 11/06/2017 01:28 PM, Andrzej Hajda wrote:
On 03.11.2017 18:01, Andrey Gusakov wrote:
This set of patches fixes several issues that was found during testing
tc358767 with desktop DisplayPort displays.
Changes in V2:
- fixed maximum pixelclock frequency
- copyright patch adde
2017년 11월 03일 23:03에 Emil Velikov 이(가) 쓴 글:
> On 3 November 2017 at 13:59, Tobias Jakobi
> wrote:
>> Inki Dae wrote:
>>> Hi Email,
>>>
>>> Since I posted this patch, much time has been passed.
>>> But no answer. We got already many Acked-by so could you merge this patch?
>> I think you need Acke
2017년 08월 11일 00:48에 Jan Vesely 이(가) 쓴 글:
> On Thu, 2017-08-10 at 13:52 +0900, Inki Dae wrote:
>> Chnage GPL license of Exynos relevant code to X11/MIT.
>>
>> I'd like to keep license consistency to all Exynos code
>> because License checker notices two more licenses exist
>> in libdrm.
>>
>> For
Hi Tobias,
Really sorry for late and no checking for your comment.
2017년 08월 10일 20:23에 Tobias Jakobi 이(가) 쓴 글:
> Hello,
>
> some comments first.
>
> - What is this license checker and why should we care about it?
We are developing Linux platform which uses libdrm open source. And when this
p
This driver can use drm_fb_helper_output_poll_changed() as its
.output_poll_changed callback.
Cc: Jani Nikula
Cc: Joonas Lahtinen
Cc: Rodrigo Vivi
Signed-off-by: Noralf Trønnes
Reviewed-by: Daniel Vetter
---
I'm resending to get a CI run.
Noralf.
drivers/gpu/drm/i915/intel_display.c | 2 +
On Sat, Nov 4, 2017 at 8:21 AM, Nicolas Iooss
wrote:
> On Sun, Sep 3, 2017 at 2:00 PM, Nicolas Iooss
> wrote:
>>
>> Function vega10_apply_state_adjust_rules() only initializes
>> stable_pstate_sclk_dpm_percentage when
>> data->registry_data.stable_pstate_sclk_dpm_percentage is not between 1
>> an
On Mon, Nov 6, 2017 at 6:59 AM, Christian König
wrote:
> Am 06.11.2017 um 12:44 schrieb Dan Carpenter:
>>
>> We assign "v_init = asic_blank_start;" a few lines earlier so there is
>> no need to do it again inside the if statements. Also "v_init" is
>> unsigned so it can't be less than zero.
>>
>>
On Mon, Nov 6, 2017 at 6:51 AM, Christian König
wrote:
> Am 06.11.2017 um 12:43 schrieb Dan Carpenter:
>>
>> backlight_device_register() never returns NULL, it returns error
>> pointers on error so the check here is wrong.
>>
>> Signed-off-by: Dan Carpenter
>
>
> Acked-by: Christian König
Appli
On Mon, Nov 6, 2017 at 3:44 AM, Christian König
wrote:
> Am 06.11.2017 um 08:07 schrieb Dan Carpenter:
>>
>> Static analysis tools get annoyed that we don't indent this if
>> statement. Actually, the if statement isn't required because kfree()
>> can handle NULL pointers just fine. The DCE110STR
https://bugs.freedesktop.org/show_bug.cgi?id=103544
--- Comment #12 from Roland Scheidegger ---
Here's a apitrace for this (1GB, of course the corruption is only seen towards
the end...), should be available a week (?):
https://we.tl/EanuxRG7Yf
--
You are receiving this mail because:
You are th
https://bugs.freedesktop.org/show_bug.cgi?id=103544
--- Comment #11 from Roland Scheidegger ---
(In reply to Ilia Mirkin from comment #10)
> Patch is available at https://patchwork.freedesktop.org/patch/186599/
> (although I'll have to rework the description)
Doesn't help, everything looks the s
https://bugs.freedesktop.org/show_bug.cgi?id=99843
--- Comment #15 from d...@jerber.co.uk ---
I was reading about the R600 driver and came across a TODO page that suggested
testing using piglit.
I downloaded and compiled this. I ran the "shader.py" test and it gave the
following results:
skip: 2
Add drm_mode_config_helper_suspend/resume() which takes care of
atomic modeset suspend/resume for simple use cases.
The suspend state is stored in struct drm_mode_config.
Signed-off-by: Noralf Trønnes
Reviewed-by: Daniel Vetter
---
drivers/gpu/drm/drm_modeset_helper.c | 76 +
Replace driver's code with the generic helpers that do the same thing.
Cc: Stefan Agner
Cc: Alison Wang
Signed-off-by: Noralf Trønnes
---
drivers/gpu/drm/fsl-dcu/fsl_dcu_drm_drv.c | 24 ++--
drivers/gpu/drm/fsl-dcu/fsl_dcu_drm_drv.h | 1 -
2 files changed, 6 insertions(+),
Replace driver's code with the generic helpers that do the same thing.
Remove todo entry.
Signed-off-by: Noralf Trønnes
---
Documentation/gpu/todo.rst | 5 ---
drivers/gpu/drm/tinydrm/core/tinydrm-core.c | 67 -
drivers/gpu/drm/tinydrm/mi0283qt.c
Replace driver's code with the generic helpers that do the same thing.
Cc: Liviu Dudau
Cc: Brian Starkey
Signed-off-by: Noralf Trønnes
Reviewed-by: Liviu Dudau
---
drivers/gpu/drm/arm/malidp_drv.c | 24 +++-
drivers/gpu/drm/arm/malidp_drv.h | 1 -
2 files changed, 3 inser
Add entry for conversion of drivers to new helpers.
Signed-off-by: Noralf Trønnes
Reviewed-by: Daniel Vetter
---
Documentation/gpu/todo.rst | 9 +
1 file changed, 9 insertions(+)
diff --git a/Documentation/gpu/todo.rst b/Documentation/gpu/todo.rst
index a44f379d2b25..6bce1beafabe 10064
Fix docs to reflect code and drm_kms_helper_poll_disable() docs by saying
that calling drm_kms_helper_poll_enable() is fine even if output polling
is not enabled.
Signed-off-by: Noralf Trønnes
Reviewed-by: Daniel Vetter
---
drivers/gpu/drm/drm_probe_helper.c | 3 +--
1 file changed, 1 insertion
This patchset adds some simple modeset suspend/resume helpers which
probably most atomic drivers can use.
For those that haven't followed dri-devel closely the past few days,
this patch put in place the fbdev piece necessary to do this:
drm: Add drm_device->fb_helper pointer
https://cgit.freedeskt
On 11/04/2017 08:04 AM, Noralf Trønnes wrote:
Use drm_fb_cma_fbdev_init_with_funcs() and drm_fb_cma_fbdev_fini() which
relies on the fact that drm_device holds a pointer to the drm_fb_helper
structure. This means that the driver doesn't have to keep track of that.
Also use the drm_fb_helper funct
On Mon, 2017-11-06 at 19:14 +0100, SF Markus Elfring wrote:
> A duplicate error message was used so far in this function implementation.
> Thus use a consistent message format instead together with property names
> where constant merging can be applied by the compiler in four cases.
[]
> diff --git
Additionally, we should also just fix this ratelimit macro anyway
since it's intended purpose is not to print anything when debugging isn't
enabled. What do you think Alex?
Well, at least I think that the described behavior of the macro is a bug
which should be fixed.
But I think that is indepe
From: Markus Elfring
Date: Mon, 6 Nov 2017 19:00:58 +0100
A duplicate error message was used so far in this function implementation.
Thus use a consistent message format instead together with property names
where constant merging can be applied by the compiler in four cases.
This issue was detec
On Thu, Nov 02, 2017 at 03:19:30PM +0200, Ville Syrjälä wrote:
> On Thu, Nov 02, 2017 at 11:12:09AM +0100, Daniel Vetter wrote:
> > On Wed, Nov 01, 2017 at 08:29:18PM +0200, Ville Syrjala wrote:
> > > From: Ville Syrjälä
> > >
> > > Try to fix the code to actually clip the plane to the crtc bound
Hi Noralf,
On 11/04/2017 02:04 PM, Noralf Trønnes wrote:
> Use drm_fb_cma_fbdev_init() and drm_fb_cma_fbdev_fini() which relies on
> the fact that drm_device holds a pointer to the drm_fb_helper structure.
> This means that the driver doesn't have to keep track of that.
> Also use the drm_fb_helpe
On Mon, Nov 6, 2017 at 12:20 PM, Randy Dunlap wrote:
> On 11/05/2017 11:30 PM, Stephen Rothwell wrote:
>> Hi all,
>>
>> Changes since 20171103:
>>
>
> on i386, when CONFIG_MODULES is not set:
>
> CC drivers/gpu/drm/amd/amdgpu/amdgpu_virt.o
> In file included from ../arch/x86/include/asm/ato
I messed up while rebasing patches and didn't test every intermediate
patch as I should have. The next patch in the series fixes this.
If anyone wants to fix this before merging further upstream, remove the
offending line in this commit and reintroduce it in the next commit in
the series. At this
On Fri, Nov 03, 2017 at 04:35:45PM -0400, Alex Deucher wrote:
> Minimum time required between power On of codec and read
> of RT5645_VENDOR_ID2 is 400msec. We should wait and attempt
> before erroring out.
So the description says we have to wait 400ms before attempting a
read...
> BUG=b:66978383
Quoting Christian König (2017-10-30 14:59:04)
> From: Christian König
>
> The amdgpu issue to also need signaled fences in the reservation objects
> should
> be fixed by now.
>
> Optimize the handling by replacing a signaled fence when adding a new
> shared one.
>
> Signed-off-by: Christian Kö
On Mon, Nov 06, 2017 at 04:43:17PM +0100, Maarten Lankhorst wrote:
> Op 06-11-17 om 15:06 schreef Ville Syrjälä:
> > On Mon, Nov 06, 2017 at 04:01:20PM +0200, Ville Syrjälä wrote:
> >> On Thu, Nov 02, 2017 at 09:55:40AM +0100, Maarten Lankhorst wrote:
> >>> Op 01-11-17 om 18:00 schreef Ville Syrjäl
Noralf Trønnes writes:
> Use drm_fb_cma_fbdev_init() and drm_fb_cma_fbdev_fini() which relies on
> the fact that drm_device holds a pointer to the drm_fb_helper structure.
> This means that the driver doesn't have to keep track of that.
> Also use the drm_fb_helper functions directly.
Reviewed-b
Quoting Christian König (2017-10-30 14:59:03)
> From: Christian König
>
> The amdgpu issue to also need signaled fences in the reservation objects
> should be fixed by now.
>
> Optimize the list by keeping only the not signaled yet fences around.
>
> v2: temporary put the signaled fences at the
The main reason I added this was because the radeon driver's hotplugging paths
for DP do a ton of unnessecary probing, and because the driver usually also
checks all connectors every time there's a hotplug (there isn't much of a good
reason for this, it's just an old driver) it's not at all difficu
https://bugs.freedesktop.org/show_bug.cgi?id=102358
--- Comment #37 from har...@gmx.de ---
Ok, thanks for clarification.
I prefer not to add such tag, because this is my anonymous email address,
dedicated to things like to games.
/Jens
--
You are receiving this mail because:
You are the assign
Instead a getting only one common device "/dev/ion" for
all the heaps this patch allow to create one device
entry ("/dev/ionX") per heap.
Getting an entry per heap could allow to set security rules
per heap and global ones for all heaps.
Allocation requests will be only allowed if the mask_id
matc
Put include in alphabetic order
Signed-off-by: Benjamin Gaignard
---
drivers/staging/android/ion/ion.c | 14 +++---
1 file changed, 7 insertions(+), 7 deletions(-)
diff --git a/drivers/staging/android/ion/ion.c
b/drivers/staging/android/ion/ion.c
index a7d9b0e..fda9756 100644
--- a/dri
version 6:
- add an ION bus so heap are show as devices in /sys/bus/ion/
instead of platform bus.
- split the patch in two: one for include reordering and one
for per heap device change
- rebased on top of next-2017110 tag
version 5:
- create a configuration flag to keep legacy Ion misc device
On Fri, Nov 03, 2017 at 04:35:43PM -0400, Alex Deucher wrote:
> Signed-off-by: Vijendar Mukunda
> Signed-off-by: Akshu Agrawal
> Reviewed-on: https://chromium-review.googlesource.com/659699
> Commit-Ready: Akshu Agrawal
> Tested-by: Akshu Agrawal
> Reviewed-by: Jason Clinton
> Reviewed-on: ht
Op 06-11-17 om 15:06 schreef Ville Syrjälä:
> On Mon, Nov 06, 2017 at 04:01:20PM +0200, Ville Syrjälä wrote:
>> On Thu, Nov 02, 2017 at 09:55:40AM +0100, Maarten Lankhorst wrote:
>>> Op 01-11-17 om 18:00 schreef Ville Syrjälä:
On Wed, Nov 01, 2017 at 04:55:06PM +0100, Maarten Lankhorst wrote:
On Mon, Nov 06, 2017 at 02:58:43PM +0100, Arnd Bergmann wrote:
> Build-testing on randconfig kernels revealed a dependency in the
> newly added lvds sub-driver:
>
> drivers/gpu/drm/rockchip/rockchip_lvds.c: In function 'rockchip_lvds_bind':
> drivers/gpu/drm/rockchip/rockchip_lvds.c:380:24: error:
Hi,
I see this on an 32-bit acer atom mini-laptop with -rc8+tip:
[2.399416] pipe B vblank wait timed out
[2.399506] [ cut here ]
[2.399533] WARNING: CPU: 1 PID: 22 at
/mnt/kernel/kernel/linux-2.6/drivers/gpu/drm/i915/intel_display.c:12176
intel_atomic_commit_
On Wed, Nov 01, 2017 at 04:20:56PM +0200, Jani Nikula wrote:
> We were recently bitten by drm_edid_to_eld() clearing the connector
> type, and us failing to set it back for DP. Here's a few ELD related
> patches to try to unify ELD handling and make it a bit simpler for
> drivers to get it right.
>
On Mon, Nov 06, 2017 at 03:42:04PM +0100, Benjamin Gaignard wrote:
> 2017-11-02 12:10 GMT+01:00 Mark Brown :
> > On Thu, Nov 02, 2017 at 11:44:07AM +0100, Greg KH wrote:
> >> On Tue, Oct 31, 2017 at 07:11:53PM +, Mark Brown wrote:
> >
> >> > There was a discussion a while ago in the context of
2017-11-02 12:10 GMT+01:00 Mark Brown :
> On Thu, Nov 02, 2017 at 11:44:07AM +0100, Greg KH wrote:
>> On Tue, Oct 31, 2017 at 07:11:53PM +, Mark Brown wrote:
>
>> > There was a discussion a while ago in the context of I2C/SPI MFDs
>> > which concluded that if you need a bus and it's going to be
On Fri, Oct 27, 2017 at 3:18 AM, Lukasz Majewski wrote:
> Hi Rob,
>
>> On Sat, Oct 21, 2017 at 12:10:03AM +0200, Lukasz Majewski wrote:
>> > Signed-off-by: Lukasz Majewski
>> > ---
>> > .../bindings/display/panel/tianma,tm070rvhg71.txt | 7 ++
>> > drivers/gpu/drm/panel/panel-simple.c
On Fri, Oct 20, 2017 at 5:18 PM, Lukasz Majewski wrote:
> This commit adds support for Mitsubishi aa070mc01 TFT panel working
> with 8 bit ISP mode (pin 19 "mode" HIGH for 20 pin TFT connector).
>
> Signed-off-by: Lukasz Majewski
> ---
> Changes for v2:
> - Place the code sorted alphabetically
>
On Mon, Nov 06, 2017 at 04:01:20PM +0200, Ville Syrjälä wrote:
> On Thu, Nov 02, 2017 at 09:55:40AM +0100, Maarten Lankhorst wrote:
> > Op 01-11-17 om 18:00 schreef Ville Syrjälä:
> > > On Wed, Nov 01, 2017 at 04:55:06PM +0100, Maarten Lankhorst wrote:
> > >> Op 01-11-17 om 16:29 schreef Ville Syrj
On Thu, Nov 02, 2017 at 09:55:40AM +0100, Maarten Lankhorst wrote:
> Op 01-11-17 om 18:00 schreef Ville Syrjälä:
> > On Wed, Nov 01, 2017 at 04:55:06PM +0100, Maarten Lankhorst wrote:
> >> Op 01-11-17 om 16:29 schreef Ville Syrjälä:
> >>> On Wed, Nov 01, 2017 at 04:04:33PM +0100, Maarten Lankhorst
Build-testing on randconfig kernels revealed a dependency in the
newly added lvds sub-driver:
drivers/gpu/drm/rockchip/rockchip_lvds.c: In function 'rockchip_lvds_bind':
drivers/gpu/drm/rockchip/rockchip_lvds.c:380:24: error: 'struct drm_bridge' has
no member named 'of_node'
remote = lvds->bri
On Mon, Nov 6, 2017 at 5:16 AM, Robert Foss wrote:
> Hey Rob,
>
> On Fri, 2017-11-03 at 07:35 -0500, Rob Herring wrote:
>> On Thu, Nov 2, 2017 at 11:45 PM, Chih-Wei Huang > org> wrote:
>> > The file contains rules that are executed on incremental builds.
>> > Since commit 4f7dc9b6 the library was
On Sat, Nov 4, 2017 at 2:04 PM, Noralf Trønnes wrote:
> Use drm_fb_cma_fbdev_init() and drm_fb_cma_fbdev_fini() which relies on
> the fact that drm_device holds a pointer to the drm_fb_helper structure.
> This means that the driver doesn't have to keep track of that.
> Also use the drm_fb_helper
On Sat, Nov 4, 2017 at 2:04 PM, Noralf Trønnes wrote:
> Use drm_fb_cma_fbdev_init() and drm_fb_cma_fbdev_fini() which relies on
> the fact that drm_device holds a pointer to the drm_fb_helper structure.
> This means that the driver doesn't have to keep track of that.
> Also use the drm_fb_helper
From: Colin Ian King
Variables err_max, err_target and f_best are being assigned values but
these are never read, hence they are redundant variables and can be
removed. Cleans up clang warnings:
drivers/video/fbdev/intelfb/intelfbhw.c:946:2: warning: Value stored to
'err_max' is never read
drive
Den 06.11.2017 10.08, skrev Daniel Vetter:
On Sat, Nov 04, 2017 at 02:03:57PM +0100, Noralf Trønnes wrote:
Use drm_fb_cma_fbdev_init() and drm_fb_cma_fbdev_fini() which relies on
the fact that drm_device holds a pointer to the drm_fb_helper structure.
This means that the driver doesn't have to
Den 06.11.2017 10.04, skrev Daniel Vetter:
On Sat, Nov 04, 2017 at 02:03:56PM +0100, Noralf Trønnes wrote:
Add functions drm_fb_cma_fbdev_init(), drm_fb_cma_fbdev_fini() and
drm_fb_cma_fbdev_init_with_funcs(). These functions relies on the fact
that the drm_fb_helper struct is stored in dev->dr
Den 06.11.2017 09.54, skrev Daniel Vetter:
On Sat, Nov 04, 2017 at 02:03:55PM +0100, Noralf Trønnes wrote:
Make the drm_framebuffer_funcs argument optional for drivers that
don't need to set the dirty callback.
Signed-off-by: Noralf Trønnes
Looks like this patch ended up in the wrong patch s
On Thu, Nov 02, 2017 at 09:09:06PM +0100, Noralf Trønnes wrote:
> These helpers take care of output polling, fbdev and atomic state.
Hmm, not much useful info here, tbh. Maybe something like:
"Replace driver's code with the generic helpers that do the same thing" ?
>
> Cc: Liviu Dudau
> Cc: Br
Am 06.11.2017 um 12:43 schrieb Dan Carpenter:
backlight_device_register() never returns NULL, it returns error
pointers on error so the check here is wrong.
Signed-off-by: Dan Carpenter
Acked-by: Christian König
diff --git a/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c
b/drivers/gpu
Am 06.11.2017 um 12:44 schrieb Dan Carpenter:
We assign "v_init = asic_blank_start;" a few lines earlier so there is
no need to do it again inside the if statements. Also "v_init" is
unsigned so it can't be less than zero.
Signed-off-by: Dan Carpenter
Acked-by: Christian König
diff --git
https://bugs.freedesktop.org/show_bug.cgi?id=101483
FFAB changed:
What|Removed |Added
Attachment #135182|0 |1
is obsolete|
https://bugs.freedesktop.org/show_bug.cgi?id=101483
--- Comment #23 from FFAB ---
Created attachment 135255
--> https://bugs.freedesktop.org/attachment.cgi?id=135255&action=edit
dmesg upstream kernel 4.14-rc8, 2017-11-06
--
You are receiving this mail because:
You are the assignee for the bug
https://bugs.freedesktop.org/show_bug.cgi?id=101483
--- Comment #22 from FFAB ---
Upstream kernel test - kernel 4.14-rc8
Installation, on which upstream kernel was installed:
ubuntu 16.04.3, kernel4.10.0-38, updated 2017-11-06
1. booting without any workaround parameters
2. booting with kernel
We assign "v_init = asic_blank_start;" a few lines earlier so there is
no need to do it again inside the if statements. Also "v_init" is
unsigned so it can't be less than zero.
Signed-off-by: Dan Carpenter
diff --git a/drivers/gpu/drm/amd/display/dc/dcn10/dcn10_timing_generator.c
b/drivers/gpu
backlight_device_register() never returns NULL, it returns error
pointers on error so the check here is wrong.
Signed-off-by: Dan Carpenter
diff --git a/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c
b/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c
index 33a15a1d818c..75f9383f5b9b 100644
On 05/11/17 11:53, Colin King wrote:
From: Colin Ian King
The variable len is assigned but never read, therefore it is redundant
and can be removed. Cleans up clang warning:
drivers/video/backlight/ili922x.c:276:2: warning: Value stored to 'len'
is never read
Signed-off-by: Colin Ian King
Linux-next was offline for the last month and the AMD drm driver went
through major changes. Anyway, I'm a bit overwhelmed by the number of
warnings and I'm not going to be able to go through them all so I'm just
sending them to you unfiltered.
Part of the problem is that I'm not running the rele
Hey Rob,
On Fri, 2017-11-03 at 07:35 -0500, Rob Herring wrote:
> On Thu, Nov 2, 2017 at 11:45 PM, Chih-Wei Huang org> wrote:
> > The file contains rules that are executed on incremental builds.
> > Since commit 4f7dc9b6 the library was moved to /vendor so
> > the old file must be removed.
> >
>
Hi!
> > P.S.: I got asked by different people about the status of this
> > patchset, which is required for display support on N9, N950 and
> > Droid 4. It's not just me and Tony, that are interested in this :)
>
> Ok. If you agree to help with the DSI part in the future, I have no
> problems appl
On Sat, Nov 04, 2017 at 03:08:26PM +0100, Hans de Goede wrote:
> Ideally we could use the VBT for this, that would be simple, in
> intel_dsi_init() check dev_priv->vbt.dsi.config->rotation, set
> connector->display_info.panel_orientation accordingly and call
> drm_connector_init_panel_orientation_p
On Sat, 4 Nov 2017 14:03:59 +0100
Noralf Trønnes wrote:
> Use drm_fb_cma_fbdev_init() and drm_fb_cma_fbdev_fini() which relies on
> the fact that drm_device holds a pointer to the drm_fb_helper structure.
> This means that the driver doesn't have to keep track of that.
> Also use the drm_fb_help
https://bugs.freedesktop.org/show_bug.cgi?id=99843
--- Comment #14 from d...@jerber.co.uk ---
The 4890 has a RV790 GPU.
I've run the trace again and also see an error similar to the one Gert
mentioned:
1639 Message api issue 1: FBO incomplete: no attachments and default width or
height is 0 [-1]
On Sat, 2017-11-04 at 14:04 +0100, Noralf Trønnes wrote:
> Use drm_fb_cma_fbdev_init() and drm_fb_cma_fbdev_fini() which relies on
> the fact that drm_device holds a pointer to the drm_fb_helper structure.
> This means that the driver doesn't have to keep track of that.
> Also use the drm_fb_helper
On Mon, Nov 06, 2017 at 10:00:25AM +0100, SF Markus Elfring wrote:
> >> If you want to lower the size of strings in this driver, you can do it,
> >> but not like this.
> >
> > Just so we're clear, GCC already detects and combines it when you use
> > the same string constant twice.
>
> Do you dist
> Sorry but NACK: the message was malformed and resulted in the
> duplication of the error log that you spotted.
>
> The proper way to fix this is to modify the second occurrence of this message.
* Would you like to achieve that a corresponding message will mention
anything around a property “a
On Sat, Nov 04, 2017 at 03:08:25PM +0100, Hans de Goede wrote:
> Apply the "panel orientation" drm connector prop to the primary plane so
> that fbcon and fbdev using userspace programs display the right way up.
>
> Fixes: https://bugs.freedesktop.org/show_bug.cgi?id=94894
> Signed-off-by: Hans de
On Sat, Nov 04, 2017 at 03:08:24PM +0100, Hans de Goede wrote:
> On some devices the LCD panel is mounted in the casing in such a way that
> the up/top side of the panel does not match with the top side of the
> device (e.g. it is mounted upside-down).
>
> This commit adds the necessary infra for
On Sat, Nov 04, 2017 at 03:08:23PM +0100, Hans de Goede wrote:
> Some x86 clamshell design devices use portrait tablet screens and a display
> engine which cannot rotate in hardware, so the firmware just leaves things
> as is and we cannot figure out that the display is oriented non upright
> from
On Sat, Nov 04, 2017 at 02:04:16PM +0100, Noralf Trønnes wrote:
> Remove the unused struct drm_fbdev_cma functions.
>
> Cc: Laurent Pinchart
> Signed-off-by: Noralf Trønnes
On patches 22&21:
Acked-by: Daniel Vetter
> ---
> drivers/gpu/drm/drm_fb_cma_helper.c | 158
>
On Sat, Nov 04, 2017 at 02:03:57PM +0100, Noralf Trønnes wrote:
> Use drm_fb_cma_fbdev_init() and drm_fb_cma_fbdev_fini() which relies on
> the fact that drm_device holds a pointer to the drm_fb_helper structure.
> This means that the driver doesn't have to keep track of that.
> Also use the drm_fb
On Sat, Nov 04, 2017 at 02:03:56PM +0100, Noralf Trønnes wrote:
> Add functions drm_fb_cma_fbdev_init(), drm_fb_cma_fbdev_fini() and
> drm_fb_cma_fbdev_init_with_funcs(). These functions relies on the fact
> that the drm_fb_helper struct is stored in dev->drm_fb_helper_private
> so drivers don't ne
>> If you want to lower the size of strings in this driver, you can do it,
>> but not like this.
>
> Just so we're clear, GCC already detects and combines it when you use
> the same string constant twice.
Do you distinguish between merging of constants and the combination
of statements for such a
Am 06.11.2017 um 08:07 schrieb Dan Carpenter:
Static analysis tools get annoyed that we don't indent this if
statement. Actually, the if statement isn't required because kfree()
can handle NULL pointers just fine. The DCE110STRENC_FROM_STRENC()
macro is a wrapper around container_of() but it's
On Sat, Nov 04, 2017 at 02:03:55PM +0100, Noralf Trønnes wrote:
> Make the drm_framebuffer_funcs argument optional for drivers that
> don't need to set the dirty callback.
>
> Signed-off-by: Noralf Trønnes
Looks like this patch ended up in the wrong patch series? Atm there's not
much users of th
On Mon, Nov 06, 2017 at 09:40:19AM +0100, Nicolas Ferre wrote:
> If you want to lower the size of strings in this driver, you can do it,
> but not like this.
Just so we're clear, GCC already detects and combines it when you use
the same string constant twice.
regards,
dan carpenter
__
On Thu, Nov 02, 2017 at 09:09:09PM +0100, Noralf Trønnes wrote:
> Add entry for conversion of drivers to new helpers.
>
> Signed-off-by: Noralf Trønnes
Reviewed-by: Daniel Vetter
I think you can merge this one as soon as the code has landed, no need to
wait for all the driver conversions to ge
On Thu, Nov 02, 2017 at 09:09:05PM +0100, Noralf Trønnes wrote:
> Add drm_mode_config_helper_suspend/resume() which takes care of
> atomic modeset suspend/resume for simple use cases.
> The suspend state is stored in struct drm_mode_config.
>
> Signed-off-by: Noralf Trønnes
It'd be great if we c
On Thu, Nov 02, 2017 at 09:09:04PM +0100, Noralf Trønnes wrote:
> Fix docs to reflect code and drm_kms_helper_poll_disable() docs by saying
> that calling drm_kms_helper_poll_enable() is fine even if output polling
> is not enabled.
>
> Signed-off-by: Noralf Trønnes
Reviewed-by: Daniel Vetter
On Thu, Nov 02, 2017 at 10:03:34PM +0200, Ville Syrjala wrote:
> From: Chris Wilson
>
> In order to silent sparse in dma_fence_get_rcu_safe(), we need to mark
s/silent/silence/
On the series (assuming sparse is indeed happy now, I didn't check that):
Reviewed-by: Daniel Vetter
> the incoming
On Thu, Nov 02, 2017 at 04:44:47PM +0100, Maxime Ripard wrote:
> On Thu, Nov 02, 2017 at 04:51:29PM +0800, Icenowy Zheng wrote:
> > 在 2017-10-27 23:06，Icenowy Zheng 写道：
> > > This patchset adds support for the SimpleFB on Allwinner SoCs with
> > > "Display Engine 2.0".
> > >
> > > PATCH 1 to PATCH
On Fri, Nov 03, 2017 at 01:07:57PM -0700, Eric Anholt wrote:
> Kees Cook writes:
>
> > On Mon, Oct 30, 2017 at 4:49 PM, Eric Anholt wrote:
> >> Kees Cook writes:
> >>
> >>> In preparation for unconditionally passing the struct timer_list pointer
> >>> to
> >>> all timer callbacks, switch to us
From: Aleksandar Markovic
Add documentation for DT binding of Goldfish FB driver. The compatible
string used by OS for binding the driver is "google,goldfish-fb".
Signed-off-by: Miodrag Dinic
Signed-off-by: Goran Ferenc
Signed-off-by: Aleksandar Markovic
Acked-by: Rob Herring
---
.../device
This is now all handled in the drivers and communicated through
fb_info.fbcon_rotate_hint.
Signed-off-by: Hans de Goede
---
drivers/video/fbdev/core/Makefile | 3 -
drivers/video/fbdev/core/fbcon.c| 4 +-
drivers/video/fbdev/core/fbcon.h| 6 --
drivers/vid
On some hardware the LCD panel is not mounted upright in the casing,
but upside-down or rotated 90 degrees. In this case we want the console
to automatically be rotated to compensate.
The fbdev-driver may know about the need to rotate. Add a new
fbcon_rotate_hint field to struct fb_info, which get
Some x86 clamshell design devices use portrait tablet screens and a display
engine which cannot rotate in hardware, so the firmware just leaves things
as is and we cannot figure out that the display is oriented non upright
from the hardware.
So at least on x86, we need a quirk table for this. This
Ideally we could use the VBT for this, that would be simple, in
intel_dsi_init() check dev_priv->vbt.dsi.config->rotation, set
connector->display_info.panel_orientation accordingly and call
drm_connector_init_panel_orientation_property(), done.
Unfortunately vbt.dsi.config->rotation is always 0 ev
Hi All,
Here is v5 of my series to add a "panel orientation" property to
the drm-connector for the LCD panel to let userspace know about LCD
panels which are not mounted upright, as well as detecting upside-down
panels without needing quirks (like we do for 90 degree rotated screens).
New in v5:
Hi Rob,
> Hi Rob,
>
> > On Sat, Oct 21, 2017 at 12:10:03AM +0200, Lukasz Majewski wrote:
> > > Signed-off-by: Lukasz Majewski
> > > ---
> > > .../bindings/display/panel/tianma,tm070rvhg71.txt | 7 ++
> > > drivers/gpu/drm/panel/panel-simple.c | 27
> > > +++
Hello!
I'm using Dell Precision P7510 with up-to-date Fedora 27. Everything
was working fine when I had two identical monitors (Dell 24")
connected to the dock with DisplayPort cables. Various issues started
when I replaced one of the monitors with a larger Dell 34" monitor. I
could work them arou
1 - 100 of 109 matches
Mail list logo
