https://bugs.freedesktop.org/show_bug.cgi?id=101182
Bug ID: 101182
Summary: Reading amdgpu_pm_info causes stutter with Linux
4.12-rc
Product: DRI
Version: DRI git
Hardware: Other
OS: All
Status:
On Thu, May 25, 2017 at 01:41:33AM -0300, Gustavo Padovan wrote:
> From: Gustavo Padovan
>
> Add support to async updates of cursors by using the new atomic
> interface for that. Basically what this commit does is do what
> intel_legacy_cursor_update() did but through atomic.
>
> v3:
> - s
On Wed, May 24, 2017 at 11:28:12AM +0200, Daniel Vetter wrote:
> We can't check this when applying (since r-b/a-b tags often get added
> afterwards), but we can check this when pushing. This only looks at
> patches authored by the pusher.
BTW, can we also have a rule that large drivers (i.e. with
From: Gustavo Padovan
After converting legacy cursor updates to atomic async commits
mdp5_cursor_plane_funcs just duplicates mdp5_plane_funcs now.
Cc: Rob Clark
Cc: Archit Taneja
Signed-off-by: Gustavo Padovan
---
drivers/gpu/drm/msm/mdp/mdp5/mdp5_plane.c | 26 +++---
1 f
From: Gustavo Padovan
Add support to async updates of cursors by using the new atomic
interface for that. Basically what this commit does is do what
mdp5_update_cursor_plane_legacy() did but through atomic.
v4: add missing atomic async commit call to msm_atomic_commit(Archit Taneja)
v3: move si
From: Gustavo Padovan
Add support to async updates of cursors by using the new atomic
interface for that. Basically what this commit does is do what
vc4_update_plane() did but through atomic.
v3: move size checks back to drivers (Ville Syrjälä)
v2: move fb setting to core and use new state (Eri
From: Gustavo Padovan
After converting legacy cursor updates to atomic async commits
intel_cursor_plane_funcs just duplicates intel_plane_funcs now.
Cc: Daniel Vetter
Signed-off-by: Gustavo Padovan
---
drivers/gpu/drm/i915/intel_display.c | 13 +
1 file changed, 1 insertion(+), 12
From: Gustavo Padovan
Hi,
New version of the patches after the comments from Archit. Full details
and the previous discussion can be found here:
https://www.spinics.net/lists/dri-devel/msg141337.html
I'm not including the uAPI patch here, because we don't have any userspace
for it yet.
Please
From: Gustavo Padovan
Add support to async updates of cursors by using the new atomic
interface for that. Basically what this commit does is do what
intel_legacy_cursor_update() did but through atomic.
v3:
- set correct vma to new state for cleanup
- move size checks back to driv
From: Gustavo Padovan
In some cases, like cursor updates, it is interesting to update the
plane in an asynchronous fashion to avoid big delays. The current queued
update could be still waiting for a fence to signal and thus block any
subsequent update until its scan out. In cases like this if we
On Wed, 2017-05-24 at 14:24 +0200, Daniel Vetter wrote:
> On Wed, May 24, 2017 at 05:20:45PM +0800, CK Hu wrote:
> > On Tue, 2017-05-23 at 15:12 +0200, Daniel Vetter wrote:
> > > On Tue, May 23, 2017 at 05:28:15PM +0800, CK Hu wrote:
> > > > Hi, Bibby:
> > > >
> > > > I've applied this patch to my
On Wed, May 24, 2017 at 04:52:11PM +0200, Daniel Vetter wrote:
> It again looks all cargo-culted for no good reasons.
drm_vblank_cleanup() is called to release the resources allocated by
drm_vblank_init(). I think that's the reason, no?
Shawn
>
> Cc: Shawn Guo
> Signed-off-by: Daniel Vetter
Hi Daniel,
On Wed, May 24, 2017 at 02:23:22PM +0200, Daniel Vetter wrote:
> On Tue, May 23, 2017 at 09:47:56AM -0500, Rob Herring wrote:
> > On Tue, May 16, 2017 at 11:19:04AM +0300, Baruch Siach wrote:
> > > Fixes: 14da3ed8dd08 ("devicetree/bindings: display: Document common panel
> > > properti
On Wed, May 24, 2017 at 10:21:31AM +0100, Chris Wilson wrote:
> On Wed, May 24, 2017 at 04:50:39PM +0800, changbin...@intel.com wrote:
> > From: Changbin Du
> >
> > At least we need one MPT module (currently only have one) selected
> > to get GVTg functional. When GVTg is enabled while no MPT sel
Hi Daniel,
On Wed, 2017-05-24 at 16:51 +0200, Daniel Vetter wrote:
> CRTC don't seem to get shut down in a controlled fashion, but no one
> bothers to stop interrupts either so this races no matter what. Might
> as well remove it. A call to drm_atomic_helper_shutdown would be
> pretty sweet somewh
From: Changbin Du
At least we need one MPT module (currently only have one) selected
to get GVTg functional. When GVTg is enabled while no MPT selected,
the build just includes useless GVTg code. This doesn't make sense.
With this patch, a submenut is created under i915 as below:
-*- Enable In
On Thu, May 18, 2017 at 12:43 AM, Icenowy Zheng wrote:
> As we have already the support for the TV encoder on Allwinner H3, add
> the display engine pipeline device tree nodes to its DTSI file.
>
> The H5 pipeline has some differences and will be enabled later.
>
> The currently-unused mixer0 and
于 2017年5月24日 GMT+08:00 下午1:34:58, Chen-Yu Tsai 写到:
>On Wed, May 24, 2017 at 1:28 PM, Icenowy Zheng wrote:
>>
>>
>> 于 2017年5月24日 GMT+08:00 下午1:24:29, Chen-Yu Tsai 写到:
>>>On Thu, May 18, 2017 at 12:43 AM, Icenowy Zheng
>>>wrote:
As we have already the support for the TV encoder on Allwinne
于 2017年5月24日 GMT+08:00 下午3:30:19, Maxime Ripard
写到:
>On Tue, May 23, 2017 at 09:00:59PM +0800, icen...@aosc.io wrote:
>> 在 2017-05-23 20:53，Maxime Ripard 写道：
>> > On Mon, May 22, 2017 at 07:55:56PM +0200, Jernej Škrabec wrote:
>> > > Hi,
>> > >
>> > > Dne sobota, 20. maj 2017 ob 03:37:53 CEST
Hi Mark
Cc: DRM maintainer
> > ALSA SoC needs to know connected DAI ID for probing.
> > It is not a big problem if device/driver was only for sound,
> > but getting DAI ID will be difficult if device includes both
> > Video/Sound, like HDMI.
>
> As far as I understand what's going on with the gr
于 2017年5月24日 GMT+08:00 下午1:24:29, Chen-Yu Tsai 写到:
>On Thu, May 18, 2017 at 12:43 AM, Icenowy Zheng
>wrote:
>> As we have already the support for the TV encoder on Allwinner H3,
>add
>> the display engine pipeline device tree nodes to its DTSI file.
>>
>> The H5 pipeline has some differences an
Hi Thierry,
From: Fabio Estevam
Sent: Monday, May 8, 2017 10:54 AM
To: Marco Franchi
Cc: DRI mailing list; Thierry Reding; robh...@kernel.org
Subject: Re: [PATCH] drm/panel: Add driver for Seiko 43WVF1G panel
On Tue, Apr 25, 2017 at 1:18 PM, Marco Franchi wrote:
On Wed, May 24, 2017 at 1:28 PM, Icenowy Zheng wrote:
>
>
> 于 2017年5月24日 GMT+08:00 下午1:24:29, Chen-Yu Tsai 写到:
>>On Thu, May 18, 2017 at 12:43 AM, Icenowy Zheng
>>wrote:
>>> As we have already the support for the TV encoder on Allwinner H3,
>>add
>>> the display engine pipeline device tree nodes
On 2017-05-23 12:45, Laurent Pinchart wrote:
> Hi Peter,
>
> Thank you for the patch.
>
> On Monday 15 May 2017 12:03:11 Peter Ujfalusi wrote:
>> If the hpd_gpio is valid, use interrupt handler to react to HPD changes.
>> In case the hpd_gpio is not valid, try to enable hpd detection on the
>> en
Hi,
Dne sreda, 24. maj 2017 ob 10:25:46 CEST je Icenowy Zheng napisal(a):
> 于 2017年5月24日 GMT+08:00 下午3:30:19, Maxime Ripard 写到:
> >On Tue, May 23, 2017 at 09:00:59PM +0800, icen...@aosc.io wrote:
> >> 在 2017-05-23 20:53，Maxime Ripard 写道：
> >>
> >> > On Mon, May 22, 2017 at 07:55:56PM +0200, Jern
struct irq_domain_ops is not modified, so it can be made const.
Signed-off-by: Tobias Klauser
---
drivers/gpu/drm/msm/mdp/mdp5/mdp5_mdss.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/gpu/drm/msm/mdp/mdp5/mdp5_mdss.c
b/drivers/gpu/drm/msm/mdp/mdp5/mdp5_mdss.c
inde
Hi Dave,
Just cc'ing you as I guess you will need to fix this up at some point.
On Tue, 23 May 2017 12:00:32 +1000 Stephen Rothwell
wrote:
>
> Hi all,
>
> Today's linux-next merge of the drm-misc tree got a conflict in:
>
> drivers/gpu/drm/i915/intel_display.c
>
> between commits:
>
> 1
2017-05-22 Daniel Vetter :
> On Tue, May 16, 2017 at 12:10:42PM +0100, Chris Wilson wrote:
> > Constructing the name takes the majority of the time for allocating a
> > sync_file to wrap a fence, and the name is very rarely used (only via
> > the sync_file status user interface). To reduce the imp
Hi Mauro,
2017-05-18 Mauro Carvalho Chehab :
> Each text file under Documentation follows a different
> format. Some doesn't even have titles!
>
> Change its representation to follow the adopted standard,
> using ReST markups for it to be parseable by Sphinx:
> - Use markup for document title an
On Wed, May 24, 2017 at 9:52 PM, Daniel Vetter wrote:
> On Wed, May 24, 2017 at 6:57 PM, Patrik Jakobsson
> wrote:
>> Hi Dave and Daniel,
>>
>> We had a little mishap this morning when I had pushed a fix for gma500
>> into drm-misc-fixes without first getting someone to review it. The
>> patch ha
https://bugs.freedesktop.org/show_bug.cgi?id=100784
Jon changed:
What|Removed |Added
Version|17.0|17.1
--- Comment #3 from Jon ---
Present in 17.1
Quick clarification.
On Wed, May 24, 2017 at 9:52 PM, Daniel Vetter wrote:
> On Wed, May 24, 2017 at 6:57 PM, Patrik Jakobsson
> wrote:
>> Hi Dave and Daniel,
>>
>> We had a little mishap this morning when I had pushed a fix for gma500
>> into drm-misc-fixes without first getting someone to revi
On Wed, May 24, 2017 at 6:57 PM, Patrik Jakobsson
wrote:
> Hi Dave and Daniel,
>
> We had a little mishap this morning when I had pushed a fix for gma500
> into drm-misc-fixes without first getting someone to review it. The
> patch have been on the list for over a month and I don't feel like I
> h
https://bugs.freedesktop.org/show_bug.cgi?id=101160
--- Comment #4 from mercuriete ---
Created attachment 131473
--> https://bugs.freedesktop.org/attachment.cgi?id=131473&action=edit
detail of addresses
I see some differences between radeon and amdgpu in the addreses
gpu addr cpu addr.
not su
https://bugs.freedesktop.org/show_bug.cgi?id=101160
--- Comment #3 from mercuriete ---
Created attachment 131472
--> https://bugs.freedesktop.org/attachment.cgi?id=131472&action=edit
radeonsi dmesg
Only for comparison this is the dmesg when using radeonsi kernel driver.
--
You are receiving
On Sat, May 20, 2017 at 7:39 AM, Christian König
wrote:
> Am 20.05.2017 um 01:48 schrieb Lyude:
>>
>> This is the first part of me going through and cleaning up the IRQ
>> handling
>> code for radeon, since after taking a look at it the other day while
>> trying to
>> debug something I realized ba
On Fri, May 12, 2017 at 2:56 AM, Christian König
wrote:
> Am 12.05.2017 um 01:31 schrieb Lyude:
>>
>> We end up reading the interrupt register for HPD5, and then writing it
>> to HPD6 which on systems without anything using HPD5 results in
>> permanently disabling hotplug on one of the display out
https://bugs.freedesktop.org/show_bug.cgi?id=101160
--- Comment #2 from mercuriete ---
Created attachment 131471
--> https://bugs.freedesktop.org/attachment.cgi?id=131471&action=edit
dmesg photo
Sorry I will upload a photo because the system freezes before init starts and
my disk being mounted
The patch
ASoC: hdmi-codec: add .get_dai_id support
has been applied to the asoc tree at
git://git.kernel.org/pub/scm/linux/kernel/git/broonie/sound.git
All being well this means that it will be integrated into the linux-next
tree (usually sometime in the next 24 hours) and sent to Linus
The patch
ASoC: hdmi-codec: remove multi detection support
has been applied to the asoc tree at
git://git.kernel.org/pub/scm/linux/kernel/git/broonie/sound.git
All being well this means that it will be integrated into the linux-next
tree (usually sometime in the next 24 hours) and sent t
The patch
ASoC: simple-card-utils: support snd_soc_get_dai_id()
has been applied to the asoc tree at
git://git.kernel.org/pub/scm/linux/kernel/git/broonie/sound.git
All being well this means that it will be integrated into the linux-next
tree (usually sometime in the next 24 hours) and s
The patch
ASoC: add snd_soc_get_dai_id() function
has been applied to the asoc tree at
git://git.kernel.org/pub/scm/linux/kernel/git/broonie/sound.git
All being well this means that it will be integrated into the linux-next
tree (usually sometime in the next 24 hours) and sent to Linus d
On Thu, May 18, 2017 at 01:40:47AM +, Kuninori Morimoto wrote:
> ALSA SoC needs to know connected DAI ID for probing.
> It is not a big problem if device/driver was only for sound,
> but getting DAI ID will be difficult if device includes both
> Video/Sound, like HDMI.
As far as I understand
Yes, I believe this is the proper way for sync_file and syncobj to
interact. Again, I can't really review for all of the kernel details
(though the seem ok to me) so this mostly applies to the API:
Reviewed-by: Jason Ekstrand
On Wed, May 24, 2017 at 12:06 AM, Dave Airlie wrote:
> From: Dave A
I can't really review for all of the kernel details (though the seem ok to
me) so this mostly applies to the API:
Reviewed-by: Jason Ekstrand
On Wed, May 24, 2017 at 12:06 AM, Dave Airlie wrote:
> From: Dave Airlie
>
> Sync objects are new toplevel drm object, that contain a
> pointer to a fe
On Wed, May 24, 2017 at 10:25 AM, Jason Ekstrand
wrote:
> On Wed, May 24, 2017 at 12:06 AM, Dave Airlie wrote:
>
>> From: Dave Airlie
>>
>> This interface will allow sync object to be used to back
>> Vulkan fences. This API is pretty much the vulkan fence waiting
>> API, and I've ported the cod
On Wed, May 24, 2017 at 12:06 AM, Dave Airlie wrote:
> From: Dave Airlie
>
> This interface will allow sync object to be used to back
> Vulkan fences. This API is pretty much the vulkan fence waiting
> API, and I've ported the code from amdgpu.
>
> v2: accept relative timeout, pass remaining tim
Hi Dave and Daniel,
We had a little mishap this morning when I had pushed a fix for gma500
into drm-misc-fixes without first getting someone to review it. The
patch have been on the list for over a month and I don't feel like I
have enough karma to force someone to review it. Since I'm the only
on
On Wed, May 24, 2017 at 04:19:31PM +0100, Chris Wilson wrote:
> On Wed, May 24, 2017 at 04:51:35PM +0200, Daniel Vetter wrote:
> > Hi all,
> >
> > So the first part of this patch series is the usual deal of decrufting some
> > part
> > of drm and attempting to improve the docs. Mostly around vbla
On Tue, May 23, 2017 at 12:08 AM, Eric Anholt wrote:
>
> Oh, yeah, we've eliminated the amba_request_regions() that used to be
> why the probe had to be under the #ifdef, so your solution would get us
> better coverage and simpler code. If you could send that patch to
> dri-devel today, I'll get
On Wed, May 24, 2017 at 03:37:36PM +0300, Baruch Siach wrote:
> Hi Daniel,
>
> On Wed, May 24, 2017 at 02:23:22PM +0200, Daniel Vetter wrote:
> > On Tue, May 23, 2017 at 09:47:56AM -0500, Rob Herring wrote:
> > > On Tue, May 16, 2017 at 11:19:04AM +0300, Baruch Siach wrote:
> > > > Fixes: 14da3ed8
On 05/24/2017 04:52 PM, Daniel Vetter wrote:
> Again seems just cargo-culted.
>
> Cc: Neil Armstrong
> Signed-off-by: Daniel Vetter
> ---
> drivers/gpu/drm/meson/meson_drv.c | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/drivers/gpu/drm/meson/meson_drv.c
> b/drivers/gpu/drm/meson/mes
On Wed, 24 May 2017 16:51:52 +0200
Daniel Vetter wrote:
> Again almost correct, but since interrupts are shut down after vblank
> still a race. Proper cleanup would call drm_atomic_helper_shutdown to
> make sure this really is safe.
>
> v2: Remove misplace malidp hunk (Liviu).
>
> Cc: Boris Bre
On Wed, May 24, 2017 at 04:51:35PM +0200, Daniel Vetter wrote:
> Hi all,
>
> So the first part of this patch series is the usual deal of decrufting some
> part
> of drm and attempting to improve the docs. Mostly around vblank. I seem to be
> the ever constant 5% of finally being able to document
-BEGIN PGP SIGNED MESSAGE-
Hash: SHA1
Adam Jackson (3):
Export drmDevicesEqual
configure: Fix the check
Fix stray caller of drmCompareDevices
Edward O'Callaghan (2):
amdgpu/: concisely && consistently check null ptrs in canonical form
amdgpu: Use the canoni
https://bugs.freedesktop.org/show_bug.cgi?id=96868
--- Comment #27 from Jonas ---
(In reply to Alex Deucher from comment #26)
> Created attachment 131453 [details] [review]
> possible fix 4/4
This time the issue seems to be completely fixed, at least for me. Even @144Hz
the screen works perfectl
https://bugs.freedesktop.org/show_bug.cgi?id=99349
--- Comment #4 from Gert Wollny ---
The same problem also seems to be discussed in these mails
http://mesa-dev.freedesktop.narkive.com/cHAXj1eT/bug-50338-radeon-tgsi-takes-more-than-two-cfiles-from-r600-shader
It is very likely that this is ac
There's no reason for drivers to call this, and all the ones I've
removed looked very fishy:
- Proper quiescenting of the vblank machinery should be done by
calling drm_crtc_vblank_off(), which is best done by shutting down
the entire display engine with drm_atomic_helper_shutdown.
- Releasing
On Wed, 24 May 2017 16:51:48 +0200
Daniel Vetter wrote:
> The kernel doc explained what needs to happen, but not how to most
> easily accomplish that using the functions. Fix that.
>
> Cc: Boris Brezillon
> Signed-off-by: Daniel Vetter
Reviewed-by: Boris Brezillon
> ---
> include/drm/drm_c
It again looks all cargo-culted for no good reasons.
Cc: Shawn Guo
Signed-off-by: Daniel Vetter
---
drivers/gpu/drm/zte/zx_drm_drv.c | 2 --
1 file changed, 2 deletions(-)
diff --git a/drivers/gpu/drm/zte/zx_drm_drv.c b/drivers/gpu/drm/zte/zx_drm_drv.c
index 490aafc99610..696836303229 100644
-
On the load error path we can't have pending vblank interrupts, and on
unload we already call drm_atomic_helper_shutdown beforehand! So all
good to nuke it.
Signed-off-by: Daniel Vetter
---
drivers/gpu/drm/i915/i915_drv.c | 6 +-
1 file changed, 1 insertion(+), 5 deletions(-)
diff --git a/d
Again seems just cargo-culted ... It's not ordered against any
irq/vblank/modeset shutdown.
Cc: Maxime Ripard
Signed-off-by: Daniel Vetter
---
drivers/gpu/drm/sun4i/sun4i_drv.c | 2 --
1 file changed, 2 deletions(-)
diff --git a/drivers/gpu/drm/sun4i/sun4i_drv.c
b/drivers/gpu/drm/sun4i/sun4i
Seems entirely cargo-culted.
Cc: Benjamin Gaignard
Cc: Vincent Abriou
Signed-off-by: Daniel Vetter
---
drivers/gpu/drm/sti/sti_drv.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/drivers/gpu/drm/sti/sti_drv.c b/drivers/gpu/drm/sti/sti_drv.c
index a4b574283269..06ef1e3886cf 100644
--- a/dr
Again seems just cargo-culted.
Cc: Yannick Fertre
Cc: Philippe Cornu
Signed-off-by: Daniel Vetter
---
drivers/gpu/drm/stm/ltdc.c | 2 --
1 file changed, 2 deletions(-)
diff --git a/drivers/gpu/drm/stm/ltdc.c b/drivers/gpu/drm/stm/ltdc.c
index 700cc0800e51..1b9483d4f2a4 100644
--- a/drivers/gp
Almost right but still racy, it's called before the interrupts are
uninstalled. So let's just drop it.
Cc: Marek Vasut
Signed-off-by: Daniel Vetter
---
drivers/gpu/drm/mxsfb/mxsfb_drv.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/drivers/gpu/drm/mxsfb/mxsfb_drv.c
b/drivers/gpu/drm/mxsfb
Only in the load failure path, where the hardware is quiet anyway.
Cc: Inki Dae
Cc: Joonyoung Shim
Cc: Seung-Woo Kim
Cc: Kyungmin Park
Signed-off-by: Daniel Vetter
---
drivers/gpu/drm/exynos/exynos_drm_drv.c | 4 +---
1 file changed, 1 insertion(+), 3 deletions(-)
diff --git a/drivers/gpu/d
The kernel doc explained what needs to happen, but not how to most
easily accomplish that using the functions. Fix that.
Cc: Boris Brezillon
Signed-off-by: Daniel Vetter
---
include/drm/drm_crtc.h | 4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)
diff --git a/include/drm/drm_crtc.h b/in
I spotted a markup issue, plus adding the descriptions in drm_driver.
Plus a few more links while at it.
I'm still mildly unhappy with the split between fops and ioctls, but I
still think having the ioctls in the uapi chapter makes more sense. Oh
well ...
v2: Rebase.
Signed-off-by: Daniel Vetter
Both drivers shut down all crtc beforehand already, which will shut up
any pending vblank (the only thing vblank_cleanup really does is
disable the disable timer). Hence we don't need this here and can
remove it.
Cc: Alex Deucher
Cc: Christian König
Signed-off-by: Daniel Vetter
---
drivers/gpu
Unify and review everything, plus make sure it's all correct markup.
Drop the kernel-doc for internal functions. Also rework the overview
section, it's become rather outdated.
Unfortuantely the kernel-doc in drm_driver isn't rendered yet, but
that will change as soon as drm_driver is kernel-docifi
Again stopping the vblank before uninstalling the irq handler is kinda
the wrong way round, but the fb_off stuff should take care of
disabling the dsiplay at least in most cases. So drop the
drm_vblank_cleanup code since it's not really doing anything, it looks
all cargo-culted.
v2: Appease gcc be
It doesn't do anything in the driver load error paths that the drm
core doesn't also do.
Cc: Laurent Pinchart
Signed-off-by: Daniel Vetter
---
drivers/gpu/drm/shmobile/shmob_drm_drv.c | 4 +---
1 file changed, 1 insertion(+), 3 deletions(-)
diff --git a/drivers/gpu/drm/shmobile/shmob_drm_drv.c
Again seems just cargo-culted.
Cc: Neil Armstrong
Signed-off-by: Daniel Vetter
---
drivers/gpu/drm/meson/meson_drv.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/drivers/gpu/drm/meson/meson_drv.c
b/drivers/gpu/drm/meson/meson_drv.c
index 75382f5f0fce..2c605a406ad5 100644
--- a/drivers/gp
nouveau_display_vblank_fini is called in the load error path (where it
doesn't matter) and module unload (where vblanks have been shut down
correctly already through drm_vblank_off), we can drop it.
Cc: Ben Skeggs
Cc: nouv...@lists.freedesktop.org
Signed-off-by: Daniel Vetter
---
drivers/gpu/dr
Again, doesn't seem to serve a purpose.
Cc: Thierry Reding
Signed-off-by: Daniel Vetter
---
drivers/gpu/drm/tegra/drm.c | 5 +
1 file changed, 1 insertion(+), 4 deletions(-)
diff --git a/drivers/gpu/drm/tegra/drm.c b/drivers/gpu/drm/tegra/drm.c
index 51c48a8e00ec..0d8839244c3a 100644
--- a
I alwasy get confused about drm_wait_vblank for a split second until I
realize it's the ioctl handler. Unconfuse me, and do it for the legacy
modeset vblank control ioctl too.
While at it also noticed that I misplaced the irq ioctl handler in the
internal header file.
Signed-off-by: Daniel Vetter
udl doesn't shut down the display, so stopping the vblank isn't going
to do much good either. Just drop it.
Cc: Dave Airlie
Signed-off-by: Daniel Vetter
---
drivers/gpu/drm/udl/udl_main.c | 2 --
1 file changed, 2 deletions(-)
diff --git a/drivers/gpu/drm/udl/udl_main.c b/drivers/gpu/drm/udl/u
Seems entirely cargo-culted.
Cc: CK Hu
Cc: Philipp Zabel
Signed-off-by: Daniel Vetter
---
drivers/gpu/drm/mediatek/mtk_drm_drv.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/drivers/gpu/drm/mediatek/mtk_drm_drv.c
b/drivers/gpu/drm/mediatek/mtk_drm_drv.c
index f6c8ec4c7dbc..56f802d0a51c
Again we probably want a drm_atomic_helper_shutdown somewhere, but
that's a bit more analysis.
Cc: Xinliang Liu
Cc: Rongrong Zou
Cc: Xinwei Kong
Cc: Chen Feng
Signed-off-by: Daniel Vetter
---
drivers/gpu/drm/hisilicon/kirin/kirin_drm_drv.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/d
Again cleanup before irq disabling doesn't really stop the races,
so just drop it. Proper fix would be to put drm_atomic_helper_shutdown
before everything gets cleaned up.
Cc: Stefan Agner
Signed-off-by: Daniel Vetter
---
drivers/gpu/drm/fsl-dcu/fsl_dcu_drm_drv.c | 2 --
1 file changed, 2 delet
Either not relevant (in the load error paths) or done better already
(in the unload code, by calling drm_atomic_helper_shutdown). Drop it.
Cc: Mark Yao
Signed-off-by: Daniel Vetter
---
drivers/gpu/drm/rockchip/rockchip_drm_drv.c | 2 --
1 file changed, 2 deletions(-)
diff --git a/drivers/gpu/d
It's only done in the driver load error path, where vblanks don't need
to be quiescent anyway. And that's all drm_vblank_cleanup does, since
the core will release the vblank allocations on its own already. So
drop it.
Cc: Philipp Zabel
Signed-off-by: Daniel Vetter
---
drivers/gpu/drm/imx/imx-dr
I'm fed up staring at the error message from kernel-doc that
it can't find anything.
Signed-off-by: Daniel Vetter
---
Documentation/gpu/drm-kms.rst | 3 ---
1 file changed, 3 deletions(-)
diff --git a/Documentation/gpu/drm-kms.rst b/Documentation/gpu/drm-kms.rst
index 2d77c9580164..0749000ab3d7
So this seems to be the first driver that does it the right way round,
so fix it up by calling drm_atomic_helper_shutdown instead. We need to
do that before the last kms user is gone (fbdev emulation), but before
we start shutting down hw stuff like interrupts.
Cc: Xinliang Liu
Cc: Rongrong Zou
Again almost correct, but since interrupts are shut down after vblank
still a race. Proper cleanup would call drm_atomic_helper_shutdown to
make sure this really is safe.
v2: Remove misplace malidp hunk (Liviu).
Cc: Boris Brezillon
Signed-off-by: Daniel Vetter
---
drivers/gpu/drm/atmel-hlcdc/a
IRQs are properly shut down, so it almost works as race-free shutdown.
Except the irq is stopped after the vblank stuff, so boom anyway.
Proper way would be to call drm_atomic_helper_shutdown before any of
the kms things gets stopped. So no harm in removing the
drm_vblank_cleanup here really.
Same
We use drm_crtc_ for all the new-style vblank functions which directly
take a struct drm_crtc *. drm_accurate_vblank_count was the odd one
out, correct this to appease my OCD.
Signed-off-by: Daniel Vetter
---
drivers/gpu/drm/drm_vblank.c | 8
drivers/gpu/drm/i915/i915_irq.c
CRTC don't seem to get shut down in a controlled fashion, but no one
bothers to stop interrupts either so this races no matter what. Might
as well remove it. A call to drm_atomic_helper_shutdown would be
pretty sweet somewhere (and maybe getting rid of the load/unload
callbacks while at it).
Cc: A
Pull a (much shorter) overview into drm_irq.c, and instead put the
callback documentation into in-line comments in drm_drv.h.
Signed-off-by: Daniel Vetter
---
Documentation/gpu/drm-internals.rst | 62 +
drivers/gpu/drm/drm_irq.c | 30 +++-
The only special-case is pci devices, and we can easily handle this in
the core. Do so and drop a pile of boilerplate from drivers.
Signed-off-by: Daniel Vetter
---
drivers/gpu/drm/amd/amdgpu/amdgpu_drv.c | 1 -
drivers/gpu/drm/ast/ast_drv.c | 1 -
drivers/gpu/drm/bochs/bochs_drv.c
This is a leftover from the drm_bus days, where we've had a
bus-specific device type for every bus type in drm_device. Except for
pci (which we can't remove because dri1 drivers) this is all gone. And
the virt driver also doesn't really need it, dev_to_virtio works
perfectly fine.
Cc: David Airlie
Since
commit ca8e2ad71013049bc88a10b11d83712bfe56cdd4
Author: Thierry Reding
Date: Fri Apr 11 15:23:00 2014 +0200
drm: Introduce drm_dev_set_unique()
the ->set_busid callback is optional. On top of that the udl one isn't
really fully compliant with the drm uabi, but since only modesetting
And document them lightly. Unfortunately kernel-doc isn't the most
awesome for documenting #defines that don't look like functions, it
makes functions out of them :-/
Signed-off-by: Daniel Vetter
---
include/drm/drmP.h | 17 -
include/drm/drm_modes.h | 17 +
The magic switching between proper pci driver and shadow-attach isn't
useful anymore since there's no ums+kms drivers left. Let's split this
up properly, calling pci_register_driver for kms drivers and renaming
the shadow-attach init to drm_legacy_pci_init/exit.
Signed-off-by: Daniel Vetter
---
Hi all,
So the first part of this patch series is the usual deal of decrufting some part
of drm and attempting to improve the docs. Mostly around vblank. I seem to be
the ever constant 5% of finally being able to document drm_driver/device
properly, oh well.
By patch count the bigger part is tryi
On Fri, May 5, 2017 at 4:29 AM, Ville Syrjälä
wrote:
> On Thu, May 04, 2017 at 02:52:09PM -0600, Daniel Drake wrote:
>> On Thu, May 4, 2017 at 2:37 PM, Ville Syrjälä
>> wrote:
>> > Please check if commit bb1d132935c2 ("drm/i915/vbt: split out defaults
>> > that are set when there is no VBT") fixe
> -Original Message-
> From: Daniel Vetter [mailto:daniel.vet...@ffwll.ch]
> Sent: Wednesday, May 24, 2017 5:28 AM
> To: DRI Development
> Cc: Intel Graphics Development; Daniel Vetter; Patrik Jakobsson; Lukas
> Wunner; Deucher, Alexander; Christian König; Sean Paul; Daniel Vetter
> Subject
https://bugs.freedesktop.org/show_bug.cgi?id=99349
--- Comment #3 from Gert Wollny ---
I've had the same error output when I was playing with the Unreal Editor with
an HD6850 (BARTS) using the latest mesa-git.
In order to track it down I added some debugging to mesa and could get the
followi
https://bugzilla.kernel.org/show_bug.cgi?id=194761
--- Comment #19 from Berg (b...@uralmail.com) ---
I confirm:
Checkerboard effect when using amdgpu on Oland is back.
On amdgpu-pro the same effect has been for a long time (despite the fact that
my R7 240 is in the list of supported devices), but
Hi Tomi,
Thank you for the patch.
On Thursday 04 May 2017 13:23:20 Tomi Valkeinen wrote:
> Use dev_err_ratelimited() when an OCP error happens, to slightly easen
> the flood.
>
> Signed-off-by: Tomi Valkeinen
Reviewed-by: Laurent Pinchart
> ---
> drivers/gpu/drm/omapdrm/omap_irq.c | 7 -
1 - 100 of 153 matches
Mail list logo
