On Fri, 2017-02-17 at 16:32 +1100, Benjamin Herrenschmidt wrote:
Make this
From: Russell Currey
Git ate it when I amended (citool bug) and I forgot to fix it up.
> The ast driver configures a window to enable access into BMC
> memory space in order to read some configuration registers.
>
> If
To enable eventual removal of pr_warning
This makes pr_warn use consistent for drivers/gpu
Prior to this patch, there were 15 uses of pr_warning and
20 uses of pr_warn in drivers/gpu
Signed-off-by: Joe Perches
---
drivers/gpu/drm/amd/powerplay/hwmgr/smu7_hwmgr.c | 2 +-
drivers/gpu/drm/am
The function does more than initializing the DRAM and in turns
calls other functions to do the actual init. This will keeping
things more consistent with the upcoming AST2500 POST code.
Signed-off-by: Benjamin Herrenschmidt
---
drivers/gpu/drm/ast/ast_post.c | 6 +++---
1 file changed, 3 inserti
From: "Y.C. Chen"
The default value of VGA scratch may incorrect.
Should initial h/w before get vram info.
Signed-off-by: Y.C. Chen
---
drivers/gpu/drm/ast/ast_main.c | 6 +++---
drivers/gpu/drm/ast/ast_post.c | 2 +-
2 files changed, 4 insertions(+), 4 deletions(-)
diff --git a/drivers/gpu/d
There's a lot of duplication for what's essentially N copies of
the same loop, so factor it. The upcoming AST2500 POST code adds
more of this.
Signed-off-by: Benjamin Herrenschmidt
---
drivers/gpu/drm/ast/ast_post.c | 76 --
1 file changed, 22 insertions(+
From: "Y.C. Chen"
Add detection and mode setting updates for AST2500 generation chip,
code originally from Aspeed and slightly reworked for coding style
mostly by Ben. This doesn't contain the BMC DRAM POST code which
is in a separate patch.
Signed-off-by: Y.C. Chen
Signed-off-by: Benjamin Herr
And fix some comment alignment & space/tabs while at it
Signed-off-by: Benjamin Herrenschmidt
---
drivers/gpu/drm/ast/ast_drv.h| 4 +-
drivers/gpu/drm/ast/ast_mode.c | 8 +--
drivers/gpu/drm/ast/ast_tables.h | 106 +++
3 files changed, 59 insertions(
The ast driver configures a window to enable access into BMC
memory space in order to read some configuration registers.
If this window is disabled, which it can be from the BMC side,
the ast driver can't function.
Closing this window is a necessity for security if a machine's
host side and BMC s
From: "Y.C. Chen"
This is used when the BMC isn't running any code and thus has
to be initialized by the host.
The code originates from Aspeed (Y.C. Chen) and has been cleaned
up for coding style purposes by BenH.
Signed-off-by: Y.C. Chen
Signed-off-by: Benjamin Herrenschmidt
---
drivers/gpu
Some braces were missing causing an incorrect calculation.
Y.C. Chen from Aspeed provided me with the right formula
which I tested on AST2400 and 2500.
The MCLK isn't currently used by the driver (it will eventually
to filter modes) so the issue isn't catastrophic.
Also make the printed value a
Signed-off-by: Benjamin Herrenschmidt
---
drivers/gpu/drm/ast/ast_main.c | 2 --
1 file changed, 2 deletions(-)
diff --git a/drivers/gpu/drm/ast/ast_main.c b/drivers/gpu/drm/ast/ast_main.c
index 823c68f..b593a53 100644
--- a/drivers/gpu/drm/ast/ast_main.c
+++ b/drivers/gpu/drm/ast/ast_main.c
@@
https://bugs.freedesktop.org/show_bug.cgi?id=99484
--- Comment #7 from Timothy Arceri ---
Bisected the llvm regression to a change in llvm 4.0
commit f991e38d156c4c10c609ca8425a7c31b951ecbed
Author: James Molloy
Date: Thu Sep 1 10:44:35 2016 +
[SimplifyCFG] Change the algorithm
On 2017年02月16日 20:08, Christian König wrote:
Am 16.02.2017 um 12:39 schrieb Nicolai Hähnle:
From: Nicolai Hähnle
By using ttm_bo_init_reserved instead of the manual initialization of
the reservation object, the reservation lock will be properly unlocked
and destroyed when the TTM BO initiali
Hi Linus,
Just two last minute fixes, one for DP MST oopses and one for a radeon
regression.
Dave.
The following changes since commit 7089db84e356562f8ba737c29e472cc42d530dbc:
Linux 4.10-rc8 (2017-02-12 13:03:20 -0800)
are available in the git repository at:
git://people.freedesktop.org/~
On 16 February 2017 at 08:16, Marek Vasut wrote:
> Hi,
>
> I collected the MXSFB fixes, based on top of airlied/drm-fixes:
At this stage I'd rather not give these to Linus, can you rebase them onto
drm-next, and resend, feel free to add stable cc's.
Fixes like this should really be getting to me
On 16 February 2017 at 19:49, Jani Nikula wrote:
>
> Hi Dave, this one superseeds [1]. Better to flush out the single uapi
> fix for v4.11 now so it's not forgotten.
Looks like I had already pulled, I just reverted Maarten's patch on
top of drm-next.
Dave.
___
https://bugs.freedesktop.org/show_bug.cgi?id=99136
Michel Dänzer changed:
What|Removed |Added
Attachment #129669|0 |1
is obsolete|
On 02/16/2017 03:40 AM, Philipp Zabel wrote:
This function will be used by the media drivers and needs to be exported
to allow them to be built as modules.
Reported-by: Russell King
Fixes: 867341b95891 ("gpu: ipu-v3: add ipu_csi_set_downsize")
Signed-off-by: Philipp Zabel
---
drivers/gpu/i
On 02/16/2017 07:42 AM, Philipp Zabel wrote:
Setting dev->of_node changes the modalias and breaks module autoloading.
Since there is an of_node field in the platform data passed to child
devices, we don't even need this anymore.
Suggested-by: Russell King
Signed-off-by: Philipp Zabel
---
dr
On Thu, 2017-02-16 at 06:34 +, YC Chen wrote:
> Hi Ben,
> This solution had been proved on x86 platform but I'm not sure if it
> works or not on POWER system .
It will only work on x86 platforms that haven't configured their
PCI Express in "hardened" mode where PCIe errors cause machine checks
Daniel Vetter schreef op di 14-02-2017 om 20:51 [+0100]:
> On Mon, Feb 13, 2017 at 10:26 PM, Pandiyan, Dhinakaran
> wrote:
> > On Mon, 2017-02-13 at 09:05 +, Lankhorst, Maarten wrote:
> > > Pandiyan, Dhinakaran schreef op do 09-02-2017 om 18:55 [+]:
> > > > On Thu, 2017-02-09 at 09:01 +000
On Thu, 2017-02-16 at 14:24 +1000, Dave Airlie wrote:
> On 11 January 2017 at 12:57, Y.C. Chen
> wrote:
> > From: "Y.C. Chen"
>
> Please run checkpatch over this patch, it's got a lot of bad
> whitespace issues
> (4 space and 2 space indents, indent the timing tables , remove start
> of line whi
On Thu, 2017-01-26 at 09:45 +0800, Y.C. Chen wrote:
> From: "Y.C. Chen"
>
> The original ast driver will access some BMC configuration through
> P2A bridge
> that can be disabled since AST2300 and after.
> It will cause system hanged if P2A bridge is disabled.
> Here is the update to fix it.
Wil
On Wed, 2017-01-11 at 10:57 +0800, Y.C. Chen wrote:
> From: "Y.C. Chen"
>
> Signed-off-by: Y.C. Chen
> ---
> drivers/gpu/drm/ast/ast_drv.h| 2 +
> drivers/gpu/drm/ast/ast_main.c | 27 ++-
> drivers/gpu/drm/ast/ast_mode.c | 25 +-
> drivers/gpu/drm/ast/ast_post.c | 510
> ++
Display stream compression is supported on DP 1.4 DP
devices. This patch adds the corersponding DPCD
register definitions for DSC.
v2:
* Rebased on drm-tip
Signed-off-by: Manasi Navare
Cc: Jani Nikula
Cc: Paulo Zanoni
Cc: dri-devel@lists.freedesktop.org
---
include/drm/drm_dp_helper.h | 102 +
https://bugzilla.kernel.org/show_bug.cgi?id=194533
nuc...@hotmail.com changed:
What|Removed |Added
Status|NEW |RESOLVED
Resolution|---
https://bugzilla.kernel.org/show_bug.cgi?id=194579
Nicolai Hähnle (nhaeh...@gmail.com) changed:
What|Removed |Added
CC||nhaeh...@gmail.com
https://bugs.freedesktop.org/show_bug.cgi?id=99843
--- Comment #3 from Ilia Mirkin ---
https://github.com/apitrace/apitrace
This can be used to record (and replay) all the GL commands sent down to the
driver.
--
You are receiving this mail because:
You are the assignee for the bug.
https://bugs.freedesktop.org/show_bug.cgi?id=99843
--- Comment #2 from d...@jerber.co.uk ---
I've just tried with multiple draw calls using the same VBO and it appears this
does also cause the error. However, it appears there has to be 3 or more calls
to cause the error (1 and 2 calls produce the
On Thu, 2017-02-16 at 17:33 +, Emil Velikov wrote:
> > +static bool ast_dram_init_2500(struct ast_private *ast)
> > +{
> > + u32 data;
> > + u32 max_tries = 5;
> > +
> > + do {
> > + if (max_tries-- == 0)
> > + return false;
> > +
On Thu, 2017-02-16 at 17:33 +, Emil Velikov wrote:
> "Water is wet" type of comment. Worth mentioning why it's so large -
> mentioned in the documentation, experimental result, other ?
> Same suggestion goes for the other mdelay(100) instances.
Ah I removed most of those useless comments, I mu
On Thu, 2017-02-16 at 17:33 +, Emil Velikov wrote:
> I realise that there's likely no documentation, yet repeating the
> same
> magic numbers multiple times is a bit meh.
This is all Aspeed original code. I merely fixed the coding style ;-)
The other POST functions for the other chip gens are
https://bugs.freedesktop.org/show_bug.cgi?id=99843
--- Comment #1 from Nicolai Hähnle ---
Interesting, thanks for the report.
Is this really an issue of having separate VBOs, or does the issue also occur
when you use separate draw calls with a single VBO? Or a single draw call?
Do you have a si
On Thu, 2017-02-16 at 17:33 +, Emil Velikov wrote:
> The above seems like a _lot_ of unrelated rework. Keep the
> refactoring
> separate ?
> New code seems to assume that only(?) -1 is returned on error, yet we
> do < 0.
> This will come to bite you/others as the tests are extended/reworked.
N
On Thu, 2017-02-16 at 17:33 +, Emil Velikov wrote:
> On 16 February 2017 at 09:09, Benjamin Herrenschmidt
> wrote:
> > From: "Y.C. Chen"
> >
> > Add detection and POST code for AST2500 generation chip,
> > code originally from Aspeed and slightly reworked for
> > coding style mostly by Ben.
https://bugs.freedesktop.org/show_bug.cgi?id=97879
--- Comment #92 from libgra...@gmail.com ---
Working great here now guys - latest RL build and Mesa git.
Thanks to all involved - great cooperation :)
--
You are receiving this mail because:
You are the assignee for the bug.
You are on the CC l
https://bugs.freedesktop.org/show_bug.cgi?id=99843
Bug ID: 99843
Summary: Geometry Shader - Incorrect Output
Product: Mesa
Version: unspecified
Hardware: x86-64 (AMD64)
OS: Linux (All)
Status: NEW
Severity
On Thu, Feb 16, 2017 at 08:59:13PM +0200, Jani Nikula wrote:
> On Thu, 16 Feb 2017, Ville Syrjälä wrote:
> > On Thu, Feb 16, 2017 at 07:54:00PM +0200, Jani Nikula wrote:
> >> On Thu, 16 Feb 2017, Ville Syrjälä wrote:
> >> > On Thu, Feb 16, 2017 at 12:36:45PM +0200, Jani Nikula wrote:
> >> >> Hand
On Thu, 16 Feb 2017, Ville Syrjälä wrote:
> On Fri, Feb 10, 2017 at 11:28:02AM +0100, Hans de Goede wrote:
>> Listen for PMIC bus access notifications and get FORCEWAKE_ALL while
>> the bus is accessed to avoid needing to do any forcewakes, which need
>> PMIC bus access, while the PMIC bus is busy
On Thu, 16 Feb 2017, Ville Syrjälä wrote:
> On Thu, Feb 16, 2017 at 07:54:00PM +0200, Jani Nikula wrote:
>> On Thu, 16 Feb 2017, Ville Syrjälä wrote:
>> > On Thu, Feb 16, 2017 at 12:36:45PM +0200, Jani Nikula wrote:
>> >> Handle debugfs override edid and firmware edid at the low level to
>> >> tr
https://bugs.freedesktop.org/show_bug.cgi?id=99780
--- Comment #12 from Matias N. Goldberg ---
I can confirm applying the patch you uploaded (plus LLVM's patch of course)
fixes the problem.
Thank you.
--
You are receiving this mail because:
You are the assignee for the bug.
On Fri, Feb 10, 2017 at 11:28:02AM +0100, Hans de Goede wrote:
> Listen for PMIC bus access notifications and get FORCEWAKE_ALL while
> the bus is accessed to avoid needing to do any forcewakes, which need
> PMIC bus access, while the PMIC bus is busy:
>
> This fixes errors like these showing up i
On Thu, Feb 16, 2017 at 07:54:00PM +0200, Jani Nikula wrote:
> On Thu, 16 Feb 2017, Ville Syrjälä wrote:
> > On Thu, Feb 16, 2017 at 12:36:45PM +0200, Jani Nikula wrote:
> >> Handle debugfs override edid and firmware edid at the low level to
> >> transparently and completely replace the real edid.
On Thu, 16 Feb 2017, Ville Syrjälä wrote:
> On Thu, Feb 16, 2017 at 12:36:45PM +0200, Jani Nikula wrote:
>> Handle debugfs override edid and firmware edid at the low level to
>> transparently and completely replace the real edid. Previously, we
>> practically only used the modes from the override
Hi Dave,
Fixes for 4.11. Highlights:
- fix >2 displays on asics with 3 or 5 crtcs
- fix SI headless asics
- powerplay fixes for new polaris variants
- misc fixes
The following changes since commit 13f62f54d174d3417c3caaafedf5e22a0a03e442:
Merge branch 'drm-next-4.11' of git://people.freedeskto
On 16 February 2017 at 09:09, Benjamin Herrenschmidt
wrote:
> From: "Y.C. Chen"
>
> Add detection and POST code for AST2500 generation chip,
> code originally from Aspeed and slightly reworked for
> coding style mostly by Ben.
>
> Signed-off-by: Y.C. Chen
> Signed-off-by: Benjamin Herrenschmidt
On Fri, Feb 3, 2017 at 11:47 AM, Arnd Bergmann wrote:
> gcc-4.8 warns about '{0}' being used an an initializer for nested structures:
>
> drivers/gpu/drm/amd/amdgpu/gfx_v8_0.c: In function
> ‘gfx_v8_0_ring_emit_ce_meta_init’:
> drivers/gpu/drm/amd/amdgpu/gfx_v8_0.c:7263:2: warning: missing braces
On Thu, Feb 16, 2017 at 11:01:29AM +0100, Hans de Goede wrote:
> Hi,
>
> On 15-02-17 15:59, Ville Syrjälä wrote:
> > On Wed, Feb 15, 2017 at 03:54:17PM +0100, Hans de Goede wrote:
> >> Hi Jani,
> >>
> >> As discussed here:
> >>
> >> https://bugs.freedesktop.org/show_bug.cgi?id=94894
> >>
> >> I've
On 16 February 2017 at 12:43, Tobias Jakobi
wrote:
> Hello,
>
> I was wondering about the following. Wasn't there some strict
> requirement about code going upstream, which also included that there
> was a full open-source driver stack for it?
>
> I don't see how this is the case for Mali, neither
Despite the documentation claim that cleanup_fb will match prior calls
to prepare_fb, in case of NULL framebuffers in the transitional helpers,
the code will skip the call to prepare_fb but not the corresponding
cleanup_fb call. This asymmetry in semantics is unnecessarily surprising
for developer
On 02/15/2017 05:19 PM, Maxime Ripard wrote:
> Hi,
>
> This is a respin of the previous serie called "Support fast framebuffer
> panning for i.MX6" made by Stefan 6 monthes ago. The imx6 bits have been
> removed, and the comments that were made at that time fixed (hopefully).
>
> Let me know what
Hi Dave,
Just one regression fix interlaced modes on radeon.
The following changes since commit 697d3a21615672b2bf7724a65755799260325dda:
Merge tag 'drm-intel-fixes-2017-02-09' of
git://anongit.freedesktop.org/git/drm-intel into drm-fixes (2017-02-10 10:14:24
+1000)
are available in the git
https://bugs.freedesktop.org/show_bug.cgi?id=99780
--- Comment #11 from Nicolai Hähnle ---
Created attachment 129675
--> https://bugs.freedesktop.org/attachment.cgi?id=129675&action=edit
Mesa patch
Yes, you need this patch for Mesa as well.
I'm going to pick up the LLVM patch again as well th
Setting dev->of_node changes the modalias and breaks module autoloading.
Since there is an of_node field in the platform data passed to child
devices, we don't even need this anymore.
Suggested-by: Russell King
Signed-off-by: Philipp Zabel
---
drivers/gpu/ipu-v3/ipu-common.c | 6 --
1 file
On Thu, Feb 16, 2017 at 12:36:45PM +0200, Jani Nikula wrote:
> Handle debugfs override edid and firmware edid at the low level to
> transparently and completely replace the real edid. Previously, we
> practically only used the modes from the override EDID, and none of the
> other data. This also pr
On Mi, 2017-02-15 at 16:00 -0200, Gustavo Padovan wrote:
> From: Gustavo Padovan
>
> virtio was missing this call to clean up core plane usage.
>
> Signed-off-by: Gustavo Padovan
> ---
> drivers/gpu/drm/virtio/virtgpu_plane.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/gp
On Thu, Feb 16, 2017 at 12:36:43PM +0200, Jani Nikula wrote:
> Make the function useful for resetting, not just setting, the ELD.
>
> Signed-off-by: Jani Nikula
> ---
> drivers/gpu/drm/drm_edid.c | 3 +++
> 1 file changed, 3 insertions(+)
>
> diff --git a/drivers/gpu/drm/drm_edid.c b/drivers/gp
There are new iterator macros that annotate whether the new or old
state should be used. This is better than using a state that depends on
whether it's called before or after swap. For clarity, also rename the
variables from $obj_state to (old,new)_$obj_state as well.
Signed-off-by: Maarten Lankho
Fifth iteration. Instead of trying to convert all drivers straight away,
implement all macros that are required to get state working.
Old situation:
Use obj->state, which can refer to old or new state.
Use drm_atomic_get_(existing_)obj_state, which can refer to new or old state.
Use for_each_obj_i
After atomic commit, these macros should be used in place of
get_existing_state. Also after commit get_xx_state should no longer
be used because it may not have the required locks.
The calls to drm_atomic_get_existing_$obj_state should no longer be
used, and converted over to these new calls.
Cha
There are new iterator macros that annotate whether the new or old
state should be used. This is better than using a state that depends on
whether it's called before or after swap. For clarity, also rename the
variables from $obj_state to (old,new)_$obj_state as well.
Changes since v1:
- Use old/n
This is a straightforward conversion that converts all the users of
get_existing_state in atomic core to use get_old_state or get_new_state
Changes since v1:
- Fix using the wrong state in drm_atomic_helper_update_legacy_modeset_state.
Changes since v2:
- Use the correct state in disable_outputs()
This function becomes a lot simpler when having passed both the old and
new state to it. Looking at all callers, it seems that old_plane_state
is never NULL so the check can be dropped.
Signed-off-by: Maarten Lankhorst
---
drivers/gpu/drm/drm_atomic_helper.c | 7 ---
drivers/gpu/drm/drm_pla
Op 17-01-17 om 02:12 schreef Laurent Pinchart:
> Hi Maarten,
>
> Thank you for the patch.
>
> I don't think you need the "v2" at the end of the subject line.
>
> On Monday 16 Jan 2017 10:37:43 Maarten Lankhorst wrote:
>> This is a straightforward conversion that converts all the users of
>> get_exi
Op 17-01-17 om 02:27 schreef Laurent Pinchart:
> Hi Maarten,
>
> One more thing.
>
> On Monday 16 Jan 2017 10:37:43 Maarten Lankhorst wrote:
>> This is a straightforward conversion that converts all the users of
>> get_existing_state in atomic core to use get_old_state or get_new_state
>>
>> Change
On Thu, 16 Feb 2017 11:01:46 +0800, Chris Zhong wrote:
> On 02/01/2017 03:22 AM, Sean Paul wrote:
> > On Sun, Jan 29, 2017 at 01:24:42PM +, John Keeping wrote:
> >
> > Reviewed-by: Sean Paul
> >
> >> Signed-off-by: John Keeping
> >> Reviewed-by: Chris Zhong
> >> ---
> >> v3:
> >> - Add Ch
On Thu, 16 Feb 2017 10:12:33 +0800, Chris Zhong wrote:
> On 02/15/2017 08:39 PM, John Keeping wrote:
> > On Wed, 15 Feb 2017 11:38:45 +0800, Chris Zhong wrote:
> >
> >> On 01/29/2017 09:24 PM, John Keeping wrote:
> >>> In order to fully reset the state of the MIPI controller we must assert
> >
https://bugs.freedesktop.org/show_bug.cgi?id=99136
siyia changed:
What|Removed |Added
Version|13.0|17.0
--
You are receiving this mail because:
Yo
https://bugs.freedesktop.org/show_bug.cgi?id=99136
--- Comment #28 from siyia ---
Created attachment 129669
--> https://bugs.freedesktop.org/attachment.cgi?id=129669&action=edit
apitrace of TW warhammer
bug happens also with latest mesa stable independently of llvm version.
--
You are receiv
https://bugs.freedesktop.org/show_bug.cgi?id=99136
--- Comment #27 from siyia ---
(In reply to Samuel Pitoiset from comment #26)
> Can you upload the trace somewhere?
will try
--
You are receiving this mail because:
You are the assignee for the bug._
Hello,
I was wondering about the following. Wasn't there some strict
requirement about code going upstream, which also included that there
was a full open-source driver stack for it?
I don't see how this is the case for Mali, neither in the kernel, nor in
userspace. I'm aware that the Mali kernel
Hi Dave,
Please pull these omapdrm fixes for v4.11.
Tomi
The following changes since commit 13f62f54d174d3417c3caaafedf5e22a0a03e442:
Merge branch 'drm-next-4.11' of git://people.freedesktop.org/~agd5f/linux
into drm-next (2017-02-10 10:13:30 +1000)
are available in the git repository at:
Hello,
I'm not sure if I'm missing something here, but I don't see how this is
supposed to work.
This just multiplies the height of the drm_mode_fb_cmd2 object with the
number of buffers. Let's say I have width=1024, height=768, then now I
have a framebuffer which has height=2304 (in the num_buff
On Thu, 16 Feb 2017, Rob Clark wrote:
> On Thu, Feb 16, 2017 at 7:00 AM, Dan Carpenter
> wrote:
>> We're off by one here. We free something that wasn't allocated and we
>> don't free msm_host->bus_clks[].
>>
>> Fixes: 6e0eb52eba9e ("drm/msm/dsi: Parse bus clocks from a list")
>> Signed-off-by:
On Thu, 16 Feb 2017, walter harms wrote:
> Am 16.02.2017 12:53, schrieb Dan Carpenter:
>> On Thu, Feb 16, 2017 at 01:27:47PM +0200, Jani Nikula wrote:
>>> On Thu, 16 Feb 2017, Dan Carpenter wrote:
We want to free msm_host->bus_clks[0] so the > should be >=.
Fixes: 6e0eb52eba9e ("dr
On Thu, Feb 16, 2017 at 5:59 AM, Archit Taneja wrote:
> A recent commit introduces a bug in dsi_mgr_phy_enable. In the non
> dual DSI mode, we reset the mdsi (master DSI) PHY. This isn't right
> since master and slave DSI exist only in dual DSI mode. For the normal
> mode of operation, we should s
On Thu, Feb 16, 2017 at 7:03 AM, walter harms wrote:
>
>
> Am 16.02.2017 12:53, schrieb Dan Carpenter:
>> On Thu, Feb 16, 2017 at 01:27:47PM +0200, Jani Nikula wrote:
>>> On Thu, 16 Feb 2017, Dan Carpenter wrote:
We want to free msm_host->bus_clks[0] so the > should be >=.
Fixes: 6
On Thu, Feb 16, 2017 at 7:00 AM, Dan Carpenter wrote:
> We're off by one here. We free something that wasn't allocated and we
> don't free msm_host->bus_clks[].
>
> Fixes: 6e0eb52eba9e ("drm/msm/dsi: Parse bus clocks from a list")
> Signed-off-by: Dan Carpenter
Thanks
Reviewed-by: Rob Clark
On 08/02/17 16:08, Jyri Sarha wrote:
> Let's disable all scaling that requires horizontal decimation with
> higher factor than 4, until we have better estimates of what we can
> and can not do. However, NV12 color format appears to work Ok with
> all decimation factors.
>
> When decimating horizon
Am 16.02.2017 um 12:39 schrieb Nicolai Hähnle:
From: Nicolai Hähnle
By using ttm_bo_init_reserved instead of the manual initialization of
the reservation object, the reservation lock will be properly unlocked
and destroyed when the TTM BO initialization fails.
Actual deadlocks caused by the mi
Am 16.02.2017 12:53, schrieb Dan Carpenter:
> On Thu, Feb 16, 2017 at 01:27:47PM +0200, Jani Nikula wrote:
>> On Thu, 16 Feb 2017, Dan Carpenter wrote:
>>> We want to free msm_host->bus_clks[0] so the > should be >=.
>>>
>>> Fixes: 6e0eb52eba9e ("drm/msm/dsi: Parse bus clocks from a list")
>>> S
We're off by one here. We free something that wasn't allocated and we
don't free msm_host->bus_clks[].
Fixes: 6e0eb52eba9e ("drm/msm/dsi: Parse bus clocks from a list")
Signed-off-by: Dan Carpenter
diff --git a/drivers/gpu/drm/msm/dsi/dsi_host.c
b/drivers/gpu/drm/msm/dsi/dsi_host.c
index 1fc07
On Thu, Feb 16, 2017 at 01:27:47PM +0200, Jani Nikula wrote:
> On Thu, 16 Feb 2017, Dan Carpenter wrote:
> > We want to free msm_host->bus_clks[0] so the > should be >=.
> >
> > Fixes: 6e0eb52eba9e ("drm/msm/dsi: Parse bus clocks from a list")
> > Signed-off-by: Dan Carpenter
> >
> > diff --git a
On Thu, 2017-02-16 at 20:09 +1100, Benjamin Herrenschmidt wrote:
> From: "Y.C. Chen"
>
> Add detection and POST code for AST2500 generation chip,
> code originally from Aspeed and slightly reworked for
> coding style mostly by Ben.
I just noticed there's still a bunch of minor checkpatch warning
This function will be used by the media drivers and needs to be exported
to allow them to be built as modules.
Reported-by: Russell King
Fixes: 867341b95891 ("gpu: ipu-v3: add ipu_csi_set_downsize")
Signed-off-by: Philipp Zabel
---
drivers/gpu/ipu-v3/ipu-csi.c | 1 +
1 file changed, 1 insertion
From: Nicolai Hähnle
As the comment says: callers of ttm_bo_init cannot rely on having the
only reference to the BO when the function returns successfully.
Signed-off-by: Nicolai Hähnle
---
include/drm/ttm/ttm_bo_api.h | 6 +-
1 file changed, 5 insertions(+), 1 deletion(-)
diff --git a/in
From: Nicolai Hähnle
By using ttm_bo_init_reserved instead of the manual initialization of
the reservation object, the reservation lock will be properly unlocked
and destroyed when the TTM BO initialization fails.
Actual deadlocks caused by the missing unlock should have been fixed
by "drm/ttm:
From: Nicolai Hähnle
This variant of ttm_bo_init returns the validated buffer object with
the reservation lock held when resv == NULL. This is convenient for
callers that want to use the BO immediately, e.g. for initializing its
contents.
Signed-off-by: Nicolai Hähnle
---
drivers/gpu/drm/ttm/t
On Thu, 16 Feb 2017, Dan Carpenter wrote:
> We want to free msm_host->bus_clks[0] so the > should be >=.
>
> Fixes: 6e0eb52eba9e ("drm/msm/dsi: Parse bus clocks from a list")
> Signed-off-by: Dan Carpenter
>
> diff --git a/drivers/gpu/drm/msm/dsi/dsi_host.c
> b/drivers/gpu/drm/msm/dsi/dsi_host.c
Op 16-02-17 om 10:45 schreef Jani Nikula:
> On Wed, 15 Feb 2017, Sinclair Yeh wrote:
>> On Wed, Feb 15, 2017 at 03:56:09PM +0200, Jani Nikula wrote:
>>> On Wed, 25 Jan 2017, Maarten Lankhorst
>>> wrote:
This was somehow lost between v3 and the merged version in Maarten's
patch merged a
A recent commit introduces a bug in dsi_mgr_phy_enable. In the non
dual DSI mode, we reset the mdsi (master DSI) PHY. This isn't right
since master and slave DSI exist only in dual DSI mode. For the normal
mode of operation, we should simply reset the PHY of the DSI device
(i.e. msm_dsi) correspond
We want to free msm_host->bus_clks[0] so the > should be >=.
Fixes: 6e0eb52eba9e ("drm/msm/dsi: Parse bus clocks from a list")
Signed-off-by: Dan Carpenter
diff --git a/drivers/gpu/drm/msm/dsi/dsi_host.c
b/drivers/gpu/drm/msm/dsi/dsi_host.c
index 1fc07ce24686..239e79b39a45 100644
--- a/drivers/
On Thu, 16 Feb 2017, Jani Nikula wrote:
> Handle override edid and firmware edid at the low level to transparently
> and completely replace the real edid. This also prevents actual edid
> reads for them, but retains ddc probe.
Please ignore this stray patch, and look at the series at
https://pat
Handle override edid and firmware edid at the low level to transparently
and completely replace the real edid. This also prevents actual edid
reads for them, but retains ddc probe.
FIXME: validate override edid, deduplicate firmware edid validation.
Signed-off-by: Jani Nikula
---
drivers/gpu/dr
Make the function useful for resetting, not just setting, the ELD.
Signed-off-by: Jani Nikula
---
drivers/gpu/drm/drm_edid.c | 3 +++
1 file changed, 3 insertions(+)
diff --git a/drivers/gpu/drm/drm_edid.c b/drivers/gpu/drm/drm_edid.c
index 24e7b282f16c..362036360724 100644
--- a/drivers/gpu/dr
This is a simplified version of the perhaps too ambitious RFC [1].
Here we simply handle debugfs override edid and the firmware edid at the
drm_do_get_edid() level, not at the probe helper level. With this, everything
from EDID gets transparently overridden.
BR,
Jani.
[1] http://mid.mail-archiv
Handle debugfs override edid and firmware edid at the low level to
transparently and completely replace the real edid. Previously, we
practically only used the modes from the override EDID, and none of the
other data. This also prevents actual EDID reads when the EDID is to be
overridden, but retai
Make the firmware loader more generic and generally useful.
Signed-off-by: Jani Nikula
---
drivers/gpu/drm/drm_edid_load.c| 17 -
drivers/gpu/drm/drm_probe_helper.c | 8 +++-
include/drm/drm_edid.h | 7 ---
3 files changed, 15 insertions(+), 17 deletions
Hi,
On 15-02-17 15:59, Ville Syrjälä wrote:
On Wed, Feb 15, 2017 at 03:54:17PM +0100, Hans de Goede wrote:
Hi Jani,
As discussed here:
https://bugs.freedesktop.org/show_bug.cgi?id=94894
I've a mini-laptop which uses a phone-screen,
so the native orientation of the screen is portrait,
where a
Hi Dave, this one superseeds [1]. Better to flush out the single uapi
fix for v4.11 now so it's not forgotten.
BR,
Jani.
[1] 87mvdnpnix.fsf@intel.com">http://mid.mail-archive.com/87mvdnpnix.fsf@intel.com
The following changes since commit 13f62f54d174d3417c3caaafedf5e22a0a03e442:
Merge bran
1 - 100 of 107 matches
Mail list logo
