:
<https://lists.freedesktop.org/archives/dri-devel/attachments/20161228/e0ef149b/attachment.html>
||when running in VM
--
You are receiving this mail because:
You are the assignee for the bug.
-- next part --
An HTML attachment was scrubbed...
URL:
<https://lists.freedesktop.org/archives/dri-devel/attachments/20161228/fb8786a5/attachm
On Tue, Dec 27, 2016 at 07:46:55PM +0100, Daniel Vetter wrote:
>On Wed, Dec 28, 2016 at 12:57:07AM +0800, kbuild test robot wrote:
>> tree: git://anongit.freedesktop.org/drm-intel drm-intel-nightly
>> head: 0d15e733fab5dd48154dda2bebdacd1d87069d08
>> commit: 50f0033d1a0f3a8e9eed09ab68067fbb57b0
vel/attachments/20161228/8af55fa9/attachment.html>
HTML attachment was scrubbed...
URL:
<https://lists.freedesktop.org/archives/dri-devel/attachments/20161228/e47f1887/attachment.html>
The samsung,power-domain property is obsolete since commit 0da658704136
("ARM: dts: convert to generic power domain bindings for exynos DT").
Replace it with generic one.
Signed-off-by: Krzysztof Kozlowski
Reviewed-by: Sylwester Nawrocki
Reviewed-by: Javier Martinez Canillas
Acked-by: Rob Herri
On Wed, Dec 28, 2016 at 03:31:19PM +0100, Daniel Vetter wrote:
> On Wed, Dec 28, 2016 at 2:31 PM, Chris Wilson
> wrote:
> > On Wed, Dec 28, 2016 at 02:02:27PM +0100, Daniel Vetter wrote:
> >> On Thu, Dec 22, 2016 at 08:36:37AM +, Chris Wilson wrote:
> >> > Insulate users from changes to the i
Added some boilerplate for the structs, documented members where they
are relevant and plenty of markup for hyperlinks all over. And a few
small wording polish.
Note that the intro needs some more love after the DRM_MM_INSERT_*
patch from Chris has landed.
v2: Spelling fixes (Chris).
Cc: Chris W
Including all drivers. I thought about keeping small compat functions
to avoid having to change all drivers. But I really like the
drm_printer idea, so figured spreading it more widely is a good thing.
Cc: Rob Clark
Cc: Russell King
Cc: Alex Deucher
Cc: Christian König
Cc: Lucas Stach
Cc: To
Useful for dumping lots of data into dmesg, e.g. drm_mm.
Cc: Rob Clark
Signed-off-by: Daniel Vetter
---
drivers/gpu/drm/drm_print.c | 6 ++
include/drm/drm_print.h | 20 ++--
2 files changed, 24 insertions(+), 2 deletions(-)
diff --git a/drivers/gpu/drm/drm_print.c b/d
On Wed, Dec 28, 2016 at 05:57:40PM +0100, Daniel Vetter wrote:
> @@ -230,23 +272,23 @@ static inline u64 drm_mm_hole_node_end(const struct
> drm_mm_node *hole_node)
>
> /**
> * drm_mm_for_each_node - iterator to walk over all allocated nodes
> - * @entry: drm_mm_node structure to assign to in
On Wed, Dec 28, 2016 at 05:42:10PM +0100, Daniel Vetter wrote:
> static int ttm_pl_vram = TTM_PL_VRAM;
> diff --git a/drivers/gpu/drm/selftests/test-drm_mm.c
> b/drivers/gpu/drm/selftests/test-drm_mm.c
> index 2ce92f4dcfc7..598fde492863 100644
> --- a/drivers/gpu/drm/selftests/test-drm_mm.c
> +++
On Mon, 19 Dec 2016 10:42:28 +0100,
Daniel Vetter wrote:
>
> On Mon, Dec 19, 2016 at 11:09:55AM +0200, Jani Nikula wrote:
> > On Wed, 14 Dec 2016, Arnaud Pouliquen wrote:
> > > Add helper to allow users to retrieve the speaker allocations without
> > > knowledge of the ELD structure.
> > >
> > >
Fabio Estevam writes:
> On Wed, Dec 28, 2016 at 4:38 PM, Gabriel Krisman Bertazi
> wrote:
>
>> This leaks tcon if clk_prepare_enable fails.
>
> No, it does not as tcon is allocated via devm_kzalloc().
Agreed. But I think devm_kzalloc() only drops the memory once the
device is removed, which is
Fabio Estevam writes:
> From: Fabio Estevam
>
> When devm_kzalloc() fails there is no need to assign an error code
> to the 'ret' variable as it will not be used after jumping to the
> 'err_node_put' label, so just remove the assignment.
>
> Signed-off-by: Fabio Estevam
> ---
> drivers/gpu/drm
On Wed, Dec 28, 2016 at 4:38 PM, Gabriel Krisman Bertazi
wrote:
> This leaks tcon if clk_prepare_enable fails.
No, it does not as tcon is allocated via devm_kzalloc().
Fabio Estevam writes:
> From: Fabio Estevam
>
> clk_prepare_enable() may fail, so we should better check its return
> value.
>
> Also place the of_node_put() function right after clk_prepare_enable(),
> in order to avoid calling of_node_put() twice in case clk_prepare_enable()
> fails.
>
> Sign
Added some boilerplate for the structs, documented members where they
are relevant and plenty of markup for hyperlinks all over. And a few
small wording polish.
Note that the intro needs some more love after the DRM_MM_INSERT_*
patch from Chris has landed.
Cc: Chris Wilson
Cc: Joonas Lahtinen
S
- Remove the outdated hunk about driver documentation which somehow
got misplaced here in the split-up.
- Collect all the testing&validation stuff together and give the CRC
section a heading for prettier output.
Cc: Tomeu Vizoso
Cc: Jani Nikula
Signed-off-by: Daniel Vetter
---
Documentati
On Wed, Dec 28, 2016 at 04:25:29PM +0100, Daniel Vetter wrote:
> @@ -549,9 +549,11 @@ EXPORT_SYMBOL(drm_mm_replace_node);
> * The DRM range allocator supports this use-case through the scanning
> * interfaces. First a scan operation needs to be initialized with
> * drm_mm_scan_init() or drm_m
On Wed, Dec 28, 2016 at 02:48:52PM +0100, Daniel Vetter wrote:
> On Thu, Dec 22, 2016 at 08:36:40AM +, Chris Wilson wrote:
> > The drm_mm range manager claimed to support top-down insertion, but it
> > was neither searching for the top-most hole that could fit the
> > allocation request nor fit
On Wed, Dec 28, 2016 at 2:31 PM, Chris Wilson
wrote:
> On Wed, Dec 28, 2016 at 02:02:27PM +0100, Daniel Vetter wrote:
>> On Thu, Dec 22, 2016 at 08:36:37AM +, Chris Wilson wrote:
>> > Insulate users from changes to the internal hole tracking within
>> > struct drm_mm_node by using an accessor
On Wed, Nov 16, 2016 at 02:58:07PM +0100, Maarten Lankhorst wrote:
> During atomic check/commit, these macros should be used in place of
> get_existing_state.
>
> We also ban the use of get_xx_state after atomic check, because at that
> point no new locks should be taken and get_new/old_state shou
On Wed, Dec 28, 2016 at 10:37:09PM +0800, Fengguang Wu wrote:
> On Tue, Dec 27, 2016 at 07:46:55PM +0100, Daniel Vetter wrote:
> >On Wed, Dec 28, 2016 at 12:57:07AM +0800, kbuild test robot wrote:
> >>tree: git://anongit.freedesktop.org/drm-intel drm-intel-nightly
> >>head: 0d15e733fab5dd48154d
On Thu, Dec 22, 2016 at 08:36:40AM +, Chris Wilson wrote:
> The drm_mm range manager claimed to support top-down insertion, but it
> was neither searching for the top-most hole that could fit the
> allocation request nor fitting the request to the hole correctly.
>
> In order to search the ran
From: Fabio Estevam
clk_prepare_enable() may fail, so we should better check its return
value.
Also place the of_node_put() function right after clk_prepare_enable(),
in order to avoid calling of_node_put() twice in case clk_prepare_enable()
fails.
Signed-off-by: Fabio Estevam
---
drivers/gp
From: Fabio Estevam
When devm_kzalloc() fails there is no need to assign an error code
to the 'ret' variable as it will not be used after jumping to the
'err_node_put' label, so just remove the assignment.
Signed-off-by: Fabio Estevam
---
drivers/gpu/drm/fsl-dcu/fsl_tcon.c | 4 +---
1 file cha
> "DV" == Daniel Vetter writes:
DV> Hm, I thought there was in issue there still. Anyway, was just a drive-by
DV> comment, please ignore me ;-)
Any and all help is always appreciated.
-JimC
--
James Cloos OpenPGP: 0x997A9F17ED7DAEA6
On Wed, Dec 28, 2016 at 02:01:29PM +0100, Daniel Vetter wrote:
> On Thu, Dec 22, 2016 at 08:36:33AM +, Chris Wilson wrote:
> > Compute the minimal required hole during scan and only evict those nodes
> > that overlap. This enables us to reduce the number of nodes we need to
> > evict to the bar
On Wed, Dec 28, 2016 at 01:06:26PM +0200, Jani Nikula wrote:
> No reason not to be const.
>
> Signed-off-by: Jani Nikula
Reviewed-by: Daniel Vetter
> ---
> drivers/gpu/drm/drm_edid.c | 6 +++---
> 1 file changed, 3 insertions(+), 3 deletions(-)
>
> diff --git a/drivers/gpu/drm/drm_edid.c b/d
On Wed, Dec 28, 2016 at 10:51:20AM +, Chris Wilson wrote:
> A couple of parameters slipped through the kerneldoc net.
>
> Reported-by: kbuild test robot
> Signed-off-by: Chris Wilson
> Cc: Daniel Vetter
Applied to drm-misc, thanks.
-Daniel
> ---
> drivers/gpu/drm/drm_mm.c | 2 ++
> 1 fil
On Thu, Dec 22, 2016 at 08:36:37AM +, Chris Wilson wrote:
> Insulate users from changes to the internal hole tracking within
> struct drm_mm_node by using an accessor for hole_follows.
>
> Signed-off-by: Chris Wilson
> Reviewed-by: Joonas Lahtinen
> ---
> drivers/gpu/drm/drm_mm.c
On Thu, Dec 22, 2016 at 08:36:33AM +, Chris Wilson wrote:
> Compute the minimal required hole during scan and only evict those nodes
> that overlap. This enables us to reduce the number of nodes we need to
> evict to the bare minimum.
>
> Signed-off-by: Chris Wilson
> Reviewed-by: Joonas Laht
On Wed, Dec 28, 2016 at 02:02:27PM +0100, Daniel Vetter wrote:
> On Thu, Dec 22, 2016 at 08:36:37AM +, Chris Wilson wrote:
> > Insulate users from changes to the internal hole tracking within
> > struct drm_mm_node by using an accessor for hole_follows.
> >
> > Signed-off-by: Chris Wilson
> >
No reason not to be const.
Signed-off-by: Jani Nikula
---
drivers/gpu/drm/drm_edid.c | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/drivers/gpu/drm/drm_edid.c b/drivers/gpu/drm/drm_edid.c
index 67d6a73731d8..4ff04aa84dd0 100644
--- a/drivers/gpu/drm/drm_edid.c
+++ b/dr
ttm_global_reference was renamed to drm_global_reference. This updates
the documentation to reflect that. While we are there, document the
drm_global_reference API and update the initialization interface
documentation.
Signed-off-by: Gabriel Krisman Bertazi
---
Documentation/gpu/drm-mm.rst | 3
Signed-off-by: Gabriel Krisman Bertazi
---
include/drm/drm_drv.h | 30 ++
1 file changed, 30 insertions(+)
diff --git a/include/drm/drm_drv.h b/include/drm/drm_drv.h
index c4fc49583dc0..0c8e4e979870 100644
--- a/include/drm/drm_drv.h
+++ b/include/drm/drm_drv.h
@@ -64
drm_ioctl_permit is exported but missed a kernel-doc style
documentation.
Signed-off-by: Gabriel Krisman Bertazi
---
drivers/gpu/drm/drm_ioctl.c | 8 +---
1 file changed, 5 insertions(+), 3 deletions(-)
diff --git a/drivers/gpu/drm/drm_ioctl.c b/drivers/gpu/drm/drm_ioctl.c
index 5c80e720aec
Signed-off-by: Gabriel Krisman Bertazi
---
drivers/gpu/drm/drm_ioctl.c | 3 ---
1 file changed, 3 deletions(-)
diff --git a/drivers/gpu/drm/drm_ioctl.c b/drivers/gpu/drm/drm_ioctl.c
index d180673c1323..5c80e720aeca 100644
--- a/drivers/gpu/drm/drm_ioctl.c
+++ b/drivers/gpu/drm/drm_ioctl.c
@@ -95
num_ioctls is already assigned when declaring the exynos_drm_driver
structure. No need to duplicate it here.
Signed-off-by: Gabriel Krisman Bertazi
---
drivers/gpu/drm/exynos/exynos_drm_drv.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/drivers/gpu/drm/exynos/exynos_drm_drv.c
b/drivers/g
Several DRM drivers print the same initialization message right after
drm_dev_register, so move that to common code. The exception is i915,
which uses its own register handle, so let it keep its own message.
Notice that this was tested only with Exynos, but looks simple enough
for the other drive
Hi,
Here is a first batch of cleanups and documentation improvements to get
me started on the DRM subsystem. I'm crawling through the newbie's
page, and should share patches for load/unload callbacks removal next,
once I properly test them.
Thanks,
Gabriel Krisman Bertazi (6):
drm: Deduplicat
In case of HW trigger mode, sysreg register should be configured to
enable TE functionality. The patch refactors also trigger setup function.
Signed-off-by: Andrzej Hajda
---
drivers/gpu/drm/exynos/exynos5433_drm_decon.c | 40 +--
1 file changed, 32 insertions(+), 8 delet
On Wednesday, 2016-12-28 11:09:59 +0100, Daniel Vetter wrote:
> On Wed, Dec 28, 2016 at 10:06:00AM +, Chris Wilson wrote:
> > On Wed, Dec 28, 2016 at 10:41:17AM +0100, Daniel Vetter wrote:
> > > Kbuild really doesn't like non-recursive Makefiles, but they do work
> > > as long as you build with
On Tue, 27 Dec 2016, Daniel Vetter wrote:
> On Tue, Dec 27, 2016 at 06:21:47PM +0200, Jani Nikula wrote:
>> Hi all -
>>
>> This series aims at three goals:
>>
>> 1) Most drivers do similar things around drm_get_edid (namely convert
>> edid to eld, add modes, and update edid blob property). Add a
On Tue, Dec 27, 2016 at 11:10:57AM +0100, Daniel Vetter wrote:
> Drivers need to take care. Motivated by a discussion between Mark and
> Rob on dri-devel.
>
> Cc: Mark yao
> Cc: Rob Clark
> Signed-off-by: Daniel Vetter
> ---
> drivers/gpu/drm/drm_mm.c | 5 +
> 1 file changed, 5 insertions(
On Wed, Dec 28, 2016 at 10:06:00AM +, Chris Wilson wrote:
> On Wed, Dec 28, 2016 at 10:41:17AM +0100, Daniel Vetter wrote:
> > Kbuild really doesn't like non-recursive Makefiles, but they do work
> > as long as you build without O=
> >
> > Reported-by: kbuild test robot
> > Fixes: 50f0033d1a0
On Thu, Dec 22, 2016 at 08:36:40AM +, Chris Wilson wrote:
> /**
> * drm_mm_for_each_hole - iterator to walk over all holes
> * @entry: drm_mm_node used internally to track progress
> @@ -274,57 +263,27 @@ static inline u64 drm_mm_hole_node_end(const struct
> drm_mm_node *hole_node)
> *
A couple of parameters slipped through the kerneldoc net.
Reported-by: kbuild test robot
Signed-off-by: Chris Wilson
Cc: Daniel Vetter
---
drivers/gpu/drm/drm_mm.c | 2 ++
1 file changed, 2 insertions(+)
diff --git a/drivers/gpu/drm/drm_mm.c b/drivers/gpu/drm/drm_mm.c
index 21bd2e13738b..54a8
Kbuild really doesn't like non-recursive Makefiles, but they do work
as long as you build without O=
Reported-by: kbuild test robot
Fixes: 50f0033d1a0f ("drm: Add some kselftests for the DRM range manager
(struct drm_mm)")
Cc: Chris Wilson
Cc: Christian König
Cc: Joonas Lahtinen # Please ente
On Tue, 27 Dec 2016, Daniel Vetter wrote:
> I'm not sure how this all should look like.
This we definitely agree on, and hence the RFC. :)
I'm pretty sure it should *not* look like it currently does.
BR,
Jani.
--
Jani Nikula, Intel Open Source Technology Center
On Tue, Dec 27, 2016 at 07:46:55PM +0100, Daniel Vetter wrote:
> On Wed, Dec 28, 2016 at 12:57:07AM +0800, kbuild test robot wrote:
> > tree: git://anongit.freedesktop.org/drm-intel drm-intel-nightly
> > head: 0d15e733fab5dd48154dda2bebdacd1d87069d08
> > commit: 50f0033d1a0f3a8e9eed09ab68067fbb
On Wed, Dec 28, 2016 at 11:23:42AM +0200, Jani Nikula wrote:
> On Tue, 27 Dec 2016, Daniel Vetter wrote:
> > On Tue, Dec 27, 2016 at 06:21:47PM +0200, Jani Nikula wrote:
> >> Hi all -
> >>
> >> This series aims at three goals:
> >>
> >> 1) Most drivers do similar things around drm_get_edid (name
On Tue, Dec 27, 2016 at 07:41:47PM +0100, Daniel Vetter wrote:
> On Tue, Dec 27, 2016 at 06:21:47PM +0200, Jani Nikula wrote:
> > Hi all -
> >
> > This series aims at three goals:
> >
> > 1) Most drivers do similar things around drm_get_edid (namely convert
> > edid to eld, add modes, and update
On Wed, Dec 28, 2016 at 10:39:17AM +0200, Jani Nikula wrote:
> On Tue, 27 Dec 2016, Daniel Vetter wrote:
> > I'm not sure how this all should look like.
>
> This we definitely agree on, and hence the RFC. :)
>
> I'm pretty sure it should *not* look like it currently does.
Yup, agreed on that. S
On Wed, Dec 28, 2016 at 10:41:17AM +0100, Daniel Vetter wrote:
> Kbuild really doesn't like non-recursive Makefiles, but they do work
> as long as you build without O=
>
> Reported-by: kbuild test robot
> Fixes: 50f0033d1a0f ("drm: Add some kselftests for the DRM range manager
> (struct drm_mm)"
On Wed, Dec 28, 2016 at 5:30 AM, Andrzej Hajda wrote:
> In case of HW trigger mode, sysreg register should be configured to
> enable TE functionality. The patch refactors also trigger setup function.
>
> Signed-off-by: Andrzej Hajda
> ---
> drivers/gpu/drm/exynos/exynos5433_drm_decon.c | 40
> +
2015-01-23 816 u64 adj_start, adj_end;
709ea971 Daniel Vetter 2010-07-02 817
9a71e277 Chris Wilson 2016-12-22 818 DRM_MM_BUG_ON(node->mm != mm);
9a71e277 Chris Wilson 2016-12-22 819 DRM_MM_BUG_ON(!node->allocated);
b3ee963f Chris Wilson 2016-12-22 820
DRM_MM_BUG_ON(node->scanned_block);
:: The code at line 812 was first introduced by commit
:: 709ea97145c125b3811ff70429e90ebdb0e832e5 drm: implement helper functions
for scanning lru list
:: TO: Daniel Vetter
:: CC: Dave Airlie
---
0-DAY kernel test infrastructureOpen Source Technology Center
https://lists.01.org/pipermail/kbuild-all Intel Corporation
-- next part --
A non-text attachment was scrubbed...
Name: .config.gz
Type: application/gzip
Size: 6441 bytes
Desc: not available
URL:
<https://lists.freedesktop.org/archives/dri-devel/attachments/20161228/197e4059/attachment-0001.gz>
dgpu :01:00.0: VM_CONTEXT1_PROTECTION_FAULT_STATUS
0x0B008001
...snip...
--
You are receiving this mail because:
You are the assignee for the bug.
-- next part --
An HTML attachment was scrubbed...
URL:
<https://lists.freedesktop.org/archives/dri-devel/attachmen
tion/gzip
Size: 59444 bytes
Desc: not available
URL:
<https://lists.freedesktop.org/archives/dri-devel/attachments/20161228/99ff7442/attachment-0001.gz>
60 matches
Mail list logo
