Turn clk_enable() and clk_disable() calls into clk_prepare_enable() and
clk_disable_unprepare() to get ready for the migration to the common
clock framework.
Cc: David Airlie
Cc: dri-devel at lists.freedesktop.org
Signed-off-by: Laurent Pinchart
---
drivers/gpu/drm/shmobile/shmob_drm_crtc.c | 4
Hello,
This patch series, based on v3.12-rc7, prepares various Renesas SH-Mobile,
R-Mobile and R-Car drivers for migration to CCF by adding clock prepare and
unprepare support.
The patches are pretty straightforward. Most of the drivers called
clk_enable and clk_disable in sleepable context, I've
ubbed...
URL:
<http://lists.freedesktop.org/archives/dri-devel/attachments/20131028/ce8ec2cb/attachment.html>
- next part --
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 836 bytes
Desc: not available
URL:
<http://lists.freedesktop.org/archives/dri-devel/attachments/20131028/e1df6293/attachment.pgp>
Hi Shirish,
I have merged the re-factoring patch set from Sean Paul to exynos-drm-next.
Can you re-base your patch set at top of exynos-drm-next?
Thanks,
Inki Dae
> -Original Message-
> From: Shirish S [mailto:s.shirish at samsung.com]
> Sent: Monday, October 28, 2013 7:39 PM
> To: dri-d
ter things to do.
>
> It's all up to you, I believe.
>
>
> Thanks,
> pq
>
-- next part --
An HTML attachment was scrubbed...
URL:
<http://lists.freedesktop.org/archives/dri-devel/attachments/20131028/943ff901/attachment-0001.html>
Hi Tomasz,
I have merged the re-factoring patch set from Sean Paul. Can you
re-base your patch set at top of exynos-drm-next?
Thanks,
Inki Dae
2013/10/21 Tomasz Stanislawski :
> This patchset adds support for HDMI at SoCs from Exynos4 family. The patches
> are rebased on kishon/next. Additionall
Hi Rahul,
I have merged the re-factoring patch set from Sean Paul to
exynos-drm-next except eDP related patch set that these need more
reviews. Can you re-base at top of exynos-drm-next?
Thanks,
Inki Dae
2013/10/22 Rahul Sharma :
> Currently, exynos hdmiphy operations and configs are kept
> insi
On Mon, Oct 28, 2013 at 10:15:00AM +, Shirish S wrote:
> Hi Mark,
> Firstly thanks for reviewing.
Hi,
Please could you refrain from replying in HTML and use plaintext, it's rather
difficult to respond sensibly.
>
>
> On Mon, Oct 28, 2013 at 12:20 PM, Mark Rutland
> wrote:
>
> Hi,
>
This patch fixes build error incurred by the re-factoring patch applying.
The re-factoring patch set from Sean missed to apply the update to vidi
module so this patch applies the update so that vidi module is also built
correctly.
Signed-off-by: Inki Dae
Signed-off-by: Kyungmin Park
---
driver
This patch makes callback funtions of each sub driver to be called
with device object instead of display and manager.
Exynos drm framework doesn't need to pass a manager or a display
when calling callback function of each sub driver, and each sub
driver can get its own context from device object.
s mail because:
You are the assignee for the bug.
-- next part --
An HTML attachment was scrubbed...
URL:
<http://lists.freedesktop.org/archives/dri-devel/attachments/20131028/b2233e3a/attachment.html>
n HTML attachment was scrubbed...
URL:
<http://lists.freedesktop.org/archives/dri-devel/attachments/20131028/5a01f651/attachment.html>
help.
Is dither supported for eDP at all?
--
You are receiving this mail because:
You are the assignee for the bug.
-- next part --
An HTML attachment was scrubbed...
URL:
<http://lists.freedesktop.org/archives/dri-devel/attachments/20131028/09d04335/attachment.html>
: 836 bytes
Desc: not available
URL:
<http://lists.freedesktop.org/archives/dri-devel/attachments/20131028/43a6e2d7/attachment.pgp>
On 10/28/2013 04:38 PM, Thierry Reding wrote:
> On Mon, Oct 28, 2013 at 03:51:32PM -0600, Stephen Warren wrote:
>> On 10/28/2013 02:53 AM, Thierry Reding wrote:
>>> On Mon, Oct 21, 2013 at 11:34:07AM +0800, Wei Yongjun wrote:
From: Wei Yongjun
In case of error, the function clk_get
EBUG_MASK_LPSP);
+ EDP_PSR_DEBUG_MASK_HPD);
intel_dp->psr_setup_done = true;
}
-- next part --
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 836 bytes
Desc: not available
URL:
<http://lists.freedesktop.org/archives/dri-devel/attachments/20131028/b458daf4/attachment-0001.pgp>
On Thu, Oct 24, 2013 at 3:46 AM, Inki Dae wrote:
> 2013/10/23 Rob Clark :
>> On Wed, Oct 23, 2013 at 9:18 AM, Inki Dae wrote:
>>> Look at omapdrm, nouveau, and radeon drm drivers.
>>
>>
>> btw, please don't look at omapdrm as a "good" example in this regard.
>> The layering is really not a good i
ves/dri-devel/attachments/20131028/5d227734/attachment.html>
- next part --
An HTML attachment was scrubbed...
URL:
<http://lists.freedesktop.org/archives/dri-devel/attachments/20131028/55d68095/attachment.html>
This patch adds dt support to hdmiphy config settings
as it is board specific and depends on the signal pattern
of board.
Signed-off-by: Shirish S
---
.../devicetree/bindings/video/exynos_hdmi.txt | 32 +
drivers/gpu/drm/exynos/exynos_hdmi.c | 76 ++
This patch moves the hdmi phy setting to arndale dts,
as its more of a per board configuration and also
shall be easier for supporting future chipsets.
Signed-off-by: Shirish S
---
arch/arm/boot/dts/exynos5250-arndale.dts | 68 ++
1 file changed, 68 insertions(+)
d
This patch moves the hdmi phy setting to smdk5250
dts,as its more of a per board configuration and
also shall be easier for supporting future chipsets.
Signed-off-by: Shirish S
---
arch/arm/boot/dts/exynos5250-smdk5250.dts | 68 +
1 file changed, 68 insertions(+)
d
For various revisions of a chipset if the signal pattern is changed for every
revision, then the phy setting need to be updated correspondingly by measuring
the signal.
For getting correct signals the clock level and data de-emphasis
levels needs to be adjusted.
Since only these 2 values matter,we
e the assignee for the bug.
-- next part --
An HTML attachment was scrubbed...
URL:
<http://lists.freedesktop.org/archives/dri-devel/attachments/20131028/0b2013ba/attachment.html>
On 10/28/2013 02:53 AM, Thierry Reding wrote:
> On Mon, Oct 21, 2013 at 11:34:07AM +0800, Wei Yongjun wrote:
>> From: Wei Yongjun
>>
>> In case of error, the function clk_get_parent() and
>> devm_ioremap_resource() returns ERR_PTR() and never returns NULL.
>> The NULL test in the return value che
+ (u32 *)&hdata->confs[i].
> > + pixel_clock, 1)) {
>
> Don't split &hdata->confs[i].pixel_clock over two lines.
>
> Why is the cast necessary?
>
> Why not just of_property_read_u32? This only ever has a single value, and
> while
> there's no of_property_read_u8, of_property_read_u32 exists.
>
> Ok, agreed.
> > + DRM_ERROR("Failed to get pixel clock\n");
> > + return -EINVAL;
> > + }
> > +
> > + /* Overwrite the data de-emphasis and data level */
> > + if (of_property_read_u8_array(cfg_np,
> "conf-de-emphasis-level",
> > + (u8 *)&hdata->confs[i].conf[16],
> 1)) {
>
> Why is this cast necessary?
>
> I don't see why this must be an 8 bit property.
>
> As mentioned earlier its by design 8 bits.
> > + DRM_ERROR("Failed to get conf\n");
> > + return -EINVAL;
> > + }
> > + /* Overwrite the clock level diff */
> > + if (of_property_read_u8_array(cfg_np, "conf-clock-level",
> > + (u8 *)&hdata->confs[i].conf[23],
> 1)) {
>
> Why the cast?
>
> Same explaination as above.
> Thanks,
> Mark.
>
Thanks,
Shirish S
-- next part --
An HTML attachment was scrubbed...
URL:
<http://lists.freedesktop.org/archives/dri-devel/attachments/20131028/eb229ff0/attachment-0001.html>
e could add an EDID quirk to fix the bpc.
--
You are receiving this mail because:
You are the assignee for the bug.
-- next part --
An HTML attachment was scrubbed...
URL:
<http://lists.freedesktop.org/archives/dri-devel/attachments/20131028/32e1ec99/attachment-0001.html>
s scrubbed...
URL:
<http://lists.freedesktop.org/archives/dri-devel/attachments/20131028/24fac76f/attachment.html>
attachment was scrubbed...
URL:
<http://lists.freedesktop.org/archives/dri-devel/attachments/20131028/23a65d9b/attachment.html>
161/
http://paste.ubuntu.com/6296168/
Thank you fritsch for your help.
Greetz, Chris
--
You are receiving this mail because:
You are the assignee for the bug.
-- next part --
An HTML attachment was scrubbed...
URL:
<http://lists.freedesktop.org/archives/dri-devel/attachme
2013/10/28 Deucher, Alexander :
>> -Original Message-
>> From: Rafa? Mi?ecki [mailto:zajec5 at gmail.com]
>> Sent: Monday, October 28, 2013 5:24 AM
>> To: Alex Deucher
>> Cc: dri-devel; Deucher, Alexander
>> Subject: Re: [PATCH] drm/radeon/audio: don't set speaker allocation on
>> DCE4+
>>
chment was scrubbed...
URL:
<http://lists.freedesktop.org/archives/dri-devel/attachments/20131028/18344907/attachment.html>
?h=drm-next-3.13-wip&id=a7986a436b7234368aa03e9e06ad737c9e9e42c5
You might try enabling dithering via xrandr.
--
You are receiving this mail because:
You are the assignee for the bug.
-- next part --
An HTML attachment was scrubbed...
URL:
<http://lists.freedesktop.org/archives/dri-devel/attachments/201
On Mon, Oct 28, 2013 at 12:49 PM, Olof Johansson wrote:
> On Wed, Oct 23, 2013 at 9:09 AM, Sean Paul wrote:
>> On Wed, Oct 23, 2013 at 11:53 AM, Dave Airlie wrote:
>>>
>>> I think we need to start considering a framework where subdrivers just
>>> add drm objects themselves,
On Fri, 25 Oct 2013 17:19:56 +0400
Eugene Shatokhin wrote:
> Hi,
>
> 2013/10/25 Pekka Paalanen
>
...
> > We could use some comments from the real reverse-engineers. I used
> > to be mostly a tool writer.
> >
>
> Yes, if some experts could share their knowledge of this matter, this would
> be
On Sat, Oct 26, 2013 at 10:27:38AM +0200, Mario Kleiner wrote:
> Hi all,
>
> this patch set for the kernel pushes the latency sensitive bits of
> vblank scanoutpos timestamping from the drm core into the kms drivers.
>
> A change in the locking of the intel-kms driver for Linux 3.11 made
> the ol
> -Original Message-
> From: Rafa? Mi?ecki [mailto:zajec5 at gmail.com]
> Sent: Monday, October 28, 2013 5:24 AM
> To: Alex Deucher
> Cc: dri-devel; Deucher, Alexander
> Subject: Re: [PATCH] drm/radeon/audio: don't set speaker allocation on
> DCE4+
>
> 2013/10/19 Alex Deucher :
> > It caus
This patch adds dt support to hdmiphy config settings
as it is board specific and depends on the signal pattern
of board.
Signed-off-by: Shirish S
---
.../devicetree/bindings/video/exynos_hdmi.txt | 29
arch/arm/boot/dts/exynos5250-arndale.dts |6 +-
drivers/gpu/drm
This patch moves the hdmi phy setting to arndale dts,
as its more of a per board configuration and also
shall be easier for supporting future chipsets.
Signed-off-by: Shirish S
---
arch/arm/boot/dts/exynos5250-arndale.dts | 68 ++
1 file changed, 68 insertions(+)
d
This patch moves the hdmi phy setting to smdk5250
dts,as its more of a per board configuration and
also shall be easier for supporting future chipsets.
Signed-off-by: Shirish S
---
arch/arm/boot/dts/exynos5250-smdk5250.dts | 68 +
1 file changed, 68 insertions(+)
d
For various revisions of a chipset if the signal pattern is changed for every
revision, then the phy setting need to be updated correspondingly by measuring
the signal.
For getting correct signals the clock level and data de-emphasis
levels needs to be adjusted.
Since only these 2 values matter,we
On Sat, Oct 26, 2013 at 4:27 AM, Mario Kleiner
wrote:
> Hi all,
>
> this patch set for the kernel pushes the latency sensitive bits of
> vblank scanoutpos timestamping from the drm core into the kms drivers.
>
> A change in the locking of the intel-kms driver for Linux 3.11 made
> the old approach
how we take care of
>> the PHY configuration values. So I will have two steps to merge this pages
>> set.
>>
>> To Rahul,
>> Could you post only your patch set regardless of Shirish's patch? I will
>> merge your patch set first because as is, Exynos drm hdmi driver is
>> broken.
>> And, we need more discussions about Shirish patch. So I will not merge
>> this
>> patch until we have a consensus about it.
>>
>> To Shirish,
>> For your patch, it seems that you need to make sure to figure out exact
>> meaning of each byte of the PHY configuration values first. Maybe you need
>> to inquire for that to hardware or design team. And please separate the
>> values into common and specific parts if needed.
>>
>> Agreed, I shall request our hardware team to provide description about
> the phy values, and will update the patch, once i receive the same.
>
>
>>
>> Thanks,
>> Inki Dae
>>
>> > --
>> > Thanks,
>> > Sylwester
>>
>> Thanks,
> Shirish S
>
-- next part --
An HTML attachment was scrubbed...
URL:
<http://lists.freedesktop.org/archives/dri-devel/attachments/20131028/a1be2188/attachment-0001.html>
On Mon, Oct 28, 2013 at 10:55:49AM +0100, David Herrmann wrote:
> DRM_IOCTL_VERSION is a reliable way to get the driver-name and version
> information. It's not related to the interface-version (SET_VERSION ioctl)
> so we can safely enable it on render-nodes.
>
> Note that gbm uses udev-BUSID to l
've applied the series, though I had to rework some of it because
host1x and DRM have significantly changed in the meantime.
Thierry
-- next part --
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 836 bytes
Desc: not available
URL:
<http://lists.freedesktop.org/archives/dri-devel/attachments/20131028/ec6bc73a/attachment.pgp>
Typo in the register offset.
Noticed-by: Sylvain BERTRAND
Signed-off-by: Alex Deucher
Cc: stable at vger.kernel.org
---
drivers/gpu/drm/radeon/sid.h | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/gpu/drm/radeon/sid.h b/drivers/gpu/drm/radeon/sid.h
index 307ffdf..569
On Mon, Oct 28, 2013 at 9:35 AM, Inki Dae wrote:
> This patch fixes build error incurred by the re-factoring patch applying.
>
> The re-factoring patch set from Sean missed to apply the update to vidi
> module so this patch applies the update so that vidi module is also built
> correctly.
>
Thank
DRM_IOCTL_VERSION is a reliable way to get the driver-name and version
information. It's not related to the interface-version (SET_VERSION ioctl)
so we can safely enable it on render-nodes.
Note that gbm uses udev-BUSID to load the correct mesa driver. However,
the VERSION ioctl should be the more
On Mon, Oct 28, 2013 at 9:35 AM, Inki Dae wrote:
> This patch makes callback funtions of each sub driver to be called
> with device object instead of display and manager.
>
> Exynos drm framework doesn't need to pass a manager or a display
> when calling callback function of each sub driver, and e
On Sun, Oct 27, 2013 at 7:25 PM, Sylvain BERTRAND wrote:
> Hi,
>
> MC_SEQ_TRAIN_WAKEUP_CNTL and MC_ARB_BURST_TIME have the same
> register address, 0x2808, in sid.h.
MC_SEQ_TRAIN_WAKEUP_CNTL should be 0x28e8. I'll fix it up.
Alex
>
> (Register addresses are different in cikd.h)
>
> Expected?
>
On 10/25/2013 02:35 PM, Igor Gnatenko wrote:
> Aaron, add this notebook to list. I've CC'ed owner.
> And I've tested this patch on my TP X230 (add as Reported-and-Tested me
> please)
> + {
> + .callback = video_set_use_native_backlight,
> + .ident = "Dell Inspiron 7520",
> + .mat
On 14.10.2013 15:21, Arto Merilainen wrote:
> The host1x driver uses currently syncpoints statically from host1x point of
> view. If we do a wait inside a job, it always has a constant value to wait.
> host1x supports also doing relative syncpoint waits with respect to syncpoint
> bases. This allow
On 21.10.2013 08:38, Wei Yongjun wrote:
> From: Wei Yongjun
>
> Add the missing clk_disable_unprepare() before return
> from gr2d_probe() in the error handling case.
>
> Signed-off-by: Wei Yongjun
> ---
> drivers/gpu/drm/tegra/gr2d.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/dr
On 21.10.2013 08:37, Wei Yongjun wrote:
> From: Wei Yongjun
>
> Add the missing clk_disable_unprepare() before return
> from host1x_probe() in the error handling case.
>
> Signed-off-by: Wei Yongjun
> ---
> drivers/gpu/host1x/dev.c | 4 +++-
> 1 file changed, 3 insertions(+), 1 deletion(-)
>
2013/10/19 Alex Deucher :
> It causes hangs on some asics. Disable on DCE6+ as well
> just to be on the safe side.
Did you get any reports about that? Or is that based only on mine comment:
> I noticed some hangs on BARTS too, let me test this solution on DCE5.
> Maybe it's not just DCE3.2.
(Af
Hi Inki,
I noticed that you merged "drm/exynos: change callback argument of sub
driver with device" to your tree without posting it to me, or
dri-devel, first. I think it would have been prudent to send for
review/comments considering that:
a) we don't agree on this, and were in discussion about i
On Mon, 28 Oct 2013, Aaron Lu wrote:
> On 10/25/2013 02:35 PM, Igor Gnatenko wrote:
>> Aaron, add this notebook to list. I've CC'ed owner.
>> And I've tested this patch on my TP X230 (add as Reported-and-Tested me
>> please)
>> +{
>> + .callback = video_set_use_native_backlight,
>> + .
rds
Stefan
-- next part --
A non-text attachment was scrubbed...
Name: switcheroo_hibernation.patch
Type: text/x-patch
Size: 4924 bytes
Desc: not available
URL:
<http://lists.freedesktop.org/archives/dri-devel/attachments/20131028/4b19d81f/attachment-0001.bin>
1 file changed, 1 insertion(+)
Applied, thanks.
Thierry
-- next part --
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 836 bytes
Desc: not available
URL:
<http://lists.freedesktop.org/archives/dri-devel/attachments/20131028/11f59748/attachment.pgp>
as scrubbed...
Name: not available
Type: application/pgp-signature
Size: 836 bytes
Desc: not available
URL:
<http://lists.freedesktop.org/archives/dri-devel/attachments/20131028/af503426/attachment.pgp>
file changed, 3 insertions(+), 1 deletion(-)
Applied, thanks.
Thierry
-- next part --
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 836 bytes
Desc: not available
URL:
<http://lists.freedesktop.org/archives/dri-devel
On Wed, Oct 23, 2013 at 9:09 AM, Sean Paul wrote:
> On Wed, Oct 23, 2013 at 11:53 AM, Dave Airlie wrote:
>>>
>>
>> I think we need to start considering a framework where subdrivers just
>> add drm objects themselves, then the toplevel node is responsible for
>> knowing that ev
On Mon, Oct 28, 2013 at 6:35 AM, Inki Dae wrote:
> This patch makes callback funtions of each sub driver to be called
> with device object instead of display and manager.
>
> Exynos drm framework doesn't need to pass a manager or a display
> when calling callback function of each sub driver, and e
:
<http://lists.freedesktop.org/archives/dri-devel/attachments/20131028/1336309b/attachment.html>
...
URL:
<http://lists.freedesktop.org/archives/dri-devel/attachments/20131028/072b83b1/attachment.html>
On 10/28/13 06:42, Inki Dae wrote:
> Hi Tomasz,
>
> I have merged the re-factoring patch set from Sean Paul. Can you
> re-base your patch set at top of exynos-drm-next?
>
Basically, RFC is not patch for merge. So Tomasz needs to re-submit
after addressing comments from RFC.
Thanks,
Kukjin
--
An HTML attachment was scrubbed...
URL:
<http://lists.freedesktop.org/archives/dri-devel/attachments/20131028/a517f9e6/attachment.html>
Hi Dave,
Please do _not_ pull this. The pipe bpp readout stuff this crucially
relies on is only partially backported from -next to -fixes and apparently
missing bits on Haswell.
Thanks, Daniel
On Fri, Oct 25, 2013 at 12:50:12PM +0200, Daniel Vetter wrote:
> Hi Dave,
>
> Just the edp bpp fix fro
/dri-devel/attachments/20131028/32da7a01/attachment.html>
ttp://lists.freedesktop.org/archives/dri-devel/attachments/20131028/92427f09/attachment.html>
--
An HTML attachment was scrubbed...
URL:
<http://lists.freedesktop.org/archives/dri-devel/attachments/20131028/a53031a2/attachment.html>
Hi,
On Mon, Oct 28, 2013 at 06:24:22AM +, Shirish S wrote:
> This patch adds dt support to hdmiphy config settings
> as it is board specific and depends on the signal pattern
> of board.
>
> Signed-off-by: Shirish S
> ---
> .../devicetree/bindings/video/exynos_hdmi.txt | 29
Hi,
MC_SEQ_TRAIN_WAKEUP_CNTL and MC_ARB_BURST_TIME have the same
register address, 0x2808, in sid.h.
(Register addresses are different in cikd.h)
Expected?
regards,
--
Sylvain
74 matches
Mail list logo
