[PATCH v6 23/23] modetest: Allocate NV buffers large enough for the two planes

Multiple the image height by 1.5 for NV12/NV21 and by 2 for NV16/NV61 to make room for the chroma plane. Signed-off-by: Laurent Pinchart --- tests/modetest/buffers.c | 19 ++- 1 file changed, 18 insertions(+), 1 deletion(-) diff --git a/tests/modetest/buffers.c b/tests/modetest/

[PATCH v6 22/23] modetest: Fix line stride in SMPTE YUV packet pattern generator

The line stride passed to the function is expressed in bytes, there's no need to multiply it by 2. Signed-off-by: Laurent Pinchart --- tests/modetest/buffers.c | 12 ++-- 1 file changed, 6 insertions(+), 6 deletions(-) diff --git a/tests/modetest/buffers.c b/tests/modetest/buffers.c ind

[PATCH v6 21/23] modetest: Try all possible encoders for a connector

When building the pipeline, instead of using only the encoders attached to a connector, take all possible encoders into account to locate a CRTC. Signed-off-by: Laurent Pinchart --- tests/modetest/modetest.c | 35 +-- 1 file changed, 25 insertions(+), 10 deletions

[PATCH v6 20/23] modetest: Support pipes with multiple connectors

The -s argument can now take a list of connectors. Configure all of them in cloned mode using a single CRTC. Signed-off-by: Laurent Pinchart --- tests/modetest/modetest.c | 211 ++ 1 file changed, 157 insertions(+), 54 deletions(-) diff --git a/tests/

[PATCH v6 19/23] modetest: Rename struct connector_arg to struct pipe_arg

This prepares the code for handling multiple connectors in a single pipeline in a cloned configuration. Signed-off-by: Laurent Pinchart --- tests/modetest/modetest.c | 162 -- 1 file changed, 85 insertions(+), 77 deletions(-) diff --git a/tests/modete

[PATCH v5 00/23] modetest enhancements

On Friday 14 June 2013 23:21:11 Laurent Pinchart wrote: > Hello, > > After a (too) long delay here's the fifth version of my modetest > enhancements patch set. And I've of course sent the wrong version :-/ v6 (hopefully final) is on the way. Sorry for the noise. > Beside various cleanups, these

[PATCH v6 18/23] modetest: Split mode setting and plane setup

There's not reason to require setting a mode to test planes. Split the two operations. Signed-off-by: Laurent Pinchart --- tests/modetest/modetest.c | 104 -- 1 file changed, 72 insertions(+), 32 deletions(-) diff --git a/tests/modetest/modetest.c b/t

[PATCH v6 17/23] modetest: Give the CRTC ID to the -P option

Planes are associated with CRTCs, not connectors. Don't try to be too clever, use the CRTC ID in the -P option. This prepares for splitting CRTC and planes setup. Signed-off-by: Laurent Pinchart --- tests/modetest/modetest.c | 32 +--- 1 file changed, 17 insertions(+)

[PATCH v6 16/23] modetest: Store the mode in the crtc structure

This prepares the code for the split in separate functions of CRTC and planes setup. Signed-off-by: Laurent Pinchart --- tests/modetest/modetest.c | 10 -- 1 file changed, 8 insertions(+), 2 deletions(-) diff --git a/tests/modetest/modetest.c b/tests/modetest/modetest.c index 6fbaf09..3

[PATCH v6 15/23] modetest: Store the crtc in the connector_arg structure

This prepares the code for the split in separate functions of CRTC and planes setup. Signed-off-by: Laurent Pinchart --- tests/modetest/modetest.c | 58 ++- 1 file changed, 37 insertions(+), 21 deletions(-) diff --git a/tests/modetest/modetest.c b/tes

[PATCH v6 14/23] modetest: Remove the struct connector_arg encoder field

The field is no needed, make it a local variable where used. Signed-off-by: Laurent Pinchart --- tests/modetest/modetest.c | 10 +- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/tests/modetest/modetest.c b/tests/modetest/modetest.c index a1a683f..2c3e093 100644 --- a/test

[PATCH v6 13/23] modetest: Compute CRTC pipe number as needed

Signed-off-by: Laurent Pinchart --- tests/modetest/modetest.c | 29 + 1 file changed, 17 insertions(+), 12 deletions(-) diff --git a/tests/modetest/modetest.c b/tests/modetest/modetest.c index cfcb989..a1a683f 100644 --- a/tests/modetest/modetest.c +++ b/tests/modetes

[PATCH v6 12/23] modetest: Create a device structure

Instead of passing the device fd and resources as global variables group them in a device structure and pass it explictly to all functions that need it. Signed-off-by: Laurent Pinchart --- tests/modetest/modetest.c | 201 -- 1 file changed, 103 inserti

[PATCH v6 11/23] modetest: Remove the -m argument

The argument isn't used, remove it. Signed-off-by: Laurent Pinchart --- tests/modetest/modetest.c | 10 +++--- 1 file changed, 3 insertions(+), 7 deletions(-) diff --git a/tests/modetest/modetest.c b/tests/modetest/modetest.c index 7f7a3a2..89bfc53 100644 --- a/tests/modetest/modetest.c +++

[PATCH v6 10/23] modetest: Print the plane ID when setting up a plane

As modetest automatically selects an unused plan, providing the plane ID allows modifying plane properties for the selected planes. Signed-off-by: Laurent Pinchart --- tests/modetest/modetest.c | 8 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/tests/modetest/modetest.c

[PATCH v6 09/23] modetest: Allow specifying plane position

Extend the -P option to allow specifying the plane x and y offsets. The position is optional, if not specified the plane will be positioned at the center of the screen as before. Signed-off-by: Laurent Pinchart --- tests/modetest/modetest.c | 67 --- 1

[PATCH v6 08/23] modetest: Add a command line parameter to set properties

The -w parameter can be used to set a property value from the command line, using the target object ID and the property name. Signed-off-by: Laurent Pinchart --- tests/modetest/modetest.c | 108 +- 1 file changed, 106 insertions(+), 2 deletions(-) dif

[PATCH v6 07/23] modetest: Don't limit mode set and planes to two instances

Configuring mode on more than two connectors or two planes is perfectly valid. Support it. Signed-off-by: Laurent Pinchart --- tests/modetest/modetest.c | 20 ++-- 1 file changed, 18 insertions(+), 2 deletions(-) diff --git a/tests/modetest/modetest.c b/tests/modetest/modetest.c

[PATCH v6 06/23] modetest: Retrieve all resources in one go

Instead of retrieving resources as they are needed, retrieve them all (except property blobs) in one go at startup. Signed-off-by: Laurent Pinchart --- tests/modetest/modetest.c | 408 +- 1 file changed, 261 insertions(+), 147 deletions(-) diff --git

[PATCH v6 05/23] modetest: Add a command line parameter to drop master after mode set

If the -d parameter is specified, modetest will drop master permissions after setting the mode. Signed-off-by: Laurent Pinchart --- tests/modetest/modetest.c | 11 +-- 1 file changed, 9 insertions(+), 2 deletions(-) diff --git a/tests/modetest/modetest.c b/tests/modetest/modetest.c inde

[PATCH v6 04/23] modetest: Add a command line parameter to select the driver

If the -M parameter is specified, modetest will use the requested device name instead of trying its builtin list of device names. Signed-off-by: Laurent Pinchart Reviewed-by: Jani Nikula --- tests/modetest/modetest.c | 50 +-- 1 file changed, 35 inser

[PATCH v6 03/23] modetest: Sort command line arguments

The current mostly random sort order hinders code readability. Sort the options alphabetically in the code, and by group in the help message. Signed-off-by: Laurent Pinchart Reviewed-by: Jani Nikula --- tests/modetest/modetest.c | 49 ++- 1 file chang

[PATCH v6 02/23] modetest: Remove extern declarations of opt(arg|ind|err|opt)

Those variables are declared in unistd.h, there's no need to redeclare them here. Signed-off-by: Laurent Pinchart Reviewed-by: Jani Nikula --- tests/modetest/modetest.c | 2 -- 1 file changed, 2 deletions(-) diff --git a/tests/modetest/modetest.c b/tests/modetest/modetest.c index 47704db..e0d7

[PATCH v6 01/23] modetest: Fix warnings

Enable all standard automake warnings except for -Wpointer-arith (as the test pattern generation code uses void pointer arithmetics) and fix them. Signed-off-by: Laurent Pinchart --- tests/modetest/Makefile.am | 4 +++- tests/modetest/buffers.c | 13 +++-- tests/modetest/buffers.h |

[PATCH v6 00/23] modetest enhancements

Hello, Here's the sixth (and hopefully final) version of my modeset enhancements patch set. Beside various cleanups, these patches allow dropping master after mode set, configuring more than two pipes and planes, setting properties from the command line, setting plane positions and configuring pi

[PATCH v5 23/23] modetest: Allocate NV buffers large enough for the two planes

Multiple the image height by 1.5 for NV12/NV21 and by 2 for NV16/NV61 to make room for the chroma plane. Signed-off-by: Laurent Pinchart --- tests/modetest/buffers.c | 19 ++- 1 file changed, 18 insertions(+), 1 deletion(-) diff --git a/tests/modetest/buffers.c b/tests/modetest/

[PATCH v5 22/23] modetest: Fix line stride in SMPTE YUV packet pattern generator

The line stride passed to the function is expressed in bytes, there's no need to multiply it by 2. Signed-off-by: Laurent Pinchart --- tests/modetest/buffers.c | 12 ++-- 1 file changed, 6 insertions(+), 6 deletions(-) diff --git a/tests/modetest/buffers.c b/tests/modetest/buffers.c ind

[PATCH v5 21/23] modetest: Try all possible encoders for a connector

When building the pipeline, instead of using only the encoders attached to a connector, take all possible encoders into account to locate a CRTC. Signed-off-by: Laurent Pinchart --- tests/modetest/modetest.c | 35 +-- 1 file changed, 25 insertions(+), 10 deletions

[PATCH v5 20/23] modetest: Support pipes with multiple connectors

The -s argument can now take a list of connectors. Configure all of them in cloned mode using a single CRTC. Signed-off-by: Laurent Pinchart --- tests/modetest/modetest.c | 211 ++ 1 file changed, 157 insertions(+), 54 deletions(-) diff --git a/tests/

[PATCH v5 19/23] modetest: Rename struct connector_arg to struct pipe_arg

This prepares the code for handling multiple connectors in a single pipeline in a cloned configuration. Signed-off-by: Laurent Pinchart --- tests/modetest/modetest.c | 162 -- 1 file changed, 85 insertions(+), 77 deletions(-) diff --git a/tests/modete

[PATCH v5 18/23] modetest: Split mode setting and plane setup

There's not reason to require setting a mode to test planes. Split the two operations. Signed-off-by: Laurent Pinchart --- tests/modetest/modetest.c | 106 +++--- 1 file changed, 73 insertions(+), 33 deletions(-) diff --git a/tests/modetest/modetest.c b/t

[PATCH v5 17/23] modetest: Give the CRTC ID to the -P option

Planes are associated with CRTCs, not connectors. Don't try to be too clever, use the CRTC ID in the -P option. This prepares for splitting CRTC and planes setup. Signed-off-by: Laurent Pinchart --- tests/modetest/modetest.c | 32 +--- 1 file changed, 17 insertions(+)

[PATCH v5 16/23] modetest: Store the mode in the crtc structure

This prepares the code for the split in separate functions of CRTC and planes setup. Signed-off-by: Laurent Pinchart --- tests/modetest/modetest.c | 10 -- 1 file changed, 8 insertions(+), 2 deletions(-) diff --git a/tests/modetest/modetest.c b/tests/modetest/modetest.c index e5f12ce..c

[PATCH v5 15/23] modetest: Store the crtc in the connector_arg structure

This prepares the code for the split in separate functions of CRTC and planes setup. Signed-off-by: Laurent Pinchart --- tests/modetest/modetest.c | 58 ++- 1 file changed, 37 insertions(+), 21 deletions(-) diff --git a/tests/modetest/modetest.c b/tes

[PATCH v5 14/23] modetest: Remove the struct connector_arg encoder field

The field is no needed, make it a local variable where used. Signed-off-by: Laurent Pinchart --- tests/modetest/modetest.c | 10 +- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/tests/modetest/modetest.c b/tests/modetest/modetest.c index c4e4dda..a7b8b43 100644 --- a/test

[PATCH v5 13/23] modetest: Compute CRTC pipe number as needed

Signed-off-by: Laurent Pinchart --- tests/modetest/modetest.c | 29 + 1 file changed, 17 insertions(+), 12 deletions(-) diff --git a/tests/modetest/modetest.c b/tests/modetest/modetest.c index 4a6566f..c4e4dda 100644 --- a/tests/modetest/modetest.c +++ b/tests/modetes

[PATCH v5 12/23] modetest: Create a device structure

Instead of passing the device fd and resources as global variables group them in a device structure and pass it explictly to all functions that need it. Signed-off-by: Laurent Pinchart --- tests/modetest/modetest.c | 199 -- 1 file changed, 102 inserti

[PATCH v5 11/23] modetest: Remove the -m argument

The argument isn't used, remove it. Signed-off-by: Laurent Pinchart --- tests/modetest/modetest.c | 10 +++--- 1 file changed, 3 insertions(+), 7 deletions(-) diff --git a/tests/modetest/modetest.c b/tests/modetest/modetest.c index 258b958..b736f2b 100644 --- a/tests/modetest/modetest.c +++

[PATCH v5 10/23] modetest: Print the plane ID when setting up a plane

As modetest automatically selects an unused plan, providing the plane ID allows modifying plane properties for the selected planes. Signed-off-by: Laurent Pinchart --- tests/modetest/modetest.c | 8 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/tests/modetest/modetest.c

[PATCH v5 09/23] modetest: Allow specifying plane position

Extend the -P option to allow specifying the plane x and y offsets. The position is optional, if not specified the plane will be positioned at the center of the screen as before. Signed-off-by: Laurent Pinchart --- tests/modetest/modetest.c | 67 --- 1

[PATCH v5 08/23] modetest: Add a command line parameter to set properties

The -w parameter can be used to set a property value from the command line, using the target object ID and the property name. Signed-off-by: Laurent Pinchart --- tests/modetest/modetest.c | 108 +- 1 file changed, 106 insertions(+), 2 deletions(-) dif

[PATCH v5 07/23] modetest: Don't limit mode set and planes to two instances

Configuring mode on more than two connectors or two planes is perfectly valid. Support it. Signed-off-by: Laurent Pinchart --- tests/modetest/modetest.c | 20 ++-- 1 file changed, 18 insertions(+), 2 deletions(-) diff --git a/tests/modetest/modetest.c b/tests/modetest/modetest.c

[PATCH v5 06/23] modetest: Retrieve all resources in one go

Instead of retrieving resources as they are needed, retrieve them all (except property blobs) in one go at startup. Signed-off-by: Laurent Pinchart --- tests/modetest/modetest.c | 408 +- 1 file changed, 261 insertions(+), 147 deletions(-) diff --git

[PATCH v5 05/23] modetest: Add a command line parameter to drop master after mode set

If the -d parameter is specified, modetest will drop master permissions after setting the mode. Signed-off-by: Laurent Pinchart --- tests/modetest/modetest.c | 11 +-- 1 file changed, 9 insertions(+), 2 deletions(-) diff --git a/tests/modetest/modetest.c b/tests/modetest/modetest.c inde

[PATCH v5 04/23] modetest: Add a command line parameter to select the driver

If the -M parameter is specified, modetest will use the requested device name instead of trying its builtin list of device names. Signed-off-by: Laurent Pinchart Reviewed-by: Jani Nikula --- tests/modetest/modetest.c | 50 --- 1 file changed, 34 inser

[PATCH v5 03/23] modetest: Sort command line arguments

The current mostly random sort order hinders code readability. Sort the options alphabetically in the code, and by group in the help message. Signed-off-by: Laurent Pinchart Reviewed-by: Jani Nikula --- tests/modetest/modetest.c | 49 ++- 1 file chang

[PATCH v5 02/23] modetest: Remove extern declarations of opt(arg|ind|err|opt)

Those variables are declared in unistd.h, there's no need to redeclare them here. Signed-off-by: Laurent Pinchart Reviewed-by: Jani Nikula --- tests/modetest/modetest.c | 2 -- 1 file changed, 2 deletions(-) diff --git a/tests/modetest/modetest.c b/tests/modetest/modetest.c index 47704db..e0d7

[PATCH v5 01/23] modetest: Fix warnings

Enable all standard automake warnings except for -Wpointer-arith (as the test pattern generation code uses void pointer arithmetics) and fix them. Signed-off-by: Laurent Pinchart --- tests/modetest/Makefile.am | 4 +++- tests/modetest/buffers.c | 13 +++-- tests/modetest/buffers.h |

[PATCH v5 00/23] modetest enhancements

Hello, After a (too) long delay here's the fifth version of my modetest enhancements patch set. Beside various cleanups, these patches allow dropping master after mode set, configuring more than two pipes and planes, setting properties from the command line, setting plane positions and configurin

[PATCH RFC 2/8] DRM: Armada: Add Armada DRM driver

On Fri, Jun 14, 2013 at 09:50:22PM +0200, Daniel Vetter wrote: > On Fri, Jun 14, 2013 at 4:42 PM, Russell King - ARM Linux > wrote: > > If you're happy with the patch I supplied, that's probably the minimal fix > > which should go to stable kernels (I'm using 3.9 here) - this also counts > > as a

[PATCH RFC 2/8] DRM: Armada: Add Armada DRM driver

On Fri, Jun 14, 2013 at 4:42 PM, Russell King - ARM Linux wrote: > On Fri, Jun 14, 2013 at 04:23:22PM +0200, Daniel Vetter wrote: >> On Thu, Jun 13, 2013 at 3:03 PM, Russell King - ARM Linux >> wrote: >> > There's a bigger issue here - if it's possible for >> > drm_crtc_helper_set_config() >> >

Re: [PATCH 3/3] i915: Don't provide ACPI backlight interface if firmware expects Windows 8

On Sat, Jun 15, 2013 at 12:14:42PM +0800, Aaron Lu wrote: > On 06/15/2013 09:38 AM, Matthew Garrett wrote: > > Well, Windows 8 will only use the ACPI backlight interface if the GPU > > driver decides to, right? So the logic for deciding whether to remove > > the ACPI backlight control or not should

[PATCH v2 3/4] gpu: host1x: add runtime pm support for dc

On Friday 14 June 2013 12:39 AM, Stephen Warren wrote: > On 06/13/2013 12:49 PM, Thierry Reding wrote: >> On Thu, Jun 13, 2013 at 03:23:37PM +0530, Mayuresh Kulkarni wrote: >> [...] >>> diff --git a/drivers/gpu/host1x/drm/dc.c >>> b/drivers/gpu/host1x/drm/dc.c >> [...] >>> @@ -1128,9 +1129,7 @@ sta

[PATCH v2 2/4] gpu: host1x: add runtime pm support for gr2d

On Thursday 13 June 2013 08:44 PM, Stephen Warren wrote: > On 06/13/2013 03:53 AM, Mayuresh Kulkarni wrote: > > Patch description? I thought the patch subject is sufficient to tell what it is it doing. Description here would be repetition in my opinion. Also, the cover letter for the patch-set s

[Bug 65438] GTK apps crash X11 since last update of LLVMM

ttp://lists.freedesktop.org/archives/dri-devel/attachments/20130614/a6c261df/attachment-0001.html>

[Bug 65723] Xonotic glsl 1.30 broken due to lack of derivatives support in radeonsi

was scrubbed... URL: <http://lists.freedesktop.org/archives/dri-devel/attachments/20130614/fac6c0f7/attachment.html>

[PATCH] drm/exynos: make sure to handle an error case to vm_mmap call

vm_mmap function returns unsigned long so addr type should be unsigned long. a pointer or address variable is required to use unsigned long or uint64_t type for 64bits address support. So this patch makes sure that addr has unsigned long type and also exynos_drm_gem_mmap_ioctl returns correct erro

[Bug 65730] no sound via HDMI for Radeon 6850 mesa driver

is one for now. Thanks for the assistance. -- You are receiving this mail because: You are the assignee for the bug. -- next part -- An HTML attachment was scrubbed... URL: <http://lists.freedesktop.org/archives/dri-devel/attachments/20130614/5b31208d/attachment.html>

[PATCH 3/3] i915: Don't provide ACPI backlight interface if firmware expects Windows 8

On Fri, 2013-06-14 at 14:47 +0800, Aaron Lu wrote: > What about a priority based solution? We can introduce a new field named > priority to backlight_device and instead of calling another module's > function like the unregister one here(which cause unnecessary module > dependency), we only need to

[pull] radeon drm-fixes-3.10

Hi Dave, I added one more patch on top if it's not too late. It's a fix for UVD on big endian: drm/radeon: fix UVD on big endian This fixes the kernel side so that the ring should come up and ring and IB tests should work. The userspace UVD drivers will also need big endian fixes. Signed-off

[PATCH RFC 2/8] DRM: Armada: Add Armada DRM driver

On Thu, Jun 13, 2013 at 3:03 PM, Russell King - ARM Linux wrote: > On Thu, Jun 13, 2013 at 12:50:16PM +0100, Russell King - ARM Linux wrote: >> On Thu, Jun 13, 2013 at 12:19:03PM +0100, Russell King - ARM Linux wrote: >> > The deeper I look, the more bugs there seem to be in this DRM stuff, >> > a

[PATCH 7/9] drm/exynos: use of_get_named_gpio to get hdmi hpd gpio

Hello Rahul, this patch is not related with others and it looks good to me. On 2013? 06? 11? 23:11, Rahul Sharma wrote: > Cleanup by removing flags variable from drm_hdmi_dt_parse_pdata > which is not used anywhere. Swtiching to of_get_named_gpio instead > of of_get_named_gpio_flags solved this.

[PATCH 5/9] drm/exynos: add support for exynos5420 mixer

Hello Rahul, This patch looks good to me just with mixer part of 2nd patch because there is no hdmiphy related things. On 2013? 06? 11? 23:11, Rahul Sharma wrote: > Add support for exynos5420 mixer IP in the drm mixer driver. > > Signed-off-by: Rahul Sharma > --- > drivers/gpu/drm/exynos/exyno

[PATCH v3] drm: Renesas R-Car Display Unit DRM driver

On Fri, Jun 14, 2013 at 02:54:04AM +0200, Laurent Pinchart wrote: > Hi Daniel, > > On Friday 07 June 2013 10:50:55 Daniel Vetter wrote: > > On Fri, Jun 07, 2013 at 09:44:45AM +0200, Laurent Pinchart wrote: > > > On Wednesday 05 June 2013 10:55:05 Daniel Vetter wrote: > > > > On Wed, Jun 05, 2013 a

[PATCH RFC 2/8] DRM: Armada: Add Armada DRM driver

On Thu, Jun 13, 2013 at 12:50:16PM +0100, Russell King - ARM Linux wrote: > On Thu, Jun 13, 2013 at 12:19:03PM +0100, Russell King - ARM Linux wrote: > > The deeper I look, the more bugs there seem to be in this DRM stuff, > > and I'm continuing to look because I'm chasing a framebuffer refcount >

[PATCH 1/9] drm/exynos: use SoC name to identify hdmi version

Hello Rahul, On 2013? 06? 11? 23:11, Rahul Sharma wrote: > Exynos hdmi IP version is named after hdmi specification version i.e. > 1.3 and 1.4. This versioning mechanism is not sufficient to handle > the diversity in the hdmi/phy IPs which are present across the exynos > SoC family. > > This patc

[PATCH RFC 2/8] DRM: Armada: Add Armada DRM driver

On Fri, Jun 14, 2013 at 04:23:22PM +0200, Daniel Vetter wrote: > On Thu, Jun 13, 2013 at 3:03 PM, Russell King - ARM Linux > wrote: > > There's a bigger issue here - if it's possible for > > drm_crtc_helper_set_config() > > to be called with set->fb set but set->mode NULL, then we overwrite > > s

[PATCH 0/5] clk/exynos5250: add clocks for hdmi subsystem

Hi, Tested this series on snow board and is working fine. Tested-by: Arun Kumar K Regards Arun On Mon, Jun 10, 2013 at 4:30 PM, Rahul Sharma wrote: > Add clock changes for hdmi subsystem for exynos5250 SoC. These > include addition of new clocks like mout_hdmi and smmu_tv, associating > ID to

Re: [PATCH RFC 2/8] DRM: Armada: Add Armada DRM driver

On Sat, Jun 15, 2013 at 12:15 AM, Russell King - ARM Linux wrote: > On Fri, Jun 14, 2013 at 09:50:22PM +0200, Daniel Vetter wrote: >> On Fri, Jun 14, 2013 at 4:42 PM, Russell King - ARM Linux >> wrote: >> > If you're happy with the patch I supplied, that's probably the minimal fix >> > which shou

[PATCH RFC 2/8] DRM: Armada: Add Armada DRM driver

On Fri, Jun 14, 2013 at 03:53:41PM +0200, Daniel Vetter wrote: > On Thu, Jun 13, 2013 at 12:50:16PM +0100, Russell King - ARM Linux wrote: > > On Thu, Jun 13, 2013 at 12:19:03PM +0100, Russell King - ARM Linux wrote: > > > The deeper I look, the more bugs there seem to be in this DRM stuff, > > > a

[PATCH 6/6] drm: fix fb leak in setcrtc

Drivers are allowed (actually have to) disable unrelated crtcs in their ->set_config callback (when we steal all the connectors from that crtc). If they do that they'll clear crtc->fb to NULL. Which results in a refcount leak, since the drm core is keeping track of that reference. To fix this tra

[PATCH 5/6] drm: check that ->set_config properly updates the fb

Historically drm lacked fb refcounting, so the updating of crtc->fb was done by the lower levels at a point convenient to get their own refcounting (e.g. refcounts for the underlying gem bo, pinning refcounts) right. With the introduction of refcounted fbs the drm core handled the fb refcounts, but

[PATCH 4/6] drm/crtc-helper: don't disable disconnected outputs

This has originally been added in commit a3a0544b2c84e1d7a2022b558ecf66d8c6a8dd93 Author: Dave Airlie Date: Mon Aug 31 15:16:30 2009 +1000 drm/kms: add explicit encoder disable function and detach harder. I think it's the wrong thing to do for a few reasons: - It's policy in the kernel. U

[PATCH 3/6] drm/crtc-helper: explicit DPMS on after modeset

Atm the crtc helper implementation of set_config has really inconsisten semantics: If just an fb update is good enough, dpms state will be left as-is, but if we do a full modeset we force everything to dpms on. This change has already been applied to the i915 modeset code in commit e3de42b68478a8

[PATCH 2/6] drm/crtc-helper: no need to check for fb->depth/bpp

... since we already check for fb->pixel_format, which encodes all this. The other two fields are only for backwards compat of older drivers (and we might want to look into eventually just killing them). Signed-off-by: Daniel Vetter --- drivers/gpu/drm/drm_crtc_helper.c |5 - 1 file chan

[PATCH 1/6] drm/crtc-helpers: Enforce sane set_config api

There's no point in trying to clean up after driver-bugs, so just blow up. Furthermore it's an interface abuse to set no mode but have an fb and aslo to try to set an fb without enough connectors. These two spefici cases of interface abuse have been committed by the fb helper, but that's been fixed

[PATCH 0/6] fb refcount and crtc helper patches

Hi all, Russell found a refcount bug in my fb refcounting conversion, but to also fix i915.ko I've opted for a slightly different approach. While at it I've thought it would be good to backport some of the semantic changes we've implented in i915's ->set_config callback since we've forked our own

[RFC 0/2] exynos5250/hdmi: replace dummy hdmiphy clock with pmu reg control

Hello Kishon, On 2013? 06? 13? 21:54, Kishon Vijay Abraham I wrote: > Hi, > > On Thursday 13 June 2013 04:51 PM, Inki Dae wrote: >> >> >>> -Original Message- >>> From: Sylwester Nawrocki [mailto:s.nawrocki at samsung.com] >>> Sent: Thursday, June 13, 2013 5:56 PM >>> To: Rahul Sharma >>>

[PATCH v6 23/23] modetest: Allocate NV buffers large enough for the two planes

Multiple the image height by 1.5 for NV12/NV21 and by 2 for NV16/NV61 to make room for the chroma plane. Signed-off-by: Laurent Pinchart --- tests/modetest/buffers.c | 19 ++- 1 file changed, 18 insertions(+), 1 deletion(-) diff --git a/tests/modetest/buffers.c b/tests/modetest/

[PATCH v6 22/23] modetest: Fix line stride in SMPTE YUV packet pattern generator

The line stride passed to the function is expressed in bytes, there's no need to multiply it by 2. Signed-off-by: Laurent Pinchart --- tests/modetest/buffers.c | 12 ++-- 1 file changed, 6 insertions(+), 6 deletions(-) diff --git a/tests/modetest/buffers.c b/tests/modetest/buffers.c ind

[PATCH v6 21/23] modetest: Try all possible encoders for a connector

When building the pipeline, instead of using only the encoders attached to a connector, take all possible encoders into account to locate a CRTC. Signed-off-by: Laurent Pinchart --- tests/modetest/modetest.c | 35 +-- 1 file changed, 25 insertions(+), 10 deletions

[PATCH v6 20/23] modetest: Support pipes with multiple connectors

The -s argument can now take a list of connectors. Configure all of them in cloned mode using a single CRTC. Signed-off-by: Laurent Pinchart --- tests/modetest/modetest.c | 211 ++ 1 file changed, 157 insertions(+), 54 deletions(-) diff --git a/tests/

[PATCH v6 19/23] modetest: Rename struct connector_arg to struct pipe_arg

This prepares the code for handling multiple connectors in a single pipeline in a cloned configuration. Signed-off-by: Laurent Pinchart --- tests/modetest/modetest.c | 162 -- 1 file changed, 85 insertions(+), 77 deletions(-) diff --git a/tests/modete

[PATCH v6 17/23] modetest: Give the CRTC ID to the -P option

Planes are associated with CRTCs, not connectors. Don't try to be too clever, use the CRTC ID in the -P option. This prepares for splitting CRTC and planes setup. Signed-off-by: Laurent Pinchart --- tests/modetest/modetest.c | 32 +--- 1 file changed, 17 insertions(+)

[PATCH v6 18/23] modetest: Split mode setting and plane setup

There's not reason to require setting a mode to test planes. Split the two operations. Signed-off-by: Laurent Pinchart --- tests/modetest/modetest.c | 104 -- 1 file changed, 72 insertions(+), 32 deletions(-) diff --git a/tests/modetest/modetest.c b/t

[PATCH v6 16/23] modetest: Store the mode in the crtc structure

This prepares the code for the split in separate functions of CRTC and planes setup. Signed-off-by: Laurent Pinchart --- tests/modetest/modetest.c | 10 -- 1 file changed, 8 insertions(+), 2 deletions(-) diff --git a/tests/modetest/modetest.c b/tests/modetest/modetest.c index 6fbaf09..3

[PATCH v6 15/23] modetest: Store the crtc in the connector_arg structure

This prepares the code for the split in separate functions of CRTC and planes setup. Signed-off-by: Laurent Pinchart --- tests/modetest/modetest.c | 58 ++- 1 file changed, 37 insertions(+), 21 deletions(-) diff --git a/tests/modetest/modetest.c b/tes

[PATCH v6 14/23] modetest: Remove the struct connector_arg encoder field

The field is no needed, make it a local variable where used. Signed-off-by: Laurent Pinchart --- tests/modetest/modetest.c | 10 +- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/tests/modetest/modetest.c b/tests/modetest/modetest.c index a1a683f..2c3e093 100644 --- a/test

[PATCH v6 13/23] modetest: Compute CRTC pipe number as needed

Signed-off-by: Laurent Pinchart --- tests/modetest/modetest.c | 29 + 1 file changed, 17 insertions(+), 12 deletions(-) diff --git a/tests/modetest/modetest.c b/tests/modetest/modetest.c index cfcb989..a1a683f 100644 --- a/tests/modetest/modetest.c +++ b/tests/modetes

[PATCH v6 12/23] modetest: Create a device structure

Instead of passing the device fd and resources as global variables group them in a device structure and pass it explictly to all functions that need it. Signed-off-by: Laurent Pinchart --- tests/modetest/modetest.c | 201 -- 1 file changed, 103 inserti

[PATCH v6 11/23] modetest: Remove the -m argument

The argument isn't used, remove it. Signed-off-by: Laurent Pinchart --- tests/modetest/modetest.c | 10 +++--- 1 file changed, 3 insertions(+), 7 deletions(-) diff --git a/tests/modetest/modetest.c b/tests/modetest/modetest.c index 7f7a3a2..89bfc53 100644 --- a/tests/modetest/modetest.c +++

[PATCH v6 10/23] modetest: Print the plane ID when setting up a plane

As modetest automatically selects an unused plan, providing the plane ID allows modifying plane properties for the selected planes. Signed-off-by: Laurent Pinchart --- tests/modetest/modetest.c | 8 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/tests/modetest/modetest.c

[PATCH v6 09/23] modetest: Allow specifying plane position

Extend the -P option to allow specifying the plane x and y offsets. The position is optional, if not specified the plane will be positioned at the center of the screen as before. Signed-off-by: Laurent Pinchart --- tests/modetest/modetest.c | 67 --- 1

[PATCH v6 08/23] modetest: Add a command line parameter to set properties

The -w parameter can be used to set a property value from the command line, using the target object ID and the property name. Signed-off-by: Laurent Pinchart --- tests/modetest/modetest.c | 108 +- 1 file changed, 106 insertions(+), 2 deletions(-) dif

[PATCH v6 07/23] modetest: Don't limit mode set and planes to two instances

Configuring mode on more than two connectors or two planes is perfectly valid. Support it. Signed-off-by: Laurent Pinchart --- tests/modetest/modetest.c | 20 ++-- 1 file changed, 18 insertions(+), 2 deletions(-) diff --git a/tests/modetest/modetest.c b/tests/modetest/modetest.c

[PATCH v6 06/23] modetest: Retrieve all resources in one go

Instead of retrieving resources as they are needed, retrieve them all (except property blobs) in one go at startup. Signed-off-by: Laurent Pinchart --- tests/modetest/modetest.c | 408 +- 1 file changed, 261 insertions(+), 147 deletions(-) diff --git

[PATCH v6 05/23] modetest: Add a command line parameter to drop master after mode set

If the -d parameter is specified, modetest will drop master permissions after setting the mode. Signed-off-by: Laurent Pinchart --- tests/modetest/modetest.c | 11 +-- 1 file changed, 9 insertions(+), 2 deletions(-) diff --git a/tests/modetest/modetest.c b/tests/modetest/modetest.c inde

[PATCH v6 03/23] modetest: Sort command line arguments

The current mostly random sort order hinders code readability. Sort the options alphabetically in the code, and by group in the help message. Signed-off-by: Laurent Pinchart Reviewed-by: Jani Nikula --- tests/modetest/modetest.c | 49 ++- 1 file chang

[PATCH 3/3] i915: Don't provide ACPI backlight interface if firmware expects Windows 8

On 06/10/2013 07:01 AM, Matthew Garrett wrote: > Windows 8 leaves backlight control up to individual graphics drivers rather > than making ACPI calls itself. There's plenty of evidence to suggest that > the Intel driver for Windows doesn't use the ACPI interface, including the > fact that it's brok

[PATCH v6 04/23] modetest: Add a command line parameter to select the driver

If the -M parameter is specified, modetest will use the requested device name instead of trying its builtin list of device names. Signed-off-by: Laurent Pinchart Reviewed-by: Jani Nikula --- tests/modetest/modetest.c | 50 +-- 1 file changed, 35 inser

  1   2   >