[PATCH] ARM: add get_user() support for 8 byte types

2012-11-12 Thread Russell King - ARM Linux
On Mon, Nov 12, 2012 at 05:33:41PM -0600, Rob Clark wrote: > I'm sort of thinking maybe we want to change 'switch (sizeof(*(__p)))' > with 'switch (sizeof(typeof(x)))' in case someone ignores the compiler > warning when they try something like: Definitely not. Ttype of access is controlled by the

i915 hang and large allocation (~3.7-rc4)

2012-11-12 Thread Daniel Vetter
On Mon, Nov 12, 2012 at 02:44:46PM -0800, Dave Hansen wrote: > I've been seeing a little goofiness with i915 video under the 3.7-rc's. > It looks like I'm seeing two separate issues. One, that the video > hardware hangs, spits some errors in dmesg, and then video acceleration > seems to stop worki

Re: [PATCH] ARM: add get_user() support for 8 byte types

2012-11-12 Thread Russell King - ARM Linux
On Mon, Nov 12, 2012 at 05:33:41PM -0600, Rob Clark wrote: > I'm sort of thinking maybe we want to change 'switch (sizeof(*(__p)))' > with 'switch (sizeof(typeof(x)))' in case someone ignores the compiler > warning when they try something like: Definitely not. Ttype of access is controlled by the

Re: [PATCH] ARM: add get_user() support for 8 byte types

2012-11-12 Thread Russell King - ARM Linux
On Mon, Nov 12, 2012 at 01:58:32PM -0600, Rob Clark wrote: > On Mon, Nov 12, 2012 at 1:27 PM, Russell King - ARM Linux > wrote: > > On Fri, Nov 09, 2012 at 03:17:33PM -0600, Rob Clark wrote: > >> From: Rob Clark > >> > >> A new atomic modeset/pageflip ioctl being developed in DRM requires > >> ge

i915 hang and large allocation (~3.7-rc4)

2012-11-12 Thread Dave Hansen
I've been seeing a little goofiness with i915 video under the 3.7-rc's. It looks like I'm seeing two separate issues. One, that the video hardware hangs, spits some errors in dmesg, and then video acceleration seems to stop working. Two, when it does this, apport goes digging in debugfs for infor

Re: Fix for vblank on nvc0

2012-11-12 Thread Kelly Doran
I had Sven test this patch... he said it works. I think chipset number test was executing code that we thought was only either 0x50 or 0xc0, but was actually more specific with things like 0x92. On Sun, Nov 11, 2012 at 2:25 PM, Maarten Lankhorst wrote: > Op 11-11-12 19:35, Marcin Slusarz schreef

Re: [PATCH] ARM: add get_user() support for 8 byte types

2012-11-12 Thread Russell King - ARM Linux
On Fri, Nov 09, 2012 at 03:17:33PM -0600, Rob Clark wrote: > From: Rob Clark > > A new atomic modeset/pageflip ioctl being developed in DRM requires > get_user() to work for 64bit types (in addition to just put_user()). NAK. (I did write a better email explaining all the ins and outs of why thi

Re: [PATCH v8 2/6] video: add of helper for videomode

2012-11-12 Thread Alexey Klimov
Hello Steffen, On Mon, Nov 12, 2012 at 7:37 PM, Steffen Trumtrar wrote: > This adds support for reading display timings from DT or/and convert one of > those > timings to a videomode. > The of_display_timing implementation supports multiple children where each > property can have up to 3 values.

Re: [PATCH] ARM: add get_user() support for 8 byte types

2012-11-12 Thread Will Deacon
On Mon, Nov 12, 2012 at 01:46:57PM +, Rob Clark wrote: > On Mon, Nov 12, 2012 at 4:46 AM, Will Deacon wrote: > > On Fri, Nov 09, 2012 at 09:17:33PM +, Rob Clark wrote: > >> @@ -122,22 +124,35 @@ extern int __get_user_4(void *); > >> ({

[PATCH] drm: fix drm_framebuffer cleanup.

2012-11-12 Thread Inki Dae
y idea AND the > reason I > > > > posted this patch. > > > > Original codes, > > > > gem alloc(gem0); > > > > -> gem0 refcount = 1 > > > > gem0 mmap > > > > -> gem0 refcount = 2 > > > > gem alloc(gem1); > > > > -> gem1 refcount =1 > > > > gem1 mmap > > > > -> gem1 refcount =2 > > > > addfb(fb0, gem0); > > > > -> gem0 refcount=3 > > > > addfb(fb1,gem1); > > > > -> gem1 refcount = 3 > > > > setcrtc(fb0, crtc0) > > > > -> crtc0.fb = fb0 > > > > pageflip(crtc0, fb1); > > > > -> crtc0.fb = fb1. > > > > and pageflip is repeated > > > > > > > > close(gem0) > > > > -> gem0 refcount = 2 > > > > close(gem1) > > > > ->gem1 refcount = 2 > > > > munmap(gem0) > > > > ->gem0 refcount = 1 > > > > munmap(gem1) > > > > ->gem1 refcount = 1 > > > > > > > > close(drm) > > > > 1. fb release > > > > -> check if crtc->fb is same as fb0 but current crtc is pointing to > fb1 > > > > 2. so free fb0 without disabling current crtc. > > > > -> gem0 refcount = 0 so released. At this time, dma access invalid > memory > > > > region unfortunately* *if the dma is accessing gem0. > > > > > > > > > > > > > > > > With my patch, > > > > ... > > > > setcrtc(fb0, crtc0) > > > > -> crtc0.fb = fb0, fb0.crtc = crtc0 > > > > pageflip(crtc0, fb1); > > > > -> crtc0.fb = fb1, fb1.crtc = crtc0. > > > > and pageflip is repeated > > > > > > > > close(gem0) > > > > -> gem0 refcount = 2 > > > > close(gem1) > > > > ->gem1 refcount = 2 > > > > munmap(gem0) > > > > ->gem0 refcount = 1 > > > > munmap(gem1) > > > > ->gem1 refcount = 1 > > > > close(drm) > > > > 1. fb release > > > > -> fb0->crtc is same as crtc so disable crtc (dma stop) > > > > > > No, that's wrong. The current fb is fb1, so destroying fb0 must not > > > disable the crtc. > > > > > > > > Do you think this is wrong that when fb0 is destroyed, the crtc also is > > disabled and crtc is pointing to fb1? > > Yes. You must disable the crtc if and only if you destroy the current > fb. Current fb means the fb specified by the latest setcrtc or pageflip > ioctl. Destroying any other fb must not affect the crtc. And this is > exactly what the current code does. > > Right, I realized that there was my missing point though your comment. I thought that current fb would be set to crtc->fb only if setmode request. But page flip request also did it(by specific driver's page flip function). Now Exynos driver has one problem. that is to set current fb to crtc->fb after drm_vblank_get call . This could induce invalid memory access like below, crtc0's current fb is fb0 page flip request(crtc0, fb1) 1. drm_vblank_get call 2. vsync occurs and the dma access memory region to fb0 yet. 3. crtc0->fb = fb1 3. drm is released 4. crtc's current fb is fb1 but the dma is accessing memory region to fb0 yet because vsync doesn't occur so fb0 doesn't disable crtc and releses its own gem buffer. This would induce the problem and definitely is a bug. For this, I will fix it as soon as possible after testing. > > And in case of Exynos driver, > > disabling the crtc would disable hardware overlay so other overlays would > > be holded on as is. This is just Exynos case so I don't know how other > SoCs > > are operated. Could you explain how Desktop side is operated? Maybe there > > is my missing point here. > > I'm not sure what you're asking. > > > Are you asking how other drivers know know when it's safe to free the > memory? Well, the usual method is to track the page flips via some > suitable interrupts. A reference is kept to the memory until it's safe > to get rid of it. > > Or are you asking what should happen when a crtc is disabled? Then my > answer is that when a crtc is disabled, there must be no output signal > whatsoever. > > It's an unfortunate design bug that we even have the fb->crtc link. > Ideally it would not exist, and all scanout duties would be handled > by planes. Then destroying fbs would never disable the crtc completely, > just the planes scanning from those fbs. > > Understood. And I'd like to say thank you again. Your comment is very helpful to me. Thanks, Inki Dae > -- > Ville Syrj?l? > Intel OTC > ___ > dri-devel mailing list > dri-devel at lists.freedesktop.org > http://lists.freedesktop.org/mailman/listinfo/dri-devel > -- next part -- An HTML attachment was scrubbed... URL: <http://lists.freedesktop.org/archives/dri-devel/attachments/20121112/97b898d4/attachment-0001.html>

[Bug 56139] [bisected] kernel 3.7.0-rc1 breaks 6950 (boot/grub2 and suspend/resume) (CAYMAN)

2012-11-12 Thread bugzilla-dae...@freedesktop.org
sktop.org/archives/dri-devel/attachments/20121112/28b0f9a9/attachment.html>

[PATCH] ARM: add get_user() support for 8 byte types

2012-11-12 Thread Russell King - ARM Linux
On Mon, Nov 12, 2012 at 01:58:32PM -0600, Rob Clark wrote: > On Mon, Nov 12, 2012 at 1:27 PM, Russell King - ARM Linux > wrote: > > On Fri, Nov 09, 2012 at 03:17:33PM -0600, Rob Clark wrote: > >> From: Rob Clark > >> > >> A new atomic modeset/pageflip ioctl being developed in DRM requires > >> ge

[PATCH v8 2/6] video: add of helper for videomode

2012-11-12 Thread Alexey Klimov
Hello Steffen, On Mon, Nov 12, 2012 at 7:37 PM, Steffen Trumtrar wrote: > This adds support for reading display timings from DT or/and convert one of > those > timings to a videomode. > The of_display_timing implementation supports multiple children where each > property can have up to 3 values.

[PATCH v2 2/2] drm: tegra: Add HDMI support

2012-11-12 Thread Thierry Reding
This commit adds support for the HDMI output on the Tegra20 SoC. Only one such output is available, but it can be driven by either of the two display controllers. A lot of work on this patch has been contributed by NVIDIA's Mark Zhang and many other people at NVIDIA were very helpful in getting t

[PATCH v2 1/2] drm: Add NVIDIA Tegra20 support

2012-11-12 Thread Thierry Reding
This commit adds a KMS driver for the Tegra20 SoC. This includes basic support for host1x and the two display controllers found on the Tegra20 SoC. Each display controller can drive a separate RGB/LVDS output. Signed-off-by: Thierry Reding --- Changes in v2: - drop Linux-specific drm subdirectory

[PATCH v2 0/2] NVIDIA Tegra DRM driver

2012-11-12 Thread Thierry Reding
This second version of this patch series addresses all the comments received so far. Most notably it takes advantage of the debugfs helpers provided by the DRM core. Oddly enough this actually increases the line count, but that's because the helpers don't fit with the subdevices approach as impleme

Fix for vblank on nvc0

2012-11-12 Thread Maarten Lankhorst
Op 12-11-12 22:30, Kelly Doran schreef: > I had Sven test this patch... he said it works. I think chipset > number test was executing code that we thought was only either 0x50 or > 0xc0, but was actually more specific with things like 0x92. > Oh right vblank is busted anyway... needs to be nv_devi

WARNING: at drivers/gpu/drm/i915/intel_display.c:1009 ironlake_crtc_disable+0xaf/0x8e0

2012-11-12 Thread Meelis Roos
I tried 3.7-rc5 on an ironlale PC and got the warning in subject. The computer last ran 3.6.0 without any warnings. Second reboot showed the same warning plus a couple of EDID warnings (also below). [0.00] Linux version 3.7.0-rc5 (mroos at prometheus) (gcc version 4.7.2 (Debian 4.7.2-4

[Bug 56878] FireGL Mobility T2: WebGL under firefox16 freezes system

2012-11-12 Thread bugzilla-dae...@freedesktop.org
ssignee for the bug. -- next part -- An HTML attachment was scrubbed... URL: <http://lists.freedesktop.org/archives/dri-devel/attachments/20121112/41143a98/attachment.html>

[PATCH v8 2/6] video: add of helper for videomode

2012-11-12 Thread Sascha Hauer
Hi Steffen, You lose memory in several places: On Mon, Nov 12, 2012 at 04:37:02PM +0100, Steffen Trumtrar wrote: > +static struct display_timing *of_get_display_timing(struct device_node *np) > +{ > + struct display_timing *dt; > + int ret = 0; > + > + dt = kzalloc(sizeof(*dt), GFP_KE

[Bug 49981] [drm:radeon_cs_ioctl] *ERROR* Failed to parse relocation -12!

2012-11-12 Thread bugzilla-dae...@bugzilla.kernel.org
https://bugzilla.kernel.org/show_bug.cgi?id=49981 --- Comment #3 from nudelsuppe1982 at gmx.de 2012-11-12 19:43:50 --- Created an attachment (id=86191) --> (https://bugzilla.kernel.org/attachment.cgi?id=86191) 3.7rc5 dmesg -- Configure bugmail: https://bugzilla.kernel.org/userprefs.cgi?tab

[Bug 49981] [drm:radeon_cs_ioctl] *ERROR* Failed to parse relocation -12!

2012-11-12 Thread bugzilla-dae...@bugzilla.kernel.org
https://bugzilla.kernel.org/show_bug.cgi?id=49981 nudelsuppe1982 at gmx.de changed: What|Removed |Added CC||nudelsuppe1982 at gmx.de --

[Bug 56878] FireGL Mobility T2: WebGL under firefox16 freezes system

2012-11-12 Thread bugzilla-dae...@freedesktop.org
receiving this mail because: You are the assignee for the bug. -- next part -- An HTML attachment was scrubbed... URL: <http://lists.freedesktop.org/archives/dri-devel/attachments/20121112/f0d31d8b/attachment.html>

[PATCH 22/22] drm/i915: Add debug print for flip queue length

2012-11-12 Thread ville.syrj...@linux.intel.com
From: Ville Syrj?l? Print some information on how many flips are in the queue waiting for the GPU. There's no limit on the queue length currently. Signed-off-by: Ville Syrj?l? --- drivers/gpu/drm/i915/i915_drv.h |1 + drivers/gpu/drm/i915/intel_atomic.c |4 2 files changed, 5

[PATCH 21/22] HACK: drm/i915: Make non-blocking GPU synchronization optional

2012-11-12 Thread ville.syrj...@linux.intel.com
From: Ville Syrj?l? Add a module parameter that allows one to easily change between blocking and non-blocking GPU synchronization with atomic page flips. Signed-off-by: Ville Syrj?l? --- drivers/gpu/drm/drm_stub.c |5 + drivers/gpu/drm/i915/intel_atomic.c | 10 +- 2

[PATCH 20/22] drm/i915: Implement a non-blocking GPU synchronization mechanism for atomic page flips

2012-11-12 Thread ville.syrj...@linux.intel.com
From: Ville Syrj?l? After the atomic flip has been split up into individual flip requests for each scanout engine, put each such request into a FIFO. Then for each flip request add new request to the ring(s) in order to get an interrupt once the GPU has finished whatever it was doing with the new

[PATCH 19/22] drm: Reject addfb2 with undefined flags bits

2012-11-12 Thread ville.syrj...@linux.intel.com
From: Ville Syrj?l? Signed-off-by: Ville Syrj?l? --- drivers/gpu/drm/drm_crtc.c |5 + 1 files changed, 5 insertions(+), 0 deletions(-) diff --git a/drivers/gpu/drm/drm_crtc.c b/drivers/gpu/drm/drm_crtc.c index 9836755..5f8dda8 100644 --- a/drivers/gpu/drm/drm_crtc.c +++ b/drivers/gpu/d

[PATCH 18/22] drm/i915: Unpin old fbs only when appropriate

2012-11-12 Thread ville.syrj...@linux.intel.com
From: Ville Syrj?l? Don't unpin the old fb after flips, unless a new fb was pinned, or we're disabling the plane/crtc. Signed-off-by: Ville Syrj?l? --- drivers/gpu/drm/i915/intel_atomic.c |8 ++-- 1 files changed, 6 insertions(+), 2 deletions(-) diff --git a/drivers/gpu/drm/i915/intel

[PATCH 17/22] drm/i915: Send atomic completion events even if nothing changed

2012-11-12 Thread ville.syrj...@linux.intel.com
From: Ville Syrj?l? Signed-off-by: Ville Syrj?l? --- drivers/gpu/drm/i915/intel_atomic.c |8 +--- 1 files changed, 5 insertions(+), 3 deletions(-) diff --git a/drivers/gpu/drm/i915/intel_atomic.c b/drivers/gpu/drm/i915/intel_atomic.c index bfc0563..a119896 100644 --- a/drivers/gpu/drm

[PATCH 16/22] drm/i915: Fix plane src rectangle dirty check

2012-11-12 Thread ville.syrj...@linux.intel.com
From: Ville Syrj?l? Signed-off-by: Ville Syrj?l? --- drivers/gpu/drm/i915/intel_atomic.c |6 +++--- 1 files changed, 3 insertions(+), 3 deletions(-) diff --git a/drivers/gpu/drm/i915/intel_atomic.c b/drivers/gpu/drm/i915/intel_atomic.c index c4cec40..bfc0563 100644 --- a/drivers/gpu/drm/i

[PATCH 15/22] drm/i915: Fix hiding the cursor with atomic ioctl

2012-11-12 Thread ville.syrj...@linux.intel.com
From: Ander Conselvan de Oliveira intel_crtc->cursor_visible is only changed on the commit phase, so the check for visibility was considering the previous state. Change this to intel_crtc->cursor_handle instead. --- drivers/gpu/drm/i915/intel_atomic.c |2 +- 1 files changed, 1 insertions(+),

[PATCH 14/22] drm/i915: Fix sprite_scaling_enabled for multiple sprites

2012-11-12 Thread ville.syrj...@linux.intel.com
From: Ville Syrj?l? We have more than one sprite, so a boolean simply won't cut it. Turn sprite_scaling_enabled into a bitmask and track the state of sprite scaler for each sprite independently. Signed-off-by: Ville Syrj?l? --- drivers/gpu/drm/i915/i915_drv.h |2 +- drivers/gpu/drm/i91

[PATCH 13/22] drm/i915: Don't mark cursor as pinned, when we don't have a cursor bo

2012-11-12 Thread ville.syrj...@linux.intel.com
From: Ville Syrj?l? Avoids a NULL pointer dereference if the atomic modeset fails. Signed-off-by: Ville Syrj?l? --- drivers/gpu/drm/i915/intel_atomic.c |3 ++- 1 files changed, 2 insertions(+), 1 deletions(-) diff --git a/drivers/gpu/drm/i915/intel_atomic.c b/drivers/gpu/drm/i915/intel_a

[PATCH 12/22] drm/i915: Kill the pending_flip counter manipulations

2012-11-12 Thread ville.syrj...@linux.intel.com
From: Ville Syrj?l? The pending_flip counter is probably going to be remove entirely, along with i915_gem_execbuffer_wait_for_flips() so don't even try to use it. Signed-off-by: Ville Syrj?l? --- drivers/gpu/drm/i915/intel_atomic.c | 74 +-- 1 files changed, 2

[PATCH 11/22] drm/i915: Update connector DPMS state after an atomic modeset

2012-11-12 Thread ville.syrj...@linux.intel.com
From: Ville Syrj?l? Update the connector DPMS state after atomic modeset operations. Signed-off-by: Ville Syrj?l? --- drivers/gpu/drm/i915/intel_atomic.c | 31 +++ 1 files changed, 31 insertions(+), 0 deletions(-) diff --git a/drivers/gpu/drm/i915/intel_atomic.c

[PATCH 10/22] drm/i915: Update new_crtc and new_encoder fields after atomic modeset

2012-11-12 Thread ville.syrj...@linux.intel.com
From: Ville Syrj?l? The i915 modeset logic requires that these be kept in sync with the other crtc and encoder pointers. Signed-off-by: Ville Syrj?l? --- drivers/gpu/drm/i915/intel_atomic.c |2 ++ drivers/gpu/drm/i915/intel_display.c |2 +- drivers/gpu/drm/i915/intel_drv.h |2

[PATCH 09/22] drm/i915: Use intel_best_encoder() directly

2012-11-12 Thread ville.syrj...@linux.intel.com
From: Ville Syrj?l? All connectors use intel_best_encoder() as their best_encoder() func, so just call it directly w/o the indirection. Signed-off-by: Ville Syrj?l? --- drivers/gpu/drm/i915/intel_atomic.c | 10 ++ 1 files changed, 2 insertions(+), 8 deletions(-) diff --git a/drivers

[PATCH 08/22] drm: Move standard crtc/plane prop handling to drm_crtc.c

2012-11-12 Thread ville.syrj...@linux.intel.com
From: Ville Syrj?l? Move some of the property code to drm_crtc.c since it should be shared by everyone. Signed-off-by: Ville Syrj?l? --- drivers/gpu/drm/drm_crtc.c | 235 +++ drivers/gpu/drm/i915/intel_atomic.c | 256 --

[PATCH 07/22] drm/i915: Update CRTC properties after modeset

2012-11-12 Thread ville.syrj...@linux.intel.com
From: Ville Syrj?l? Update cursor related CRTC properties after a modeset. The cursor properties aren't handled by the drm core since not all CRTCs have cursors. Signed-off-by: Ville Syrj?l? --- drivers/gpu/drm/i915/intel_display.c | 15 +++ 1 files changed, 15 insertions(+), 0 d

[PATCH 06/22] drm: Update standard plane properties after update_plane/disable_plane

2012-11-12 Thread ville.syrj...@linux.intel.com
From: Ville Syrj?l? Keep the new plane properties when doing operations through the legacy code paths. Signed-off-by: Ville Syrj?l? --- drivers/gpu/drm/drm_crtc.c |6 ++ 1 files changed, 6 insertions(+), 0 deletions(-) diff --git a/drivers/gpu/drm/drm_crtc.c b/drivers/gpu/drm/drm_crtc

[PATCH 05/22] drm_crtc_helper: Update standard crtc properties after modeset

2012-11-12 Thread ville.syrj...@linux.intel.com
From: Ville Syrj?l? Keep the new CRTC properties when doing modeset through the legacy code paths. Signed-off-by: Ville Syrj?l? --- drivers/gpu/drm/drm_crtc_helper.c | 10 ++ 1 files changed, 10 insertions(+), 0 deletions(-) diff --git a/drivers/gpu/drm/drm_crtc_helper.c b/drivers/

[PATCH 04/22] drm/i915: Move standard properties under mode_config

2012-11-12 Thread ville.syrj...@linux.intel.com
From: Ville Syrj?l? Standard connector properties are kept in the mode_config structure. Move the CRTC and plane properties there as well. Signed-off-by: Ville Syrj?l? --- drivers/gpu/drm/i915/intel_atomic.c | 295 +++ include/drm/drm_crtc.h | 19

[PATCH 03/22] drm/i915: Refactor property handling in atomic code

2012-11-12 Thread ville.syrj...@linux.intel.com
From: Ville Syrj?l? Move the property code around a bit to make it easier to move it out to the drm core later. Signed-off-by: Ville Syrj?l? --- drivers/gpu/drm/i915/intel_atomic.c | 423 --- drivers/gpu/drm/i915/intel_drv.h|3 + include/drm/drm_crtc.h

[PATCH 02/22] drm/i915: Clear flip helpers for sprites too

2012-11-12 Thread ville.syrj...@linux.intel.com
From: Ville Syrj?l? Don't leave stale flips hanging around the sprites' flip helpers when the crtc is being disabled. Signed-off-by: Ville Syrj?l? --- drivers/gpu/drm/i915/intel_atomic.c | 15 +++ drivers/gpu/drm/i915/intel_display.c |4 ++-- drivers/gpu/drm/i915/intel_drv.h

[PATCH 01/22] drm: Add missing EXPORT_SYMBOL()s for drm_flip

2012-11-12 Thread ville.syrj...@linux.intel.com
From: Ander Conselvan de Oliveira --- drivers/gpu/drm/drm_flip.c | 11 +++ 1 files changed, 11 insertions(+), 0 deletions(-) diff --git a/drivers/gpu/drm/drm_flip.c b/drivers/gpu/drm/drm_flip.c index 6ccc3f8..a20e6a4 100644 --- a/drivers/gpu/drm/drm_flip.c +++ b/drivers/gpu/drm/drm_fl

[PATCH 00/22] Atomic page flip: fixes, refactoring and non-blocking GPU sync

2012-11-12 Thread ville.syrj...@linux.intel.com
Here's a bunch of new stuff on top of my last atomic modeset/pageflip posting. Highlights: - some bug fixes - started moving common property bits out of intel_atomic.c - hooked up the properties to some legacy code paths - non-blocking GPU synchronization The GPU sync part could surely use some

[PATCH] ARM: add get_user() support for 8 byte types

2012-11-12 Thread Russell King - ARM Linux
On Fri, Nov 09, 2012 at 03:17:33PM -0600, Rob Clark wrote: > From: Rob Clark > > A new atomic modeset/pageflip ioctl being developed in DRM requires > get_user() to work for 64bit types (in addition to just put_user()). NAK. (I did write a better email explaining all the ins and outs of why thi

[PATCH] ARM: add get_user() support for 8 byte types

2012-11-12 Thread Rob Clark
On Mon, Nov 12, 2012 at 5:53 PM, Russell King - ARM Linux wrote: > On Mon, Nov 12, 2012 at 05:33:41PM -0600, Rob Clark wrote: >> I'm sort of thinking maybe we want to change 'switch (sizeof(*(__p)))' >> with 'switch (sizeof(typeof(x)))' in case someone ignores the compiler >> warning when they try

Fix for vblank on nvc0

2012-11-12 Thread Sven Joachim
On 2012-11-11 21:25 +0100, Maarten Lankhorst wrote: > Op 11-11-12 19:35, Marcin Slusarz schreef: >> On Sun, Nov 11, 2012 at 07:26:17PM +0100, Marcin Slusarz wrote: >>> On Tue, Nov 06, 2012 at 07:30:00PM +0100, Maarten Lankhorst wrote: Op 06-11-12 15:48, Kelly Doran schreef: > The vbl

[PATCH] ARM: add get_user() support for 8 byte types

2012-11-12 Thread Rob Clark
On Mon, Nov 12, 2012 at 5:08 PM, Russell King - ARM Linux wrote: > On Mon, Nov 12, 2012 at 01:58:32PM -0600, Rob Clark wrote: >> On Mon, Nov 12, 2012 at 1:27 PM, Russell King - ARM Linux >> wrote: >> > On Fri, Nov 09, 2012 at 03:17:33PM -0600, Rob Clark wrote: >> >> From: Rob Clark >> >> >> >> A

[PATCH v2 0/2] NVIDIA Tegra DRM driver

2012-11-12 Thread Stephen Warren
On 11/12/2012 02:55 PM, Thierry Reding wrote: > This second version of this patch series addresses all the comments > received so far. Most notably it takes advantage of the debugfs helpers > provided by the DRM core. Oddly enough this actually increases the line > count, but that's because the hel

[Bug 56405] Distorted graphics on Radeon HD 6620G

2012-11-12 Thread bugzilla-dae...@freedesktop.org
--enable-xa \ > --enable-vdpau " Don't need these. -- You are receiving this mail because: You are the assignee for the bug. -- next part -- An HTML attachment was scrubbed... URL: <http://lists.freedesktop.org/archives/dri-devel/attachments/20121112/0e8155af/attachment.html>

[PATCH v8 6/6] drm_modes: add of_videomode helpers

2012-11-12 Thread Steffen Trumtrar
Add helper to get drm_display_mode from devicetree. Signed-off-by: Steffen Trumtrar --- drivers/gpu/drm/drm_modes.c | 41 + include/drm/drmP.h |5 + 2 files changed, 46 insertions(+) diff --git a/drivers/gpu/drm/drm_modes.c b/drivers/gp

[PATCH v8 5/6] drm_modes: add videomode helpers

2012-11-12 Thread Steffen Trumtrar
Add conversion from videomode to drm_display_mode Signed-off-by: Steffen Trumtrar --- drivers/gpu/drm/drm_modes.c | 36 include/drm/drmP.h |3 +++ 2 files changed, 39 insertions(+) diff --git a/drivers/gpu/drm/drm_modes.c b/drivers/gpu/drm/drm

[PATCH v8 4/6] fbmon: add of_videomode helpers

2012-11-12 Thread Steffen Trumtrar
Add helper to get fb_videomode from devicetree. Signed-off-by: Steffen Trumtrar --- drivers/video/fbmon.c | 40 include/linux/fb.h|3 +++ 2 files changed, 43 insertions(+) diff --git a/drivers/video/fbmon.c b/drivers/video/fbmon.c index d46ecef

[PATCH v8 3/6] fbmon: add videomode helpers

2012-11-12 Thread Steffen Trumtrar
Add a function to convert from the generic videomode to a fb_videomode. Signed-off-by: Steffen Trumtrar --- drivers/video/fbmon.c | 37 + include/linux/fb.h|2 ++ 2 files changed, 39 insertions(+) diff --git a/drivers/video/fbmon.c b/drivers/video/f

[PATCH v8 2/6] video: add of helper for videomode

2012-11-12 Thread Steffen Trumtrar
This adds support for reading display timings from DT or/and convert one of those timings to a videomode. The of_display_timing implementation supports multiple children where each property can have up to 3 values. All children are read into an array, that can be queried. of_get_videomode converts

[PATCH v8 1/6] video: add display_timing and videomode

2012-11-12 Thread Steffen Trumtrar
Add display_timing structure and the according helper functions. This allows the description of a display via its supported timing parameters. Every timing parameter can be specified as a single value or a range . Also, add helper functions to convert from display timings to a generic videomode

[PATCH v8 0/6] of: add display helper

2012-11-12 Thread Steffen Trumtrar
Hi! This is v8 of the display helper series Changes since v7: - move of_xxx to drivers/video - remove non-binding documentation from display-timings.txt - squash display_timings and videomode in one patch - misc minor fixes Regards, Steffen Steffen Trumtrar (6):

Re: [PATCH] ARM: add get_user() support for 8 byte types

2012-11-12 Thread Rob Clark
On Mon, Nov 12, 2012 at 5:53 PM, Russell King - ARM Linux wrote: > On Mon, Nov 12, 2012 at 05:33:41PM -0600, Rob Clark wrote: >> I'm sort of thinking maybe we want to change 'switch (sizeof(*(__p)))' >> with 'switch (sizeof(typeof(x)))' in case someone ignores the compiler >> warning when they try

[PATCH 6/6] staging: drm/imx: Remove 300ms delay after memory reset

2012-11-12 Thread Sascha Hauer
From: Philipp Zabel This has been added once, but does not seem to be necessary. Tested on i.MX51 and i.MX6. Signed-off-by: Philipp Zabel Signed-off-by: Sascha Hauer --- drivers/staging/imx-drm/ipu-v3/ipu-common.c |2 -- 1 file changed, 2 deletions(-) diff --git a/drivers/staging/imx-drm

[PATCH 5/6] staging: drm/imx: Add pinctrl support to parallel display driver

2012-11-12 Thread Sascha Hauer
To allow the iomux to be configured for the display. Signed-off-by: Sascha Hauer --- drivers/staging/imx-drm/parallel-display.c | 10 ++ 1 file changed, 10 insertions(+) diff --git a/drivers/staging/imx-drm/parallel-display.c b/drivers/staging/imx-drm/parallel-display.c index 9b51d73

[PATCH 4/6] staging: drm/imx: Add ipu_cpmem_set_yuv_interleaved()

2012-11-12 Thread Sascha Hauer
From: Philipp Zabel For configuring interleaved formats. Signed-off-by: Philipp Zabel Signed-off-by: Sascha Hauer --- drivers/staging/imx-drm/ipu-v3/imx-ipu-v3.h |1 + drivers/staging/imx-drm/ipu-v3/ipu-common.c | 17 + 2 files changed, 18 insertions(+) diff --git a/dri

[PATCH 3/6] staging: drm/imx: silence ipu_crtc_dpms debug message

2012-11-12 Thread Sascha Hauer
From: Philipp Zabel It's for debugging only, so use dev_dbg. Signed-off-by: Philipp Zabel Signed-off-by: Sascha Hauer --- drivers/staging/imx-drm/ipuv3-crtc.c |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/staging/imx-drm/ipuv3-crtc.c b/drivers/staging/imx-drm

[PATCH 2/6] staging: drm/imx: Add YVU420 support to i.MX IPUv3 base driver

2012-11-12 Thread Sascha Hauer
From: Philipp Zabel Signed-off-by: Philipp Zabel Signed-off-by: Sascha Hauer --- drivers/staging/imx-drm/ipu-v3/ipu-common.c | 11 ++- 1 file changed, 10 insertions(+), 1 deletion(-) diff --git a/drivers/staging/imx-drm/ipu-v3/ipu-common.c b/drivers/staging/imx-drm/ipu-v3/ipu-commo

[PATCH 1/6] staging: drm/imx: Fix YUYV support in i.MX IPUv3 base driver

2012-11-12 Thread Sascha Hauer
From: Michael Olbrich YVYU is not supported by the IPU, so remove partial handling of this format and replace it with YUYV which is supported. Signed-off-by: Michael Olbrich Signed-off-by: Philipp Zabel Signed-off-by: Sascha Hauer --- drivers/staging/imx-drm/ipu-v3/ipu-common.c |3 ++- 1

[PATCH] staging drm/imx: updates

2012-11-12 Thread Sascha Hauer
The following contains some assorted updates to the i.MX drm driver for the next merge window. Sascha Michael Olbrich (1): staging: drm/imx: Fix YUYV support in i.MX IPUv3 base driver Philipp Zabel (4): staging: drm/imx

Re: [PATCH v2 0/2] NVIDIA Tegra DRM driver

2012-11-12 Thread Stephen Warren
On 11/12/2012 02:55 PM, Thierry Reding wrote: > This second version of this patch series addresses all the comments > received so far. Most notably it takes advantage of the debugfs helpers > provided by the DRM core. Oddly enough this actually increases the line > count, but that's because the hel

Re: [PATCH] ARM: add get_user() support for 8 byte types

2012-11-12 Thread Rob Clark
On Mon, Nov 12, 2012 at 5:08 PM, Russell King - ARM Linux wrote: > On Mon, Nov 12, 2012 at 01:58:32PM -0600, Rob Clark wrote: >> On Mon, Nov 12, 2012 at 1:27 PM, Russell King - ARM Linux >> wrote: >> > On Fri, Nov 09, 2012 at 03:17:33PM -0600, Rob Clark wrote: >> >> From: Rob Clark >> >> >> >> A

[Bug 56139] [bisected] kernel 3.7.0-rc1 breaks 6950 (boot/grub2 and suspend/resume) (CAYMAN)

2012-11-12 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=56139 --- Comment #28 from Alexandre Demers --- Alex, a simple question: you said bit 0 in EVERGREEN_CRTC_CONTROL stops the CRTC sync. With the culprit commit, when is it set? I mean, I had a quick look in the driver's code and I couldn't find it. When

Fix for vblank on nvc0

2012-11-12 Thread Kelly Doran
moving the bar flush help? > > ~Maarte -- next part -- A non-text attachment was scrubbed... Name: vblank-fix1.patch Type: application/octet-stream Size: 1474 bytes Desc: not available URL: <http://lists.freedesktop.org/archives/dri-devel/attachments/20121112/827f06ae/attachment-0001.obj>

[PATCH] HACK: drm: Allow encoders to be reenabled

2012-11-12 Thread Daniel Vetter
On Mon, Nov 12, 2012 at 3:25 PM, Rob Clark wrote: > On Mon, Nov 12, 2012 at 8:17 AM, Daniel Vetter wrote: >> On Mon, Nov 12, 2012 at 3:11 PM, Rob Clark wrote: >>> I do prefer that, at least on lastclose, that we revert properties >>> back to default/initial state, so that userspace unaware of so

[PATCH] HACK: drm: Allow encoders to be reenabled

2012-11-12 Thread Daniel Vetter
On Mon, Nov 12, 2012 at 3:11 PM, Rob Clark wrote: > I do prefer that, at least on lastclose, that we revert properties > back to default/initial state, so that userspace unaware of some new > or driver specific properties doesn't get confused. > > But dpms is a bit of an odd-duck property. Probab

[PATCH] drm/i915: Optimize DIV_ROUND_CLOSEST call

2012-11-12 Thread Jean Delvare
On Mon, 12 Nov 2012 15:02:26 +0100, Daniel Vetter wrote: > On Mon, Nov 12, 2012 at 02:18:02PM +0100, Jean Delvare wrote: > > DIV_ROUND_CLOSEST is faster if the compiler knows it will only be > > dealing with unsigned dividends. This optimization rips 32 bytes of > > binary code on x86_64. > > > >

[PATCH 01/10] drm/radeon: allow move_notify to be called without reservation

2012-11-12 Thread Maarten Lankhorst
Op 12-11-12 15:00, Maarten Lankhorst schreef: > The few places that care should have those checks instead. > This allow destruction of bo backed memory without a reservation. Forgot to add, this patch series depends on the previous sync_obj_arg removal patches, and cpu_writers -EBUSY change. ~Maa

Re: Fix for vblank on nvc0

2012-11-12 Thread Marcin Slusarz
On Mon, Nov 12, 2012 at 06:14:05AM -0600, Kelly Doran wrote: > Okay I have added two patches, one of them should fix the problem... > vblank-fix1.patch works, thanks. Marcin ___ dri-devel mailing list dri-devel@lists.freedesktop.org http://lists.freede

[PATCH] drm/i915: Optimize DIV_ROUND_CLOSEST call

2012-11-12 Thread Daniel Vetter
On Mon, Nov 12, 2012 at 02:18:02PM +0100, Jean Delvare wrote: > DIV_ROUND_CLOSEST is faster if the compiler knows it will only be > dealing with unsigned dividends. This optimization rips 32 bytes of > binary code on x86_64. > > Signed-off-by: Jean Delvare > Cc: Guenter Roeck > Cc: Andrew Morton

[PATCH 10/10] drm/ttm: remove reliance on ttm_bo_wait_unreserved

2012-11-12 Thread Maarten Lankhorst
Slightly makes things more complicated, but instead of testing for unreserved and starting over, try to block and acquire reservation first, then start over. This maps a lot better to a blocking acquire operation. Signed-off-by: Maarten Lankhorst --- drivers/gpu/drm/nouveau/nouveau_gem.c | 19

[PATCH 09/10] drm/ttm: remove lru_lock around ttm_bo_reserve

2012-11-12 Thread Maarten Lankhorst
There should no longer be assumptions that reserve will always succeed with the lru lock held, so we can safely break the whole atomic reserve/lru thing. As a bonus this fixes most lockdep annotations for reservations. Signed-off-by: Maarten Lankhorst --- drivers/gpu/drm/ttm/ttm_bo.c |

[PATCH 08/10] drm/ttm: cope with reserved buffers on lru list in ttm_mem_evict_first

2012-11-12 Thread Maarten Lankhorst
Signed-off-by: Maarten Lankhorst --- drivers/gpu/drm/ttm/ttm_bo.c | 19 +++ 1 file changed, 7 insertions(+), 12 deletions(-) diff --git a/drivers/gpu/drm/ttm/ttm_bo.c b/drivers/gpu/drm/ttm/ttm_bo.c index b9c26a5..a760178 100644 --- a/drivers/gpu/drm/ttm/ttm_bo.c +++ b/drivers/gpu

[PATCH 07/10] drm/ttm: cope with reserved buffers on swap list in ttm_bo_swapout

2012-11-12 Thread Maarten Lankhorst
Signed-off-by: Maarten Lankhorst --- drivers/gpu/drm/ttm/ttm_bo.c | 27 ++- 1 file changed, 10 insertions(+), 17 deletions(-) diff --git a/drivers/gpu/drm/ttm/ttm_bo.c b/drivers/gpu/drm/ttm/ttm_bo.c index 1d77ad1..b9c26a5 100644 --- a/drivers/gpu/drm/ttm/ttm_bo.c +++ b/dr

[PATCH 06/10] drm/ttm: remove no_wait_reserve, v2

2012-11-12 Thread Maarten Lankhorst
All items on the lru list are always reservable, so this is a stupid thing to keep. Not only that, it is used in a way which would guarantee deadlocks if it were ever to be set to block on reserve. This is a lot of churn, but mostly because of the removal of the argument which can be nested arbitr

[PATCH 05/10] drm/ttm: add sense to ttm_bo_cleanup_refs, v4

2012-11-12 Thread Maarten Lankhorst
Require lru_lock and reservation to be held, kill off the loop, no new sync objects should be attached at this point any more. v2: - moved upwards in patch list and fixed conflicts. v3: - rebase for fence lock, and rename to ttm_bo_cleanup_refs_and_unlock for clarity that it unlocks lru. v4:

[PATCH 04/10] drm/ttm: change fence_lock to inner lock, v3

2012-11-12 Thread Maarten Lankhorst
I changed the hierarchy to make fence_lock the most inner lock, instead of outer lock. This will simplify things slightly, and hopefully makes it easier to make fence_lock global at one point should it be needed. To make things clearer, I change the order around in ttm_bo_cleanup_refs and ttm_bo_c

[PATCH 03/10] drm/ttm: do not check if list is empty in ttm_bo_force_list_clean

2012-11-12 Thread Maarten Lankhorst
Just use the return error from ttm_mem_evict_first instead. Signed-off-by: Maarten Lankhorst --- drivers/gpu/drm/ttm/ttm_bo.c | 27 --- 1 file changed, 8 insertions(+), 19 deletions(-) diff --git a/drivers/gpu/drm/ttm/ttm_bo.c b/drivers/gpu/drm/ttm/ttm_bo.c index 74d6e7c

[PATCH 02/10] drm/ttm: remove ttm_bo_cleanup_memtype_use

2012-11-12 Thread Maarten Lankhorst
move to release_list instead Signed-off-by: Maarten Lankhorst --- drivers/gpu/drm/ttm/ttm_bo.c | 47 +--- 1 file changed, 14 insertions(+), 33 deletions(-) diff --git a/drivers/gpu/drm/ttm/ttm_bo.c b/drivers/gpu/drm/ttm/ttm_bo.c index 9c48e8f..74d6e7c 100

[PATCH 01/10] drm/radeon: allow move_notify to be called without reservation

2012-11-12 Thread Maarten Lankhorst
The few places that care should have those checks instead. This allow destruction of bo backed memory without a reservation. Signed-off-by: Maarten Lankhorst --- drivers/gpu/drm/radeon/radeon_gart.c | 1 - drivers/gpu/drm/radeon/radeon_object.c | 2 +- 2 files changed, 1 insertion(+), 2 deleti

Re: i915 hang and large allocation (~3.7-rc4)

2012-11-12 Thread Daniel Vetter
On Mon, Nov 12, 2012 at 02:44:46PM -0800, Dave Hansen wrote: > I've been seeing a little goofiness with i915 video under the 3.7-rc's. > It looks like I'm seeing two separate issues. One, that the video > hardware hangs, spits some errors in dmesg, and then video acceleration > seems to stop worki

i915 hang and large allocation (~3.7-rc4)

2012-11-12 Thread Dave Hansen
I've been seeing a little goofiness with i915 video under the 3.7-rc's. It looks like I'm seeing two separate issues. One, that the video hardware hangs, spits some errors in dmesg, and then video acceleration seems to stop working. Two, when it does this, apport goes digging in debugfs for infor

[PATCH] ARM: add get_user() support for 8 byte types

2012-11-12 Thread Will Deacon
On Mon, Nov 12, 2012 at 01:46:57PM +, Rob Clark wrote: > On Mon, Nov 12, 2012 at 4:46 AM, Will Deacon wrote: > > On Fri, Nov 09, 2012 at 09:17:33PM +, Rob Clark wrote: > >> @@ -122,22 +124,35 @@ extern int __get_user_4(void *); > >> ({

[PATCH] drm: fix drm_framebuffer cleanup.

2012-11-12 Thread Ville Syrjälä
On Sat, Nov 10, 2012 at 10:09:02AM +0900, Inki Dae wrote: > 2012/11/10 Ville Syrj?l? > > > On Sat, Nov 10, 2012 at 01:50:53AM +0900, Inki Dae wrote: > > > 2012/11/9 Ville Syrj?l? > > > > > > > On Fri, Nov 09, 2012 at 11:04:58PM +0900, Inki Dae wrote: > > > > > 2012/11/9 Ville Syrj?l? > > > > >

[PATCH] drm/i915: Optimize DIV_ROUND_CLOSEST call

2012-11-12 Thread Jean Delvare
DIV_ROUND_CLOSEST is faster if the compiler knows it will only be dealing with unsigned dividends. This optimization rips 32 bytes of binary code on x86_64. Signed-off-by: Jean Delvare Cc: Guenter Roeck Cc: Andrew Morton Cc: Daniel Vetter Cc: David Airlie --- Already sent on: 2012-09-03. Dan

[patch] vmwgfx: return an -EFAULT if copy_to_user() fails

2012-11-12 Thread Dan Carpenter
copy_to_user() returns the number of bytes remaining to be copied, but we want to return a negative error code here. I fixed a couple of these last year, but I missed this one. Signed-off-by: Dan Carpenter --- I think there were only three copy_to/from_user() functions in this file and they're a

[PATCH] ARM: add get_user() support for 8 byte types

2012-11-12 Thread Rob Clark
On Mon, Nov 12, 2012 at 1:27 PM, Russell King - ARM Linux wrote: > On Fri, Nov 09, 2012 at 03:17:33PM -0600, Rob Clark wrote: >> From: Rob Clark >> >> A new atomic modeset/pageflip ioctl being developed in DRM requires >> get_user() to work for 64bit types (in addition to just put_user()). > > NA

[PATCH v2 0/2] NVIDIA Tegra DRM driver

2012-11-12 Thread Thierry Reding
This second version of this patch series addresses all the comments received so far. Most notably it takes advantage of the debugfs helpers provided by the DRM core. Oddly enough this actually increases the line count, but that's because the helpers don't fit with the subdevices approach as impleme

Re: Fix for vblank on nvc0

2012-11-12 Thread Maarten Lankhorst
Op 12-11-12 22:30, Kelly Doran schreef: > I had Sven test this patch... he said it works. I think chipset > number test was executing code that we thought was only either 0x50 or > 0xc0, but was actually more specific with things like 0x92. > Oh right vblank is busted anyway... needs to be nv_devi

[PATCH v8 2/6] video: add of helper for videomode

2012-11-12 Thread Stephen Warren
On 11/12/2012 08:37 AM, Steffen Trumtrar wrote: > This adds support for reading display timings from DT or/and convert one of > those > timings to a videomode. > The of_display_timing implementation supports multiple children where each > property can have up to 3 values. All children are read int

[Bug 5092] Unichrome (K8M800) locks up when working with textures

2012-11-12 Thread bugzilla-dae...@freedesktop.org
vel/attachments/20121112/7d5dae37/attachment-0001.html>

[Bug 17270] OpenChrome & KDE Screen Savers

2012-11-12 Thread bugzilla-dae...@freedesktop.org
org/archives/dri-devel/attachments/20121112/fb37115b/attachment.html>

[Bug 17269] KPDF & OpenChrome 0.2.309

2012-11-12 Thread bugzilla-dae...@freedesktop.org
ttp://lists.freedesktop.org/archives/dri-devel/attachments/20121112/3e77194f/attachment.html>

  1   2   3   >