Hello, all.
I am trying to implement multi planer using your plane patch and I
think it's good but I am still warried about that drm_mode_fb_cmd2
structure has only one handle. I know this handle is sent to
framebuffer module to create new framebuffer. and the framebuffer
would cover entire a imag
Nouveau, when configured with debugfs, creates debugfs files for every
channel, so structure holding list of files needs to be protected from
simultaneous changes by multiple threads.
Without this patch it's possible to hit kernel oops in
drm_debugfs_remove_files just by running a couple of xterms
On 11/09/2011 09:22 PM, j.glisse at gmail.com wrote:
> So i did an overhaul of ttm_memory, i believe the simplification i did
> make sense. See patch 5 for a longer explanation.
>
>
> Thomas with the ttm_memory change the allocation of pages won't happen
> if the accounting report that we are g
On Wed, Nov 09, 2011 at 03:40:19PM +0800, Takashi Iwai wrote:
> At Tue, 8 Nov 2011 12:23:30 -0800,
> Linus Torvalds wrote:
> >
> > Hmm, I don't know what caused this to trigger, but I'm adding both the
> > i915 people and the HDA people to the cc, and they can fight to the
> > death about this in
ane->funcs->update_plane(plane, crtc, fb,
> +plane_req->crtc_x,
plane_req->crtc_y,
> +plane_req->crtc_w,
plane_req->crtc_h,
> +plane_req->src_x,
plane_req->src_y,
> +plane_req->src_w,
plane_req->src_h);
> + if (!ret) {
> + plane->crtc = crtc;
> + plane->fb = fb;
> + }
> +
> +out:
> + mutex_unlock(&dev->mode_config.mutex);
> +
> + return ret;
> +}
> +
> +/**
> * drm_mode_setcrtc - set CRTC configuration
> * @inode: inode from the ioctl
> * @filp: file * from the ioctl
> @@ -1688,11 +1939,13 @@ int drm_mode_addfb(struct drm_device *dev,
>return -EINVAL;
>
>if ((config->min_width > r->width) || (r->width >
config->max_width)) {
> - DRM_ERROR("mode new framebuffer width not within
limits\n");
> + DRM_ERROR("bad framebuffer width %d, should be >= %d &&
<= %d\n",
> + r->width, config->min_width, config->max_width);
>return -EINVAL;
> index 8020798..e20867e 100644
> --- a/include/drm/drm_crtc.h
> +++ b/include/drm/drm_crtc.h
> @@ -44,6 +44,7 @@ struct drm_framebuffer;
> #define DRM_MODE_OBJECT_PROPERTY 0xb0b0b0b0
> #define DRM_MODE_OBJECT_+extern int drm_pl
--
- Joonyoung Shim
-- next part --
An HTML attachment was scrubbed...
URL:
<http://lists.freedesktop.org/archives/dri-devel/attachments/2009/f1f1ea33/attachment-0001.htm>
https://bugs.freedesktop.org/show_bug.cgi?id=42678
--- Comment #13 from Filip 2011-11-09 10:56:34 PST ---
So, after I ran the following on my system:
sudo sh /usr/share/ati/fglrx-uninstall.sh
sudo apt-get remove --purge fglrx fglrx_* fglrx-amdcccle* fglrx-dev*
sudo apt-get remove --purge xserve
From: Jerome Glisse
Move dma data to a superset ttm_dma_tt structure which herit
from ttm_tt. This allow driver that don't use dma functionalities
to not have to waste memory for it.
Signed-off-by: Jerome Glisse
---
drivers/gpu/drm/nouveau/nouveau_bo.c | 18 +
drivers/gpu/drm/nou
This apply on top of the ttm_tt & backend merge patchset.
Cheers,
Jerome
2011/11/9 Rafa? Mi?ecki :
> 2011/11/9 Greg Dietsche :
>> Hi,
>> I have a ASUS M4A89GTD motherboard and when I play back music in Rhythmbox,
>> there is no sound (hdmi connection). Also, the playback speed is in a sort
>> of fast forward (for example, after a few seconds of real time, rhythmbox
>> s
https://bugs.freedesktop.org/show_bug.cgi?id=28426
--- Comment #11 from J?rg Billeter 2011-11-09 08:51:09 PST ---
My Linux 3.1 system has been running for over 6 days now without issues. Seems
like it may finally be fixed for good :) Thanks!
--
Configure bugmail: https://bugs.freedesktop.org/us
On Wed, Nov 09, 2011 at 09:25:20PM +0100, Thomas Hellstrom wrote:
> On 11/09/2011 09:22 PM, j.glisse at gmail.com wrote:
> >So i did an overhaul of ttm_memory, i believe the simplification i did
> >make sense. See patch 5 for a longer explanation.
> >
> >Thomas with the ttm_memory change the alloca
On Tue, Nov 08, 2011 at 08:22:48AM +0100, Thomas Hellstrom wrote:
> On 11/08/2011 12:40 AM, j.glisse at gmail.com wrote:
> >From: Jerome Glisse
> >
> >This was never use in none of the driver, properly using userspace
> >page for bo would need more code (vma interaction mostly). Removing
> >this de
On Tue, Nov 08, 2011 at 06:50:19PM +0100, Michel D?nzer wrote:
> From: Michel D?nzer
>
> This was only the case if the GPU reset was triggered from the CS ioctl,
> otherwise other processes could happily enter the CS ioctl and wreak havoc
> during the GPU reset.
>
> This is a little complicated
From: Konrad Rzeszutek Wilk
If the card is capable of more than 32-bit, then use the default
TTM page pool code which allocates from anywhere in the memory.
Note: If the 'ttm.no_dma' parameter is set, the override is ignored
and the default TTM pool is used.
V2 use pci_set_consistent_dma_mask
From: Konrad Rzeszutek Wilk
With the exception that we do not handle the AGP case. We only
deal with PCIe cards such as ATI ES1000 or HD3200 that have been
detected to only do DMA up to 32-bits.
V2 force dma32 if we fail to set bigger dma mask
CC: Dave Airlie
CC: Alex Deucher
Signed-off-by: K
From: Konrad Rzeszutek Wilk
As a mechanism to detect whether SWIOTLB is enabled or not.
We also fix the spelling - it was swioltb instead of
swiotlb.
CC: FUJITA Tomonori
[v1: Ripped out swiotlb_enabled]
Signed-off-by: Konrad Rzeszutek Wilk
---
drivers/xen/swiotlb-xen.c |2 +-
include/linu
From: Konrad Rzeszutek Wilk
In TTM world the pages for the graphic drivers are kept in three different
pools: write combined, uncached, and cached (write-back). When the pages
are used by the graphic driver the graphic adapter via its built in MMU
(or AGP) programs these pages in. The programming
From: Jerome Glisse
Move the page allocation and freeing to driver callback and
provide ttm code helper function for those.
Most intrusive change, is the fact that we now only fully
populate an object this simplify some of code designed around
the page fault design.
V2 Rebase on top of memory a
From: Jerome Glisse
ttm_backend will exist only and only with a ttm_tt, and ttm_tt
will be of interesting use only when bind to a backend. Thus to
avoid code & data duplication btw the two merge them.
V2 Rebase on top of memory accountign overhaul
Signed-off-by: Jerome Glisse
Reviewed-by: Konr
From: Jerome Glisse
Signed-off-by: Jerome Glisse
Reviewed-by: Konrad Rzeszutek Wilk
Reviewed-by: Thomas Hellstrom
---
drivers/gpu/drm/ttm/ttm_tt.c |2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/drivers/gpu/drm/ttm/ttm_tt.c b/drivers/gpu/drm/ttm/ttm_tt.c
index 303bbb
From: Jerome Glisse
Use the ttm_tt page ptr array for page allocation, move the list to
array unwinding into the page allocation functions.
V2 split the fix to use ttm put page as a separate fix
properly fill pages array when TTM_PAGE_FLAG_ZERO_ALLOC is not
set
V3 Added back page_count()==1 chec
From: Jerome Glisse
This is an overhaul of the ttm memory accounting. This tries to keep
the same global behavior while removing the whole zone concept. It
keeps a distrinction for dma32 so that we make sure that ttm don't
starve the dma32 zone.
There is 3 threshold for memory allocation :
- max
From: Jerome Glisse
On failure we need to make sure the page we free has wb cache
attribute. Do this pas call the proper ttm page helper function.
Signed-off-by: Jerome Glisse
Reviewed-by: Konrad Rzeszutek Wilk
Reviewed-by: Thomas Hellstrom
---
drivers/gpu/drm/ttm/ttm_tt.c |5 -
1 fi
From: Jerome Glisse
This field is not use by any of the driver just drop it.
Signed-off-by: Jerome Glisse
Reviewed-by: Konrad Rzeszutek Wilk
Reviewed-by: Thomas Hellstrom
---
drivers/gpu/drm/radeon/radeon_ttm.c |1 -
include/drm/ttm/ttm_bo_driver.h |2 --
2 files changed, 0 inser
From: Jerome Glisse
Split btw highmem and lowmem page was rendered useless by the
pool code. Remove it. Note further cleanup would change the
ttm page allocation helper to actualy take an array instead
of relying on list this could drasticly reduce the number of
function call in the common case o
From: Jerome Glisse
This was never use in none of the driver, properly using userspace
page for bo would need more code (vma interaction mostly). Removing
this dead code in preparation of ttm_tt & backend merge.
Signed-off-by: Jerome Glisse
Reviewed-by: Konrad Rzeszutek Wilk
Reviewed-by: Thoma
So i did an overhaul of ttm_memory, i believe the simplification i did
make sense. See patch 5 for a longer explanation.
Thomas with the ttm_memory change the allocation of pages won't happen
if the accounting report that we are going over the limit and bo shrinker
failed to free any memory to mak
https://bugs.freedesktop.org/show_bug.cgi?id=27314
--- Comment #59 from Alex Deucher 2011-11-09 06:44:37 PST
---
(In reply to comment #57)
> Created attachment 53309 [details]
> xorg log with the ati driver in fedora16
>
> I have just installed fedora 16 on an "imac11,1", and I still have the s
From: Jerome Glisse
Move dma data to a superset ttm_dma_tt structure which herit
from ttm_tt. This allow driver that don't use dma functionalities
to not have to waste memory for it.
Signed-off-by: Jerome Glisse
---
drivers/gpu/drm/nouveau/nouveau_bo.c | 18 +
drivers/gpu/drm/nou
This apply on top of the ttm_tt & backend merge patchset.
Cheers,
Jerome
___
dri-devel mailing list
dri-devel@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/dri-devel
Nouveau, when configured with debugfs, creates debugfs files for every
channel, so structure holding list of files needs to be protected from
simultaneous changes by multiple threads.
Without this patch it's possible to hit kernel oops in
drm_debugfs_remove_files just by running a couple of xterms
On Wed, Nov 09, 2011 at 09:25:20PM +0100, Thomas Hellstrom wrote:
> On 11/09/2011 09:22 PM, j.gli...@gmail.com wrote:
> >So i did an overhaul of ttm_memory, i believe the simplification i did
> >make sense. See patch 5 for a longer explanation.
> >
> >Thomas with the ttm_memory change the allocatio
On Tue, Nov 08, 2011 at 08:22:48AM +0100, Thomas Hellstrom wrote:
> On 11/08/2011 12:40 AM, j.gli...@gmail.com wrote:
> >From: Jerome Glisse
> >
> >This was never use in none of the driver, properly using userspace
> >page for bo would need more code (vma interaction mostly). Removing
> >this dead
On 11/09/2011 09:22 PM, j.gli...@gmail.com wrote:
So i did an overhaul of ttm_memory, i believe the simplification i did
make sense. See patch 5 for a longer explanation.
Thomas with the ttm_memory change the allocation of pages won't happen
if the accounting report that we are going over t
On Tue, Nov 08, 2011 at 06:50:19PM +0100, Michel Dänzer wrote:
> From: Michel Dänzer
>
> This was only the case if the GPU reset was triggered from the CS ioctl,
> otherwise other processes could happily enter the CS ioctl and wreak havoc
> during the GPU reset.
>
> This is a little complicated
From: Konrad Rzeszutek Wilk
If the card is capable of more than 32-bit, then use the default
TTM page pool code which allocates from anywhere in the memory.
Note: If the 'ttm.no_dma' parameter is set, the override is ignored
and the default TTM pool is used.
V2 use pci_set_consistent_dma_mask
From: Konrad Rzeszutek Wilk
With the exception that we do not handle the AGP case. We only
deal with PCIe cards such as ATI ES1000 or HD3200 that have been
detected to only do DMA up to 32-bits.
V2 force dma32 if we fail to set bigger dma mask
CC: Dave Airlie
CC: Alex Deucher
Signed-off-by: K
From: Konrad Rzeszutek Wilk
As a mechanism to detect whether SWIOTLB is enabled or not.
We also fix the spelling - it was swioltb instead of
swiotlb.
CC: FUJITA Tomonori
[v1: Ripped out swiotlb_enabled]
Signed-off-by: Konrad Rzeszutek Wilk
---
drivers/xen/swiotlb-xen.c |2 +-
include/linu
From: Jerome Glisse
Move the page allocation and freeing to driver callback and
provide ttm code helper function for those.
Most intrusive change, is the fact that we now only fully
populate an object this simplify some of code designed around
the page fault design.
V2 Rebase on top of memory a
From: Jerome Glisse
ttm_backend will exist only and only with a ttm_tt, and ttm_tt
will be of interesting use only when bind to a backend. Thus to
avoid code & data duplication btw the two merge them.
V2 Rebase on top of memory accountign overhaul
Signed-off-by: Jerome Glisse
Reviewed-by: Konr
From: Jerome Glisse
Signed-off-by: Jerome Glisse
Reviewed-by: Konrad Rzeszutek Wilk
Reviewed-by: Thomas Hellstrom
---
drivers/gpu/drm/ttm/ttm_tt.c |2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/drivers/gpu/drm/ttm/ttm_tt.c b/drivers/gpu/drm/ttm/ttm_tt.c
index 303bbb
From: Jerome Glisse
Use the ttm_tt page ptr array for page allocation, move the list to
array unwinding into the page allocation functions.
V2 split the fix to use ttm put page as a separate fix
properly fill pages array when TTM_PAGE_FLAG_ZERO_ALLOC is not
set
V3 Added back page_count()==1 chec
From: Jerome Glisse
This is an overhaul of the ttm memory accounting. This tries to keep
the same global behavior while removing the whole zone concept. It
keeps a distrinction for dma32 so that we make sure that ttm don't
starve the dma32 zone.
There is 3 threshold for memory allocation :
- max
From: Jerome Glisse
On failure we need to make sure the page we free has wb cache
attribute. Do this pas call the proper ttm page helper function.
Signed-off-by: Jerome Glisse
Reviewed-by: Konrad Rzeszutek Wilk
Reviewed-by: Thomas Hellstrom
---
drivers/gpu/drm/ttm/ttm_tt.c |5 -
1 fi
From: Jerome Glisse
This field is not use by any of the driver just drop it.
Signed-off-by: Jerome Glisse
Reviewed-by: Konrad Rzeszutek Wilk
Reviewed-by: Thomas Hellstrom
---
drivers/gpu/drm/radeon/radeon_ttm.c |1 -
include/drm/ttm/ttm_bo_driver.h |2 --
2 files changed, 0 inser
From: Jerome Glisse
Split btw highmem and lowmem page was rendered useless by the
pool code. Remove it. Note further cleanup would change the
ttm page allocation helper to actualy take an array instead
of relying on list this could drasticly reduce the number of
function call in the common case o
From: Jerome Glisse
This was never use in none of the driver, properly using userspace
page for bo would need more code (vma interaction mostly). Removing
this dead code in preparation of ttm_tt & backend merge.
Signed-off-by: Jerome Glisse
Reviewed-by: Konrad Rzeszutek Wilk
Reviewed-by: Thoma
So i did an overhaul of ttm_memory, i believe the simplification i did
make sense. See patch 5 for a longer explanation.
Thomas with the ttm_memory change the allocation of pages won't happen
if the accounting report that we are going over the limit and bo shrinker
failed to free any memory to mak
https://bugs.freedesktop.org/show_bug.cgi?id=42678
--- Comment #13 from Filip 2011-11-09 10:56:34 PST ---
So, after I ran the following on my system:
sudo sh /usr/share/ati/fglrx-uninstall.sh
sudo apt-get remove --purge fglrx fglrx_* fglrx-amdcccle* fglrx-dev*
sudo apt-get remove --purge xserve
From: Jakob Bornecrantz
Snooping code expects this to be the case.
Signed-off-by: Jakob Bornecrantz
Reviewed-by: Thomas Hellstrom
---
drivers/gpu/drm/vmwgfx/vmwgfx_kms.c |4
1 files changed, 4 insertions(+), 0 deletions(-)
diff --git a/drivers/gpu/drm/vmwgfx/vmwgfx_kms.c
b/drivers/
From: Jakob Bornecrantz
Signed-off-by: Jakob Bornecrantz
Reviewed-by: Thomas Hellstrom
---
drivers/gpu/drm/vmwgfx/vmwgfx_kms.c |5 +++--
1 files changed, 3 insertions(+), 2 deletions(-)
diff --git a/drivers/gpu/drm/vmwgfx/vmwgfx_kms.c
b/drivers/gpu/drm/vmwgfx/vmwgfx_kms.c
index f3ab1fe..
From: Jakob Bornecrantz
Signed-off-by: Jakob Bornecrantz
Reviewed-by: Thomas Hellstrom
---
drivers/gpu/drm/vmwgfx/vmwgfx_kms.c |5 -
1 files changed, 4 insertions(+), 1 deletions(-)
diff --git a/drivers/gpu/drm/vmwgfx/vmwgfx_kms.c
b/drivers/gpu/drm/vmwgfx/vmwgfx_kms.c
index 03daefa..
A couple of bugfixes for vmwgfx kms.
2011/11/9 Greg Dietsche :
> Hi,
> I have a ASUS M4A89GTD motherboard and when I play back music in Rhythmbox,
> there is no sound (hdmi connection). Also, the playback speed is in a sort
> of fast forward (for example, after a few seconds of real time, rhythmbox
> shows something like 30 seconds in
https://bugs.freedesktop.org/show_bug.cgi?id=28426
--- Comment #11 from Jürg Billeter 2011-11-09 08:51:09 PST ---
My Linux 3.1 system has been running for over 6 days now without issues. Seems
like it may finally be fixed for good :) Thanks!
--
Configure bugmail: https://bugs.freedesktop.org/us
At Tue, 8 Nov 2011 12:23:30 -0800,
Linus Torvalds wrote:
>
> Hmm, I don't know what caused this to trigger, but I'm adding both the
> i915 people and the HDA people to the cc, and they can fight to the
> death about this in the HDMI Thunderdome.
It must be the new addition of ELD-passing code.
F
This is an overhaul of the ttm memory accounting. This tries to keep
the same global behavior while removing the whole zone concept. It
keeps a distrinction for dma32 so that we make sure that ttm don't
starve the dma32 zone.
There is 3 threshold for memory allocation :
- max_mem is the maximum me
On Wed, Nov 9, 2011 at 7:25 AM, InKi Dae wrote:
> Hello, all.
>
> I am trying to implement multi planer using your plane patch and I
> think it's good but I am still warried about that drm_mode_fb_cmd2
> structure has only one handle. I know this handle is sent to
> framebuffer module to create ne
https://bugs.freedesktop.org/show_bug.cgi?id=27314
--- Comment #59 from Alex Deucher 2011-11-09 06:44:37 PST ---
(In reply to comment #57)
> Created attachment 53309 [details]
> xorg log with the ati driver in fedora16
>
> I have just installed fedora 16 on an "imac11,1", and I still have the sa
On Wed, Nov 9, 2011 at 7:25 AM, InKi Dae wrote:
> Hello, all.
>
> I am trying to implement multi planer using your plane patch and I
> think it's good but I am still warried about that drm_mode_fb_cmd2
> structure has only one handle. I know this handle is sent to
> framebuffer module to create ne
Hello, all.
I am trying to implement multi planer using your plane patch and I
think it's good but I am still warried about that drm_mode_fb_cmd2
structure has only one handle. I know this handle is sent to
framebuffer module to create new framebuffer. and the framebuffer
would cover entire a imag
On Wed, Nov 09, 2011 at 03:40:19PM +0800, Takashi Iwai wrote:
> At Tue, 8 Nov 2011 12:23:30 -0800,
> Linus Torvalds wrote:
> >
> > Hmm, I don't know what caused this to trigger, but I'm adding both the
> > i915 people and the HDA people to the cc, and they can fight to the
> > death about this in
2011년 11월 9일 수요일에 Jesse Barnes님이 작성:
> Planes are a bit like half-CRTCs. They have a location and fb, but
> don't drive outputs directly. Add support for handling them to the core
> KMS code.
>
> Acked-by: Alan Cox
> Reviewed-by: Rob Clark
> Reviewed-by: Daniel Vetter
> Signed-off-by: Jesse Ba
https://bugs.freedesktop.org/show_bug.cgi?id=27314
--- Comment #57 from Rafael ?vila de Esp?ndola
2011-11-08 17:43:24 PST ---
Created attachment 53309
--> https://bugs.freedesktop.org/attachment.cgi?id=53309
xorg log with the ati driver in fedora16
I have just installed fedora 16 on an "imac1
From: Jakob Bornecrantz
Snooping code expects this to be the case.
Signed-off-by: Jakob Bornecrantz
Reviewed-by: Thomas Hellstrom
---
drivers/gpu/drm/vmwgfx/vmwgfx_kms.c |4
1 files changed, 4 insertions(+), 0 deletions(-)
diff --git a/drivers/gpu/drm/vmwgfx/vmwgfx_kms.c
b/drivers/
From: Jakob Bornecrantz
Signed-off-by: Jakob Bornecrantz
Reviewed-by: Thomas Hellstrom
---
drivers/gpu/drm/vmwgfx/vmwgfx_kms.c |5 +++--
1 files changed, 3 insertions(+), 2 deletions(-)
diff --git a/drivers/gpu/drm/vmwgfx/vmwgfx_kms.c
b/drivers/gpu/drm/vmwgfx/vmwgfx_kms.c
index f3ab1fe..
From: Jakob Bornecrantz
Signed-off-by: Jakob Bornecrantz
Reviewed-by: Thomas Hellstrom
---
drivers/gpu/drm/vmwgfx/vmwgfx_kms.c |5 -
1 files changed, 4 insertions(+), 1 deletions(-)
diff --git a/drivers/gpu/drm/vmwgfx/vmwgfx_kms.c
b/drivers/gpu/drm/vmwgfx/vmwgfx_kms.c
index 03daefa..
A couple of bugfixes for vmwgfx kms.
___
dri-devel mailing list
dri-devel@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/dri-devel
2011/11/9 Greg Dietsche :
> Hi,
> I have a ASUS M4A89GTD motherboard and when I play back music in Rhythmbox,
> there is no sound (hdmi connection). Also, the playback speed is in a sort
> of fast forward (for example, after a few seconds of real time, rhythmbox
> shows something like 30 seconds in
On Tue, Nov 08, 2011 at 05:36:11PM -0500, Alex Deucher wrote:
> On Tue, Nov 8, 2011 at 5:06 PM, Daniel Vetter wrote:
> > On Mon, Nov 07, 2011 at 10:02:55AM -0800, Jesse Barnes wrote:
> >> Add new ioctls for getting and setting the current destination color
> >> key. ?This allows for simple overlay
70 matches
Mail list logo
