[PATCH 2/2 v2] drm/i915: pass ELD to HDMI/DP audio driver

2011-09-04 Thread Wu Fengguang
Add ELD support for Intel Eaglelake, IbexPeak/Ironlake, SandyBridge/CougarPoint and IvyBridge/PantherPoint chips. ELD (EDID-Like Data) describes to the HDMI/DP audio driver the audio capabilities of the plugged monitor. It's built and passed to audio driver in 2 steps: (1) at get_modes time, pars

Re: [PATCH 2/2] drm/i915: pass ELD to HDMI/DP audio driver

2011-09-04 Thread Wu Fengguang
I'd like to do more cleanups: > + int aud_cntl_st; > + int aud_cntrl_st2; s/aud_cntrl_st2/aud_cntl_st2/ > + if (IS_IVYBRIDGE(connector->dev)) { > + hdmiw_hdmiedid = GEN7_HDMIW_HDMIEDID_A; > + aud_cntl_st = GEN7_AUD_CNTRL_ST_A; > + aud_cntrl_st2 = G

[PATCH 2/2] drm/i915: pass ELD to HDMI/DP audio driver

2011-09-04 Thread Wu Fengguang
Add ELD support for Intel Eaglelake, IbexPeak/Ironlake, SandyBridge/CougarPoint and IvyBridge/PantherPoint chips. ELD (EDID-Like Data) describes to the HDMI/DP audio driver the audio capabilities of the plugged monitor. It's built and passed to audio driver in 2 steps: (1) at get_modes time, pars

[PATCH 1/2] drm: support routines for HDMI/DP ELD

2011-09-04 Thread Wu Fengguang
ELD (EDID-Like Data) describes to the HDMI/DP audio driver the audio capabilities of the plugged monitor. This adds drm_edid_to_eld() for converting EDID to ELD. The converted ELD will be saved in a new drm_connector.eld[128] data field. This is necessary because the graphics driver will need to f

[PATCH] RFC: omapdrm DRM/KMS driver for TI OMAP platforms

2011-09-04 Thread Daniel Vetter
On Sun, Sep 04, 2011 at 11:29:43AM -0500, Rob Clark wrote: > > Above set of get/put functions seem to do very little. Drop them for the > > first round? > > The intention is to do attach/detach_pages here.. and in case of > get/put_paddr do remapping into TILER if the buffer isn't physically > con

Re: [PATCH v5] drm/i915: pass ELD to HDMI/DP audio driver

2011-09-04 Thread Wu Fengguang
On Sun, Sep 04, 2011 at 06:57:23PM +0800, James Cloos wrote: > > "WF" == Wu Fengguang writes: > > WF> ... If only the stereo playback capability is reported, the user > WF> won't be able to start 8-channel playback; if the 8-channel ELD is > WF> reported, then user space applications may send

Re: [PATCH v5] drm/i915: pass ELD to HDMI/DP audio driver

2011-09-04 Thread Wu Fengguang
On Sun, Sep 04, 2011 at 08:08:37PM +0800, Chris Wilson wrote: > On Sun, 4 Sep 2011 05:15:10 +0800, Wu Fengguang > wrote: > > Changes from v4: remove a debug call to dump_stack(). > > Thanks to Bossart for catching this! > > --- > > > > Add ELD support for Intel Eaglelake, IbexPeak/Ironlake, > >

Re: [Intel-gfx] [PATCH v5] drm/i915: pass ELD to HDMI/DP audio driver

2011-09-04 Thread Wu Fengguang
Dear Paul, On Sun, Sep 04, 2011 at 07:11:54PM +0800, Paul Menzel wrote: > Dear Wu, > > > I hope that is your first name. My first name is Fengguang. "LAST NAME, FIRSTNAME" is the convention in Intel emails. However I often forgot this and pick whatever comes first...and happily accept both Feng

[PATCH] RFC: omapdrm DRM/KMS driver for TI OMAP platforms

2011-09-04 Thread Rob Clark
On Sun, Sep 4, 2011 at 2:49 PM, Daniel Vetter wrote: > On Sun, Sep 04, 2011 at 11:29:43AM -0500, Rob Clark wrote: >> > Above set of get/put functions seem to do very little. Drop them for the >> > first round? >> >> The intention is to do attach/detach_pages here.. and in case of >> get/put_paddr

Re: [PATCH] RFC: omapdrm DRM/KMS driver for TI OMAP platforms

2011-09-04 Thread Rob Clark
On Sun, Sep 4, 2011 at 2:49 PM, Daniel Vetter wrote: > On Sun, Sep 04, 2011 at 11:29:43AM -0500, Rob Clark wrote: >> > Above set of get/put functions seem to do very little. Drop them for the >> > first round? >> >> The intention is to do attach/detach_pages here.. and in case of >> get/put_paddr

[Intel-gfx] [PATCH v5] drm/i915: pass ELD to HDMI/DP audio driver

2011-09-04 Thread Paul Menzel
Dear Wu, I hope that is your first name. Am Sonntag, den 04.09.2011, 05:15 +0800 schrieb Wu Fengguang: > Changes from v4: remove a debug call to dump_stack(). > Thanks to Bossart for catching this! His first name is Pierre-Louis. I do not know how you address people at Intel though. > --- I t

[PATCH v5] drm/i915: pass ELD to HDMI/DP audio driver

2011-09-04 Thread Chris Wilson
On Sun, 4 Sep 2011 05:15:10 +0800, Wu Fengguang wrote: > Changes from v4: remove a debug call to dump_stack(). > Thanks to Bossart for catching this! > --- > > Add ELD support for Intel Eaglelake, IbexPeak/Ironlake, > SandyBridge/CougarPoint and IvyBridge/PantherPoint chips. > > ELD (EDID-Like

Re: [PATCH] RFC: omapdrm DRM/KMS driver for TI OMAP platforms

2011-09-04 Thread Daniel Vetter
On Sun, Sep 04, 2011 at 11:29:43AM -0500, Rob Clark wrote: > > Above set of get/put functions seem to do very little. Drop them for the > > first round? > > The intention is to do attach/detach_pages here.. and in case of > get/put_paddr do remapping into TILER if the buffer isn't physically > con

[PATCH] RFC: omapdrm DRM/KMS driver for TI OMAP platforms

2011-09-04 Thread Rob Clark
On Sat, Sep 3, 2011 at 1:53 PM, Daniel Vetter wrote: > Hi Rob, > > I've taken a look at your driver, some comments inline. Can't really > comment much on the kms side because of lack of expertise in that area. > > I think most can be trivially addressed by dropping the plugin layer ;-) > > Cheers,

Re: [PATCH] RFC: omapdrm DRM/KMS driver for TI OMAP platforms

2011-09-04 Thread Rob Clark
On Sat, Sep 3, 2011 at 1:53 PM, Daniel Vetter wrote: > Hi Rob, > > I've taken a look at your driver, some comments inline. Can't really > comment much on the kms side because of lack of expertise in that area. > > I think most can be trivially addressed by dropping the plugin layer ;-) > > Cheers,

[PATCH v5] drm/i915: pass ELD to HDMI/DP audio driver

2011-09-04 Thread James Cloos
> "WF" == Wu Fengguang writes: WF> ... If only the stereo playback capability is reported, the user WF> won't be able to start 8-channel playback; if the 8-channel ELD is WF> reported, then user space applications may send 8-channel samples WF> down, however the user may actually be listening

[PATCH v5] drm/i915: pass ELD to HDMI/DP audio driver

2011-09-04 Thread Wu Fengguang
Changes from v4: remove a debug call to dump_stack(). Thanks to Bossart for catching this! --- Add ELD support for Intel Eaglelake, IbexPeak/Ironlake, SandyBridge/CougarPoint and IvyBridge/PantherPoint chips. ELD (EDID-Like Data) describes to the HDMI/DP audio driver the audio capabilities of the

Re: [PATCH v5] drm/i915: pass ELD to HDMI/DP audio driver

2011-09-04 Thread Chris Wilson
On Sun, 4 Sep 2011 05:15:10 +0800, Wu Fengguang wrote: > Changes from v4: remove a debug call to dump_stack(). > Thanks to Bossart for catching this! > --- > > Add ELD support for Intel Eaglelake, IbexPeak/Ironlake, > SandyBridge/CougarPoint and IvyBridge/PantherPoint chips. > > ELD (EDID-Like D

Re: [Intel-gfx] [PATCH v5] drm/i915: pass ELD to HDMI/DP audio driver

2011-09-04 Thread Paul Menzel
Dear Wu, I hope that is your first name. Am Sonntag, den 04.09.2011, 05:15 +0800 schrieb Wu Fengguang: > Changes from v4: remove a debug call to dump_stack(). > Thanks to Bossart for catching this! His first name is Pierre-Louis. I do not know how you address people at Intel though. > --- I t

Re: [PATCH v5] drm/i915: pass ELD to HDMI/DP audio driver

2011-09-04 Thread James Cloos
> "WF" == Wu Fengguang writes: WF> ... If only the stereo playback capability is reported, the user WF> won't be able to start 8-channel playback; if the 8-channel ELD is WF> reported, then user space applications may send 8-channel samples WF> down, however the user may actually be listening