On Thu, Sep 1, 2011 at 10:06 PM, Inki Dae wrote:
> Hello Rob.
> Below is my comments. thank you.
>
>> -Original Message-
>> From: Rob Clark [mailto:robdcl...@gmail.com]
>> Sent: Thursday, September 01, 2011 1:02 AM
>> To: Inki Dae
>> Cc: airl...@linux.ie; dri-devel@lists.freedesktop.org;
>
e VMWGFX_DRIVER_DATE "20100927"
-#define VMWGFX_DRIVER_MAJOR 1
-#define VMWGFX_DRIVER_MINOR 4
+#define VMWGFX_DRIVER_DATE "20110901"
+#define VMWGFX_DRIVER_MAJOR 2
+#define VMWGFX_DRIVER_MINOR 0
#define VMWGFX_DRIVER_PATCHLEVEL 0
#define VMWGFX_FILE_PAGE_OFFSET 0x0010
#define
Will be needed for queries and drm event-driven throttling.
As a benefit, they help avoid stale user-space fence handles.
Signed-off-by: Thomas Hellstrom
Reviewed-by: Jakob Bornecrantz
---
drivers/gpu/drm/vmwgfx/Makefile |3 +-
drivers/gpu/drm/vmwgfx/vmwgfx_buffer.c | 26 +-
d
Break out on-demand enabling and disabling of fence irqs to make
the function more readable. Also make dev_priv->fence_queue_waiters an int
instead of an atomic_t since we only manipulate it with dev_priv->hw_mutex
held.
Signed-off-by: Thomas Hellstrom
Reviewed-by: Jakob Bornecrantz
---
drivers
This is needed before we introduce the fence objects.
Otherwise this will be even more confusing. The plan is to use the following:
seqno: A 32-bit sequence number that may be passed in the fifo.
marker: Objects, carrying a seqno, that track fifo submission time. They
are used for fifo lag based t
Since we don't allow user-space to map the fifo anymore,
add a parameter to get fifo hw version and
an ioctl to copy the 3D capabilities.
Signed-off-by: Thomas Hellstrom
Reviewed-by: Jakob Bornecranz
---
drivers/gpu/drm/vmwgfx/vmwgfx_drv.c |5 +++
drivers/gpu/drm/vmwgfx/vmwgfx_drv.h |
This was previously used by user-space to check whether a fence
sequence had passed or not.
With fence objects that's not needed anymore.
Signed-off-by: Thomas Hellstrom
Reviewed-by: Jakob Bornecrantz
---
drivers/gpu/drm/vmwgfx/vmwgfx_drv.h |1 -
drivers/gpu/drm/vmwgfx/vmwgfx_fifo.c
It doesn't seem like its needed. If this turns out to be an incorrect
assumption, we can reinstate it.
Signed-off-by: Thomas Hellstrom
Reviewed-by: Jakob Bornecrantz
---
drivers/gpu/drm/vmwgfx/vmwgfx_drv.c |6
drivers/gpu/drm/vmwgfx/vmwgfx_drv.h |2 -
drivers/gpu/drm/vmwgfx/vmwgfx_
It was only used for bringup debugging, and probably doesn't work
anymore. Remove it.
Signed-off-by: Thomas Hellstrom
Reviewed-by: Jakob Bornecrantz
---
drivers/gpu/drm/vmwgfx/vmwgfx_drv.c |5 -
drivers/gpu/drm/vmwgfx/vmwgfx_drv.h |6 --
drivers/gpu/drm/vmwgfx/vmwgfx_fifo.c
A set of changes and cleanups that affects the kernel-user-interface in a
non-backwards-compatible way. This is intended to be the last major bump
before we exit staging, but there may be a couple of minor bumps in
upcoming patches, as we add new features.
In-Reply-To:
Hello Rob.
Below is my comments. thank you.
> -Original Message-
> From: Rob Clark [mailto:robdclark at gmail.com]
> Sent: Thursday, September 01, 2011 1:02 AM
> To: Inki Dae
> Cc: airlied at linux.ie; dri-devel at lists.freedesktop.org;
> sw0312.kim at samsung.com; linux-kernel at vger.ke
https://bugzilla.kernel.org/show_bug.cgi?id=42172
Alex Deucher changed:
What|Removed |Added
CC||alexdeuc...@gmail.com
--- Comment #4 f
Thanks for reviewing, please see inline.
On 09/01/2011 08:02 PM, Konrad Rzeszutek Wilk wrote:
> On Wed, Aug 31, 2011 at 09:42:51AM +0200, Thomas Hellstrom wrote:
>
>> Signed-off-by: Thomas Hellstrom
>> Reviewed-by: Jos? Fonseca
>> ---
>> drivers/gpu/drm/vmwgfx/svga_reg.h | 96
>> +++
On Mon, Aug 29, 2011 at 07:20:16PM +0300, Pasi K?rkk?inen wrote:
> Hello,
>
> I have a laptop with Mobility Radeon HD 3650, and the opensource radeon
> driver makes
> the laptop overheat and crash (or kernel does thermal emergency shutdowns).
> Even when the laptop is totally *idle* the system ov
On Thu, Sep 1, 2011 at 8:06 AM, Inki Dae wrote:
>> >> > +struct samsung_drm_gem_obj *
>> >> > + ? ? ? ? ? ? ? find_samsung_drm_gem_object(struct drm_file
> *file_priv,
>> >> > + ? ? ? ? ? ? ? ? ? ? ? struct drm_device *dev, unsigned int handle)
>> >> > +{
>> >> > + ? ? ? struct drm_gem_object *gem
On Thu, Sep 1, 2011 at 8:02 PM, Kyungmin Park wrote:
>>> Just thinking hypothetically.. what if some future device had two hdmi
>>> controllers. ?Then you'd want two instances of the same display
>>> object.
>>>
>>> Although it seems this API is just internal to the DRM driver (which I
>>> had not
On Don, 2011-09-01 at 13:46 -0400, alexdeucher at gmail.com wrote:
> From: Alex Deucher
>
> If the bios or OS sets the pci max read request size to 0 or an
> invalid value (6,7), it can result in a hang or slowdown. Check
> and set it to something sane if it's invalid.
>
> Fixes:
> https://bug
https://bugzilla.kernel.org/show_bug.cgi?id=25052
Bernhard M. Wiedemann changed:
What|Removed |Added
CC||kernelbmw at lsmod.de
--- Com
On Thu, Sep 1, 2011 at 8:06 AM, Inki Dae wrote:
>> >> > +struct samsung_drm_gem_obj *
>> >> > + find_samsung_drm_gem_object(struct drm_file
> *file_priv,
>> >> > + struct drm_device *dev, unsigned int handle)
>> >> > +{
>> >> > + struct drm_gem_object *gem
On Thu, Sep 1, 2011 at 8:02 PM, Kyungmin Park wrote:
>>> Just thinking hypothetically.. what if some future device had two hdmi
>>> controllers. Then you'd want two instances of the same display
>>> object.
>>>
>>> Although it seems this API is just internal to the DRM driver (which I
>>> had not
https://bugzilla.kernel.org/show_bug.cgi?id=42172
--- Comment #3 from nissa...@gmail.com 2011-09-02 00:59:20 ---
More than 8 hours have passed without a single glitch (same as before..
glxgears, web browser, wesnoth, etc.) so yeah, it appears that
b03e7495a862b028294f59fc87286d6d78ee7fa1 is m
https://bugzilla.kernel.org/show_bug.cgi?id=39832
--- Comment #11 from Michel Dänzer 2011-08-29 17:46:25 ---
If you want to consider this a regression, it was caused by the currently best
known fix for another regression: enabling HDMI audio by default caused blank
screens and display proble
https://bugzilla.kernel.org/show_bug.cgi?id=42172
--- Comment #2 from nissarin at gmail.com 2011-09-01 16:42:41 ---
OK, after some "extensive" testing (as in glxgears x 20, duh)
b03e7495a862b028294f59fc87286d6d78ee7fa1 "crashed" near 30 minute mark.
Currently I'm running 5f66d2b58ca879e70740c
https://bugs.freedesktop.org/show_bug.cgi?id=27069
--- Comment #4 from Stefan Dösinger 2011-09-01
16:21:54 PDT ---
(In reply to comment #3)
> This problem still exists,
I forgot to add the usual software version info:
Kernel: 3.0.4-gentoo
Xorg: X.Org X Server 1.10.2
DDX: xf86-video-ati-6.14.2
M
https://bugs.freedesktop.org/show_bug.cgi?id=27069
--- Comment #4 from Stefan D?singer 2011-09-01
16:21:54 PDT ---
(In reply to comment #3)
> This problem still exists,
I forgot to add the usual software version info:
Kernel: 3.0.4-gentoo
Xorg: X.Org X Server 1.10.2
DDX: xf86-video-ati-6.14.2
M
https://bugs.freedesktop.org/show_bug.cgi?id=27069
--- Comment #3 from Stefan Dösinger 2011-09-01
16:20:12 PDT ---
This problem still exists, UMS(as far as 3D is still working with it) is much
faster than KMS. Unfortunately the only app that's still working with UMS in
Mesa 7.11 is glxgears.
On
https://bugs.freedesktop.org/show_bug.cgi?id=27069
--- Comment #3 from Stefan D?singer 2011-09-01
16:20:12 PDT ---
This problem still exists, UMS(as far as 3D is still working with it) is much
faster than KMS. Unfortunately the only app that's still working with UMS in
Mesa 7.11 is glxgears.
On
https://bugzilla.kernel.org/show_bug.cgi?id=42172
Niels Ole Salscheider changed:
What|Removed |Added
CC||niels_ole at salscheider-onlin
https://bugzilla.kernel.org/show_bug.cgi?id=42172
Summary: WARNING: at drivers/gpu/drm/radeon/radeon_fence.c:267
radeon_fence_wait+0x39f/0x3d0()
Product: Drivers
Version: 2.5
Kernel Version: 3.1-rc3
Platform: All
OS/Version
On Wed, Aug 31, 2011 at 09:42:55AM +0200, Thomas Hellstrom wrote:
> Guest Memory Regions 2 is a way to bind pages to the GPU, but using
> the FIFO instead of an io-submitted descriptor chain.
>
> Signed-off-by: Thomas Hellstrom
> Reviewed-by: Jakob Bornecantz
> ---
> drivers/gpu/drm/vmwgfx/vmwg
On Wed, Aug 31, 2011 at 09:42:51AM +0200, Thomas Hellstrom wrote:
> Signed-off-by: Thomas Hellstrom
> Reviewed-by: Jos? Fonseca
> ---
> drivers/gpu/drm/vmwgfx/svga_reg.h | 96
> ++-
> drivers/gpu/drm/vmwgfx/vmwgfx_drv.c |4 ++
> 2 files changed, 99 insert
From: Alex Deucher
If the bios or OS sets the pci max read request size to 0 or an
invalid value (6,7), it can result in a hang or slowdown. Check
and set it to something sane if it's invalid.
Fixes:
https://bugzilla.kernel.org/show_bug.cgi?id=42162
v2: use pci reg defines from include/linux/p
https://bugs.freedesktop.org/show_bug.cgi?id=40531
--- Comment #3 from Vadim 2011-09-01 13:20:38 PDT ---
Probably the driver can't do anything other than report the "out of memory"
error (error code -12 in your dmesg log). The game just shouldn't use such huge
textures, it shouldn't use MAX_TEXTU
e VMWGFX_DRIVER_DATE "20100927"
-#define VMWGFX_DRIVER_MAJOR 1
-#define VMWGFX_DRIVER_MINOR 4
+#define VMWGFX_DRIVER_DATE "20110901"
+#define VMWGFX_DRIVER_MAJOR 2
+#define VMWGFX_DRIVER_MINOR 0
#define VMWGFX_DRIVER_PATCHLEVEL 0
#define VMWGFX_FILE_PAGE_OFFSET 0x0010
#define
Will be needed for queries and drm event-driven throttling.
As a benefit, they help avoid stale user-space fence handles.
Signed-off-by: Thomas Hellstrom
Reviewed-by: Jakob Bornecrantz
---
drivers/gpu/drm/vmwgfx/Makefile |3 +-
drivers/gpu/drm/vmwgfx/vmwgfx_buffer.c | 26 +-
d
Break out on-demand enabling and disabling of fence irqs to make
the function more readable. Also make dev_priv->fence_queue_waiters an int
instead of an atomic_t since we only manipulate it with dev_priv->hw_mutex
held.
Signed-off-by: Thomas Hellstrom
Reviewed-by: Jakob Bornecrantz
---
drivers
This is needed before we introduce the fence objects.
Otherwise this will be even more confusing. The plan is to use the following:
seqno: A 32-bit sequence number that may be passed in the fifo.
marker: Objects, carrying a seqno, that track fifo submission time. They
are used for fifo lag based t
Since we don't allow user-space to map the fifo anymore,
add a parameter to get fifo hw version and
an ioctl to copy the 3D capabilities.
Signed-off-by: Thomas Hellstrom
Reviewed-by: Jakob Bornecranz
---
drivers/gpu/drm/vmwgfx/vmwgfx_drv.c |5 +++
drivers/gpu/drm/vmwgfx/vmwgfx_drv.h |
This was previously used by user-space to check whether a fence
sequence had passed or not.
With fence objects that's not needed anymore.
Signed-off-by: Thomas Hellstrom
Reviewed-by: Jakob Bornecrantz
---
drivers/gpu/drm/vmwgfx/vmwgfx_drv.h |1 -
drivers/gpu/drm/vmwgfx/vmwgfx_fifo.c
It doesn't seem like its needed. If this turns out to be an incorrect
assumption, we can reinstate it.
Signed-off-by: Thomas Hellstrom
Reviewed-by: Jakob Bornecrantz
---
drivers/gpu/drm/vmwgfx/vmwgfx_drv.c |6
drivers/gpu/drm/vmwgfx/vmwgfx_drv.h |2 -
drivers/gpu/drm/vmwgfx/vmwgfx_
https://bugs.freedesktop.org/show_bug.cgi?id=40531
--- Comment #3 from Vadim 2011-09-01 13:20:38 PDT ---
Probably the driver can't do anything other than report the "out of memory"
error (error code -12 in your dmesg log). The game just shouldn't use such huge
textures, it shouldn't use MAX_TEXTU
It was only used for bringup debugging, and probably doesn't work
anymore. Remove it.
Signed-off-by: Thomas Hellstrom
Reviewed-by: Jakob Bornecrantz
---
drivers/gpu/drm/vmwgfx/vmwgfx_drv.c |5 -
drivers/gpu/drm/vmwgfx/vmwgfx_drv.h |6 --
drivers/gpu/drm/vmwgfx/vmwgfx_fifo.c
A set of changes and cleanups that affects the kernel-user-interface in a
non-backwards-compatible way. This is intended to be the last major bump
before we exit staging, but there may be a couple of minor bumps in
upcoming patches, as we add new features.
In-Reply-To:
__
From: Alex Deucher
If the bios or OS sets the pci max read request size to 0 or an
invalid value (6,7), it can result in a hang or slowdown. Check
and set it to something sane if it's invalid.
Fixes:
https://bugzilla.kernel.org/show_bug.cgi?id=42162
Signed-off-by: Alex Deucher
Cc: stable at k
Hello Thomas.
> -Original Message-
> From: Thomas Hellstrom [mailto:thomas at shipmail.org]
> Sent: Wednesday, August 31, 2011 5:39 PM
> To: Inki Dae
> Cc: airlied at linux.ie; dri-devel at lists.freedesktop.org;
> sw0312.kim at samsung.com; linux-kernel at vger.kernel.org;
> kyungmin.park
Thanks for reviewing, please see inline.
On 09/01/2011 08:02 PM, Konrad Rzeszutek Wilk wrote:
On Wed, Aug 31, 2011 at 09:42:51AM +0200, Thomas Hellstrom wrote:
Signed-off-by: Thomas Hellstrom
Reviewed-by: José Fonseca
---
drivers/gpu/drm/vmwgfx/svga_reg.h | 96
On Mon, Aug 29, 2011 at 07:20:16PM +0300, Pasi Kärkkäinen wrote:
> Hello,
>
> I have a laptop with Mobility Radeon HD 3650, and the opensource radeon
> driver makes
> the laptop overheat and crash (or kernel does thermal emergency shutdowns).
> Even when the laptop is totally *idle* the system ov
https://bugzilla.kernel.org/show_bug.cgi?id=25052
Bernhard M. Wiedemann changed:
What|Removed |Added
CC||kernel...@lsmod.de
--- Commen
On Wed, Aug 31, 2011 at 09:42:51AM +0200, Thomas Hellstrom wrote:
> Signed-off-by: Thomas Hellstrom
> Reviewed-by: José Fonseca
> ---
> drivers/gpu/drm/vmwgfx/svga_reg.h | 96
> ++-
> drivers/gpu/drm/vmwgfx/vmwgfx_drv.c |4 ++
> 2 files changed, 99 insert
On Don, 2011-09-01 at 13:46 -0400, alexdeuc...@gmail.com wrote:
> From: Alex Deucher
>
> If the bios or OS sets the pci max read request size to 0 or an
> invalid value (6,7), it can result in a hang or slowdown. Check
> and set it to something sane if it's invalid.
>
> Fixes:
> https://bugzil
From: Alex Deucher
If the bios or OS sets the pci max read request size to 0 or an
invalid value (6,7), it can result in a hang or slowdown. Check
and set it to something sane if it's invalid.
Fixes:
https://bugzilla.kernel.org/show_bug.cgi?id=42162
v2: use pci reg defines from include/linux/p
From: Alex Deucher
If the bios or OS sets the pci max read request size to 0 or an
invalid value (6,7), it can result in a hang or slowdown. Check
and set it to something sane if it's invalid.
Fixes:
https://bugzilla.kernel.org/show_bug.cgi?id=42162
Signed-off-by: Alex Deucher
Cc: sta...@kern
https://bugzilla.kernel.org/show_bug.cgi?id=42172
--- Comment #2 from nissa...@gmail.com 2011-09-01 16:42:41 ---
OK, after some "extensive" testing (as in glxgears x 20, duh)
b03e7495a862b028294f59fc87286d6d78ee7fa1 "crashed" near 30 minute mark.
Currently I'm running 5f66d2b58ca879e70740c824
On Mit, 2011-08-31 at 23:54 +0200, Tormod Volden wrote:
> From: Tormod Volden
>
> This was previously done for r300 only. Use %016llX instead of %08X for
> printing the table address.
>
> Also fix typos in gart warning messages.
>
> Signed-off-by: Tormod Volden
Reviewed-by: Michel D?nzer
https://bugzilla.kernel.org/show_bug.cgi?id=42172
Niels Ole Salscheider changed:
What|Removed |Added
CC||niels_ole@salscheider-onlin
https://bugs.freedesktop.org/show_bug.cgi?id=40531
--- Comment #2 from Vadim 2011-09-01 08:40:41 PDT ---
Created an attachment (id=50816)
View: https://bugs.freedesktop.org/attachment.cgi?id=50816
Review: https://bugs.freedesktop.org/review?bug=40531&attachment=50816
game patch
The game tries
https://bugs.freedesktop.org/show_bug.cgi?id=40531
--- Comment #2 from Vadim 2011-09-01 08:40:41 PDT ---
Created an attachment (id=50816)
View: https://bugs.freedesktop.org/attachment.cgi?id=50816
Review: https://bugs.freedesktop.org/review?bug=40531&attachment=50816
game patch
The game tries
https://bugzilla.kernel.org/show_bug.cgi?id=42172
Summary: WARNING: at drivers/gpu/drm/radeon/radeon_fence.c:267
radeon_fence_wait+0x39f/0x3d0()
Product: Drivers
Version: 2.5
Kernel Version: 3.1-rc3
Platform: All
OS/Version
https://bugs.freedesktop.org/show_bug.cgi?id=40531
--- Comment #1 from roughl 2011-09-01 08:24:35 PDT ---
I noticed some console output:
% fretsonfire
radeon: The kernel rejected CS, see dmesg for more information.
% dmesg|grep radeon
[1.201137] [drm] radeon defaulting to kernel modesetting.
https://bugs.freedesktop.org/show_bug.cgi?id=40531
--- Comment #1 from roughl 2011-09-01 08:24:35 PDT ---
I noticed some console output:
% fretsonfire
radeon: The kernel rejected CS, see dmesg for more information.
% dmesg|grep radeon
[1.201137] [drm] radeon defaulting to kernel modesetting.
https://bugs.freedesktop.org/show_bug.cgi?id=40554
Summary: r200 falls back to software when clearing FBOs
Product: Mesa
Version: git
Platform: Other
OS/Version: All
Status: NEW
Severity: normal
Priority: medium
https://bugs.freedesktop.org/show_bug.cgi?id=40554
Summary: r200 falls back to software when clearing FBOs
Product: Mesa
Version: git
Platform: Other
OS/Version: All
Status: NEW
Severity: normal
Priority: medium
https://bugs.freedesktop.org/show_bug.cgi?id=40552
Summary: r200 crashes in glclear when running the wine d3d
tests.
Product: Mesa
Version: git
Platform: x86 (IA32)
OS/Version: All
Status: NEW
Severity: no
https://bugs.freedesktop.org/show_bug.cgi?id=40552
Summary: r200 crashes in glclear when running the wine d3d
tests.
Product: Mesa
Version: git
Platform: x86 (IA32)
OS/Version: All
Status: NEW
Severity: no
Hello Rob.
Below is my comments. thank you.
> -Original Message-
> From: Rob Clark [mailto:robdcl...@gmail.com]
> Sent: Thursday, September 01, 2011 1:02 AM
> To: Inki Dae
> Cc: airl...@linux.ie; dri-devel@lists.freedesktop.org;
> sw0312@samsung.com; linux-ker...@vger.kernel.org;
> kyu
https://bugs.freedesktop.org/show_bug.cgi?id=40423
--- Comment #15 from Jure Repinc 2011-09-01 05:29:39 PDT
---
Ups forgot the debugging symbols for mesa:
$ valgrind --tool=memcheck ./glxtest
==28048== Memcheck, a memory error detector
==28048== Copyright (C) 2002-2010, and GNU GPL'd, by Julian
https://bugs.freedesktop.org/show_bug.cgi?id=40423
--- Comment #15 from Jure Repinc 2011-09-01 05:29:39
PDT ---
Ups forgot the debugging symbols for mesa:
$ valgrind --tool=memcheck ./glxtest
==28048== Memcheck, a memory error detector
==28048== Copyright (C) 2002-2010, and GNU GPL'd, by Julian
https://bugs.freedesktop.org/show_bug.cgi?id=40423
--- Comment #14 from Jure Repinc 2011-09-01 05:10:06 PDT
---
This is what valgrind gives on my laptop with ATI Mobility Radeon 5470:
$ valgrind --tool=memcheck ./glxtest
==20468== Memcheck, a memory error detector
==20468== Copyright (C) 2002-2
https://bugs.freedesktop.org/show_bug.cgi?id=40423
--- Comment #14 from Jure Repinc 2011-09-01 05:10:06
PDT ---
This is what valgrind gives on my laptop with ATI Mobility Radeon 5470:
$ valgrind --tool=memcheck ./glxtest
==20468== Memcheck, a memory error detector
==20468== Copyright (C) 2002-2
69 matches
Mail list logo
