On Don, 2011-07-07 at 09:10 +1000, Ben Skeggs wrote:
> On Wed, 2011-07-06 at 09:38 +0200, Michel Dänzer wrote:
> > On Mon, 2011-07-04 at 13:16 +1000, skeg...@gmail.com wrote:
> > > From: Ben Skeggs
> > >
> > > Signed-off-by: Ben Skeggs
> > > ---
> > > drivers/gpu/drm/drm_irq.c | 15 +
commit closes/addresses in the commit
message.
[?]
Thanks,
Paul
-- next part --
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 198 bytes
Desc: This is a digitally signed message part
URL:
<http://lists.freedesktop.org/
https://bugs.freedesktop.org/show_bug.cgi?id=38800
--- Comment #28 from Alex Deucher 2011-07-06 20:07:58 PDT ---
(In reply to comment #27)
> (In reply to comment #22)
> > FWIW, the pageflip interrupts weren't too reliable at least on 6xx, but they
> > seemed to work ok on 7xx+.
>
> Thanks for t
https://bugs.freedesktop.org/show_bug.cgi?id=38800
--- Comment #28 from Alex Deucher 2011-07-06 20:07:58 PDT
---
(In reply to comment #27)
> (In reply to comment #22)
> > FWIW, the pageflip interrupts weren't too reliable at least on 6xx, but they
> > seemed to work ok on 7xx+.
>
> Thanks for
Alpha needs to have available the system bus address for the Radeon's
local memory, so that it can be used in ttm_bo_vm_fault(), when building
the PTEs for accessing that VRAM. So, we make bus.addr hold the ioremap()
return, and then we can modify bus.base appropriately for use during page
fault
The radeon pageflip ioctl handler delayed submitting the pageflip to
hardware until the vblank IRQ handler. On AMD Fusion (PALM GPU, G-T56N
CPU), when using a reduced blanking CVT mode, a pageflip submitted to
hardware in the IRQ handler failed to complete before the end of the
vblank, resulting in
On Wednesday 6 July 2011, Jerome Glisse wrote:
> On Wed, Jul 6, 2011 at 12:29 PM, Simon Farnsworth
>
> > In particular, I'm a bit hazy about what the fence in pageflip is
> > doing - I assume it's there to synchronize drawing and scanout, so
> > that I don't flip to a buffer that's still being dr
https://bugs.freedesktop.org/show_bug.cgi?id=38800
--- Comment #27 from Mario Kleiner 2011-07-06
18:43:42 PDT ---
(In reply to comment #22)
> FWIW, the pageflip interrupts weren't too reliable at least on 6xx, but they
> seemed to work ok on 7xx+.
Thanks for the info Alex. Can you define "work
https://bugs.freedesktop.org/show_bug.cgi?id=38800
--- Comment #27 from Mario Kleiner
2011-07-06 18:43:42 PDT ---
(In reply to comment #22)
> FWIW, the pageflip interrupts weren't too reliable at least on 6xx, but they
> seemed to work ok on 7xx+.
Thanks for the info Alex. Can you define "work
https://bugs.freedesktop.org/show_bug.cgi?id=38800
--- Comment #26 from Mario Kleiner 2011-07-06
18:02:26 PDT ---
Ok, i looked at the patch. The way it is now it won't work reliably and is
vulnerable to the races we tried to remove in the current implementation.
First, as far as i understood, t
https://bugs.freedesktop.org/show_bug.cgi?id=38800
--- Comment #26 from Mario Kleiner
2011-07-06 18:02:26 PDT ---
Ok, i looked at the patch. The way it is now it won't work reliably and is
vulnerable to the races we tried to remove in the current implementation.
First, as far as i understood, t
The radeon pageflip ioctl handler delayed submitting the pageflip to
hardware until the vblank IRQ handler. On AMD Fusion (PALM GPU, G-T56N
CPU), when using a reduced blanking CVT mode, a pageflip submitted to
hardware in the IRQ handler failed to complete before the end of the
vblank, resulting in
On Thu, Jul 07, 2011 at 01:30:12AM +0200, rei...@googlemail.com wrote:
> From: Thomas Reim
>
> Provides function drm_edid_header_is_valid() for EDID header check
> and replaces EDID header check part of function drm_edid_block_valid()
> by a call of drm_edid_header_is_valid().
> T
Alpha needs to have available the system bus address for the Radeon's
local memory, so that it can be used in ttm_bo_vm_fault(), when building
the PTEs for accessing that VRAM. So, we make bus.addr hold the ioremap()
return, and then we can modify bus.base appropriately for use during page
fault
On Thu, Jul 07, 2011 at 01:30:12AM +0200, reimth at googlemail.com wrote:
> From: Thomas Reim
>
> Provides function drm_edid_header_is_valid() for EDID header check
> and replaces EDID header check part of function drm_edid_block_valid()
> by a call of drm_edid_header_is_valid().
>
From: Thomas Reim
Provides function drm_edid_header_is_valid() for EDID header check
and replaces EDID header check part of function drm_edid_block_valid()
by a call of drm_edid_header_is_valid().
This is a prerequisite to extend DDC probing, e. g. in function
radeon_ddc_probe
From: Thomas Reim
Fixes bug https://bugs.launchpad.net/ubuntu/+source/linux/+bug/722806:
Some integrated ATI Radeon chipset implementations with add-on HDMI card
(e. g. Asus M2A-VM HDMI) indicate the availability of a DDC even
when the add-on card is not plugged in or HDMI is disa
From: Thomas Reim
Log PCI subsystem vendor and subsystem device ID in addition to
PCI vendor and device ID during kernel mode initialisation. This helps
to better identify radeon devices of third-party vendors, e. g. for
bug analysis.
Tested for kernel 2.35, 2.38 and 3.0 on A
From: Thomas Reim
Dear Alex,
> > From: Thomas Reim
> >
> >Some integrated ATI Radeon chipset implementations
> >with add-on HDMI card (e. g. Asus M2A-VM HDMI) indicate the availability
> >of a DDC even when the add-on card is not plugged in or HDMI is disabled
> >in BIOS setup.
On Wed, 2011-07-06 at 09:38 +0200, Michel Dänzer wrote:
> On Mon, 2011-07-04 at 13:16 +1000, skeg...@gmail.com wrote:
> > From: Ben Skeggs
> >
> > Signed-off-by: Ben Skeggs
> > ---
> > drivers/gpu/drm/drm_irq.c | 15 +--
> > 1 files changed, 9 insertions(+), 6 deletions(-)
> >
>
Only affects BE systems.
Signed-off-by: Alex Deucher
Cc: stable at kernel.org
---
drivers/gpu/drm/radeon/evergreend.h |2 +-
drivers/gpu/drm/radeon/r600d.h |2 +-
2 files changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/gpu/drm/radeon/evergreend.h
b/drivers/gpu/drm/ra
Signed-off-by: Alex Deucher
Cc: stable at kernel.org
---
drivers/gpu/drm/radeon/evergreend.h |2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/drivers/gpu/drm/radeon/evergreend.h
b/drivers/gpu/drm/radeon/evergreend.h
index 1636e34..5a44afb 100644
--- a/drivers/gpu/drm/rad
https://bugs.freedesktop.org/show_bug.cgi?id=38800
--- Comment #25 from Alex Deucher 2011-07-06 14:52:46 PDT ---
You can select where you want the double buffered update to take place by
adjusting the D*MODE_MASTER_UPDATE_MODE regs (pre-avivo has similar bits).
--
Configure bugmail: https://bug
https://bugs.freedesktop.org/show_bug.cgi?id=38800
--- Comment #25 from Alex Deucher 2011-07-06 14:52:46 PDT
---
You can select where you want the double buffered update to take place by
adjusting the D*MODE_MASTER_UPDATE_MODE regs (pre-avivo has similar bits).
--
Configure bugmail: https://bu
https://bugs.freedesktop.org/show_bug.cgi?id=38800
--- Comment #24 from Jerome Glisse 2011-07-06 14:35:49
PDT ---
So rereading the spec it's all about computing vblank lenght and adding it to
timestamp at vblank interrupt.
Seems like the most reliable solution
--
Configure bugmail: https://bu
https://bugs.freedesktop.org/show_bug.cgi?id=38800
--- Comment #24 from Jerome Glisse 2011-07-06
14:35:49 PDT ---
So rereading the spec it's all about computing vblank lenght and adding it to
timestamp at vblank interrupt.
Seems like the most reliable solution
--
Configure bugmail: https://bu
On Wed, Jul 6, 2011 at 2:30 PM, wrote:
> From: Jerome Glisse
>
> ib pool weren't free for various newer asic on module unload.
> This doesn't cause much arm but still could be candidate for
> stable.
>
> Signed-off-by: Jerome Glisse
Reviewed-by: Alex Deucher
> ---
> ?drivers/gpu/drm/radeon/e
From: Jerome Glisse
ib pool weren't free for various newer asic on module unload.
This doesn't cause much arm but still could be candidate for
stable.
Signed-off-by: Jerome Glisse
---
drivers/gpu/drm/radeon/evergreen.c |1 +
drivers/gpu/drm/radeon/ni.c|1 +
drivers/gpu/drm/rade
https://bugs.freedesktop.org/show_bug.cgi?id=38800
--- Comment #23 from Jerome Glisse 2011-07-06 14:25:54
PDT ---
So what exactly the timestamp should correspond to ? For me vblank is good
enough and looking at specification its says that it's when the hw register are
using the new value. So eit
Here are the kernel logs with and without the patch for better
visualisation of the changes:
1. dmesg after applying the patch:
[0.00] Initializing cgroup subsys cpuset
[0.00] Initializing cgroup subsys cpu
[0.00] Linux version 3.0-3-generic (root at Mark-Aurel) (gcc
versi
https://bugs.freedesktop.org/show_bug.cgi?id=38800
--- Comment #23 from Jerome Glisse 2011-07-06
14:25:54 PDT ---
So what exactly the timestamp should correspond to ? For me vblank is good
enough and looking at specification its says that it's when the hw register are
using the new value. So eit
https://bugs.freedesktop.org/show_bug.cgi?id=38800
--- Comment #22 from Alex Deucher 2011-07-06 14:13:27 PDT ---
FWIW, the pageflip interrupts weren't too reliable at least on 6xx, but they
seemed to work ok on 7xx+. Also, I can see problems where you might not get
interrupts for some flips if a
https://bugs.freedesktop.org/show_bug.cgi?id=38800
--- Comment #22 from Alex Deucher 2011-07-06 14:13:27 PDT
---
FWIW, the pageflip interrupts weren't too reliable at least on 6xx, but they
seemed to work ok on 7xx+. Also, I can see problems where you might not get
interrupts for some flips if
https://bugs.freedesktop.org/show_bug.cgi?id=38800
--- Comment #21 from Mario Kleiner 2011-07-06
13:54:14 PDT ---
@Simon: Michel and your testcode is right, the pageflip is only programmed
about 2 scanlines after the end of vblank, so the crtc waits for another full
refresh cycle before flipping
Am Mittwoch, den 06.07.2011, 19:04 +0100 schrieb Simon Farnsworth:
> The radeon pageflip ioctl handler delayed submitting the pageflip to
> hardware until the vblank IRQ handler. On AMD Fusion (PALM GPU, G-T56N
> CPU), when using a reduced blanking CVT mode, a pageflip submitted to
> hardware in th
https://bugs.freedesktop.org/show_bug.cgi?id=38800
--- Comment #21 from Mario Kleiner
2011-07-06 13:54:14 PDT ---
@Simon: Michel and your testcode is right, the pageflip is only programmed
about 2 scanlines after the end of vblank, so the crtc waits for another full
refresh cycle before flipping
Only affects BE systems.
Signed-off-by: Alex Deucher
Cc: sta...@kernel.org
---
drivers/gpu/drm/radeon/evergreend.h |2 +-
drivers/gpu/drm/radeon/r600d.h |2 +-
2 files changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/gpu/drm/radeon/evergreend.h
b/drivers/gpu/drm/radeo
On Wed, Jul 6, 2011 at 12:29 PM, Simon Farnsworth
wrote:
> The radeon pageflip ioctl handler delayed submitting the pageflip to
> hardware until the vblank IRQ handler. On AMD Fusion (PALM GPU, G-T56N
> CPU), when using a reduced blanking CVT mode, a pageflip submitted to
> hardware in the IRQ han
Signed-off-by: Alex Deucher
Cc: sta...@kernel.org
---
drivers/gpu/drm/radeon/evergreend.h |2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/drivers/gpu/drm/radeon/evergreend.h
b/drivers/gpu/drm/radeon/evergreend.h
index 1636e34..5a44afb 100644
--- a/drivers/gpu/drm/radeon
From: Thomas Reim
Some integrated ATI Radeon chipset implementations
with add-on HDMI card (e. g. Asus M2A-VM HDMI) indicate the availability
of a DDC even when the add-on card is not plugged in or HDMI is disabled
in BIOS setup. In this case, drm_get_edid() and drm_edid_block_val
On Wed, Jul 6, 2011 at 11:39 AM, Alex Deucher wrote:
> On Wed, Jul 6, 2011 at 6:09 AM, ? wrote:
>> From: Thomas Reim
>>
>> ? ?Some integrated ATI Radeon chipset implementations
>> ? ?with add-on HDMI card (e. g. Asus M2A-VM HDMI) indicate the availability
>> ? ?of a DDC even when the add-on card
On Wed, Jul 6, 2011 at 6:09 AM, wrote:
> From: Thomas Reim
>
> ? ?Some integrated ATI Radeon chipset implementations
> ? ?with add-on HDMI card (e. g. Asus M2A-VM HDMI) indicate the availability
> ? ?of a DDC even when the add-on card is not plugged in or HDMI is disabled
> ? ?in BIOS setup. In
Dear Alex,
sorry for the long delay. I have updated the patch according to the
comments in your last e-mail (see below).
I've added function radeon_connector_needs_extended_probe() and flag
radeon_connector->requires_extended_probe that provide the means to
force on a board,connector basis to che
On Wed, Jul 6, 2011 at 2:30 PM, wrote:
> From: Jerome Glisse
>
> ib pool weren't free for various newer asic on module unload.
> This doesn't cause much arm but still could be candidate for
> stable.
>
> Signed-off-by: Jerome Glisse
Reviewed-by: Alex Deucher
> ---
> drivers/gpu/drm/radeon/e
From: Jerome Glisse
ib pool weren't free for various newer asic on module unload.
This doesn't cause much arm but still could be candidate for
stable.
Signed-off-by: Jerome Glisse
---
drivers/gpu/drm/radeon/evergreen.c |1 +
drivers/gpu/drm/radeon/ni.c|1 +
drivers/gpu/drm/rade
The radeon pageflip ioctl handler delayed submitting the pageflip to
hardware until the vblank IRQ handler. On AMD Fusion (PALM GPU, G-T56N
CPU), when using a reduced blanking CVT mode, a pageflip submitted to
hardware in the IRQ handler failed to complete before the end of the
vblank, resulting in
https://bugs.freedesktop.org/show_bug.cgi?id=36327
--- Comment #20 from Karesz L. 2011-07-06 10:48:51
PDT ---
Okay, I had some time, and tried this:
I've made this script:
#!/bin/sh
sync
echo 1 > /sys/power/pm_trace
echo mem > /sys/power/state
(from here: http://lxr.linux.no/linux+v2.6.34.1/D
https://bugs.freedesktop.org/show_bug.cgi?id=36327
--- Comment #20 from Karesz L. 2011-07-06
10:48:51 PDT ---
Okay, I had some time, and tried this:
I've made this script:
#!/bin/sh
sync
echo 1 > /sys/power/pm_trace
echo mem > /sys/power/state
(from here: http://lxr.linux.no/linux+v2.6.34.1/D
On Wednesday 6 July 2011, Jerome Glisse wrote:
> On Wed, Jul 6, 2011 at 12:29 PM, Simon Farnsworth
>
> > In particular, I'm a bit hazy about what the fence in pageflip is
> > doing - I assume it's there to synchronize drawing and scanout, so
> > that I don't flip to a buffer that's still being dr
On Wed, Jul 6, 2011 at 12:29 PM, Simon Farnsworth
wrote:
> The radeon pageflip ioctl handler delayed submitting the pageflip to
> hardware until the vblank IRQ handler. On AMD Fusion (PALM GPU, G-T56N
> CPU), when using a reduced blanking CVT mode, a pageflip submitted to
> hardware in the IRQ han
On Mon, 2011-07-04 at 13:16 +1000, skeggsb at gmail.com wrote:
> From: Ben Skeggs
>
> Signed-off-by: Ben Skeggs
> ---
> drivers/gpu/drm/drm_irq.c | 15 +--
> 1 files changed, 9 insertions(+), 6 deletions(-)
>
> diff --git a/drivers/gpu/drm/drm_irq.c b/drivers/gpu/drm/drm_irq.c
>
The radeon pageflip ioctl handler delayed submitting the pageflip to
hardware until the vblank IRQ handler. On AMD Fusion (PALM GPU, G-T56N
CPU), when using a reduced blanking CVT mode, a pageflip submitted to
hardware in the IRQ handler failed to complete before the end of the
vblank, resulting in
On Wed, Jul 6, 2011 at 11:39 AM, Alex Deucher wrote:
> On Wed, Jul 6, 2011 at 6:09 AM, wrote:
>> From: Thomas Reim
>>
>> Some integrated ATI Radeon chipset implementations
>> with add-on HDMI card (e. g. Asus M2A-VM HDMI) indicate the availability
>> of a DDC even when the add-on card
On Wed, Jul 6, 2011 at 6:09 AM, wrote:
> From: Thomas Reim
>
> Some integrated ATI Radeon chipset implementations
> with add-on HDMI card (e. g. Asus M2A-VM HDMI) indicate the availability
> of a DDC even when the add-on card is not plugged in or HDMI is disabled
> in BIOS setup. In
https://bugs.freedesktop.org/show_bug.cgi?id=38800
--- Comment #20 from Simon Farnsworth
2011-07-06 07:24:10 PDT ---
So, this is a gross hack to demonstrate that it's the delaying of the pageflip
that's hurting me:
[sfarnsworth@f12simon airlied-drm-fixes]$ git diff
diff --git a/drivers/gpu/drm/
https://bugs.freedesktop.org/show_bug.cgi?id=38800
--- Comment #20 from Simon Farnsworth
2011-07-06 07:24:10 PDT ---
So, this is a gross hack to demonstrate that it's the delaying of the pageflip
that's hurting me:
[sfarnsworth at f12simon airlied-drm-fixes]$ git diff
diff --git a/drivers/gpu/d
https://bugs.freedesktop.org/show_bug.cgi?id=38859
--- Comment #10 from Alex Deucher 2011-07-06 07:12:12 PDT ---
(In reply to comment #9)
> Like an issue in the code or the config?
3D driver code.
--
Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email
--- You are receiv
https://bugs.freedesktop.org/show_bug.cgi?id=38859
--- Comment #10 from Alex Deucher 2011-07-06 07:12:12 PDT
---
(In reply to comment #9)
> Like an issue in the code or the config?
3D driver code.
--
Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email
--- You are recei
https://bugs.freedesktop.org/show_bug.cgi?id=38859
--- Comment #9 from ch...@chris-portela.com 2011-07-06 07:11:13 PDT ---
Like an issue in the code or the config?
--
Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You
https://bugs.freedesktop.org/show_bug.cgi?id=38859
--- Comment #9 from chris at chris-portela.com 2011-07-06 07:11:13 PDT ---
Like an issue in the code or the config?
--
Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
Y
https://bugs.freedesktop.org/show_bug.cgi?id=38859
--- Comment #8 from Alex Deucher 2011-07-06 06:31:37 PDT ---
Sounds like some missing state init in the 3D driver.
--
Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
Y
https://bugs.freedesktop.org/show_bug.cgi?id=38859
--- Comment #8 from Alex Deucher 2011-07-06 06:31:37 PDT
---
Sounds like some missing state init in the 3D driver.
--
Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
https://bugs.freedesktop.org/show_bug.cgi?id=38859
--- Comment #7 from ch...@chris-portela.com 2011-07-06 06:23:08 PDT ---
I needed the problem to reoccur to test this and it did. I tried to play videos
with Totem and it couldn't play video but then I tried Mplayer and it fixed
some of the fonts b
https://bugs.freedesktop.org/show_bug.cgi?id=38859
--- Comment #7 from chris at chris-portela.com 2011-07-06 06:23:08 PDT ---
I needed the problem to reoccur to test this and it did. I tried to play videos
with Totem and it couldn't play video but then I tried Mplayer and it fixed
some of the font
Here are the kernel logs with and without the patch for better
visualisation of the changes:
1. dmesg after applying the patch:
[0.00] Initializing cgroup subsys cpuset
[0.00] Initializing cgroup subsys cpu
[0.00] Linux version 3.0-3-generic (root@Mark-Aurel) (gcc
version
https://bugs.freedesktop.org/show_bug.cgi?id=38800
--- Comment #19 from Simon Farnsworth
2011-07-06 03:19:46 PDT ---
I'm using the preferred mode from the panel's EDID, which xrandr says is:
1920x1200 (0x54) 154.0MHz +HSync -VSync *current +preferred
h: width 1920 start 1968 end 200
https://bugs.freedesktop.org/show_bug.cgi?id=38800
--- Comment #19 from Simon Farnsworth
2011-07-06 03:19:46 PDT ---
I'm using the preferred mode from the panel's EDID, which xrandr says is:
1920x1200 (0x54) 154.0MHz +HSync -VSync *current +preferred
h: width 1920 start 1968 end 200
https://bugs.freedesktop.org/show_bug.cgi?id=38800
Michel Dänzer changed:
What|Removed |Added
CC||mario.klei...@tuebingen.mpg
https://bugs.freedesktop.org/show_bug.cgi?id=38800
Michel D?nzer changed:
What|Removed |Added
CC||mario.kleiner at tuebingen.mpg
From: Thomas Reim
Some integrated ATI Radeon chipset implementations
with add-on HDMI card (e. g. Asus M2A-VM HDMI) indicate the availability
of a DDC even when the add-on card is not plugged in or HDMI is disabled
in BIOS setup. In this case, drm_get_edid() and drm_edid_block_val
Dear Alex,
sorry for the long delay. I have updated the patch according to the
comments in your last e-mail (see below).
I've added function radeon_connector_needs_extended_probe() and flag
radeon_connector->requires_extended_probe that provide the means to
force on a board,connector basis to che
On Tue, Jun 21, 2011 at 12:01:34PM -0700, Keith Packard wrote:
> Thanks. I'll see if I can't get an X201s upgraded to this version and
> see if we can reproduce the problem you're having...
Any news?
I have found the time today for more debugging.
Attached there are 3 files.
dmesg-startup is th
On Mon, 2011-07-04 at 13:16 +1000, skeg...@gmail.com wrote:
> From: Ben Skeggs
>
> Signed-off-by: Ben Skeggs
> ---
> drivers/gpu/drm/drm_irq.c | 15 +--
> 1 files changed, 9 insertions(+), 6 deletions(-)
>
> diff --git a/drivers/gpu/drm/drm_irq.c b/drivers/gpu/drm/drm_irq.c
> ind
73 matches
Mail list logo
