[PATCH] drm: Free the idr layers before calling idr_destroy()

2010-07-24 Thread Chris Wilson

No subject

2010-07-24 Thread
/* A typical clean-up sequence for objects stored in an idr tree, will * use idr_for_each() to free all objects, if necessary, then * idr_remove_all() to remove all ids, and idr_destroy() to free * up the cached idr_layers. */ We were missing the vital idr_rmove_all() step and so were leaking

[PATCH] drm: Cleanup after failing to create master->unique and dev->name

2010-07-24 Thread Chris Wilson
v2: Userspace (notably xf86-video-{intel,ati}) became confused when drmSetInterfaceVersion() started returning -EBUSY as they used a second call (the first done in drmOpen()) to check their master credentials. Since userspace wants to be able to repeatedly call drmSetInterfaceVersion() allow them t

[PATCH 1/3] drm: Cleanup after failing to create master->unique and dev->name

2010-07-24 Thread Chris Wilson
On Sat, 24 Jul 2010 18:29:35 +0100, Chris Wilson wrote: > Signed-off-by: Chris Wilson > @@ -323,7 +358,9 @@ int drm_setversion(struct drm_device *dev, void *data, > struct drm_file *file_pri > /* >* Version 1.1 includes tying of DRM to specific devi

[PATCH 3/3] agp/intel: Destroy the scatterlist on allocation failure

2010-07-24 Thread Chris Wilson
A side-effect of being able to use custom page allocations with the sg_table is that it cannot reap the partially constructed scatterlist if fails to allocate a page. So we need to call sg_free_table() ourselves if sg_alloc_table() fails. Signed-off-by: Chris Wilson Cc Dave Airlie --- drivers/c

[PATCH 2/3] drm: Free devname along with master->unique

2010-07-24 Thread Chris Wilson
The device name is tightly coupled and created at the same time as the master->unique address, so we need to free it with the master. Currently we overwrite it each time we create a new master: unreferenced object 0xe32c54b0 (size 32): comm "Xorg", pid 1455, jiffies 4294721798 (age 3196.879s)

[PATCH 1/3] drm: Cleanup after failing to create master->unique and dev->name

2010-07-24 Thread Chris Wilson
Signed-off-by: Chris Wilson --- drivers/gpu/drm/drm_ioctl.c | 73 -- 1 files changed, 55 insertions(+), 18 deletions(-) diff --git a/drivers/gpu/drm/drm_ioctl.c b/drivers/gpu/drm/drm_ioctl.c index 9b9ff46..197267b 100644 --- a/drivers/gpu/drm/drm_ioctl.c

[PATCH] drm/vmgfx: operation on ‘par->dirty.y1’ may be undefined

2010-07-24 Thread Chris Wilson
Trivial fix to set y1 = y2 = 0. Signed-off-by: Chris Wilson Cc: Jakob Bornecrantz --- drivers/gpu/drm/vmwgfx/vmwgfx_fb.c |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/drivers/gpu/drm/vmwgfx/vmwgfx_fb.c b/drivers/gpu/drm/vmwgfx/vmwgfx_fb.c index b0866f0..870967a 1006

Suspend lockup: How to bisect d-r-t specific commits?

2010-07-24 Thread Alex Deucher
non-text attachment was scrubbed... Name: 0001-drm-radeon-optimize-default-3D-state-for-r6xx-r7xx-b.patch Type: text/x-patch Size: 16682 bytes Desc: not available URL: <http://lists.freedesktop.org/archives/dri-devel/attachments/20100724/f5460903/attachment.bin>

[PATCH] drm: Free the idr layers before calling idr_destroy()

2010-07-24 Thread Chris Wilson
>From the docs for idr: /* A typical clean-up sequence for objects stored in an idr tree, will * use idr_for_each() to free all objects, if necessary, then * idr_remove_all() to remove all ids, and idr_destroy() to free * up the cached idr_layers. */ We were missing the vital idr_rmove_all()

Re: Suspend lockup: How to bisect d-r-t specific commits?

2010-07-24 Thread Alex Deucher
2010/7/24 Rafał Miłecki : > W dniu 21 lipca 2010 19:23 użytkownik Alex Deucher > napisał: >> 2010/7/21 Rafał Miłecki : >>> W dniu 21 lipca 2010 11:30 użytkownik Rafał Miłecki >>> napisał: First bisect try gave me: bad: [d8c253f30d0eb975e5c42c31587ef718517f5067] drm/radeon: optimiz

[PATCH] drm: Cleanup after failing to create master->unique and dev->name

2010-07-24 Thread Chris Wilson
v2: Userspace (notably xf86-video-{intel,ati}) became confused when drmSetInterfaceVersion() started returning -EBUSY as they used a second call (the first done in drmOpen()) to check their master credentials. Since userspace wants to be able to repeatedly call drmSetInterfaceVersion() allow them t

Re: [PATCH 1/3] drm: Cleanup after failing to create master->unique and dev->name

2010-07-24 Thread Chris Wilson
On Sat, 24 Jul 2010 18:29:35 +0100, Chris Wilson wrote: > Signed-off-by: Chris Wilson > @@ -323,7 +358,9 @@ int drm_setversion(struct drm_device *dev, void *data, > struct drm_file *file_pri > /* >* Version 1.1 includes tying of DRM to specific devi

[PATCH 2/3] drm: Free devname along with master->unique

2010-07-24 Thread Chris Wilson
The device name is tightly coupled and created at the same time as the master->unique address, so we need to free it with the master. Currently we overwrite it each time we create a new master: unreferenced object 0xe32c54b0 (size 32): comm "Xorg", pid 1455, jiffies 4294721798 (age 3196.879s)

[PATCH 1/3] drm: Cleanup after failing to create master->unique and dev->name

2010-07-24 Thread Chris Wilson
Signed-off-by: Chris Wilson --- drivers/gpu/drm/drm_ioctl.c | 73 -- 1 files changed, 55 insertions(+), 18 deletions(-) diff --git a/drivers/gpu/drm/drm_ioctl.c b/drivers/gpu/drm/drm_ioctl.c index 9b9ff46..197267b 100644 --- a/drivers/gpu/drm/drm_ioctl.c

[PATCH 3/3] agp/intel: Destroy the scatterlist on allocation failure

2010-07-24 Thread Chris Wilson
A side-effect of being able to use custom page allocations with the sg_table is that it cannot reap the partially constructed scatterlist if fails to allocate a page. So we need to call sg_free_table() ourselves if sg_alloc_table() fails. Signed-off-by: Chris Wilson Cc Dave Airlie --- drivers/c

Suspend lockup: How to bisect d-r-t specific commits?

2010-07-24 Thread Rafał Miłecki
W dniu 21 lipca 2010 19:23 u?ytkownik Alex Deucher napisa?: > 2010/7/21 Rafa? Mi?ecki : >> W dniu 21 lipca 2010 11:30 u?ytkownik Rafa? Mi?ecki >> napisa?: >>> First bisect try gave me: >>> bad: [d8c253f30d0eb975e5c42c31587ef718517f5067] >>> drm/radeon: optimize default 3D state for r6xx/r7xx bli

[PATCH] drm/vmgfx: operation on ‘par->dirty.y1’ may be undefined

2010-07-24 Thread Chris Wilson
Trivial fix to set y1 = y2 = 0. Signed-off-by: Chris Wilson Cc: Jakob Bornecrantz --- drivers/gpu/drm/vmwgfx/vmwgfx_fb.c |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/drivers/gpu/drm/vmwgfx/vmwgfx_fb.c b/drivers/gpu/drm/vmwgfx/vmwgfx_fb.c index b0866f0..870967a 1006

[Bug 29217] After pm-suspend the second monitor shows garbled output on evergreen card (kms)

2010-07-24 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=29217 --- Comment #12 from boris64 2010-07-24 05:14:12 PDT --- Update: Enabling "Repost Video On S3 Resume" in BIOS seems to help a lot. I've send my computer into sleepmode for a couple of times now and the second monitor has always been working fine

[Bug 29217] After pm-suspend the second monitor shows garbled output on evergreen card (kms)

2010-07-24 Thread bugzilla-dae...@freedesktop.org
https://bugs.freedesktop.org/show_bug.cgi?id=29217 --- Comment #12 from boris64 2010-07-24 05:14:12 PDT --- Update: Enabling "Repost Video On S3 Resume" in BIOS seems to help a lot. I've send my computer into sleepmode for a couple of times now and the second monitor has always been working fin

[Bug 21012] [855GM] can't display > 1024x768 over DVI

2010-07-24 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=21012 Chris Wilson changed: What|Removed |Added Attachment #29422|application/octet-stream|text/plain mime type|

[Bug 21012] [855GM] can't display > 1024x768 over DVI

2010-07-24 Thread bugzilla-dae...@freedesktop.org
https://bugs.freedesktop.org/show_bug.cgi?id=21012 Chris Wilson changed: What|Removed |Added Attachment #29422|application/octet-stream|text/plain mime type|

Re: Suspend lockup: How to bisect d-r-t specific commits?

2010-07-24 Thread Rafał Miłecki
W dniu 21 lipca 2010 19:23 użytkownik Alex Deucher napisał: > 2010/7/21 Rafał Miłecki : >> W dniu 21 lipca 2010 11:30 użytkownik Rafał Miłecki >> napisał: >>> First bisect try gave me: >>> bad: [d8c253f30d0eb975e5c42c31587ef718517f5067] >>> drm/radeon: optimize default 3D state for r6xx/r7xx bli