Re: [bug] success field never emited in auth_request_finished event

2019-07-12 Thread Jean-Daniel Dupas via dovecot
Sorry, I forgot to mention this is with the freshly released 2.3.7 > Le 12 juil. 2019 à 16:43, Aki Tuomi via dovecot a écrit > : > > Would you like to try with 2.3.7? It was released today. > > Aki >> On 12/07/2019 17:05 Jean-Daniel Dupas via dovecot < dovecot@dovecot.org >>

Re: [bug] success field never emited in auth_request_finished event

2019-07-12 Thread Aki Tuomi via dovecot
Would you like to try with 2.3.7? It was released today. Aki On 12/07/2019 17:05 Jean-Daniel Dupas via dovecot < dovecot@dovecot.org> wrote: An other issue is that when 'request->passdb_success' is FALSE, the req

Re: [bug] success field never emited in auth_request_finished event

2019-07-12 Thread Jean-Daniel Dupas via dovecot
An other issue is that when 'request->passdb_success' is FALSE, the request fails but the error field is not set (as it is only set when request->failure is TRUE), which make it hard to create metrics for failed login attempts. We have (assuming success were working as expected): - success = yes