Re: [Dovecot] Dovecot - some more optimisations

2010-09-02 Thread Timo Sirainen
On Thu, 2010-09-02 at 11:42 +0200, Len7hir wrote: > Safe_memset is also called from: > pool_alloconly_clear, pool_alloconly_destroy, Only when pool was created by pool_alloconly_create_clean(), which isn't used anywhere. > pool_system_clean_free Also this isn't used anywhere. I should probably

Re: [Dovecot] Dovecot - some more optimisations

2010-09-02 Thread Len7hir
W dniu 2010-09-01 17:25, Timo Sirainen pisze: On Wed, 2010-09-01 at 13:23 +0200, Len7hir wrote: And another problem. Why You use safe_memset instead of memset? Now this function have the largest impact in Dovecot performance. Really? I'd think it would be called very rarely since it should be

Re: [Dovecot] Dovecot - some more optimisations

2010-09-01 Thread Timo Sirainen
On Wed, 2010-09-01 at 16:25 +0100, Timo Sirainen wrote: > http://hg.dovecot.org/dovecot-2.0/rev/e9358064c45e Whops, messed up that one. http://hg.dovecot.org/dovecot-2.0/rev/0c73829cd1f8

Re: [Dovecot] Dovecot - some more optimisations

2010-09-01 Thread Timo Sirainen
On Wed, 2010-09-01 at 13:23 +0200, Len7hir wrote: > And another problem. Why You use safe_memset instead of memset? > Now this function have the largest impact in Dovecot performance. Really? I'd think it would be called very rarely since it should be used only for password-related data. I anyway

Re: [Dovecot] Dovecot - some more optimisations

2010-09-01 Thread Len7hir
In dovecot-patch2.diff data = _stream->buffer + _stream->skip; Should be: data = (unsigned char *)_stream->buffer + _stream->skip; Sorry for this :P -- Len7hir