Re: [Dovecot] [PATCH] Generalize HMAC implementation

2012-09-19 Thread Florian Zeitz
Am 19.09.2012 19:43, schrieb Florian Zeitz: > Am 11.09.2012 20:21, schrieb Timo Sirainen: >> On 11.9.2012, at 21.07, Florian Zeitz wrote: >> I think we could simply #define the largest allowed context_size, use it for these buffers' sizes and then add i_assert(meth->context_size <=

Re: [Dovecot] [PATCH] Generalize HMAC implementation

2012-09-19 Thread Florian Zeitz
Am 11.09.2012 20:21, schrieb Timo Sirainen: > On 11.9.2012, at 21.07, Florian Zeitz wrote: > >>> I think we could simply #define the largest allowed context_size, use it >>> for these buffers' sizes and then add i_assert(meth->context_size <= >>> HMAC_MAX_CONTEXT_SIZE) >>> >> Well, either that,

Re: [Dovecot] [PATCH] Generalize HMAC implementation

2012-09-11 Thread Florian Zeitz
Am 11.09.2012 18:02, schrieb Timo Sirainen: > On 4.9.2012, at 21.25, Florian Zeitz wrote: > >> Hello everyone and Timo in particular, >> >> about a year ago I implemented a SHA-1 variant of the HMAC(-MD5) present >> in Dovecot. >> I had always disliked this a bit, because it replicates a lot of co

Re: [Dovecot] [PATCH] Generalize HMAC implementation

2012-09-11 Thread Timo Sirainen
On 4.9.2012, at 21.25, Florian Zeitz wrote: > Hello everyone and Timo in particular, > > about a year ago I implemented a SHA-1 variant of the HMAC(-MD5) present > in Dovecot. > I had always disliked this a bit, because it replicates a lot of code. > This patch generalizes the HMAC function to ta