Re: [Dovecot] Patch to fix leak in imap_refresh_proctitle in beta[5, 6]

2010-06-16 Thread Mike Abbott
> I couldn't find anything obviously wrong in the code. Figured it out. The t_pop in client_handle_input was clobbering imap_clients->command_queue->name. This is because cmd_uid allocated the name from the wrong pool. Here is a patch to fix it. Forget my other patch (to imap_refresh_procti

Re: [Dovecot] Patch to fix leak in imap_refresh_proctitle in beta[5, 6]

2010-06-16 Thread Mike Abbott
> Is it complete garbage or 0xde character? (Or if you don't use > --with-devel-checks then 0xde shouldn't be appearing.) It is often 0xde with devel-checks on.

Re: [Dovecot] Patch to fix leak in imap_refresh_proctitle in beta[5, 6]

2010-06-16 Thread Timo Sirainen
On Tue, 2010-06-15 at 21:04 -0500, Mike Abbott wrote: > >> 6 imap0x000105867333 > >> imap_refresh_proctitle + 218 -> > >> 7 imap0x0001058666ce > >> cmd_sync_continue + 199 -> > > > > But how does this happen? Did it opti

Re: [Dovecot] Patch to fix leak in imap_refresh_proctitle in beta[5, 6]

2010-06-15 Thread Mike Abbott
>> 6 imap0x000105867333 >> imap_refresh_proctitle + 218 -> >> 7 imap0x0001058666ce cmd_sync_continue >> + 199 -> > > But how does this happen? Did it optimize away some functions Yeah optimized out tail-calls, e.g. clie

Re: [Dovecot] Patch to fix leak in imap_refresh_proctitle in beta[5, 6]

2010-06-15 Thread Timo Sirainen
On Mon, 2010-06-14 at 17:18 -0500, Mike Abbott wrote: > 6 imap0x000105867333 > imap_refresh_proctitle + 218 -> > 7 imap0x00010585f18e > client_command_input + 190 -> Looks ok.. > 6 imap

[Dovecot] Patch to fix leak in imap_refresh_proctitle in beta[5, 6]

2010-06-14 Thread Mike Abbott
The "imap" process of dovecot-2.0.beta[5,6] grows very large (I impose no system limits), e.g. exceeding 4.8GB on a 64-bit system. These messages appear in the logs: Warning: Growing pool 'imap client' with: 2048 Warning: Growing pool 'Cache fields' with: 2048 Warning: Growing data stack with: 3