Re: [Dovecot] [patch] 'c' and 'd' in setacl

2009-02-09 Thread Timo Sirainen
On Mon, 2009-02-09 at 13:01 +0100, Bernhard Herzog wrote: > > > str = MAIL_ACL_CREATE; > > > array_append(rights, &str > > > > I gave it a try in the attached patch. Actually I considered that my > > self but I'm (still) not sure if this is 100% legal according to the > > standard. > > After a bi

Re: [Dovecot] [patch] 'c' and 'd' in setacl

2009-02-09 Thread Bernhard Herzog
Hi, On 09.02.2009, Sascha Wilde wrote: > Timo Sirainen writes: [...] > > How about instead of > > > > array_append(rights, &imap_acl_letter_map[8].name > > > > something like: > > > > str = MAIL_ACL_CREATE; > > array_append(rights, &str > > I gave it a try in the attached patch. Actually I consi

Re: [Dovecot] [patch] 'c' and 'd' in setacl

2009-02-09 Thread Sascha Wilde
Hi Timo, thanks for your reply! Timo Sirainen writes: > On Fri, 2009-02-06 at 12:29 +0100, Sascha Wilde wrote: >> I just recognized that the new imap-acl plugin in dovecot 1.2 does not >> know the obsolete rights 'd' and 'c' when setting. > .. >> [0] I don't like the use of static indexes witc

Re: [Dovecot] [patch] 'c' and 'd' in setacl

2009-02-06 Thread Timo Sirainen
On Fri, 2009-02-06 at 12:29 +0100, Sascha Wilde wrote: > I just recognized that the new imap-acl plugin in dovecot 1.2 does not > know the obsolete rights 'd' and 'c' when setting. .. > [0] I don't like the use of static indexes witch imap_acl_letter_map but > currently I wasn't able to decid

Re: [Dovecot] [patch] 'c' and 'd' in setacl

2009-02-06 Thread Matvey Soloviev
Hello everyone, while I understand (and am glad to see) that the codebase evolved almost beyond recognition since I submitted it, from a superficial glance over the present code, I get the impression that it might be better to employ an additional check along the lines of what I had done in the pi

[Dovecot] [patch] 'c' and 'd' in setacl

2009-02-06 Thread Sascha Wilde
Hi Timo, Hi *, I just recognized that the new imap-acl plugin in dovecot 1.2 does not know the obsolete rights 'd' and 'c' when setting. According to RFC 4314 section 2.1.1.: If a client includes the "d" right in a rights list, then it MUST be treated as if the client had included every