[Dolibarr-dev] Facture class

2013-06-10 Par sujet Maxime Kohlhaas
Hi all, Just wondering why the FactureLigne update method has $user as first parameter... Propal and Commande don't have it, and the $user var is defined by global just after. Should I remove this parameter and check where this function is called ? Regards, -- *Maxime Kohlhaas Consultant associ

Re: [Dolibarr-dev] Facture class

2013-06-10 Par sujet Florian Henry
I think the better things to do is to pass the user as parameters (and check each call to be sure the parameters is correctly passed) It's done like that in all class CRUD method. Global $user should be avoid into class method. Florian HENRY florian.he...@open-concept.pro +33 6 03 76 48 07 htt

Re: [Dolibarr-dev] Question on CommonObject/CommonOrder/...

2013-06-10 Par sujet Laurent Destailleur (eldy)
Le 09/06/2013 18:41, Florian Henry a écrit : > Hello all, > > I'm actually implementing extrafield into propal/order/invoice lines. > > I wonder why for Order and Invoice the class extends CommonOrder > and CommonInvoice but not Propal. Even if this abstract class are > empty, should I do t

[Dolibarr-dev] Revert of commit

2013-06-10 Par sujet Laurent Destailleur (eldy)
Regis, I revert the commit you did about change into hook management to use resPrint to return value. There is no need for this. Hooks for pdf_xxx are already hooks of type "returnvalue". This means, if you want your hook to return a specific value to replace data return, you must return your val

Re: [Dolibarr-dev] Revert of commit

2013-06-10 Par sujet Régis Houssin
Laurent, so he must be the "revert" on Develop branchno? Le 11/06/13 00:24, Laurent Destailleur (eldy) a écrit : Regis, I revert the commit you did about change into hook management to use resPrint to return value. There is no need for this. Hooks for pdf_xxx are already hooks of type "re