Re: [Dnsmasq-discuss] [PATCH] Fix potential memory leak

2024-03-17 Thread Brian Haley
Hi, On 3/17/24 9:38 AM, Geert Stappers wrote: From: Brian Haley When a new IPv6 address is being added to a dhcp_config struct, if there is anything invalid regarding the prefix it looks like there is a potential memory leak. ret_err_free() should be used to free it. Signed-off-by: Brian

Re: [Dnsmasq-discuss] [PATCH] Fix potential memory leak

2024-03-18 Thread Brian Haley
Hi, On 3/16/24 6:07 AM, Geert Stappers wrote: On Sat, Mar 02, 2024 at 05:03:01PM +0100, Geert Stappers wrote: On Fri, Mar 01, 2024 at 04:43:20PM -0500, Brian Haley wrote: When a new IPv6 address is being added to a dhcp_config struct, if there is anything invalid regarding the prefix it looks

[Dnsmasq-discuss] Dnsmasq not always seeing unicast packets

2011-09-12 Thread Brian Haley
Hi, I searched the archives, but didn't find anything that exactly fit the problem I'm seeing. I'm running dnsmasq-2.57 on Linux (Ubuntu 11.04), and am starting two dnsmasq processes to serve DHCP on two interfaces to VMs I'm running. Initial packets (broadcast MAC/broadcast IP) are handled fine

Re: [Dnsmasq-discuss] Dnsmasq not always seeing unicast packets

2011-09-12 Thread Brian Haley
On 09/12/2011 03:16 PM, Jan Psota wrote: >> I'm running dnsmasq-2.57 on Linux (Ubuntu 11.04), and am starting two dnsmasq >> processes to serve DHCP on two interfaces to VMs I'm running. Initial >> packets >> (broadcast MAC/broadcast IP) are handled fine, but when it comes time to >> renew >> an

Re: [Dnsmasq-discuss] Dnsmasq not always seeing unicast packets

2011-09-12 Thread Brian Haley
On 09/12/2011 03:54 PM, Jan Psota wrote: >> Unfortunately using multiple range and interface arguments won't work since I >> will need to run >100, with different conf files for each. >> > Didn't you forget to set "bind-interfaces"? No, I set --bind-interfaces, --listen-address=1.2.3.4 and --inter

[Dnsmasq-discuss] Windows Server 2008 R2 issue

2012-10-13 Thread Brian Haley
Hi, I'm having trouble getting a Windows Server 2008 R2 virtual machine to get a lease from dnsmasq running on Ubuntu Linux. An R1, and any other OS, has no problems. The version of dnsmasq is 2.58-3. My config is as follows: eth0 - public interface - IP 15.3.2.1 (that's not my real IP) brx1 -

Re: [Dnsmasq-discuss] Windows Server 2008 R2 issue

2012-10-15 Thread Brian Haley
On 10/15/2012 06:58 AM, Simon Kelley wrote: On 13/10/12 17:34, Brian Haley wrote: Hi, I'm having trouble getting a Windows Server 2008 R2 virtual machine to get a lease from dnsmasq running on Ubuntu Linux. An R1, and any other OS, has no problems. The version of dnsmasq is 2.58-3

Re: [Dnsmasq-discuss] Cannot assign IPv6 address for /96 subnet

2013-02-12 Thread Brian Haley
On 02/08/2013 09:59 PM, Sheng Yang wrote: > Hi Simon, > > I found I can't assign IPv6 address for /96 subnet. > > I specified DHCP range use 96 bits prefixes: > > dhcp-range=fc00:3:1602::7473,96,static This is in violation of RFC 4862 Section 5.5.3 Item d, right? "If the sum of the prefix

Re: [Dnsmasq-discuss] Cannot assign IPv6 address for /96 subnet

2013-02-12 Thread Brian Haley
t; On Tue, Feb 12, 2013 at 1:06 PM, Brian Haley wrote: >> On 02/08/2013 09:59 PM, Sheng Yang wrote: >>> Hi Simon, >>> >>> I found I can't assign IPv6 address for /96 subnet. >>> >>> I specified DHCP range use 96 bits prefixes: >>> &g

Re: [Dnsmasq-discuss] dnsmasq's AdvRouterAddr On equivalent

2014-04-17 Thread Brian Haley
On 04/17/2014 09:20 AM, Simon Kelley wrote: > On 15/04/14 23:31, Jorge Schrauwen wrote: >> Hey All, >> >> I had a bit of trouble getting ra to work on OpenBSD but manually compiling >> 2.69 seems to have done the trick. (Yay!) >> I was porting over my old radvd.conf from linux and I have this op

Re: [Dnsmasq-discuss] How does DNSMASQ handle large concurrent configure file updating request requests

2015-01-14 Thread Brian Haley
On 01/14/2015 04:48 AM, Yongkang You wrote: > Hi, > > We have a cloud environment which uses DNSMASQ as DHCP/DNS server; in the > cloud, > it usually starts lots of VMs concurrently, for example, 1 VM; for each > VM, > we will configure a static DHCP entry in DNSMASQ configuration and send

[Dnsmasq-discuss] Query about solving a DHCPNAK issue

2015-02-02 Thread Brian Haley
Hi, There have been a number of people chasing an issue in Openstack where dnsmasq was sending DHCPNAK's after it was restarted since it's being started with --leasefile-ro (https://launchpad.net/bugs/1345947). The first solution was to create a script that could be called to re-populate the data

Re: [Dnsmasq-discuss] Query about solving a DHCPNAK issue

2015-02-02 Thread Brian Haley
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 On 02/02/2015 03:30 PM, Simon Kelley wrote: > > On 02/02/15 19:50, Brian Haley wrote: >> Hi, > >> There have been a number of people chasing an issue in Openstack where >> dnsmasq was sending DHCPNAK's after i

Re: [Dnsmasq-discuss] Query about solving a DHCPNAK issue

2015-02-02 Thread Brian Haley
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 On 02/02/2015 05:30 PM, Simon Kelley wrote: > > > On 02/02/15 22:20, Brian Haley wrote: > >> The one thing I'm curious about is if dnsmasq is restarted while a VM >> holds a lease, how will it respond? As someone

Re: [Dnsmasq-discuss] Query about solving a DHCPNAK issue

2015-05-26 Thread Brian Haley
On 02/02/2015 05:47 PM, Brian Haley wrote: The one thing I'm curious about is if dnsmasq is restarted while a VM holds a lease, how will it respond? As someone else has pointed-out to me - isc-dhcp will respond with a DHCPNAK in that case, and wondered why there would be a difference

Re: [Dnsmasq-discuss] DNSMASQ wrong addresses allocated after changing DHCP Clients between Neutron vRouters

2018-12-06 Thread Brian Haley
Luis, You should probably file a bug against neutron (https://bugs.launchpad.net/neutron/) with the relevant info, along with the neutron commands you're running and debug from the dhcp-agent and /var/lib/neutron/dhcp/xxx/ files as necessary. I don't exactly understand what you mean by "LAN

[Dnsmasq-discuss] [PATCH] Change read_leases() to skip invalid entries

2019-01-17 Thread Brian Haley
There's no reason to stop reading the existing lease file when dnsmasq is started and an invalid entry is found, it can just be ignored. This was fallout from an Openstack bug where the file was being written incorrectly with [] around IPv6 addresses. --- src/lease.c | 18 +- 1 f

[Dnsmasq-discuss] [PATCH] Change dhcp_release to use first address when no IP subnet matches

2019-04-27 Thread Brian Haley
ight spawn and using --enable-dbus=$id in order to isolate messages to specific dnsmasq instances. Signed-off-by: Brian Haley --- contrib/lease-tools/dhcp_release.c | 13 +++-- 1 file changed, 11 insertions(+), 2 deletions(-) diff --git a/contrib/lease-tools/dhcp_release.c b/contrib/lease-

Re: [Dnsmasq-discuss] [PATCH] Change dhcp_release to use first address when no IP subnet matches

2019-05-14 Thread Brian Haley
On 5/14/19 3:52 AM, Nicolas Cavallari wrote: On 26/04/2019 22:03, Brian Haley wrote: Currently, dhcp_release will only send a 'fake' release when the address given is in the same subnet as an IP on the interface that was given. This doesn't work in an environment where dnsm

Re: [Dnsmasq-discuss] [PATCH] Change dhcp_release to use first address when no IP subnet matches

2019-05-20 Thread Brian Haley
Hi Simon, Not sure if you had an opinion on this, seemed like a bug regardless of me trying to use Dbus. Thanks, -Brian On 4/26/19 4:03 PM, Brian Haley wrote: Currently, dhcp_release will only send a 'fake' release when the address given is in the same subnet as an IP on the inte

Re: [Dnsmasq-discuss] [PATCH] Change dhcp_release to use first address when no IP subnet matches

2019-08-06 Thread Brian Haley
Simon - just re-sending since you're back. Thanks, -Brian On 4/26/19 4:03 PM, Brian Haley wrote: Currently, dhcp_release will only send a 'fake' release when the address given is in the same subnet as an IP on the interface that was given. This doesn't work in an environm

Re: [Dnsmasq-discuss] [PATCH] Change dhcp_release to use first address when no IP subnet matches

2019-08-28 Thread Brian Haley
On 8/22/19 6:50 PM, Simon Kelley wrote: On 26/04/2019 21:03, Brian Haley wrote: Currently, dhcp_release will only send a 'fake' release when the address given is in the same subnet as an IP on the interface that was given. This doesn't work in an environment where dnsmasq is

Re: [Dnsmasq-discuss] [PATCH v2] Change dhcp_release to use default address when no IP subnet matches

2019-10-01 Thread Brian Haley
wrote: From: Brian Haley Currently, dhcp_release will only send a 'fake' release when the address given is in the same subnet as an IP on the interface that was given. This doesn't work in an environment where dnsmasq is managing leases for remote subnets via a DHCP relay, as runni

Re: [Dnsmasq-discuss] Crash with "double free or corruption" when receiving SIGHUP, on a configuration using hosts file and tags

2025-01-31 Thread Brian Haley
On 1/31/25 10:05 AM, Mathieu ABATI wrote: Crash not reproduced on 2.91test9, and not reproduced on 2.91test9 with patch from Brain Haley (2025-01-23). Thank you! Maybe it can get applied :) -Brian ___ Dnsmasq-discuss mailing list Dnsmasq-discuss@li

Re: [Dnsmasq-discuss] Crash with "double free or corruption" when receiving SIGHUP, on a configuration using hosts file and tags

2025-01-31 Thread Brian Haley
On 1/31/25 12:42 PM, Geert Stappers wrote: On Fri, Jan 31, 2025 at 05:01:59PM +0100, Mathieu ABATI wrote: On Fri, Jan 31, 2025 at 10:58:24AM -0500, Brian Haley wrote: On 1/31/25 10:05 AM, Mathieu ABATI wrote: Crash not reproduced on 2.91test9, and not reproduced on 2.91test9 with patch from

[Dnsmasq-discuss] [PATCH v2] Fix potential memory leak

2025-01-23 Thread Brian Haley
before the validity check, it is best to defer this insertion until later so an invalid entry is not present, since the CONFIG_ADDR6 flag might not have been set yet. Signed-off-by: Brian Haley --- src/option.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/src

Re: [Dnsmasq-discuss] Request for a new release

2025-01-14 Thread Brian Haley
Hi Simon, On 12/23/24 3:20 PM, Simon Kelley wrote: We're into the "test release" phase. I guess sometime in January would be likely for a stable release. I don't see a change I proposed last March ever being merged [0], I don't know if others have been missed. Should I re-propose it now as I