Re: [Dnsmasq-discuss] Use-after-free with DHCP + use-stale-cache

2024-05-13 Thread Dominik Derigs via Dnsmasq-discuss
Hey Erik, sorry for the late reply.. I wanted to err on the side of caution this time. We have been testing with your patch applied on top of latest master for almost four days now and - so far - no new use-after-free events occurred. Before, it happened at least once a day. Seems I have misi

Re: [Dnsmasq-discuss] [PATCH] Ensure resize_packet() does not overflow header

2024-05-13 Thread Geert Stappers
On Mon, May 13, 2024 at 11:04:01AM +0900, Dominique Martinet wrote: > This is a "fix" for OSV-2022-785 (oss-fuzz automated report that > apparently hasn't been looked into) > > It really is a redundant safety in case something goes wrong when > finding pheader: the only caller of resize_packet() w

Re: [Dnsmasq-discuss] Use-after-free with DHCP + use-stale-cache

2024-05-13 Thread Erik Karlsson
Hi Dominik, SIGALRM is in fact what is used for expiring leases so this patch should affect the relevant code path: [PATCH] Update DNS records after pruning DHCP leases As far as I can tell this is also the only place where lease_prune() is not followed by lease_update_dns() I found the issue b