[Dnsmasq-discuss] [PATCH] Handle UBus serialization errors.

2021-07-22 Thread Etan Kissling
The various blob / blobmsg commands can fail, e.g., when memory is low. Previously, those errors were silently discarded. This patch adds checks for the error conditions, logging them and exiting from the functions. Signed-off-by: Etan Kissling --- src/ubus.c | 72 +++

[Dnsmasq-discuss] [PATCH] Eliminate redundant UBus `notify` variable.

2021-07-22 Thread Etan Kissling
There was a `notify` variable to keep track whether a subscriber is observing our UBus object. However, it was not properly cleaned up in `ubus_destroy`, potentially becoming stale over UBus reconnections. The variable was removed and the current state is examined when sending notifications, simila

[Dnsmasq-discuss] [PATCH] Re-order UBus teardown logic.

2021-07-22 Thread Etan Kissling
When destroying the UBus context, private fields of our ubus_object were being reset to 0 while UBus was still owning those objects. While this seems to work out fine, it seems cleaner to first release the object so that UBus no longer owns it, before proceding to reset those fields. Signed-off-by

[Dnsmasq-discuss] [PATCH v2] Handle UBus serialization errors.

2021-07-22 Thread Etan Kissling
The various blob / blobmsg commands can fail, e.g., when memory is low. Previously, those errors were silently discarded. This patch adds checks for the error conditions, logging them and exiting from the functions. Signed-off-by: Etan Kissling --- v2: Fix compile. src/ubus.c | 72 +

[Dnsmasq-discuss] [PATCH] Adjust logging levels for connmark patterns.

2021-07-22 Thread Etan Kissling
This brings the log levels emitted by connmark pattern code in line with the rest of the code base. LOG_DEBUG is used for diagnostics that may be verbose depending on the request patterns. LOG_ERR is used for problems with the implementation itself. Signed-off-by: Etan Kissling --- src/pattern.c

[Dnsmasq-discuss] [PATCH] Make comment style consistent.

2021-07-22 Thread Etan Kissling
Majority of code base does not use C90-style // end of line comments. This formats the few existing exceptions using /* */ for consistency. --- NOTE: This builds on top of the other patches that I just submitted. src/hash-questions.c | 14 +++--- src/pattern.c| 8 src/ub

[Dnsmasq-discuss] Dnsmasq replying with refuse without forwarding request to upstream server.

2021-07-22 Thread sunil rathod
Hi All, Any thoughts why dnsmasq is replying with REFUSE response without forwarding the query to upstream server? Nslookup always fails with refuse response from the external client. I have the upstream server configured on conf file as server=8.8.8.8@eth0 Regards, Sunil _

Re: [Dnsmasq-discuss] Change in behaviour of --server

2021-07-22 Thread Geert Stappers via Dnsmasq-discuss
On Fri, Jul 09, 2021 at 02:10:23PM +0200, Petr Menšík wrote: > On 7/6/21 10:23 PM, Simon Kelley wrote: > > On 06/07/2021 12:14, Kevin Darbyshire-Bryant wrote: > >> Hi Simon, > >> > >> An eager OpenWrt tester of current dnsmasq master has noticed the > >> following change in behaviour: > > I have to

Re: [Dnsmasq-discuss] Dnsmasq replying with refuse without forwarding request to upstream server.

2021-07-22 Thread Simon Kelley
Two possible reasons: 1) resource exhaustion - the limit on the number of "in-flight" queries has been reached. 2) Network errors sending the query upstream. As a start of debugging, I'd try without the @eth0 interface specifier. Simon. On 22/07/2021 18:21, sunil rathod wrote: > Hi All,  > Any

Re: [Dnsmasq-discuss] Dnsmasq replying with refuse without forwarding request to upstream server.

2021-07-22 Thread sunil rathod
Hello Simon, I still see the problem after removing interface from server= config. I restarted dnsmasq, for some reason dnsmasq not liking the dns query. As soon as it receives the query sends back the REFUSE response without forwarding to upstream server. Sunil. On Fri, Jul 23, 2021, 03:05 Si

Re: [Dnsmasq-discuss] Dnsmasq replying with refuse without forwarding request to upstream server.

2021-07-22 Thread Dominik DL6ER
Hey Sunil, I encountered this situation only when dnsmasq didn't have any working upstream server it could forward your query to. Could you please 1. add "log-queries=extra" and "log-facility=/tmp/dnsmasq.log" to your configuration, 2. restart dnsmasq, 3. do the DNS query that ends up in REFUSED,