Re: [Dnsmasq-discuss] [PATCH] Re: 2.86rc1

2021-10-06 Thread Simon Kelley
If you're going to use more natural internal representations of DNS datastructures and then convert them to line format at the end, there are much more deserving cases than this. I think I must have been certifiably mad to do DNSSEC validation on a line-format representation of a DNS packet. It end

Re: [Dnsmasq-discuss] [PATCH] Re: 2.86rc1

2021-10-06 Thread Petr Menšík
Ouch, that ancount increase seems quite weird. What if we still used break to avoid printing all parts never added to message? It seems to me multibyte variables in dns_header should be converted just once after receiving and converted back to network order just once before sending. Constant conve

Re: [Dnsmasq-discuss] [PATCH] Re: 2.86rc1

2021-10-05 Thread Simon Kelley
On 30/09/2021 23:49, Petr Menšík wrote: > Thanks! > > I were checking it a bit on test build and found part of file > 0013-Fix-coverity-issues-detected-in-domain-match.c.patch avoided > application. domain-match.c:447 still has add_resource_record return > value unchecked, unlike A record above. >

[Dnsmasq-discuss] [PATCH] Re: 2.86rc1

2021-09-30 Thread Petr Menšík
Thanks! I were checking it a bit on test build and found part of file 0013-Fix-coverity-issues-detected-in-domain-match.c.patch avoided application. domain-match.c:447 still has add_resource_record return value unchecked, unlike A record above. Btw, return values shadows truncp pointer. If add_re