I am not sure systemd.socket can listen both on UDP and TCP, to pass
both sockets into dnsmasq when it starts. For a properly initialized
dnsmasq it is needed to listen on both. Most other services I have seen
with socket activation use it with TCP socket only. It is much easier
with that. I ha
LGTM
On 24/09/2024 08:52, Jan Ceuleers wrote:
Signed-off-by: Jan Ceuleers
Reviewed-by: Wang Xiaobo
---
src/dhcp.c | 9 +
1 file changed, 1 insertion(+), 8 deletions(-)
diff --git a/src/dhcp.c b/src/dhcp.c
index b65facd..586117d 100644
--- a/src/dhcp.c
+++ b/src/dhcp.c
@@ -821,16 +8
When thinking about this again, maybe it would be safer to make it not
compiled by define at compile time, before we remove that additional
check altogether?
I have hit this comment once too. And wondered why we need such hacks
long after Windows XP are history.
Do we have any proposal, how
I think Simon has pointed out this is intentional. Partial reply is
incomplete and for well behaving clients carries not useful information.
It would use TCP anyway instead, therefore it adds just additional data.
I would consider clients not falling back to TCP as broken. TCP is not
consider
Hi,
i found the some threads discussing this already (in 2023 and decades before
that), including:
-
https://www.mail-archive.com/dnsmasq-discuss@lists.thekelleys.org.uk/msg17151.html
Disclaimer: i won’t get into the philosophical stance reg. uselessness or
“overblown”-ness of systemd, as this
From: Erik Karlsson
Not doing so can result in a use after free since the name for DHCP
derived DNS records is represented as a pointer into the DHCP lease
table. Update will only happen when necessary since lease_update_dns
tests internally on dns_dirty and the force argument is zero.
Signed-of
