Re: [dm-devel] [PATCH 000/141] Fix fall-through warnings for Clang

2020-11-24 Thread Rafael J. Wysocki
On Mon, Nov 23, 2020 at 4:58 PM James Bottomley wrote: > > On Mon, 2020-11-23 at 15:19 +0100, Miguel Ojeda wrote: > > On Sun, Nov 22, 2020 at 11:36 PM James Bottomley > > wrote: [cut] > > > > Maintainers routinely review 1-line trivial patches, not to mention > > internal API changes, etc. > >

Re: [dm-devel] [RFC PATCH 29/34] power/swap: use bio_new in hib_submit_io

2021-01-29 Thread Rafael J. Wysocki
On Thu, Jan 28, 2021 at 8:21 AM Chaitanya Kulkarni wrote: > Please explain in the changelog why making this change is a good idea. > Signed-off-by: Chaitanya Kulkarni > --- > kernel/power/swap.c | 7 +++ > 1 file changed, 3 insertions(+), 4 deletions(-) > > diff --git a/kernel/power/swap.c

Re: [dm-devel] [PATCH v6 10/18] x86/power/64: Remove VLA usage

2018-07-25 Thread Rafael J. Wysocki
On Tue, Jul 24, 2018 at 6:49 PM, Kees Cook wrote: > In the quest to remove all stack VLA usage from the kernel[1], this > removes the discouraged use of AHASH_REQUEST_ON_STACK by switching to > shash directly and allocating the descriptor in heap memory (which should > be fine: the tfm has already

Re: [dm-devel] [PATCH v6 10/18] x86/power/64: Remove VLA usage

2018-08-07 Thread Rafael J. Wysocki
On Wednesday, July 25, 2018 8:01:47 PM CEST Kees Cook wrote: > On Wed, Jul 25, 2018 at 4:32 AM, Rafael J. Wysocki wrote: > > On Tue, Jul 24, 2018 at 6:49 PM, Kees Cook wrote: > >> In the quest to remove all stack VLA usage from the kernel[1], this > >> rem

Re: [dm-devel] [PATCH 03/24] PM: hibernate: remove the global snapshot_test variable

2023-05-23 Thread Rafael J. Wysocki
On Tue, May 23, 2023 at 9:45 AM Christoph Hellwig wrote: > > Passing call dependent variable in global variables is a huge > antipattern. Fix it up. > > Signed-off-by: Christoph Hellwig Acked-by: Rafael J. Wysocki > --- > kernel/power/hibernate.c | 17 ++--

Re: [dm-devel] [PATCH 21/24] PM: hibernate: don't use early_lookup_bdev in resume_store

2023-05-23 Thread Rafael J. Wysocki
stoph Hellwig > Fixes: 421a5fa1a6cf ("PM / hibernate: use name_to_dev_t to parse resume") Acked-by: Rafael J. Wysocki > --- > kernel/power/hibernate.c | 18 +- > 1 file changed, 17 insertions(+), 1 deletion(-) > > diff --git a/kernel/power/hibernate.c b/kerne

Re: [dm-devel] [PATCH 02/24] PM: hibernate: factor out a helper to find the resume device

2023-05-23 Thread Rafael J. Wysocki
On Tue, May 23, 2023 at 9:45 AM Christoph Hellwig wrote: > > Split the logic to find the resume device out software_resume and into > a separate helper to start unwindig the convoluted goto logic. > > Signed-off-by: Christoph Hellwig Acked-by: Rafael J. Wysocki > -

Re: [dm-devel] [PATCH 04/24] PM: hibernate: move finding the resume device out of software_resume

2023-05-23 Thread Rafael J. Wysocki
le later and doesn't have the sysfs locking nest inside it. > > Signed-off-by: Christoph Hellwig Acked-by: Rafael J. Wysocki > --- > kernel/power/hibernate.c | 80 > 1 file changed, 39 insertions(+), 41 deletions(-) > > dif

Re: [dm-devel] [PATCH 11/30] swsusp: don't pass a stack address to blkdev_get_by_path

2023-06-11 Thread Rafael J. Wysocki
On Thu, Jun 8, 2023 at 1:03 PM Christoph Hellwig wrote: > > holder is just an on-stack pointer that can easily be reused by other calls, > replace it with a static variable that doesn't change. > > Signed-off-by: Christoph Hellwig > Reviewed-by: Hannes Reinecke Acke

Re: [dm-devel] [PATCH for 6.5 regression] PM: hibernate: fix resume_store() return value when hibernation not available

2023-08-07 Thread Rafael J. Wysocki
On Mon, Aug 7, 2023 at 10:34 AM Vlastimil Babka wrote: > > On a laptop with hibernation set up but not actively used, and with > secure boot and lockdown enabled kernel, 6.5-rc1 gets stuck on boot with > the following repeated messages: > > A start job is running for Resume from hibernation usin