[dm-devel] kernel BUG at drivers/scsi/device_handler/scsi_dh_alua.c:662!

2020-09-03 Thread Brian Bunker
hci megaraid_sas nvme_fabrics libata nvme_core scsi_transport_fc [ 1953.761355] i2c_algo_bit dm_mirror dm_region_hash dm_log dm_mod Thanks, Brian Brian Bunker SW Eng br...@purestorage.com -- dm-devel mailing list dm-devel@redhat.com https://www.redhat.com/mailman/listinfo/dm-devel

[dm-devel] fix for kernel BUG at drivers/scsi/device_handler/scsi_dh_alua.c:662!

2020-09-07 Thread Brian Bunker
); list_del_rcu(&h->node); spin_unlock_irq(&pg->lock); kref_put(&pg->kref, release_port_group); } + rcu_assign_pointer(h->pg, NULL); + h->sdev = NULL; + spin_unlock(&h->pg_lock); sdev->han

[dm-devel] Make LUNs higher than 255 more friendly to look at

2020-09-24 Thread Brian Bunker
d.scsi_id, - pp->sg_id.lun); + (pp->sg_id.lun & 0x4000) ? pp->sg_id.lun - 0x4000 : pp->sg_id.lun); } static int Brian Bunker SW Eng br...@purestorage.com -- dm-devel mailing list dm-devel@redhat.com https://www.redhat.com/mailman/listinfo/dm-devel

Re: [dm-devel] Make LUNs higher than 255 more friendly to look at

2020-09-25 Thread Brian Bunker
G features='0' hwhandler='1 alua' wp=rw `-+- policy='service-time 0' prio=50 status=active |- 6:0:0:256 sde 8:64 active ready running |- 7:0:0:256 sdh 8:112 active ready running |- 8:0:0:256 sdi 8:128 active ready running `- 9:0:0:256 sdj 8:144 active ready

[dm-devel] [PATCH] libmultipath: Extract the LUN number for peripheral, flat, and logical unit address methods

2020-09-28 Thread Brian Bunker
th/util.h 2020-09-28 16:43:32.632879763 -0600 @@ -22,6 +22,7 @@ int parse_prkey_flags(char *ptr, uint64_t *prkey, uint8_t *flags); int safe_write(int fd, const void *buf, size_t count); void set_max_fds(int max_fds); +int extract_lun_number(int lun); #define KERNEL_VERSION(maj, min, ptc) maj)

[dm-devel] A device existing in two different multpath devices

2020-11-04 Thread Brian Bunker
for the creation of the two multipath devices. I am not sure that multipath is not just the victim of udev, but I expect that this behavior is not what multipath would ever want to do since it is a certain corruption when it happens. Any ideas or insight on what could keep us out of this situatio

Re: [dm-devel] A device existing in two different multpath devices

2020-11-06 Thread Brian Bunker
ID_SCSI_SERIAL Thanks, Brian Brian Bunker SW Eng br...@purestorage.com > On Nov 5, 2020, at 5:05 PM, Roger Heflin wrote: > > You might try limited udev's children to say 4 rather than the > default, the default seems to be based on some % of total cpus (it > seem

[dm-devel] [PATCH] ALUA support for PURE FlashArray

2019-06-26 Thread Brian Bunker
.pgpolicy = GROUP_BY_PRIO, + .pgfailback= -FAILBACK_IMMEDIATE, + .hwhandler = "1 alua", + .prio_name = PRIO_ALUA, + .fast_io_fail = 10, + .max_sectors_kb = 4096, }, /* *

Re: [dm-devel] [PATCH] ALUA support for PURE FlashArray

2019-09-11 Thread Brian Bunker
. I don’t know if there is a preferred way but if we use multipath.conf then hopefully no users will ever have to deal with the higher value that will error out if a SCSI read or write is actually sent larger than the 4 MB maximum size. Thanks, Brian Brian Bunker SW Eng br...@purestorage.com

[dm-devel] ALUA state unavailable and device discovery

2021-03-17 Thread Brian Bunker
vered and then transitions to the unavailable state, the device is already created so it can be transitioned in multipath and all is good. Is there a way to handle both unintended consequence and the ALUA unavailable state? Thanks, Brian Brian Bunker SW Eng br...@purestorage.com -- d

Re: [dm-devel] [PATCH] multipath-tools: add Pure Storage device to hardware table

2016-06-14 Thread Brian Bunker
Hello all, Definitely we want the one we included with the queue length vs. round robin and 60 second devloss timeout. Not sure where the other one came from. Thanks Brian Brian Bunker PURE Storage, Inc. On Jun 14, 2016 5:40 AM, wrote: > If driver names are different between tophat

Re: [dm-devel] Question about multipath device compiled defaults

2016-01-19 Thread Brian Bunker
or "multipathd -k'show config'". >> >> Hope this might still help at this time, >> >> [1] >> http://git.opensvc.com/gitweb.cgi?p=multipath-tools/.git;a=blob;f=libmultipath/hwtable.c >> [2] >> http://git.opensvc.com/gitweb.cgi?p=multipath-t

Re: [dm-devel] Question about multipath device compiled defaults

2016-01-20 Thread Brian Bunker
aro...@opensvc.com> wrote: > Ok, merged. > > On Tue, Jan 19, 2016 at 11:17 PM, Brian Bunker > wrote: > >> There are just two files I touch, so the patch is simple: >> >> diff -Naur 3/multipath-tools/libmultipath/hwtable.c >> 4/multipath-tools/libmultipath/hw

[dm-devel] [PATCH] [PATCH] libmultipath: return 'ghost' state when port is in transition

2023-02-21 Thread Brian Bunker
A test unit ready command sent on a path in standby state will not result in a failed path. The same should be true for a path in the transitioning state. Signed-off-by: Brian Bunker br...@purestorage.com --- libmultipath/checkers/tur.c | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions

Re: [dm-devel] [PATCH] [PATCH] libmultipath: return 'ghost' state when port is in transition

2023-03-03 Thread Brian Bunker
> On Mar 2, 2023, at 11:46 PM, Martin Wilck wrote: > > On Tue, 2023-02-21 at 12:56 -0800, Brian Bunker wrote: >> A test unit ready command sent on a path in standby state will not >> result >> in a failed path. The same should be true for a path in the >> trans

Re: [dm-devel] [PATCH] [PATCH] libmultipath: return 'ghost' state when port is in transition

2023-03-04 Thread Brian Bunker
On Mar 3, 2023, at 12:41 PM, Martin Wilck wrote: > > On Fri, 2023-03-03 at 09:18 -0800, Brian Bunker wrote: >>> >> Hello Martin, >> >> Doesn’t "something in between failed and up” semantics describe ALUA >> state transitioning pretty well? >

Re: [dm-devel] [PATCH] [PATCH] libmultipath: return 'ghost' state when port is in transition

2023-03-07 Thread Brian Bunker
> On Mar 7, 2023, at 2:31 AM, Martin Wilck wrote: > > On Mon, 2023-03-06 at 13:04 -0600, Benjamin Marzinski wrote: >> On Mon, Mar 06, 2023 at 12:46:50PM +0100, Martin Wilck wrote: >>> Hi Brian, >>> >>> On Sat, 2023-03-04 at 12:49 -0800, Brian Bunker w

Re: [dm-devel] [PATCH] [PATCH] libmultipath: return 'ghost' state when port is in transition

2023-03-09 Thread Brian Bunker
> On Mar 7, 2023, at 1:15 PM, Martin Wilck wrote: > > Brian, > > On Tue, 2023-03-07 at 11:41 -0800, Brian Bunker wrote: >> >>> On Mar 7, 2023, at 2:31 AM, Martin Wilck wrote: >>> >>> On Mon, 2023-03-06 at 13:04 -0600, Benjamin Marzinski wrot

Re: [dm-devel] [PATCH] [PATCH] libmultipath: return 'ghost' state when port is in transition

2023-03-09 Thread Brian Bunker
> On Mar 9, 2023, at 1:50 PM, Martin Wilck wrote: > > Brian, > > On Thu, 2023-03-09 at 13:40 -0800, Brian Bunker wrote: >> >> Martin, >> >> Sorry I bounce between kernel versions a lot since most of the >> problems which find their way to us are

Re: [dm-devel] [PATCH 0/3] handle transitioning devices in TUR checker

2023-03-10 Thread Brian Bunker
> On Mar 9, 2023, at 12:38 AM, mwi...@googlemail.com wrote: > > Brian, > > could you give this patch set a test in your environment? > > On Tue, 2023-03-07 at 16:49 -0600, Benjamin Marzinski wrote: >> This patchset is based on Brian Bunker's "libmultipath: return >> 'ghost' state when port is in

[dm-devel] [PATCH] multipath-tools Consider making 'smart' the default

2023-03-17 Thread Brian Bunker
regression to how it previously worked. Signed-off-by: Brian Bunker --- libmultipath/defaults.h| 2 +- multipath/multipath.conf.5 | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/libmultipath/defaults.h b/libmultipath/defaults.h index a5e9ea0c..6dfdb63b 100644 --- a

[dm-devel] [PATCH] libmultipathd Avoid parsing errors due to unsupported designators

2023-03-20 Thread Brian Bunker
multipath[45016]: parse_vpd_pg83: invalid device designator at offset 131: 0205 Thanks, Brian Signed-off-by: Brian Bunker — --- libmultipath/discovery.c | 8 1 file changed, 8 insertions(+) diff --git a/libmultipath/discovery.c b/libmultipath/discovery.c index d9ee2cb9..306884f6

Re: [dm-devel] [PATCH] multipath-tools Consider making 'smart' the default

2023-03-20 Thread Brian Bunker
> On Mar 20, 2023, at 12:41 PM, Benjamin Marzinski wrote: > > On Mon, Mar 20, 2023 at 03:18:37PM +0100, Martin Wilck wrote: >> On Thu, 2023-03-16 at 14:47 -0700, Brian Bunker wrote: >>> As a target vendor, it is nice to be able control initiator >>> behavior f