Re: [dm-devel] [dm-devel resend] dm mpath: fix UAF in multipath_message()

2023-08-08 Thread Mikulas Patocka
On Wed, 2 Aug 2023, Mike Snitzer wrote: > On Thu, May 18 2023 at 8:11P -0400, > lilingfeng (A) wrote: > > > > > 在 2022/10/18 3:56, Mike Snitzer 写道: > > > On Mon, Oct 10 2022 at 10:41P -0400, > > > Luo Meng wrote: > > > > > > > From: Luo Meng > > > > > > > > If dm_get_device() create dd i

Re: [dm-devel] [RFC PATCH v10 11/17] dm-verity: consume root hash digest and signature data via LSM hook

2023-08-08 Thread Fan Wu
On Tue, Jul 25, 2023 at 04:43:48PM -0400, Paul Moore wrote: > On Tue, Jul 11, 2023 at 11:43???PM Fan Wu wrote: > > On Fri, Jul 07, 2023 at 10:53:45AM -0400, Mike Snitzer wrote: > > ... > > > > Both of your calls to security_bdev_setsecurity() to set your blobs in > > > the bdev are suspect becau

Re: [dm-devel] [RFC PATCH v10 11/17] dm-verity: consume root hash digest and signature data via LSM hook

2023-08-08 Thread Alasdair G Kergon
On Tue, Aug 08, 2023 at 03:45:03PM -0700, Fan Wu wrote: > On Tue, Jul 25, 2023 at 04:43:48PM -0400, Paul Moore wrote: > > Where would the finalize() hook be called? > > It is in the __bind function in drivers/md/dm.c, calling just before > rcu_assign_pointer(md->map, (void *)t) which activates th

Re: [dm-devel] [PATCH v4 46/48] mm: shrinker: make memcg slab shrink lockless

2023-08-08 Thread Qi Zheng
Hi Dave, On 2023/8/8 10:44, Dave Chinner wrote: On Mon, Aug 07, 2023 at 07:09:34PM +0800, Qi Zheng wrote: Like global slab shrink, this commit also uses refcount+RCU method to make memcg slab shrink lockless. This patch does random code cleanups amongst the actual RCU changes. Can you please

Re: [dm-devel] [PATCH -next] dm: Remove unused declaration dm_get_rq_mapinfo()

2023-08-08 Thread Yue Haibing
On 2023/8/9 1:03, Hugo Villeneuve wrote: > On Tue, 8 Aug 2023 23:03:01 +0800 > Yue Haibing wrote: > > Hi, > >> Commit ae6ad75e5c3c ("dm: remove unused dm_get_rq_mapinfo()") >> removed the implementation but leave declaration. > > Maybe change to "removed the implementation but not the declarati

Re: [dm-devel] [PATCH -next] dm: Remove unused declaration dm_get_rq_mapinfo()

2023-08-08 Thread Hugo Villeneuve
On Tue, 8 Aug 2023 23:03:01 +0800 Yue Haibing wrote: Hi, > Commit ae6ad75e5c3c ("dm: remove unused dm_get_rq_mapinfo()") > removed the implementation but leave declaration. Maybe change to "removed the implementation but not the declaration." Hugo Villeneuve. > Signed-off-by: Yue Haibing >

[dm-devel] [PATCH -next] dm: Remove unused declaration dm_get_rq_mapinfo()

2023-08-08 Thread Yue Haibing
Commit ae6ad75e5c3c ("dm: remove unused dm_get_rq_mapinfo()") removed the implementation but leave declaration. Signed-off-by: Yue Haibing --- include/linux/device-mapper.h | 1 - 1 file changed, 1 deletion(-) diff --git a/include/linux/device-mapper.h b/include/linux/device-mapper.h index 69d0

[dm-devel] [PATCH v2 -next] dm: Remove unused declaration dm_get_rq_mapinfo()

2023-08-08 Thread Yue Haibing
Commit ae6ad75e5c3c ("dm: remove unused dm_get_rq_mapinfo()") removed the implementation but not the declaration. Signed-off-by: Yue Haibing --- v2: revise commit log --- include/linux/device-mapper.h | 1 - 1 file changed, 1 deletion(-) diff --git a/include/linux/device-mapper.h b/include/linu

Re: [dm-devel] [PATCH v4 45/48] mm: shrinker: make global slab shrink lockless

2023-08-08 Thread Qi Zheng
Hi Dave, On 2023/8/8 10:24, Dave Chinner wrote: On Mon, Aug 07, 2023 at 07:09:33PM +0800, Qi Zheng wrote: diff --git a/include/linux/shrinker.h b/include/linux/shrinker.h index eb342994675a..f06225f18531 100644 --- a/include/linux/shrinker.h +++ b/include/linux/shrinker.h @@ -4,6 +4,8 @@ #