Re: [dm-devel] [PATCH 5.15] dm init: add dm-mod.waitfor to wait for asynchronously probed block devices

2023-07-21 Thread Greg KH
On Fri, Jul 21, 2023 at 02:38:45PM +0800, Mark-PK Tsai wrote: > > On Mon, Jul 17, 2023 at 09:57:28AM +0800, Mark-PK Tsai wrote: > > > > On Sun, Jul 16, 2023, 11:16 AM Greg KH > > > > wrote: > > > > > > > > > On Thu, Jul 13, 2023 at 01:58:37PM +0800, Mark-PK Tsai wrote: > > > > > > From: Peter Ko

Re: [dm-devel] Nobarrier mount option (was: Re: File system robustness)

2023-07-21 Thread Theodore Ts'o
On Thu, Jul 20, 2023 at 09:55:22AM +0200, Martin Steigerwald wrote: > > I thought that nowadays a cache flush would be (almost) a no-op in the > case the storage receiving it is backed by such reliability measures. > I.e. that the hardware just says "I am ready" when having the I/O > request in

Re: [dm-devel] [PATCH 2/3] brd: enable discard

2023-07-21 Thread Mikulas Patocka
On Wed, 19 Jul 2023, Christoph Hellwig wrote: > > +static void brd_free_page_rcu(struct rcu_head *head) > > +{ > > + struct page *page = container_of(head, struct page, rcu_head); > > + __free_page(page); > > Nit: missing empty line here. Although I see no point in the local > variable an

Re: [dm-devel] [PATCH 3/3] brd: implement write zeroes

2023-07-21 Thread Mikulas Patocka
On Thu, 20 Jul 2023, Chaitanya Kulkarni wrote: > > Index: linux-2.6/drivers/block/brd.c > > === > > --- linux-2.6.orig/drivers/block/brd.c > > +++ linux-2.6/drivers/block/brd.c > > @@ -272,7 +272,8 @@ out: > > > > void brd_do_

[dm-devel] [PATCH v2 0/3] brd discard patches

2023-07-21 Thread Mikulas Patocka
This is a new version of the brd discard patches. -- dm-devel mailing list dm-devel@redhat.com https://listman.redhat.com/mailman/listinfo/dm-devel

[dm-devel] [PATCH v2 1/3] brd: extend the rcu regions to cover read and write

2023-07-21 Thread Mikulas Patocka
This patch extends the rcu regions, so that lookup followed by a read or write of a page is done inside rcu read lock. This is needed for the following patch that enables discard. Signed-off-by: Mikulas Patocka --- drivers/block/brd.c |8 1 file changed, 8 insertions(+) Index: lin

[dm-devel] [PATCH v2 3/3] brd: implement write zeroes

2023-07-21 Thread Mikulas Patocka
This patch implements REQ_OP_WRITE_ZEROES on brd. Write zeroes will free the pages just like discard, but the difference is that it writes zeroes to the preceding and following page if the range is not aligned on page boundary. Signed-off-by: Mikulas Patocka --- drivers/block/brd.c | 78 +

[dm-devel] [PATCH v2 2/3] brd: enable discard

2023-07-21 Thread Mikulas Patocka
This patch implements discard in the brd driver. We use RCU to free the page, so that if there are any concurrent readers or writes, they won't touch the page after it is freed. Calling "call_rcu" for each page is inefficient, so we attempt to batch multiple pages to a single "call_rcu" call. Not

Re: [dm-devel] [PATCH v2 0/3] brd discard patches

2023-07-21 Thread Jens Axboe
On 7/21/23 7:48?AM, Mikulas Patocka wrote: > This is a new version of the brd discard patches. Can you please: 1) Ensure that your postings thread properly, it's all separate emails and the patches don't nest under the cover letter parent. 2) Include a changelog. What changed since v1? -- J

Re: [dm-devel] [PATCH v2 0/3] brd discard patches

2023-07-21 Thread Mikulas Patocka
On Fri, 21 Jul 2023, Jens Axboe wrote: > On 7/21/23 7:48?AM, Mikulas Patocka wrote: > > This is a new version of the brd discard patches. > > Can you please: > > 1) Ensure that your postings thread properly, it's all separate emails >and the patches don't nest under the cover letter paren

Re: [dm-devel] [vdo-devel] [PATCH v2 00/39] Add the dm-vdo deduplication and compression device mapper target.

2023-07-21 Thread Kenneth Raeburn
On Tue, Jul 18, 2023 at 11:51 AM Mike Snitzer wrote: > > But the long-standing dependency on VDO's work-queue data > struct is still lingering (drivers/md/dm-vdo/work-queue.c). At a > minimum we need to work toward pinning down _exactly_ why that is, and > I think the best way to answer that is b