Re: [dm-devel] [PATCH v7 12/12] crypto: x86/aes-kl - Implement the AES-XTS algorithm

2023-05-26 Thread Eric Biggers
On Wed, May 24, 2023 at 09:57:17AM -0700, Chang S. Bae wrote: > == API Limitation == > > The setkey() function transforms an AES key into a handle. But, an > extended key is a usual outcome of setkey() in other AES cipher > implementations. For this reason, a setkey() failure does not fall > back

[dm-devel] [PATCH v2 2/5] drbd: use PAGE_SECTORS_SHIFT and PAGE_SECTORS

2023-05-26 Thread Luis Chamberlain
Replace common constants with generic versions. This produces no functional changes. Acked-by: Christoph Böhmwalder Signed-off-by: Luis Chamberlain --- drivers/block/drbd/drbd_bitmap.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/block/drbd/drbd_bitmap.c b/dri

[dm-devel] [PATCH v2 3/5] iomap: simplify iomap_init() with PAGE_SECTORS

2023-05-26 Thread Luis Chamberlain
Replace common constants with generic versions. This produces no functional changes. Signed-off-by: Luis Chamberlain --- fs/iomap/buffered-io.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/fs/iomap/buffered-io.c b/fs/iomap/buffered-io.c index 915b448b8554..5641e696fb3f 100

[dm-devel] [PATCH v2 5/5] zram: use generic PAGE_SECTORS and PAGE_SECTORS_SHIFT

2023-05-26 Thread Luis Chamberlain
Instead of re-defining the already existing constants use the provided ones: So replace: o SECTORS_PER_PAGE_SHIFT with PAGE_SECTORS_SHIFT o SECTORS_PER_PAGE with PAGE_SECTORS This produces no functional changes. Reviewed-by: Sergey Senozhatsky Signed-off-by: Luis Chamberlain --- driv

[dm-devel] [PATCH v2 4/5] dm bufio: simplify by using PAGE_SECTORS_SHIFT

2023-05-26 Thread Luis Chamberlain
The PAGE_SHIFT - SECTOR_SHIFT constant be replaced with PAGE_SECTORS_SHIFT defined in linux/blt_types.h, which is included by linux/blkdev.h. This produces no functional changes. Signed-off-by: Luis Chamberlain --- drivers/md/dm-bufio.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)

[dm-devel] [PATCH v2 1/5] block: annotate bdev_disk_changed() deprecation with a symbol namespace

2023-05-26 Thread Luis Chamberlain
This ensures no other users pop up by mistake easily and provides us a with an easy vehicle to do the same with other routines should we need it later. Signed-off-by: Luis Chamberlain --- block/partitions/core.c | 6 +- drivers/block/loop.c| 2 ++ drivers/s390/block/dasd_

[dm-devel] [PATCH v2 0/5] block: simplify with PAGE_SECTORS_SHIFT

2023-05-26 Thread Luis Chamberlain
A bit of block drivers have their own incantations with PAGE_SHIFT - SECTOR_SHIFT. Just simplfy and use PAGE_SECTORS_SHIFT all over.

Re: [dm-devel] [PATCH v2 1/5] block: annotate bdev_disk_changed() deprecation with a symbol namespace

2023-05-26 Thread Luis Chamberlain
On Fri, May 26, 2023 at 01:13:14AM -0700, Christoph Hellwig wrote: > On Fri, May 26, 2023 at 12:33:32AM -0700, Luis Chamberlain wrote: > > This ensures no other users pop up by mistake easily and provides > > us a with an easy vehicle to do the same with other routines should > > we need it later.

Re: [dm-devel] [PATCH v2 3/5] iomap: simplify iomap_init() with PAGE_SECTORS

2023-05-26 Thread Christoph Hellwig
Looks good: Reviewed-by: Christoph Hellwig -- dm-devel mailing list dm-devel@redhat.com https://listman.redhat.com/mailman/listinfo/dm-devel

Re: [dm-devel] [PATCH v2 1/5] block: annotate bdev_disk_changed() deprecation with a symbol namespace

2023-05-26 Thread Christoph Hellwig
On Fri, May 26, 2023 at 12:33:32AM -0700, Luis Chamberlain wrote: > This ensures no other users pop up by mistake easily and provides > us a with an easy vehicle to do the same with other routines should > we need it later. I don't see how this is related to the rest of the seris. I also don't th

Re: [dm-devel] [PATCH v2 2/5] drbd: use PAGE_SECTORS_SHIFT and PAGE_SECTORS

2023-05-26 Thread Johannes Thumshirn
Looks good, Reviewed-by: Johannes Thumshirn -- dm-devel mailing list dm-devel@redhat.com https://listman.redhat.com/mailman/listinfo/dm-devel

Re: [dm-devel] [PATCH v2 3/5] iomap: simplify iomap_init() with PAGE_SECTORS

2023-05-26 Thread Johannes Thumshirn
Looks good, Reviewed-by: Johannes Thumshirn -- dm-devel mailing list dm-devel@redhat.com https://listman.redhat.com/mailman/listinfo/dm-devel

Re: [dm-devel] [PATCH v2 4/5] dm bufio: simplify by using PAGE_SECTORS_SHIFT

2023-05-26 Thread Johannes Thumshirn
On 26.05.23 09:33, Luis Chamberlain wrote: > *data_mode = DATA_MODE_GET_FREE_PAGES; > return (void *)__get_free_pages(gfp_mask, > - c->sectors_per_block_bits - > (PAGE_SHIFT - SECTOR_SHIFT)); > +

Re: [dm-devel] [PATCH v2 5/5] zram: use generic PAGE_SECTORS and PAGE_SECTORS_SHIFT

2023-05-26 Thread Johannes Thumshirn
On 26.05.23 09:34, Luis Chamberlain wrote: > + u32 index = bio->bi_iter.bi_sector >> PAGE_SECTORS_SHIFT; > + u32 offset = (bio->bi_iter.bi_sector & (PAGE_SECTORS - 1)) << > SECTOR_SHIFT; (PAGE_SECTORS - 1) is SECTOR_MASK, please use this. Thanks, Johannes --

Re: [dm-devel] [PATCH v2 0/5] block: simplify with PAGE_SECTORS_SHIFT

2023-05-26 Thread Johannes Thumshirn
On 26.05.23 09:33, Luis Chamberlain wrote: > A bit of block drivers have their own incantations with > PAGE_SHIFT - SECTOR_SHIFT. Just simplfy and use PAGE_SECTORS_SHIFT > all over. > >

Re: [dm-devel] [PATCH v7 0/5] Introduce provisioning primitives

2023-05-26 Thread Dave Chinner
On Thu, May 25, 2023 at 12:19:47PM -0400, Brian Foster wrote: > On Wed, May 24, 2023 at 10:40:34AM +1000, Dave Chinner wrote: > > On Tue, May 23, 2023 at 11:26:18AM -0400, Mike Snitzer wrote: > > > On Tue, May 23 2023 at 10:05P -0400, Brian Foster > > > wrote: > > > > On Mon, May 22, 2023 at 02:2

Re: [dm-devel] [PATCH v7 0/5] Introduce provisioning primitives

2023-05-26 Thread Joe Thornber
Here's my take: I don't see why the filesystem cares if thinp is doing a reservation or provisioning under the hood. All that matters is that a future write to that region will be honoured (barring device failure etc.). I agree that the reservation/force mapped status needs to be inherited by sn

Re: [dm-devel] [PATCH v7 0/5] Introduce provisioning primitives

2023-05-26 Thread Brian Foster
On Fri, May 26, 2023 at 07:37:43PM +1000, Dave Chinner wrote: > On Thu, May 25, 2023 at 12:19:47PM -0400, Brian Foster wrote: > > On Wed, May 24, 2023 at 10:40:34AM +1000, Dave Chinner wrote: > > > On Tue, May 23, 2023 at 11:26:18AM -0400, Mike Snitzer wrote: > > > > On Tue, May 23 2023 at 10:05P -

Re: [dm-devel] [PATCH v7 0/5] Introduce provisioning primitives

2023-05-26 Thread Brian Foster
On Thu, May 25, 2023 at 07:35:14PM -0700, Sarthak Kukreti wrote: > On Thu, May 25, 2023 at 6:36 PM Dave Chinner wrote: > > > > On Thu, May 25, 2023 at 03:47:21PM -0700, Sarthak Kukreti wrote: > > > On Thu, May 25, 2023 at 9:00 AM Mike Snitzer wrote: > > > > On Thu, May 25 2023 at 7:39P -0400, >

[dm-devel] [PATCH] dm flakey: introduce the random_read_corrupt and random_write_corrupt options

2023-05-26 Thread Mikulas Patocka
Hi Here I'm sending a new dm-flakey patch. It fixes a bug that table was incorrectly reported in STATUSTYPE_TABLE (the strings "random_read_corrupt" and "random_write_corrupt" were missing). Mikulas From: Mikulas Patocka The random_read_corrupt and random_write_corrupt options corrupt rando

Re: [dm-devel] [PATCH v7 0/5] Introduce provisioning primitives

2023-05-26 Thread Dave Chinner
On Fri, May 26, 2023 at 12:04:02PM +0100, Joe Thornber wrote: > Here's my take: > > I don't see why the filesystem cares if thinp is doing a reservation or > provisioning under the hood. All that matters is that a future write > to that region will be honoured (barring device failure etc.). > >