Re: [dm-devel] [PATCH v7 0/5] Introduce provisioning primitives

On Fri, May 19 2023 at 12:09P -0400, Christoph Hellwig wrote: > FYI, I really don't think this primitive is a good idea. In the > concept of non-overwritable storage (NAND, SMR drives) the entire > concept of a one-shoot 'provisioning' that will guarantee later writes > are always possible is si

Re: [dm-devel] [PATCH v7 1/5] block: Don't invalidate pagecache for invalid falloc modes

On Thu, May 18, 2023 at 03:33:22PM -0700, Sarthak Kukreti wrote: > Only call truncate_bdev_range() if the fallocate mode is > supported. This fixes a bug where data in the pagecache > could be invalidated if the fallocate() was called on the > block device with an invalid mode. > > Fixes: 25f4c414

Re: [dm-devel] [PATCH v7 4/5] dm-thin: Add REQ_OP_PROVISION support

On Thu, May 18 2023 at 6:33P -0400, Sarthak Kukreti wrote: > dm-thinpool uses the provision request to provision > blocks for a dm-thin device. dm-thinpool currently does not > pass through REQ_OP_PROVISION to underlying devices. > > For shared blocks, provision requests will break sharing and

[dm-devel] [PATCH 0/5] multipath: Add a group_by_tgp path grouping policy

This patchset is adds a new path grouping policy that can be used with ALUA devices. The goal is to avoid the temporary incorrect path groupings that can happen when paths change priorities. There is one thing that I'm not sure of. Is there any possiblity of a path device changing the target port

[dm-devel] [PATCH 1/5] libmultipath: add group_by_tpg path_grouping_policy

When we group paths by prio and the priority changes, paths can end up temporarily in the wrong path groups. This usually happens when some paths are down, so their priority can't be updated. To avoid this for ALUA paths, group them by their target port group instead. The path groups chosen by thi

[dm-devel] [PATCH 2/5] libmultipath: don't copy pgpolicy string in get_pgpolicy_name

copying the value into a passed in buffer doesn't help any of the callers of this function. It's just wasted work. Signed-off-by: Benjamin Marzinski --- libmultipath/dict.c | 6 +- libmultipath/pgpolicies.c | 27 --- libmultipath/pgpolicies.h | 2 +- libmultip

[dm-devel] [PATCH 3/5] libmultipath: add ALUA tpg path wildcard

Make it possible to easily check a path's target port group. Signed-off-by: Benjamin Marzinski --- libmultipath/print.c | 9 + 1 file changed, 9 insertions(+) diff --git a/libmultipath/print.c b/libmultipath/print.c index 3193dbe0..360308d2 100644 --- a/libmultipath/print.c +++ b/libmul

[dm-devel] [PATCH 4/5] multipath-tools tests: add tests for group_by_tpg policy

Signed-off-by: Benjamin Marzinski --- tests/pgpolicy.c | 201 +++ 1 file changed, 201 insertions(+) diff --git a/tests/pgpolicy.c b/tests/pgpolicy.c index 43be831f..85fa30ce 100644 --- a/tests/pgpolicy.c +++ b/tests/pgpolicy.c @@ -32,6 +32,15 @@ struct

[dm-devel] [PATCH 5/5] libmultipath: add "detect_pgpolicy" config option

This allows configuations to use "group_by_tpg" if alua is autodetected and another policy if it isn't, so they can work with detect_prio. Signed-off-by: Benjamin Marzinski --- libmultipath/config.c | 2 ++ libmultipath/config.h | 2 ++ libmultipath/configure.c

Re: [dm-devel] [PATCH v7 0/5] Introduce provisioning primitives

On Fri, May 19, 2023 at 10:41:31AM -0400, Mike Snitzer wrote: > On Fri, May 19 2023 at 12:09P -0400, > Christoph Hellwig wrote: > > > FYI, I really don't think this primitive is a good idea. In the > > concept of non-overwritable storage (NAND, SMR drives) the entire > > concept of a one-shoot '