Re: [dm-devel] [PATCH v5 00/20] bio: check return values of bio_add_page

2023-05-05 Thread Johannes Thumshirn
On 02.05.23 12:20, Johannes Thumshirn wrote: > We have two functions for adding a page to a bio, __bio_add_page() which is > used to add a single page to a freshly created bio and bio_add_page() which is > used to add a page to an existing bio. > > While __bio_add_page() is expected to succeed, bi

Re: [dm-devel] [PATCH v5 00/20] bio: check return values of bio_add_page

2023-05-05 Thread Jens Axboe
On 5/5/23 2:09?AM, Johannes Thumshirn wrote: > On 02.05.23 12:20, Johannes Thumshirn wrote: >> We have two functions for adding a page to a bio, __bio_add_page() which is >> used to add a single page to a freshly created bio and bio_add_page() which >> is >> used to add a page to an existing bio.

Re: [dm-devel] [PATCH v6 08/12] x86/PM/keylocker: Restore internal wrapping key on resume from ACPI S3/4

2023-05-05 Thread Eric Biggers
On Mon, Apr 10, 2023 at 03:59:32PM -0700, Chang S. Bae wrote: > +/* > + * This flag is set with IWKey load. When the key restore fails, it is > + * reset. This restore state is exported to the crypto library, then AES-KL > + * will not be used there. So, the feature is soft-disabled with this flag.

Re: [dm-devel] [PATCH v6 07/12] x86/cpu/keylocker: Load an internal wrapping key at boot-time

2023-05-05 Thread Eric Biggers
On Mon, Apr 10, 2023 at 03:59:31PM -0700, Chang S. Bae wrote: > diff --git a/arch/x86/include/asm/keylocker.h > b/arch/x86/include/asm/keylocker.h > index e85dfb6c1524..820ac29c06d9 100644 > --- a/arch/x86/include/asm/keylocker.h > +++ b/arch/x86/include/asm/keylocker.h > @@ -5,6 +5,7 @@ > > #i

Re: [dm-devel] [PATCH v6 10/12] crypto: x86/aes - Prepare for a new AES implementation

2023-05-05 Thread Eric Biggers
On Mon, Apr 10, 2023 at 03:59:34PM -0700, Chang S. Bae wrote: > Refactor the common C code to avoid code duplication. The AES-NI code uses > it with a function pointer argument to call back the AES-NI assembly code. > So will the AES-KL code. Actually, the AES-NI XTS glue code currently makes dire

Re: [dm-devel] [PATCH v6 11/12] crypto: x86/aes-kl - Support AES algorithm using Key Locker instructions

2023-05-05 Thread Eric Biggers
On Mon, Apr 10, 2023 at 03:59:35PM -0700, Chang S. Bae wrote: > [PATCH v6 11/12] crypto: x86/aes-kl - Support AES algorithm using Key Locker > instructions Thanks for dropping the unnecessary modes of operation (CBC, ECB, CTR). It simplified the patchset quite a bit! Now that only AES-XTS is in

Re: [dm-devel] [PATCH v5 4/5] dm-thin: Add REQ_OP_PROVISION support

2023-05-05 Thread Sarthak Kukreti
On Mon, May 1, 2023 at 12:15 PM Mike Snitzer wrote: > > On Wed, Apr 19 2023 at 8:48P -0400, > Sarthak Kukreti wrote: > > > dm-thinpool uses the provision request to provision > > blocks for a dm-thin device. dm-thinpool currently does not > > pass through REQ_OP_PROVISION to underlying devices.